From patchwork Tue Dec 1 00:46:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 11941701 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1755C64E90 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78F2320857 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f2llBGEV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389167AbgLAArk (ORCPT ); Mon, 30 Nov 2020 19:47:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389163AbgLAArk (ORCPT ); Mon, 30 Nov 2020 19:47:40 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18DD5C0613D2 for ; Mon, 30 Nov 2020 16:46:54 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id x16so9515oic.3 for ; Mon, 30 Nov 2020 16:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DopMMy+2qUcp0dkDTtyCKQQ8s1AtEjNmYwhRWV0mMFI=; b=f2llBGEVzDaEOPVthXS8GcIEf9ylUFdfnltMSQCd0ye/B5ESXfZGkwmHTMGy9YEDad 7Oq0jF4QGJ26iUfGgVr5uIX0s6tm1XHvO74pR//HoNKucSCjScAXcw2wDAfbuZYnpmQd ZtSbvbVL0n0vKqDsdrfzyaudiravX9y0OoE9jFsiZbqGZ8inc2e+D5yIjU6ml3fhQFiY lMnX/cBcR6JdnKxqk/uvJtv+j+rtUHmc6nz5ohEuxGelVRWodIQPNyfUw6zhoAsd+IWf yiCai+voPlJ1ZJJUiyYg+MwfxbeS5eAtbkIezx0HAqmzAvDXtvsAqTs7tiRECjdy3dIc m0pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DopMMy+2qUcp0dkDTtyCKQQ8s1AtEjNmYwhRWV0mMFI=; b=rFthTq/IPmGtNrLltOGPoefuW5/CIcvV1cyzuAGpDR8mMzlKiOLnRFJH6NLeqJF16A Tygm81vz6g8r/Sf+kiN7UR77aWeVAVRjB4+T481xVNkRBLr+REmdT/v9HZBlHibeJQrz KL5QOzGqL5p88ZPfqHEgktuDfB2/cnVibw9gZQ3Q3+tVeT4dl2Ll4dgk7ZI06x2hT1vZ idnRomFM5eMD5CoTI1bGKP0qLeDCsKsmfwludBg/eeMiqyOH4R9cUaptdWOzrYiZJgEi KSUcVxl3pqYwgActYAZmMeAVG7p+rIpDUY+PJjhEfPhBgrOusXeqhEgfQIUA4A7McpvN awVg== X-Gm-Message-State: AOAM533dtL5ng4T5X+V3GveakMkmY3+d9VJvafO2AaaN7Cz4a9Sic1It Fn4D57k96Gqw2DYnHpQCyjLIJgDzbM/t5g== X-Google-Smtp-Source: ABdhPJyva2RxvCjdGDwjvRt8SQ8bPLq/S6onbbTlTqXI9urzvRZLgvuB9YbepHTTszCtahpr1i1FiA== X-Received: by 2002:a54:4608:: with SMTP id p8mr182996oip.5.1606783613290; Mon, 30 Nov 2020 16:46:53 -0800 (PST) Received: from localhost (189-209-26-110.static.axtel.net. [189.209.26.110]) by smtp.gmail.com with ESMTPSA id d32sm6619otb.24.2020.11.30.16.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 16:46:52 -0800 (PST) From: Felipe Contreras To: git@vger.kernel.org Cc: Junio C Hamano , Felipe Contreras Subject: [PATCH 1/4] refspec: trivial cleanup Date: Mon, 30 Nov 2020 18:46:46 -0600 Message-Id: <20201201004649.57548-2-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201004649.57548-1-felipe.contreras@gmail.com> References: <20201201004649.57548-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org We can remove one level of indentation and make the code clearer. So why not do so? No functional changes. Signed-off-by: Felipe Contreras --- refspec.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/refspec.c b/refspec.c index c49347c2d7..d4823dbff9 100644 --- a/refspec.c +++ b/refspec.c @@ -272,15 +272,16 @@ void refspec_ref_prefixes(const struct refspec *rs, else if (item->src && !item->exact_sha1) prefix = item->src; - if (prefix) { - if (item->pattern) { - const char *glob = strchr(prefix, '*'); - strvec_pushf(ref_prefixes, "%.*s", - (int)(glob - prefix), - prefix); - } else { - expand_ref_prefix(ref_prefixes, prefix); - } + if (!prefix) + continue; + + if (item->pattern) { + const char *glob = strchr(prefix, '*'); + strvec_pushf(ref_prefixes, "%.*s", + (int)(glob - prefix), + prefix); + } else { + expand_ref_prefix(ref_prefixes, prefix); } } } From patchwork Tue Dec 1 00:46:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 11941705 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17105C71156 for ; Tue, 1 Dec 2020 00:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C572020809 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t0ftu6Nn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729716AbgLAArq (ORCPT ); Mon, 30 Nov 2020 19:47:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389163AbgLAArm (ORCPT ); Mon, 30 Nov 2020 19:47:42 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9A72C0613D3 for ; Mon, 30 Nov 2020 16:46:55 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id o25so16375489oie.5 for ; Mon, 30 Nov 2020 16:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1g5xme2kvGlgzs6jtn9FfjzffOMoj1QipCaxtjl+0HA=; b=t0ftu6NnWJFupT70OvWsqs7OSZ/aV5t6l25Xoq0Tb6MmjQMjdyRsUH5WC7vjVHP4Pw RoZTePFLVcoxudvaiYonp8ICODH2zRd793YazE3T2tR3xmOEQ+JE9DpMmKpcpc2mOsaV LWnho81zuxzslCeJQjV+m0FcgnYoAlUmA5VIuXg1kyRh72+P4coJj5ttdAuCZYCLuVak sJx6bGSDF1uSUr9kECyhQSZ6XD8WGKAp0n0fDB6lKShmGbroXJzO/comMq7wBf9V4FwT dnYjuylDlaoiseyXiQEpOzgaQdwxAKDj1jdYVJw9jdqGWWGpUQJ4Pn28UYF11QN/0s1U pohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1g5xme2kvGlgzs6jtn9FfjzffOMoj1QipCaxtjl+0HA=; b=QjAil2cAHehFqMXRdjYMfuS7KH6cSoToP3fPbOHED66E0hHvgjzav+uD+dwAVT2t9H JOThsl7bP+r1E4Y/dJ+n9UQIZSWZZDKdJe/Jf2kJRneNErJCwfkcRjTBpUl4OqZmcng8 jSSiEMHOBok7uNEqvBxFBVt3Ix0rTdLr2gutmvDJWUM+bIJnoH9TqN/9Hp+7dPgr8t1K lFDh7qUnMbOfUcK1DGxPudcNtDpAToAatvngGVKLDQ34cszveNLZ7peW/eBULq5nX0xX 9jWjJHAEqn3HFbmDL1R3Rm762CvVAunN5qQRaJLeutTtcwALTG3N2p9XsEACOx0z/vm9 DDsw== X-Gm-Message-State: AOAM533CJBiFqU5X9IOLOBkoYVX31bbr4EMBB+TunBgA3bRbJqsHx895 N/m9rqA1o+8O5i8DwQY8uGqRbrsAJ4pumA== X-Google-Smtp-Source: ABdhPJzjxhjQhC16SfZFdBt5TTCTkmhpilyITgwo5PrtlSa0qNB8m9kWliYsIhjoRlNbCkv6mOBmKg== X-Received: by 2002:aca:fd86:: with SMTP id b128mr167260oii.103.1606783615043; Mon, 30 Nov 2020 16:46:55 -0800 (PST) Received: from localhost (189-209-26-110.static.axtel.net. [189.209.26.110]) by smtp.gmail.com with ESMTPSA id p28sm10633ots.0.2020.11.30.16.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 16:46:54 -0800 (PST) From: Felipe Contreras To: git@vger.kernel.org Cc: Junio C Hamano , Felipe Contreras Subject: [PATCH 2/4] .gitignore: remove dangling file Date: Mon, 30 Nov 2020 18:46:47 -0600 Message-Id: <20201201004649.57548-3-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201004649.57548-1-felipe.contreras@gmail.com> References: <20201201004649.57548-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The library was removed 7 years ago on commit ae34ac126f. But not from the .gitignore file. Signed-off-by: Felipe Contreras Signed-off-by: Jeff King --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index f85d02c854..7c5096aee5 100644 --- a/.gitignore +++ b/.gitignore @@ -135,7 +135,6 @@ /git-remote-ftps /git-remote-fd /git-remote-ext -/git-remote-testpy /git-repack /git-replace /git-request-pull From patchwork Tue Dec 1 00:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 11941707 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F04C71155 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E71B2085B for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h9kNaIhm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389178AbgLAArq (ORCPT ); Mon, 30 Nov 2020 19:47:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389173AbgLAArn (ORCPT ); Mon, 30 Nov 2020 19:47:43 -0500 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEABDC0613D4 for ; Mon, 30 Nov 2020 16:46:57 -0800 (PST) Received: by mail-ot1-x32a.google.com with SMTP id z23so44750oti.13 for ; Mon, 30 Nov 2020 16:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GpDKWpGHKGXx8b7pLO8/lRpGqgffZf2XNHl7r3qXpf4=; b=h9kNaIhmy3DDcIZ+NSB0oGn4RTeVm3R1hd8V7cn96T5ATGrDhC7rd1KNf7dUOM7XRA IUt6t2qrVb+ptyq2EBTyl11XlDzJ7/LZFgg0PA5rUFsJvQmD69DuWUShWx0dLqPxa3wz 9tVUCkPZO70sD99bxAveGSz7tbrXWE6+wJih5iLCOqDtnRVWJruAqgBNQCJjdWxi5FJ+ 6CvsqtAstp2oKo9bQH1UEJ9hJOM539YCyv5RJPbiNyQjRb9hUE16xL62uisHoSPN2TOq 8JY3i1szXmvJ8COYDIc1w43MIQwt3YT4viMjidPJfIfaGKYWVv/GBfb/jynWX0hFXYky Y1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GpDKWpGHKGXx8b7pLO8/lRpGqgffZf2XNHl7r3qXpf4=; b=uMyRedl6/jBTynUhf3xVy4WbAWMCJYQgy7wozbG8v55Be9gnBL0SNRD0L/oAApoiaZ PxeryCHsjMB/sJ151lZYhL+n/AwsIk3wvrFEwUKKX6R8OF9SYlPyDZvi8hXHO5fmzhBy YFiAKOfOVIKcaPzxLY4ZaSO4yzDMkLHc2BHHOJv3gusXmxIQ0ipQBER51hw4Kr2pf9Os RZD20SfatiezfhHrZKv9qvHFMHZGjrKJsVj98puSBMq5Y0MmeSwLclvurvxxgzUdhQCj abYc1+HhLc81+s0byYU4MO0mVJ7vEycZ9u0MyiI4sHZKdfrvpE+M9fU7TATgDqDEk9Q2 V8pA== X-Gm-Message-State: AOAM533jG51kUnfyFYI8zD8vMwURHF3e0aWyPda4+wStnEDYHqUNkXDj jY0OVUyl0zxreNR8Zzsw5MJX0tGS+BLEjw== X-Google-Smtp-Source: ABdhPJworKnJ1aLB520+THXUvVOardxP9EksAWGIybbPXnAR/ZQgxFPu3w0/WzejhmD4SSvAk23j0A== X-Received: by 2002:a9d:7a97:: with SMTP id l23mr108531otn.232.1606783616924; Mon, 30 Nov 2020 16:46:56 -0800 (PST) Received: from localhost (189-209-26-110.static.axtel.net. [189.209.26.110]) by smtp.gmail.com with ESMTPSA id h17sm52670oor.1.2020.11.30.16.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 16:46:56 -0800 (PST) From: Felipe Contreras To: git@vger.kernel.org Cc: Junio C Hamano , Felipe Contreras Subject: [PATCH 3/4] test: completion: fix typos Date: Mon, 30 Nov 2020 18:46:48 -0600 Message-Id: <20201201004649.57548-4-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201004649.57548-1-felipe.contreras@gmail.com> References: <20201201004649.57548-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Felipe Contreras --- t/t9902-completion.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 5c01c75d40..81a728c743 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -906,7 +906,7 @@ test_expect_success '__git_refs - after --opt= - full refs' ' test_cmp expected "$actual" ' -test_expect_success '__git refs - exluding refs' ' +test_expect_success '__git refs - excluding refs' ' cat >expected <<-EOF && ^HEAD ^master @@ -922,7 +922,7 @@ test_expect_success '__git refs - exluding refs' ' test_cmp expected "$actual" ' -test_expect_success '__git refs - exluding full refs' ' +test_expect_success '__git refs - excluding full refs' ' cat >expected <<-EOF && ^refs/heads/master ^refs/heads/matching-branch From patchwork Tue Dec 1 00:46:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 11941699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93919C63777 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 545D520809 for ; Tue, 1 Dec 2020 00:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eyYQQ2Vc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389162AbgLAArj (ORCPT ); Mon, 30 Nov 2020 19:47:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389150AbgLAArj (ORCPT ); Mon, 30 Nov 2020 19:47:39 -0500 Received: from mail-oo1-xc44.google.com (mail-oo1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E6FAC0617A6 for ; Mon, 30 Nov 2020 16:46:59 -0800 (PST) Received: by mail-oo1-xc44.google.com with SMTP id l20so17882oot.3 for ; Mon, 30 Nov 2020 16:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J4ApOr0TN5Ls6zxLxW5FNxUuULjVWpIh3mM0eEFSUWE=; b=eyYQQ2VcHgRlmXckWGooRS+Gt7t4791A0guNvDQEsnmOIxH7sZ93i9Cd2m/qZ3T7jo +UVr+o/8eYYccwZtByaNXAK004nPkClptQXj26I6nGqEjFb/ZwDCnxIrTC9HlaNYBnaK hROMMxJQ+7f7HuVbTX3TBGZbJGj7EhTb2xpKZUwiRTYvKouk8VIGgEzf8SZhZsdKl1Mf JaZboDKwQXsbf+0DXkQ5gCq5Q/i7B5p9sCe74aXJEvwZhGl/FyxhnJVIsVJpbMtFn2Oo HlVgtcdgONJkJGHASp6iqahFOd6WVZYyzazhpbLMzyFcuyO3yksaR8AWE2sytNKpwnjC NxSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J4ApOr0TN5Ls6zxLxW5FNxUuULjVWpIh3mM0eEFSUWE=; b=sjk8LQDcGgBly2cBLGHwpomjijZrLPYlfy3TB+1+HUK7wl2o2sf3o5A4czCAJmwQ7x QXYNxq3m5oKLgEaWb/Nks5+YeX8OoXXwJVrr8kO8+V8AOB63+Cool3NoZgrNXnmPCaE6 v0SXik6WR0+aesBQh5KAi8rKnBFIrUxz290MjojZ2VyIv48jd/9ViNCqL3xVU7yo1CF6 y6AM54yv+lSSzhgubnBKhVT30cG11sH04k9ABPkQ+GqMbflznHsr2IQV7pzySRlPbHw7 5KReqTUKn4ymiT/K8EWComys7L936hXsplEXQrEhXENJCSCXVipBhN68Q7b0Xt4mdwb5 LkJg== X-Gm-Message-State: AOAM531AE0cmxDPtLIWdk9RFcYchIb/xpuLxzjMtmwkrsNABkWNNq/lu 5AEIqE7P3JXUQqgw1QhN1kva1BzO6LDDEg== X-Google-Smtp-Source: ABdhPJxxHsec08digfoAe7ETHJhSV72NmQhiETG+/SYz3IWuZEVJT/ENDnflA9bnXrboJGXb21yu7g== X-Received: by 2002:a05:6820:104d:: with SMTP id x13mr213785oot.41.1606783618634; Mon, 30 Nov 2020 16:46:58 -0800 (PST) Received: from localhost (189-209-26-110.static.axtel.net. [189.209.26.110]) by smtp.gmail.com with ESMTPSA id r4sm996otd.66.2020.11.30.16.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 16:46:58 -0800 (PST) From: Felipe Contreras To: git@vger.kernel.org Cc: Junio C Hamano , Felipe Contreras Subject: [PATCH 4/4] tests: lib-functions: trivial style cleanups Date: Mon, 30 Nov 2020 18:46:49 -0600 Message-Id: <20201201004649.57548-5-felipe.contreras@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201201004649.57548-1-felipe.contreras@gmail.com> References: <20201201004649.57548-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Felipe Contreras --- t/test-lib-functions.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 7ba3011b90..a791f2f1d6 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -955,7 +955,7 @@ test_expect_code () { # - cmp's output is not nearly as easy to read as diff -u # - not all diff versions understand "-u" -test_cmp() { +test_cmp () { eval "$GIT_TEST_CMP" '"$@"' } @@ -968,7 +968,7 @@ test_cmp() { # # test_cmp_config foo core.bar # -test_cmp_config() { +test_cmp_config () { local GD && if test "$1" = "-C" then @@ -984,7 +984,7 @@ test_cmp_config() { # test_cmp_bin - helper to compare binary files -test_cmp_bin() { +test_cmp_bin () { cmp "$@" } @@ -1418,7 +1418,7 @@ nongit () { # whitespace and put in a single packet. Note that data containing NULs must be # given on stdin, and that empty input becomes an empty packet, not a flush # packet (for that you can just print 0000 yourself). -packetize() { +packetize () { if test $# -gt 0 then packet="$*"