From patchwork Tue Dec 1 16:52:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Perret X-Patchwork-Id: 11943311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEFEC64E7B for ; Tue, 1 Dec 2020 16:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F13E820758 for ; Tue, 1 Dec 2020 16:53:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HMRWOVPa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388924AbgLAQxW (ORCPT ); Tue, 1 Dec 2020 11:53:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387795AbgLAQxW (ORCPT ); Tue, 1 Dec 2020 11:53:22 -0500 Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C98FDC0613CF for ; Tue, 1 Dec 2020 08:52:35 -0800 (PST) Received: by mail-ed1-x54a.google.com with SMTP id w24so1649778edt.11 for ; Tue, 01 Dec 2020 08:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=7J2rIU7NG1spfWolovEBqiTIkQod3FyymVw5u4J4xKA=; b=HMRWOVPawresJEri9vwe5OAQkAqTCsl6dlMR+u1UNoDoHH6RbQaUwdgAJ1SQv8Q5bU CqlJP8IK0+UOwr32kekS3X6pe1aKHWUwpycegjqqxbyWASoTk93WCwhUYmRAfGzBMYvf o5dc4oOfy7mUHyhaifj0uAXbH3wH9CSPcUWApGOgzaSE7PUejyhPwvMGLwY0T2DrTrm9 o3UzWmtcFm7U+dXq1pK3QSkrrw8bbiR3resQdt9ATutmPjP5rhXFf2wrkdJCaaKHwL5J P9MlHaihMNzGKvVg3Tl8gYn+6ztJ65RBxTeQrBezks98OgZaJaArdZlQQz0LCrqta5WL Lohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=7J2rIU7NG1spfWolovEBqiTIkQod3FyymVw5u4J4xKA=; b=mvw0nxLWuVF6P09YRQtmKb0XAXXIZkIHhS1NJzRioeh16lkjfYnI0ewYNUGTIwMzKn t3rfHAZ9QYJTXpB2BOG53xhhwRM8f0Suf+N7kdhW1gWUC7lIljN9XXJAacLOnyXav8Yg np4qFWNJUCFI0Q3CElMnySZFhTWJ2OUSZjx1NJvQB2g520TAq5VOvq0ArWnfKP0Yji/k CTQl0bhUGH3q2DCOUuyOsX7D7Hjtlh86KUmHLF3l5yIrZCBUEP6z6g5x/13a8QO8Vxc7 eLROC33SMzF5iRe83fhNeRS8KEOmKnE60xfCWA7PWH337gEeC+RT/RDny0QdfdI/xlLJ WCkg== X-Gm-Message-State: AOAM533RipQBMZMurUUTNrV6YJwVJ+RNDKugiBdOofQNmYTApQu/IqLx /kqWxwTYweM/kyfb425gGH8jlnX58gDJ X-Google-Smtp-Source: ABdhPJxcFEFb3HZPmb7f2rVe8+bDLBadD+Ea3YClzGi0bJXXWHPjBMwHyKyRbk6uMfZoP/zYg/0vOrHFEenm Sender: "qperret via sendgmr" X-Received: from luke.lon.corp.google.com ([2a00:79e0:d:210:f693:9fff:fef4:a7ef]) (user=qperret job=sendgmr) by 2002:a05:6402:143a:: with SMTP id c26mr3846526edx.131.1606841554118; Tue, 01 Dec 2020 08:52:34 -0800 (PST) Date: Tue, 1 Dec 2020 16:52:22 +0000 Message-Id: <20201201165222.2001985-1-qperret@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: [PATCH v2] modpost: turn static exports into error From: Quentin Perret To: masahiroy@kernel.org, michal.lkml@markovi.net Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, kernel-team@android.com, maennich@google.com, Quentin Perret Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the warn() message to error() to make sure this never happens again. Acked-by: Greg Kroah-Hartman Reviewed-by: Matthias Maennich Signed-off-by: Quentin Perret --- v2: now depends on 20201201103418.675850-2-masahiroy@kernel.org --- scripts/mod/modpost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 43e00867623a..5562526c8c32 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2648,9 +2648,9 @@ int main(int argc, char **argv) for (s = symbolhash[n]; s; s = s->next) { if (s->is_static) - warn("\"%s\" [%s] is a static %s\n", - s->name, s->module->name, - export_str(s->export)); + error("\"%s\" [%s] is a static %s\n", + s->name, s->module->name, + export_str(s->export)); } }