From patchwork Fri Dec 4 12:18:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 11951639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE730C4361A for ; Fri, 4 Dec 2020 12:19:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5891122795 for ; Fri, 4 Dec 2020 12:19:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5891122795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cb01DLI6ARybG3Vz4G8GUwwxau/D90pqhua66wX2/ag=; b=rxeZV1R4VaqlGKYk/l5a8aGR5N mKUy/r5xSutOGYv+jT3JtV/R90H8lKnkCyAHzZ1Rrmxny0xxKfaDOnhC4Am5Me+6onG2j5w+EiYfz EeejxM5e34L+/hvDhibI9w4l56vNDMEi8bYtgFx31He4NdeEVhLJrL5THqJSgXzTgsvDYGn1eEEW/ wxBhYBMaz96AsU54O8u25Y1IL60RZt6VXxsHBqvsu5KLiLRogQcV+iv4Fd79B5PlB9aIe5qTPAIii KI8hWmtQb5cWGx9BQiwZbwO3Wpe0ngWdmun1Z6c991WbGV6BSMiZmzV028tVaSX3fjuE4FIRwFjqx 2hrnpI7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klA2P-0006RU-NB; Fri, 04 Dec 2020 12:18:13 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klA2M-0006Pc-7L for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 12:18:11 +0000 Received: by mail-lf1-x142.google.com with SMTP id j205so7348909lfj.6 for ; Fri, 04 Dec 2020 04:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QKh+BEm0Z2hwqewzzroWyDAofQUgJdQkZ+JXiUwPDEU=; b=pZu9FxSWb0qhpn2tILJ8QNQAAOVd2yuPkNWwm+pqgkEFt6pc6Vz6Acf4UYrGpIxlT+ 1HTAp/sNwh8RoKTuJXWF+rSQowE3O1oxfWUVXFiJc1tC2QM37A4arFOkX4K4zS1y3UrA 7Hpwue75hh07cIOm1PTeTQNHv/Qu3Nc6t5EDMwptN2K2CvcWMnuXU1h92VPRm1GgdpQ0 dJ+qkkLDT7tf8SiXZOdlDr5tqcleQbDbjt+O3bPSDo6gPsMhheZaYSanoKvt1dWZ6WDE uyVKDw2ErECXAUMimdLiAVD/4uqVDvQZinJHWbfwkQ87PBaK3Pxjsj/6nB3EmQQyZ2X/ qpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QKh+BEm0Z2hwqewzzroWyDAofQUgJdQkZ+JXiUwPDEU=; b=oZnRwHdSd8PUlGicgNN4QWFmFNUE5nhLbyRTGL8f0M+VPyINAQD6dQRInOHsrK398t wU5QFYRIl/3QuPfTQ6YHAW4hH8z/M6TJGHnseMefENkTrvz9JN3PBMxpVZrm9tSfReCP Zyb72AsVbaKcOArAnTr4V+0R/uGjT6rqIU7HtqlhGYrWi3bppjGlPj0C6f4kwc6DZ90B /VVfkEVaSrD0YSvTboXzZQsideOtDJOAxQ/ri2rq6P1JOSdQM0AknuA3BpbbUZweX71f 3d1C/1mAaiWRZiBiehve6xxqS8wORKPQ3MhP8DFQrB7mUPi8VTDj7fV5dVv08L/Fxwf8 FN3g== X-Gm-Message-State: AOAM530147QDC7g26xuKJ0sUDoTt0BRtDRUmUmCZxxo8AXznfZZTXpm8 c07igVuYhB8Y1v8fzIAlm9kdaw== X-Google-Smtp-Source: ABdhPJz2Cdt4Tpl9onypmtkivvmNIEWmBoOLOR8tvaRInPMfFukDEjGAivVIF1q6f0kGhoFFtOEh7Q== X-Received: by 2002:ac2:41ca:: with SMTP id d10mr3218682lfi.419.1607084286559; Fri, 04 Dec 2020 04:18:06 -0800 (PST) Received: from localhost (c-9b28e555.07-21-73746f28.bbcust.telenor.se. [85.229.40.155]) by smtp.gmail.com with ESMTPSA id c8sm597731lja.103.2020.12.04.04.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 04:18:06 -0800 (PST) From: Anders Roxell To: akpm@linux-foundation.org, glider@google.com, elver@google.com, dvyukov@google.com, catalin.marinas@arm.com, will@kernel.org Subject: [PATCH] kfence: fix implicit function declaration Date: Fri, 4 Dec 2020 13:18:04 +0100 Message-Id: <20201204121804.1532849-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_071810_613810_438D0399 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , linux-arm-kernel@lists.infradead.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When building kfence the following error shows up: In file included from mm/kfence/report.c:13: arch/arm64/include/asm/kfence.h: In function ‘kfence_protect_page’: arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration of function ‘set_memory_valid’ [-Werror=implicit-function-declaration] 12 | set_memory_valid(addr, 1, !protect); | ^~~~~~~~~~~~~~~~ Use the correct include both f2b7c491916d ("set_memory: allow querying whether set_direct_map_*() is actually enabled") and 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") went in the same day via different trees. Signed-off-by: Anders Roxell Reviewed-by: Alexander Potapenko --- I got this build error in todays next-20201204. Andrew, since both patches are in your -mm tree, I think this can be folded into 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") arch/arm64/include/asm/kfence.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/kfence.h b/arch/arm64/include/asm/kfence.h index 6c0afeeab635..c44bb368a810 100644 --- a/arch/arm64/include/asm/kfence.h +++ b/arch/arm64/include/asm/kfence.h @@ -3,7 +3,7 @@ #ifndef __ASM_KFENCE_H #define __ASM_KFENCE_H -#include +#include static inline bool arch_kfence_init_pool(void) { return true; }