From patchwork Sun Dec 6 19:02:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912C0C433FE for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 600D82310B for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727038AbgLFTDm (ORCPT ); Sun, 6 Dec 2020 14:03:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbgLFTDm (ORCPT ); Sun, 6 Dec 2020 14:03:42 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D7C0C0613D1 for ; Sun, 6 Dec 2020 11:03:02 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id o24so12679554ljj.6 for ; Sun, 06 Dec 2020 11:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=awoxLOM24BlPDDqXjccUiIDJsTqNec5B33IQuldBAcA=; b=P5PNaFqQt3Yi6PZWkmUYqAJgQuDA/89Ks30XOudshL9zK381d4NWbc1uodB//UHAfc HTvn64yb6lGi9hcQh9QITUkTv7+fUOaS7TKiKVbVSuKdPrxFND1N3fXGyyEw7nKng+7s +mf+kOMFsoBz/AElgTQboTbNhPzEgGAzuHyrT8cJ0S0zxOqEFPBXjUl8emTYeZu97F4A laCvoGTSEqnMc08Y40jy5iVbAC86aMm8Xs54zO1wU4rnMsFRsk8/eUiYNxBqfyzpYpiT vYJe6IToXWhfEKlCngFRlpJcolu6GUdOlepGDbYPvysd6DwHh3Fr467MliJ9uYaqKsVQ P54A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=awoxLOM24BlPDDqXjccUiIDJsTqNec5B33IQuldBAcA=; b=jQwnvWZFDqbVY2DFeFhFbdxkRjdF8piaXH6uBKivSipud/hWFLSl/FrxvyBQGj2I5v MiyeRW0UByPaTqh9wpjRRBwsblzfoR+92z0qDCi3F5SN9hOj78n1mth11fqbTuhpvfKi +bVZMF5lPfxBEqmrXE0FjxYCgZXVhCvqWuMugc9P+1Bcc2RlByzFedXruXAdnAj/gOFh DSLQR2vlohLMpWba08QufNpYnUgbCpqNe9D1hFlsHeH7sdIeBZ70AihYAL07zwiO9m+K U5uTgZWcquJrBETcg5l5SEcZSkAGC0T0vln+9NAqnsrctIU+YUZTQvIc3tXeLGGji9hL zBHw== X-Gm-Message-State: AOAM532atqcvwJLEZvuwX3FHxzEM/Z23d9ooZ6KdjtCNTqVNG9M6QmWM xEg3BvcMt+R4BT7iR9xjUCmea/LTzRHlmA== X-Google-Smtp-Source: ABdhPJwFKM/Zl7jOyF45tkIXB6X8zzxGd1xx4NWx6nsFo3s5UcMXstc7DIYYaoWF/J47Mjh04zw6vw== X-Received: by 2002:a2e:a40e:: with SMTP id p14mr4886244ljn.63.1607281380392; Sun, 06 Dec 2020 11:03:00 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:02:59 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk , Ferenc Bakonyi , linux-nvidia@lists.surfsouth.com Subject: [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings Date: Sun, 6 Dec 2020 20:02:35 +0100 Message-Id: <20201206190247.1861316-2-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix kernel-doc comments. v2: - Updated subject (Lee) v3: - Add space after ':' (Randy) - Fix name of function in comment Signed-off-by: Sam Ravnborg Cc: Ferenc Bakonyi Cc: linux-nvidia@lists.surfsouth.com Cc: Lee Jones Acked-by: Randy Dunlap --- drivers/video/fbdev/hgafb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c index a45fcff1461f..8bbac7182ad3 100644 --- a/drivers/video/fbdev/hgafb.c +++ b/drivers/video/fbdev/hgafb.c @@ -357,8 +357,8 @@ static int hga_card_detect(void) /** * hgafb_open - open the framebuffer device - * @info:pointer to fb_info object containing info for current hga board - * @int:open by console system or userland. + * @info: pointer to fb_info object containing info for current hga board + * @init: open by console system or userland. */ static int hgafb_open(struct fb_info *info, int init) @@ -370,9 +370,9 @@ static int hgafb_open(struct fb_info *info, int init) } /** - * hgafb_open - open the framebuffer device - * @info:pointer to fb_info object containing info for current hga board - * @int:open by console system or userland. + * hgafb_release - open the framebuffer device + * @info: pointer to fb_info object containing info for current hga board + * @init: open by console system or userland. */ static int hgafb_release(struct fb_info *info, int init) From patchwork Sun Dec 6 19:02:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9F2C4167B for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A863A2310B for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgLFTDu (ORCPT ); Sun, 6 Dec 2020 14:03:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgLFTDt (ORCPT ); Sun, 6 Dec 2020 14:03:49 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 971C7C0613D2 for ; Sun, 6 Dec 2020 11:03:03 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id r24so14873261lfm.8 for ; Sun, 06 Dec 2020 11:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AWKed4odfdsIU5AGoPrFhmgmtEnPpwRuMDNnFb1mat8=; b=BD38NveQzbi0GZYDlRS4ddm+TOpNJuvzIK01AZxXT3QyMCEPJ4dI5vbixKjs17NbNB 64eAdShaMM/tV24LtAnyv5OASJu+J6B5OKMKormP1iPZXTd5mQPycd9PKBAGNwtvQzEj P3tctVPAhd0gQAhLn533Y/KZQLpN+7LaC17r0O+xQJaFJ/0LpWlN8LX/X0CLAMgyP/44 8N9p9sAgWvVTT57VjRJEbZJpIUBDWzVooUnWcJm3hrZKWKi8KHlAw/B+f5BOawWAHaYV 0fBNuY9Wv1RalrCsxj/ueAjI1XFkmU2rTpLi517r2HfYn04yjxOoSDTu83YsvHeFXHjv EBww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=AWKed4odfdsIU5AGoPrFhmgmtEnPpwRuMDNnFb1mat8=; b=EjWvgJQej4Hex1J+jdPecFnR/siTbmg4UJFZICVWJMVkw2ljMN6t4JdOBg/F5FPwkp vdgrbYYi2yeLsD7LcNA9qv9B6amDBJSEdbNjJtoQx5ux09kmVxqxKrMfN4m8Bvh1WKKj PpLiJ73QAL/Yo5usNXT5dEvMMcPdMm/Jota9jcsyRq9+XTD83ugJuLwSF5Z5txmqwIQs SUrKomACoKFD1cyhgJAe54nfe4XYkC8+fIddVaC0wyQywT1rv2nvdUHIkH/ErRZacK5K DelIKtZBWWPigyl/cezo7NabzLM4DyxqEY9DFoyHIPkzgQZwmtnMDglfG9mIoSttKV1G 0kBw== X-Gm-Message-State: AOAM5304VwSp+ysqWVqxwurDaCKyz/ww9mV5oStDI/IHOAs9K0ZrYosr pgD7JF2pZJ62c5XPnYAWi6wB9hwlZvjQgg== X-Google-Smtp-Source: ABdhPJxMMFbAmqvduYmjI39HUAlAX90pPZ/380NwlD2kk4yJ4yuH78VuVYftT/yg8SyxScng+YNcqQ== X-Received: by 2002:ac2:46ef:: with SMTP id q15mr6523183lfo.2.1607281381884; Sun, 06 Dec 2020 11:03:01 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:01 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify Date: Sun, 6 Dec 2020 20:02:36 +0100 Message-Id: <20201206190247.1861316-3-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix kernel-doc warnings reported when using W=1 v2: - Improve subject (Lee) v3: - Add RETURNS documentation (Thomas) Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Sam Ravnborg Cc: Randy Dunlap Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter Cc: "Alexander A. Klimov" Acked-by: Randy Dunlap --- drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++ drivers/video/fbdev/core/fbmon.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c index 74c2da528884..4e39c61fae1f 100644 --- a/drivers/video/fbdev/core/fb_notify.c +++ b/drivers/video/fbdev/core/fb_notify.c @@ -19,6 +19,9 @@ static BLOCKING_NOTIFIER_HEAD(fb_notifier_list); /** * fb_register_client - register a client notifier * @nb: notifier block to callback on events + * + * RETURNS: + * 0 on success, negative error code on failure. */ int fb_register_client(struct notifier_block *nb) { @@ -29,6 +32,9 @@ EXPORT_SYMBOL(fb_register_client); /** * fb_unregister_client - unregister a client notifier * @nb: notifier block to callback on events + * + * RETURNS: + * 0 on success, negative error code on failure. */ int fb_unregister_client(struct notifier_block *nb) { @@ -38,7 +44,11 @@ EXPORT_SYMBOL(fb_unregister_client); /** * fb_notifier_call_chain - notify clients of fb_events + * @val: value passed to callback + * @v: pointer passed to callback * + * RETURNS: + * The return value of the last notifier function */ int fb_notifier_call_chain(unsigned long val, void *v) { diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 1bf82dbc9e3c..b0e690f41025 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c @@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block, * fb_create_modedb - create video mode database * @edid: EDID data * @dbsize: database size + * @specs: monitor specifications, may be NULL * * RETURNS: struct fb_videomode, @dbsize contains length of database * @@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres) * 2 * M * M = 300; * C = 30; - */ static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres) { From patchwork Sun Dec 6 19:02:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE59C19425 for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 921CD23123 for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727135AbgLFTDq (ORCPT ); Sun, 6 Dec 2020 14:03:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbgLFTDp (ORCPT ); Sun, 6 Dec 2020 14:03:45 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C127C0613D3 for ; Sun, 6 Dec 2020 11:03:05 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id u19so14884916lfr.7 for ; Sun, 06 Dec 2020 11:03:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tdC3cUaEksOqJq+sL/p6xZwzgeMpzcgI0nIv+Qg+xyQ=; b=LCBIul2FmmPrZESM+8qeYwN4OpnDb/dxDTYb/TiWt4o7mkEP7BJ4PlysJm6Y5kv6cm 2yPblL1lGNYWg1YGC9G+7m6Co8kBZFPZLz2Uy3dbDRkCPrSEPMecaLr81BdW5cD7mB1P va/jfswFmn5bqS10GISBYJlGnsk3XnjICDxGoZsbFcgfL1Sf+6hViT6mpO+37EYQxVor 9+N0WtMJB9YjvTfQ9Wj1wNO0ok/4BmtLr9CQJ4/FyRaZKlHq9kjVUIQmCNdFBqfGh8l5 sKeTwGF96uqPdP4j46KjJrJlY4JDDVT1N28YO6RznAQVKa7gkckmUdT1nySCBt2pWgco ewew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=tdC3cUaEksOqJq+sL/p6xZwzgeMpzcgI0nIv+Qg+xyQ=; b=oGlEpQRDFjw4J6bP73du3iOU4iDBiUtfIVO+cs/v0thN2N3AAaGSK3a5pE1M0wajvs RB41Zo6iaaFWglGJZ1DZ1Rcp5x+3ShCcDmlRtZGoTPQCYqHIpXKMdDMnDKj4GbcHirkH UwDJ8PNDd5fMzrgEO30+3Bb9FGmawETs7yy79ik5AdyVLQfu0YXqvhkRuX63ECNMfyDj ydfmENHm8arfcNMkNQPgRdDm0GdVi80+3jLQeSANZP3nW5tTdSsHN20T/6QL4XRr3XoJ Z8LTlTe5SzzBuRKSevhUsgc2xQn7Dd55FKrpxdtFe9foXSGXH4g+OMe7b/womi4ujBVM vEYg== X-Gm-Message-State: AOAM530xH6cqSKB8IwnUkHddNIr0R9s+9hkhd1snENYvmmueTX+FP2Xu U8BF2JmCAenJCGGSTdl0ZgkTe5tU0q1uyw== X-Google-Smtp-Source: ABdhPJzbrijhCUfWaTPNks1kyBh2XAUFgM6PlyUutCGUNASmv4YuSYakKEIu1GH46R6if5yf5aFAbA== X-Received: by 2002:a05:6512:1112:: with SMTP id l18mr7344980lfg.538.1607281383548; Sun, 06 Dec 2020 11:03:03 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:03 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core Date: Sun, 6 Dec 2020 20:02:37 +0100 Message-Id: <20201206190247.1861316-4-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix a few W=1 warnings about unused assignments. Drop the unused error code. v2: - Subject updated (Lee) Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Qilong Zhang Cc: "Alexander A. Klimov" Cc: Daniel Vetter Cc: Lee Jones Acked-by: Thomas Zimmermann --- drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++-- drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c index 726c190862d4..e6363a420933 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c @@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, struct hdmi_audio_format audio_format; struct hdmi_audio_dma audio_dma; struct hdmi_core_audio_config acore; - int err, n, cts, channel_count; + int n, cts, channel_count; unsigned int fs_nr; bool word_length_16b = false; @@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, return -EINVAL; } - err = hdmi_compute_acr(pclk, fs_nr, &n, &cts); + hdmi_compute_acr(pclk, fs_nr, &n, &cts); /* Audio clock regeneration settings */ acore.n = n; diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c index eda29d3032e1..cb63bc0e92ca 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c @@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, struct hdmi_audio_format audio_format; struct hdmi_audio_dma audio_dma; struct hdmi_core_audio_config core_cfg; - int err, n, cts, channel_count; + int n, cts, channel_count; unsigned int fs_nr; bool word_length_16b = false; @@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp, return -EINVAL; } - err = hdmi_compute_acr(pclk, fs_nr, &n, &cts); + hdmi_compute_acr(pclk, fs_nr, &n, &cts); core_cfg.n = n; core_cfg.cts = cts; From patchwork Sun Dec 6 19:02:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4CCDC1B0D8 for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE5CC2333D for ; Sun, 6 Dec 2020 19:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbgLFTDy (ORCPT ); Sun, 6 Dec 2020 14:03:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbgLFTDx (ORCPT ); Sun, 6 Dec 2020 14:03:53 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00AF0C0613D4 for ; Sun, 6 Dec 2020 11:03:07 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id d20so14848851lfe.11 for ; Sun, 06 Dec 2020 11:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UOGcGZuV1pDdyacp1Yj7CCfxSkcEGtk2M7nbhP+rzwQ=; b=W4gYsSCFlMC3r/LTQSkwP0qTVDk1kJpWLdduH1jLyAqllGVDMYSQtNHD4blw1N+er2 BugriDhBiTiR7o1RzujF9NtuuU75bkJ/e1zB98RoTOdqONoDAQjpknt9NtEy0ztGO+Z/ y0S6SzoEbDhGl5nvhjjQi380hT99I/TFRGMDxK0NV7z8+vp1An2ttsBS7tU/dEoHTVJe ImwLOV15MWtZB1Vd6wFU7zHTj1P+UjwUUsxnpSrsz3wDH96Uy4CQSzco7ZyQGkY9zI1F qPX/ubbUWILv3tp4AgxnyahY1Y7CDdN1qyjxUQFsTF7qKlWJ4Mup+ExozfOVk0FioVe8 odMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UOGcGZuV1pDdyacp1Yj7CCfxSkcEGtk2M7nbhP+rzwQ=; b=YhquvzMFecZlvHTBmDThRna2pq4bSgRRi2erXIi6IqXgnZt+Jh9708sqMT2L1JYUih jP1Q5PWZ6v06AzKQ5NAX0XWZTFDkweMKhtJC6AtPY3GxfQwzpRY9xN4GjH1Mv7YeikDk vtpZl9iE9xbUVy1gaIP9RT7ccUryU4TbqpXXXbZPE6AAJhNbW3wd6eT/8raZM4V3qOzC U7IOcaT1hGq3gJeN4OAYCbRnNBvFsNuWOKTFCXU9i2w1dpW/vTNFOwUnE/1UQUOiWClH tCv7yqd3eYdmxrXMJSmkBO/ROVHmJ2MlbrWlM36DCZyxhjOr4BkuxPV0ue1d7lqJwmaN aVRA== X-Gm-Message-State: AOAM533zBxFsKIWE0GZfVXAlVZkoWoIR0Rwp2gzpTfb/rXxkTP1poTXz O/DweS5zXu9MJ89kJ1BA2hEx0JP0l6GpSg== X-Google-Smtp-Source: ABdhPJxsIP6M5qtkKkVSQDTL6GRkXd2Urg3bP3B6nC0o/in7udaqrBXvv8Nl+MDjf6py3v0d86tqOg== X-Received: by 2002:a05:6512:78f:: with SMTP id x15mr7093698lfr.370.1607281385343; Sun, 06 Dec 2020 11:03:05 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:04 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk , Michal Januszewski Subject: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning Date: Sun, 6 Dec 2020 20:02:38 +0100 Message-Id: <20201206190247.1861316-5-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix W=1 warning by deleting unused local variable. v2: - Updated subject (Lee) v3: - Return early in case of an error (Thomas) Signed-off-by: Sam Ravnborg Cc: Michal Januszewski Cc: linux-fbdev@vger.kernel.org Cc: Lee Jones Acked-by: Thomas Zimmermann --- drivers/video/fbdev/uvesafb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 6c9cfab39313..4df6772802d7 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task, task->t.regs.eax = 0x4f0a; task->t.regs.ebx = 0x0; err = uvesafb_exec(task); + if (err) + return err; if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { par->pmi_setpal = par->ypan = 0; From patchwork Sun Dec 6 19:02:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19ABC4361B for ; Sun, 6 Dec 2020 19:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0A5923122 for ; Sun, 6 Dec 2020 19:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbgLFTEX (ORCPT ); Sun, 6 Dec 2020 14:04:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgLFTEW (ORCPT ); Sun, 6 Dec 2020 14:04:22 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C497C061A4F for ; Sun, 6 Dec 2020 11:03:08 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id b4so7268680lfo.6 for ; Sun, 06 Dec 2020 11:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eLxsg7EkjCm+oZc7/H4MeQJFzAKzFuMyJlMAucG5j6M=; b=ILdNiwFfM7J4+SrpF1knMWis/rnjLfkL9BW6opbCU1Tht72uZsNuwawgHaGa/TYKPf uzszEFxJDJHoljJLRysYP0ao1o/tHtZZd7QR4kMaCMZXf3naGJ2ARncpPHw0yQRwyPzf gg8YpdlAHdUuc6y0g726nvK95UCQgpT78x3PC/fAZgYGseaf/YNQ8p3l1n1VrCf7kEst uH81FAX3+vFTNjbGmFRV8NcLQwLM70sDtyAfAlw4toa6bIdQK8MbkzqN4OD8tSDh9Jb0 UT4vJb9IwDqTlso6A9fQtuUqykaBwOa0H/dlMcgUhOiZDeAkhu6PPjI4W1jeoSJU4E6T M4wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=eLxsg7EkjCm+oZc7/H4MeQJFzAKzFuMyJlMAucG5j6M=; b=SBKUWZ7nyT1dZOUnL3Ff+NOz9omVJu/6R0e3FLP99Ct2E7gcegXvQKZ1aepejueJ2i SKB81qe9S7LYI0mEkiKKNrCBG4iFOl3LCPFcj2e4irqEdp8JR7Qurecng7id/PMcsBoT dO1zL3M16OItB9YKbsfsYxbKZuPA3owt2Eb5i7ZkDUREFtmI0DNabJtxpviWkAlI2+FB hP2qX+XE9jCgmRuJyzXoWHchvCiJID6tOebpyfk/G8kPYGOMeOM5Nd6Ri4A3rn7tzq1r B4yLgp2Sp4Q0xbP+qBzICj4uRePttEwDFAlpvux2vMlcunNvOeRn6hi9E0I6ewVdBf6h Og9g== X-Gm-Message-State: AOAM53067fXgZiOzs2V9jeigX3so/Crofth3nnP3SY6iAHu7E93Q4+nd qVwr0v8qCBm3dGl7nX+zNrTE7GqRx2MzUQ== X-Google-Smtp-Source: ABdhPJxnM6yBu1jRcx8Og5RErbaxtRURZRQTgDs7BZFG81dlhoGPg5ALRRskqOrkcPkDhwvsIpFv1g== X-Received: by 2002:a19:23d8:: with SMTP id j207mr4911471lfj.153.1607281386823; Sun, 06 Dec 2020 11:03:06 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:06 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU Date: Sun, 6 Dec 2020 20:02:39 +0100 Message-Id: <20201206190247.1861316-6-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Building fbdev drivers for sh with W=1 produces the following warning: tmiofb.c: In function ‘tmiofb_remove’: tmiofb.c:805:21: warning: variable ‘par’ set but not used This is with allmodconfig and ARCH=sh This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used. Signed-off-by: Sam Ravnborg Cc: Thomas Zimmermann Cc: Lee Jones Cc: Rich Felker Cc: Arnd Bergmann Cc: Geert Uytterhoeven Cc: Mike Rapoport Cc: Kuninori Morimoto Cc: Peter Zijlstra Cc: Sam Ravnborg Cc: Andrew Morton Reported-by: kernel test robot Acked-by: Thomas Zimmermann --- arch/sh/include/asm/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index 6d5c6463bc07..5ad56c6c1e1e 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size, #endif /* CONFIG_HAVE_IOREMAP_PROT */ #else /* CONFIG_MMU */ -#define iounmap(addr) do { } while (0) +#define iounmap(addr) do { (void)addr; } while (0) #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) #endif /* CONFIG_MMU */ From patchwork Sun Dec 6 19:02:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301C4C19425 for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08CF92310B for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727661AbgLFTE3 (ORCPT ); Sun, 6 Dec 2020 14:04:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbgLFTE2 (ORCPT ); Sun, 6 Dec 2020 14:04:28 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB92C061A51 for ; Sun, 6 Dec 2020 11:03:10 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id t22so12714116ljk.0 for ; Sun, 06 Dec 2020 11:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A4gGS7Km1zSYBw+OXt/rDintJ7WruXibpnRy/u4JXrI=; b=fBHDvYnIKyIRCluPZ7LsGvsmKUja4Il5k9Lf5O94usbRxBlR9tUbQ/bj7xs4Y55UDC PvZeuekZWwvbTIMp7AawS+pSAp+ZlvIcgscgg/WgcNch+3jmT4atQ1sTtGh6eV//VdQB ziLw++ePlEDVRPd8H0hEwR7irC/O2fqf7kXXXWFZvuuQnY2bzSnOaVyUfNwpUyOj8Iqm nJ8z2q2Zuhmvpjd6gL6oWRhwHsGqYN87Ci/JK4r1qXZ+TSl8JyNdJhiZWkeMLxKzGFla OtxWhtPzX1VbXj5zHIYjAkGYtm6WPHDpzB7BWdPo73FcGGw52BdocCqVRBON+ZHBAwhM PDzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=A4gGS7Km1zSYBw+OXt/rDintJ7WruXibpnRy/u4JXrI=; b=N73MqG8hESTLOajy72GK/k43qe8Jd+ImOH4KyMVlyDTvv4oFm8WLiPSA5ghLfk0mUg kBg5+ZKZFSqqX6kAdwIGjmFfqbIKTdJSs7678wJo3mrA5VT9gqQklx9VG+g6kSN20XFa A5qcZwpCw4q+m7HdOCsDGhiom2xTJ5v8ZlEILgZpJE+j8PgBWTokE6UhLednR+91/EAY 9FrUQ56s5yu1pBYvA7U6TMiN2ZSiLb5uXTCWARW9RhmN8g/cTsDBERByiBB485XGywAf ih0buFfSvym3gyq7tkJ4aMk3v//CmCPu7x+n9HZVXCwhuQJnYvw7eboNhAXHrRUMsgUd JvJg== X-Gm-Message-State: AOAM532EgFTRf2XTzhiRfzwzdPdYuCrw31l085bXmSF5IVxNjvQQjDCt Q6JYSadS+tujzJ1SgBI0RBYIZbL6qEmDig== X-Google-Smtp-Source: ABdhPJwCMgEC3zvaWm+zhlV8Koc6bx4J+FYHGrzJzPNlmyIbiTwpIPLsURBYMA9deDpFJaDtgElnrw== X-Received: by 2002:a2e:9710:: with SMTP id r16mr6994169lji.462.1607281388344; Sun, 06 Dec 2020 11:03:08 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:07 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode Date: Sun, 6 Dec 2020 20:02:40 +0100 Message-Id: <20201206190247.1861316-7-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix kernel-doc warnings caused by a wrong parameter name blank_mode => blank Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video/fbdev/bw2.c | 2 +- drivers/video/fbdev/cg3.c | 2 +- drivers/video/fbdev/cg6.c | 2 +- drivers/video/fbdev/ffb.c | 2 +- drivers/video/fbdev/leo.c | 2 +- drivers/video/fbdev/p9100.c | 2 +- drivers/video/fbdev/tcx.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/video/fbdev/bw2.c b/drivers/video/fbdev/bw2.c index 0d9a6bb57a09..e7702fe1fe7d 100644 --- a/drivers/video/fbdev/bw2.c +++ b/drivers/video/fbdev/bw2.c @@ -116,7 +116,7 @@ struct bw2_par { /** * bw2_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int diff --git a/drivers/video/fbdev/cg3.c b/drivers/video/fbdev/cg3.c index 77f6470ce665..bdcc3f6ab666 100644 --- a/drivers/video/fbdev/cg3.c +++ b/drivers/video/fbdev/cg3.c @@ -179,7 +179,7 @@ static int cg3_setcolreg(unsigned regno, /** * cg3_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int cg3_blank(int blank, struct fb_info *info) diff --git a/drivers/video/fbdev/cg6.c b/drivers/video/fbdev/cg6.c index a1c68cd48d7e..97ef43c25974 100644 --- a/drivers/video/fbdev/cg6.c +++ b/drivers/video/fbdev/cg6.c @@ -511,7 +511,7 @@ static int cg6_setcolreg(unsigned regno, /** * cg6_blank - Blanks the display. * - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int cg6_blank(int blank, struct fb_info *info) diff --git a/drivers/video/fbdev/ffb.c b/drivers/video/fbdev/ffb.c index 948b73184433..b3d580e57221 100644 --- a/drivers/video/fbdev/ffb.c +++ b/drivers/video/fbdev/ffb.c @@ -667,7 +667,7 @@ static int ffb_setcolreg(unsigned regno, /** * ffb_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int ffb_blank(int blank, struct fb_info *info) diff --git a/drivers/video/fbdev/leo.c b/drivers/video/fbdev/leo.c index 40b11cce0ad6..3eb0f3583f4f 100644 --- a/drivers/video/fbdev/leo.c +++ b/drivers/video/fbdev/leo.c @@ -308,7 +308,7 @@ static int leo_setcolreg(unsigned regno, /** * leo_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int leo_blank(int blank, struct fb_info *info) diff --git a/drivers/video/fbdev/p9100.c b/drivers/video/fbdev/p9100.c index 6da672e92643..4e88a0a195ad 100644 --- a/drivers/video/fbdev/p9100.c +++ b/drivers/video/fbdev/p9100.c @@ -175,7 +175,7 @@ static int p9100_setcolreg(unsigned regno, /** * p9100_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int diff --git a/drivers/video/fbdev/tcx.c b/drivers/video/fbdev/tcx.c index 34b2e5b6e84a..1638a40fed22 100644 --- a/drivers/video/fbdev/tcx.c +++ b/drivers/video/fbdev/tcx.c @@ -196,7 +196,7 @@ static int tcx_setcolreg(unsigned regno, /** * tcx_blank - Optional function. Blanks the display. - * @blank_mode: the blank mode we want. + * @blank: the blank mode we want. * @info: frame buffer structure that represents a single frame buffer */ static int From patchwork Sun Dec 6 19:02:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE59C4167B for ; Sun, 6 Dec 2020 19:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4F6C2310B for ; Sun, 6 Dec 2020 19:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726440AbgLFTEX (ORCPT ); Sun, 6 Dec 2020 14:04:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbgLFTEX (ORCPT ); Sun, 6 Dec 2020 14:04:23 -0500 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9347CC061A52 for ; Sun, 6 Dec 2020 11:03:11 -0800 (PST) Received: by mail-lj1-x242.google.com with SMTP id t22so12714155ljk.0 for ; Sun, 06 Dec 2020 11:03:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q2c8TosX3R/8fyI6+6hbgfajIYltmGAIh3MuAuO3wgI=; b=U8MIJ/hnXOrYJTIg5Ty/f9FVT3L8hXf/9YHCObVYWGeyhdDQDyxfUUfBTi+qMkjNEI OMTiD6lSuOFYPNUnRzv6kA7UjQTaO5R1tVf6tctjhXhObK4IjjAtiEGPkrtqtNGah3nx nit27kclFdW4q+r77Bc9rijfIQBZtU5/yCmxzGAgRBcPA3t3+UWy66kO9NBJ5Q9rom9c F+4stSsq2cJzJbR0dNnOEg9WjpJaFvIHHjP3HnUYTVhyHN/D3V/IfR+HiQx9MvNzhWo0 0QT235RW3/8/oKvO+K8TPKJ7Mrf0FvPUvccFrTjNsdZrFNBYUR+L5iTkIBrehcYMBsgv 8JNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Q2c8TosX3R/8fyI6+6hbgfajIYltmGAIh3MuAuO3wgI=; b=Y1YpRXSkqpJmAzfwkEU+i4Ao9u9phv4FoCzQAcBMWP1t1UV4qbVtLBBy9a3tcyKfdq r/YOWgmuj0kXKAAwPupm92SAy3WOma6NbqLa8iJxbiBXLC8gN8MNAhWRsttVd8aKSqkN 59ai9MlzTpMC0FGNdUzXCeTlg0moChcPkoU/XRL73xlwaqMxF56hrnsHIiS0JD2UNXck zWzvLrRebZdc/NS3el/zeslNqvQha5haOpdjj9QpFNPrHRM9Sqxg+LgHlXFfO1efmoKY 0B2edXhHz72MeoTLkm+B7Vhal/x/raRxMQ8QtaBrPsGP2IWbUZPE2B/Z4rmaybzizZZT NEmA== X-Gm-Message-State: AOAM532+oFMi+iTEhE++LeiPrbzMmSUBtdpS/BeECD8xaMoUbz91bHPJ ph2Ryd3MWUQ4B0NYyL7l2TztbiOl8/1btQ== X-Google-Smtp-Source: ABdhPJwh2HgCsQBPCpyq5dqu0dPDQ9AeMbjlOSyw3cv3zGiXAtMUTvcVRxOeuj+jvb/oXUKuQwIJMw== X-Received: by 2002:a2e:3c15:: with SMTP id j21mr7596976lja.440.1607281389929; Sun, 06 Dec 2020 11:03:09 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:09 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write Date: Sun, 6 Dec 2020 20:02:41 +0100 Message-Id: <20201206190247.1861316-8-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Add missing parameter and drop parameter that is not present Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Andrzej Hajda Cc: Bartlomiej Zolnierkiewicz Acked-by: Thomas Zimmermann --- drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c index 1911a47769b6..16401eb95c6c 100644 --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c @@ -17,8 +17,8 @@ /** * spi_write - write command to the SPI port + * @spi: the SPI device. * @data: can be 8/16/32-bit, MSB justified data to write. - * @len: data length. * * Wait bus transfer complete IRQ. * The caller is expected to perform the necessary locking. From patchwork Sun Dec 6 19:02:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9CEC197BF for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F3BB2310E for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727375AbgLFTE3 (ORCPT ); Sun, 6 Dec 2020 14:04:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727617AbgLFTE3 (ORCPT ); Sun, 6 Dec 2020 14:04:29 -0500 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F36BC061A53 for ; Sun, 6 Dec 2020 11:03:13 -0800 (PST) Received: by mail-lj1-x242.google.com with SMTP id y16so12712701ljk.1 for ; Sun, 06 Dec 2020 11:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9YJ8hNiC7fcBnhr6W4yRKfHMapnKQoLUJY6svzs3To0=; b=LaLHUm1Z4gGqnGZ3KZ7SHqaALYkoq/yZxYDzkQbZYV0PMY0w52MBCPt//V8+5dKQSB g+UgMgIcXOB/tO/E/S/ZOeqmDZyduyPkSz6vCyBp1j0j0R/blDyXa5ncboNUSyWNMmMF 7z4bu82pAwrOMfKemks/fqOWwajOskvq7e+ffV9CjCxa+f0cR7uOpNMx1E+RO/dH8/pA 8ku81TvvuYNVjpeSAv5GkdkAwNrotvjHD2EbOid95GXlW7DZFpHvs5+mNU86MN3GadvI RKAzjz2ik6cq7BN/9mn2RHD6G9PdUsn7mATzpH4xmVpu2xIiZ3Uf98S7duMImpKVvfVl +15g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9YJ8hNiC7fcBnhr6W4yRKfHMapnKQoLUJY6svzs3To0=; b=OplR5t5/Fro9OT3+vK2IjUikfsmXDN+CxDGm01+UhNk5jvwi3FUE43i9yk83H3iFnt bVdhZ/J52IdifGqUw9+YCGdrd6L6efWidkoIFcXOM8yhG27ywEH7E4kEPS3AuhQukpb2 j69BHcGNziZ9MJearzFEUWSr6kOZOP9UxHJ1Uyk+Z2VwiO+k7QXaCHHPJnEnw007D+k8 /CdfTRqoq4kpUDUVgo5OSFAZ3MljsEUTIynQurvs9SZI/YCFzIaWdxNoJxsDQEv4ozyB Lce0pDugNQYbVWC8LFOU4x2fK6ozlWJj757+NzpaQQrEQaeyS/y5UZDR6ziN/xhpXKuJ DnzA== X-Gm-Message-State: AOAM533XRKE8vqA8Zy9qqJqgOhuUfHkic+XQ3gWEe3/KtDf0BBCpMBEC y9RkECx3EkuClDv0DjUOrGGCqdeHV5lzfA== X-Google-Smtp-Source: ABdhPJziPsnplTe7NiMrRGdNc3o7SXo2FpWEV9XqodakF7dSDg151GPsQjMackM7Ag3jGTKj591jlg== X-Received: by 2002:a2e:894b:: with SMTP id b11mr7761708ljk.439.1607281391398; Sun, 06 Dec 2020 11:03:11 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:10 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings Date: Sun, 6 Dec 2020 20:02:42 +0100 Message-Id: <20201206190247.1861316-9-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Include own header to fix "function not declared" warnings. Signed-off-by: Sam Ravnborg Cc: Tony Prisk Cc: linux-arm-kernel@lists.infradead.org Acked-by: Thomas Zimmermann --- drivers/video/fbdev/wmt_ge_rops.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/wmt_ge_rops.c b/drivers/video/fbdev/wmt_ge_rops.c index 2445cfe617a9..42255d27a1db 100644 --- a/drivers/video/fbdev/wmt_ge_rops.c +++ b/drivers/video/fbdev/wmt_ge_rops.c @@ -11,6 +11,7 @@ #include #include #include "core/fb_draw.h" +#include "wmt_ge_rops.h" #define GE_COMMAND_OFF 0x00 #define GE_DEPTH_OFF 0x04 From patchwork Sun Dec 6 19:02:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB49C1B0E3 for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58EFA2310E for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgLFTEc (ORCPT ); Sun, 6 Dec 2020 14:04:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727617AbgLFTEb (ORCPT ); Sun, 6 Dec 2020 14:04:31 -0500 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 787C7C061A54 for ; Sun, 6 Dec 2020 11:03:14 -0800 (PST) Received: by mail-lj1-x242.google.com with SMTP id i15so5315613ljg.9 for ; Sun, 06 Dec 2020 11:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kt+OQKqeEYVX/LquXQdXcmS8yIcFdc6k57DQM+M9oPU=; b=STZEcMk+wb0l3UdJ+w4DLF0jFXx8DnBowF7giFgGM4j8hOag/FpJ3NUdtoZl01umkO CJ0hrczLQanZCBtkp+DClr3pgNMRlx+QAah7U+tqKMY3jNczQ1mp4yq4rk0ZEy66/X4n cKs6U/iRyR8LV0FuqV+zjtW5Bz+LVrTGbXizScvbIJzKOo9oiBDofvUrS/8ph0Mhi9lM 0qke4Q1lpTeGGlUu/5TI+VkjsUjQ05RBsvtLg4khuatGKHZsz2JI0VzkhcG3URBw8dXU g86Z/r2lNjTgeaBoeVYgkTD6QL0youwlGJ4BDPY1ABX1cUNmu8mo2cPuqx8mShfk5yEd Vftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kt+OQKqeEYVX/LquXQdXcmS8yIcFdc6k57DQM+M9oPU=; b=PhS0GtJWjwKAOOm1G/lUSnAbkjnhBSaTmXtpgesIxM2so6BQGrTHCZ6OPmJsXGQNdt TlLqN+Qm8L7MDZRkwhqDP3CnRT07pxhSWUcRqlJNwUZrGifcCvz9JwEdEBfVVP4kfBTW n+EiWtYgHTuwIyQkkpUUjqTGcWgBzage9sbfqsr909KXFhwUeT9A5ntFZlqO4X/LvqAJ kdoHFsPb8n/FY4YKytkIlKgyiZ69oJsnsVWgm36NnAX7Z2IzSy/nXRR32QAYmjVhorOE WP0OJXalxS+ryAwTioElP1tQlQ/Qw1TkHgJhD6JxzDwZMinOB1hPaejUDJGhd/w9fiog e0+g== X-Gm-Message-State: AOAM533qc2aWpJYNYnnkWEIn9idGaaDxSJ/ekgpv8ulE88iOtOipwvoK DSKodtQuGaoDYR8g93B+rTQtvGlPbUv+Jw== X-Google-Smtp-Source: ABdhPJwKtkjVCJWvIkTsbN4Y12+y0IxNqsqpikK8ueZbFLo3Nyh8mSQt2+/iNy4h8gmKIAfP/b+CjA== X-Received: by 2002:a2e:8982:: with SMTP id c2mr7943919lji.121.1607281392832; Sun, 06 Dec 2020 11:03:12 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:12 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning Date: Sun, 6 Dec 2020 20:02:43 +0100 Message-Id: <20201206190247.1861316-10-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The goldfish_fb_acpi_match table is only used with ACPI enabled. Ifdef it out unless it is needed. This is a similar fix to what other acpi drivers do. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video/fbdev/goldfishfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 9c83ec3f8e1f..2b885cd046fe 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c @@ -305,11 +305,13 @@ static const struct of_device_id goldfish_fb_of_match[] = { }; MODULE_DEVICE_TABLE(of, goldfish_fb_of_match); +#ifdef CONFIG_ACPI static const struct acpi_device_id goldfish_fb_acpi_match[] = { { "GFSH0004", 0 }, { }, }; MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match); +#endif static struct platform_driver goldfish_fb_driver = { .probe = goldfish_fb_probe, From patchwork Sun Dec 6 19:02:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954363 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A56BC433FE for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB6D32333F for ; Sun, 6 Dec 2020 19:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbgLFTE0 (ORCPT ); Sun, 6 Dec 2020 14:04:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727375AbgLFTE0 (ORCPT ); Sun, 6 Dec 2020 14:04:26 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E980C061A55 for ; Sun, 6 Dec 2020 11:03:16 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id l11so14938189lfg.0 for ; Sun, 06 Dec 2020 11:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nq89nmYMFAZ5g1yAyMZHjiJetWqkZ/9OgWWUFHRT3b4=; b=WGpgX85MCpBc/yupm9apVzhUhe6pthypjQPG+TqhMPGOxcNMlZbUgD+wg1Dz9WkZ52 vgriXDfWnywMSzvVRm98Or4TXWqplwssuHvJWhqEJlz/RY0tbBcVQYoUNBe1Ci6jflLr 8gY3anClfRCFGPXzpqZjvmL2R+mgwYrBlDTHfC05x5eTOaodG0nDmLYOfOju5EIxSXn1 ZfRFbvHkGRzw2FnOdGO64khY4a2egIHyqxk6nkb58s+bIHI2TmpmbDBeP0MachGsWcTV 4J4WxRLcP6p9CMZds7niw/z1J35TMqzqFMbINUCdLemUADLZ0C8d29H7sgAF/DMu3U8S fvRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Nq89nmYMFAZ5g1yAyMZHjiJetWqkZ/9OgWWUFHRT3b4=; b=ifGEZ4W+0AK5RPYnDhdN6wALQrGL8Vx3uYBc+UOnzwPyeDMmOIkj4wyaOIN/XVT/gq n+RFEJUNQRsmK1nI77E0fxt0znFq9fn8FmJeHmch//Fpq7gzG0TZsHWPzTWcuo1goc6t +mE4PVsBz5DCV8w+ph8yJh/+QAri1oktUcH8gx5CQQmpBknMujtGjBn5PvxU6/oa0rMk 3mtMLLLnNSZr6as3p5PDds5wJtP0bxdwsuIEEd7R1/M6BWnMTITyRRv5jd4ZiVHjbi2N pyQhNN+pNoXajyfD5Wyor95z+/RrROB5XuUA97HBOed2OlZPqEGdGBHW37DbpQYPtOXg V2Rw== X-Gm-Message-State: AOAM530YK5uH6DIszRPIzta62SwSBE6jNuvjuZD/tGhxU63aZ3pYsQtl Fn1uAjlMihz9hmTNWj5GOecXMgOrCe1law== X-Google-Smtp-Source: ABdhPJzwaADOyAjTA/hARmZgN7KTVo4qobwfMII7N5adWMTLZMzL8lf7NO0ukXa+upxezM5u7zbd4g== X-Received: by 2002:ac2:4c8e:: with SMTP id d14mr6892427lfl.411.1607281394385; Sun, 06 Dec 2020 11:03:14 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:13 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 10/13] video: fbdev: gbefb: Fix set but not used warning Date: Sun, 6 Dec 2020 20:02:44 +0100 Message-Id: <20201206190247.1861316-11-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The variable "x" was set but never used. Drop the redundant assignments. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Acked-by: Thomas Zimmermann --- drivers/video/fbdev/gbefb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c index 31270a8986e8..c5b99a4861e8 100644 --- a/drivers/video/fbdev/gbefb.c +++ b/drivers/video/fbdev/gbefb.c @@ -198,7 +198,7 @@ static void gbe_reset(void) static void gbe_turn_off(void) { int i; - unsigned int val, x, y, vpixen_off; + unsigned int val, y, vpixen_off; gbe_turned_on = 0; @@ -249,7 +249,6 @@ static void gbe_turn_off(void) for (i = 0; i < 100000; i++) { val = gbe->vt_xy; - x = GET_GBE_FIELD(VT_XY, X, val); y = GET_GBE_FIELD(VT_XY, Y, val); if (y < vpixen_off) break; @@ -260,7 +259,6 @@ static void gbe_turn_off(void) "gbefb: wait for vpixen_off timed out\n"); for (i = 0; i < 10000; i++) { val = gbe->vt_xy; - x = GET_GBE_FIELD(VT_XY, X, val); y = GET_GBE_FIELD(VT_XY, Y, val); if (y > vpixen_off) break; From patchwork Sun Dec 6 19:02:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954373 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6A6C2BB3F for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E71E2310B for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbgLFTEg (ORCPT ); Sun, 6 Dec 2020 14:04:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727617AbgLFTEg (ORCPT ); Sun, 6 Dec 2020 14:04:36 -0500 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A57D5C061A56 for ; Sun, 6 Dec 2020 11:03:17 -0800 (PST) Received: by mail-lf1-x144.google.com with SMTP id w13so2185765lfd.5 for ; Sun, 06 Dec 2020 11:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/SfLL6p8Oi2QG40QnuZputxs/YKRkVGSLvwvUqAWetc=; b=dzhegX2f5Ql3PjQBuil9z4sEYgr3337KW2qQckQ6pQGqbvHHs3CVckmYm5Un20ZhkN wdkTRTeoGd4YUyQFFb9U0U8n93rtfAEylUq//N9tgc51Uj0heyF4pNIBSnYX3+NsBMg3 VlU4KJFbgS+nYglZ1sGrjauXI4h68vGNSOgCJRgtnTxfmkIhYAinfPZNDvHX3dZZVEpJ D8Uhz593GGEn0bnW/ZX+fvM/7cLfUcJ5KPkfia0Y4F+7Jzk8Drd3lORKZBfzTHoV+FZS vBppZ4WLbjFRLdfxltCmYT0j7Y1+AMNgraJP+91Ox1B9CubxR0yjYf9zDFUhIyR8iYzU sulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/SfLL6p8Oi2QG40QnuZputxs/YKRkVGSLvwvUqAWetc=; b=qbjuPUrG/AEwVxm82nAidkinMSql6dBFg7gPPdUA0Hrsryb1l9NTCQg/V0IlONyOZd 2RwU/oARZJKtJyZuxJTmbw8LIGnsNre7lm4zkx2SlS10iLj5PhCNRjMOF0rcG4+3GYLX VZyTJVOm/MCIS+8M7y40Lt35cFqsXqKMc1ohVlXzj7FllItU5YZ9o3wZww34Rk0g52Hs Gopgner+6k5UF6GxubmU38esgRr0JnRXsGJxMiPAlgzmRuwwLSiXUfsr0j9pEMz7RU4Y /aYZN5usvH4piGHYAGogtjdNLErvGIX4bwqUmcATdMp1mq6DaSApsc+bXSTXaFnHSLDc RsPQ== X-Gm-Message-State: AOAM532vydpoj4FOJv4evKT+X3/YTyVFGmsZe9tuUODqX4TitjpSuREU +8aPzIsfW5Bi/teXDCzl1wfrLm7t5nTo6g== X-Google-Smtp-Source: ABdhPJwxko1cTuuCkRnEsGsx7KovNmq7vPKRcW8CEJXVJu5saQZRJ120DnppqSpeigQFs93cZ9Bi5g== X-Received: by 2002:ac2:46f3:: with SMTP id q19mr7197990lfo.76.1607281396030; Sun, 06 Dec 2020 11:03:16 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:15 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch Date: Sun, 6 Dec 2020 20:02:45 +0100 Message-Id: <20201206190247.1861316-12-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org screen_pitch was asssigned a value which was never used. Drop it to fix the warning Signed-off-by: Sam Ravnborg Cc: Peter Jones Cc: linux-fbdev@vger.kernel.org Acked-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index e57c00824965..b80ba3d2a9b8 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_info *si, u32 bmp_width) static void efifb_show_boot_graphics(struct fb_info *info) { - u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y; + u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y; struct screen_info *si = &screen_info; struct bmp_file_header *file_header; struct bmp_dib_header *dib_header; @@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info *info) bmp_width = dib_header->width; bmp_height = abs(dib_header->height); bmp_pitch = round_up(3 * bmp_width, 4); - screen_pitch = si->lfb_linelength; if ((file_header->bitmap_offset + bmp_pitch * bmp_height) > bgrt_image_size) From patchwork Sun Dec 6 19:02:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74739C1B0D9 for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 392402310B for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbgLFTEa (ORCPT ); Sun, 6 Dec 2020 14:04:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727617AbgLFTEa (ORCPT ); Sun, 6 Dec 2020 14:04:30 -0500 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58129C08C5F2 for ; Sun, 6 Dec 2020 11:03:19 -0800 (PST) Received: by mail-lj1-x244.google.com with SMTP id x23so5656132lji.7 for ; Sun, 06 Dec 2020 11:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sXUs3Mthn2WNxe9bljzB5KJJxtMgTykEfGBU86F6xiE=; b=Q4dR21nP1jZzsA/PsBN5qV0FqAKg4TkCjUyfsDCiyitQByJY5pO5fmgCAt3HViK+Vu XRUL2l0cD9wsZRjDwcbB0ZkNdr2Ir8Z7fcIEcrCiLQ53YeGHkSqqOUbj4eNSOg27SQ2e VuiJFCYExB03CZXF1PU6lkLv//+TmUU088Jb20M90SzVM9CX147uj+6nsdoHGclTz2ug h7Enp9lKWI4SeKqcS7nXNJbi6m28/YpB2nLY/XwFy9XMEryms6GgsPuePANX6hSoCvmW db092ppYA0YCdY9Z8mQQsgWKkITED7TNoaGGzceIxon6WPvVxvSHD/htfnVZo8eKukOP QYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=sXUs3Mthn2WNxe9bljzB5KJJxtMgTykEfGBU86F6xiE=; b=I2aruokWXu5jzT/515+vDqvY7XsPYVHHEgntazDCobUXikiCP7UrciIAJ3XcyFwE6Q dbj8ekfwF3X4ee7oE2v8ZRs/Mx/ILQfQzNYS2JEcNfIQkTraI5kKoSDuJfVIP/RBUgUT ps78HIpZFHm6k92/gquuUmA2RRyDQm6z06gXMYa/6W/innhsZ7dtIU8vcOmk/qGo7DdM LqF1+A21yyubpeNMK5LZddJnv4BRanL5WrKrsH6ljuCfrOgGsC/AFmXTr2BvftADNIu5 VFo5cfRJikJdMDQp9AgMWjp7dgDhPFPY6UQ8B1rnxkXcilj4r4uIvsEKvUlI3aP6petd iNHA== X-Gm-Message-State: AOAM531ETIOLINTs0I7bnRqIXi+vUFbVl2Ht5N6IuWeFHpmv1dQ4NfzG WTNfPBCOTEpCk++kGjxgR0s8L0XBtC2HAQ== X-Google-Smtp-Source: ABdhPJzb0KQuWgqAs1QxpFLIbzjo0hp3iVTcDNFOfPyUb7EI83W2N6g7hHXWSCKUuYPdd+iJRhnYvw== X-Received: by 2002:a05:651c:10d4:: with SMTP id l20mr6957942ljn.389.1607281397682; Sun, 06 Dec 2020 11:03:17 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:17 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings Date: Sun, 6 Dec 2020 20:02:46 +0100 Message-Id: <20201206190247.1861316-13-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The controlfb driver has a number of dummy defines for IO operations. They were introduced in commit a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support"). The write variants did not use their value parameter in the dummy versions, resulting in set but not used warnings. Fix this by adding "(void)val" to silence the compiler. Signed-off-by: Sam Ravnborg Cc: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: "Gustavo A. R. Silva" Cc: Michael Ellerman Acked-by: Thomas Zimmermann --- drivers/video/fbdev/controlfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c index 2df56bd303d2..509311471d51 100644 --- a/drivers/video/fbdev/controlfb.c +++ b/drivers/video/fbdev/controlfb.c @@ -64,9 +64,9 @@ #undef in_le32 #undef out_le32 #define in_8(addr) 0 -#define out_8(addr, val) +#define out_8(addr, val) (void)(val) #define in_le32(addr) 0 -#define out_le32(addr, val) +#define out_le32(addr, val) (void)(val) #define pgprot_cached_wthru(prot) (prot) #else static void invalid_vram_cache(void __force *addr) From patchwork Sun Dec 6 19:02:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11954375 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9320FC1B0D8 for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 706462333D for ; Sun, 6 Dec 2020 19:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727819AbgLFTEe (ORCPT ); Sun, 6 Dec 2020 14:04:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727617AbgLFTEd (ORCPT ); Sun, 6 Dec 2020 14:04:33 -0500 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B0BC08E85E for ; Sun, 6 Dec 2020 11:03:20 -0800 (PST) Received: by mail-lj1-x244.google.com with SMTP id i15so5315803ljg.9 for ; Sun, 06 Dec 2020 11:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GScDic0SzMOywiRur8mCpGJMaQJv67n1BqEnfhPYONM=; b=QMkRY6iR3O19IMJtlN+m8w86Axp8od1Z+Rd3idr23N4rt0HINNoZzNcNrb4mNMjjZu LtfD2LRDhh3DEyGEelRH+81cqqoQz6u2EGfaFSAaEV4zQVEQ7bdTSmG3CvppgGL4RgWj c7Oi5iOg63ZkdJPZC4t0TXvm2CwtDUzgfeudGj2JxAKG2JJV00RNILCmcFohVVoB5GRw Lc5MCgm2iKKHIevinvY7+ABLUGJ+6Wgt5evU5xN9dWXBW3BVnKhDDYg5UYkpaodDe+J6 ppuuuQbWocz5KRVehMqi41+JufRzKHoQeL7FAeA3rqybqK6fKDkrVw+NwXOkDRqusUpM lMjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GScDic0SzMOywiRur8mCpGJMaQJv67n1BqEnfhPYONM=; b=g1Vp2RkcP2qjd/dH0Pwfw3XTuRgVflFre8ws4Kk2gb2SFhpy4VnoAi6PpdAW7Ciqxu J/3HNF0I/JAtV5ocfqwFfgdi82PlHIJ+SlfxR04bI6Hb2viems4oToWpKVkuUckxMn66 AnnP/bnzQvYloYRo1XWXCUVrEyCJ/p86C1eh+ZLVf1qwQ/PgO2aCpXRyvMRqHSQCvOXO quY8mnV2CWF1RnOhnar0F5yQn2MlJQEDRUFf9sTq92qjdWZZO7Q3ph7AjyOeIDNH26Br fPjnAKK4bZIKgUozCvID5xZn1tPQ2MF8O1SNXB5yo2W3ZYgi+M60NicbobzrOQmnwBUY LG5Q== X-Gm-Message-State: AOAM530A+XdCFhSTbey44gz28VjnFDbCKDfg6qg2wZYly1SxkzMUR2zK T3zcvow1XnS9dDRvgpOsDK9ZecBfNJrvZA== X-Google-Smtp-Source: ABdhPJxrMN/xtNgSlDAS8lye01CuFJ2naATPUBdhH/2vk8CwJU1fz9TzgghOkMOTq4Zk9C0n+Dp+gA== X-Received: by 2002:a2e:b0d4:: with SMTP id g20mr7193569ljl.281.1607281399117; Sun, 06 Dec 2020 11:03:19 -0800 (PST) Received: from saturn.localdomain ([2a00:fd00:8060:1c00:c1c3:bbc6:3ac5:732d]) by smtp.gmail.com with ESMTPSA id v28sm2483865ljv.29.2020.12.06.11.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 11:03:18 -0800 (PST) Sender: Sam Ravnborg From: Sam Ravnborg To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Sam Ravnborg , Thierry Reding , Thomas Winischhofer , Thomas Zimmermann , Tony Prisk Subject: [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo() Date: Sun, 6 Dec 2020 20:02:47 +0100 Message-Id: <20201206190247.1861316-14-sam@ravnborg.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201206190247.1861316-1-sam@ravnborg.org> References: <20201206190247.1861316-1-sam@ravnborg.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Coverity reported: Useless call (USELESS_CALL) side_effect_free: Calling SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its return value, which is ignored. And this is correct - so drop the call. Signed-off-by: Sam Ravnborg Reported-by: Colin Ian King Addresses-Coverity: ("Useless call") Cc: Colin Ian King Cc: Thomas Winischhofer Acked-by: Thomas Zimmermann --- drivers/video/fbdev/sis/init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index b77ea1a8825a..b568c646a76c 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -2659,7 +2659,6 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, if(SiS_Pr->UseCustomMode) { infoflag = SiS_Pr->CInfoFlag; } else { - SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); if(ModeNo > 0x13) { infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag; }