From patchwork Tue Dec 15 16:40:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11975239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69981C2BB48 for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 284B82251E for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725850AbgLOQlt (ORCPT ); Tue, 15 Dec 2020 11:41:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:52106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgLOQlt (ORCPT ); Tue, 15 Dec 2020 11:41:49 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2D75207E8 for ; Tue, 15 Dec 2020 16:41:08 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.94) (envelope-from ) id 1kpDNr-000nGs-Ji for linux-trace-devel@vger.kernel.org; Tue, 15 Dec 2020 11:41:07 -0500 Message-ID: <20201215164107.465848331@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 15 Dec 2020 11:40:31 -0500 From: Steven Rostedt To: linux-trace-devel@vger.kernel.org Subject: [PATCH 1/3] libtracefs: Move do_install_* macros to utils.mk References: <20201215164030.520449524@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: "Steven Rostedt (VMware)" The do_install_* macros are in the main Makefile, and they overwrite some of the same macros in utils.mk. Move those macros into the utils.mk and delete the ones that were not used. Signed-off-by: Steven Rostedt (VMware) --- Makefile | 19 ------------------- scripts/utils.mk | 25 ++++++++++++++----------- 2 files changed, 14 insertions(+), 30 deletions(-) diff --git a/Makefile b/Makefile index 5e7831407427..5a9d33455143 100644 --- a/Makefile +++ b/Makefile @@ -206,25 +206,6 @@ endef $(PKG_CONFIG_FILE) : ${PKG_CONFIG_SOURCE_FILE}.template $(Q) $(call do_make_pkgconfig_file,$(prefix)) -define do_install_mkdir - if [ ! -d '$(DESTDIR_SQ)$1' ]; then \ - $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$1'; \ - fi -endef - -define do_install - $(call do_install_mkdir,$2); \ - $(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2' -endef - -define do_install_pkgconfig_file - if [ -n "${pkgconfig_dir}" ]; then \ - $(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \ - else \ - (echo Failed to locate pkg-config directory) 1>&2; \ - fi -endef - tags: force $(RM) tags $(call find_tag_files) | xargs ctags --extra=+f --c-kinds=+px diff --git a/scripts/utils.mk b/scripts/utils.mk index 7967a4f290d2..71985e6a28b1 100644 --- a/scripts/utils.mk +++ b/scripts/utils.mk @@ -119,18 +119,21 @@ define update_dir fi); endef +define do_install_mkdir + if [ ! -d '$(DESTDIR_SQ)$1' ]; then \ + $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$1'; \ + fi +endef + define do_install - $(print_install) \ - if [ ! -d '$(DESTDIR_SQ)$2' ]; then \ - $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \ - fi; \ - $(INSTALL) $1 '$(DESTDIR_SQ)$2' + $(call do_install_mkdir,$2); \ + $(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2' endef -define do_install_data - $(print_install) \ - if [ ! -d '$(DESTDIR_SQ)$2' ]; then \ - $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$2'; \ - fi; \ - $(INSTALL) -m 644 $1 '$(DESTDIR_SQ)$2' +define do_install_pkgconfig_file + if [ -n "${pkgconfig_dir}" ]; then \ + $(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \ + else \ + (echo Failed to locate pkg-config directory) 1>&2; \ + fi endef From patchwork Tue Dec 15 16:40:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11975233 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FDE8C2BB9A for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11E3F223D6 for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725947AbgLOQlt (ORCPT ); Tue, 15 Dec 2020 11:41:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:52108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbgLOQlt (ORCPT ); Tue, 15 Dec 2020 11:41:49 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05C8622573 for ; Tue, 15 Dec 2020 16:41:09 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.94) (envelope-from ) id 1kpDNr-000nHM-PI for linux-trace-devel@vger.kernel.org; Tue, 15 Dec 2020 11:41:07 -0500 Message-ID: <20201215164107.647287878@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 15 Dec 2020 11:40:32 -0500 From: Steven Rostedt To: linux-trace-devel@vger.kernel.org Subject: [PATCH 2/3] libtracefs: Print installing messages References: <20201215164030.520449524@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: "Steven Rostedt (VMware)" The make install did not show anything being installed. When files are being installed, they should be printed that they are being installed. Signed-off-by: Steven Rostedt (VMware) --- scripts/utils.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/utils.mk b/scripts/utils.mk index 71985e6a28b1..ad73814c5664 100644 --- a/scripts/utils.mk +++ b/scripts/utils.mk @@ -126,6 +126,7 @@ define do_install_mkdir endef define do_install + $(print_install) \ $(call do_install_mkdir,$2); \ $(INSTALL) $(if $3,-m $3,) $1 '$(DESTDIR_SQ)$2' endef From patchwork Tue Dec 15 16:40:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11975237 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E87C2BBCA for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49369207E8 for ; Tue, 15 Dec 2020 16:42:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725878AbgLOQlu (ORCPT ); Tue, 15 Dec 2020 11:41:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:52110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgLOQlt (ORCPT ); Tue, 15 Dec 2020 11:41:49 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0ACB122581 for ; Tue, 15 Dec 2020 16:41:09 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.94) (envelope-from ) id 1kpDNr-000nHs-V5 for linux-trace-devel@vger.kernel.org; Tue, 15 Dec 2020 11:41:07 -0500 Message-ID: <20201215164107.816232723@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 15 Dec 2020 11:40:33 -0500 From: Steven Rostedt To: linux-trace-devel@vger.kernel.org Subject: [PATCH 3/3] libtracefs: Remove KernelShark relics from build References: <20201215164030.520449524@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: "Steven Rostedt (VMware)" The utils.mk file has variables to deal with building KernelShark as it was taken from the trace-cmd.git repo. libtracefs dose not build KernelShark and we can remove the variables that were for that. Signed-off-by: Steven Rostedt (VMware) --- scripts/utils.mk | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/scripts/utils.mk b/scripts/utils.mk index ad73814c5664..398b88a75bfb 100644 --- a/scripts/utils.mk +++ b/scripts/utils.mk @@ -2,15 +2,7 @@ # Utils -ifeq ($(BUILDGUI), 1) - GUI = 'GUI ' - GSPACE = -else - GUI = - GSPACE = " " -endif - - GOBJ = $(GSPACE)$(notdir $(strip $@)) + GOBJ = $(notdir $(strip $@)) ifeq ($(VERBOSE),1) @@ -32,15 +24,15 @@ ifeq ($(findstring 1,$(SILENT)$(VERBOSE)),1) print_install = print_update = else - print_compile = echo ' $(GUI)COMPILE '$(GOBJ); - print_app_build = echo ' $(GUI)BUILD '$(GOBJ); - print_fpic_compile = echo ' $(GUI)COMPILE FPIC '$(GOBJ); - print_shared_lib_compile = echo ' $(GUI)COMPILE SHARED LIB '$(GOBJ); - print_plugin_obj_compile = echo ' $(GUI)COMPILE PLUGIN OBJ '$(GOBJ); - print_plugin_build = echo ' $(GUI)BUILD PLUGIN '$(GOBJ); - print_static_lib_build = echo ' $(GUI)BUILD STATIC LIB '$(GOBJ); - print_install = echo ' $(GUI)INSTALL '$(GSPACE)$1' to $(DESTDIR_SQ)$2'; - print_update = echo ' $(GUI)UPDATE '$(GOBJ); + print_compile = echo ' COMPILE '$(GOBJ); + print_app_build = echo ' BUILD '$(GOBJ); + print_fpic_compile = echo ' COMPILE FPIC '$(GOBJ); + print_shared_lib_compile = echo ' COMPILE SHARED LIB '$(GOBJ); + print_plugin_obj_compile = echo ' COMPILE PLUGIN OBJ '$(GOBJ); + print_plugin_build = echo ' BUILD PLUGIN '$(GOBJ); + print_static_lib_build = echo ' BUILD STATIC LIB '$(GOBJ); + print_install = echo ' INSTALL '$1' to $(DESTDIR_SQ)$2'; + print_update = echo ' UPDATE '$(GOBJ); endif do_fpic_compile = \