From patchwork Wed Dec 16 13:14:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 11977531 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3905C0018C for ; Wed, 16 Dec 2020 13:16:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A47233CF for ; Wed, 16 Dec 2020 13:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A47233CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=VTo8r/PXQTunjFPdspW7byci6QJ9caWXiH5ySgWKCPQ=; b=n2VKYClk6fLnyTcXL9pgQG/zoC Tzts1JshJ2QpE1fi4o2N90pqjA1JrSuEaHS4yJxjJYp4y11Nl43H/pBMTcJRI/6/2Esl9Fd6v9c21 Uy/iEaoiVxJdkL1NRLjKOKaGqlEVldQ6KAMITHBNqIutRJ6YM4NFhgdYdMOKwDZuaJ6XnDKD5QbRi I1Wpur+MJXvixRgugStt9s5V5hrOOfqiQ2u8b3YGh2UWqdIiGBGZvJUrAsYM8FbjphqeRBde59ZPS SrdAw83tAuNjJYuGQ7j5QCMudAnFWVF8i8qIeCIbc7EhyiJHX8hTsjxfeycYB4Yn85lVI7otibmjk 9bVfTflg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWe3-0005vx-0P; Wed, 16 Dec 2020 13:15:07 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWe0-0005uU-3S for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 13:15:05 +0000 Received: by mail-lf1-x134.google.com with SMTP id s26so13537855lfc.8 for ; Wed, 16 Dec 2020 05:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m4jmJAOQCco9M3h+AoC7gWzpQon/ZawA/8oWPNkEngQ=; b=Lltyb3OHjMrMpnH10EYmim6elXWeyvj8x9zcvRANz9icPbJXkV+b4lOIamqJkOwBIm FzGh2upBIT+V/nvfqRvYRktB3QlYCE6qzZ9mHQC39c4rEJZnIswU++WWdMtXiWGtJQn8 ShGQ8gr3XEJeqd7WBqWAiQTxTZzt2pMFghIcKM0iD70My9fMsbXOl6W+GtUoL6miNEqG QILc2Z8MNITPc8Aep8AOAyQjpAlQDuqS6qS9AL/3E2lrb56bJcwXq71tIr5aoKvB5uU4 jj+d/ULpF7809ihtOOe6nUVmCLNAJ11Cguf0XRC+BP0nLKWxKc5w51I3NX27AuVfBw0A VexQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m4jmJAOQCco9M3h+AoC7gWzpQon/ZawA/8oWPNkEngQ=; b=FZ0lpzy231ixzBLJwZY+Y7nerjaaj28/InxuRwpwHivCc41TM6fKx1dvvsgjEZqXL8 SGksbdRnDC17vgQPoOWgA6ObJ5f9N0nhI0KSV1iFwhP/w1M2W2TIkNeCSTvHEqigLXYN s+XgYslJ8edmO6ggo+1kfaOIr+5Ja5iWspZAjs+WGrrU+oODtkq/gtAN2BxwQRu+j2Mk PIWWekbUxiUZtNoO59j27DwobX3hPqTw9NNvMQm4WJPtZl6lKUDzvGHqDDobbI7xF/Y6 yhl57lO3UIKHTeR8KqNRbmPLFkbb1Otvz1XPGki6lvc8y78w9QsVzeZoNhFMh5gOkGvM NpDQ== X-Gm-Message-State: AOAM533BSWTmtkykL1VGbc2Vmj5Cd2axb4pfvJzPsTl79mVt0XAzVMBJ mLs0+GoVFkChKirpgi9hXjk= X-Google-Smtp-Source: ABdhPJzgyJLvHAuEw7IesmqyD7qLJYq81K+f61mn2CQBC/BmGuvLZh9k7sajC31iMlc5jotpXjwFJA== X-Received: by 2002:a2e:b047:: with SMTP id d7mr9621904ljl.467.1608124500712; Wed, 16 Dec 2020 05:15:00 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id n84sm220899lfd.176.2020.12.16.05.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 05:15:00 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring Subject: [PATCH 1/3] dt-bindings: phy: brcm, brcmstb-usb-phy: convert to the json-schema Date: Wed, 16 Dec 2020 14:14:49 +0100 Message-Id: <20201216131451.16900-1-zajec5@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_081504_189639_D6A21089 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Al Cooper , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki Changes that require mentioning: 1. interrupt-names Name "wakeup" was changed to the "wake". It matches example and what Linux driver looks for in the first place 2. brcm,ipp and brcm,ioc Both were described as booleans with 0 / 1 values. In examples they were integers and Linux driver checks for int as well. I made both uint32 but that probably should be refactored later. 3. Added minimal description Signed-off-by: Rafał Miłecki --- .../bindings/phy/brcm,brcmstb-usb-phy.txt | 86 -------- .../bindings/phy/brcm,brcmstb-usb-phy.yaml | 195 ++++++++++++++++++ 2 files changed, 195 insertions(+), 86 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt deleted file mode 100644 index 698aacbdcfc4..000000000000 --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt +++ /dev/null @@ -1,86 +0,0 @@ -Broadcom STB USB PHY - -Required properties: -- compatible: should be one of - "brcm,brcmstb-usb-phy" - "brcm,bcm7216-usb-phy" - "brcm,bcm7211-usb-phy" - -- reg and reg-names properties requirements are specific to the - compatible string. - "brcm,brcmstb-usb-phy": - - reg: 1 or 2 offset and length pairs. One for the base CTRL registers - and an optional pair for systems with USB 3.x support - - reg-names: not specified - "brcm,bcm7216-usb-phy": - - reg: 3 offset and length pairs for CTRL, XHCI_EC and XHCI_GBL - registers - - reg-names: "ctrl", "xhci_ec", "xhci_gbl" - "brcm,bcm7211-usb-phy": - - reg: 5 offset and length pairs for CTRL, XHCI_EC, XHCI_GBL, - USB_PHY and USB_MDIO registers and an optional pair - for the BDC registers - - reg-names: "ctrl", "xhci_ec", "xhci_gbl", "usb_phy", "usb_mdio", "bdc_ec" - -- #phy-cells: Shall be 1 as it expects one argument for setting - the type of the PHY. Possible values are: - - PHY_TYPE_USB2 for USB1.1/2.0 PHY - - PHY_TYPE_USB3 for USB3.x PHY - -Optional Properties: -- clocks : clock phandles. -- clock-names: String, clock name. -- interrupts: wakeup interrupt -- interrupt-names: "wakeup" -- brcm,ipp: Boolean, Invert Port Power. - Possible values are: 0 (Don't invert), 1 (Invert) -- brcm,ioc: Boolean, Invert Over Current detection. - Possible values are: 0 (Don't invert), 1 (Invert) -- dr_mode: String, PHY Device mode. - Possible values are: "host", "peripheral ", "drd" or "typec-pd" - If this property is not defined, the phy will default to "host" mode. -- brcm,syscon-piarbctl: phandle to syscon for handling config registers -NOTE: one or both of the following two properties must be set -- brcm,has-xhci: Boolean indicating the phy has an XHCI phy. -- brcm,has-eohci: Boolean indicating the phy has an EHCI/OHCI phy. - - -Example: - -usbphy_0: usb-phy@f0470200 { - reg = <0xf0470200 0xb8>, - <0xf0471940 0x6c0>; - compatible = "brcm,brcmstb-usb-phy"; - #phy-cells = <1>; - dr_mode = "host" - brcm,ioc = <1>; - brcm,ipp = <1>; - brcm,has-xhci; - brcm,has-eohci; - clocks = <&usb20>, <&usb30>; - clock-names = "sw_usb", "sw_usb3"; -}; - -usb-phy@29f0200 { - reg = <0x29f0200 0x200>, - <0x29c0880 0x30>, - <0x29cc100 0x534>, - <0x2808000 0x24>, - <0x2980080 0x8>; - reg-names = "ctrl", - "xhci_ec", - "xhci_gbl", - "usb_phy", - "usb_mdio"; - brcm,ioc = <0x0>; - brcm,ipp = <0x0>; - compatible = "brcm,bcm7211-usb-phy"; - interrupts = <0x30>; - interrupt-parent = <&vpu_intr1_nosec_intc>; - interrupt-names = "wake"; - #phy-cells = <0x1>; - brcm,has-xhci; - syscon-piarbctl = <&syscon_piarbctl>; - clocks = <&scmi_clk 256>; - clock-names = "sw_usb"; -}; diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml new file mode 100644 index 000000000000..34664bdfa4be --- /dev/null +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml @@ -0,0 +1,195 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/brcm,brcmstb-usb-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom STB USB PHY + +description: Broadcom's PHY that handles EHCI/OHCI and/or XHCI + +maintainers: + - Rafał Miłecki + +properties: + compatible: + enum: + - brcm,bcm7211-usb-phy + - brcm,bcm7216-usb-phy + - brcm,brcmstb-usb-phy + + clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + maxItems: 2 + items: + - const: sw_usb + - const: sw_usb3 + + interrupts: + description: wakeup interrupt + + interrupt-names: + const: wake + + brcm,ipp: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Invert Port Power + minimum: 0 + maximum: 1 + + brcm,ioc: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Invert Over Current detection + minimum: 0 + maximum: 1 + + dr_mode: + description: PHY Device mode. If this property is not defined, the PHY will + default to "host" mode. + enum: + - host + - peripheral + - drd + - typec-pd + + brcm,syscon-piarbctl: + description: phandle to syscon for handling config registers + $ref: /schemas/types.yaml#/definitions/phandle + + brcm,has-xhci: + description: Indicates the PHY has an XHCI PHY. + type: boolean + + brcm,has-eohci: + description: Indicates the PHY has an EHCI/OHCI PHY. + type: boolean + + "#phy-cells": + description: | + Cell allows setting the type of the PHY. Possible values are: + - PHY_TYPE_USB2 for USB1.1/2.0 PHY + - PHY_TYPE_USB3 for USB3.x PHY + const: 1 + +required: + - reg + - "#phy-cells" + +anyOf: + - required: + - brcm,has-xhci + - required: + - brcm,has-eohci + +allOf: + - if: + properties: + compatible: + contains: + const: brcm,brcmstb-usb-phy + then: + properties: + reg: + minItems: 1 + maxItems: 2 + items: + - description: the base CTRL register + - description: XHCI EC register + - if: + properties: + compatible: + contains: + const: brcm,bcm7211-usb-phy + then: + properties: + reg: + minItems: 5 + maxItems: 6 + items: + - description: the base CTRL register + - description: XHCI EC register + - description: XHCI GBL register + - description: USB PHY register + - description: USB MDIO register + - description: BDC register + reg-names: + minItems: 5 + maxItems: 6 + items: + - const: ctrl + - const: xhci_ec + - const: xhci_gbl + - const: usb_phy + - const: usb_mdio + - const: bdc_ec + - if: + properties: + compatible: + contains: + const: brcm,bcm7216-usb-phy + then: + properties: + reg: + minItems: 3 + maxItems: 3 + items: + - description: the base CTRL register + - description: XHCI EC register + - description: XHCI GBL register + reg-names: + minItems: 3 + maxItems: 3 + items: + - const: ctrl + - const: xhci_ec + - const: xhci_gbl + +additionalProperties: true + +examples: + - | + #include + + usb-phy@f0470200 { + compatible = "brcm,brcmstb-usb-phy"; + reg = <0xf0470200 0xb8>, + <0xf0471940 0x6c0>; + #phy-cells = <1>; + dr_mode = "host"; + brcm,ioc = <1>; + brcm,ipp = <1>; + brcm,has-xhci; + brcm,has-eohci; + clocks = <&usb20>, <&usb30>; + clock-names = "sw_usb", "sw_usb3"; + }; + - | + #include + + usb-phy@29f0200 { + compatible = "brcm,bcm7211-usb-phy"; + reg = <0x29f0200 0x200>, + <0x29c0880 0x30>, + <0x29cc100 0x534>, + <0x2808000 0x24>, + <0x2980080 0x8>; + reg-names = "ctrl", + "xhci_ec", + "xhci_gbl", + "usb_phy", + "usb_mdio"; + brcm,ioc = <0x0>; + brcm,ipp = <0x0>; + interrupts = <0x30>; + interrupt-parent = <&vpu_intr1_nosec_intc>; + interrupt-names = "wake"; + #phy-cells = <0x1>; + brcm,has-xhci; + syscon-piarbctl = <&syscon_piarbctl>; + clocks = <&scmi_clk 256>; + clock-names = "sw_usb"; + }; From patchwork Wed Dec 16 13:14:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 11977533 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246C9C2BBCA for ; Wed, 16 Dec 2020 13:16:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D58702339E for ; Wed, 16 Dec 2020 13:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D58702339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dMznkudR69ILDDUs0qo5fV8uqAbD3vK+8UK8Ta7hItw=; b=AQUkwnlKY217+N9frbh5k65XN /jV7S2Ht6D568Jp4uOe9NnxDQo2IU6ufTJgPSPKBFqBFjz7gZp1sh08sV1KczTLzlzcf2B+ccBBa1 vK5yCNxaaZAWU2Iu35Gjsp9MvdVw8cVWmYBVG+IoD6mIUuaA6yhq/LpjaVEbRd4Unhon7Ik6IYbnD E0iLtQhLlGHj4rVQ2QydlvzafF44EsA5DVA+Bbs+rSpwIpnv2m4HPlKYZtAaB5pMw8JHTV/QPZPhd mLAb9mKUjrssKH4hhdDQF0FdSMz3sjIWghYMeN92g9bWH8G1j4hAHiuOg5FOphEWHONrNahuxRoOa wxRq9owBA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWe9-0005xv-7n; Wed, 16 Dec 2020 13:15:13 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWe1-0005vO-Ls for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 13:15:07 +0000 Received: by mail-lf1-x132.google.com with SMTP id a9so48201046lfh.2 for ; Wed, 16 Dec 2020 05:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3bqN0VQwl8tDX1KGMDEJjbziUGx+xbpEwCCsyvHgV/8=; b=Eq9RHPPQ/9K70lYdmCeFlVwFEq0xDOOmxX/ZdbOm3y+3bD5iaCYMwTb2gM01XdJEUy mKm2hj8pRlh+BlDjwCHkIiJyhOS9K2UFeUhw8WFXyzehrU6w0Zc0poUKgaIPh653sdJa OnSJm1hBeflrMTY2XvP7fkV2XqI8WuAEjZtcZ7q0ThqqLhs6j8xZHPdRQX2C8cIN/1// KwRRm0bVjwkNgFuiFiSAY3i76GQjEgp9VFfvi9791ZQcO/SgDU/GT+FnfuVPAJpFikkZ gVpqcISzsDu3EJofzb76OL9tFzYoWEq/g3XZLgtBR50rTkIkwYISJNLwjLZxq45yZ9zB zUdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3bqN0VQwl8tDX1KGMDEJjbziUGx+xbpEwCCsyvHgV/8=; b=Z479EyftBjs3QxzGgQvD4wUFBWxw1qrs4jsww3P0vTFjY/FQaDN9wkSCyhuXVV0Rdi qGVDxQTMTbSeQnfWkGUN/YL4Ce/jpXdl1Ed7iqu9vYCO/SCu86XHLP0MlN844AnGZmFw Tpsu2Ps3LIsl4dWAuFI3P2c2x6rlfjHJ9Nmrl8Jan61ympu0T3dXYl/L18QH46B6Wurm +r2w2JoXmmme2BGJP1fSGj7anSgXsxaf0gDyoyTn6OPa/SluxmQvTJa1Hw+0smDwZGSE voMagnIfhLL5jC6VNzKXwSdx67tRPYATGt+cs+Vtn1fWtcYlYdbdUusrW6+fEhBZjzzW I4Fw== X-Gm-Message-State: AOAM530nL4527EJBdbueN8h0VVtWXiWAQ9oMI6ew+iqLX4zu2DNiDC93 jEWHXe4AQVYf4qaZEbE9E+w= X-Google-Smtp-Source: ABdhPJzovhIxkbkc8gSM6k+TCyzmOgPth66anjNdaLfM7pmLMXnBX0mUm/pkUDvC321bytvKTKk4pw== X-Received: by 2002:a19:c96:: with SMTP id 144mr12260977lfm.564.1608124504320; Wed, 16 Dec 2020 05:15:04 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id n84sm220899lfd.176.2020.12.16.05.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 05:15:03 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring Subject: [PATCH 2/3] dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding Date: Wed, 16 Dec 2020 14:14:50 +0100 Message-Id: <20201216131451.16900-2-zajec5@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201216131451.16900-1-zajec5@gmail.com> References: <20201216131451.16900-1-zajec5@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_081505_745276_CF8DBFE2 X-CRM114-Status: GOOD ( 11.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Al Cooper , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki BCM4908 uses the same PHY and may require just slightly different programming. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli --- .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml index 34664bdfa4be..021d3171be75 100644 --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml @@ -14,6 +14,7 @@ maintainers: properties: compatible: enum: + - brcm,bcm4908-usb-phy - brcm,bcm7211-usb-phy - brcm,bcm7216-usb-phy - brcm,brcmstb-usb-phy @@ -90,7 +91,9 @@ allOf: properties: compatible: contains: - const: brcm,brcmstb-usb-phy + enum: + - const: brcm,bcm4908-usb-phy + - const: brcm,brcmstb-usb-phy then: properties: reg: From patchwork Wed Dec 16 13:14:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 11977529 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E66C4361B for ; Wed, 16 Dec 2020 13:16:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E9DB2339E for ; Wed, 16 Dec 2020 13:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E9DB2339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/vEgmYuMXn4XGSjsRRbsCoN5JzvWOeQfwZuuoZ5AwNw=; b=GehG+vcsxzuWJqVt0dDXWY2GU Y9O16gmZz3taEHnLu9w0Kgqaws2PNit2X5BAdyn/TIYu2k9o48htDlsW3S1TxP7626qvgbcBoihmC 2w2V7lCUSE+H9zq0nZ3FjUW7ybe5IwWS8dFXfQ9dRLzDsKm6y6ufjrM/mdS8CHc6Bdk0z6f27hCUm gg9Iiaui+2qRmd1q9Pufl1u74uBWyuZPk19K2wD+A6+5O7ZjFQ3D09D92a903rxrY1TuJDIgnCG6U OUdckWbFy7u2Wt8s3A4RXAjdcvzMcsTNxCeqWOumZuy05tdQZOPduMqfZcUoJuELclRG6E9zmvSZC PcejHzGRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWeG-0005zS-Rd; Wed, 16 Dec 2020 13:15:20 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpWe5-0005wQ-NC for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 13:15:14 +0000 Received: by mail-lf1-x12e.google.com with SMTP id o17so45269016lfg.4 for ; Wed, 16 Dec 2020 05:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M2hDyNKbfINfDFRORNR8XoQ5cqYbb7cXlIAuvUco70E=; b=r1M6lNd1dK0MDMzthu2JU42zFfdRbmIN1RJ77QVCrgshlM6fY4gK2LkLmUCVsnFFPH B41sKXEpCiTzWKMCUCByEYPil5XYC8LpsLVXecRDUQtjsd5sG1LLfPFI8/mH3haIYGE7 mFRPI+YVVckUZEExAPpY6WkVKQa7/LbGf7kCzujSEcLsAgCK2ckYiJfKAcT3BG8XZs5m pb7ijRc209Zo2xvjrj7YE8w3levq+OSz5sL4d3ZSK0y5HqGkLnHfGfAQRrlu4b5Uyjdu 9zmO8rtCt38jSbb+eQUf7fh8oFxhfv/g39zxdU0RPor/kKcGtQvK/zXv/AJk0K4/vD6U KVOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M2hDyNKbfINfDFRORNR8XoQ5cqYbb7cXlIAuvUco70E=; b=Nu4Xk2RTvHlYQWcFwq4Sv0azVzptGjLlDU5ivi0Iwwb4qPQjw24Ro61FdWdstVod2u FO/8LTsINIQU3rtNTFCRxzBIrmZilk9u4hjTLgjWbAmc9pJmv+4Qsj2uYc36EmRtHMPo EF/WZmZWhmT/x6IsVgGRAhgiNbsbNnMlWLhP1DKQRclMjk8/JVBjB5yR80wwQBX3xbN1 2JMCzZmAIkl6JYa0ljVZB7/fR2zd39I3n+BtP9FkRujeJjZzI0soypmTy2eF3MU15vgK LoC040JtP1wjDCsqsDYSbN0PMcOsrQIeb3C6vWW0smF+qzx8CDKZ0RcU92Y37yAkEY9Y Phpw== X-Gm-Message-State: AOAM5336Yq8VO5rjpg1Jjkk61cSkeCYpAY/74ALUlAOVS7muV3bwZcEA Bhl2An/P/L4dAttQn574yNw= X-Google-Smtp-Source: ABdhPJyXWA0QgL3q7AEk+SqALSfLxFwcsmvaBfVABbY0fFhfid17DwJcUij17H+RJ1GE318GRMK9lQ== X-Received: by 2002:a19:770c:: with SMTP id s12mr6889155lfc.367.1608124507954; Wed, 16 Dec 2020 05:15:07 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id n84sm220899lfd.176.2020.12.16.05.15.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 05:15:07 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring Subject: [PATCH 3/3] phy: phy-brcm-usb: support BCM4908 binding Date: Wed, 16 Dec 2020 14:14:51 +0100 Message-Id: <20201216131451.16900-3-zajec5@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201216131451.16900-1-zajec5@gmail.com> References: <20201216131451.16900-1-zajec5@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_081509_835951_8EB0BE2A X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Florian Fainelli , Al Cooper , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki BCM4908 seems to have slightly different registers but work when programmed just like the STB one. Signed-off-by: Rafał Miłecki Acked-by: Florian Fainelli --- drivers/phy/broadcom/phy-brcm-usb.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c index 99fbc7e4138b..63f922a5f29b 100644 --- a/drivers/phy/broadcom/phy-brcm-usb.c +++ b/drivers/phy/broadcom/phy-brcm-usb.c @@ -285,6 +285,10 @@ static const struct match_chip_info chip_info_7445 = { }; static const struct of_device_id brcm_usb_dt_ids[] = { + { + .compatible = "brcm,bcm4908-usb-phy", + .data = &chip_info_7445, + }, { .compatible = "brcm,bcm7216-usb-phy", .data = &chip_info_7216,