From patchwork Wed Jan 6 13:28:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 12001633 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B3BC433E0 for ; Wed, 6 Jan 2021 13:30:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4D5D2311A for ; Wed, 6 Jan 2021 13:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbhAFNaN (ORCPT ); Wed, 6 Jan 2021 08:30:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbhAFNaM (ORCPT ); Wed, 6 Jan 2021 08:30:12 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3228C06134C for ; Wed, 6 Jan 2021 05:29:31 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id r7so2442234wrc.5 for ; Wed, 06 Jan 2021 05:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OUzk47HBaWxY+fVcCNsyUMU5tZsT6IexSmrC5pHLmCQ=; b=iTrkuOw7gkPjlxE4v0hoN0/AXduZZP4mmao5yHYCKtmmo5SgfzL1gh9PQkEMaRLuDb DgXm70AjDvDb345lIwZzESOvNXJ8hRCV2iziOQHM6bviXUuqvuiWC5hW4IsyAAFUkOOX Sb05Pj0cCY636BVsJ4zWDQbLOXa33xVsdXb3xT+gXMNDf/REvsG/go9ULxgA6VRSXc/r 4zIcqIk/oNWjtBTQjtrJq9fNKiu9z44Hwh9Hy9wAgEdEg3Z/pQrCKUM3kF2yk3++XkhB Asfw8R4m6+uJlZTi7XG6j0Psp2xNYA0Ay7vDw5Khwma9PcsUvwbt5F+Hg82GYE0G3a5t ou7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OUzk47HBaWxY+fVcCNsyUMU5tZsT6IexSmrC5pHLmCQ=; b=VQlfz5waO8+8XhZulIz9WxdW0ZQw8aNuNligRvArYiIe7LyYYTRSM52xe6uAKQ0XaQ jJ0HY4DyQz2BRQl4oHtw9X0sdOIr0C1qQrAjHGnBRQeLHbgJMN5RG+BRbZIAErkB/+Oi YLGe/kQeTAaQCM0AAU7tXe91hmaFHJ5iwiZHAPGm7ODYJS6/3BKy+rHFTn8O1HMm6ZXk yvQCbr5xlsyxfvYYeW/7tq/rDO8xIe59KGs2cIg0mJ6RdwgDUTsDAAdfosKXEM8gicMz U299YAag8uirc75jH32/G/LiPLGhSBvB5CkzwrG7PEomXFcztDdQdZg0XlW2igpjst0R OATw== X-Gm-Message-State: AOAM532NRdVhHcNmOdRP3v1x91XQi10kmitUW8bDKu6TjU/XIG1ee2i2 b/QI3ZMoFwERUu0u84kz5IPqVRdKnNs= X-Google-Smtp-Source: ABdhPJzkm061xY5Zaz8Fcp7MGQDAlAE90IsyvTy0s3KXJru6aisY7U/kal4QBTLrMA0ktrl4COD6lg== X-Received: by 2002:adf:90e3:: with SMTP id i90mr4507932wri.248.1609939770410; Wed, 06 Jan 2021 05:29:30 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:e1db:b990:7e09:f1cf? (p200300ea8f065500e1dbb9907e09f1cf.dip0.t-ipconnect.de. [2003:ea:8f06:5500:e1db:b990:7e09:f1cf]) by smtp.googlemail.com with ESMTPSA id a12sm3413933wrh.71.2021.01.06.05.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 05:29:29 -0800 (PST) Subject: [PATCH net-next 1/3] r8169: replace BUG_ON with WARN in _rtl_eri_write From: Heiner Kallweit To: Jakub Kicinski , David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" References: Message-ID: <619e6cc2-9253-fd1e-564a-eec944ee31e1@gmail.com> Date: Wed, 6 Jan 2021 14:28:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Use WARN here to avoid stopping the system. In addition print the addr and mask values that triggered the warning. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 024042f37..9af048ad0 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -763,7 +763,7 @@ static void _rtl_eri_write(struct rtl8169_private *tp, int addr, u32 mask, { u32 cmd = ERIAR_WRITE_CMD | type | mask | addr; - BUG_ON((addr & 3) || (mask == 0)); + WARN(addr & 3 || !mask, "addr: 0x%x, mask: 0x%08x\n", addr, mask); RTL_W32(tp, ERIDR, val); r8168fp_adjust_ocp_cmd(tp, &cmd, type); RTL_W32(tp, ERIAR, cmd); From patchwork Wed Jan 6 13:28:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 12001637 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A05C433DB for ; Wed, 6 Jan 2021 13:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE4262311A for ; Wed, 6 Jan 2021 13:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbhAFNaP (ORCPT ); Wed, 6 Jan 2021 08:30:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbhAFNaN (ORCPT ); Wed, 6 Jan 2021 08:30:13 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D69AC06134D for ; Wed, 6 Jan 2021 05:29:33 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id c5so2439764wrp.6 for ; Wed, 06 Jan 2021 05:29:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vPQAq5rL2RT0Kb9F+IBKUZ7s46kdUygloMmy2B3StMk=; b=qcIVgM5q6DjBWZsspgRGvCLE3aqBeSslFqtcj+UXMfAnmFyNXy20QMmuSN9/qqZp24 K5Y9VeCEyS1b8nMZNXdsqVPHsQUisg440x9QOBXEsGg4B3KWlabOLqhSlZPfN5wlHU7J ssEaBLK5QRfl2rwkxrDfLxCGQACz4uolTns9EJCSockPXNsK1AFwLHhAGE50dsA9uuA4 RwhjisC/8sQufqN3z6Gn2W1GdOTxuz3RAskaJodgqv25gtSPHs1is/cYqBWgH+EtpvhI oYKBkUEWSWYpAyna+AJIJHqXEUbG1tbkY65FypDhx3qjV9qVzKY3+wqfCIvnlAeqyZQK gTNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vPQAq5rL2RT0Kb9F+IBKUZ7s46kdUygloMmy2B3StMk=; b=VluxTVNoVj0zd4sugacn7coEOyEtU9G7BZHx3chZTIGVXyOLrKReQ3njoIpwmEkq0n WsNghETX0XTWCJcGkgDYznKLGZLys5+zsNplcoY6/f1BcU3eQuIahD6B8SvPKYEE2n3m AbaBRLZy+lf0tZLtATzbhGF8qVhm+V4YNJDBc2NNMXgRvFsnB0x1HJGoQ+0/bBz/itO5 ayrNFM9j7L4hr0xeM0Vit+eTrSObTAxdcdqaG7S5T60dODn3voUc+FXCyG4fud99OSTa Ct6FZFQhTosmAW7hOQu0EOXYhzmd8KECPEwDRIoUd/26tMiwXhyPKslVFc6ZbuCBbqJg cM4A== X-Gm-Message-State: AOAM533motTguikZWDDg9f/TnPf5Y3KSYYEyWIb7WQ6MsODmeVrfWf0M UFwuItO2tfmcmkPY4wzS3Xp21ROQMBc= X-Google-Smtp-Source: ABdhPJyw3NXbHC561kEz06RMRH07Pix7DwC5+RISwdWw9ZPjpd6skZBhWZc4lAkuH3GZ2DovI6Yk2w== X-Received: by 2002:a5d:6708:: with SMTP id o8mr4355150wru.64.1609939771592; Wed, 06 Jan 2021 05:29:31 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:e1db:b990:7e09:f1cf? (p200300ea8f065500e1dbb9907e09f1cf.dip0.t-ipconnect.de. [2003:ea:8f06:5500:e1db:b990:7e09:f1cf]) by smtp.googlemail.com with ESMTPSA id t16sm3316974wmi.3.2021.01.06.05.29.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 05:29:31 -0800 (PST) Subject: [PATCH net-next 2/3] r8169: improve rtl_ocp_reg_failure From: Heiner Kallweit To: Jakub Kicinski , David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" References: Message-ID: <9c543ff7-0ef6-917b-cd71-3e4c28812952@gmail.com> Date: Wed, 6 Jan 2021 14:28:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Use WARN_ONCE here to get a call trace in case of a problem. This facilitates finding the offending code part. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 9af048ad0..6005d37b6 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -810,14 +810,9 @@ static void rtl_eri_clear_bits(struct rtl8169_private *tp, int addr, u32 m) rtl_w0w1_eri(tp, addr, 0, m); } -static bool rtl_ocp_reg_failure(struct rtl8169_private *tp, u32 reg) +static bool rtl_ocp_reg_failure(u32 reg) { - if (reg & 0xffff0001) { - if (net_ratelimit()) - netdev_err(tp->dev, "Invalid ocp reg %x!\n", reg); - return true; - } - return false; + return WARN_ONCE(reg & 0xffff0001, "Invalid ocp reg %x!\n", reg); } DECLARE_RTL_COND(rtl_ocp_gphy_cond) @@ -827,7 +822,7 @@ DECLARE_RTL_COND(rtl_ocp_gphy_cond) static void r8168_phy_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data) { - if (rtl_ocp_reg_failure(tp, reg)) + if (rtl_ocp_reg_failure(reg)) return; RTL_W32(tp, GPHY_OCP, OCPAR_FLAG | (reg << 15) | data); @@ -837,7 +832,7 @@ static void r8168_phy_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data) static int r8168_phy_ocp_read(struct rtl8169_private *tp, u32 reg) { - if (rtl_ocp_reg_failure(tp, reg)) + if (rtl_ocp_reg_failure(reg)) return 0; RTL_W32(tp, GPHY_OCP, reg << 15); @@ -848,7 +843,7 @@ static int r8168_phy_ocp_read(struct rtl8169_private *tp, u32 reg) static void r8168_mac_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data) { - if (rtl_ocp_reg_failure(tp, reg)) + if (rtl_ocp_reg_failure(reg)) return; RTL_W32(tp, OCPDR, OCPAR_FLAG | (reg << 15) | data); @@ -856,7 +851,7 @@ static void r8168_mac_ocp_write(struct rtl8169_private *tp, u32 reg, u32 data) static u16 r8168_mac_ocp_read(struct rtl8169_private *tp, u32 reg) { - if (rtl_ocp_reg_failure(tp, reg)) + if (rtl_ocp_reg_failure(reg)) return 0; RTL_W32(tp, OCPDR, reg << 15); From patchwork Wed Jan 6 13:29:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 12001635 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2460EC433E0 for ; Wed, 6 Jan 2021 13:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E85812311C for ; Wed, 6 Jan 2021 13:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726500AbhAFNaQ (ORCPT ); Wed, 6 Jan 2021 08:30:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbhAFNaO (ORCPT ); Wed, 6 Jan 2021 08:30:14 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38149C061358 for ; Wed, 6 Jan 2021 05:29:34 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id d26so2407766wrb.12 for ; Wed, 06 Jan 2021 05:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qjUxkdGfZy17IlPm7nlnqedjqmFUxudQh8FDLcrpSgc=; b=tPJLLYxQPfclMCSwS9KudCYhYQtevVW/+eQt0wyDbANKZ4DObvKVKb5RD+n9XOi3bq rZpEYk+rZzk299Hpl4NARYWFugOlaBLU4WlanSYJV7w6OxP60YA3Qa8gHg5r2vKBzjzi ovmcWOY8M9g9mljXu+VgMVLvBSbD6F5oL0uoW7H0hrkgDZAuzsUC2c60osCKgKvv/9xQ 2UB3nJ40O8UD03IZtujrNe2XNq9q1WWsxyT73orf7iYwB/5fwFE5GymedJKY0pWXdH2+ /DPhDKO4HLj63jKvBVTbqAZD+Px9CK74De8J52oa90pNN/3+IXIdh1YAXvk4rQhY7U6N Liig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qjUxkdGfZy17IlPm7nlnqedjqmFUxudQh8FDLcrpSgc=; b=X8DBr3CtrBElD0oneDPX3e35ZAEWIXkXLb0slVI5ZdOqMp7FUFJtnhJQYt3ZkX/iV/ cx9uHjG/GJCim0lj0woQnSSw0jVnk+XiKX+2+G9LhuVDWQzxc03c9Jj9heipq1bG3fHQ h1M+VA9gCpqFo/xfoCYpZwkuAsFjFXKfTfwBL4kk9Q4QQWfhzcQ3MPV21nBS+GtjpdAv jjLzFtR9K6/dDewTkqERzB/I9QibC1WbyMlsXCLNSz96BfRz5Kza5rhg68LHuWsOS4uP OJsA7Smyter+IV5uJGPV2ztJScG6ak+QBVT7GEDjwuhJbABygIF4a+OcYBmAvf7wfYpr wdcA== X-Gm-Message-State: AOAM533wp6YN/xQDA9g1ndcFHKh5ixXv3qe0cpoto8k1L+cCGua9qJLI JNA5OTZ751hWQya4Lz8otUuQE5v4fz8= X-Google-Smtp-Source: ABdhPJyrT95Oz1flZCJ5OsnRWJw/Q3sF2HTAqKnaE72RHuf9TStWiESNwOPXrjo0A3xWcGoYvv1o+Q== X-Received: by 2002:adf:9506:: with SMTP id 6mr4295432wrs.172.1609939772734; Wed, 06 Jan 2021 05:29:32 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:e1db:b990:7e09:f1cf? (p200300ea8f065500e1dbb9907e09f1cf.dip0.t-ipconnect.de. [2003:ea:8f06:5500:e1db:b990:7e09:f1cf]) by smtp.googlemail.com with ESMTPSA id z63sm3243326wme.8.2021.01.06.05.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 05:29:32 -0800 (PST) Subject: [PATCH net-next 3/3] r8169: don't wakeup-enable device on shutdown if WOL is disabled From: Heiner Kallweit To: Jakub Kicinski , David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" References: Message-ID: <62ad5326-b4b5-5453-7763-bee9b09942b2@gmail.com> Date: Wed, 6 Jan 2021 14:29:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org If WOL isn't enabled, then there's no need to enable wakeup from D3. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 6005d37b6..982e6b2f0 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4876,7 +4876,7 @@ static void rtl_shutdown(struct pci_dev *pdev) rtl_wol_shutdown_quirk(tp); } - pci_wake_from_d3(pdev, true); + pci_wake_from_d3(pdev, tp->saved_wolopts); pci_set_power_state(pdev, PCI_D3hot); } }