From patchwork Wed Jan 13 14:49:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB6B8C433E0 for ; Wed, 13 Jan 2021 14:51:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B5432360D for ; Wed, 13 Jan 2021 14:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725801AbhAMOvB (ORCPT ); Wed, 13 Jan 2021 09:51:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbhAMOu4 (ORCPT ); Wed, 13 Jan 2021 09:50:56 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26268C06179F for ; Wed, 13 Jan 2021 06:50:16 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id 3so1852431wmg.4 for ; Wed, 13 Jan 2021 06:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AGeTlHRvpAdPio9vRmuctbq8OFArXLtHb/g2TDArOrk=; b=s5iALxr3dobAkBUTpXGoBoDm/4QIM6hPqOgnFBeyOPMxE44pJLX408VkWwnjf9EKr7 cV7kywVBFk+BvK0rYKNvHfyqBUdb5WnuXOYKKGcbdNXTqGP8wzzNaWscr3GVpl5L+3e9 59GwpRAnSZw8YR3uzHvOELb7YNB+MK3VqThmnI/SPsJGojvBSlVXx9pEChrkKe/NOSnL ISS27W14Wk79/qU5wLB7QGSr1xGvvu+viv/ZtzaO16hfIiOOc82jkjWv9QBVdfjnSd7c DsTks38v32N1wxNwz0nDYPs9DmW7h7iY6aRdoTTFZx6zjR6CxixctRYRVpRPsYNSW6i4 aExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AGeTlHRvpAdPio9vRmuctbq8OFArXLtHb/g2TDArOrk=; b=rl4phzZWGZbydlGpjXBpqJDa1VdVz59Tpe0+jLJxa/R82bpZo38mN4AdXRn1waVijU 71cJME7yyCQjbqt9BmZLMsU4CuOjehCQl2eb1Je8INgD7x37BmSs1SAfDxn1ZU4ORwl4 qCBHwAif+g6QbrbJfB4N6PFnj4Zs1k8YQoeNSb9kZV83B6TsbbsK7nbIWkMRuJsW35SG 6qu8SdSGRx/unGvJ6NJl1mwT1wXIdigl5toi6dFyC63VK0HoOQHGEcDJKVHL4kFJeQn1 KKHPlgGpF06EYWB/u4JYlQSpqXXf4wH4j7GE0gJu/R6ctbUew4ByzYLnS5ARTmgriJIL vHFA== X-Gm-Message-State: AOAM531DHA/KhLqwGnv0SrUFjGb8IgmOHmxcl3s7LxZSMaQG7jbsa1ad lyCZOcPZrYxuDGC77obQTD1EXg== X-Google-Smtp-Source: ABdhPJyCW0t+4fXJ5f+EqccH4bSmfQRogXuSLR0mXqIvzlFByErtr2znDphOj6bW9fU2Yx0Dp0rX9w== X-Received: by 2002:a1c:cc19:: with SMTP id h25mr2579994wmb.124.1610549414900; Wed, 13 Jan 2021 06:50:14 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, James Simmons , Egbert Eich , John Fremlin , Ani Joshi , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 01/31] video: fbdev: core: fbmon: Add missing description for 'specs' Date: Wed, 13 Jan 2021 14:49:39 +0000 Message-Id: <20210113145009.1272040-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Also fix a formatting issue Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fbmon.c:617: warning: Function parameter or member 'specs' not described in 'fb_create_modedb' drivers/video/fbdev/core/fbmon.c:1103: warning: bad line: Cc: James Simmons Cc: Egbert Eich Cc: John Fremlin Cc: Ani Joshi Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fbmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 1bf82dbc9e3cf..82f856fe3919f 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c @@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block, * fb_create_modedb - create video mode database * @edid: EDID data * @dbsize: database size + * @specs: framebuffer montior specifications * * RETURNS: struct fb_videomode, @dbsize contains length of database * @@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres) * 2 * M * M = 300; * C = 30; - */ static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres) { From patchwork Wed Jan 13 14:49:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05125C433E6 for ; Wed, 13 Jan 2021 14:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C1123619 for ; Wed, 13 Jan 2021 14:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726900AbhAMOvC (ORCPT ); Wed, 13 Jan 2021 09:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbhAMOvB (ORCPT ); Wed, 13 Jan 2021 09:51:01 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BADAC0617A3 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id t30so2433904wrb.0 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=zc9ZOpEUI+Nh6Qla1WDfrb2vnRL2q84hQM50XEQXQr0xU371apuDwreUQOZKKSgAr5 g7a1pROIkw2JAlYrfbUiig2HWLqwWHy8HZ/XWWBHtiDNKwj55UxEgroLjJuCBw18hlHe 92MAeh9s6TSYlS6N3UHBcggv18NhVPSGxCug7FAilAYfafpZsRbkQDlYTKiORivlccUP 9LS1k+4OMMbCziBfn3XobchtVgfVFJZSPwFyAo4AnK1qxUYR+KRpOnUOlfLckY0T7SBh WIy1YBvftA/oJxDxlPln0TX3wEE3MMUxIU12tVxKSgY+5mviYsZit9GALu0OnFxLsu+0 HhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=bGkb9cyLc+qT7CkQp2K1CbobeU7S0oYg2HZXTIDJLQwM54yv/WPF1i7PNmtVyIG6+g WupG9vUKoMVK9BeStwqIhiq1aZw7zpjkGA6F+ciCXQ/yXAseA6HJHjGwcqbLERCAEA/O GD+MiVg35fWv1gPswpQOqtQPO69J741KqbFVJlSq6O61i7uZRGQOChlnc9nuRyXgzL6l iBUDbpxHIqlmlYDobEdZv8fS/medmbHwsVIBrS0EZiocT6leQPWG17hTvXnNg4n4vH2p DK5OZjWFwh9G9SoKBNY08LCohigWjsCOURGd1CSsDXGG6G807VxDcjyNF4UMPIP+a07C Se0g== X-Gm-Message-State: AOAM533zzNsUDkqQ6Jn2tqk9wNRUSnYhPl2BPCp/0w+nvhfSuv3FGg4j 2PJhWrTQpHRKdtSO+6Nhzz3A3g== X-Google-Smtp-Source: ABdhPJzvNk0my33Gw7zgd1XA3cpG4wONGFNN2ELceKXzyI59SQd9sR/5sbIBr/pV5XoFHhHHEN2b3g== X-Received: by 2002:adf:f4d0:: with SMTP id h16mr3060914wrp.30.1610549416231; Wed, 13 Jan 2021 06:50:16 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Steffen Trumtrar , Sascha Hauer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 02/31] video: of_display_timing: Provide missing description for 'dt' Date: Wed, 13 Jan 2021 14:49:40 +0000 Message-Id: <20210113145009.1272040-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/of_display_timing.c:58: warning: Function parameter or member 'dt' not described in 'of_parse_display_timing' Cc: Steffen Trumtrar Cc: Sascha Hauer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_display_timing.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index abc9ada798ee8..9f21f7dc85292 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name, /** * of_parse_display_timing - parse display_timing entry from device_node * @np: device_node with the properties + * @dt: Display timing information **/ static int of_parse_display_timing(const struct device_node *np, struct display_timing *dt) From patchwork Wed Jan 13 14:49:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94117C43381 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48A0A235FF for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727278AbhAMOvh (ORCPT ); Wed, 13 Jan 2021 09:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A15C1C0617A6 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 190so1850490wmz.0 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=IrAuQ7STah/wSU3pxyHJvgSYn2RFJdHG53sANMcOvFWEelHr6MWbdgH0ILose47Zot Z7KuINVRHXAMOA906n8OR8iFtf4Nj4LcjAyitSzAalDlz9HRtVPGlTQdbmekRtEQvGci mwZQ7Bb/HQ3c6/5luRJ3paeeu2VckReWTpFW7IRFzHAedOHDtIquldPM8aztOfgvKxxD s6M1i1MfLLNqZIHLouLNp+LTtcAhj/vFkE7Sl4+oIe3REJUFHIDtu/tkOMeXBy2FAK74 x/2MlHNNGii/IG81iFi1rPP9oiZBxGa2SQxXcMDTHrLT+hIaHOP1bEfVoE+Viqsap5Ze aNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=OXd1oHlr2WCnqm5ruX4mu01HfBPo4VgAwJS6EV16Kuk8uUc4bT6OxhxWqtQ8R4BU3h ew7hAaD3GK7Uxk3OGVIBaYUXVCUkPIRtzUWqbzyVjY/6MV7ofdawvR1//MtZ4yVrzOe4 SReSD5HdhzJribVtW54SDR2/k/YvrW34b2o/eiWmYkY9JQVux8oTNd5UXM4/PdcuYA/p Jn/4vvQ6cYR/846C4dfUBNXSJnkdncYf/DmLmPEWvYH+jTWaw6lNFtbobTxIJcT+hz6q 5WriOXfVykNaszpJSLFf4MxRqadIoHn83fhNgSLV1LCl6ByxXn9xhRMzbhlSuyd65V+E 7ueA== X-Gm-Message-State: AOAM53158PiBuU4a3SAVwHI4bMjMVdL0nHoXS9ZdPBCEfYu3YRw5fTzM /N9rEEtSXG5NzIup6HMEJA853A== X-Google-Smtp-Source: ABdhPJwjKCL09Sc77kIICMVKTnbILEqHPsQQ1uMvyk6hJHaNqRVyJKhV6HK5PA5SegcO2ZY3WnDx2Q== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr2562890wmj.168.1610549417412; Wed, 13 Jan 2021 06:50:17 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Alex Kern , "Eddie C. Dost" , Anthony Tong , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 03/31] video: fbdev: aty: atyfb_base: Remove superfluous code surrounding 'dac_type' Date: Wed, 13 Jan 2021 14:49:41 +0000 Message-Id: <20210113145009.1272040-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org If used, 'dac_type' is overwritten in the '#ifdef CONFIG_ATARI' clause. It's also not used after the last assignment, so we'll rid that too. Cc: Bartlomiej Zolnierkiewicz Cc: Vaibhav Gupta Cc: Alex Kern Cc: "Eddie C. Dost" Cc: Anthony Tong Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/atyfb_base.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index c8feff0ee8da9..11c328f0585ce 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -2365,8 +2365,6 @@ static int aty_init(struct fb_info *info) par->bus_type = (stat0 >> 0) & 0x07; par->ram_type = (stat0 >> 3) & 0x07; ramname = aty_gx_ram[par->ram_type]; - /* FIXME: clockchip/RAMDAC probing? */ - dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07; #ifdef CONFIG_ATARI clk_type = CLK_ATI18818_1; dac_type = (stat0 >> 9) & 0x07; @@ -2375,7 +2373,6 @@ static int aty_init(struct fb_info *info) else dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type; #else - dac_type = DAC_IBMRGB514; dac_subtype = DAC_IBMRGB514; clk_type = CLK_IBMRGB514; #endif From patchwork Wed Jan 13 14:49:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B17AC433DB for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03A2123600 for ; Wed, 13 Jan 2021 14:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbhAMOvh (ORCPT ); Wed, 13 Jan 2021 09:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727262AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68BF9C0617A9 for ; Wed, 13 Jan 2021 06:50:20 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id q18so2430378wrn.1 for ; Wed, 13 Jan 2021 06:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qvE9T1Sdi1RAuyfyFAKYPhv+PIZJRg/gdw+xAA12HNM=; b=U7XZpCynbw9Y5AThFO42Dm2JoFqWJsr9KG6TgiBESTQlNc3fAWqvrv/vV8/bWuW37L 5Fjmhghbx5eL6EY4Moqeeu/yko+J0D69QRMZW6dhXQ+Nm9vDb4yEtKNNPUG+swW/GUbD nAaRi2O/qE3tCVsaODzksTZRhF5TfWSJtIznTgVmbKSYSnmBQqobEUxuFMK2YTYRo0L7 5w6ysuaaYARhRutz78Bmdnh6Kc8gc9Z/V8eH/apGCKxMK7Ke/jwJuBK4NTtqahNEJg7W TA2E0XY8ZoQAjFera38Ev01dBrJEDrnnCeyVsmeOs34OMOGtHvVAEe9zC9dc+VdMb3Ui iGGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qvE9T1Sdi1RAuyfyFAKYPhv+PIZJRg/gdw+xAA12HNM=; b=p7Gt6ynWvfdSSzZ1QSW1P0VYi6WGuuk0jdTxmOX4kzpPY1jFX/U8GMir2lme+PoUz/ e71SnCNYlJek3vyjkfORfUyczSyv+vzbCecJydauHpGmPXj3K9GWNEt5VpqbB1QaJtAD mfdMvvTbTdQjk3D1xD1vQxHivJCEwbfTyUU3keFCtgSm2oAZFO8sul5k3yRkNZstYfu/ K174+OqMYjTUQbqv0VknAGDFJ8onJquuqH2Ne8VTp/z3u3kBCdedSZ96XG5CtiUAgEj7 Awkea/fiAIRYRfa8SeuyVWmriARaFj7jelVI1Xl6HPB/eCFe4jaKvZEidafwxJky2D51 U8yQ== X-Gm-Message-State: AOAM533TYiH1L53VmWAgLzx59rrkukHpGhFp4sXAilt131650N2vyuei X2UH1mx3/ThZcX/dELtnskVYEQ== X-Google-Smtp-Source: ABdhPJw8rEyi0DM19K9SdWt8OAokANJ3aIc/AvHlDFnh4GZL9+DaYT3IWFB1YtzXdbd84j6vPII+bw== X-Received: by 2002:adf:f18a:: with SMTP id h10mr3187110wro.244.1610549419211; Wed, 13 Jan 2021 06:50:19 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Vaibhav Gupta , Alex Kern , "Eddie C. Dost" , Anthony Tong , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 04/31] video: fbdev: aty: atyfb_base: Mark 'dac_type' as __maybe_unused Date: Wed, 13 Jan 2021 14:49:42 +0000 Message-Id: <20210113145009.1272040-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org 'dac_type' is only used in the '#ifdef CONFIG_ATARI' clause. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/atyfb_base.c: In function ‘aty_init’: drivers/video/fbdev/aty/atyfb_base.c:2363:6: warning: variable ‘dac_type’ set but not used [-Wunused-but-set-variable] Cc: Vaibhav Gupta Cc: Alex Kern Cc: "Eddie C. Dost" Cc: Anthony Tong Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index 11c328f0585ce..9b056b49f2807 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -2360,7 +2360,7 @@ static int aty_init(struct fb_info *info) #ifdef CONFIG_FB_ATY_GX if (!M64_HAS(INTEGRATED)) { u32 stat0; - u8 dac_type, dac_subtype, clk_type; + u8 __maybe_unused dac_type, dac_subtype, clk_type; stat0 = aty_ld_le32(CNFG_STAT0, par); par->bus_type = (stat0 >> 0) & 0x07; par->ram_type = (stat0 >> 3) & 0x07; From patchwork Wed Jan 13 14:49:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240D2C433E0 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD42B235FF for ; Wed, 13 Jan 2021 14:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbhAMOvi (ORCPT ); Wed, 13 Jan 2021 09:51:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59B2C061575 for ; Wed, 13 Jan 2021 06:50:21 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id t16so2416098wra.3 for ; Wed, 13 Jan 2021 06:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=S6pjMri1LooUzVebsMKl5L/qXAXXf0BQaNWI9zUwzK+jMt6eB9Qc4oOTGepufIBfid w8BOqqJSqOTlO1AaMZ2c97EUxzPgYgwXzlP38xgFZHdc5f5/8pnliirr015cmXT5P/6C bmXz//hqWY6WZtaLsnyk9w3DTs/zx93zvqMGjgmGEz1ltpAcWFoGUuZTLcV3oaXDRWzg TsHN1MtRbF4DsoU67oqGthJ9CyD102ea6PWM8nSeKWwLjDVQYDQOynMxGeM3eMYyzuVy k+RwnCTE6vvqOECHhK+/HT1+C06vWU2p6IumxaB4VEqq3egwhncHh1sL8BXGgsKHUjzx Jyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=OtZRUa6hrrklHf/bJtbrXGCrqwVYP4VZMNyC7fQPOi61O3baxdg51Lc8HTsRK9ngIw 5woHhjSWMjd7gs2sfQGc7DBERaMJA2zs20rk3SCfTolKZ+pAVPDQTsA8nuHYu7kK65iA RwpU45FnjVSXdZzWW6UwvYNC3yYTNk9/R0JgZAgDe/Kc/9Mc2kWaO3+wgAnTdzDkWdvY diuotRF252O+pMnm1ccg4pp92RJz1bKS9Z3GwVK0MsNe/ipXsfj1ZCKW/Ydlf88iAJJk unX5jiuV5soBGf9Tm+8j3kft9cHR9fHuDj1P8P9+khHFwXX+fr7uO4derEZtFs4040QV 609A== X-Gm-Message-State: AOAM533CIRxFwcp1A4chHingL1+0pZChKwo3lIPREwgdTNYYnf0vnt7l /j7QdbDOhy55OyIEMlTIkzKjYw== X-Google-Smtp-Source: ABdhPJwQS7eakiW5Ymk7Te1CVRoqQilV5MyqcK9JOS6lfWXJfPo5U8VaTE2R9c7aaPoPlmXHPb50DQ== X-Received: by 2002:adf:ec86:: with SMTP id z6mr2994233wrn.17.1610549420622; Wed, 13 Jan 2021 06:50:20 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Steffen Trumtrar , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 05/31] video: of_videomode: Fix formatting in kernel-doc header Date: Wed, 13 Jan 2021 14:49:43 +0000 Message-Id: <20210113145009.1272040-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/of_videomode.c:32: warning: Function parameter or member 'np' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'vm' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'index' not described in 'of_get_videomode' Cc: Steffen Trumtrar Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_videomode.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c index 67aff2421c29e..97a220852977f 100644 --- a/drivers/video/of_videomode.c +++ b/drivers/video/of_videomode.c @@ -14,11 +14,11 @@ /** * of_get_videomode - get the videomode # from devicetree - * @np - devicenode with the display_timings - * @vm - set to return value - * @index - index into list of display_timings - * (Set this to OF_USE_NATIVE_MODE to use whatever mode is - * specified as native mode in the DT.) + * @np: devicenode with the display_timings + * @vm: set to return value + * @index: index into list of display_timings + * (Set this to OF_USE_NATIVE_MODE to use whatever mode is + * specified as native mode in the DT.) * * DESCRIPTION: * Get a list of all display timings and put the one From patchwork Wed Jan 13 14:49:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93A1C433DB for ; Wed, 13 Jan 2021 14:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A1F235FF for ; Wed, 13 Jan 2021 14:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbhAMOvR (ORCPT ); Wed, 13 Jan 2021 09:51:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727019AbhAMOvQ (ORCPT ); Wed, 13 Jan 2021 09:51:16 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E5E7C0617B0 for ; Wed, 13 Jan 2021 06:50:23 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id m4so2388917wrx.9 for ; Wed, 13 Jan 2021 06:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ZA26LGPctNuqP7mpV6XCcQsQZ+HB0XmYF1B/7L0jYA=; b=YtqFI8RDxxpW9mdQOUk2m2f1SEWXkWNA5Pijok8cpdh3D28yUmkArEeHKDJHaMEw2D PdgSAP9Q4tLae/SkYSJ5eTZDO+n6pFatwv/TqUUoiuB320K732eTGq0iXq8oR/tNfkIH 9Y7pMmU2dnvUJlE7Cdikh+7Q8gG1oq1Nl7lwW/RGcLXR8b/1SFcPKGDY/yVn+9vcaOw5 ZsO4KDnuoqv4twTiAyGApWz9SY9RChb3/M/q2nVmM21sVoOCVxHdSCQemO93T1g3lrAj 3Lx+99Zkwfs70d4L1iYYRAQVeIVTso9ON+bmqWt1gSMmPn5bt/vIUtmLPizMCW6GT2UM qWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ZA26LGPctNuqP7mpV6XCcQsQZ+HB0XmYF1B/7L0jYA=; b=sNy/rXDyoi+JNd/0eP4e7zJNDrclamzIw+b28gyQdWOpwzzz0BaeO0eGlsRGMSH4Ww X3l7TdD7/vIzyJ2L6ggj9zfnYBsm89UPEIbpvi3OBtygiGogfQxKr+/WjWCql/t8CJ5C 6QxLAOB3B5OIwQRVz9okhLx3ITExsn0oMccdMz53I2B2obvd4FFH/YR8UcBBceZUsanY JGmkOqgWELMqDMMAtz1NIIiIv9RDtZbtzdNQvi17mxz7iQEkDqI5nmEFFjG4o9LY7yIQ dXx48VDK8YG5WUzkhEDwf/9xgjrxKSPOBN5kLJM0FacajfjLef3iG/7+WvP78QUJ/ynB HAHw== X-Gm-Message-State: AOAM5320PQjDdl+d/eumW/sr4daELWW+xiNvRl6i2GdGaQV1KgVK3Hih HOXNX+xP/LRvqhiuT2fyTAsw+w== X-Google-Smtp-Source: ABdhPJybD9xMfIqt11fPwnFfiI93H9p+YPj4ju8Xk0ywP3UrRKbDeRkdo75NDlfYMlTY1EKiKvzaMA== X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr2935428wrw.379.1610549422311; Wed, 13 Jan 2021 06:50:22 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas , Brad Douglas , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 06/31] video: fbdev: core: fb_notify: Demote non-conformant kernel-doc header Date: Wed, 13 Jan 2021 14:49:44 +0000 Message-Id: <20210113145009.1272040-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'val' not described in 'fb_notifier_call_chain' drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'v' not described in 'fb_notifier_call_chain' Cc: Antonino Daplas Cc: Brad Douglas Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fb_notify.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c index 74c2da5288848..1f142182fb40e 100644 --- a/drivers/video/fbdev/core/fb_notify.c +++ b/drivers/video/fbdev/core/fb_notify.c @@ -36,9 +36,8 @@ int fb_unregister_client(struct notifier_block *nb) } EXPORT_SYMBOL(fb_unregister_client); -/** +/* * fb_notifier_call_chain - notify clients of fb_events - * */ int fb_notifier_call_chain(unsigned long val, void *v) { From patchwork Wed Jan 13 14:49:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A20C433E6 for ; Wed, 13 Jan 2021 14:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 315CA23602 for ; Wed, 13 Jan 2021 14:54:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbhAMOym (ORCPT ); Wed, 13 Jan 2021 09:54:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbhAMOvm (ORCPT ); Wed, 13 Jan 2021 09:51:42 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B7AC0617B1 for ; Wed, 13 Jan 2021 06:50:25 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id a6so1850658wmc.2 for ; Wed, 13 Jan 2021 06:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=41nyWegGgkKSptjKwd6Aeq/y24rv95GTAFlb1D5g4Jo=; b=pafm/yTul1VI6VgZ+awVR07fmX3mqTQQWpRtjlYSoHGu/InZpKlZn+TF3rRl17XSwP nVwCaHHy9o1NrbzI5Kqe7jaZlv2VbjcglCPPckq0exelBS2rP9Xphp3ItgG6M8CLTIda FwhjulzLUtcgvHitUQ8ektKlAMQXC7BiliexBGYJjJwdb+W/YgPFIvtHlO2IzbtQIst3 2lSsdNd4+01TS9ZC+VwxrTVSuKXlQqv7Nl4gEzF2GdRsihWAM07i9laFCMuZ/apY4wep urDKWRfnc3vXE09BZNPfdVc8mjTIaiELGUowzaRoZqOiyF9oz78MBZlpqlJsYGj2kyLL xurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=41nyWegGgkKSptjKwd6Aeq/y24rv95GTAFlb1D5g4Jo=; b=HRZldCDk97JbK8A6MkVBJD98KzDbku8cQQ843fDSGO62JGP0Ql8ycDhuPM3L/0w+9S PFOPwslB/skm7Jj2l+yQAmo/t9Q4eTrwXDeOxx1AYPu/us6hBAnlP6ooRXKdaQVHXJiI UNihOj0X9gS4X6prtjrRxBEfg0xAHo0HuOKfxVi2H7Lj+7oS3kfuKmvjzXM6+QeRcr74 vWWvz6F7aPepn2+DqWxxkdT8V2WK3Rj2CGZLsvmot36tKfrmaFYeMivM9UqilLtWq//a Vi4tJ38MH+SaZ4uqs43Dc4Lw9Oil6FL77TFAsiR0c5gr/62gQP0hPxTa2bjRapA2K57O 9gJA== X-Gm-Message-State: AOAM530bPmIm7s0OlWevH6fgrvzEgFuVMKGDmdDvx76HkJYQ1/tfTmAY UK13gy4Ml0Nqzm6/dVoJQUYTcQ== X-Google-Smtp-Source: ABdhPJzywTsfi9Vnx2cWTPz0rA/vBrZ4+HLSZp3gHQQkVIeaDidlu8J3N598S3+EfWlm4YxHB5jcVA== X-Received: by 2002:a1c:a145:: with SMTP id k66mr2551920wme.18.1610549423835; Wed, 13 Jan 2021 06:50:23 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas , Ani Joshi , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:49:45 +0000 Message-Id: <20210113145009.1272040-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/fbdev.c:485: warning: Function parameter or member 'data8' not described in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:485: warning: Excess function parameter 'data' description in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'var' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'nom' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:1229: warning: Excess function parameter 'con' description in 'rivafb_pan_display' Cc: Antonino Daplas Cc: Ani Joshi Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/fbdev.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c index ce55b9d2e862b..8adf9cf353410 100644 --- a/drivers/video/fbdev/riva/fbdev.c +++ b/drivers/video/fbdev/riva/fbdev.c @@ -464,12 +464,12 @@ static inline void reverse_order(u32 *l) /** * rivafb_load_cursor_image - load cursor image to hardware - * @data: address to monochrome bitmap (1 = foreground color, 0 = background) + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background) * @par: pointer to private data - * @w: width of cursor image in pixels - * @h: height of cursor image in scanlines * @bg: background color (ARGB1555) - alpha bit determines opacity * @fg: foreground color (ARGB1555) + * @w: width of cursor image in pixels + * @h: height of cursor image in scanlines * * DESCRIPTiON: * Loads cursor image based on a monochrome source and mask bitmap. The @@ -840,19 +840,15 @@ static void riva_update_var(struct fb_var_screeninfo *var, NVTRACE_LEAVE(); } -/** - * rivafb_do_maximize - +/* + * rivafb_do_maximize * @info: pointer to fb_info object containing info for current riva board - * @var: - * @nom: - * @den: * * DESCRIPTION: * . * * RETURNS: * -EINVAL on failure, 0 on success - * * * CALLED FROM: * rivafb_check_var() @@ -1214,7 +1210,6 @@ static int rivafb_set_par(struct fb_info *info) /** * rivafb_pan_display * @var: standard kernel fb changeable data - * @con: TODO * @info: pointer to fb_info object containing info for current riva board * * DESCRIPTION: From patchwork Wed Jan 13 14:49:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017015 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBE3C43381 for ; Wed, 13 Jan 2021 14:51:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C3E823600 for ; Wed, 13 Jan 2021 14:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbhAMOvc (ORCPT ); Wed, 13 Jan 2021 09:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbhAMOvc (ORCPT ); Wed, 13 Jan 2021 09:51:32 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18276C0617BB for ; Wed, 13 Jan 2021 06:50:27 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id r3so2426127wrt.2 for ; Wed, 13 Jan 2021 06:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=q+MZOwcKb62nI3dDtefjHxCD1svvGR60Jf4GADTHbVCFSZk5ahffVs42713RFmCF3M hhNPD9AVosxvdPh3Z8yE2EAX9AIqiNvXNvlrh/+KWS1FF0B5BjXeeykrTfib5131sKFj mn2tgU4dkCSlErK842cyu7HwusDnIaakfzs1I7cSnM4yplICdcp2mBAJcvH34TWQSDE0 Dng1yBz0vV3j29G56BqJw78ZGoOyPY6hhoK+WPjPT+6lUPxLOPjPUWuXCAoeTfdRwhJo a9h437HEm5yNmdhcoLqG033+xaunKcJYY/dyF8W3QR8fqLXStt350nJ0m0HkPZgnnZIh 3SRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=DjTuwtxfmqDwphUhpGj59/EwNS9e5mCsHVY9JTOhBSlUncomlUn4IWUNQHyAZh5i1X spa+S3ESckZVcsqeUIRO60362gIaG3NLsuijLyBnAJTVqpDoAHqcsDtXPB84ItL3uyz3 IISEQbORrW7H/3M3AoVqIrkYXpFPQQVNxuwZMnYoHlfEY3BmDWXSpXnIUEgzGWKohPud giBf6JSDahMkRKWWzHWEb7dP+Lex2zFkv1efMAO8tlG5N+cDEDqFltAkRaPGDcGuBYEv qcBHQin1F1nbmHemaS1lrz77Wux2TIxk/X43heWp6CVYb9wNwQkXGYWe+UCo58k/aMb1 vzWg== X-Gm-Message-State: AOAM530AJYN2n4Sewg6p1wE7vzY2k9NPGfvsLs2cv13KypRQn+pCEjfX fTZkGMIJSS+ckCye/FB64+L/lA== X-Google-Smtp-Source: ABdhPJwVCTsByjCEjav6tW14+5dv7xLsxBc5Eorij361Ct+VXeRJyY7s7OCdf+rGi3SgUVSd2g+Hog== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr2925284wru.43.1610549425879; Wed, 13 Jan 2021 06:50:25 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , Gerd Knorr , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 08/31] video: fbdev: sis: sis_main: Remove unused variable 'reg' Date: Wed, 13 Jan 2021 14:49:46 +0000 Message-Id: <20210113145009.1272040-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/sis_main.c: In function ‘sisfb_post_xgi_ddr2’: drivers/video/fbdev/sis/sis_main.c:5032:5: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: Gerd Knorr Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 03c736f6f3d08..266a5582f94d3 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -5029,7 +5029,6 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) static const u8 cs168[8] = { 0x48, 0x78, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00 }; - u8 reg; u8 v1; u8 v2; u8 v3; @@ -5037,9 +5036,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0xb0, 0x80); /* DDR2 dual frequency mode */ SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x86, 0x00); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); SiS_SetReg(SISCR, 0x86, 0x88); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); v1 = cs168[regb]; v2 = cs160[regb]; v3 = cs158[regb]; if (ivideo->haveXGIROM) { v1 = bios[regb + 0x168]; @@ -5049,9 +5048,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0x86, v1); SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x85, 0x00); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, 0x88); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, v2); SiS_SetReg(SISCR, 0x82, v3); SiS_SetReg(SISCR, 0x98, 0x01); From patchwork Wed Jan 13 14:49:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FE0C4332B for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55AE823602 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbhAMOv6 (ORCPT ); Wed, 13 Jan 2021 09:51:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727534AbhAMOv5 (ORCPT ); Wed, 13 Jan 2021 09:51:57 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5493FC0617BC for ; Wed, 13 Jan 2021 06:50:29 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id r7so2408351wrc.5 for ; Wed, 13 Jan 2021 06:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=sst9frRzW/IJefwutBUvPoGyyHkMdmNCE2/2cJ1SvAob/HspH1X56uzjWNN7XPuilz wdKSM/9Hqj3XNtAA/hBuaE7G/g9i5BxwEMY6nf9eunFCXOpEAB+tkTQ53x6HPpg6jtJ5 4/CwTTvIH5eIMy9CUXAYqkwetX52U5C8J5iXu+ftxRcgI6ioB4TaWFUZokVU0jMRv4go iVThPqkc16K5jm14VkBnPxRc0KOF1l7502J6ctNsR0SVyVrAujPyJcOPpNmjUaQa0T2D QXsr/aNolpDchgMH7vINY63kaYmkDnVOFM9EKwvSgcfdyGaw5+y6o1AKmnSdmQwT2uZv +w6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=SePMincq7t0s4yKgT4+GuGTvRsprFIqZ7cn7pmKSreCUa5OBh8gJc7e8DO2jpaXw9m gOh3qoL+607U2Wk152/1ziq0ugXAEb3ztPgZmHNTEffXLWHT++Z9c1NWdI1I/THdTdLQ z1g39U6mbiFddXKzVZ6hYpMGjamnl9SC1NkcDD3zWqOMN3zK5mAnjwm7J3nUK7lX+X0u H7sCJ1gFGMZsy9jyVsf7fMH9kJBssl94LLMu1tpid8gzZGr59Dzv7idYO32hc7m3Unwe Wfjsgxynf2loGdzKWtwVl3BasALUD4gWUnLQsGFDcvHMr34JAZV4D9UVwd1qSHJpBGrt BxoA== X-Gm-Message-State: AOAM532hglk5UjE3If7/X+TMyuqdVpxUP+qwFLeuw8TDSyazpxaBVtqF 5QGQ5xMcWjJTAicMV4THGVkp2Q== X-Google-Smtp-Source: ABdhPJw7YBO0Y3mdZUBWXhnPmv13OWbKuieV4zDqiFanxqcxWiLlKLymFuWigA/Hr4jjfIkyPRZuxQ== X-Received: by 2002:adf:f58a:: with SMTP id f10mr3137113wro.338.1610549428139; Wed, 13 Jan 2021 06:50:28 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 09/31] video: fbdev: sis: Remove superfluous include of 'init.h' Date: Wed, 13 Jan 2021 14:49:47 +0000 Message-Id: <20210113145009.1272040-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Neither 'sis.h' nor any of its consumers uses these tables. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.h:144:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:132:28: warning: ‘SiS_EGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:120:28: warning: ‘SiS_CGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:108:28: warning: ‘SiS_MDA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:106:29: warning: ‘ModeIndex_310_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:105:29: warning: ‘ModeIndex_300_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:104:29: warning: ‘ModeIndex_1920x1440’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:103:29: warning: ‘ModeIndex_1920x1080’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:102:29: warning: ‘ModeIndex_1600x1200’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:101:29: warning: ‘ModeIndex_1680x1050’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:100:29: warning: ‘ModeIndex_1400x1050’ defined but not used [-Wunused-const-variable=] NB: Snipped - there are 277 of these! Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h index 9f4c3093ccb36..d632f096083b3 100644 --- a/drivers/video/fbdev/sis/sis.h +++ b/drivers/video/fbdev/sis/sis.h @@ -15,7 +15,6 @@ #include "vgatypes.h" #include "vstruct.h" -#include "init.h" #define VER_MAJOR 1 #define VER_MINOR 8 From patchwork Wed Jan 13 14:49:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC227C433E6 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70F8F23600 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbhAMOy5 (ORCPT ); Wed, 13 Jan 2021 09:54:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 000EFC0617BF for ; Wed, 13 Jan 2021 06:50:30 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id r4so1842956wmh.5 for ; Wed, 13 Jan 2021 06:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=akZkn4hii3ygwpUSWjXzvWKSUmmw5HI5L5N5wIekgQ0=; b=EJcbDkfKRG16dlT8xRjZ2F6tm3CWsp8WqmfprIForTO/9Y2JsYYNwS4yJL/okHccdL rfFTr0ZxW+4KF1FLysPYPNS/5SpSbjq6qLF+qf8QQszV05GlO7M8iQ6PEmExS8y0nIg/ sXKq7t7hD+h4zaMRifhvTSDH5Hdr8NcJnaksMh1Ba9J0+3WsIZOR3AdDg0zNFFyAxMq3 3m3VnwwWhpB/6kSBEAN7ThxVncEhpfkBGoxPJwk7xzxy9b6Nmo2FutbwW08hTxYU1W9B sx8byNENSxrpQ60i3f4xICBSBhsYi8qdXOOmXcJnE7uFyNJ8w242AIOWEoe7QKSKVv1G 7X2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=akZkn4hii3ygwpUSWjXzvWKSUmmw5HI5L5N5wIekgQ0=; b=ttSJFh/dPFb8dfm/zQgIPupFAR1vW/qf09+KXm/5/X9U+k2w1wOkaJUs4dQruVx/YY 66/ze21wouAB3KCr5i9hs6vOi5mGNeNSroubiHv/o+sJB5zY9L1++uhQ/1f8V6vfs82Q WUWNu2OYdL+4M5Mj254W06cJyi6rrgyP5uvjSeqMpR9MA1omr/VEk0RVU5LXmf7gAZve f0dhz7GHB5Q7aZQFJbIQpEyrYq877+f8yqz2S7ibfiFZfSv6rX3YEZ70v0NN6IE9eLXB YnmBVl6s5w2jNzgVILo/toTAK2DsvbY4OmoalJ0udlaIS8cXChNcLtThmZJbRdsIufnk nFEg== X-Gm-Message-State: AOAM533SzkhO6hMuCA17u6/1hE/57nRgJB9nwu3qX3YMJD7nKW33BGBf MTtDUicSRXNr4b7wpGSC6wvA2g== X-Google-Smtp-Source: ABdhPJyCN8YgIewQREamnbFpDz4/uZeDkGL1R/LbeVSpIuV7ANhwmGVP6W2Xw1BS3pyVh28c7PuZPw== X-Received: by 2002:a7b:c246:: with SMTP id b6mr2582589wmj.154.1610549429735; Wed, 13 Jan 2021 06:50:29 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas , Jeff Garzik , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 10/31] video: fbdev: riva: riva_hw: Remove a bunch of unused variables Date: Wed, 13 Jan 2021 14:49:48 +0000 Message-Id: <20210113145009.1272040-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’: drivers/video/fbdev/riva/riva_hw.c:849:9: warning: variable ‘pclks_2_top_fifo’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:43: warning: variable ‘vus_pipe’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:21: warning: variable ‘us_pipe’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:9: warning: variable ‘craw’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:846:27: warning: variable ‘vlwm’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:844:37: warning: variable ‘video_drain_rate’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:841:21: warning: variable ‘us_extra’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:840:55: warning: variable ‘vbs’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:839:25: warning: variable ‘cas’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: Jeff Garzik Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/riva_hw.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c index bcf9c4b4de311..4ee63f7d84d3e 100644 --- a/drivers/video/fbdev/riva/riva_hw.c +++ b/drivers/video/fbdev/riva/riva_hw.c @@ -836,17 +836,17 @@ static void nv10CalcArbitration nv10_sim_state *arb ) { - int data, pagemiss, cas,width, video_enable, bpp; - int nvclks, mclks, pclks, vpagemiss, crtpagemiss, vbs; - int nvclk_fill, us_extra; + int data, pagemiss, width, video_enable, bpp; + int nvclks, mclks, pclks, vpagemiss, crtpagemiss; + int nvclk_fill; int found, mclk_extra, mclk_loop, cbs, m1; int mclk_freq, pclk_freq, nvclk_freq, mp_enable; - int us_m, us_m_min, us_n, us_p, video_drain_rate, crtc_drain_rate; + int us_m, us_m_min, us_n, us_p, crtc_drain_rate; int vus_m, vus_n, vus_p; - int vpm_us, us_video, vlwm, cpm_us, us_crt,clwm; + int vpm_us, us_video, cpm_us, us_crt,clwm; int clwm_rnd_down; - int craw, m2us, us_pipe, us_pipe_min, vus_pipe, p1clk, p2; - int pclks_2_top_fifo, min_mclk_extra; + int m2us, us_pipe_min, p1clk, p2; + int min_mclk_extra; int us_min_mclk_extra; fifo->valid = 1; @@ -854,16 +854,13 @@ static void nv10CalcArbitration mclk_freq = arb->mclk_khz; nvclk_freq = arb->nvclk_khz; pagemiss = arb->mem_page_miss; - cas = arb->mem_latency; width = arb->memory_width/64; video_enable = arb->enable_video; bpp = arb->pix_bpp; mp_enable = arb->enable_mp; clwm = 0; - vlwm = 1024; cbs = 512; - vbs = 512; pclks = 4; /* lwm detect. */ @@ -924,17 +921,13 @@ static void nv10CalcArbitration us_min_mclk_extra = min_mclk_extra *1000*1000 / mclk_freq; us_n = nvclks*1000*1000 / nvclk_freq;/* nvclk latency in us */ us_p = pclks*1000*1000 / pclk_freq;/* nvclk latency in us */ - us_pipe = us_m + us_n + us_p; us_pipe_min = us_m_min + us_n + us_p; - us_extra = 0; vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */ vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */ vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */ - vus_pipe = vus_m + vus_n + vus_p; if(video_enable) { - video_drain_rate = pclk_freq * 4; /* MB/s */ crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */ vpagemiss = 1; /* self generating page miss */ @@ -993,7 +986,6 @@ static void nv10CalcArbitration else if(crtc_drain_rate * 100 >= nvclk_fill * 98) { clwm = 1024; cbs = 512; - us_extra = (cbs * 1000 * 1000)/ (8*width)/mclk_freq ; } } } @@ -1010,7 +1002,6 @@ static void nv10CalcArbitration m1 = clwm + cbs - 1024; /* Amount of overfill */ m2us = us_pipe_min + us_min_mclk_extra; - pclks_2_top_fifo = (1024-clwm)/(8*width); /* pclk cycles to drain */ p1clk = m2us * pclk_freq/(1000*1000); @@ -1038,14 +1029,13 @@ static void nv10CalcArbitration min_mclk_extra--; } } - craw = clwm; if(clwm < (1024-cbs+8)) clwm = 1024-cbs+8; data = (int)(clwm); /* printf("CRT LWM: %f bytes, prog: 0x%x, bs: 256\n", clwm, data ); */ fifo->graphics_lwm = data; fifo->graphics_burst_size = cbs; - /* printf("VID LWM: %f bytes, prog: 0x%x, bs: %d\n, ", vlwm, data, vbs ); */ + /* printf("VID LWM: 1024 bytes, prog: 0x%x, bs: 512\n, ", data); */ fifo->video_lwm = 1024; fifo->video_burst_size = 512; } } From patchwork Wed Jan 13 14:49:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A03C433E6 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA4A123602 for ; Wed, 13 Jan 2021 14:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727629AbhAMOwC (ORCPT ); Wed, 13 Jan 2021 09:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727624AbhAMOwB (ORCPT ); Wed, 13 Jan 2021 09:52:01 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0D0C061381 for ; Wed, 13 Jan 2021 06:50:32 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id a6so1851094wmc.2 for ; Wed, 13 Jan 2021 06:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UBertLrO50IMon3TZ4gj0CSxI3Yqy8ksl/8MP2cv2iw=; b=akpdEhMJh2ARCHyoNNx9VPJuhAoo9/Y4QVqEYnbUJ0Hy/4xwAFnitREVMt08+c+3Qu Kc2u8TwF4caPKUyn75DQBoHuu3wGDMO0r2V3p0Yo+d9smk9uBH9HBLge1hMCGnifQUR9 JjsszdKmG43arb7E46nkyyLFqd/tXDE7Y7P9jv3oeKYHpCIPG8OOt+aQ4sR1/nWloE2f 51Wwa7J/1t45aqUrswNJxn0kk2k4+oGZ23ac7biP9+idnJfOmRnbqPHH2PwdliX+83OH bnrAP/8D7ucxpARodtDBgI/9O7O5s2Vfm3AXS7vGGur65NmXvY4JTtIa3YxDSPJQGQVk BZgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UBertLrO50IMon3TZ4gj0CSxI3Yqy8ksl/8MP2cv2iw=; b=U2YELZaJkH3/z72fKfAZtNLWmjMrmLNPDbGd6JAV0LTBzZzV+CODag4DKgph6/i3Zr I5grU5V6fBq6dqtkXfh9NWkMprIbK7FvcHnvT+q7R2zrGGEdkXpxcnVRjwuGPgAghqYp duNEV+8oPDScM2oUAWbQwW2BctQ5vEPmT59VTkLtTsi9ASBPFY80z54k6pgRJ6q+K05V MHlsFbb9F4mkInGRq0cltdoNODzBtKfHO3EyExhyoLDYJZsDybp3g9vQC/gRuiWGrakN fJQ2WY2XSpPZfH/8j3S2kwsgCbgoXeAI9nBvCPwyr16Pc+gu7dmhvbHewsdcwQjRSnTr E7og== X-Gm-Message-State: AOAM533x4G/vguhyzc8HZ6OlEH3opQX7DrBhgRXDcyTSIhxZVG933dTn lO4bIm6DtlXVNOziP3SI9QfUqw== X-Google-Smtp-Source: ABdhPJw509pJdXHv0jOqPq8GOcIPKK4q+ka5nv3ec9nw6ylQAnAdVKzrPJgraDgus3zDqa2Oa+9RdA== X-Received: by 2002:a7b:c10e:: with SMTP id w14mr2520321wmi.161.1610549431282; Wed, 13 Jan 2021 06:50:31 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 11/31] video: fbdev: sis: init: Remove four unused variables Date: Wed, 13 Jan 2021 14:49:49 +0000 Message-Id: <20210113145009.1272040-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.c: In function ‘SiS_SetCRT1ModeRegs’: drivers/video/fbdev/sis/init.c:2651:49: warning: variable ‘resindex’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’: drivers/video/fbdev/sis/init.c:3544:19: warning: variable ‘A’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3542:34: warning: variable ‘VBS’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3541:34: warning: variable ‘HBS’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/init.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index fde27feae5d0c..4510272ad297a 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -2648,7 +2648,7 @@ static void SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned short ModeIdIndex, unsigned short RRTI) { - unsigned short data, infoflag = 0, modeflag, resindex; + unsigned short data, infoflag = 0, modeflag; #ifdef CONFIG_FB_SIS_315 unsigned char *ROMAddr = SiS_Pr->VirtualRomBase; unsigned short data2, data3; @@ -2659,7 +2659,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, if(SiS_Pr->UseCustomMode) { infoflag = SiS_Pr->CInfoFlag; } else { - resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); + SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); if(ModeNo > 0x13) { infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag; } @@ -3538,16 +3538,15 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, struct fb_var_screeninfo *var, bool writeres ) { - unsigned short HRE, HBE, HRS, HBS, HDE, HT; - unsigned short VRE, VBE, VRS, VBS, VDE, VT; + unsigned short HRE, HBE, HRS, HDE, HT; + unsigned short VRE, VBE, VRS, VDE, VT; unsigned char sr_data, cr_data, cr_data2; - int A, B, C, D, E, F, temp; + int B, C, D, E, F, temp; sr_data = crdata[14]; /* Horizontal total */ HT = crdata[0] | ((unsigned short)(sr_data & 0x03) << 8); - A = HT + 5; /* Horizontal display enable end */ HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6); @@ -3557,9 +3556,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, HRS = crdata[4] | ((unsigned short)(sr_data & 0xC0) << 2); F = HRS - E - 3; - /* Horizontal blank start */ - HBS = crdata[2] | ((unsigned short)(sr_data & 0x30) << 4); - sr_data = crdata[15]; cr_data = crdata[5]; @@ -3593,7 +3589,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, ((unsigned short)(cr_data & 0x01) << 8) | ((unsigned short)(cr_data & 0x20) << 4) | ((unsigned short)(sr_data & 0x01) << 10); - A = VT + 2; /* Vertical display enable end */ VDE = crdata[10] | @@ -3611,12 +3606,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, cr_data2 = (crdata[16] & 0x01) << 5; - /* Vertical blank start */ - VBS = crdata[11] | - ((unsigned short)(cr_data & 0x08) << 5) | - ((unsigned short)(cr_data2 & 0x20) << 4) | - ((unsigned short)(sr_data & 0x04) << 8); - /* Vertical blank end */ VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4); temp = VBE - ((E - 1) & 511); From patchwork Wed Jan 13 14:49:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA24CC433DB for ; Wed, 13 Jan 2021 14:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E38323600 for ; Wed, 13 Jan 2021 14:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727496AbhAMOwC (ORCPT ); Wed, 13 Jan 2021 09:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbhAMOwB (ORCPT ); Wed, 13 Jan 2021 09:52:01 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2752C061383 for ; Wed, 13 Jan 2021 06:50:34 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id g10so1855227wmh.2 for ; Wed, 13 Jan 2021 06:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j7fOAdOMSh9+aZXnWVlTBiJqXaPtT0tmJFJgVlyDPug=; b=wkKY3gUVpw4qP/WuQzc8XjrzRncVeSuZ6NzeUbALePTgU3Yrbw7YLTdHcXZj56nxVU 5Jh4wNloszsqH/vVqJxDDwBSRrJ2OCTzKTPcd5JzNVT5XIiv2M5crt5y5UskqbNAQTBB KvR9s7UwwCew+cXB1M/8JHMnIwXdbQxIScTfFklRChWJUy40Q3CuOodobSh9Um18qIvs FEHYZzDJPaKk06OPv4/h1Mi2+ufc5Xt/BqkVcO0w1K9kWocAZk5NMITW/2XtGYuEHFGY KaZnlzcDkLV1OrVCrmMpjQPrdUpM4TmeGqpdDN4K+fWyND84c6a9egSMvCEW1eojZ/Tv wkMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j7fOAdOMSh9+aZXnWVlTBiJqXaPtT0tmJFJgVlyDPug=; b=opm9PeHfXMYbO+wKL0puXzWOtmtIsrt9ibWJ1Y84mvpxSb1vfcOrr6d8mffXyhS+tH Gqc6R3B4KRQQPBthnhNI1PA3p8rIZWoNXAePBmfH6rSIpCjvAlQI6kXFXTJsFWY5wO82 OkitS5xAB8DCm98T/80KVzZDtP333HRxOVhKMeqeMb0JTlrdD+bKDin2XcTSlcd/8BMS sg0pp6x47M4zjJSMPvHFL/sNnG1Mqb6cgCb7JcNapGOJvqebfF4yExrSQqASUnC3Yrew D+78KKqIJWD7LKymmFywUvjULJy1X+35D2rAgUndlDiv/9u7W+PWcuA+AlqBmJOSpe/1 wTAA== X-Gm-Message-State: AOAM532W35P9HIibKBMjoL5j0bECT5tHklR5bu/C54Z40YOY6krkNeFC x2v7b/tHRISxOHyvs9AeMwQEENEEfHn/qYQM X-Google-Smtp-Source: ABdhPJwgWbKyROyg3P7kZzj3BsF17xohBzHH0P8bPH1Fo1biBkBRZcCRyPVkV1Whe5OHdIZxjMwpOQ== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr2564071wmb.180.1610549433405; Wed, 13 Jan 2021 06:50:33 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 12/31] video: fbdev: sis: oem310: Remove some unused static const tables Date: Wed, 13 Jan 2021 14:49:50 +0000 Message-Id: <20210113145009.1272040-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/oem310.h:213:28: warning: ‘SiS_TVDelay661_301B’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/oem310.h:203:28: warning: ‘SiS_TVDelay661_301’ defined but not used [-Wunused-const-variable=] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/oem310.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h index 8fce56e4482c0..5f7b503ed2a06 100644 --- a/drivers/video/fbdev/sis/oem310.h +++ b/drivers/video/fbdev/sis/oem310.h @@ -200,26 +200,6 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] = /* M650, 651, 0x33,0x33 }; -static const unsigned char SiS_TVDelay661_301[] = /* 661, 301 */ -{ - 0x44,0x44, - 0x44,0x44, - 0x00,0x00, - 0x44,0x44, - 0x44,0x44, - 0x44,0x44 -}; - -static const unsigned char SiS_TVDelay661_301B[] = /* 661, 301B et al */ -{ - 0x44,0x44, - 0x44,0x44, - 0x00,0x00, - 0x44,0x44, - 0x44,0x44, - 0x44,0x44 -}; - static const unsigned char SiS310_TVDelayCompensation_LVDS[] = /* LVDS */ { 0x0a,0x0a, From patchwork Wed Jan 13 14:49:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F71C43332 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1430723600 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727690AbhAMOwN (ORCPT ); Wed, 13 Jan 2021 09:52:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727676AbhAMOwM (ORCPT ); Wed, 13 Jan 2021 09:52:12 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D075C061385 for ; Wed, 13 Jan 2021 06:50:36 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id a6so1851287wmc.2 for ; Wed, 13 Jan 2021 06:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hcCYDUMcS26jDuM5+gRx+fiSHXa/31pKXfkIX189fZc=; b=WKJOrwZ97W06sGNe/8643fsBAhUrIy3pw+p8/Z4nnVsXP2eywnUTF/fuu6aqQ7IqnV 6bqyAhBD4abY+s60Rl5IZigMaAmPXz8Uw2c1DpBJK4PQxmaJxmh9tA+R2LxW1BhiiZTk yiuf3i9VtB5gHvfNiYKnHs1w8ffM0OURr8SS6DOOcwdI/uLEYMkd3eiV0TcMkLorYNz2 63JkGhf4cM01/SzrmAxd+HQf+HPnQA/eQoOZlRp6Lb9kAQGSlV4OiRy91CNfm/Ap5ieG bufuyVkbrh7vj7Mtxphu1YXK2MYICuU0icBn09Vb30KwCkk8oOWznjZavOmb2Rr1w40u CRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hcCYDUMcS26jDuM5+gRx+fiSHXa/31pKXfkIX189fZc=; b=aMUORw5MJZJVgqvGAPJGDPz0Kk1jHmVIc/K9p5NjeGmBOXp4cSM10DbEDRlkZ6zcfv /i1uo9hOFLjKMHuCbogsuT1vgXmk/JEo9OeevgiYwTOIc8bXPH+Vl4O40pps6DOgLc0t QQkgiNXtAD/5e1JnaYlKEnFeFIzZ2gweihw2NBr2oPBZVs/rd6jDYhLGfqbfjzhILwMp AVzw/38Mj4uqM0mQ9vOFoukGLndmIZ2VJtjG0o/R07nigaBZdV2OpeN8sAKV2UWZTOvP djUC8gWLc9tOIx7am434UMc6kmLJfRbfCkbTb8sK4D5U/GhB4R+q+oHde91Ra1DS/n3d LiPQ== X-Gm-Message-State: AOAM5334WLXbV6QIDWlgD5NADNRSZBppef6cRZn7kCQKFBvqqI7MMQxC ZWfyxgZRQiuSXI6499JqJTOL1TF8giRjtbAp X-Google-Smtp-Source: ABdhPJxI/06Eq2Rl5+qCibE+uAUvKG7ngE/AQ/AKyFAKVjTjbxsN6HN/O2nM7Z2/XWrJTZE0EwxiWQ== X-Received: by 2002:a1c:2d92:: with SMTP id t140mr2585614wmt.114.1610549434915; Wed, 13 Jan 2021 06:50:34 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 13/31] video: fbdev: nvidia: nv_setup: Remove a couple of unused 'tmp' variables Date: Wed, 13 Jan 2021 14:49:51 +0000 Message-Id: <20210113145009.1272040-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVWriteAttr’: drivers/video/fbdev/nvidia/nv_setup.c:92:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVReadAttr’: drivers/video/fbdev/nvidia/nv_setup.c:104:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/nvidia/nv_setup.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c index 2fa68669613af..47a96a066f998 100644 --- a/drivers/video/fbdev/nvidia/nv_setup.c +++ b/drivers/video/fbdev/nvidia/nv_setup.c @@ -89,9 +89,7 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index) } void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else @@ -101,9 +99,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) } u8 NVReadAttr(struct nvidia_par *par, u8 index) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else From patchwork Wed Jan 13 14:49:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A747C4332D for ; Wed, 13 Jan 2021 14:51:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65D76235FF for ; Wed, 13 Jan 2021 14:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbhAMOvx (ORCPT ); Wed, 13 Jan 2021 09:51:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727479AbhAMOvv (ORCPT ); Wed, 13 Jan 2021 09:51:51 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954EFC061388 for ; Wed, 13 Jan 2021 06:50:37 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id g25so3769827wmh.1 for ; Wed, 13 Jan 2021 06:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dqYcKMvvBegfm3VenU/QB6olxRoFuHKFr2cjTUmqS/8=; b=S9AVj327o2YowF2UVDBy78wryMVcbl0h9+66FkKjsJ6i8WFxR9bdMBpvD09HQSKrBK vo1ZGwrQgRIbO8nXV14mGFMY7xN/8efJxg72LA+jGfLxFGqANW5Hq1Sp7x03fIgx6wh9 GIQHviMB4xL7Ezvs1yhHlV4tpH+kRDmAfbGsmQRRzOL0kTysvdv5asLys1CLRMxMQw3j KSElJsxQsL2ag8A2zAltelJHGfRZI0Wa5LkJq72Dlg5v5NEk61ys0mgDyU45DAojoCL2 n+AyXgib6ItiEzC+zdVYwT+v/wpNd5HLgmYqxPkzAM1ka3F9mHglqwUXvhnOweZ6cRBz nA+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dqYcKMvvBegfm3VenU/QB6olxRoFuHKFr2cjTUmqS/8=; b=nHa3V5bl69CUbVj4BOb7kz4wKSuE0g8F+6n1Sva3ifHhtooi37k9e211vIATHpHfs8 nEXBSJd4UyqDz1gk71gMWXrfQG9HTxHNwKNqFW8YTLRsqexOoLQTTNgSsm0GU5VO7IGH jkLJzjdttTwBoazjh8+s6PbxPZJhbqAIhMVT8pezkV08NEAkORKi/y9jFigeYbrdEEjK 9I6Y542lWpFenoTdk6SncLPhe/6X4FiD1grdFHj3pbhmWXVr+0BBeiuCpmu7boDp1NCh Jxsq4B8iHLihPcmnz7R7rixL02SjICby6u3Wgg2AVhUWOKiUDe5p64Bpa1cjZYlwDFjG pwTg== X-Gm-Message-State: AOAM533wPgsRYiyr4WR75KUi0pPJl7tsKXraPHAEqt4hAPdpTjn0S0FJ 2uTJNWCWIG2Ge18OpM9urD92Pw== X-Google-Smtp-Source: ABdhPJy4RotZ5wPboUC1kdYhrUWx9GlS9eDgIJqXfbaNL8FlpjQa2No/+N3798NUVzIh33Csn1WwcA== X-Received: by 2002:a05:600c:2255:: with SMTP id a21mr2599659wmm.122.1610549436394; Wed, 13 Jan 2021 06:50:36 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, daniel.mantione@freepascal.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables Date: Wed, 13 Jan 2021 14:49:52 +0000 Message-Id: <20210113145009.1272040-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’: drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable] Cc: daniel.mantione@freepascal.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/mach64_ct.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c index f87cc81f4fa2b..23eececa1e9d7 100644 --- a/drivers/video/fbdev/aty/mach64_ct.c +++ b/drivers/video/fbdev/aty/mach64_ct.c @@ -402,7 +402,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll) struct atyfb_par *par = (struct atyfb_par *) info->par; u8 mpost_div, xpost_div, sclk_post_div_real; u32 q, memcntl, trp; - u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off; + u32 dsp_config; #ifdef DEBUG int pllmclk, pllsclk; #endif @@ -488,25 +488,10 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll) /* Allow BIOS to override */ dsp_config = aty_ld_le32(DSP_CONFIG, par); - dsp_on_off = aty_ld_le32(DSP_ON_OFF, par); - vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par); - vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par); if (dsp_config) pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16; -#if 0 - FIXME: is it relevant for us? - if ((!dsp_on_off && !M64_HAS(RESET_3D)) || - ((dsp_on_off == vga_dsp_on_off) && - (!dsp_config || !((dsp_config ^ vga_dsp_config) & DSP_XCLKS_PER_QW)))) { - vga_dsp_on_off &= VGA_DSP_OFF; - vga_dsp_config &= VGA_DSP_XCLKS_PER_QW; - if (ATIDivide(vga_dsp_on_off, vga_dsp_config, 5, 1) > 24) - pll->ct.fifo_size = 32; - else - pll->ct.fifo_size = 24; - } -#endif + /* Exit if the user does not want us to tamper with the clock rates of her chip. */ if (par->mclk_per == 0) { From patchwork Wed Jan 13 14:49:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F19C43331 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 751E623741 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbhAMOw7 (ORCPT ); Wed, 13 Jan 2021 09:52:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727703AbhAMOwR (ORCPT ); Wed, 13 Jan 2021 09:52:17 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B26C3C061389 for ; Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id h17so1654487wmq.1 for ; Wed, 13 Jan 2021 06:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=qCaU5/PwjTYjtfnriB60Z9oLOr+vFl/C6eE9S2SqWRzje404GBkmpQhafug/AkVxOy cQQpoF2TPpvHLZ2G0WwI0m9I3+iSy5mECHxCRPxdVQEqbEaiQAKEQ21H2Puw7RerAiVE wFP15HZbbxQs2PH85CQiCco+76nv2mFTwq9YLxfrDpX1dbHfhcDj5xFdWbHJisbQiGp9 gXFKfd2QUbQryXwNq3Wq2jJyOgsjiru7oncOJDfA+X11+HkluVlV1zwafJGTb/u8E2G8 MRaYmLZI/XB7G9OUxyfbsMCiS30QwhZAVeTDBJWC+SfdIRLhSlZ+MEl7DCFddFc+gJo3 s87Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=gRYM7eAz28xkGAhyo10bKZWg7TeNPTT6mv/zQCmztXOennS6nAN5g3tYswmBG0CYAp F/yqMvvhX+d6YrtWWJCDTt0OQgcKCtwAyi/+KadU+oS4fXtVWtPdc1oMHzhfOHcHFlXI YyiCvSUd/yN4KmwFs7+RsSaPpUoKA1/G3u+EG2XR2xSsvuyW2UUIqYMKKN7KUQq33JbE hjd5guuHkN3J8KFyt7Ly3upVQZIthwZNJlQecLLlaI3as4DNrWghkioCrNuku5Cbs/1C pfWOofyPmymvd45oQqEKbMkHH5ldA4O+RpBVVbXVQzg3OnLEaHtqApiH0DCUG5KmwdFa YARQ== X-Gm-Message-State: AOAM532A70Saha3NfSdRnIgt+UD26kvktWwv8KuxKdbkNjFsCO0e4dC3 vIsDKAOlEVDYg91IZy2LVbN08Q== X-Google-Smtp-Source: ABdhPJzXGlHjQWCGWlwH0MsHBEeXn1e8tUGwLxoT/K65Pbdak+HaHN+93bMx8dcQNJlERhqlDPiH6w== X-Received: by 2002:a1c:40d6:: with SMTP id n205mr2609520wma.0.1610549437515; Wed, 13 Jan 2021 06:50:37 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 15/31] video: fbdev: via: lcd: Remove unused variable 'mode_crt_table' Date: Wed, 13 Jan 2021 14:49:53 +0000 Message-Id: <20210113145009.1272040-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/via/lcd.c: In function ‘viafb_lcd_set_mode’: drivers/video/fbdev/via/lcd.c:540:29: warning: variable ‘mode_crt_table’ set but not used [-Wunused-but-set-variable] Cc: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/via/lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 4a869402d120d..088b962076b51 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres, u32 clock; struct via_display_timing timing; struct fb_var_screeninfo panel_var; - const struct fb_videomode *mode_crt_table, *panel_crt_table; + const struct fb_videomode *panel_crt_table; DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n"); - /* Get mode table */ - mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60); /* Get panel table Pointer */ panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60); viafb_fill_var_timing_info(&panel_var, panel_crt_table); From patchwork Wed Jan 13 14:49:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73085C43333 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4130A235FF for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbhAMOwS (ORCPT ); Wed, 13 Jan 2021 09:52:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727706AbhAMOwR (ORCPT ); Wed, 13 Jan 2021 09:52:17 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6FB2C06138B for ; Wed, 13 Jan 2021 06:50:39 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id y23so1857553wmi.1 for ; Wed, 13 Jan 2021 06:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=AONsu4c49jYlWKZxIV71Fh+XZdaNm/Vzg4dgCbN9JbxTF4zXdk0hxy5yUAjRqlY1Xp nIupPjhqoIDmU9VkNJPtK0bN3YDe0f2AqkiUUwaqnLI5f/UzmCGOhingAiMylna4SnJ7 hLXn2MQXPU6i1MKuVELPGT8kK+K/FZOJI4dUhj0jPoBZq2Enr9vntVzkeQDu+4qMmsGJ v9PLkQKSiH7g77yfRhELqhLTHFPLU2Zj+6aaz97t1aI4q7b6mzr8jI36fIERyEk5M18O pFAOSj+Sqvp1t7uHTA6T4HOtbxb08KOCHlGCDgPp2Qf5TW3Vp2vXs9ztiYrfKzPx/xqZ 1DRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=o3+RqW+3T6266f5F66TCCpUSH7q2KEGeJBEZwcnj/LNnNRl0ZtCsmNpI7uUIPNOM2l Hd6bfofnTG35VRZOg7tgNgqqg5cO53UuIkKgM3VolAYq+VfHysmFZvJKBtYjpLjhzjch s62f71bEfGMM9fWIasvuJKUcEZS4DxuYmAy/PYBA1OLNyzz+oJrW+u89nFKMMyXf+nzc rR3wOeB3ZS7CZUgbQy49/6tzpDtR0xzORK+/FvK3sj96YVlVxeID9+s13geWo6lRBFQN T09cjbKyakjYHbQ4uquM6oS35SM3wYbvzSoiJD18Odjr0z4zt6OFSbiVcJ5NpIKb1wJG DrtQ== X-Gm-Message-State: AOAM532C4AFzNxZLkUy5hLUjEL01bCHKyz8dcw3ALRP1Oojm20tXqlkl Ot0XU6IfC4+5/9W06JZirguRew== X-Google-Smtp-Source: ABdhPJwgYTdZ2SuZ1GC/GjtSB8bSmqwzQcGAszf80Fej8Y4hpcF1LKJ1kwg1EITnZXMFsMy/JoGVCg== X-Received: by 2002:a1c:4843:: with SMTP id v64mr2570638wma.186.1610549438672; Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Jim Hague , Ilario Nardinocchi , Jakub Jelinek , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 16/31] video: fbdev: pm2fb: Fix some kernel-doc formatting issues Date: Wed, 13 Jan 2021 14:49:54 +0000 Message-Id: <20210113145009.1272040-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'pdev' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'id' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1721: warning: Function parameter or member 'pdev' not described in 'pm2fb_remove' drivers/video/fbdev/pm2fb.c:1765: warning: Function parameter or member 'options' not described in 'pm2fb_setup' Cc: "Gustavo A. R. Silva" Cc: Jim Hague Cc: Ilario Nardinocchi Cc: Jakub Jelinek Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/pm2fb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c index 27893fa139b08..6a30096676374 100644 --- a/drivers/video/fbdev/pm2fb.c +++ b/drivers/video/fbdev/pm2fb.c @@ -1504,12 +1504,12 @@ static const struct fb_ops pm2fb_ops = { /** - * Device initialisation + * pm2fb_probe - Device initialisation * * Initialise and allocate resource for PCI device. * - * @param pdev PCI device. - * @param id PCI device ID. + * @pdev: PCI device. + * @id: PCI device ID. */ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) { @@ -1711,11 +1711,11 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) } /** - * Device removal. + * pm2fb_remove - Device removal. * * Release all device resources. * - * @param pdev PCI device to clean up. + * @pdev: PCI device to clean up. */ static void pm2fb_remove(struct pci_dev *pdev) { @@ -1756,7 +1756,7 @@ MODULE_DEVICE_TABLE(pci, pm2fb_id_table); #ifndef MODULE -/** +/* * Parse user specified options. * * This is, comma-separated options following `video=pm2fb:'. From patchwork Wed Jan 13 14:49:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B57C43331 for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A107236F9 for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727943AbhAMOyA (ORCPT ); Wed, 13 Jan 2021 09:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727487AbhAMOvw (ORCPT ); Wed, 13 Jan 2021 09:51:52 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEBEC06138E for ; Wed, 13 Jan 2021 06:50:41 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id c124so1837584wma.5 for ; Wed, 13 Jan 2021 06:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=P/TckwyC+Zpm96Xw3jhnQcTPN4yEDByRSGHhaDy4FTUtGMu06Iu1Lz1wyjqkxnYGD8 Ka0UeFrgp+iGG7nEK9sOqDisiaFpLSK1hp1DISbHIQX8TDn4GphpHRUfABx50dTEboH0 qeaFWlT7UN/Vu7aoSNXpYCaMFlK+DfSHuhMJjBshrb8gKl2yGkzp7JIUWGPZphFnEfly 608DGRjP7K/CPR0c/OxOSedMrPcUuDd1OSXearvHBAU6PUJXtpFKR1uPWbedCfsb9D0l VZxN7mXIKLzNxEZYF8QgplqX7VbOWBfbEy/IEpStDEkkgxcfNRAH9CcHckNWX7BTHpf7 EMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=WCwPZHXk5C9IxYQIM0SwT+7QpmlFmdg+5cw5pYv1HuuORZwOmJ4FR05gQCImVAUQUF EtmkDfF48E5m9uEVXNAVaGFC2OS9kofvgjpgzbNy0KksAS14wTVHdA3Cqp6FHeu+R6V5 s2n3yAxdO0FHqIUGeN1tUG8+3weda1MU7esvpIV3TgatlWONhDR4ChjaPoS//RgEunDi LB+LaELyR8iboxwT5+KEIR8pNJ/vFkIxKgraWfpS6Y+1K8RMnd1sJz185n11qrt6qLc9 PRHtdq49Vso0TPAfA4svWpt6TU96TehMgtOYYYJP7Ir4ZV0quuA4iOjXkL3AMEbreTLB mo0A== X-Gm-Message-State: AOAM532xpLmq2z1vDgMAAIlnMjetRdtqVLVoYmFwEHUePzrgCN7kIalF folXql+nLArzcP+xBjCAYDvUOw== X-Google-Smtp-Source: ABdhPJzYqXQr0JAQFjeee0qoDpAYIIkOJfbnlgTUbeOjt6+QKL+q1AvPdGMRRUWutIMa4sTg1X4bsA== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr2598878wme.30.1610549439832; Wed, 13 Jan 2021 06:50:39 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 17/31] video: fbdev: aty: radeon_monitor: Remove unused variable 'mon_types' Date: Wed, 13 Jan 2021 14:49:55 +0000 Message-Id: <20210113145009.1272040-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/radeon_monitor.c: In function ‘radeon_probe_screens’: drivers/video/fbdev/aty/radeon_monitor.c:491:8: warning: variable ‘mon_types’ set but not used [-Wunused-but-set-variable] Cc: Benjamin Herrenschmidt Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/radeon_monitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c index 9966c58aa26cd..5ff01aa389381 100644 --- a/drivers/video/fbdev/aty/radeon_monitor.c +++ b/drivers/video/fbdev/aty/radeon_monitor.c @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo, #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C) { u8 *EDIDs[4] = { NULL, NULL, NULL, NULL }; - int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE}; int i; for (i = 0; i < 4; i++) - mon_types[i] = radeon_probe_i2c_connector(rinfo, - i+1, &EDIDs[i]); + radeon_probe_i2c_connector(rinfo, i+1, &EDIDs[i]); } #endif /* DEBUG */ /* From patchwork Wed Jan 13 14:49:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E87EC4332B for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20D0A235FF for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbhAMOyA (ORCPT ); Wed, 13 Jan 2021 09:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbhAMOvw (ORCPT ); Wed, 13 Jan 2021 09:51:52 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E81C061786 for ; Wed, 13 Jan 2021 06:50:42 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id 91so2406992wrj.7 for ; Wed, 13 Jan 2021 06:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K8LGsHawy1FykMfSNgFdlsHpkSijq6aQuT4rYUHFPB4=; b=vlfUbYCaI8nbSGsNOrvP4jNkRNNQft4Td7Q/qK7df3eMXHJiNDMJ7WqrL+lctbGzof irvEGx52lUUHqOlSxdne5KYtvcv637NvMYUh46CWn0hYxBYGrnYgpxsFeL+hxHB7aXZz nKEugO/vNXJaQpOyOYQD1cz7XxScABklnzNnXh+KI5q1rPET24SGQL0t9lgX19e+C7fR eFsxphGPTVhjYYo/VvE2TbVEkj/Dq8F69zcFARqN+rtlR6zQXNuUSLhFlkcsV/wpyhQh 1eMd62z5eauJMxNi8y0gGmRjshelxQz5tkvi3VyP8GGcTFLF5ZpE7yXf3E7Hveu5aQgK 93FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K8LGsHawy1FykMfSNgFdlsHpkSijq6aQuT4rYUHFPB4=; b=r7YllQOxqn797bBto8A1MGV9hXitT3NH6UZ4SdmJqi0yp+Dj43QUE6+t/mg+X4Imao yRjqovk4V8nI9Q6mj/+fkvXEsiV+t+ulHEuLJNHdKTO4F3FJHkDDAz6F5H2vcl4HYEP+ 4Zr0odT4ajHWOMeD43eV2Yl3YwB8kqpwV7ZjY3zrvZ5ZqdBV5Rp8LlX1HYwOHOqOdLSg 43awESUO36GO3h12uzhpxptA9MYF+QpbfL8dk96MZtv8v5w5oYQ/+SpP+R2vxHCuPH4X JRRzgmKtWaE0ZnuGQP+61wUTgqKEI6G5Ocj/Jn76Sx+6qbIlzm4Fqlsj85WeCh/sWtmw 503g== X-Gm-Message-State: AOAM5316eZZHPnhvGS/w7PlRJTfjUdfFbk5oaq+yUrvToYACB7VTpRXN K4diP8u3et1PbDk0pjolH7790Q== X-Google-Smtp-Source: ABdhPJwDJgxU/PSj6fZ35ddRgyivt16zN5Q0Jj9wVZXocDRBHdXbn58OnsQtAexupAPNKExN9UaOeg== X-Received: by 2002:adf:f18a:: with SMTP id h10mr3188792wro.244.1610549441019; Wed, 13 Jan 2021 06:50:41 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Evgeny Novikov , Mike Rapoport , Oliver Kropp , "Thomas J. Moore" , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 18/31] video: fbdev: neofb: Remove unused variable 'CursorMem' Date: Wed, 13 Jan 2021 14:49:56 +0000 Message-Id: <20210113145009.1272040-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/neofb.c: In function ‘neo_init_hw’: drivers/video/fbdev/neofb.c:1846:6: warning: variable ‘CursorMem’ set but not used [-Wunused-but-set-variable] Cc: Evgeny Novikov Cc: Mike Rapoport Cc: Oliver Kropp Cc: "Thomas J. Moore" Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/neofb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c index 09a20d4ab35f2..bec199a34037e 100644 --- a/drivers/video/fbdev/neofb.c +++ b/drivers/video/fbdev/neofb.c @@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info) struct neofb_par *par = info->par; int videoRam = 896; int maxClock = 65000; - int CursorMem = 1024; int CursorOff = 0x100; DBG("neo_init_hw"); @@ -1895,26 +1894,22 @@ static int neo_init_hw(struct fb_info *info) case FB_ACCEL_NEOMAGIC_NM2070: case FB_ACCEL_NEOMAGIC_NM2090: case FB_ACCEL_NEOMAGIC_NM2093: - CursorMem = 2048; CursorOff = 0x100; break; case FB_ACCEL_NEOMAGIC_NM2097: case FB_ACCEL_NEOMAGIC_NM2160: - CursorMem = 1024; CursorOff = 0x100; break; case FB_ACCEL_NEOMAGIC_NM2200: case FB_ACCEL_NEOMAGIC_NM2230: case FB_ACCEL_NEOMAGIC_NM2360: case FB_ACCEL_NEOMAGIC_NM2380: - CursorMem = 1024; CursorOff = 0x1000; par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase; break; } /* - info->sprite.size = CursorMem; info->sprite.scan_align = 1; info->sprite.buf_align = 1; info->sprite.flags = FB_PIXMAP_IO; From patchwork Wed Jan 13 14:49:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E03C43332 for ; Wed, 13 Jan 2021 14:52:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9520235FF for ; Wed, 13 Jan 2021 14:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727424AbhAMOvy (ORCPT ); Wed, 13 Jan 2021 09:51:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727494AbhAMOvx (ORCPT ); Wed, 13 Jan 2021 09:51:53 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FACC061342 for ; Wed, 13 Jan 2021 06:50:43 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id t30so2435605wrb.0 for ; Wed, 13 Jan 2021 06:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZRcivOWCu86KtmbW2EK6Np9SsvS7JZY4Xqa/qkwVtkE=; b=t1ER4nwN/WPM6fNnm/Mdum0Pojlr01P78z/COYqJ1z5HyIHjWoDRfik8SQHtBQqxQK YmiySxijr8E0W29ccNGw29mWFYTILvz8yqxd4Jhjz4xgCEkubT+0KFcPLzD/bqSuhqOv bwbne25dLdz4tncYRuqLl24YT+dNFgIwqI2SBJY9J4cgkiSXbIrT5qKhC9+mgB4yvQc0 udbu5Cayvxz6NRQyXKyHcIRbULqdBiGQkpmclevO2khhsi+G7TZ0owLOrYnOEnlNsCCt PsWXGjmGYEWJlNT1uNBNNRB3QkWWj1iQNibwkHhjoWky2+41zMmhl3Ve1ioMsvWRW5MO 3aKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZRcivOWCu86KtmbW2EK6Np9SsvS7JZY4Xqa/qkwVtkE=; b=SBbbOuTNvBE7pw9yR77hAMlWZy/+Yt3gXP9F9vrM58iNMC+wTk1y9uqRxTZmTShZeY ICSrfAWdzyXm80335xIs+7UDSozgkSkOVS2lsQCJ3hnqyCXfEqiMBejF4qCIq+OKwQY7 z1NrjnxRvZPL/pCvoS7QbNvAqxMDLuClbzKB+pEZ7aryOuaVe82LIB+O9wHRNZW27HCw UtHabtpn1hCwQ2Fi5WIofUK6CX59sf3Ot8DsTGZudghNw8RurzLP5KuQpOmKDAYxs1Hj 5lCWHUi7W4oefloUqd1a/ye8Vi5HRWQc7gTaJMJdbBGT1PGB0U6XBFtmR1hWiKHvw+Nh YmZQ== X-Gm-Message-State: AOAM533flWwt2V1Lj9M5cCyThDBtf1h7GVuJzaPmoMfGkhfLmEN0vO4D 92XNNF342FFyEwrTIfXNcH4NpQ== X-Google-Smtp-Source: ABdhPJySPsgzKgHkiIcO4ZfvmXeUEmf0jtG+A5MVr9yGI+9UHHrTEsVD5G/gBIMGMpLdJt4RrmnaQg== X-Received: by 2002:a5d:530c:: with SMTP id e12mr3033393wrv.54.1610549442170; Wed, 13 Jan 2021 06:50:42 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Hannu Mallat , Frodo Looijaard , Philip Edelbrock , Ralph Metzler , "Mark D. Studebaker" , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 19/31] video: fbdev: tdfxfb: Remove unused variable 'tmp' Date: Wed, 13 Jan 2021 14:49:57 +0000 Message-Id: <20210113145009.1272040-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/tdfxfb.c: In function ‘att_outb’: drivers/video/fbdev/tdfxfb.c:209:16: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: "Gustavo A. R. Silva" Cc: Hannu Mallat Cc: Frodo Looijaard Cc: Philip Edelbrock Cc: Ralph Metzler Cc: "Mark D. Studebaker" Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/tdfxfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index f056d80f6359f..67e37a62b07c3 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx) static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) { - unsigned char tmp; - - tmp = vga_inb(par, IS1_R); + vga_inb(par, IS1_R); vga_outb(par, ATT_IW, idx); vga_outb(par, ATT_IW, val); } From patchwork Wed Jan 13 14:49:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C917C433E9 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0313E235FF for ; Wed, 13 Jan 2021 14:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727599AbhAMOwD (ORCPT ); Wed, 13 Jan 2021 09:52:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbhAMOwC (ORCPT ); Wed, 13 Jan 2021 09:52:02 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 914BDC061345 for ; Wed, 13 Jan 2021 06:50:44 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id 91so2407125wrj.7 for ; Wed, 13 Jan 2021 06:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8AKZe0pvPLHu3x895juPn/Z4GbXtcqzxxje+6pz86KU=; b=MweOdz1mBiZ3YANYAenthalC1RAZ2L7YBzcfY2mxwBScLf0FZ7dfPLhGVCYJ3wStLt C3s1vvBrFa415Wr1aCWWYyc6yuvzFexaNiSTEv/rsPJ+qSMCxbo/gkIkbK6PkL7+YYiN j4X4qJFw6IVfKE3+eKxdcIPKq3uf/B3BN8WWKumhwaTV44EooXi7ZrrsGRMN/hPU9R9g aM2d+N3S2d8PdXVSrkZFhnz4GytrdOwPuh2vbjAk7nR/Um1bObWFqsibjGktJZnkTX2+ LSnF9sH+yRTO8ixzJlE682O8bs4obJ1NQRctXzq69GkYjy20O7QmRaSjmdm9hW95TO4e 51pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8AKZe0pvPLHu3x895juPn/Z4GbXtcqzxxje+6pz86KU=; b=QvEcU2Y9gxFE4oGBqjbqY2owOba2PQxJ6qIeMGNpW1E5305rcKqIhW8WNxtJvuUA4b SWLXBn9Ggk8P+TL+X8XmE+KItnYr2MJEv7BZqzThS8YeoC/1ai3546q+PkF6gpzF6cYC YEuin9OML4X+J6HYXGxfMEaQ8zOWqnQcteZbRgUKF2JrQFrI0rnaB26m2o6ZIh+2HAj+ nTySH9Dijkxnn/5zaywAXCyotnKzPH8N5eTtaVqcev/ObJEkmXXpNXJOcal+VgrcHe87 /3LTlVSDm5yh5XgYEovOZVoMHQQ8qJernEaLykz2YGvamhO77Hw2sgfTcOlZ802pnfhe nzlQ== X-Gm-Message-State: AOAM533hEMpfPES/S9PBCRbl3dnnN1SBmcmcALo6AWkdQbwMWuqQr1fL QNUX/THoCWxmpmUc40+u79YPbA== X-Google-Smtp-Source: ABdhPJw5rVCSN67wNU6TdCizFMPeOQwAc4JEScwBmwUscxQjY1orEkpeVLOPrWKc5N9q4Vjxl5enIA== X-Received: by 2002:a05:6000:124e:: with SMTP id j14mr3073602wrx.310.1610549443321; Wed, 13 Jan 2021 06:50:43 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, carter@compsci.bristol.ac.uk, William Rucklidge , Jes Sorensen , Emmanuel Marty , Jakub Jelinek , Martin Mares , Brad Douglas , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 20/31] video: fbdev: core: fbcon: Mark 'pending' as __maybe_unused Date: Wed, 13 Jan 2021 14:49:58 +0000 Message-Id: <20210113145009.1272040-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org 'pending' is only used if FBCONDEBUG is defined. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fbcon.c: In function ‘fbcon_exit’: drivers/video/fbdev/core/fbcon.c:3295:7: warning: variable ‘pending’ set but not used [-Wunused-but-set-variable] Cc: carter@compsci.bristol.ac.uk Cc: William Rucklidge Cc: Jes Sorensen Cc: Emmanuel Marty Cc: Jakub Jelinek Cc: Martin Mares Cc: Brad Douglas Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index bf61598bf1c39..f3d628fd07dc1 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3292,7 +3292,7 @@ static void fbcon_exit(void) #endif for_each_registered_fb(i) { - int pending = 0; + int __maybe_unused pending = 0; mapped = 0; info = registered_fb[i]; From patchwork Wed Jan 13 14:49:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B2EC43381 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C56A23600 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbhAMOwE (ORCPT ); Wed, 13 Jan 2021 09:52:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727633AbhAMOwD (ORCPT ); Wed, 13 Jan 2021 09:52:03 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C02F6C061346 for ; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id d13so2384811wrc.13 for ; Wed, 13 Jan 2021 06:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=h7CCOaMRu/KwDp4FkMru0iAXzhcqDT8Zgx3TFkmqeQ+lFmQabkd31QQ+lufeDRUy3X LtVPTgu8/Zqp1FSR8BAvO7dZtJzfFJCxlVtW1Nocwnb68P37FSE+be5cVVaNK5Tt8JCU 9w0Ph8RfNh92LMTOPQay3rdqNK2k+J9YHe1s4Pc7Cfwul+RTcoi4Ud5EHifbnQv/CgAl HXLZdEt7o50147fxcADWLOPX90H4PF4f7epdHBvT72f7b/PpYAha9w6yexNN/IIcz2uN fnQb+ZapvvgV5yFNpXtWjyjgqG+ixxGtM9qn4DjB5lbBlmDCcef1Kbvt5M9KefOQMbJJ FfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=iULB/bH9bezFpMhZJmQHjbAJn887M5GfW+iYDKzEzI5jkTjVJWg7KZL9s1G8Z5yZO8 Zlyu6WjtHge3tD6r8bFMQwzz+/vqbw+PSlwCVdswhKltX1zgr2RoWzacsqzHOIuIundb VTtKoYi8WoXhB5Vm9zArZcwAv1bght96RvFYyE8iJW50zALR94CuUCeT48bEl56AavZF hZzsOa5FhNGUEIQwutZPFBPJDMOkWQDanO/sg27MibmgdmP8hupDgYBAgyYe+I7eWKvY p2qHSwIPqDkPqhjH4e8WZXL/cAAM4ihkAZ5pv2RBqTuzGj2lV69SGPqNvfex7uGHLDJz YRuw== X-Gm-Message-State: AOAM5312tHNcJjHRK6Ppo/UdLFts0e8kWnhPKXj8wcFXLFNQY6mNOE7N W5726+/OhFrP/ruqO8J4tbnPeg== X-Google-Smtp-Source: ABdhPJyuIlFTIENDUMPlw5lomJPJtWMdNwJG+DPzaqlFIAPWPUczY5LQd4LCs7FSNVgCvZWujNH+Hw== X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr2937092wrw.379.1610549444578; Wed, 13 Jan 2021 06:50:44 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alex Dewar , Bartlomiej Zolnierkiewicz , Ghozlane Toumi , James Simmons , Paul Mundt , Urs Ganse , Helge Deller , Alan Cox , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 21/31] video: fbdev: sstfb: Mark 3 debug variables as __maybe_unused Date: Wed, 13 Jan 2021 14:49:59 +0000 Message-Id: <20210113145009.1272040-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org These are only used if SST_DEBUG_FUNC is set. Declare them under the same clause as their use. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sstfb.c: In function ‘sst_detect_ics’: drivers/video/fbdev/sstfb.c:934:26: warning: variable ‘n_clk1_b’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:16: warning: variable ‘n_clk0_7’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:6: warning: variable ‘n_clk0_1’ set but not used [-Wunused-but-set-variable] Cc: Alex Dewar Cc: Bartlomiej Zolnierkiewicz Cc: Ghozlane Toumi Cc: James Simmons Cc: Paul Mundt Cc: Urs Ganse Cc: Helge Deller Cc: Alan Cox Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sstfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c index c05cdabeb11c2..b8813a0b63b1d 100644 --- a/drivers/video/fbdev/sstfb.c +++ b/drivers/video/fbdev/sstfb.c @@ -931,7 +931,7 @@ static int sst_detect_ics(struct fb_info *info) { struct sstfb_par *par = info->par; int m_clk0_1, m_clk0_7, m_clk1_b; - int n_clk0_1, n_clk0_7, n_clk1_b; + int __maybe_unused n_clk0_1, __maybe_unused n_clk0_7, __maybe_unused n_clk1_b; int i; for (i = 0; i<5; i++ ) { From patchwork Wed Jan 13 14:50:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34870C433DB for ; Wed, 13 Jan 2021 14:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 066B8235FF for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbhAMOwJ (ORCPT ); Wed, 13 Jan 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbhAMOwI (ORCPT ); Wed, 13 Jan 2021 09:52:08 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E5CC061349 for ; Wed, 13 Jan 2021 06:50:46 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id q18so2432036wrn.1 for ; Wed, 13 Jan 2021 06:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=DVx9RGOhwl5u8ldZy5VrfBB5nqUBSa6oCbOAtc/naAE4if9nM+qG1VzCKee+LVG+3B pYMHjLmmVhejEEkmBIU3VqOIbS0QbervpRSbvt8RbrJ65WI6sdAQJIFHQBuqYquGY9sm C0BoNNBF1vlcU19yuj0aroZuKk5XVtUWIzVX0dv3Fl5+wU5eXqndsETD1SuasAlFPapO Ndex26m6UwPr44hJ1bIN/A68qcXyyjbFTxYEWrG/wLv+f8ePNT5PGN0tbNcfIJ6tyYVQ 66n2l1NmCju3l+XV3FxP/N8a/cWJvm9uSD3UZcReTj1OIqHd9zRtoKkjQOixv9hbaPDF TjNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=NWUMPBGrY75PIccMdoPaOzAje+mUFOq+V5pD7b3GEIZaJjee1ycvLzofFH5wEOuBQ3 igzxUd3d88WIwIZOkEKo845mtc+bCKIehS9Hsuk+7RYF9SIBTCj01fdFy0I6ZUCbF/RN M5Xx+Peg3R2r21d49MhLr31zg2fdC8FPOnnC7ySpCcugLTAfpZFyfW+NTMq07drO5v5x r8JHhxTPxW/hNTHZ6WF1I0F3bIzJBQ8qPoG3hKmhVSP7cO9vBZ+zsCoJM2FhY16Cynmi 5zhQpOypBvY8r7P+wq2EvFTA3VZ+fBME/qKqwcFRcB2PXq0a9J77JqTxRRUJ9kFAzXsx SjHQ== X-Gm-Message-State: AOAM532jFuEOUO5q0vQDHbeljtPdnJ4uS03E5JCz/FuqCqjmpt+9Pxcx ib6sjbi+UY/Nb643kFV4N7Rdsw== X-Google-Smtp-Source: ABdhPJzAZpIkSU3ZuxYWodWKq2E4apdvM/gowpmYALF9g0lHHwu0yWyxlERCrNd/IkX0NEsPk4cbEg== X-Received: by 2002:a5d:6852:: with SMTP id o18mr2897319wrw.371.1610549445789; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jeff Garzik , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Date: Wed, 13 Jan 2021 14:50:00 +0000 Message-Id: <20210113145009.1272040-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c: In function ‘WHDR’: drivers/video/fbdev/cirrusfb.c:2466:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index e9027172c0f55..f05160fa34da9 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo) */ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) { - unsigned char dummy; - if (is_laguna(cinfo)) return; if (cinfo->btype == BT_PICASSO) { @@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) WGen(cinfo, VGA_PEL_MSK, 0x00); udelay(200); /* next read dummy from pixel address (3c8) */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); } /* now do the usual stuff to access the HDR */ - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); WGen(cinfo, VGA_PEL_MSK, val); @@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) if (cinfo->btype == BT_PICASSO) { /* now first reset HDR access counter */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); /* and at the end, restore the mask value */ From patchwork Wed Jan 13 14:50:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D92C433E9 for ; Wed, 13 Jan 2021 14:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D74E123602 for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727655AbhAMOwJ (ORCPT ); Wed, 13 Jan 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbhAMOwI (ORCPT ); Wed, 13 Jan 2021 09:52:08 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 212D2C06134B for ; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id d13so2384961wrc.13 for ; Wed, 13 Jan 2021 06:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8R8CrMmu7yuBA/ZNIQZlAyfMprfiOkPW3GpI5ayBsWg=; b=q1+kp8rlc5YHssN6Eq89+XBI9+3PExs7mtj+vKpE1TFKE1rjX2///yzy+zDTZKSmOo veDWfzfkp2jlcqkWf6hyrhxd4ZIDNoNqF9HS7ddPt4booh+FDzx3O5uQ2G8rdhZHcVp3 PA1ZgIYstzQ14gHP1p8JOg40/+Qe5fqobxdt9bJb49f5X37fSTQnByGZCt6BqgU83z6p QzAtbnYyN0YvKG7g442YVr2E98ZQvzgo4BnA5yP33ogF0/EDLppn6AMEy+q/dBx0eQ5f Im6lCkgNGn1IZSkhzSUaYdClRbl34RHO4jN1MiOjnXDBZW66eOJRiiEjwIv769RVoAR7 qlfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8R8CrMmu7yuBA/ZNIQZlAyfMprfiOkPW3GpI5ayBsWg=; b=QbqdjRV9eFz/PZ5ndwPTuOQSFTNrDIel5V2CyU536GMzu+qzaXmGd6NLMRmyjiFvwM F//4eUqrIv8cjjohHpXI36oxENU3RL6E5nHmSu8nKWA3l8loXXuzv/1RgAVg4rhkqoVd 4DRQ82dbQJGrl8YBlX/9IWPJtZECDeEjnIzU4PSWfoqIeyWjXdA4ONt8YXvCgtKfNbUN 1FHcZ1EHP4TWyJvNXenTOC5mTXYVb+riD3zYNZesWYpq01kZVT6Y0RHDT/FyTBP2p9jE rMVmxZdPkLCC250mBgJD739oKIyCfgpXcAw4JYQNzfcPq70sR754MSrtnGJ0Mf35rDSV FElw== X-Gm-Message-State: AOAM532B4CivkPjXMNNLTY9XnUNIs579Mi1U3oVkhL5jQ4EJoS1eon13 09m1+ZBk2A8nRqRp9wPtuCGwcQ== X-Google-Smtp-Source: ABdhPJwF8QB82NwqEyn+scjHeSXF56DRGMKoUHEnV/4pPFJaM/1IosDrCdd2x+tLam8CZhkoj23PHQ== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr2926797wru.43.1610549446928; Wed, 13 Jan 2021 06:50:46 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Kristoffer Ericson , Thibaut VARENE , Ben Dooks , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 23/31] video: fbdev: s1d13xxxfb: Mark debug variables as __maybe_unused Date: Wed, 13 Jan 2021 14:50:01 +0000 Message-Id: <20210113145009.1272040-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Can't declare these under the same clause as their use, since debugging is enabled manually with an '#if {0,1}', so mark them as __maybe_unused instead to notify the compiler that this behaviour is expected. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s1d13xxxfb.c: In function ‘s1d13xxxfb_fetch_hw_state’: drivers/video/fbdev/s1d13xxxfb.c:644:16: warning: variable ‘is_dual’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/s1d13xxxfb.c:643:11: warning: variable ‘lcd_bpp’ set but not used [-Wunused-but-set-variable] Cc: Kristoffer Ericson Cc: Thibaut VARENE Cc: Ben Dooks Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s1d13xxxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index 4541afcf9386e..e6e8bc74412c6 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -640,8 +640,8 @@ static void s1d13xxxfb_fetch_hw_state(struct fb_info *info) u16 offset; u32 xres, yres; u32 xres_virtual, yres_virtual; - int bpp, lcd_bpp; - int is_color, is_dual, is_tft; + int bpp, __maybe_unused lcd_bpp; + int is_color, __maybe_unused is_dual, is_tft; int lcd_enabled, crt_enabled; fix->type = FB_TYPE_PACKED_PIXELS; From patchwork Wed Jan 13 14:50:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017031 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA666C43331 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB45223600 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727634AbhAMOwJ (ORCPT ); Wed, 13 Jan 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbhAMOwI (ORCPT ); Wed, 13 Jan 2021 09:52:08 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF80C06134E for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id 91so2407408wrj.7 for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=k1fbqp18yv8PIWF/VtBZ1OCxmUUxm3DEuDCdGpp/1lf2Qusjjl6Jr0LbNjCDkAYjum 1/wwNHwC2fYs6yOsRNYBp7G/0/6EKBrI0OVlE9krnhPcy8pLZI8vfx7yCAVMlSMwGOA+ hnp7cTdcUMYNnIJqWcxy66Lo1P3xlU9yPVOVU+OePlvMmIh7A0BSVnlshSywJYQQwzbU 5uukjwiQHWY6GeoO+bNuzYazh3MQdjtKvFY6BEa2ztaEJRUBzfF1uDCo9++RfRW+OfdJ ZYE/I/DDBlwjWjQBrwAXZdAbnCrtVk//3HRL1I6mCpS4vkKtNu8uXUKBPssO/APhiy0t CkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=d2hNDK2XStgThYDbpvfolUkV35vJ27AzcqB77lXLcrRZGtDEHgRQpNpbvjNF6relSM FzxUfOOGyDSMLm+Ql9WLyMtpR0CJLK5JJlIjCkF+5p5ffmkbhBi88Ich2isK688Pc9HA YKipVQAEVp5y78pcWUnkqy9rZ8P63igj8X9CvbWfhJaQ1vnFVTRrNSoSiGAtFO6t4p0v BTjs9HKw3a3uoGopSOD2BT3FS/57VJZY1S/yH4OOiJ1mB3urbhB3umqCCyDNuok71P6C Ydrwq1hig4K8uGfbvy0h5ooZdQVGBiQQmcpY38gWMWfA1iFjIYo90P2RwivyIwUlg6T7 HFQQ== X-Gm-Message-State: AOAM530862eqNvRa8SAztG3HSkjrRaVeD2Q2DelBCtrpzjsRLNDfAyba wTIyNIdpEXMekPZbcluIagqR7g== X-Google-Smtp-Source: ABdhPJzm7B7r7YLa6vfZWKXo9/XfNaBJsRwMRh4mKywkyucObHWaPSbUoL8ihPPgUVWu5+GcPhFQvw== X-Received: by 2002:adf:eec6:: with SMTP id a6mr2949891wrp.239.1610549448015; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jingoo Han , Ben Dooks , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:50:02 +0000 Message-Id: <20210113145009.1272040-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant' drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win' drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win' drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win' Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Acked-by: Jingoo Han --- drivers/video/fbdev/s3c-fb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index ba316bd56efd7..d33d7df77a6a5 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -75,6 +75,7 @@ struct s3c_fb; * @buf_size: Offset of buffer size registers. * @buf_end: Offset of buffer end registers. * @osd: The base for the OSD registers. + * @osd_stride: The OSD stride value. * @palette: Address of palette memory, or 0 if none. * @has_prtcon: Set if has PRTCON register. * @has_shadowcon: Set if has SHADOWCON register. @@ -155,7 +156,7 @@ struct s3c_fb_palette { * @windata: The platform data supplied for the window configuration. * @parent: The hardware that this window is part of. * @fbinfo: Pointer pack to the framebuffer info for this window. - * @varint: The variant information for this window. + * @variant: The variant information for this window. * @palette_buffer: Buffer/cache to hold palette entries. * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ * @index: The window number of this window. @@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, /** * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. * @sfb: The hardware state. - * @pixclock: The pixel clock wanted, in picoseconds. + * @pixclk: The pixel clock wanted, in picoseconds. * * Given the specified pixel clock, work out the necessary divider to get * close to the output frequency. @@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan, * @red: The red field for the palette data. * @green: The green field for the palette data. * @blue: The blue field for the palette data. - * @trans: The transparency (alpha) field for the palette data. + * @transp: The transparency (alpha) field for the palette data. * @info: The framebuffer being changed. */ static int s3c_fb_setcolreg(unsigned regno, @@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_release_win() - release resources for a framebuffer window. + * @sfb: The base resources for the hardware. * @win: The window to cleanup the resources for. * * Release the resources that where claimed for the hardware window, @@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_probe_win() - register an hardware window * @sfb: The base resources for the hardware + * @win_no: The ID of the window to be registered * @variant: The variant information for this window. * @res: Pointer to where to place the resultant window. * From patchwork Wed Jan 13 14:50:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F215EC433E0 for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB13223600 for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbhAMOxI (ORCPT ); Wed, 13 Jan 2021 09:53:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727687AbhAMOwN (ORCPT ); Wed, 13 Jan 2021 09:52:13 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80297C061350 for ; Wed, 13 Jan 2021 06:50:50 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id r7so2409673wrc.5 for ; Wed, 13 Jan 2021 06:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=ClTWBKea4vm3y9ZVGUdkzqdOECtwhR9PudkWuiyjwsis41BqC493w/zvDp2ojr1Xuc ZKnKrxsByJZR0AsZRzPwnncxKrIpJo8q/JxnXgt5uVjgHffxSyJ/m/GiYYZFr0k/fKPF mAUTMzojahcDs+ltW3aBgJgY0pUiUSDu1uCQsHcM5514XCdauiHH8Frr9ruELCw0BD/E FTVVet0fiPEihuRkcU9+1jE680PoB0pOR4Fx8MdQ56p1l1lAxW4F53kcOf3dMgFbW0wD nLFBJyF35Zz+nr0o3nFYMPOFbn8EmarY0vsbpWCUmYqEvxpBpYIoiNLTuo7DHxfJGp22 4RYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=F7lhjmfDQ6BM5+eilNcKvFbQRGlxYJeFwDo5UzGSK/N2vozv5sOjyu3cVZdNEAKJZp HoyOPoIbeFZtHg/XlUJNQ/BShCoBulXE1rT08L6ZnuRNqlSN7aMxQWMf3N5p/L5+U7EB 54MsEYEUm5NNOOJgEWq+RPkxkgcOjTSl09FYNvICTO/4LArasbgty2SzQRiyeP4TBAES IUs3d2vbYczFF4HJFRo0OfpYLNzvwTBTfBy0zx46vLr+DyUxDxLl4d2j5IbquVqYoRvV UjHjsp8W9GBmcf0syM/SpiveLe29qL4QHmNaFS6ETr5uWPLnrHBm9N2/f4MMarWxp34p JqHQ== X-Gm-Message-State: AOAM5313mzOuLHZv9dVtHGQeIW0+KgujQ7Zw1cP5eMyzqP62FfRoyL04 +HrjC2o4ddfmxHTepr6NaafHyQ== X-Google-Smtp-Source: ABdhPJy85VePePA0CqsKm5siGrKpak6OmOYMGqGLRupA7S/S8zgvi5kBWxRpHIlYj831TLmAru4Taw== X-Received: by 2002:a5d:674b:: with SMTP id l11mr3094653wrw.247.1610549449265; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Arnd Bergmann , Software Engineering , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 25/31] video: fbdev: mx3fb: Remove unused variable 'enabled' Date: Wed, 13 Jan 2021 14:50:03 +0000 Message-Id: <20210113145009.1272040-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c: In function ‘sdc_disable_channel’: drivers/video/fbdev/mx3fb.c:448:11: warning: variable ‘enabled’ set but not used [-Wunused-but-set-variable] Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index 894617ddabcb6..d1c8f7a969ac3 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *mx3_fbi) static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) { struct mx3fb_data *mx3fb = mx3_fbi->mx3fb; - uint32_t enabled; unsigned long flags; if (mx3_fbi->txd == NULL) @@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) spin_lock_irqsave(&mx3fb->lock, flags); - enabled = sdc_fb_uninit(mx3_fbi); + sdc_fb_uninit(mx3_fbi); spin_unlock_irqrestore(&mx3fb->lock, flags); From patchwork Wed Jan 13 14:50:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB720C4332E for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A48BB23602 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbhAMOxH (ORCPT ); Wed, 13 Jan 2021 09:53:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727693AbhAMOwN (ORCPT ); Wed, 13 Jan 2021 09:52:13 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2396C061358 for ; Wed, 13 Jan 2021 06:50:51 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id e25so1865359wme.0 for ; Wed, 13 Jan 2021 06:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fiTAiO1+djM4LYXjGKueW16bvgv2sBtNiLbtIOEARdk=; b=IDza5YLilamkwPDT+g2/a0lofmuncKNpAv/y/6ZQX7PTgZHHrzIscPArIaLwzgGk21 +PTQkWm+NELC+KC9BFDcWCwiEBGUoc7D99iVhf/b8Zau/fF4+imDj62ocQwZfhj48s7p G301bdVxqdgcGdeZ0mOu5lmhiQU2WC/WPRGqNZpFfUOiJAjYflnQOI3iCRme45LwRAT5 UA87z3v5OeC740plgM+jScryysn9swGK41grynXPhZPBHzL1uyI195awHeRx0r0D+KV6 M3YDyk1IDQxUtVgKliH+QZdMV6naG94aZh3W2EpFGPxDHMNQ6+AhIUIbY31cyP7lq5uP Fxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fiTAiO1+djM4LYXjGKueW16bvgv2sBtNiLbtIOEARdk=; b=uodIqTmS7Vk3X7hvx6+Ec6XFN11Y7N0XEEcb9WLJ9Me489jK6b5R6KlnAFVAlzM/3U IKba0XM+fjEQEh/8Uy/uUj0ll2w3wa4UbwmMGtOshqZr32ZzCogxKesMuGHCmMukCwNv 6h68/3voGEsWQwnpLu56Jdq3YdMgpmbZNi48e3B3hdpJvwPnTXlrrReCj99ZOoxszPPw ZdEfB18JoFpgIWEbFly2uB0K31JK2I/yG2zMI68ooiiGKss9Mu39j6TXBiBldy3A8GLX FVzLfm3L0QtBKGWqCgcsNBwPHTE9l9xaXIoeJaMjIY5EmMYnaYtNQ7TbOYnAuEZ13rJB 1xXw== X-Gm-Message-State: AOAM531MmRcg7qociE34S579NO1w7sDXTnn7LcnGVFODsK1nVQC5KUVa uvPanPyMDYGEiIiZdQDYYifW2g== X-Google-Smtp-Source: ABdhPJzn0hsHSArPV+PdoU3MwAI+uaM7MfxzC+Q9pFqpa5/9nfQ0iIqmvEqP+hOl9RxA7AZoMzJjNw== X-Received: by 2002:a1c:988f:: with SMTP id a137mr2554157wme.130.1610549450459; Wed, 13 Jan 2021 06:50:50 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas , Jeff Garzik , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 26/31] video: fbdev: riva: riva_hw: Remove set but unused variables 'vus_p' and 'vus_n' Date: Wed, 13 Jan 2021 14:50:04 +0000 Message-Id: <20210113145009.1272040-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’: drivers/video/fbdev/riva/riva_hw.c:845:23: warning: variable ‘vus_p’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:845:16: warning: variable ‘vus_n’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: Jeff Garzik Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/riva_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c index 4ee63f7d84d3e..2bc510c24aa9e 100644 --- a/drivers/video/fbdev/riva/riva_hw.c +++ b/drivers/video/fbdev/riva/riva_hw.c @@ -842,7 +842,7 @@ static void nv10CalcArbitration int found, mclk_extra, mclk_loop, cbs, m1; int mclk_freq, pclk_freq, nvclk_freq, mp_enable; int us_m, us_m_min, us_n, us_p, crtc_drain_rate; - int vus_m, vus_n, vus_p; + int vus_m; int vpm_us, us_video, cpm_us, us_crt,clwm; int clwm_rnd_down; int m2us, us_pipe_min, p1clk, p2; @@ -924,8 +924,6 @@ static void nv10CalcArbitration us_pipe_min = us_m_min + us_n + us_p; vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */ - vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */ - vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */ if(video_enable) { crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */ From patchwork Wed Jan 13 14:50:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E4CC433E9 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5FD02389E for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbhAMOwT (ORCPT ); Wed, 13 Jan 2021 09:52:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727714AbhAMOwS (ORCPT ); Wed, 13 Jan 2021 09:52:18 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C50C06135B for ; Wed, 13 Jan 2021 06:50:53 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id n16so3770066wmc.0 for ; Wed, 13 Jan 2021 06:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RvwJoM6XPaTXW+swhyuXIxTf/L820o0O05r3Nn2BahU=; b=nid9QSSJw0nnYpdBxWNfeDxySbsTdIoMqZnUcmEnH52+LjrzqEPdVxtuCSQU+wNDQp 62FqX/weiPQySDiuQC9amofCPbG5004lDcrdnsnbkZYpzAuZJWvH09KtuoWBDRa2aWSO AocjLmQI+CLfzX2ZsW6YPb2EJJtPlz/GlBtg1LtWbQlVwwHB11QS8Mte86K91VCLTbrK fFJLvGRnloBApapS2VcH6Q1I7KdGDGhrjWmsEMB+WKoFpwYMTT3bIWKLWXdKJxr7Xn8w cAkIudEJcSr3GiCxwMMFUlqXuSrqw8ck0D0hkmDyZxfdnSB9sa3sIlBp8zjyERLJw0nR orsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RvwJoM6XPaTXW+swhyuXIxTf/L820o0O05r3Nn2BahU=; b=bqaX4xHIzPFlJkXaqKV93ZqyGi3ZOdIW1XAuVNsyJOPRqweb3SF5ZKY0DQx0IRXrM/ WaxurL9zZKg5k/W82q95VvYdONAzvbFQSYqUW+uuhbi/rpLvwcbVpKmQ0UnLjkxvJTaZ 5GLWREa8Jq89q52lGEECZsKCtKWZotI6adlEu7MOvtZ6MuFSzNov5GUzNukTvcvSHOJb EFbjE34RN3N8F/KeWgsHXdp8gp8ZJkATvvI2jTsPj4eUEGV2ljCxB92WsAmy6zYaWOfA 41uvdPuSlIHMf3k100Yxgk9oEXB2W2IH7kzerNKAK8x3OKujydBTvztUdx/krPfNRs6z 4Sng== X-Gm-Message-State: AOAM5304xGNSc3aK2lv7slRwby48HLFU5YRwLqQun47vwXDnHxn1Jzpb x6XdGTMEtwzf7eg8A2AHnUw1akpklVjIiOxF X-Google-Smtp-Source: ABdhPJxfLq1AkB7CSlngKBkLh9QrvLjSYsWJajt2KPoiRKEuRYNd2u3c5lDCPhIKbXF1gj4rQNYUUA== X-Received: by 2002:a7b:c85a:: with SMTP id c26mr2464833wml.160.1610549452072; Wed, 13 Jan 2021 06:50:52 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 27/31] video: fbdev: sis: init: Remove unused variables 'cr_data2', 'VT' and 'HT' Date: Wed, 13 Jan 2021 14:50:05 +0000 Message-Id: <20210113145009.1272040-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’: drivers/video/fbdev/sis/init.c:3543:37: warning: variable ‘cr_data2’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3542:39: warning: variable ‘VT’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3541:39: warning: variable ‘HT’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/init.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index 4510272ad297a..b77ea1a8825a5 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -3538,16 +3538,13 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, struct fb_var_screeninfo *var, bool writeres ) { - unsigned short HRE, HBE, HRS, HDE, HT; - unsigned short VRE, VBE, VRS, VDE, VT; - unsigned char sr_data, cr_data, cr_data2; + unsigned short HRE, HBE, HRS, HDE; + unsigned short VRE, VBE, VRS, VDE; + unsigned char sr_data, cr_data; int B, C, D, E, F, temp; sr_data = crdata[14]; - /* Horizontal total */ - HT = crdata[0] | ((unsigned short)(sr_data & 0x03) << 8); - /* Horizontal display enable end */ HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6); E = HDE + 1; @@ -3584,12 +3581,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, sr_data = crdata[13]; cr_data = crdata[7]; - /* Vertical total */ - VT = crdata[6] | - ((unsigned short)(cr_data & 0x01) << 8) | - ((unsigned short)(cr_data & 0x20) << 4) | - ((unsigned short)(sr_data & 0x01) << 10); - /* Vertical display enable end */ VDE = crdata[10] | ((unsigned short)(cr_data & 0x02) << 7) | @@ -3604,8 +3595,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, ((unsigned short)(sr_data & 0x08) << 7); F = VRS + 1 - E; - cr_data2 = (crdata[16] & 0x01) << 5; - /* Vertical blank end */ VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4); temp = VBE - ((E - 1) & 511); From patchwork Wed Jan 13 14:50:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFFEC432C3 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68F5523600 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727714AbhAMOwT (ORCPT ); Wed, 13 Jan 2021 09:52:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbhAMOwS (ORCPT ); Wed, 13 Jan 2021 09:52:18 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9283AC06135C for ; Wed, 13 Jan 2021 06:50:54 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id r4so1844020wmh.5 for ; Wed, 13 Jan 2021 06:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9xOmpZJSJcGjkWdwzXh/1wdxHxk1qdbTp529iSzZw+A=; b=MymSG+nXTdHHBzQGPOze7DAAa+ej555u1BcqPgKwDdULmCR+9lifj/RBMgwbwLjlyt elvEBNHzvmvW/yms4fg79Qi5WzxgrFr7YClQKZgIpcNwnQ6ljdR5HdRdcTX3fA10rdIO aO30H/7nbBKrI5hxOWH6sSs6sEMtOANO1pinWzByh2d2GV3m/EpoTjowTDqX+0kZ8xaX liF75WImH8LTXSQqNUBp9HlqfewIAHFYh7spBcCRwDuq6cWAwda7+vnAqeuvQNX58v7P 03COI9tjDj1PG/ZMJxlUk7Sxq24UPa6mvTMs6nk8c9qwdcBQeIG7i50znWEf+3nSQ5RB JzdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9xOmpZJSJcGjkWdwzXh/1wdxHxk1qdbTp529iSzZw+A=; b=py3cwGUscMDEUgsPjNBkkxujCwnCxjZd3sn8M9hwgpHfbn3ie+fyZWFvWLdvgCFS4M a4gZS9UQsPoWA9XrwgCkgsHlIj/PpOfAXey24jWGyB5+kCjzqsRwfCCiCA4z4n8nmm+I HQhN/x+nNL5I/P6XD8w1BGZ0eIgPlxvJIPSyhORQhBO7kd4Pk2O89ePIdsy7DphZbZMD p10hlcahaQOM/2NsnBMY/bDPqMMcgO82D1YWkN98rKBx7L4JP52XHOKZ/sxXGpJ2USoO fcB4IkMyHI2vLAX1jJQUI2vca1KuFlsJ+ei1CdwBFk4Gpbhbwr/am9YSJQ8761EfzaZw Wy6A== X-Gm-Message-State: AOAM531a9uLKr1ITZaQY33V/CVZ/3jEiGczA/AA4NuQ4yiblK9pE+Hfw Kx2mIwqQt+nfTvfxjSnbnxutWA== X-Google-Smtp-Source: ABdhPJy1eR+KY9VjvEkheIzVcqWp7XoiAxVirwoH+ntCmyxPC42Czfx3zHGSaOqSDxojIeI3efM6eQ== X-Received: by 2002:a05:600c:29cc:: with SMTP id s12mr1724821wmd.180.1610549453390; Wed, 13 Jan 2021 06:50:53 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jeff Garzik , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 28/31] video: fbdev: cirrusfb: Add description for 'info' and correct spelling of 'regbase' Date: Wed, 13 Jan 2021 14:50:06 +0000 Message-Id: <20210113145009.1272040-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2815: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_reg_dump' drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_reg_dump' drivers/video/fbdev/cirrusfb.c:2859: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_reg_dump' Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index f05160fa34da9..bb2cc753c1cf5 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2800,7 +2800,8 @@ static void bestclock(long freq, int *nom, int *den, int *div) /** * cirrusfb_dbg_print_regs - * @base: If using newmmio, the newmmio base address, otherwise %NULL + * @info: frame buffer info structure + * @regbase: If using newmmio, the newmmio base address, otherwise %NULL * @reg_class: type of registers to read: %CRT, or %SEQ * * DESCRIPTION: @@ -2847,7 +2848,8 @@ static void cirrusfb_dbg_print_regs(struct fb_info *info, /** * cirrusfb_dbg_reg_dump - * @base: If using newmmio, the newmmio base address, otherwise %NULL + * @info: frame buffer info structure + * @regbase: If using newmmio, the newmmio base address, otherwise %NULL * * DESCRIPTION: * Dumps a list of interesting VGA and CIRRUSFB registers. If @base is %NULL, From patchwork Wed Jan 13 14:50:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8264C433E0 for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F6D223600 for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbhAMOwq (ORCPT ); Wed, 13 Jan 2021 09:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727734AbhAMOwX (ORCPT ); Wed, 13 Jan 2021 09:52:23 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB22BC06135E for ; Wed, 13 Jan 2021 06:50:55 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id w5so2387847wrm.11 for ; Wed, 13 Jan 2021 06:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=r5T8a1xoDb37mL9jIaJql8CuqF65c13F0JN0BADlmBJtoOSiLcHLQQE0zXy42jaISG L+mOCdoDYshlaFwezWabUiL61Rpla5d4FFyMQCCDUECkUNO1e6hFSngniGnbMl3TwRw+ 0YBTdOFYXyzAsLFnu8j9xEbDQHDJuqj6YN1tK1TxHEmTQvc5vFrEV8J9bQUUCzhlQc/L uEKFperGkCjqCYYjupjJDiL5O1pf0WMWVTyoYuZMKqCrDTJBlNsucq2nS6FxjcouMcm8 ZJnYRxOZO/pAbljJIw7+ZWc1fEo6pqh7BSCCdYtMIEOpTqkl93Az01qWCSLh9dnj+3/e 0yYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=QddTVf3lr9OOq38qIkphofpN+ycGTnbMk3qmEBoEFU0262tpCIEFsXBpFkfX7IaSYS yoLcVw8aTZmJqNZODH5zI5HmI1o1f/wpog1gmcSYhf4/Tp8ZAb1MaZeEO2/O7jT2jHvB pRd0W7FQYB9x1wrTfQGRiPvqFCIay/OoM1U9qZgfiSrNZQQ4wAD4Yy60sVMIcPEsQqiP 6LrE2Y2US3hQRsf1BXiiNEor/zd1v7j7jAdWZGVoyK4tsy9PeAlYiI1mWi8YXpKmMRoM 5tXNiFAv/pM5nO9XPHKSoueDwa87ILGj5+2DP4E+AUoWDS/JV/98tC5+ebRAEXkL03MI BPZg== X-Gm-Message-State: AOAM530anki7RsUj8iK8jmeZN+kdL246m+L1hQGZmk9RmXyvF6mD7sbJ RYy8fgL19ujYiCs1pW+K6rhSdA== X-Google-Smtp-Source: ABdhPJwWW8Mh0VQz40rTJwa/0e7kE/8p2NvxyZJuFij95jhV38CZu46wo+9mK5ByYWZwB9G7KRUEhQ== X-Received: by 2002:a5d:5227:: with SMTP id i7mr3134555wra.68.1610549454505; Wed, 13 Jan 2021 06:50:54 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Kristoffer Ericson , Thibaut VARENE , Ben Dooks , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 29/31] video: fbdev: s1d13xxxfb: Function name must be on the 2nd line in kernel-doc Date: Wed, 13 Jan 2021 14:50:07 +0000 Message-Id: <20210113145009.1272040-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s1d13xxxfb.c:515: warning: Cannot understand * Cc: Kristoffer Ericson Cc: Thibaut VARENE Cc: Ben Dooks Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s1d13xxxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index e6e8bc74412c6..b21627c07f8d0 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area) } /** - * * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function * @info : framebuffer structure * @rect : fb_fillrect structure From patchwork Wed Jan 13 14:50:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A242C433DB for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F940235FF for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbhAMOwp (ORCPT ); Wed, 13 Jan 2021 09:52:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbhAMOwY (ORCPT ); Wed, 13 Jan 2021 09:52:24 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B795C061795 for ; Wed, 13 Jan 2021 06:50:57 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id m4so2391130wrx.9 for ; Wed, 13 Jan 2021 06:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5kBvB4NkQBZ34V2o1ex42K5vSl0rdRhcvGCTff/v+VQ=; b=CX3P+S9L4wGYuGSks00quxfFpZEPOVPivW0r/M9EjGfhtOTkdgaF5aDbimCQt5ON7+ ArYJ0aOzuZ3UQN/A8k7aMly33N16m2n25UqGKwjTU66wrXGcVp4c5o146iISuqMXolOE WHoahwD7dLOGZnK8I/aajIntcVornbKvK8GVcqxWXPCDEJzONy6QEKkTDIVeQ8br91/B RLFAOAbBTU2oZTL9ZOn/+bu+v4ss+ptf8QatATZZ/Qx5NWvYLhjlLcrxcQuf9r+tNcWM SmKKOt26cZHRlMc5SPNWHLCaCXTz35T5oJO8GK2T9EC+lLSv5P25KG/huKlSGIoTohQG tmUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5kBvB4NkQBZ34V2o1ex42K5vSl0rdRhcvGCTff/v+VQ=; b=XEnzOmr2I+ZWMKezdPzP1u1yEa2igOHtWkjvalRBlTaeESDjkMPDjc/DK3CSwvdNc8 2mR8pscnT9SFrK04V+R1yGG+nxAXm29rpcHK1qpIg42hsSieqUkAu8yJOXslqIefvUV/ l+0FcoEKQt194Xx+EIbq0vw3HSbwLT9eSCsksxkXDh/JYbdB+6D+1rVWgRq0BGGO4g+a QuuW+BL3Ut5C05XByPJopZEKecnul7oykbWHJIi0RLjt+QITbRIcbHH3ptN+SnkeqVIT DjCuh27UPPL/5wtFV+3P5AtCAYodDEzzdDqUoT2NLZJ/4ybi+JCVXyBmPX5b9qxNJbbF PTxQ== X-Gm-Message-State: AOAM532QI1jIXArSF8TmTeh1+2snVCV0GxE3JIKWjJLIFHzGSAdIjUy/ WXOGhsXnA1+1JtpqqWOolDQIVA== X-Google-Smtp-Source: ABdhPJw1ufVOnrS2JPmqkNrZy8h6u74DEt1BTq/yWKFBkHEkejsbQDOSJfyqheFLrclUErFWt5afkg== X-Received: by 2002:adf:f18a:: with SMTP id h10mr3189875wro.244.1610549455814; Wed, 13 Jan 2021 06:50:55 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jingoo Han , Ben Dooks , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 30/31] video: fbdev: s3c-fb: Remove unused variable 'var' from 's3c_fb_probe_win()' Date: Wed, 13 Jan 2021 14:50:08 +0000 Message-Id: <20210113145009.1272040-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’: drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not used [-Wunused-but-set-variable] Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Acked-by: Jingoo Han --- drivers/video/fbdev/s3c-fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index d33d7df77a6a5..91daeca5ca392 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -1173,7 +1173,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no, struct s3c_fb_win_variant *variant, struct s3c_fb_win **res) { - struct fb_var_screeninfo *var; struct fb_videomode initmode; struct s3c_fb_pd_win *windata; struct s3c_fb_win *win; @@ -1201,7 +1200,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no, win = fbinfo->par; *res = win; - var = &fbinfo->var; win->variant = *variant; win->fbinfo = fbinfo; win->parent = sfb; From patchwork Wed Jan 13 14:50:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12017039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB243C4332E for ; Wed, 13 Jan 2021 14:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9801723600 for ; Wed, 13 Jan 2021 14:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbhAMOwp (ORCPT ); Wed, 13 Jan 2021 09:52:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbhAMOwY (ORCPT ); Wed, 13 Jan 2021 09:52:24 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C301C06179F for ; Wed, 13 Jan 2021 06:50:58 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id w5so2388016wrm.11 for ; Wed, 13 Jan 2021 06:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=dw+awuMm/xszxko06x1zbZDXJLrY8h9w46Ii0r1I8t7M23qIokSEWF+lctfR7ifEG+ 10hTw/DwZRUnEFPhAVSO68dOG3xRMSECzOqgPEZGcaXkIwEZpNzwO47CVeLh022fRJlH jDBbte4+oRAEKQsXCuHQ59dmP92NSYRrJJV3l5taYJRqGkZfD+TVnytK3qk0j65GJPKu 2f+mh5IUw8l2pURTp/2Vx0/xKSO+Pb15iZss30ox0FSMT0+dZ7zRgUjqCFkx8UoasarG 0QTSmkjRG6zgnWk6plq18kDAdy0dxgi5AzQNxp96r0OLZ3jhu/aqmtWdmf/vSBNmKOFD AtZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=RmgbXUZI6qXVll87FfnJ6ZAzyahiYI996OnQv3ZNqwxPbtpM5O4amxF5Y81SsuvYvT 72aNDed59bq8To9Njej1QXZm3hKgq8ZimLd9yzt0jlksIcCedUAkHvTW2Bk3O+/JitDO Y1HRLba1NFNAGbJrThFhRMsJ0rinw4nqEbkpRwlcrhVSPckaOfiV+jb2fpnWFZo+D/LD wdJBJf80wEa/nqitjJwn7X6aSKsosSzBypuX8dtC5S88WcNPjgjbq0cxtYE/9OmRxHvf iIk3xpxBIRZcjzRO7tSOFV71ye3XrCefX9872fQ1AH6YxLnhCC6KKMvL0qSA7TOvCdes 5h9A== X-Gm-Message-State: AOAM532TWRhkKtV/geRhV2cS1LCIZiOA/IzQXlw/3ONaAo99lPh4Etxa Cxn8eJUKab0DrlezemyxencR/w== X-Google-Smtp-Source: ABdhPJxI76cMcy6SPfmM5W3HPZ9oHq45qLxC2KpwnypdTX8IGDVuElLlSdIgg82G0B9F5jmQLXJfmQ== X-Received: by 2002:a5d:530c:: with SMTP id e12mr3034474wrv.54.1610549457244; Wed, 13 Jan 2021 06:50:57 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Arnd Bergmann , Software Engineering , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 31/31] video: fbdev: mx3fb: Fix some kernel-doc issues Date: Wed, 13 Jan 2021 14:50:09 +0000 Message-Id: <20210113145009.1272040-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c:738: warning: Function parameter or member 'fbi' not described in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:738: warning: Excess function parameter 'info' description in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'blank' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'fbi' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1134: warning: Function parameter or member 'fbi' not described in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1134: warning: Excess function parameter 'info' description in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'dev' not described in 'mx3fb_init_fbinfo' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'ops' not described in 'mx3fb_init_fbinfo' Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index d1c8f7a969ac3..a0fad25136fe5 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -731,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi); /** * mx3fb_set_fix() - set fixed framebuffer parameters from variable settings. - * @info: framebuffer information pointer + * @fbi: framebuffer information pointer * @return: 0 on success or negative error code on failure. */ static int mx3fb_set_fix(struct fb_info *fbi) @@ -1104,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fbi) /** * mx3fb_blank() - blank the display. + * @blank: blank mode (unblank, normal, {v,h}sync_suspend, powerdown) + * @fbi: framebuffer information pointer */ static int mx3fb_blank(int blank, struct fb_info *fbi) { @@ -1125,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info *fbi) /** * mx3fb_pan_display() - pan or wrap the display * @var: variable screen buffer information. - * @info: framebuffer information pointer. + * @fbi: framebuffer information pointer. * * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag */ @@ -1384,7 +1386,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi) return 0; } -/** +/* * mx3fb_init_fbinfo() - initialize framebuffer information object. * @return: initialized framebuffer structure. */