From patchwork Fri Jan 15 19:30:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 12023945 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D96C4332E for ; Fri, 15 Jan 2021 19:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B17CA23A9D for ; Fri, 15 Jan 2021 19:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733119AbhAOTbK (ORCPT ); Fri, 15 Jan 2021 14:31:10 -0500 Received: from mail.zx2c4.com ([167.71.246.149]:36304 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727639AbhAOTbK (ORCPT ); Fri, 15 Jan 2021 14:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1610739026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7BaNXWOkaA65p8n11dAlACCraC+MzlfwCOIG3MhWrHk=; b=Mg1YiCm4JcgjRFChNaaTX1xOutjzCMiMfe6UdC1ymN0INqS2gdRXk3i562QDly4ePWcGq6 zr5iDy/4l/lPVOP4IvB2mpCW5T0dC+C8MfRlO06SxKxshGM+oG6AnPOA7kIcQkQXR3qHbt uGD8OMPsRFOwHWhW71Ps14jr54Dn2JY= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9d76af42 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 15 Jan 2021 19:30:26 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-crypto@vger.kernel.org, ardb@kernel.org, herbert@gondor.apana.org.au Cc: "Jason A. Donenfeld" , John Donnelly Subject: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function Date: Fri, 15 Jan 2021 20:30:12 +0100 Message-Id: <20210115193012.3059929-1-Jason@zx2c4.com> In-Reply-To: <20210115171743.1559595-1-Jason@zx2c4.com> References: <20210115171743.1559595-1-Jason@zx2c4.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org With no mod_exit function, users are unable to unload the module after use. I'm not aware of any reason why module unloading should be prohibited for this one, so this commit simply adds an empty exit function. Reported-and-tested-by: John Donnelly Acked-by: Ard Biesheuvel Signed-off-by: Jason A. Donenfeld --- v1->v2: - Fix typo in commit message. lib/crypto/chacha20poly1305.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c index 5850f3b87359..c2fcdb98cc02 100644 --- a/lib/crypto/chacha20poly1305.c +++ b/lib/crypto/chacha20poly1305.c @@ -362,7 +362,12 @@ static int __init mod_init(void) return 0; } +static void __exit mod_exit(void) +{ +} + module_init(mod_init); +module_exit(mod_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction"); MODULE_AUTHOR("Jason A. Donenfeld ");