From patchwork Fri Jan 15 20:08:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024037 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECBAAC4332B for ; Fri, 15 Jan 2021 20:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA46323A5A for ; Fri, 15 Jan 2021 20:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388231AbhAOUKb (ORCPT ); Fri, 15 Jan 2021 15:10:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727278AbhAOUJ5 (ORCPT ); Fri, 15 Jan 2021 15:09:57 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A710C061794 for ; Fri, 15 Jan 2021 12:09:17 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id k10so8473123wmi.3 for ; Fri, 15 Jan 2021 12:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ruuzqVcibszll2eFO33TUxrB4tXdgXcWaZZEtfFtK0U=; b=K0QIJJrtbTVVGnm0417IN5WqEh5ppaxUlhR0OqXfdBdbiKbbRwer5uHYKYJTtXAktz gZZZbU8CVeAvuoa7EVilbQ8aU8UYprMBp5p4uFXlXWES8OaLPrh/7vL3XPX0+52nQF+u q9GKE9sELVG7doX8KkvQ0b023p8qEDOF8KJPtEERAgZnhE+A5t0UHh15EIcRYASV5oix HLry1ARTaBQiDDOB3mDQuMcltIu00Xjswrs8gGEQTjmXfkBz65sq1E82JK49LYpUh5wE QkXeVB5s/d03vawDvs/XAtoNa5DI0QNCH8+HYQTP2g5sg1Xt+5qJ2XKUJfHyxCQkhMX5 WKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ruuzqVcibszll2eFO33TUxrB4tXdgXcWaZZEtfFtK0U=; b=A7B0IzRqgNgSuwQ7qHG4R2syN5dzhl5zYmDX3fiEs9BlhaOjHEAt009pPd3yISplf4 ZtIO77q/n3c64JIv4ObWhQikJXBk1oBtgh+1TbdrD+2ABg4hOkmeSK28FEJ4GE4RAbfK 7scnPtvbosPmwxaGE1xsWgzZmGZPIyeeUOQY5bS5+9mfj3UD+wrZqjKIu4c4AbRfQAze G7d5A37qiatcaGWXUFjrWpMmH0E06nA9Jjg5zyUnNjZ9tFhAytBRJWhZ4lUTU60WoTw9 rdD3f72p+JPrVqjmYRcbdRQdyVqp3zDJH8usTsZR9sCm2acWr7MjOLlrbIQyP1V0gc9k GO/A== X-Gm-Message-State: AOAM531FMPT2yQaAKchz1plmHCWwp+5N+RvWfecS4nJrRp/x78RiRRY7 mcaAIGNzhi/egG+u9LxZ325GVg== X-Google-Smtp-Source: ABdhPJyIVEMVjS5hMhLba5F7K9JoJZEJMSH0rgqKM8y1qiS+nYVk9WQFhlY8h5yAtTzIG7AtQI2JNg== X-Received: by 2002:a7b:c415:: with SMTP id k21mr8222932wmi.96.1610741355781; Fri, 15 Jan 2021 12:09:15 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , "David S. Miller" , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: [PATCH 1/7] net: ethernet: smsc: smc91x: Fix function name in kernel-doc header Date: Fri, 15 Jan 2021 20:08:59 +0000 Message-Id: <20210115200905.3470941-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio' Cc: Nicolas Pitre Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Erik Stahlman Cc: Peter Cammaert Cc: Daris A Nevil Cc: Russell King Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 742a1f7a838c9..891b49281bc64 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = { MODULE_DEVICE_TABLE(of, smc91x_match); /** - * of_try_set_control_gpio - configure a gpio if it exists + * try_toggle_control_gpio - configure a gpio if it exists * @dev: net device * @desc: where to store the GPIO descriptor, if it exists * @name: name of the GPIO in DT From patchwork Fri Jan 15 20:09:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024031 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B99C43381 for ; Fri, 15 Jan 2021 20:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E61523A57 for ; Fri, 15 Jan 2021 20:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbhAOUK1 (ORCPT ); Fri, 15 Jan 2021 15:10:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388061AbhAOUKB (ORCPT ); Fri, 15 Jan 2021 15:10:01 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0310C061799 for ; Fri, 15 Jan 2021 12:09:18 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id u14so4443970wmq.4 for ; Fri, 15 Jan 2021 12:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aiJUe/D+M6zdYoqU8/tCGnMlqOxFrCNb2GHwWBgB6XE=; b=dSqWxy5oJbUPhoGZ0kJkRd2cNEx5u2GKs2BvohoeKfNCcPJhr2Eu60z6vjzxq/40aN glgoqChgxqONYcrADHOUNx2SAbmIdyugzHGjcwAfK+IGJbWjyqOFoCOnNrJsRyuZ73GM ajB7yxsGQvusQMPlxvi6EQSO7extZO99Jze3AkqqxSQlrR9cBUH7LFx9BHVjWO4NVWZI EiRX3iCscVdNpnfjJCMuIQEvt/MdUGmvt9JbNZuSoBP+A2j09IlgIriYQv58JVaXSLpB eWTUAgMgNSZG8vtSDnHBneQoIxOiEZXrirrBiXBWfYRfCWc7r1+5ZlnwZDhU1hIS7a/5 b5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aiJUe/D+M6zdYoqU8/tCGnMlqOxFrCNb2GHwWBgB6XE=; b=sXYFR7FxUauU1nBgzoeoLnJ6IhdRHlZL0hXQyg6es+Edrqevutsp12dNxyKqU6rOm5 r++KLJSdbOxeS3Fh/pz6TQEQ/BUjT96ax69/RWt0I5qi08Wcuy8GBf+QpDg1dTJXrTJZ yZyza9vY+oQNDE1hDDTW3L7wvAXtskj2LYTbRE8TLCQn1HXMJvm8p2TVyo60aqZ8jXiq 9aInMVzFZ2pFUMxmIVWnDoUmBJ/w7loJuCh0tfukPNseEVcnbodgMamdaBiHrXhDn0hN SI+WZ87xs8FgLndszrlGMTYntiZ/mT+48CatV/J99QceLVR4V5fqO9kWtB6vyct0Cbfu mfWg== X-Gm-Message-State: AOAM532OBPoi4ztZVYKLmaoo/DwowmUGm0w/AO6fjUBa+Rzq8mn5sB2V +nr9YDnh0mEK4p9zTA6UM0iDzg== X-Google-Smtp-Source: ABdhPJz6z8ooRqEJMuEtAZ3z0VQGV3ToTw4T17vOw6fkh1inINUIw2LGxPtLCYYvw9uakPUqYWmMKw== X-Received: by 2002:a7b:cb54:: with SMTP id v20mr10484579wmj.148.1610741357695; Fri, 15 Jan 2021 12:09:17 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Wei Liu , Paul Durrant , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Rusty Russell , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Andrew Lunn Subject: [PATCH 2/7] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Date: Fri, 15 Jan 2021 20:09:00 +0000 Message-Id: <20210115200905.3470941-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'dev' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:419: warning: Function parameter or member 'frontend_state' not described in 'frontend_changed' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'dev' not described in 'netback_probe' drivers/net/xen-netback/xenbus.c:1001: warning: Function parameter or member 'id' not described in 'netback_probe' Cc: Wei Liu Cc: Paul Durrant Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: Rusty Russell Cc: xen-devel@lists.xenproject.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones Reviewed-by: Paul Durrant --- drivers/net/xen-netback/xenbus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 6f10e0998f1ce..a5439c130130f 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -411,7 +411,7 @@ static void read_xenbus_frontend_xdp(struct backend_info *be, vif->xdp_headroom = headroom; } -/** +/* * Callback received when the frontend's state changes. */ static void frontend_changed(struct xenbus_device *dev, @@ -996,7 +996,7 @@ static int netback_remove(struct xenbus_device *dev) return 0; } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and switch to InitWait. */ From patchwork Fri Jan 15 20:09:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024047 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972FFC433DB for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B47C23A5A for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388518AbhAOUKl (ORCPT ); Fri, 15 Jan 2021 15:10:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388376AbhAOUKh (ORCPT ); Fri, 15 Jan 2021 15:10:37 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BA92C06179B for ; Fri, 15 Jan 2021 12:09:20 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id v15so6823354wrx.4 for ; Fri, 15 Jan 2021 12:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G08JJuzSVjauD2w7RKeXQ1nSbD1Rkjm71UkTsB/zD7Y=; b=D2amWQb9S98u/P5DUNkplruHJE6hVhzLyueXRjLidi8RMYlvYJAhCpbqxHg8k2MQjo 1S5+7meCyWYbaXQZbhA1FJq7SfDR4nLyt3j+Jt6tJEev8HvJlVpqybhK+MTf4jK6+e2h HS9/myq1P0yBGJaqe2Pdye8TlfM5DlRC8+TwEZ7Z/eiUi1viUgUJV0tIxTxisRLNHbl8 mizOpFQFPPkvu5KawxfqOWdEdA8g3UnjMV4D+VIDsTy6ig7B1lsk04d/E48bCNSbazJh Jhh4KjgIY+FL2YJRew11Mc6SL7julFqzizygkgUi6ACy04C3SN41sqQ8XmA7gQqzqJ0g uRDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G08JJuzSVjauD2w7RKeXQ1nSbD1Rkjm71UkTsB/zD7Y=; b=C0e02Ynqt6bm9UZCym13KmtoYuNqLVjJAVI8157XsrUXtBLPFE3T9/hrN8muUieiFp bPdTtBOVsl+aIU50vZVYzbxYOAxM0NT6uJJ8xfMDr+74e+5lQCIwPvvwASWql5Jr8YVS rfhPR8cFOkz88drCusQV27CZ/llrXuRYzK6d4gJaplvNLUgr7wND1/49d4mpN2oaEhPI BFcTabJ9HdE+r32SqwmOuU2zZMKccdEL7Jq6tcYwDuFk+gGlQ+VlyhF7TxqIMH5hU+q+ 7j2U5GLJMfGgORs2x0G+Jm5bogsyuVrFn34J0Ueigvf7kIYX/jj8D3cWt3PmXnVBOPiO ou3w== X-Gm-Message-State: AOAM533W6tngQBgaO1OpvVWRxFHv2EH77bKC8Xv4hypVWfirkxaFpI5A 00cRyMhyanJhV4DvsJGKtMikECbOdLrLYmYV X-Google-Smtp-Source: ABdhPJxfwfguWvKcJ2QuCcwdTin9mx4tSWoLnGUHJZrmHg1o0XwnvHiDMbU3NCBvaVyzrd7wiS0Lsg== X-Received: by 2002:adf:e9d2:: with SMTP id l18mr14392232wrn.179.1610741359077; Fri, 15 Jan 2021 12:09:19 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Ivan Khoronzhuk , "Gustavo A. R. Silva" , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 3/7] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Date: Fri, 15 Jan 2021 20:09:01 +0000 Message-Id: <20210115200905.3470941-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Ivan Khoronzhuk Cc: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 3bdd4dbcd2ff1..ebcc6386cc34a 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c @@ -356,7 +356,7 @@ static void am65_cpsw_est_set_sched_list(struct net_device *ndev, writel(~all_fetch_allow & AM65_CPSW_FETCH_ALLOW_MSK, ram_addr); } -/** +/* * Enable ESTf periodic output, set cycle start time and interval. */ static int am65_cpsw_timer_set(struct net_device *ndev, From patchwork Fri Jan 15 20:09:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024051 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFC4C4332B for ; Fri, 15 Jan 2021 20:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3C8523A5A for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388755AbhAOUKz (ORCPT ); Fri, 15 Jan 2021 15:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388402AbhAOUKi (ORCPT ); Fri, 15 Jan 2021 15:10:38 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2392C06179C for ; Fri, 15 Jan 2021 12:09:21 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id v15so6823415wrx.4 for ; Fri, 15 Jan 2021 12:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z1CB49mzZZUw/61JRz0eEUr9QqVKx7SA3GZtjiem/4A=; b=XZVdyPclrbT2uhxikgAxnyIS/ZX1qGmCB8LbBl3vmin7FjsAsxRottUyPI83R0g3lU +4Q7EX9573V1O6kGhPJdJJKT6hRRq96wUP4l95wA8rl3xpo90ptufBd2CZWkbmugECIw bfjO1EOjYV6zg0/S5sBgJjUeFp9vLqAB8vc7Oy2Y6M8wZBTfGqdfw4VI/6NIO5I0y/c0 INaxZ8czTplEQT+SU1KBPk5SbbbO3giYgFjXLHrXLtukvEywqvOsUCxmO1tHSjKSLQj8 0uoJ8Pj7N0SlrVletx9yTWLzIHNMPfbq/KjdpRTwEySsiVz6JzCVlrVrflyFcM2Tp2In E6Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z1CB49mzZZUw/61JRz0eEUr9QqVKx7SA3GZtjiem/4A=; b=E8ZtTaLlfBU2u5eDPd93pEkONNYHdBJUCR3/AoGZTYH5P5SnLrQhNRpab2uVFWIgZX jceQxOGtXPADmm4qk8mmc1KdOL9rvXiwCVQGbjSIIaAUGAwfwEgF00Z+cBQTVlYW6c4j AkIDvFhRW5w2XK/FRL1wSnZoEGbOeOk77PIVmUlqY23179g3VAW8y0zzKO5xpLxIL4J1 GQdzHWOLSafzsM/2vFuCI95B6IPZUm42jY/PffJyu2HDjG1N4SOHtMEDEKRelL1l5GvD 7feLTsbptz7u6cvCmZQIc2mALQGUlPcdSmhdAL8LuA3Z3MaBKVt+TZ1M+8tTmQDlK/3W 1omQ== X-Gm-Message-State: AOAM531zPR86H8gpbZ9zdfm6s1ONQ5bS5CSB0wt+OAmRLvsGTJmDd5zV 6o02M9JFslEBpys9KGNMtkbTvw== X-Google-Smtp-Source: ABdhPJzPRnnSXQx1D6qljyZv+mLSE16/5yzn1TrX3tu+KrVYQEGeVQXzTU1sS031YhYKSUQ+M6B2hg== X-Received: by 2002:adf:c64f:: with SMTP id u15mr14322350wrg.270.1610741360557; Fri, 15 Jan 2021 12:09:20 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Grygorii Strashko , Kurt Kanzenbach , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 4/7] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Date: Fri, 15 Jan 2021 20:09:02 +0000 Message-Id: <20210115200905.3470941-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 5dc60ecabe561..9caaae79fc957 100644 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp) /** * am65_cpts_rx_enable - enable rx timestamping * @cpts: cpts handle - * @skb: packet + * @en: enable * * This functions enables rx packets timestamping. The CPTS can timestamp all * rx packets. From patchwork Fri Jan 15 20:09:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024055 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05427C4332D for ; Fri, 15 Jan 2021 20:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF68E23A9C for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388419AbhAOUKx (ORCPT ); Fri, 15 Jan 2021 15:10:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388405AbhAOUKi (ORCPT ); Fri, 15 Jan 2021 15:10:38 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86F81C06179E for ; Fri, 15 Jan 2021 12:09:23 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id g10so8646009wmh.2 for ; Fri, 15 Jan 2021 12:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yDzb65IKn3nwovbfX3R0K/7WXOxWh6GWTqzLuh+BAmI=; b=pZsRMv5bhHtvqYJamsuJ75nikyt6zcEJQlYa5vQNiBCiISvirtV/ccexo7zQxCL1hu FyMdw6tJFzSL+XN4ohF9JDJi5bNXyHBfqEqyKGKVtQFvIof1HSwxObDjQ06yYJD+Ny56 MKCOrA9dCzWddMH10Sre5X+JgsGLmIc++r0XDgmiQQ/UVjhhhmCg2myrmmjsK0CckMSX aKr2n65VSUKW1Facr/jNVjR4IeSnYHdw2rTWy//Bt6I1nB7nbCnmxCW/lkikEvkBxrgY MzhZpHTN2iXSiKX9uLQIRu6p2MsCvQzueB4ji7GPjK5Z4qOIpiZbDuW1S0rybK4pqPFZ o0aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yDzb65IKn3nwovbfX3R0K/7WXOxWh6GWTqzLuh+BAmI=; b=NOW6zKVO1xuY2DnX3LXGuPPhxX5fUgzbXkghMcTbsEF4Od0oJMTEAuYFCNYtR/qPtl H25bj/tl4B5/XQepqgKgNkbCcOLtYlEwyjh0sdlLiYqO0PtkN1pIuXnDLChbBz2lAAOz j8sCQlRVSt7HioWVL+BYaqNsMFprWe/2eVCY3l92kE0fpXwREzbDcDxlSoozzt9HmvS2 SmGOSyR2wGiRXni0o01aEh17KPAxFiKor3nn7AezsV9gDK1JENEMUxmTfgEGxxjAkCVQ FbFnPhgoQGiBFPfy/ANsXlBha9acsJf+HbAg1UmSNt/qBo8gAOO4BX3q/SL+1ELaXmAG mPzA== X-Gm-Message-State: AOAM5300Be0JH9PlztMWStLODHFsc5JDiiZ8eZ6RX3JOSTGgEo0m6es9 tUxevrT3IwxjWmptRY60jYo/8Q== X-Google-Smtp-Source: ABdhPJwKdwqNYtrjcalQ/mSZfe/zNNTb1WZf+Bx43LDkCZUpxVVkCGbnv0e+Kgl19uj2hk4l/rtILA== X-Received: by 2002:a05:600c:d1:: with SMTP id u17mr7533052wmm.20.1610741362266; Fri, 15 Jan 2021 12:09:22 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Jakub Kicinski , Santiago Leon , Thomas Falcon , John Allen , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 5/7] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Date: Fri, 15 Jan 2021 20:09:03 +0000 Message-Id: <20210115200905.3470941-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 27 +++++++++++++-------------- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index aed985e08e8ad..4c4252e68de5a 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1384,10 +1384,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1444,11 +1444,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @hdr_data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1496,10 +1496,9 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @txbuff: tx buffer + * @num_entries: number of descriptors to be sent + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable * L2/L3/L4 packet header descriptors to be sent by send_subcrq_indirect. @@ -1925,7 +1924,7 @@ static int ibmvnic_set_mac(struct net_device *netdev, void *p) return rc; } -/** +/* * do_reset returns zero if we are able to keep processing reset events, or * non-zero if we hit a fatal error and must halt. */ diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index b01848ef46493..811ddc8a94eea 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1582,7 +1582,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1659,7 +1659,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2305,7 +2305,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, From patchwork Fri Jan 15 20:09:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024049 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8B2C433E9 for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 958BE23A9C for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388622AbhAOUKt (ORCPT ); Fri, 15 Jan 2021 15:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728081AbhAOUKp (ORCPT ); Fri, 15 Jan 2021 15:10:45 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA619C0617A1 for ; Fri, 15 Jan 2021 12:09:24 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id e15so2246936wme.0 for ; Fri, 15 Jan 2021 12:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=r4oAoo9yjHlPOAHenr5g1EEQfCJWwxaNTfc1ja5O6o5T1ZICU4yaeYLTltJ1ZwhWt1 hYVV2trVas9eLp1262M7RtfrYIEz7l+5afdXAZLDAVgmpGypz488LOz8xh5YUONIahkt eE1JpBPouAfU6ZbgapMKocnQObleFyJlMh17sdT9uSaDfAJK1H4RLL3fR/jf1vPbZSl2 3ZXGy84XFr6wdgvBhg4tUDvEZEEb9HvFdLNJXx4pfxdQa+bod0l65TCpu6pNojaqfRmz GZBTnODZc6DO9w3kWfCa8POUDB0h8esIyL2gH/Yx7pqneNMukxKM+5ngce4TNsbAFuly uH2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=JK0G0IQiIGNe8AOKHrxZudn507nWqcWsBXhSQjo0GKLCVKFExNLYOi+bi2kvKMtEOu zt9m0+SDyJc49ZIn29h5M6KWSlXj4cGToqiYFEHgTJZjer3Q4cnjYMMgcBgGj0LSU85t HzYzaLInoIWBVaxzSs0zut/XjkF/jFP0bOeJI3CHf4TpmNNky6qbP+QKn4kaP+dBS8Af ND/NNRL1Y4AFfBdOEdGIxqn7TEl6Hy/5SmrdKzLAvjr+yTFQQ3AkjrY+sIScGG9dOg95 n1q/vYLCdoEuZ3RVX4vZT9JCicTb8BpKEL3ApOgvdaY/Jtm/Hlhi7xfQeDzs2Xx6bB1t GSUA== X-Gm-Message-State: AOAM533pywnaUi/1Nn+w6z2g7ur2VkV4cCwqzS995hdnS6i+Pm7KwCd+ 3LYVdjDYPiz5IFuUhJ30uCO1E6ph86FufXWf X-Google-Smtp-Source: ABdhPJxGn2F+giS73DFxVcuMgHRX52afEr2GWeLUY9WVozvsYAH2KsUVC7lFq4bGhVvc5fGD15RuMQ== X-Received: by 2002:a1c:1f86:: with SMTP id f128mr10246918wmf.174.1610741363617; Fri, 15 Jan 2021 12:09:23 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Geoff Levand , "David S. Miller" , Jakub Kicinski , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn Subject: [PATCH 6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Fri, 15 Jan 2021 20:09:04 +0000 Message-Id: <20210115200905.3470941-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index 3d1fc8d2ca667..55e652624bd76 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,7 +1789,7 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ From patchwork Fri Jan 15 20:09:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12024053 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C2AC43381 for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B636B23A5A for ; Fri, 15 Jan 2021 20:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388665AbhAOUKw (ORCPT ); Fri, 15 Jan 2021 15:10:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388220AbhAOUKj (ORCPT ); Fri, 15 Jan 2021 15:10:39 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E36AC0617A2 for ; Fri, 15 Jan 2021 12:09:26 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id o10so2520434wmc.1 for ; Fri, 15 Jan 2021 12:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ChGB+JX2oknD3GU9F+oPlQzChiJ0MNf1JzMjKC1b9JA=; b=hHi5eCMSCKRIHZs+AW6PVjhBGk5PWZBITFLeeaKh02RUYGNWd0XuWAmygYxQpSiMLo /IvW0bfnHYArnuKkoy6CXoAGaWY8H6k725azzyJjS2Fh4zVgdjHEMiJTXNrf6YQNkbPD C+7hiAeDdU5YHHsQa3cEfg9kJVWfwjlmESJyu2CVsSPC/bsrps5ZLiueS2vnWR+Tuy/R z1ZuMPcgf4zaHO2wZo2rclu7WKsBfImD3PGT91PkoVoA+U4EB/2blW1dbDyp7SYouhvk UO2HkHXxHfglxvTYwYktfI1KP5fnDKgbPN8gSCC4WG5I3hlgBZmbFxZeFFkhA44N7sr5 Cvow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ChGB+JX2oknD3GU9F+oPlQzChiJ0MNf1JzMjKC1b9JA=; b=IubMVr5dtKT2l2FHMFwhgZJG1oQuLeptrIcLN0Ek+BfF802j9AQndFPfwllCb1Owb/ 07GWVkK8yezunM5WAS2fM8NDgGl6hNisC3Qe1TU7EjeJDjV2yx3u44dU7ZfbyqEz/e45 05LbwxaTlxPW1NgEohhinmK8If0hskfyU/bEhkmMC8qdfevtk9/DlMHGwYRnqAIefxGM 3WILTfscaALqJ7J2/TRTLw6/Xd4cPnmNi39jjdp5FGwM4GjO7KWYnhzeCNAi5QKehNeJ Mz873GiLrfI3Z/d7fB6hrgMkwxc01zUCVCzt9CGO31ejU0RoSLcVhcvuErfdWMGaV26r e4YQ== X-Gm-Message-State: AOAM531igCwezNIyYK5WG5lNQdgUqZka2ItkuPokzCcQvddM7vnF52v9 Ai8gwCxMuWbTKChyMajDWQg0gg== X-Google-Smtp-Source: ABdhPJwpsJ6om7dpmSink2Kvd+WW/SYJt/aG/4x3TTcsakw95M5VDVS8RCTFjl29lRPpQrnhIqkNsQ== X-Received: by 2002:a1c:10c:: with SMTP id 12mr10286793wmb.186.1610741364928; Fri, 15 Jan 2021 12:09:24 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ishizaki Kou , "David S. Miller" , Jakub Kicinski , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 7/7] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Date: Fri, 15 Jan 2021 20:09:05 +0000 Message-Id: <20210115200905.3470941-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout' Cc: Ishizaki Kou Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/spider_net.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c index 5f5b33e6653b2..d5a75ef7e3ca9 100644 --- a/drivers/net/ethernet/toshiba/spider_net.c +++ b/drivers/net/ethernet/toshiba/spider_net.c @@ -254,7 +254,7 @@ spider_net_set_promisc(struct spider_net_card *card) /** * spider_net_get_descr_status -- returns the status of a descriptor - * @descr: descriptor to look at + * @hwdescr: descriptor to look at * * returns the status as in the dmac_cmd_status field of the descriptor */ @@ -542,6 +542,7 @@ spider_net_alloc_rx_skbs(struct spider_net_card *card) /** * spider_net_get_multicast_hash - generates hash for multicast filter table + * @netdev: interface device structure * @addr: multicast address * * returns the hash value. @@ -890,7 +891,7 @@ spider_net_xmit(struct sk_buff *skb, struct net_device *netdev) /** * spider_net_cleanup_tx_ring - cleans up the TX ring - * @card: card structure + * @t: timer context used to obtain the pointer to net card data structure * * spider_net_cleanup_tx_ring is called by either the tx_timer * or from the NAPI polling routine. @@ -1063,6 +1064,7 @@ static void show_rx_chain(struct spider_net_card *card) /** * spider_net_resync_head_ptr - Advance head ptr past empty descrs + * @card: card structure * * If the driver fails to keep up and empty the queue, then the * hardware wil run out of room to put incoming packets. This @@ -1220,7 +1222,7 @@ spider_net_decode_one_descr(struct spider_net_card *card) /** * spider_net_poll - NAPI poll function called by the stack to return packets - * @netdev: interface device structure + * @napi: napi device structure * @budget: number of packets we can pass to the stack at most * * returns 0 if no more packets available to the driver/stack. Returns 1, @@ -1268,7 +1270,7 @@ static int spider_net_poll(struct napi_struct *napi, int budget) /** * spider_net_set_mac - sets the MAC of an interface * @netdev: interface device structure - * @ptr: pointer to new MAC address + * @p: pointer to new MAC address * * Returns 0 on success, <0 on failure. Currently, we don't support this * and will always return EOPNOTSUPP. @@ -1340,6 +1342,8 @@ spider_net_link_reset(struct net_device *netdev) * spider_net_handle_error_irq - handles errors raised by an interrupt * @card: card structure * @status_reg: interrupt status register 0 (GHIINT0STS) + * @error_reg1: interrupt status register 1 (GHIINT1STS) + * @error_reg2: interrupt status register 2 (GHIINT2STS) * * spider_net_handle_error_irq treats or ignores all error conditions * found when an interrupt is presented @@ -1961,8 +1965,7 @@ spider_net_open(struct net_device *netdev) /** * spider_net_link_phy - * @data: used for pointer to card structure - * + * @t: timer context used to obtain the pointer to net card data structure */ static void spider_net_link_phy(struct timer_list *t) { @@ -2140,7 +2143,7 @@ spider_net_stop(struct net_device *netdev) /** * spider_net_tx_timeout_task - task scheduled by the watchdog timeout * function (to be called not under interrupt status) - * @data: data, is interface device structure + * @work: work context used to obtain the pointer to net card data structure * * called as task when tx hangs, resets interface (if interface is up) */ @@ -2174,6 +2177,7 @@ spider_net_tx_timeout_task(struct work_struct *work) /** * spider_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */