From patchwork Sun Jan 17 22:21:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12025863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D2FC433E0 for ; Sun, 17 Jan 2021 22:22:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8429E222B3 for ; Sun, 17 Jan 2021 22:22:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8429E222B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=xLL1U4nOnnGlyiRZ9NtU9i2JWRUESjiq+OnV1vnIwBA=; b=cR7qfDqk504xz6SryQ6rPSjxbN 6QVTtdX2PTCJYuUWV2yKir6/R5BslkH06Q+xxCXCznc4gfLtfy5U40hITf06NqL1mv91+ers/BR1Q ZGweZBJT+D7XrXU3GjqYDaMXeGiJcpwP5sglBHEBzpA/sSvkodxDVSnQp1o03Ed6AWpSJmuLciipK RSDi4eRPRpq0rLuQv+dy4yNEoIsOlNLfrCIfjSL4JimlJBf214t2EjJa7l8wZMqV6hwHAxPCunIkl uBRMsHPijSlW6b8Dd5uRwEsC+0EkJWu02pQZaAjs9f/ZsAeXcdv6oh3C5634Dxn35fV9pvHGtzrh/ ttIjSERg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1GQq-0007r2-9v; Sun, 17 Jan 2021 22:22:00 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1GQn-0007qK-2B for linux-mediatek@lists.infradead.org; Sun, 17 Jan 2021 22:21:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610922112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1Q/nirjyd353laCSIcUJdblTkIhaVs8AOQO2AamTKH0=; b=YT2htPgRh3IjSkrigGvxEeBTkLV+rJ8Mmx+1YJXQw7kNz78OUrwTK44vUzqH92aqunqF2m i+1BoDAwmwb0OpgcOwrqzW9jM8fWojC1XQGToM9YeCotec/JVn3hp3sWdmhNaAcP4rWXOI JovaZnIVj7ki5I6XzZKBrNUJVBiJbpI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-Nq1glw0-NLGZbvQnWQw1hA-1; Sun, 17 Jan 2021 17:21:50 -0500 X-MC-Unique: Nq1glw0-NLGZbvQnWQw1hA-1 Received: by mail-qv1-f72.google.com with SMTP id k16so14561410qve.19 for ; Sun, 17 Jan 2021 14:21:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1Q/nirjyd353laCSIcUJdblTkIhaVs8AOQO2AamTKH0=; b=VAwvdu2HVsyxiYAkq7x9t3Rwqxyl7gSFdmJNmE5x9lb6k4x+mOlnJsIHw9z7FwyMoB RiZ+GkB9BX4zL/APGP+WCejcDWvFju0mKFeS7DqIbnlWlYuoro9I0VfKOqfEs2pVUZhc HHvguB4jgJB1oaYky4WX2SKhMNDP/lllI+1D2xfKdU9JgSKLRHsywn/Cr6DUvUN7FLu8 ln5rm87S9NeACfbge6ccwRb7aSh9l44dQ8uqHmcCLQZ+xsF/fbpT2j4Dj1ya/V4kJvlJ sGV6iI2LwVAvPVkBHQo3zi1jDn76XCeqgOndm5rShf+2q/AFQlq5dC1jucmn06FkQEIb Jr4g== X-Gm-Message-State: AOAM533/aDtPLnsJMzVjoYnL5UfmEs+zD8boNiGraSkGy6gn8E+YkxPL ub7LmB3oGklHsv9008mFsASpUTaKKSd/ZBKxXmKigxIhzumsYgJ7h0iAmThV32PZ5Tref7KHYiw Y6zKyVOvFcHg5OXghN359zZo5iL4qnu0n X-Received: by 2002:a0c:9e50:: with SMTP id z16mr21356532qve.13.1610922110404; Sun, 17 Jan 2021 14:21:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLfAViRBC01RcVQ97+1PHfTVCqF3ZzkhqNaMPivdg097DavcqB1qB4Ni4JYwm+u1ckPY0Qnw== X-Received: by 2002:a0c:9e50:: with SMTP id z16mr21356516qve.13.1610922110196; Sun, 17 Jan 2021 14:21:50 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id d25sm9674480qkl.97.2021.01.17.14.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 14:21:49 -0800 (PST) From: trix@redhat.com To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, hverkuil-cisco@xs4all.nl, yunfei.dong@mediatek.com, acourbot@chromium.org Subject: [PATCH] media: mtk-vcodec: fix argument used when DEBUG is defined Date: Sun, 17 Jan 2021 14:21:38 -0800 Message-Id: <20210117222138.551147-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210117_172157_146186_937C01C8 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rix , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Tom Rix When DEBUG is defined this error occurs drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c:306:41: error: ‘i’ undeclared (first use in this function) mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_SYS]); Reviewing the old line mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[i]); All the i's need to be changed to VENC_SYS. Fix a similar error for VENC_LT_SYS. Fixes: 0dc4b3286125 ("media: mtk-vcodec: venc: support SCP firmware") Signed-off-by: Tom Rix --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c index dfb42e19bf81..be3842e6ca47 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c @@ -303,7 +303,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) ret = PTR_ERR((__force void *)dev->reg_base[VENC_SYS]); goto err_res; } - mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_SYS]); + mtk_v4l2_debug(2, "reg[%d] base=0x%p", VENC_SYS, dev->reg_base[VENC_SYS]); res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); if (res == NULL) { @@ -332,7 +332,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) ret = PTR_ERR((__force void *)dev->reg_base[VENC_LT_SYS]); goto err_res; } - mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_LT_SYS]); + mtk_v4l2_debug(2, "reg[%d] base=0x%p", VENC_LT_SYS, dev->reg_base[VENC_LT_SYS]); dev->enc_lt_irq = platform_get_irq(pdev, 1); irq_set_status_flags(dev->enc_lt_irq, IRQ_NOAUTOEN);