From patchwork Tue Jan 19 05:27:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12028835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A73F5C433DB for ; Tue, 19 Jan 2021 05:34:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32281206DC for ; Tue, 19 Jan 2021 05:34:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32281206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 772878D0031; Tue, 19 Jan 2021 00:34:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FB398D0030; Tue, 19 Jan 2021 00:34:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E91E8D0031; Tue, 19 Jan 2021 00:34:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4451C8D0030 for ; Tue, 19 Jan 2021 00:34:07 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0951E181AF5D0 for ; Tue, 19 Jan 2021 05:34:07 +0000 (UTC) X-FDA: 77721408534.05.doll26_01066162754f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id E525518030179 for ; Tue, 19 Jan 2021 05:34:06 +0000 (UTC) X-HE-Tag: doll26_01066162754f X-Filterd-Recvd-Size: 4539 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Jan 2021 05:34:06 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id c22so12278795pgg.13 for ; Mon, 18 Jan 2021 21:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aEEMV7863xltVpOu5dQdeBuAa/L7iHBBzSh9lFg+Kn0=; b=mwxZeLnxMtuvQXXMcMBQsTFESo6aiXFL43N5Ft8TdGjcyIu/StwJ3A3lW8hC+9BQfm qvqCffOW80GeEY4cGwo2tkrrFTWeUL3471eOzgweQvi1pLYkHqYIw1ICBBoJ77i3jVBZ Y9imH6F6215IdJ6eJgOvOjf0v4joL8ol/PWEPUpDHU1EMw5m3P1mXe+gKRjv8jg31GJo gW2wp/txsbZbS9BHBsT4bTflX5ir+ZFxBI72wyDTaGq8ZJsyjM55zz2pmiDzcvOaYth2 0mEjuA23VeUwUlK5j333DwpSRHDhln8Hqjo7pln6+GZxOsvZO+eMuBOG61a0N6FOygNj BqcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aEEMV7863xltVpOu5dQdeBuAa/L7iHBBzSh9lFg+Kn0=; b=YY1FWDmXs3gCyYYvAuB5zLXzyE/leMobrN3VNJEmIT9+GbxukXWUwqrvJ8A85677cD EAN4qlUZ8gXmq9yWT749TSKLowiqUWg4mYKy4wXHjHs09N6qTk9bEdhtjN7SJQ4eonMw 1XkHid8tB0R2V+gVXjv7z9uniegX0HxaJu3MxzUnB4KDkleyUYG3dFMiHg5wj+i42Ou4 6SK4L1r2kKKqrWreqDAuStAYbw5WOieNBY3pAepAxRbYTNrUlWaMGf3yG8Q47+9CjaFq TOnWKH8fj6yJeEBEHiBm4zymimwxQMI7VtIsbdYwPysVBNvIsI9XXcCENsm7H804tIi9 QNBw== X-Gm-Message-State: AOAM532Ws5VuJM5+YK/jcEFB4vUIFIgnu9YTZtDaMY4NTcrb1KzVLfiF 2vENm6sm2kZ/tBpyTRG//HIDeg== X-Google-Smtp-Source: ABdhPJz9yUYJS3K8GJIRHJtp+tSiIfEl1ITZVDGbqtywXleCleCvjD7QQffAm6mPSgO+5Jn9Cafdyg== X-Received: by 2002:a65:5882:: with SMTP id d2mr2917346pgu.323.1611034443734; Mon, 18 Jan 2021 21:34:03 -0800 (PST) Received: from localhost.localdomain ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id a18sm17425822pfg.107.2021.01.18.21.34.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2021 21:34:03 -0800 (PST) From: Muchun Song To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH] mm: memcontrol: skip propagate percpu vmstat values to current memcg Date: Tue, 19 Jan 2021 13:27:44 +0800 Message-Id: <20210119052744.96765-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The current memcg will be freed soon, so updating it's vmstat and vmevent values is pointless. Just skip updating it. Signed-off-by: Muchun Song --- mm/memcontrol.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index c0a90767e264..597fbe9acf93 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3700,7 +3700,7 @@ static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg) for (i = 0; i < MEMCG_NR_STAT; i++) stat[i] += per_cpu(memcg->vmstats_percpu->stat[i], cpu); - for (mi = memcg; mi; mi = parent_mem_cgroup(mi)) + for (mi = parent_mem_cgroup(memcg); mi; mi = parent_mem_cgroup(mi)) for (i = 0; i < MEMCG_NR_STAT; i++) atomic_long_add(stat[i], &mi->vmstats[i]); @@ -3716,7 +3716,8 @@ static void memcg_flush_percpu_vmstats(struct mem_cgroup *memcg) stat[i] += per_cpu( pn->lruvec_stat_cpu->count[i], cpu); - for (pi = pn; pi; pi = parent_nodeinfo(pi, node)) + for (pi = parent_nodeinfo(pn, node); pi; + pi = parent_nodeinfo(pi, node)) for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) atomic_long_add(stat[i], &pi->lruvec_stat[i]); } @@ -3736,7 +3737,7 @@ static void memcg_flush_percpu_vmevents(struct mem_cgroup *memcg) events[i] += per_cpu(memcg->vmstats_percpu->events[i], cpu); - for (mi = memcg; mi; mi = parent_mem_cgroup(mi)) + for (mi = parent_mem_cgroup(memcg); mi; mi = parent_mem_cgroup(mi)) for (i = 0; i < NR_VM_EVENT_ITEMS; i++) atomic_long_add(events[i], &mi->vmevents[i]); }