From patchwork Fri Jan 22 10:03:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 12038783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755C1C433DB for ; Fri, 22 Jan 2021 10:05:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87241235F7 for ; Fri, 22 Jan 2021 10:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87241235F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2tJU-0007ry-88 for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 05:05:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2tII-0007Ng-P6 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:03:54 -0500 Received: from mail.ispras.ru ([83.149.199.84]:44584) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2tIF-0004DJ-HE for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:03:54 -0500 Received: from [127.0.1.1] (unknown [62.118.151.149]) by mail.ispras.ru (Postfix) with ESMTPSA id 4D1A940D403D; Fri, 22 Jan 2021 10:03:45 +0000 (UTC) Subject: [PATCH] util/log: flush TB cache when log level changes From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Fri, 22 Jan 2021 13:03:44 +0300 Message-ID: <161130982491.1038646.15688151175539344664.stgit@pasha-ThinkPad-X280> User-Agent: StGit/0.23 MIME-Version: 1.0 Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, pbonzini@redhat.com, pavel.dovgalyuk@ispras.ru, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Sometimes we need to collect the translation logs starting from some point of the execution. Some TB listings may be missed in this case, when blocks were translated before. This patch clears TB cache to allow re-translation of such code blocks. Signed-off-by: Pavel Dovgalyuk --- accel/tcg/translate-all.c | 8 ++++++++ include/sysemu/tcg.h | 1 + stubs/meson.build | 1 + stubs/tcg.c | 12 ++++++++++++ util/log.c | 3 +++ 5 files changed, 25 insertions(+) create mode 100644 stubs/tcg.c diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index e9de6ff9dd..3acb227c57 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1461,6 +1461,14 @@ void tb_flush(CPUState *cpu) } } +void tb_flush_all(void) +{ + CPUState *cpu; + CPU_FOREACH(cpu) { + tb_flush(cpu); + } +} + /* * Formerly ifdef DEBUG_TB_CHECK. These debug functions are user-mode-only, * so in order to prevent bit rot we compile them unconditionally in user-mode, diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h index 00349fb18a..7415f11022 100644 --- a/include/sysemu/tcg.h +++ b/include/sysemu/tcg.h @@ -9,6 +9,7 @@ #define SYSEMU_TCG_H void tcg_exec_init(unsigned long tb_size, int splitwx); +void tb_flush_all(void); #ifdef CONFIG_TCG extern bool tcg_allowed; diff --git a/stubs/meson.build b/stubs/meson.build index 80b1d81a31..95e70f8542 100644 --- a/stubs/meson.build +++ b/stubs/meson.build @@ -38,6 +38,7 @@ stub_ss.add(files('set-fd-handler.c')) stub_ss.add(files('sysbus.c')) stub_ss.add(files('target-get-monitor-def.c')) stub_ss.add(files('target-monitor-defs.c')) +stub_ss.add(files('tcg.c')) stub_ss.add(files('tpm.c')) stub_ss.add(files('trace-control.c')) stub_ss.add(files('uuid.c')) diff --git a/stubs/tcg.c b/stubs/tcg.c new file mode 100644 index 0000000000..775a748c77 --- /dev/null +++ b/stubs/tcg.c @@ -0,0 +1,12 @@ +/* + * TCG stubs + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include "sysemu/tcg.h" + +void tb_flush_all(void) +{ +} diff --git a/util/log.c b/util/log.c index 2ee1500bee..2ff342a91b 100644 --- a/util/log.c +++ b/util/log.c @@ -26,6 +26,7 @@ #include "trace/control.h" #include "qemu/thread.h" #include "qemu/lockable.h" +#include "sysemu/tcg.h" static char *logfilename; static QemuMutex qemu_logfile_mutex; @@ -84,6 +85,8 @@ void qemu_set_log(int log_flags) #ifdef CONFIG_TRACE_LOG qemu_loglevel |= LOG_TRACE; #endif + tb_flush_all(); + /* * In all cases we only log if qemu_loglevel is set. * Also: