From patchwork Fri Jan 22 10:58:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12038957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18449C433DB for ; Fri, 22 Jan 2021 11:00:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E8A32376F for ; Fri, 22 Jan 2021 11:00:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E8A32376F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2uAh-0008DK-9m for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 06:00:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2u9S-000719-AA for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:58:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2u9Q-0003k1-Ox for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:58:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611313128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=ZoXejHOqPOwUGHxw8yQ2sqvgkqhCn/K5TanngtZn+qsfk2kGThupmvKwrTKmbKwkCaEdEq 1exLDm7XtgyUAKqVLZXO8MIJJvuEq7kco4rW9a7V0bgAD9H/s3V1bS4wOTUeq6fgSKdIdZ nMXQfBbumQ9t/nQi2Ne7Z07K9aAoGbM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-EYUEvWYINy-awD893ezwxw-1; Fri, 22 Jan 2021 05:58:45 -0500 X-MC-Unique: EYUEvWYINy-awD893ezwxw-1 Received: by mail-ej1-f71.google.com with SMTP id z2so2067120ejf.3 for ; Fri, 22 Jan 2021 02:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=kdpJ+6JaSsMSRdQhk18Pcd3TxBfJHD9dDhLEVNwdFBL+G+3+S++Bcxiof1dyE++GDL gPt+aA+4yJ3bZH8nGOf7LFfPRCvtinX0QMJrVpR+jnRkhZFBbE1DvbcTCg54XBeaCvWJ YdgKWnMW9r0pnUDZi0HG5CAn3h6vWcM1mbVBya0Njh3Hao4HsiunDRUb92uyPgA3kFWB XITlfSy45qXna10Q9pVA/uWF3rN93JGHnx1i/5TOFKbNlGX12uNGLu4/rR4cgEEjeXaW teNPZlZAhcw5jzPsJrsACEpJwF4nc8OdvYdE21n3O0apNZRPpmyyh372kKua8j1sdo7O omkw== X-Gm-Message-State: AOAM533K45NCde9miZgvB4aORaxA2QkbpcsHxAQWfaUKu8EJsIv0fIyl 3rFip+dUTpHEyaE0VwAI3xZMBt9fZELLGcsyU7m9YFWJJ6gE/Yw6PEvB2BsAgav+SZp2fncZ6wX 4GshemWYwuVm+1Y+Aw9mJSP8+hA8EXjYu7fjE99yLGQ4mwJ8Hc3DZrPmoYQFgclIn X-Received: by 2002:a05:6402:b30:: with SMTP id bo16mr2834013edb.84.1611313124441; Fri, 22 Jan 2021 02:58:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdpx7h3XRi/IG2+3LNK6hGzVzpD5uIZNCFjwkZrcM5gP86JtKoiMXID0w8o5b/GXdGB0AIUQ== X-Received: by 2002:a05:6402:b30:: with SMTP id bo16mr2833994edb.84.1611313124258; Fri, 22 Jan 2021 02:58:44 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id f9sm4996441edm.6.2021.01.22.02.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 02:58:43 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/4] meson: Explicit TCG backend used Date: Fri, 22 Jan 2021 11:58:33 +0100 Message-Id: <20210122105836.1878506-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122105836.1878506-1-philmd@redhat.com> References: <20210122105836.1878506-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 8535a83fb70..d5b76150e49 100644 --- a/meson.build +++ b/meson.build @@ -229,7 +229,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if 'CONFIG_TCG_INTERPRETER' in config_host - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif @@ -2419,8 +2419,12 @@ endif summary_info += {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if config_host.has_key('CONFIG_TCG_INTERPRETER') + summary_info += {'TCG backend': 'TCG interpreter (experimental)'} + else + summary_info += {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info += {'TCG debug enabled': config_host.has_key('CONFIG_DEBUG_TCG')} - summary_info += {'TCG interpreter': config_host.has_key('CONFIG_TCG_INTERPRETER')} endif summary_info += {'target list': ' '.join(target_dirs)} if have_system From patchwork Fri Jan 22 10:58:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12038987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A4CC433DB for ; Fri, 22 Jan 2021 11:03:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96C91239EF for ; Fri, 22 Jan 2021 11:03:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96C91239EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2uDd-00029Q-Fu for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 06:03:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2u9X-00077s-T6 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:58:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2u9V-0003lq-BB for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:58:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611313132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=e1PcJ9F4R7rK4OSfWUaBKVq5mWjh+Ee5GW2me1dWt2Ghl++jgH6YYAs7ufALZ9epEHkGob A77meKnkoRV/LhGWmzOAHL98A8IJ/+LDdapYJfTnW+ChaQp5TAsN+xyfV+FkIgpVAVFdG7 b4ItSz7P5WJb7hKU61tvxG5CiiNqxM4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-423-Y2gUQ3gHOXCQUHDfXxb8xQ-1; Fri, 22 Jan 2021 05:58:51 -0500 X-MC-Unique: Y2gUQ3gHOXCQUHDfXxb8xQ-1 Received: by mail-ed1-f69.google.com with SMTP id g6so2727245edw.13 for ; Fri, 22 Jan 2021 02:58:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=bCZugyLaiHJ6zo/dKFmm/5wZKLnGVeB2inn2H0mu+3q+sXDcTkPFyvKBB1D2diBwUi N34AxNVzEeDexFlPzuGToct29XTw7IfkP73Z6T1GhBQJR2Ta+ZECd/soFGnH/4t/waUT 2akH7pUyfZ4GYa78qX7WfBa6VqZmlLA1kcrBi41xbJ0+JIQU4+97d/GZaJ4ZHYQW9R2J QEKHID3shtvSF0nWeaJsgRjUuDGmpJRTPvhCqRP50OgUQXBh7oSamlw9ePs935Tf0vXx 6WzVauP1a1sh3WqJn1Gfb4M8h/vKHgHWVdNlYHv4dZvarzmtMjpQhHeqCUya1mWSh6hY aPLg== X-Gm-Message-State: AOAM532sVzSckrd45mOTgD8fJsKFselUdS726vEsEPBryYt0MXRKzKTz D05MIPy8xT8IzX8Az+WhVfL5G1SEyZbTJPghjJ1j1RALaRdDX58q2iSrIhJViUX+3fXCNlTDoEO gRvXLvfULKKDn/a3uuxo+e/dgcsIJSLiTTA0D0mxbzfSxKklZ0WYL3cLC032Y6drd X-Received: by 2002:a50:d552:: with SMTP id f18mr2718974edj.168.1611313129821; Fri, 22 Jan 2021 02:58:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTuytXpKW69oCvTDPUGbmVPEcVYdz8PXtcvHoQBAaEhiFtcb/WdSaZ+qnqt0t1UT5urDcjpQ== X-Received: by 2002:a50:d552:: with SMTP id f18mr2718961edj.168.1611313129626; Fri, 22 Jan 2021 02:58:49 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id q2sm4964236edn.91.2021.01.22.02.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 02:58:48 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/4] meson: Warn when TCI is selected but TCG backend is available Date: Fri, 22 Jan 2021 11:58:34 +0100 Message-Id: <20210122105836.1878506-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122105836.1878506-1-philmd@redhat.com> References: <20210122105836.1878506-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index d5b76150e49..d3df5fa3516 100644 --- a/meson.build +++ b/meson.build @@ -234,6 +234,9 @@ error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif endif + if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus + warning('Experimental TCI requested while native TCG is available on @0@, suboptimal performance expected'.format(cpu)) + endif accelerators += 'CONFIG_TCG' config_host += { 'CONFIG_TCG': 'y' } endif From patchwork Fri Jan 22 10:58:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12038959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE6FC433DB for ; Fri, 22 Jan 2021 11:00:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 931CC2376F for ; Fri, 22 Jan 2021 11:00:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 931CC2376F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2uB9-00007k-Ck for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 06:00:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2u9e-0007J7-1o for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:59:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2u9c-0003oI-7R for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:59:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611313138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H+Pq8Z9GG4F4ZYMbIAnDME9sYtYMxfqDFI3WzJbMa8g=; b=NktoAVG75NPssVUjBuWFN+CHhrLdpBVa1f8nX7z46PG5rMqC+LKWy/P7cMdBvYfRJ+7T+w Y+yjzvHf3R3w1iwWnqoU9k9u1NNFDdWt99yDUaj5T24bsNJ9Mf/Ie7ge9SW6UhCweeUkDP NYU30dFSBHmgCvJwVfF3E+zyjs/nD4o= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-S6HGfCtiNe63xIJM1Bd9hg-1; Fri, 22 Jan 2021 05:58:56 -0500 X-MC-Unique: S6HGfCtiNe63xIJM1Bd9hg-1 Received: by mail-ed1-f72.google.com with SMTP id w4so2731545edu.0 for ; Fri, 22 Jan 2021 02:58:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H+Pq8Z9GG4F4ZYMbIAnDME9sYtYMxfqDFI3WzJbMa8g=; b=lu2+amMe2ewWKod2/0Vs6MmOr6r0ZyQ7cxwSc4D+qLs5VAiIceZsXrz2YLNmW717NY w4LI/oXvmgYy2hEhh6EpQNj0VcEgnwhri3HTwwiKCTYqYIiHWbO25eED5wgxhEE51A1X 3JHWmmybY/kizkhrWhoiVUCyo/nVcQlPE3UwLikTHLThQ4mXjB0Qno235oxr3DF+TKJ+ j5Xa2JBEjNWpt4lMmzaCWKFTNkx87WkQ+4+aGkrGb+Pe9ZHhzdbORVsImeZpY9kLOapT RpDiiZr9jL1M3XET+jlHlmcIhQ2P0BcmLY1P5Tu9TfGcBdYzOuBq3yLtE6fVF/0rpYXc 7Oaw== X-Gm-Message-State: AOAM530402krL683bO8LYbtuTV3Hq07ppCqtY6n3ccDKOGwp3ss5o1RU wBns3b0XDKyEzttlIa84OU7vbVAAuyEl8EEaJowQQIyobFSOSblBN9i6fKooN9leY0u+8b+5gS5 fE9x9oiss9/ns7ow7hfbTaQrgiAGODehHuUbtMUI9ZByK1CtVmL/99F/iczxG6SgO X-Received: by 2002:a17:907:1701:: with SMTP id le1mr2680585ejc.68.1611313135338; Fri, 22 Jan 2021 02:58:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxePCKVC0sCfO/tfOGopndsXH5PiT03ujGBvbb9AiW9wAcN4hsQ6U+c1yN7JD4Yd58cezhZUQ== X-Received: by 2002:a17:907:1701:: with SMTP id le1mr2680570ejc.68.1611313135134; Fri, 22 Jan 2021 02:58:55 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id d8sm5169602edm.75.2021.01.22.02.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 02:58:54 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/4] configure: Improve TCI feature description Date: Fri, 22 Jan 2021 11:58:35 +0100 Message-Id: <20210122105836.1878506-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122105836.1878506-1-philmd@redhat.com> References: <20210122105836.1878506-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 9f016b06b54..71bdc523aa0 100755 --- a/configure +++ b/configure @@ -1753,7 +1753,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCG with bytecode interpreter (experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu] From patchwork Fri Jan 22 10:58:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12038989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20A5C433DB for ; Fri, 22 Jan 2021 11:03:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35931235DD for ; Fri, 22 Jan 2021 11:03:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35931235DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2uDn-0002Ok-1K for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 06:03:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2u9o-0007Sq-W1 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:59:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2u9g-0003rO-9p for qemu-devel@nongnu.org; Fri, 22 Jan 2021 05:59:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611313143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g4EDW26wqJzvbldi/AmeB50uRCleZG3tNbcnAK553ZI=; b=QLaVFyKfaShGL/DEEmzkK+VXJEvm6RtpkigEU/66ceKphsWpFS4IhxzY3n5LgRHHOQfswS uKfSkIgu6hyGF4vk0G+w2Axvacvg/SXN07mIrW/RJMVWiQlOtd25yHV9iUyKfBEzRFD8MK 0AX9+DWDI72FI67RX2hCOPE5cl273Y8= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-F6fSyW76NP2ZyG_ZeSDOVg-1; Fri, 22 Jan 2021 05:59:01 -0500 X-MC-Unique: F6fSyW76NP2ZyG_ZeSDOVg-1 Received: by mail-ed1-f71.google.com with SMTP id t9so2738720edd.3 for ; Fri, 22 Jan 2021 02:59:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g4EDW26wqJzvbldi/AmeB50uRCleZG3tNbcnAK553ZI=; b=Hay/DpXltBcteSvOcJ4IfBYITJNyYdsj7pNL3fX3XXl7W0Cc/RLU4EM4SidVkXXXdE vKUfwP3VBDu0lbhO44HTc2qSykh7Z52nZMOz3KLBPqZEyXxAVHQhmfED2l5J1heJ52Ul xPChZ3o+Js3HF/cpupDMEMer5KDwJyWMYMILS3MkNeTcwpa9QDEbVl4BS5INmKu6is7X NTASJn3wPESacPXLSPBDhJxF1meAURu1pULUG88ifc2Fi4ptb/BYt7z+sanlxMyoUaGE OMam/R3wN+bi5ESqXzLwheITAY4i3USs7HA9FdRUjfwoxGtc9cXhr1RLE+Ct/PXH1Uuw 5Mlg== X-Gm-Message-State: AOAM533doLINcWpPqIk4JZePNgXLN4p4EWnmrddDLS9WthKlMhM/ibNn TZhu8EmnpQDO+tYl2F4M6flpwgLnCmGJcVXXAcSM5WJzTxtqvBrT7G1pBZlnbyfblU54LYuiJFz jtlSrvBd1TUs8io3IxQxglzjvzPyrj//oiRJOVOe+2KWkv02VOrglCZoYMlbw/FhA X-Received: by 2002:aa7:c94a:: with SMTP id h10mr87325edt.247.1611313140336; Fri, 22 Jan 2021 02:59:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwL+8ju/0d0X7lZcqJhWEo9y75bFTmkAXG2IM9QJl1rh6fBJbCLgLTnzUtjOXo7rjbybTpWiA== X-Received: by 2002:aa7:c94a:: with SMTP id h10mr87311edt.247.1611313140199; Fri, 22 Jan 2021 02:59:00 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id z25sm4134918ejd.23.2021.01.22.02.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 02:58:59 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg Date: Fri, 22 Jan 2021 11:58:36 +0100 Message-Id: <20210122105836.1878506-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122105836.1878506-1-philmd@redhat.com> References: <20210122105836.1878506-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- RFC so it can be discarded from the series configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 71bdc523aa0..5e56fa76499 100755 --- a/configure +++ b/configure @@ -1121,7 +1121,8 @@ for opt do ;; --disable-tcg-interpreter) tcg_interpreter="no" ;; - --enable-tcg-interpreter) tcg_interpreter="yes" + --enable-tcg-interpreter) # backward compatibility + --disable-native-tcg) tcg_interpreter="yes" ;; --disable-cap-ng) cap_ng="disabled" ;; @@ -1753,7 +1754,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (experimental and slow) + --disable-native-tcg enable TCG with bytecode interpreter (experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu]