From patchwork Fri Jan 22 13:30:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12039457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7232C433E0 for ; Fri, 22 Jan 2021 13:34:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70F3022D50 for ; Fri, 22 Jan 2021 13:34:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70F3022D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2waB-00058w-Ee for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 08:34:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2wW4-00021c-HR for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2wW2-0004hn-NV for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=a3P/4NuVJJ32+KB6ML+TjCBawsSskcqRdJDm1fDPh9hpsoeuUU4N766VK4aorBmzXCGXEt IJh/Xy+bxXkdjTLCg74QbrduNweyjjuYdyW/0kw+RawTGyOBm0H/oXM5dT105GHv9Dz4BN wkPCaS02Jzw1gObfvTJbr+UJtR9QOE8= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-oC43GnOqNACugv6P_xH32Q-1; Fri, 22 Jan 2021 08:30:15 -0500 X-MC-Unique: oC43GnOqNACugv6P_xH32Q-1 Received: by mail-ed1-f72.google.com with SMTP id m16so2888399edd.21 for ; Fri, 22 Jan 2021 05:30:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=FC9Pol0z17jai5ylBlXr8RC2ClKWrrlkxeYYMcw1lzQsE5/caKkicuJ7Vuyg3LMYRJ nd4BCXTNqZ84UoBf1U6qgoZYdhbWtEesmO4Ezj7d6rzSbrSTKc6LeR5oVoPwgDefpQlA rUZN8SnIQeKIaIHWs3NpWfYAxUp14NLrN654NXlnjqd2p6Egd0naIzMl19M3zwzr7eJK ZTDGBCXxzs9f0i0zRl1TjCoOV9VFDdMX4ytg59ORmg4lBE25Cisk3ToY/aCwt6ccQn/d QnAyLkBaTI8XwsiCv94MojfPFjehqexCsvpuz6/jeZ7GMKUm52RNB9R2sR2lwNbA/fVv pLuw== X-Gm-Message-State: AOAM532jrHnaKwB7qVco/6efYQO0p9MXaWB6nVF2T0KXkqSNeoVts9Gc +sN7vj1fQ/YlIUvvG1/QviD1BjJiUB/D/Lv0jYmfgvtkI+7EqVGjcTx4OgxVIj4PP0xh4UZWsve lwX9mu545hudmTts0KKqjkc4D8ZWbExk+i9wQNLX6x9BrcqZ4IWQw9zcDOmdshlgA X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr2789988ejc.434.1611322212546; Fri, 22 Jan 2021 05:30:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuSfHMZ53V3OprBiAdcKi9GojHq4lJGM5X12yW0zeKyVir9ZxjyTcCxEGmOLk8eu7+nJ1Iag== X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr2789967ejc.434.1611322212323; Fri, 22 Jan 2021 05:30:12 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id k16sm4423726ejd.78.2021.01.22.05.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:11 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 1/4] meson: Explicit TCG backend used Date: Fri, 22 Jan 2021 14:30:01 +0100 Message-Id: <20210122133004.1913923-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 8535a83fb70..d5b76150e49 100644 --- a/meson.build +++ b/meson.build @@ -229,7 +229,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if 'CONFIG_TCG_INTERPRETER' in config_host - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif @@ -2419,8 +2419,12 @@ endif summary_info += {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if config_host.has_key('CONFIG_TCG_INTERPRETER') + summary_info += {'TCG backend': 'TCG interpreter (experimental)'} + else + summary_info += {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info += {'TCG debug enabled': config_host.has_key('CONFIG_DEBUG_TCG')} - summary_info += {'TCG interpreter': config_host.has_key('CONFIG_TCG_INTERPRETER')} endif summary_info += {'target list': ' '.join(target_dirs)} if have_system From patchwork Fri Jan 22 13:30:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12039455 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FE4C433DB for ; Fri, 22 Jan 2021 13:32:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B02722D50 for ; Fri, 22 Jan 2021 13:32:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B02722D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2wY9-0003Eu-7X for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 08:32:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2wW7-00024e-VU for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2wW6-0004kw-95 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=SADi+7+gLFlyakGFs8lJCB2OZVAOxH2EEj9O7NhU8rcXepEv9kX0xJTVQdwzjOCl4MZt9U dooT+CxLWlpaeH/hjZbD5Ovy/Q7EWehdEU4RaQxKu2qwEYE7eHgNEVuhecbyty4Ba6BaTr zWVbLRdlWAMIiCybWW7KSpCxenuCQoQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-pmKX_i96ONWIgngTd1YqlA-1; Fri, 22 Jan 2021 08:30:19 -0500 X-MC-Unique: pmKX_i96ONWIgngTd1YqlA-1 Received: by mail-ed1-f72.google.com with SMTP id 32so2904526edy.22 for ; Fri, 22 Jan 2021 05:30:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=luSma7Et7Go6rROEpeF1tYjiIagZ0l4ZBCp4kE4SjQsESSRMVnuYt5IQFGH41APu1n cJQEBD/cgtcyfCRgwf7esgXCntzBE6EjKSP183pUu3CJB24Uy5e80dExu7bq5fd0HGlS K5VKijXdReCiGNh9rxrhjq489HRNvhng3OXOFCEXiOLfmEs8z0lq7He+yYDMNKfNNipj 3BU6A0VweVXaMYmeybDA8g1qx0cNWr9FLr2H12fnNDpBcFerPuaCkBRyaU7WJaqSkRy1 7AKSm7zE2IAWSpsgVexKjB1o5CiAZTB9WRFi/I5ur8wvygaMizfA9hcEgwHSdjyncYaW G4lg== X-Gm-Message-State: AOAM532snMjgZL1sCYvWjYMl2xqjQ7nr0l+l7dukx2s2ZLcJAEcSSeaR 9hJIkwN36iiDqi1S2qnaUbcJDyj53R6ZkalZHWJjFldl2zpcMbBUt7Dj70ghhHKycLFo5YT/dOi rSr9nkb9sW3+x2imeZpXQkurjSjS6u61/8x8PIOcpj0I6TI5rwpbwuSHYsz7sXotJ X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr3079018edy.46.1611322217766; Fri, 22 Jan 2021 05:30:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3CX/xAcgYy/rJFitVeqKwpJ97IyOMYpVA0gCrcNv3Xe2SMlDxyel2dUpKbY+7IUrq7Z7RHg== X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr3078999edy.46.1611322217531; Fri, 22 Jan 2021 05:30:17 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id g10sm4379867ejp.37.2021.01.22.05.30.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:16 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/4] meson: Warn when TCI is selected but TCG backend is available Date: Fri, 22 Jan 2021 14:30:02 +0100 Message-Id: <20210122133004.1913923-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index d5b76150e49..d3df5fa3516 100644 --- a/meson.build +++ b/meson.build @@ -234,6 +234,9 @@ error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif endif + if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus + warning('Experimental TCI requested while native TCG is available on @0@, suboptimal performance expected'.format(cpu)) + endif accelerators += 'CONFIG_TCG' config_host += { 'CONFIG_TCG': 'y' } endif From patchwork Fri Jan 22 13:30:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12039459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDAE9C433DB for ; Fri, 22 Jan 2021 13:34:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70A4D23437 for ; Fri, 22 Jan 2021 13:34:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A4D23437 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2waF-0005FY-Fy for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 08:34:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2wWG-00027N-VV for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2wWC-0004pd-W9 for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SC9toH6zd85Yt0/fqqNGyw/NDQltVKupxFW46xt/En4=; b=REIMCQ/h5V+Cht0r8HrBV20C8jlAj+djP+ivLi+t+T4SrFYjHg39V9UiZym9RyBuvo8+tQ Ndkomroje6HCYvoxM+jxwdWptw1LCtM5tsAvb8aGCeI0AemvhHvnDEwC67dvlT7v8W0ulO k86FlaPgNHQQoMbrTOnzmlsEmBNuzYM= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-4RHTkXnOOny2TmQOtpwmWQ-1; Fri, 22 Jan 2021 08:30:24 -0500 X-MC-Unique: 4RHTkXnOOny2TmQOtpwmWQ-1 Received: by mail-ej1-f70.google.com with SMTP id n18so2180887ejc.11 for ; Fri, 22 Jan 2021 05:30:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SC9toH6zd85Yt0/fqqNGyw/NDQltVKupxFW46xt/En4=; b=VV55LMkHwY9ny7tBTh5pohRMhBw0qNNQBUqiHmUnzR7LoqgrazNsWO7TQQ9p1EE3Ba It9kbiFyoUPSclPM56rkToySie8YLupSPDZ0JEXXiVK5a4/wKEarJ2vCmWNO0ziaEC1A 0o/maFYi/8oQclDC/+u0VREBl/6rArcoaDuOvFGp43xEz2nI1dUGOUN5+G3nEpAHkRKy yn1kWfEJQPTn31XwNCqYsyEgf31inIcOMAfsYNm7RhhRcp6fk+cEzebgRoXxgl82Tzx3 T6mkiLHzmp+TEYdKPjUGZ9I1AoqzkJgwCuWn2DjzhECvcbX0CaDBPeoE52NvKTeNm7q0 9LOA== X-Gm-Message-State: AOAM533XdhehRZrjbyeo+6xSXe/pqU9KcxbCeTMSvqLOMyzxl2C6fRv4 pBNroejmdMLJb/r3TtzjYv0IN/cXcKu+qzWwBEmtsbCwdtcEU9IHAnHYeLBjshT/4eO46wvQIyq 4kjqfAJBTdcjLYeUP1gUi7YWHrRvWOeDzQyBsCjmX1FE/00aPMcYPBvlmMM6n3hND X-Received: by 2002:a05:6402:18f:: with SMTP id r15mr3155259edv.189.1611322222964; Fri, 22 Jan 2021 05:30:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzztiGKu/Yz4F20eM1ZObBDm/xvfQL+kgj20IqgEvBwILnfpDkZYzkxoXHJrrUP9ZXrXE8a9A== X-Received: by 2002:a05:6402:18f:: with SMTP id r15mr3155240edv.189.1611322222802; Fri, 22 Jan 2021 05:30:22 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id cx6sm5656035edb.53.2021.01.22.05.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:22 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/4] configure: Improve TCI feature description Date: Fri, 22 Jan 2021 14:30:03 +0100 Message-Id: <20210122133004.1913923-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 9f016b06b54..48bd6f48d7a 100755 --- a/configure +++ b/configure @@ -1753,7 +1753,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu] From patchwork Fri Jan 22 13:30:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12039463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CB2C433DB for ; Fri, 22 Jan 2021 13:36:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD74522D57 for ; Fri, 22 Jan 2021 13:36:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD74522D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2wcH-0007O2-Ra for qemu-devel@archiver.kernel.org; Fri, 22 Jan 2021 08:36:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2wWI-00027p-BN for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2wWG-0004t2-8C for qemu-devel@nongnu.org; Fri, 22 Jan 2021 08:30:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqLUxS6+wXdFYNdF20lIIzQLVCdqXVLR3cT1O1xo2Ts=; b=QlnUHF3Gr9P2cPRnamxHQauBRiSOBAPo10+f3QDT3tJJzn23X7ntUgwtAB/gaapreQfYYk faSLRcmUJ8ZViskBb2mOz+Ln5qbFSDyAdLFpNs3jjf5OChIpyj1lhwkDy/P5iLnrcwOtJC ixOkV4KLCZ1ywR9yhpMr+XgPZjgxuNk= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-139-I5vE7xwPNLyXMiGmu2XCWg-1; Fri, 22 Jan 2021 08:30:29 -0500 X-MC-Unique: I5vE7xwPNLyXMiGmu2XCWg-1 Received: by mail-ej1-f71.google.com with SMTP id h18so2177422ejx.17 for ; Fri, 22 Jan 2021 05:30:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rqLUxS6+wXdFYNdF20lIIzQLVCdqXVLR3cT1O1xo2Ts=; b=gTh5iaQosCPi/eTm9JwX7INedLFxZx+pVqhklpm//z1uH8UgQGgRPjO+xdgAE1K7d6 yOa9WVMAJDas9Ga7ICzLM08nvxSnGXcDQdS3gf6IDiMwMwE7pGBJvY5x0FZsOf8nTEpM bd/P5trnbwmUYD1dqAwfivDUBvoSJ6FCIOrNSblh0OaqAi1lCXRoyQgs/Nb1PO7FpidJ JVF48uYyoZcXS2seD60QcuAdU6iSCLPbgA6VrFrVxXbUPGfGOJN6I2gMvTzaG68sbIvP QNk5e8emy6rAGsE53jSPobsTAqgjspjBIDvZbUHLTFN8+zIwdMScSzJ2DqeRpP+JOQsS Et2A== X-Gm-Message-State: AOAM531FH631PeFF+Pi5zcjFWjk2pbhgSXTiVQ5ZcJIvk63tlWdfgYUN s1I617tdyAOAa2JyYoUIJI7aTBpTHUgJAbe3e4ccPzV9177dRxn66TBgOzHdVRyggKfSqOIwAXr JVieBiBDd8zEPIR6l8zrxKIXY9WcFRkubcV4JjqefjWxBty96qUgdQbAR9sMiDzy5 X-Received: by 2002:a17:906:3401:: with SMTP id c1mr3067689ejb.156.1611322228075; Fri, 22 Jan 2021 05:30:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDKkqjq0cxNEgFzumErQwUHNNbfoMfN/tF8SdsThiumUxWd15W8HQSTlEswAsIubpLRCMsCg== X-Received: by 2002:a17:906:3401:: with SMTP id c1mr3067667ejb.156.1611322227806; Fri, 22 Jan 2021 05:30:27 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id b26sm5431195eds.48.2021.01.22.05.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:27 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg Date: Fri, 22 Jan 2021 14:30:04 +0100 Message-Id: <20210122133004.1913923-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.182, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Suggested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 48bd6f48d7a..5e5ff779a69 100755 --- a/configure +++ b/configure @@ -1121,7 +1121,8 @@ for opt do ;; --disable-tcg-interpreter) tcg_interpreter="no" ;; - --enable-tcg-interpreter) tcg_interpreter="yes" + --enable-tcg-interpreter) # backward compatibility + --disable-native-tcg) tcg_interpreter="yes" ;; --disable-cap-ng) cap_ng="disabled" ;; @@ -1753,7 +1754,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, experimental and slow) + --disable-native-tcg enable TCI (TCG with bytecode interpreter, experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu]