From patchwork Mon Jan 25 14:45:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12043581 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31459C433DB for ; Mon, 25 Jan 2021 14:48:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 866B4206A1 for ; Mon, 25 Jan 2021 14:48:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866B4206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l43AT-0004oq-HP for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 09:48:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l437k-0003sa-MZ for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l437h-0002oc-MV for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyAIWgb9gsg8MioYvbK2q4hAEL+3fqa+Th3P+PoqI/E=; b=iqfbw9EUFaZGIm60kPR8GJUyXSx6ssfkkWRsvouqstHXJ5sE2QcdAWAF1ug7c0DRhP2klf 478NNriMUWjQH55KjobVriiNc3RrHB19NYSfOA87VHu6+zTqUxIYBvw72lypGW3iab0rnN +45SWOhKdVyMf1J+ipokWn5GItc3/zs= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-TM6jSDBROwatTZJjI17HSg-1; Mon, 25 Jan 2021 09:45:41 -0500 X-MC-Unique: TM6jSDBROwatTZJjI17HSg-1 Received: by mail-ed1-f72.google.com with SMTP id r4so7505168eds.4 for ; Mon, 25 Jan 2021 06:45:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eyAIWgb9gsg8MioYvbK2q4hAEL+3fqa+Th3P+PoqI/E=; b=Sb07GOPNuHuR95begn2MpN7DQEGi1eqcWuGvxf3chet0W+jkSKjzW637OUsrs2Qg4l AoCcBkpIkKwGY3UJVNfYX71z9YA/+KfzWRp0t0hP0r2iAkqN2XVq5zf6NbbS9OmZN/Ut A+XcrKKhhveh7SctdxAXPlyt7YBk9zvcSvUF6uN4EICT4w5BvxFMNiht1pYNocyUglEv MRLcT9HnzKK8hZKb2URV/oIP0Ns/BzooAJFUWzIScSLvVtHbs6IQZtfXtVkFKJz3TCux 0eq7xD9FoiU2n5qEZFI9iSVUmOCqWgFdtzepSneUyP/vhzaY9+rBoCAnyHzSkOWam00s KYXg== X-Gm-Message-State: AOAM531/iMoE9nWGILDr4PqNVLsfiDTOsL9HEVmwVpUQV1c2JK1DfpgP K5WFQisqR2rSGf6Da5Jhz3sgiaU4EpoIUczK0FfCV5Wu0DhsTSoLPSZHeOl6spDBMomV/UyV2EE jNAWrA+4DhM8ut/4yCuZG0KuJb4sksKuPClfiAuwZmHkYgnt4HqxVvDRJcSTZ69Lu X-Received: by 2002:a17:906:358f:: with SMTP id o15mr588639ejb.369.1611585940517; Mon, 25 Jan 2021 06:45:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVYQLQb66A79o/zw5D3p/Mlmg2n1oRdyBvcTXOdEjHjZYe4Rgdk6og4SOlqq37HtF15JItCg== X-Received: by 2002:a17:906:358f:: with SMTP id o15mr588624ejb.369.1611585940358; Mon, 25 Jan 2021 06:45:40 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id gb14sm8184040ejc.61.2021.01.25.06.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:39 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter Date: Mon, 25 Jan 2021 15:45:27 +0100 Message-Id: <20210125144530.2837481-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson The configure option was backward, and we failed to pass the value on to meson. Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury") Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210124211119.35563-1-richard.henderson@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Tested-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dcc5ea7d630..526c4cc1306 100755 --- a/configure +++ b/configure @@ -1119,9 +1119,9 @@ for opt do ;; --enable-whpx) whpx="enabled" ;; - --disable-tcg-interpreter) tcg_interpreter="true" + --disable-tcg-interpreter) tcg_interpreter="false" ;; - --enable-tcg-interpreter) tcg_interpreter="false" + --enable-tcg-interpreter) tcg_interpreter="true" ;; --disable-cap-ng) cap_ng="disabled" ;; @@ -6361,6 +6361,7 @@ NINJA=$ninja $meson setup \ -Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \ -Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \ -Dxen=$xen -Dxen_pci_passthrough=$xen_pci_passthrough -Dtcg=$tcg \ + -Dtcg_interpreter=$tcg_interpreter \ -Dcocoa=$cocoa -Dgtk=$gtk -Dmpath=$mpath -Dsdl=$sdl -Dsdl_image=$sdl_image \ -Dvnc=$vnc -Dvnc_sasl=$vnc_sasl -Dvnc_jpeg=$vnc_jpeg -Dvnc_png=$vnc_png \ -Dgettext=$gettext -Dxkbcommon=$xkbcommon -Du2f=$u2f -Dvirtiofsd=$virtiofsd \ From patchwork Mon Jan 25 14:45:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12043583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C139CC433DB for ; Mon, 25 Jan 2021 14:50:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A33A20848 for ; Mon, 25 Jan 2021 14:50:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A33A20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l43C5-0006fg-FU for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 09:50:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l437q-0003uX-7g for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l437n-0002rH-9z for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/vTBGdpObdt7akXTKRcYVJLfbSFpvNvWMtOTP20LsSw=; b=K9ZFprSQHmpn0MNmn4jY7288Y4GfXFwTP+LYOAODru8TdXgi5pOrNueuhVfPt/j5r/7OYG UsTJ9tjRJwpzTXk1vIfVQzK7aDVCYO7pJ9FQ0yQ71HzKb90y2VPYlNghJNl+aLW1r0hxpq wMStKSVyMpM1Ur6lFgQjFAxehiUn5Dw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-M7Y9MNTcMDezn5e3QaR56w-1; Mon, 25 Jan 2021 09:45:48 -0500 X-MC-Unique: M7Y9MNTcMDezn5e3QaR56w-1 Received: by mail-ej1-f70.google.com with SMTP id m4so3841100ejc.14 for ; Mon, 25 Jan 2021 06:45:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vTBGdpObdt7akXTKRcYVJLfbSFpvNvWMtOTP20LsSw=; b=lAUzrJWrcGBITeHZWqlvUMjvcrbWeuRZWReBRwps6avagH0BVis2Vc2z3Qk8Hh64Er fI+r01QRya6m3AjVyTomaz8xYwghazcc43W8PzveVtonM3aa0Z74Rt8NOOtNLpqU/nD/ IIioFx7A1TYptdeV9mwL5ZjaCYOPWXCiveSMj3DQk7l2dqitO7Lac2i4p7BCmZgyUYrY 3Rms1+grw7SudR7kuPzoZd0ZJ9QhgQPC6/ph5x3dCEH/SA0SfEu1y8lgWQsaAq3WdPAA kMzYHC4ncNceHit/ai21x2pXg6wb+fOzHoQchcwM6B+HEdoz4lWFvtycHIOtM3ZDF8Jd FOhg== X-Gm-Message-State: AOAM531WXhWidOwG/dXyEGZbFSJmkDThsgryRDKMJajY8dXbJMtaXNzI s7RFck/EM6Kkrkhey8sWhGGJBTHmlzE7eRNq9ZNWdrqJ7fAuTGttxacUXf0aVFk9vuMaShcwWCm d8IV/JqclFcqImfmEECyV+wmr5M9i9TpF0p4Eprx2v7+eHGnh2HTgPuWVXn1YGduH X-Received: by 2002:a17:906:3a98:: with SMTP id y24mr557816ejd.436.1611585947420; Mon, 25 Jan 2021 06:45:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbqhCxaQl381d2LAvhvh+O0qV3j7JW5isaDMyu7oEjzWubENYGfe3V3+dRa6yNNc0pLIKnxQ== X-Received: by 2002:a17:906:3a98:: with SMTP id y24mr557803ejd.436.1611585947278; Mon, 25 Jan 2021 06:45:47 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id e22sm8473467ejd.79.2021.01.25.06.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:45 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 2/4] configure: Improve TCI feature description Date: Mon, 25 Jan 2021 15:45:28 +0100 Message-Id: <20210125144530.2837481-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 526c4cc1306..00952ac8186 100755 --- a/configure +++ b/configure @@ -1748,7 +1748,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu] From patchwork Mon Jan 25 14:45:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12043585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A97C433E6 for ; Mon, 25 Jan 2021 14:50:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC8F020848 for ; Mon, 25 Jan 2021 14:50:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8F020848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l43C6-0006iP-Rc for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 09:50:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l437t-0003zi-T0 for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l437s-0002tT-At for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:45:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2Gd3t26d/y3LY2H+JD2tvGw/gAXWP5A1DeG2ouC98o=; b=ans76OWiacsJSqSAHalFYoES04TWW1CfGpvIjVAye3FNhEX/Tm6PuT8jkCM6Mb5OoR1Cp2 Bo/M6X57G2vk1c/mqa9eCGlkwlPkfUwJPrNDo8qSDtITRnmh1WEjfQvZA5ozbzbm379/MD NvnFCsh9lowfT3Cew6nBYdCd4SddUfA= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-ZW-Mrge0PVGurjP2giZLyQ-1; Mon, 25 Jan 2021 09:45:54 -0500 X-MC-Unique: ZW-Mrge0PVGurjP2giZLyQ-1 Received: by mail-ej1-f70.google.com with SMTP id p1so3855458ejo.4 for ; Mon, 25 Jan 2021 06:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B2Gd3t26d/y3LY2H+JD2tvGw/gAXWP5A1DeG2ouC98o=; b=O6D45UpXBnxCujP9M6qwnMuvs/ORtVyCySOHFdjzdS5bEEFv8dFFLhDK8gEwLIIfiN qQAoBTwcHbvF7cJajvM89QfLUV/63vIRjeKQ60s7ciidBdKeq3VE4uGue9gYPH+3ybP+ wiQD9EVrSLLl1XMX03WDT3z22c+6+TbXPIj/pQaXm4LpceB6Y3Bv3RLbImX5lCiWh+Ay TobBkXoxe+3Q+85uju1bLSJY16SpcLYczq5k3ElkM3eDkNJmQuPjQ5d9SG9alS3wffbS 7na1LCGuoCWZVuN8vrjNHB1QYjK8yqw9+86DdARWuOEz4NknaU0PL23ND2dTsCP2HlXi 1EUw== X-Gm-Message-State: AOAM533IzQCFFCSL8GCG2aFbO56n3f7wQvH5m8eg+CHNup7gYZdEdl+S F8Q0aHv7cJ8KWJ4Rwt3KQLW8aeI4oPd1/i8N+rCBUkywL3brcpo6TLgdEe4VAk6LHWKkAZJA8m8 gXs+L/8LKoNwlfRoF7JjNEihVdzrW9SzA8CRp1QXbI6uhQXguMNzgNMh/2LHXEH9O X-Received: by 2002:a50:fd84:: with SMTP id o4mr751455edt.340.1611585952696; Mon, 25 Jan 2021 06:45:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyA0fXL//k93o4UH9A4XlD7FiddFN+j95oeaipptv/B9N4spO8S6tWfqxWTLyTL/YHLG2FCg== X-Received: by 2002:a50:fd84:: with SMTP id o4mr751439edt.340.1611585952571; Mon, 25 Jan 2021 06:45:52 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id o4sm4324731edw.78.2021.01.25.06.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:51 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 3/4] meson: Explicit TCG backend used Date: Mon, 25 Jan 2021 15:45:29 +0100 Message-Id: <20210125144530.2837481-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 35a9eddf5cf..16b2560e7e7 100644 --- a/meson.build +++ b/meson.build @@ -224,7 +224,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if get_option('tcg_interpreter') - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental and slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif @@ -2447,8 +2447,12 @@ endif summary_info += {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if get_option('tcg_interpreter') + summary_info += {'TCG backend': 'TCI (TCG with bytecode interpreter, experimental and slow)'} + else + summary_info += {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info += {'TCG debug enabled': config_host.has_key('CONFIG_DEBUG_TCG')} - summary_info += {'TCG interpreter': tcg_arch == 'tci'} endif summary_info += {'target list': ' '.join(target_dirs)} if have_system From patchwork Mon Jan 25 14:45:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12043589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F84C433E0 for ; Mon, 25 Jan 2021 14:52:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FC9F20848 for ; Mon, 25 Jan 2021 14:52:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC9F20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l43EQ-0008Cy-Fz for qemu-devel@archiver.kernel.org; Mon, 25 Jan 2021 09:52:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4389-00046U-Hp for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:46:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l4380-0002zS-9z for qemu-devel@nongnu.org; Mon, 25 Jan 2021 09:46:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moujoo3wpaqNyQsY1CrjUL6h3PWNXXcWEFS2F5fvjSs=; b=IxWLkoyp6FgCx3bkJRVIGQwLwwQYD4GNrR8/daCUB4BYdnUawYfjYURe0S3/yeHiA6KRCn 5PYsmz2ApRiGTipAUoiGtVqmdFG599YoVRNijFDDhb/RWlfRy9X4yVFzjHWzTyY3sKM7Av kRc/BosOKi+auzFJhLuCO+HD4cSxmAU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-nCjyCckmOUaYlhhUl43BcA-1; Mon, 25 Jan 2021 09:46:00 -0500 X-MC-Unique: nCjyCckmOUaYlhhUl43BcA-1 Received: by mail-ed1-f72.google.com with SMTP id 32so7527951edy.22 for ; Mon, 25 Jan 2021 06:46:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=moujoo3wpaqNyQsY1CrjUL6h3PWNXXcWEFS2F5fvjSs=; b=Ap5zC8FWJU9a3EEtVqu9vt9FFnrh3HG57StZpdmhSgE38+lvH3X6HI2m1SABbY5IkE o3nYY1VGDqiuJHbw/+J6+AiUsITYr2Th1SprNQTvDNz0dLpcR2YM38UDWei9eEevy/zz g8K9flVVI0Qy1X8N+IDXc8CBGVf0kwoXjCpsNjlHAc6FZNfXbDPjiDBI2GzarKPdY+pd 4h7+dJi+ycB2VaaXRL5YnmlFVb7b9+hJtYqweEiKrsF+Bhh6wakssBx+7QZoWlOp/Aye V+d+dhi/rTJjPN2Kq181p51GQVt2B3Aw+XTZEO7jSxm8QBzRZUxQI1+6gWUbqk64eRSt tvvg== X-Gm-Message-State: AOAM533VYaxCUs4IfCVmDmX5f2dOjqvXv8TvaP2//VxS1JUK7bgUV3/t 1imgrvCtI93VYevnWvp6r09TmnCMxz+ivN8X5qd6htnqCx+gzE46YNXBN8q6yTzSgRLS/L1XXsh 7Qwomgt9HXf1uHih3HL+aoNV87khd2Tu7IZVz9M7H8Cv4tpYaqjPNHE+pGX5n1ZnI X-Received: by 2002:a17:907:20a7:: with SMTP id pw7mr578437ejb.283.1611585958793; Mon, 25 Jan 2021 06:45:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZjFAUdE2ZQt3llbkO2qTr/PmCco0P0DUiSz77Ob9rRL45HV+QX+FG3XB+CIWcH6hzBdnaKQ== X-Received: by 2002:a17:907:20a7:: with SMTP id pw7mr578417ejb.283.1611585958640; Mon, 25 Jan 2021 06:45:58 -0800 (PST) Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id l1sm8336612eje.12.2021.01.25.06.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:57 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available Date: Mon, 25 Jan 2021 15:45:30 +0100 Message-Id: <20210125144530.2837481-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.255, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P . Berrange" , Stefan Weil , Richard Henderson , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Suggested-by: Daniel Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- meson.build | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meson.build b/meson.build index 16b2560e7e7..f675c54e636 100644 --- a/meson.build +++ b/meson.build @@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu)) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend available') + warning('which provides substantially better performance and reliability.') + warning('It is strongly recommended to remove the --enable-tcg-interpreter') + warning('configuration option on this architecture to use the native') + warning('backend.') endif if get_option('tcg_interpreter') tcg_arch = 'tci'