From patchwork Mon Jan 25 11:31:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12045287 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7655BC433E6 for ; Tue, 26 Jan 2021 05:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 407EA22B2C for ; Tue, 26 Jan 2021 05:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727147AbhAZFCI (ORCPT ); Tue, 26 Jan 2021 00:02:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:39070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728250AbhAYMoD (ORCPT ); Mon, 25 Jan 2021 07:44:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 68E1B229EF; Mon, 25 Jan 2021 11:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611574334; bh=korZHA4N+5N7x+HxWDYsFG7OLXGozqFeC35pIVA8E1w=; h=From:To:Cc:Subject:Date:From; b=mgTolqdVu3vPLoH+5GdnRjtJbmkEHvzmgOd5331GrCD25GBB8VGE8Lu30fOVo+A/G qtGdhKhrVWvL+qCNV6Jm9UniNoyudf1/Hf4Dqc+HETApfveB+8KtI7jOwBOVh4avTF s+1G74+0O8RHnkHCZWm8h2b3m7vT3HUD89LjQd76Z1UScbRI7Mw65Wyi+7tla/YoPj 3l8BVFE/P+9KEH+XmJ2GIv5W1aY1T7uktwyNPXdRbMvAvybVeznR2YpcmmWfwgVHA5 dXx/aHnAuAb1tgbQIU3tb371/lDD96K0FcWVUewjXoBjtN8lDq4UXGxHTNrN2olf36 FdqAsoSg7DXHg== From: Arnd Bergmann To: "David S. Miller" , Jakub Kicinski Cc: Arnd Bergmann , Mauro Carvalho Chehab , Florian Fainelli , Andrew Lunn , Loic Poulain , Pablo Neira Ayuso , Masahiro Yamada , Martin Varghese , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [net-next] bonding: add TLS dependency Date: Mon, 25 Jan 2021 12:31:59 +0100 Message-Id: <20210125113209.2248522-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Arnd Bergmann When TLS is a module, the built-in bonding driver may cause a link error: x86_64-linux-ld: drivers/net/bonding/bond_main.o: in function `bond_start_xmit': bond_main.c:(.text+0xc451): undefined reference to `tls_validate_xmit_skb' Add a dependency to avoid the problem. Signed-off-by: Arnd Bergmann --- I could not figure out when this started, it seems to have been possible for a while. --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 672fcdd9aecb..45d12b0e9a2f 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -42,6 +42,7 @@ config BONDING tristate "Bonding driver support" depends on INET depends on IPV6 || IPV6=n + depends on TLS || TLS_DEVICE=n help Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet Channels together. This is called 'Etherchannel' by Cisco,