From patchwork Tue Jan 26 12:47:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046485 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA49C433E9 for ; Tue, 26 Jan 2021 13:06:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9A4F2311D for ; Tue, 26 Jan 2021 13:06:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387832AbhAZMyl (ORCPT ); Tue, 26 Jan 2021 07:54:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403919AbhAZMt3 (ORCPT ); Tue, 26 Jan 2021 07:49:29 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF9BC061A31 for ; Tue, 26 Jan 2021 04:47:37 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id c127so2619921wmf.5 for ; Tue, 26 Jan 2021 04:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tMPWL4xcF1JuemrxQOYLmhlUXhHVXt9aCwFIvLWAmvg=; b=NPJrLaJ+ieP70+yUH0QEuQwSl/cJVDPNtryk+LPPOU4ry0VjoWJADw8ppN74mpelqa v7DZOil5sBeBMS9JjBEIZySg0hBo4Qkm6npFjH57DCrM2MdPuXoVOMWKVsEOq07C3L1o bFftf5O4HyIWE8HbRhxXrz64hiVWg2MfcYJljZJ8iAyDlKuqFiAJjB+eVnd4EFsXrJaw TDs1+Nqqno78NLwdMDvF8e8D9CZgBVmJP2urdcU8Khx8BIz6Kr+Ch+xifOvLCzKrbfu0 u/M4eJPU1Yxiaq/L/Kd+eZFu+rCuTdpmsqXUzKgH12cGzzjU/hJMxVzheaJjLPOLVJLi fCew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tMPWL4xcF1JuemrxQOYLmhlUXhHVXt9aCwFIvLWAmvg=; b=hdp6c/03xMgVl4hMcV4BXJfGy8iIVuDRdc08ZpFGyG5hhCkyHQGKTtKwNmisNUFHyK mv0Rj77Fp7YUNG4yaJfuA4apuRgYCqKtuCGKTCI66xGLZQpJ3aZw+TnUNfFZy4RWqvjc rvgWjCJkoJUo6mKjcjRS5r/KdSNIL6TXBt7pxRdknV8zPFi5L0v6VRxnnKNssCr9ooIS MeY6mlLe0o9P49mZ+p9s6U+XITqjTJ0Mq/k318B6y/6ViLHkYtVoNGTYEFS5gUl0nW46 agPD/+sEmnXO8QHU/YFTiv+RY29TohMU6Gmt/0S/LcKW4TprUa9ABxnCm9if34QDGWib ZOSA== X-Gm-Message-State: AOAM530rfA7cYboEZ+ILgXWG2a0avPYtNJVNlmQHwcaJ0mA2ZQ5av77o f22OWyQgW19mtvxmPoTvxgnWXg== X-Google-Smtp-Source: ABdhPJwHKbeLsVd+Hxqfezp4jl3v4stixH8G3pUHkseIsG2FSuSpZibIrfyILM1amXTlIQK/o8JB/g== X-Received: by 2002:a1c:f312:: with SMTP id q18mr4526261wmq.79.1611665256744; Tue, 26 Jan 2021 04:47:36 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 01/20] RDMA/hw/hfi1/intr: Fix some kernel-doc formatting issues Date: Tue, 26 Jan 2021 12:47:13 +0000 Message-Id: <20210126124732.3320971-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'msg' not described in 'format_hwmsg' drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'msgl' not described in 'format_hwmsg' drivers/infiniband/hw/hfi1/intr.c:99: warning: Function parameter or member 'hwmsg' not described in 'format_hwmsg' drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'hwerrs' not described in 'hfi1_format_hwerrors' drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'hwerrmsgs' not described in 'hfi1_format_hwerrors' drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'nhwerrmsgs' not described in 'hfi1_format_hwerrors' drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'msg' not described in 'hfi1_format_hwerrors' drivers/infiniband/hw/hfi1/intr.c:115: warning: Function parameter or member 'msgl' not described in 'hfi1_format_hwerrors' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/intr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/intr.c b/drivers/infiniband/hw/hfi1/intr.c index 387305b768e94..5ba5c11459e79 100644 --- a/drivers/infiniband/hw/hfi1/intr.c +++ b/drivers/infiniband/hw/hfi1/intr.c @@ -91,9 +91,9 @@ static void add_full_mgmt_pkey(struct hfi1_pportdata *ppd) /** * format_hwmsg - format a single hwerror message - * @msg message buffer - * @msgl length of message buffer - * @hwmsg message to add to message buffer + * @msg: message buffer + * @msgl: length of message buffer + * @hwmsg: message to add to message buffer */ static void format_hwmsg(char *msg, size_t msgl, const char *hwmsg) { @@ -104,11 +104,11 @@ static void format_hwmsg(char *msg, size_t msgl, const char *hwmsg) /** * hfi1_format_hwerrors - format hardware error messages for display - * @hwerrs hardware errors bit vector - * @hwerrmsgs hardware error descriptions - * @nhwerrmsgs number of hwerrmsgs - * @msg message buffer - * @msgl message buffer length + * @hwerrs: hardware errors bit vector + * @hwerrmsgs: hardware error descriptions + * @nhwerrmsgs: number of hwerrmsgs + * @msg: message buffer + * @msgl: message buffer length */ void hfi1_format_hwerrors(u64 hwerrs, const struct hfi1_hwerror_msgs *hwerrmsgs, size_t nhwerrmsgs, char *msg, size_t msgl) From patchwork Tue Jan 26 12:47:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046437 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C11C433DB for ; Tue, 26 Jan 2021 12:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B78492224C for ; Tue, 26 Jan 2021 12:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392070AbhAZMzT (ORCPT ); Tue, 26 Jan 2021 07:55:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404036AbhAZMta (ORCPT ); Tue, 26 Jan 2021 07:49:30 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F8DC061D7F for ; Tue, 26 Jan 2021 04:47:39 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id m187so2346802wme.2 for ; Tue, 26 Jan 2021 04:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bwZHLBV2JS6GWXnvbYJdRkmpIgp0vHY6q4uz5g/IZE8=; b=xDf2jLJ9BS5w40h7X7toDBe6lSpyuD18tkLth0biAYEu/jMnh/IHrnN3YEosErZa4V Wb/jFaZ4CbEOlf9QH09uP95ZzExw5pmHPpZwC1QRM3YfgUgsaV4vgQeTzahUOMYud4WO 6hKX6fT5m1+aGPpxFF/s/zY7526Hil5+/S9JdLJre83GlyoiXaB3YZ5o2XzlYC3kR/DF tI0Out45E9Xzb+ELsEAMjL2/NtsjkbPBfYbwkXMsy/qntjaXZ5foPisOuqeHby7P7B0e coqoc4Q7J4ShMxLzFux29+jMT/o/+yxtggLs/7TqkA6KYknxe2k8V4FxMdM1gSbE/6a2 ePCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bwZHLBV2JS6GWXnvbYJdRkmpIgp0vHY6q4uz5g/IZE8=; b=Dz6i9J2BURC6lQ+VzCXQMYBHtlhRx5mWh4E+kuG27YMYcEQcC+Q5nt0uNuQN9Ktzd3 MOu+mXraz5tsI+Epd9aT7j/3mrTUOiTTWaIeOVypOkHOh4LV4c9z6OL5iUgx1zZiiBvt fB19tdfPcaflqWpym1LIeVorpOQJ9BK2GjQ0MNRNcNSshs3jzRdbRjd6atRPFVpk6PPR g4YJ/nv51i43kmnuH9KSF8HYnizDFCskTcQZHaiFQnGXvup4/oM+YDv1xSm2kmuh7AW8 qKqLcrE/tU7KKokoEBni4VC7rqvImNQPbRS2cqaB5CbYWn88/7cIEa2trosDB85vY1/H Nw/g== X-Gm-Message-State: AOAM533guimq5cHuv6auLBfmeJERHpJAkvfyknpjIg3mmP0tSoMHTLwG pHC5Wst305CibUUF2sBDg7aPm1BGlV1r2GLd X-Google-Smtp-Source: ABdhPJxKL3WTgee+lBclj1oNmZ13v21vDISRjfCGYU7SJejUQaKhRSDQZQTya/sJpgPivEVDeh7SFQ== X-Received: by 2002:a1c:a406:: with SMTP id n6mr4561592wme.53.1611665257845; Tue, 26 Jan 2021 04:47:37 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 02/20] RDMA/sw/rdmavt/srq: Fix a couple of kernel-doc issues Date: Tue, 26 Jan 2021 12:47:14 +0000 Message-Id: <20210126124732.3320971-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/srq.c:78: warning: Function parameter or member 'ibsrq' not described in 'rvt_create_srq' drivers/infiniband/sw/rdmavt/srq.c:78: warning: Excess function parameter 'ibpd' description in 'rvt_create_srq' drivers/infiniband/sw/rdmavt/srq.c:336: warning: Function parameter or member 'udata' not described in 'rvt_destroy_srq' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/srq.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/srq.c b/drivers/infiniband/sw/rdmavt/srq.c index 64d98bf238ab0..2a7c2f12d372e 100644 --- a/drivers/infiniband/sw/rdmavt/srq.c +++ b/drivers/infiniband/sw/rdmavt/srq.c @@ -67,7 +67,7 @@ void rvt_driver_srq_init(struct rvt_dev_info *rdi) /** * rvt_create_srq - create a shared receive queue - * @ibpd: the protection domain of the SRQ to create + * @ibsrq: the protection domain of the SRQ to create * @srq_init_attr: the attributes of the SRQ * @udata: data from libibverbs when creating a user SRQ * @@ -311,7 +311,8 @@ int rvt_modify_srq(struct ib_srq *ibsrq, struct ib_srq_attr *attr, return ret; } -/** rvt_query_srq - query srq data +/** + * rvt_query_srq - query srq data * @ibsrq: srq to query * @attr: return info in attr * @@ -330,7 +331,7 @@ int rvt_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr *attr) /** * rvt_destroy_srq - destory an srq * @ibsrq: srq object to destroy - * + * @udata: user data for libibverbs.so */ int rvt_destroy_srq(struct ib_srq *ibsrq, struct ib_udata *udata) { From patchwork Tue Jan 26 12:47:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046403 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C36C433E0 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95C1C23122 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391304AbhAZMts (ORCPT ); Tue, 26 Jan 2021 07:49:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404040AbhAZMta (ORCPT ); Tue, 26 Jan 2021 07:49:30 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34FEAC0698C0 for ; Tue, 26 Jan 2021 04:47:40 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id p15so9656917wrq.8 for ; Tue, 26 Jan 2021 04:47:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i9Mu8Bh1YY8EtsX22yToiGMh//B01t5LgpZPGaTQ+Bo=; b=i0VO5mhW8uoKItgQm7dfy12wJVs5GTBAslNT7PWgwS7TuwlhdcxUEdQqzki08qZkQC YjgRfy3KrKwCInmXbDIeaD7G/dXs93oEphzBYGQUSygA36QZETV9s7KptEBUt6S0JNZu M6+xxyrs4nOFtD8+Imix14sya8zsehfGTyJ2XK1S8X8nW3zaYs9bwmVUQI0o2GeXnHKC rg/C/EKYFIsSHkFpHEuOuytKfxlsQGXqph8v6UwaSx+oAIvah6CGkuAvDoIudoy0ltnB ZJkrtDCYpdtu1tDrILXOYyq3NtO7A/E0hE8k8U+PntWoFwMM8QYxyL+D/qvpm12l8bRe 8B1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i9Mu8Bh1YY8EtsX22yToiGMh//B01t5LgpZPGaTQ+Bo=; b=l5ewzuioAgMCD+lOoCWNBke0t3rUZqhzLSPPdCoeUeWbxI1sgGRocC7scGzVWj/AKZ oNL9gYKKWhh5DPKo9oRyGEL2Qwnm6FY5EiZyGjNdqucSsNEvYD7fy9LH+/GMn2UP8Q5f UwBIEMlZPZNeGUGAPA/eHIUlRP2NW7KAkXkKerCUOWpGuMq1oaaH6VbOE8RHBBi9uiaG ykVeb3GN4hXZOCjOgiy4AmhQcpoE2n5yMFYboAf82nJSL7lfndWDkq5cdABa5dgqm60c BhVsGIe5k5qpb+NTHT6cvtWkwWsT6JExQ2hJY2i9UsKDrwGvNys/vmpd+IE9RDL10fXq N0PQ== X-Gm-Message-State: AOAM531o0J4hAIQ3wxPGubmVW1bU1MZLRsve1mlkSplSuXXydMhED5o0 uGlV3SZesEFSKc05GZoEGzDCig== X-Google-Smtp-Source: ABdhPJw9ITUWt0EJXUR9dYh1AQKI+wsUulyl960WAdsqnnB/If5INkjPbVIRAIdpsX0AEOHvSxbPzQ== X-Received: by 2002:adf:e610:: with SMTP id p16mr5840983wrm.169.1611665259013; Tue, 26 Jan 2021 04:47:39 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 03/20] RDMA/hw/hfi1/iowait: Demote half-completed kernel-doc and fix formatting issue in another Date: Tue, 26 Jan 2021 12:47:15 +0000 Message-Id: <20210126124732.3320971-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'tidfunc' not described in 'iowait_init' drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'wakeup' not described in 'iowait_init' drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'sdma_drained' not described in 'iowait_init' drivers/infiniband/hw/hfi1/iowait.c:52: warning: Function parameter or member 'init_priority' not described in 'iowait_init' drivers/infiniband/hw/hfi1/iowait.c:52: warning: Excess function parameter 'resume' description in 'iowait_init' drivers/infiniband/hw/hfi1/iowait.c:94: warning: Function parameter or member 'w' not described in 'iowait_set_work_flag' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/iowait.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/iowait.c b/drivers/infiniband/hw/hfi1/iowait.c index 5836fe7b28177..1114898026140 100644 --- a/drivers/infiniband/hw/hfi1/iowait.c +++ b/drivers/infiniband/hw/hfi1/iowait.c @@ -26,7 +26,7 @@ inline void iowait_clear_flag(struct iowait *wait, u32 flag) clear_bit(flag, &wait->flags); } -/** +/* * iowait_init() - initialize wait structure * @wait: wait struct to initialize * @tx_limit: limit for overflow queuing @@ -88,7 +88,7 @@ void iowait_cancel_work(struct iowait *w) /** * iowait_set_work_flag - set work flag based on leg - * @w - the iowait work struct + * @w: the iowait work struct */ int iowait_set_work_flag(struct iowait_work *w) { From patchwork Tue Jan 26 12:47:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046441 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B19C433DB for ; Tue, 26 Jan 2021 12:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E09932224C for ; Tue, 26 Jan 2021 12:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392152AbhAZMzb (ORCPT ); Tue, 26 Jan 2021 07:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404060AbhAZMtc (ORCPT ); Tue, 26 Jan 2021 07:49:32 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A083C0698C3 for ; Tue, 26 Jan 2021 04:47:41 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id p15so9656958wrq.8 for ; Tue, 26 Jan 2021 04:47:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N2A/9nno1xl4++74y2P/uvyNiEobVCQkfqRKED5+0vc=; b=n3F89KI4RPSPzvDifs9N2HHAnY0itgxPIoXbCCunKRgVhzoMjqvWs5bGwjgSTIaDZl 4hX+vBEcuS0t/XlD/3y5yAz+0aXk6Y9/c7ZEjVI3RFkVv84bWSvw4n7PJlGM3+0o0Gzi VHdM7cZW6wPgOORTOe/9cUM/kRTNMhki7IS4nbJyRVHI7ZuA1eTzU9t/EqSBpgV7AO45 lv3pbMnvluHwQz87OndGZM0yJBLfMW15HEedQqOEyEoCSgF4wF2HdL0BsMgm/rXIPnR4 F0eF6nJ/fGen4mTuzxpj1f3Ogt/ytG8ptDlpZoGFdra0/B8wx4GwQrSDGUVuWDYp3s8j UMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N2A/9nno1xl4++74y2P/uvyNiEobVCQkfqRKED5+0vc=; b=alfaJi9whuQSlvdAFnNwkLGneCA0vDXE+jdJ3bjIiDrV47LNK2GqpbFyzdzYoHJ0PW SH5XZz+4bSjHNoUtYnYsk3Q6nupEWipYa5L90fqFXzkwSSvjVWWL2HeQCbAyA/tAYjYP JJzCET1w1xKgVVIP+7e3FGKhSkLWz2vrXOxl/TnIs5oTbMZBInga/wImY80/rBtuE81q djAYkPCttkq+L4iyoKjVHwYCI4mQtuxS4aJf6Ye79ABuGf7b/GFEVCWRdHNnnjIcEkAQ fewp5R1XIHjVMzAMZsPHT/uzhR84hBSKkrXWDV3P8ZZ9UztRtr/vSC/EK4urX3BaoJmY cX3A== X-Gm-Message-State: AOAM530tklZRzDehxC3w7+DRyl+vXmb7g194RkIK9NAUaVEpDJKBtoXb d+NDyiNznlLGma5KuQyaexRHcA== X-Google-Smtp-Source: ABdhPJxiPW8UepCs4kGXIndFfWIti+Ug4whrJpMAhh59PCiWRXk1B6kO5m2J4IXWXVrYGGpAg0AwBg== X-Received: by 2002:adf:cd83:: with SMTP id q3mr5883334wrj.225.1611665260142; Tue, 26 Jan 2021 04:47:40 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 04/20] RDMA/hw/hfi1/mad: Demote half-completed kernel-doc header fix another Date: Tue, 26 Jan 2021 12:47:16 +0000 Message-Id: <20210126124732.3320971-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'am' not described in '__subn_set_opa_portinfo' drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'data' not described in '__subn_set_opa_portinfo' drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'resp_len' not described in '__subn_set_opa_portinfo' drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'max_len' not described in '__subn_set_opa_portinfo' drivers/infiniband/hw/hfi1/mad.c:1354: warning: Function parameter or member 'local_mad' not described in '__subn_set_opa_portinfo' drivers/infiniband/hw/hfi1/mad.c:4919: warning: Function parameter or member 'out_mad_size' not described in 'hfi1_process_mad' drivers/infiniband/hw/hfi1/mad.c:4919: warning: Function parameter or member 'out_mad_pkey_index' not described in 'hfi1_process_mad' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/mad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c index 3222e3acb79c6..e2f2f7847aedc 100644 --- a/drivers/infiniband/hw/hfi1/mad.c +++ b/drivers/infiniband/hw/hfi1/mad.c @@ -1341,7 +1341,7 @@ static int set_port_states(struct hfi1_pportdata *ppd, struct opa_smp *smp, return 0; } -/** +/* * subn_set_opa_portinfo - set port information * @smp: the incoming SM packet * @ibdev: the infiniband device @@ -4902,6 +4902,8 @@ static int hfi1_process_ib_mad(struct ib_device *ibdev, int mad_flags, u8 port, * @in_grh: the global route header for this packet * @in_mad: the incoming MAD * @out_mad: any outgoing MAD reply + * @out_mad_size: size of the outgoing MAD reply + * @out_mad_pkey_index: used to apss back the packet key index * * Returns IB_MAD_RESULT_SUCCESS if this is a MAD that we are not * interested in processing. From patchwork Tue Jan 26 12:47:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046439 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78242C433E6 for ; Tue, 26 Jan 2021 12:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 472A92224C for ; Tue, 26 Jan 2021 12:55:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731937AbhAZMz0 (ORCPT ); Tue, 26 Jan 2021 07:55:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404067AbhAZMtc (ORCPT ); Tue, 26 Jan 2021 07:49:32 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E5B2C0698C5 for ; Tue, 26 Jan 2021 04:47:42 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id a9so16322412wrt.5 for ; Tue, 26 Jan 2021 04:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5iSr6BVX0vLsZ6XbdKfpACTjI5e2CvJxacmXWu0DW1o=; b=f68ZTT5BAx8LNsgLSWm/TjA2tIVW26h6lNl+CnoQEtts8XlWcVHbIzA6GJQeyq3TyT puEHbfG0J4EZKkEyTDgAraOOa/BZooJ6LvvY7nZDW6VDOaafEuSJOV1jhSkbqk244pwK idPuhasszf5w3/gQfZFkcQ3CmH/4RF02z5w6H9rm1ifn1t58GjQcdZUNSe4cYw8ilDNW SzqLU+TmgRluyNbUptpAmsTp00jH/i2Atp3qjH1lQeUMTo+9NR89ZPwAjm+Lw9LEHN3Q f8U7Hq2N99WZDlIycYqNcfutBXXYaoMPkzuxtXkl9Sv8he3llLKvltIjw4Yaix9P/x4u +LwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5iSr6BVX0vLsZ6XbdKfpACTjI5e2CvJxacmXWu0DW1o=; b=nQ5npi5CgqdLGmCU9gT1W/3hnvw0FlE0KIoePeKfXpgl5/n39wqV97nRfbs3K+06AU J0k0WmueJDQSv3nlgl498lBpMojEouXc/mrM48gFRJZ9jF3VuxXbvPh8xQj5+FOHTiia 6UpEI9cJAY0Qqg0SspzkcZm38EaC+qP2dq4b/RBXfnMH25fn4B5ZBdB5XQBX9ToJXmym fvepqa53rTpBWoUgU1aJX6zWn1KvMl7UOsE7acORqn5ObOnmMLm7B+EtiBaySDEWQokf cGDsUVABxw1vIPosxg2EY/djlO24d9HaVIYHjIPh0GJJFlWMO64HzHdaK3pDbqlbZ6xf h1sg== X-Gm-Message-State: AOAM5319gaR3bEW2kPgm/iL+08hPlzk1pPmkar92jm/tOT9jPx1PSlxd 3tgmU2Neth8TOpFm9IwtOZv1wQ== X-Google-Smtp-Source: ABdhPJx6VwGxc6iFcBAt+2Q5SwbgbOSyw8EcYP6v7CxipTnjTDMcohXo8wuR7p0/yZ1LW2zXgB4wiA== X-Received: by 2002:adf:f403:: with SMTP id g3mr5943028wro.212.1611665261306; Tue, 26 Jan 2021 04:47:41 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 05/20] RDMA/hw/hfi1/msix: Add description for 'name' and remove superfluous param 'idx' Date: Tue, 26 Jan 2021 12:47:17 +0000 Message-Id: <20210126124732.3320971-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/msix.c:120: warning: Function parameter or member 'name' not described in 'msix_request_irq' drivers/infiniband/hw/hfi1/msix.c:120: warning: Excess function parameter 'idx' description in 'msix_request_irq' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/msix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/msix.c b/drivers/infiniband/hw/hfi1/msix.c index d61ee853d215c..cf3040bb177f6 100644 --- a/drivers/infiniband/hw/hfi1/msix.c +++ b/drivers/infiniband/hw/hfi1/msix.c @@ -103,8 +103,8 @@ int msix_initialize(struct hfi1_devdata *dd) * @arg: context information for the IRQ * @handler: IRQ handler * @thread: IRQ thread handler (could be NULL) - * @idx: zero base idx if multiple devices are needed * @type: affinty IRQ type + * @name: IRQ name * * Allocated an MSIx vector if available, and then create the appropriate * meta data needed to keep track of the pci IRQ request. From patchwork Tue Jan 26 12:47:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046483 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0915AC433E6 for ; Tue, 26 Jan 2021 13:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E0223109 for ; Tue, 26 Jan 2021 13:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403919AbhAZMzd (ORCPT ); Tue, 26 Jan 2021 07:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404081AbhAZMtd (ORCPT ); Tue, 26 Jan 2021 07:49:33 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9AC7C0698C7 for ; Tue, 26 Jan 2021 04:47:43 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id l12so16314248wry.2 for ; Tue, 26 Jan 2021 04:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JqnwtQpR7zRjxIxGO7OfabuwI6zTkwI4IUC4xHbde+s=; b=cvBHhXkuxzLiX4OWL+cfWzUSDdd4nPQDjG7e6O1QSdyaTPN7Yt35vJ9pbIvvuVUdfp KM5HmyTi7kZjfI9KbsyBD9kJY2TGHCPIQ9AuVvkCyGyPf5EF52V0RnWi2Akf0/3Z8yQi +/aw38tTxASeKdQcOyvftC9hve/tcgnAw6k0yAAIY1Mh3pjyMRIg+AwpM/jvl9Xc8Jao pDF2MkqQLJ517MBxidBsH+ri6DTNvZZfTLRJUzvoTJ1ovH/W0fTAef8t2SOW8Qs1O4Kp GAUVCTTAvY4jxK7gZUZb0PVaHjsapSFM68bSTZi6exaViaHjAgjkplPbjJaBnPphTewQ bXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JqnwtQpR7zRjxIxGO7OfabuwI6zTkwI4IUC4xHbde+s=; b=MgfsV2tyY38q0On9GFEZLtQqVtkbr6fgq1ImticQMslJiB2ndA/g+l6DRmtraAZ2id cKrbFabUf30tzTSUSSgt2dGE+qVoiCjtVYG+q+AynQfMUvTHQdgpPnNh9LURXFUtZdEN HgMoYITGUAFCEyCYJwuFb0/829oEgvjIVR8Q6Ek7DdrynbiRYdjnMF/USucMMGXU+WGj XfCRugSqjsj+nsG126IIlWslIIvLFPrAmROqbUWdEtwD8DRkdFGDL4HmH+ygiGkRAfVX kCaa/RCyFAWHnF0IieSJ5KPFMt7L2fnH51qungRAu7WzlD9D8p/UPyKY0/jPZ5xHYP5J NZkw== X-Gm-Message-State: AOAM532u8xywF3r+BDh3GyND+je9B6/Vs5/PxfLAxi4+OnJSBCWV8VKX nHuP9iBOeHNhsOjUoNgwBMiubw== X-Google-Smtp-Source: ABdhPJypSWwMtVwU6H4CcatzRF+WbHG464YrhUgYvMZYokv2g6bW06791dituSqjsOiwOz40Kp6DMg== X-Received: by 2002:a5d:6847:: with SMTP id o7mr5944354wrw.216.1611665262428; Tue, 26 Jan 2021 04:47:42 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 06/20] RDMA/sw/rdmavt/mad: Fix misspelling of 'rvt_process_mad()'s 'in_mad_size' param Date: Tue, 26 Jan 2021 12:47:18 +0000 Message-Id: <20210126124732.3320971-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/mad.c:78: warning: Function parameter or member 'in_mad_size' not described in 'rvt_process_mad' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/mad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rdmavt/mad.c b/drivers/infiniband/sw/rdmavt/mad.c index 8cc4de9aa6644..fa5be13a43944 100644 --- a/drivers/infiniband/sw/rdmavt/mad.c +++ b/drivers/infiniband/sw/rdmavt/mad.c @@ -57,7 +57,7 @@ * @in_wc: the work completion entry for this packet * @in_grh: the global route header for this packet * @in: the incoming MAD - * @out_mad_size: size of the incoming MAD reply + * @in_mad_size: size of the incoming MAD reply * @out: any outgoing MAD reply * @out_mad_size: size of the outgoing MAD reply * @out_mad_pkey_index: unused From patchwork Tue Jan 26 12:47:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046443 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4287EC433E0 for ; Tue, 26 Jan 2021 12:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1575D2224C for ; Tue, 26 Jan 2021 12:55:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403768AbhAZMzc (ORCPT ); Tue, 26 Jan 2021 07:55:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404083AbhAZMtd (ORCPT ); Tue, 26 Jan 2021 07:49:33 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCC8FC0698C8 for ; Tue, 26 Jan 2021 04:47:44 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id u14so2336677wml.4 for ; Tue, 26 Jan 2021 04:47:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mFF2QQVIxFNp90Nwp9Ycl+uVfrjIiAZ/XTfl8r5ymZw=; b=NXFo+MjsuwTE93TK1DXo22fdhXCsOJIX5os6D2un8k+TfF0W44WoEx8MopsRfuCdFP pIn3+whREwoX42q32xde47Zzi8jcBHeSBj8KhF2hGXRuY5TEnqgNLP0pz2qmZx54wzbZ 0jOPdZxcPF1X0mEDAY0EGa5YheyaWiwkhkftdIx2p2j49lsQFhd7j95rIxZ4XCYnzuZe 7DRDSVMUa3Fvj1LwXMU1aIp04wUxnyoO2kKVMylJrKaa+ZhJM3tGMyXKRN0xlU/p88r2 Go7KHM9PALmv9xdbU5dG1UiG9BTBIqz+vpu5ohnoNfBrFNOWNlEZzZ6S3RUdSgKQLe5j gx9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mFF2QQVIxFNp90Nwp9Ycl+uVfrjIiAZ/XTfl8r5ymZw=; b=Q5EcBOVLtJSNOJCdIOkd+YXrvYr1W0Yl8hBGkULVZpdYmXNcDhXV16VvN+cP0fUt9q d9u/ziBxtz27Zr5fl1U1ht3YjjzIe1D3LECaq69KaI0+k6GX6SUAzYjptellXUsh1Ko+ hjuZX+ZzsLo0r8YShEHLTjS5u0TrlT+k3hdcM0JzA7RnT033PuLm6KbgTn1ZxxEKcSZh II6VJgxjoh35N8S6IAxwKW+5bhp4GET90a7OV2ewrL3Vuw6TEWo9VF8gZ8tPTavPV8oO ckexSchc3l+3L+BXXvAMO2BY1hM1X3uw4o9rDCt+QtE/rsnBV7MEwt84rfV87iv/milA 0/uw== X-Gm-Message-State: AOAM531pXIeQT+bWmKP7PBo5g4/nOLahFQmV4x9pYv52RublB09dNgrL fbp5Jv7K2Yh9PmeK/gW9ZZQmJA== X-Google-Smtp-Source: ABdhPJxtqqXwmCwTwN6bwBokU5s+qmzfaQug5nE09DpjSUdLE2Dv+s4i9mbjVL986WtG7WXLmHmm4Q== X-Received: by 2002:a1c:2c0b:: with SMTP id s11mr4371432wms.13.1611665263563; Tue, 26 Jan 2021 04:47:43 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 07/20] RDMA/sw/rdmavt/qp: Fix kernel-doc formatting problem Date: Tue, 26 Jan 2021 12:47:19 +0000 Message-Id: <20210126124732.3320971-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/sw/rdmavt/qp.c:1929: warning: Function parameter or member 'post_parms' not described in 'rvt_qp_valid_operation' Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/sw/rdmavt/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c index 76d6bbfbec50c..9d13db68283c2 100644 --- a/drivers/infiniband/sw/rdmavt/qp.c +++ b/drivers/infiniband/sw/rdmavt/qp.c @@ -1907,7 +1907,7 @@ int rvt_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr, /** * rvt_qp_valid_operation - validate post send wr request * @qp: the qp - * @post_parms_ the post send table for the driver + * @post_parms: the post send table for the driver * @wr: the work request * * The routine validates the operation based on the From patchwork Tue Jan 26 12:47:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046481 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BD2C433E0 for ; Tue, 26 Jan 2021 13:06:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 567F323109 for ; Tue, 26 Jan 2021 13:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403966AbhAZMze (ORCPT ); Tue, 26 Jan 2021 07:55:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404087AbhAZMte (ORCPT ); Tue, 26 Jan 2021 07:49:34 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B22C035438 for ; Tue, 26 Jan 2021 04:47:45 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id b5so16308222wrr.10 for ; Tue, 26 Jan 2021 04:47:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S+DMI0EXUYJJLvmmH2bAEB7JiPLoVbXeT/sw5HJ1UT8=; b=BFvftWxNjJ1f8kZeSk14lsUMun1/l2fh/zf2H/00VdGTMPu6yAgBNrw7KEwZi6M1wS mTWkBcyI8MQqtNZJFTW2FOyW10BxStpDjS71ik/aSVyBT2eYIffwIu2tY+uO1TWDUmlm wkNPljH37Zm3tX8CbgiHUQcguqlyY8aARKGG+27JgQPjbb5VG7PWKilCrUZaS0NOL3xn KSJGvD7Ah0knlmc6gbCugR3iVZaJA+eKz7fqGFmVZavgQZ2j1g/lZxO1iYKLJ/FHD1kV JFREmbuOCnycRzarZqSlPOzfAUp/Nz9SIuUpOWHXI/6PUqKUFh001jcQXvq7eM510Oow DEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S+DMI0EXUYJJLvmmH2bAEB7JiPLoVbXeT/sw5HJ1UT8=; b=iq0Zi7BYOeG7UFzAQfngvjyyv0MhlMtnG6mVfjI4qE4MGE/ArNC586b8aH6z9ONteo 8dZJKGM2hiBEV5OmBbBWSF8w5fp1z1h9mQ3xSBRE/Qg7dsvSeRMe/BMVruYs5aihu7t9 NN06XOcSWJrDvVBvYjv6zCW8uPf6Qrf1HT+SCAOHEUpQl7ferDe5Dn6tXa3POXC3Wu60 mHw+96xYzpdyocEe0gtW2RnnPY8L6dUKTqVnndlhUlEjt727e3+ugHZGG9J9CwFrZb23 zKTooDFNTN+tP1VTxlg4zG5oBsFa5S3jvpD5Jav5OzWqxNxZksEpdsjptdpjVhQ3zlqZ fBvg== X-Gm-Message-State: AOAM531e+Rb6dgj40zomZZ7iMqZrmn73o3JBefKsVNPj/dsrsXUNbZts NnUAiH1vGPuuOCWwi7wbDLm0YQ== X-Google-Smtp-Source: ABdhPJwrmxLQr9CLyptuMRo6dOqaAb/sply8hRE70jVFz+f/6LzkND+6LLI0NL6a3EFXnc8j3mCewQ== X-Received: by 2002:a5d:470f:: with SMTP id y15mr5872456wrq.187.1611665264670; Tue, 26 Jan 2021 04:47:44 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:44 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 08/20] RDMA/hw/hfi1/netdev_rx: Fix misdocumentation of the 'start_id' param Date: Tue, 26 Jan 2021 12:47:20 +0000 Message-Id: <20210126124732.3320971-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/netdev_rx.c:473: warning: Function parameter or member 'start_id' not described in 'hfi1_netdev_get_first_data' drivers/infiniband/hw/hfi1/netdev_rx.c:473: warning: Excess function parameter 'id' description in 'hfi1_netdev_get_first_data' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/netdev_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/netdev_rx.c b/drivers/infiniband/hw/hfi1/netdev_rx.c index 6d263c9749b36..1fb6e1a0e4e1d 100644 --- a/drivers/infiniband/hw/hfi1/netdev_rx.c +++ b/drivers/infiniband/hw/hfi1/netdev_rx.c @@ -467,7 +467,7 @@ void *hfi1_netdev_get_data(struct hfi1_devdata *dd, int id) * hfi1_netdev_get_first_dat - Gets first entry with greater or equal id. * * @dd: hfi1 dev data - * @id: requested integer id up to INT_MAX + * @start_id: requested integer id up to INT_MAX */ void *hfi1_netdev_get_first_data(struct hfi1_devdata *dd, int *start_id) { From patchwork Tue Jan 26 12:47:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046445 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DF8C433DB for ; Tue, 26 Jan 2021 12:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E51142224C for ; Tue, 26 Jan 2021 12:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403985AbhAZMzl (ORCPT ); Tue, 26 Jan 2021 07:55:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404090AbhAZMtf (ORCPT ); Tue, 26 Jan 2021 07:49:35 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B032C034601 for ; Tue, 26 Jan 2021 04:47:47 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id c12so16338841wrc.7 for ; Tue, 26 Jan 2021 04:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=deIr3conzzcAnJ0iN+eWlZZAsgdUd4uaIBytevHZc9w=; b=Ni/X8P7dw/EUpGfKcK7INpqiGEkSO6stlLXETIJ9Hsc/eStM7kQmSqPWWRyjR9SDwS 6NJH+glOQ4t8RTs7UT2S8vsZ1V0hB1TtCNjWE8cucBwdlxuw6me0cYMy5XcDDD+ec6BR 0laMB2dQnbQjPTvB85Ah0CtYslCYRVb/TDFiw/GBAuPOJsewXFiB1L+GsNlwGt+Uu68k lHbZsGj5OKqgsLZywAQFeKXZ0SfFm9JuTvfDpgsgUJ/MLu2H3juUdiWlhn1G+xtNkQ2R fUo0CpQJb+EJJOEECV8GXxp8A7YRkt3iu6tBgz549wF2GIiZPFpdgDUq+L3vqUzwngJW 36WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=deIr3conzzcAnJ0iN+eWlZZAsgdUd4uaIBytevHZc9w=; b=eyl7MBKiYdBJX47+6mckMwqvWJNw+rmd6fefNCMAZ9TUqshAagzbHoOfFa+h2ZUniK Wazs5J1Q1snnf/6tCNVRwsLPqL63JeV42DjtW6t+EBf4JoXiTwKZOQUvtNlmezlL8ISO S2xpEpytpBBc3/c1kiYXd7YcNIOBIMOKWVZF01sOUyFOmziQJabDQwVBlyi98wAWG5oL 49H47SJ962ePxmII7hqDX5e9i8czXhssYjWz4F3ucPEI33+kdI7xUtCO6x+hyXAnY9cc B+avyabmwEhfMw8VdO9ojerV53vBXvlRdwDOGs5ftm/JC7OWqEj+bXxmPnL3yT3l5yqt 8P9Q== X-Gm-Message-State: AOAM533/6GFaX2/FZnW8DpN9S3H3UORFGwTF1OaGK0fcc/K/P7NHsRo6 AoMRzihvWRt+MiwXoDB6sPukew== X-Google-Smtp-Source: ABdhPJyu9yO8Y+a1f2EmA3BEdiSu8PkKvmgcnmyJjujRPzhuUqTg9MHXepuGkl+jLmhdpXe0Yfv8sQ== X-Received: by 2002:a05:6000:1565:: with SMTP id 5mr6039531wrz.109.1611665265817; Tue, 26 Jan 2021 04:47:45 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 09/20] RDMA/hw/hfi1/pcie: Demote kernel-doc abuses Date: Tue, 26 Jan 2021 12:47:21 +0000 Message-Id: <20210126124732.3320971-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/pcie.c:343: warning: Function parameter or member 'dd' not described in 'restore_pci_variables' drivers/infiniband/hw/hfi1/pcie.c:402: warning: Function parameter or member 'dd' not described in 'save_pci_variables' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/pcie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c index 18d32f053d26e..6f06e99205037 100644 --- a/drivers/infiniband/hw/hfi1/pcie.c +++ b/drivers/infiniband/hw/hfi1/pcie.c @@ -334,7 +334,7 @@ int pcie_speeds(struct hfi1_devdata *dd) return 0; } -/** +/* * Restore command and BARs after a reset has wiped them out * * Returns 0 on success, otherwise a negative error value @@ -393,7 +393,7 @@ int restore_pci_variables(struct hfi1_devdata *dd) return pcibios_err_to_errno(ret); } -/** +/* * Save BARs and command to rewrite after device reset * * Returns 0 on success, otherwise a negative error value From patchwork Tue Jan 26 12:47:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046447 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CABC433E0 for ; Tue, 26 Jan 2021 12:55:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3C8D2224C for ; Tue, 26 Jan 2021 12:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404000AbhAZMzn (ORCPT ); Tue, 26 Jan 2021 07:55:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391070AbhAZMto (ORCPT ); Tue, 26 Jan 2021 07:49:44 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22C18C08E86F for ; Tue, 26 Jan 2021 04:47:48 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id m13so1882347wro.12 for ; Tue, 26 Jan 2021 04:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E3TPshJEOpUxZ52hskTlO67Qqk3Ra8/d2GtrTB1ggtY=; b=aufbBYTlyyVvy/8ib6Safly+lDI/cY/nGr8NsKxe/qt3uC4pkYxC73Jdn/4NSG1fuh QqNK6OVg91g9NI6DZBVWL8/LZmAFRBrnCA+BZx12J8zIC3zCrxJ5rJwrFkQj7/2xF6Fc BNJYhamHsG7W8a+wVZ5TClIQrpttkKW32/vuMM8/LlrcZrwdyNm9M0LFcfB1KiVrKwUq 75VfIIMsS3tAtdUIXCdhStc1+S5dRGRQ646jMovViooA/bDR5fiQ6lyP/nVg7Hi9XqMV xrk2tZP/n4LOU4uk7gZhp8TEkz+gFFgpFDkmm6N60J27ytL4Lu7GaoFRP6+NCqVbATkc J4Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E3TPshJEOpUxZ52hskTlO67Qqk3Ra8/d2GtrTB1ggtY=; b=ifY3COwb8aV31EhZUeUNbFMHqKvlPpvp9qw9FJRBzdlIaJjsn942rjQaPT0DdX04ui dbxHEcbH7iozjcLyOwWCYAAWY+ZW4rUSjVf5Ch4M2QQbhhupMRnLgrTOMEKidkwaCNHw qS89A/tZIvuhuaowulHdaO0I8nLBAzP2yhE9o1fHT88HW6Yl4Mf3JqMn8sK2SyOHkafB LEdY18trHTATCeP10DfQ8XU9H13FLmf5/tkeDdl4/+ok2Ne74SNS2WiNNIoVXKP1OjHN D6DjPVQsJawQG6oB+0LYlVZw0TKbwpve+7d9B/7Gjv4y4VBVMOqmUC2/NXalF7mczY2t vBEw== X-Gm-Message-State: AOAM533kFPm1SNli2E8SZUmMqUMvQsAI+Tx/5PLjbfm7NrfhO8lFhxDf ZDh+5cBPH1dDllXnjGvp7JSDBg== X-Google-Smtp-Source: ABdhPJzNGpzPPPE7/NWFHvm/KqfZ2gdr6pBlIKgL/nfMP+CSk3BohIx1TgiEfh8ZjrIeCxjOnpX3TA== X-Received: by 2002:adf:dd45:: with SMTP id u5mr5869371wrm.392.1611665266932; Tue, 26 Jan 2021 04:47:46 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 10/20] RDMA/hw/hfi1/pio_copy: Provide entry for 'pio_copy()'s 'dd' param Date: Tue, 26 Jan 2021 12:47:22 +0000 Message-Id: <20210126124732.3320971-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/pio_copy.c:73: warning: Function parameter or member 'dd' not described in 'pio_copy' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/pio_copy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hfi1/pio_copy.c b/drivers/infiniband/hw/hfi1/pio_copy.c index 4a4ec23978579..14bfd8287f4ae 100644 --- a/drivers/infiniband/hw/hfi1/pio_copy.c +++ b/drivers/infiniband/hw/hfi1/pio_copy.c @@ -55,6 +55,7 @@ /** * pio_copy - copy data block to MMIO space + * @dd: hfi1 dev data * @pbuf: a number of blocks allocated within a PIO send context * @pbc: PBC to send * @from: source, must be 8 byte aligned From patchwork Tue Jan 26 12:47:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046405 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5C5C433DB for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB03923127 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391809AbhAZMtz (ORCPT ); Tue, 26 Jan 2021 07:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403796AbhAZMtv (ORCPT ); Tue, 26 Jan 2021 07:49:51 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5F8C08EB22 for ; Tue, 26 Jan 2021 04:47:49 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id 6so16315043wri.3 for ; Tue, 26 Jan 2021 04:47:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rnUOXuaDVhzv+JRzF2N3phcXKpl5z42SkYZrTN+HwL8=; b=MqNVz8RNxX/zGJoBvGZbRzmox2XT2+Oo/kNZZVSP2zXsRlIQkB6mQwDoEBKNS+SK4q Z/4yHb7RqDDLXtoV7Rl536qDZwv7sYfZeavJ9tMpe+Ksv1Ss4RMNynaIgYmnCjSGWGsF 3HiYTJDeO+PRz9SVF6G9UzhTAwOJSAWOtGC+eGgr9wfCHNVoNzlL7j9NDn9SUsa5uPbi 6YEDTLtk6bftJmna9JYd7xBUpLEzK5bn6EcKNrY6GWQ7h/M1NeyNVZOkfxXt+SMg+Wgh /wOOjdsMNBbmv2tmNmERZuUae9CxU8/Vg3xFbF/Ip/K+RnHJZRZBY7hHLbW0jKAt2bub Kk7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rnUOXuaDVhzv+JRzF2N3phcXKpl5z42SkYZrTN+HwL8=; b=jwoTqQ44b/xz7daz+2+TuN3MfCnb7FsNq5//CusZETbpF8nn2hvQmDmnGfeQjJFKJ8 eSersBob+TZb6Z/1Sw71pZdWo99ycmDoK9bNX564sfKh7o30m42FLfV0c95TKIC5L8y/ o7OK9fcHdRKOdayP5hHjSn/ZzJlr5Ov5t9ewQakjZhpEtKRhUBzxGf3RBgfqqFMPPdqm eMnavNgLYbA1mi2cXFb/j/mi2GGc80vRpyFeEIVl38KQ+AwxjFMIgrCGdEePBDDHrYvx pb19J7JPM5dy2UcJlRjw00U52CdVGgVfFb6Ol/fUr2oL5Q3B68nD9zlSb60YVFF2PpCC Q7Hg== X-Gm-Message-State: AOAM533HBs8XWObdmODwTCiHb4KC+uCFvXNsqu7SsZ3giBTNqhb8IIry hGdhN/opCcPbqbL1p6C15J+peA== X-Google-Smtp-Source: ABdhPJyLudmPTC3h2iicIMU90/lCacPFTuduSuKUdXae8KM5eDTxCucVccuknk2sFWP6UvfheL9vuA== X-Received: by 2002:adf:cd83:: with SMTP id q3mr5883891wrj.225.1611665268097; Tue, 26 Jan 2021 04:47:48 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 11/20] RDMA/hw/hfi1/rc: Fix a few function documentation issues Date: Tue, 26 Jan 2021 12:47:23 +0000 Message-Id: <20210126124732.3320971-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/rc.c:430: warning: Function parameter or member 'ps' not described in 'hfi1_make_rc_req' drivers/infiniband/hw/hfi1/rc.c:1387: warning: Function parameter or member 'packet' not described in 'hfi1_send_rc_ack' drivers/infiniband/hw/hfi1/rc.c:1387: warning: Function parameter or member 'is_fecn' not described in 'hfi1_send_rc_ack' drivers/infiniband/hw/hfi1/rc.c:1387: warning: Excess function parameter 'qp' description in 'hfi1_send_rc_ack' drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'aeth' not described in 'do_rc_ack' drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'val' not described in 'do_rc_ack' drivers/infiniband/hw/hfi1/rc.c:2008: warning: Function parameter or member 'rcd' not described in 'do_rc_ack' drivers/infiniband/hw/hfi1/rc.c:2554: warning: Function parameter or member 'rcd' not described in 'rc_rcv_error' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/rc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/rc.c b/drivers/infiniband/hw/hfi1/rc.c index 1bb5f57152d35..7194236aec8fe 100644 --- a/drivers/infiniband/hw/hfi1/rc.c +++ b/drivers/infiniband/hw/hfi1/rc.c @@ -421,6 +421,7 @@ static int make_rc_ack(struct hfi1_ibdev *dev, struct rvt_qp *qp, /** * hfi1_make_rc_req - construct a request packet (SEND, RDMA r/w, ATOMIC) * @qp: a pointer to the QP + * @ps: the current packet state * * Assumes s_lock is held. * @@ -1992,7 +1993,7 @@ static void update_qp_retry_state(struct rvt_qp *qp, u32 psn, u32 spsn, } } -/** +/* * do_rc_ack - process an incoming RC ACK * @qp: the QP the ACK came in on * @psn: the packet sequence number of the ACK @@ -2541,6 +2542,7 @@ static inline void rc_cancel_ack(struct rvt_qp *qp) * @opcode: the opcode for this packet * @psn: the packet sequence number for this packet * @diff: the difference between the PSN and the expected PSN + * @rcd: the receive context * * This is called from hfi1_rc_rcv() to process an unexpected * incoming RC packet for the given QP. From patchwork Tue Jan 26 12:47:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046409 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C6EC433E6 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE86E23123 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392140AbhAZMuA (ORCPT ); Tue, 26 Jan 2021 07:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392106AbhAZMt4 (ORCPT ); Tue, 26 Jan 2021 07:49:56 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BCD4C08EB24 for ; Tue, 26 Jan 2021 04:47:50 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id b5so16308477wrr.10 for ; Tue, 26 Jan 2021 04:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bWXDn1Q9e79o1Ahbq11jdzTrjLD5igFdf2jngDni798=; b=GPuwh5UMbRYTIAqxWcuNWJoL/UZWeUSNS+EYoNcJ91J1TkfsGI0YNqhubB8RQGeReP neR90OV2gzOy6VqYlffob/ri5kelHkNcePX6VgL5r6gjn53vWKYh1VhkWeVMupGxgm6L Kyk2/aynygYowh/ZUb+kJT+/UzEgzQh8/S39Aj5luzRPazsi5gYNnVxOy25nQ2hIWfrW oEqQPDq0lO6Fu0Mc+7vHtAf6nkQJaDUyF6Lz4A2Ljfwt/JxlLysavqwwH2dYXWr97Er0 tP+eCmUz7yoWJoSEEQm/BxcMxpvB5T0xjZLLveUJp5jFyX56K967T7uxSIKonfYu4t1T mj3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bWXDn1Q9e79o1Ahbq11jdzTrjLD5igFdf2jngDni798=; b=H7Rk3lnvBlc+Ald9cK+csH5NoAYD0aKYBoR/zBIC79yeB0iIMbeqE7TSa8tJ44PFo1 ajRzZV2mpX0qtVG5Eo7BEuk8UzlP1VcIkawfELJ92YnOSv+0TlFyC7kzkQMGnwmPgvzl mHSkAqFRTcXWa+w3WVa3z8BAge/lng/peDicfdBmFwVJfO85mhV3aD68ojdF40rkZRpq wr/6rEAN4gNU8JsL9YwARKDaV10LqEUMvcYlma++aDzlf2pv2NHhP1sZ008bEuIe9JVy rd2DVeF2v3/+Ao3oLB96ihYgBAQ1kGtHr66cAxEFDcS93TUQIoWHhB0+HTgx7FcbJiD8 hVmA== X-Gm-Message-State: AOAM5318Pt2AvFEbp+vr5hW2L2sXbq/jtEMYC2iq1BzpN0p/VDVST37q AvGJAGbV+mRGp2Jy31tl1+qqsg== X-Google-Smtp-Source: ABdhPJyoqraqYP5Lncuk2TmsiQknmS5tV0xjuVaaRBE6kIXCodS8Icxj6NLW9Dse8QaRWrHHIWGA5g== X-Received: by 2002:adf:f403:: with SMTP id g3mr5943566wro.212.1611665269305; Tue, 26 Jan 2021 04:47:49 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 12/20] RDMA/hw/hfi1/qp: Fix some formatting issues and demote kernel-doc abuse Date: Tue, 26 Jan 2021 12:47:24 +0000 Message-Id: <20210126124732.3320971-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'dev' not described in 'verbs_mtu_enum_to_int' drivers/infiniband/hw/hfi1/qp.c:195: warning: Function parameter or member 'mtu' not described in 'verbs_mtu_enum_to_int' drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'qp' not described in 'hfi1_setup_wqe' drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'wqe' not described in 'hfi1_setup_wqe' drivers/infiniband/hw/hfi1/qp.c:306: warning: Function parameter or member 'call_send' not described in 'hfi1_setup_wqe' drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'qp' not described in 'hfi1_qp_iter_cb' drivers/infiniband/hw/hfi1/qp.c:922: warning: Function parameter or member 'v' not described in 'hfi1_qp_iter_cb' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/qp.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/qp.c b/drivers/infiniband/hw/hfi1/qp.c index 681bb4e918c92..e037df9115127 100644 --- a/drivers/infiniband/hw/hfi1/qp.c +++ b/drivers/infiniband/hw/hfi1/qp.c @@ -186,7 +186,7 @@ static void flush_iowait(struct rvt_qp *qp) write_sequnlock_irqrestore(lock, flags); } -/** +/* * This function is what we would push to the core layer if we wanted to be a * "first class citizen". Instead we hide this here and rely on Verbs ULPs * to blindly pass the MTU enum value from the PathRecord to us. @@ -289,9 +289,9 @@ void hfi1_modify_qp(struct rvt_qp *qp, struct ib_qp_attr *attr, /** * hfi1_setup_wqe - set up the wqe - * @qp - The qp - * @wqe - The built wqe - * @call_send - Determine if the send should be posted or scheduled. + * @qp: The qp + * @wqe: The built wqe + * @call_send: Determine if the send should be posted or scheduled. * * Perform setup of the wqe. This is called * prior to inserting the wqe into the ring but after @@ -595,7 +595,7 @@ struct sdma_engine *qp_to_sdma_engine(struct rvt_qp *qp, u8 sc5) return sde; } -/* +/** * qp_to_send_context - map a qp to a send context * @qp: the QP * @sc5: the 5 bit sc @@ -912,8 +912,8 @@ void notify_error_qp(struct rvt_qp *qp) /** * hfi1_qp_iter_cb - callback for iterator - * @qp - the qp - * @v - the sl in low bits of v + * @qp: the qp + * @v: the sl in low bits of v * * This is called from the iterator callback to work * on an individual qp. From patchwork Tue Jan 26 12:47:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046407 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B274C433E9 for ; Tue, 26 Jan 2021 12:50:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D20BE23122 for ; Tue, 26 Jan 2021 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403796AbhAZMuB (ORCPT ); Tue, 26 Jan 2021 07:50:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392111AbhAZMt4 (ORCPT ); Tue, 26 Jan 2021 07:49:56 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3017C08EB25 for ; Tue, 26 Jan 2021 04:47:51 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id v15so16308922wrx.4 for ; Tue, 26 Jan 2021 04:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4f4I65tHSu0Sevubz3lp3Zk+K7fk0+tHrgiLNeMd+Rc=; b=p4HdJ6LjNhnbcw4Rkb46d4O637uRz+G/y5kFGVkp3mw/I0eBw5VnPxLp4bvxxC6wPD GUyd4XS8uv/MF76CwjocbLJjE/kwtXYQ+If2ymHM+H/TPnFDJnXwSXLLdWBhlOJ4MQBn nNO/VP+yk6ec2yyGbteddQCv3ieCJxN/y5KZ+AnFkCHYtohS/SQxbSQxTaGYs3+iqI0P tOWUnxm8z/PTmJkNGaUVOnm9brIEBrrC6EjUD72jUJkyPtLQ5kljrZhftYjfpDSmgdec 4yGsORj7TSSiL+/AspbTUt4v+Ni4/pBRg9UtqRw/eDSoHo/NE7EZm1Nbw+cuJCQqSOKh p+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4f4I65tHSu0Sevubz3lp3Zk+K7fk0+tHrgiLNeMd+Rc=; b=p7LtZfoJfgtPK51d2Q6H/plWSpTct/OdsYyp7+J8sPhHAvveYuzzuSNCEk8DKgGwWu 3yROIjioc5uJZCmk43wJtDC8fXRDsFjJ4x+HTmiCfZMlfD9hNH/ircyRfNZYPXiiO328 duktg3cgu1IDiFCX8PTQ62YpoJMdiCVufmrVGaAWEuVfA37Ke05Bv6bnq8QTC0MbCwcM yUlYkmPb5Oy6Qh/9IJ3oqn1Byp7nA3fcIVtINWX6c0j74l8f2J+fBQ2NHVDBd8XtkdG/ Cj3d9IRccipj+/D3BLdDiPdruG2FpX1Ui6oVi4adsKYed/ohkn7oB9GH4KX14h3gOXbC aHmQ== X-Gm-Message-State: AOAM530WS5kJAAcHEW+42tI09kpd+fY8CDDTef317crduAKPMq4xUhmO /O72Rgsu4lQEm3c9CkX7yuYCIgQgHiPVDMm1 X-Google-Smtp-Source: ABdhPJwFJFyJiQxPN+ieJwSG+epJ+dfgs4HDsCWwPmw6XySAq1DHWA1Fxp8sJuDlEEZ9YiFCba30Dg== X-Received: by 2002:a5d:414c:: with SMTP id c12mr6099593wrq.251.1611665270492; Tue, 26 Jan 2021 04:47:50 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 13/20] RDMA/hw/hfi1/ruc: Fix a small formatting and description issues Date: Tue, 26 Jan 2021 12:47:25 +0000 Message-Id: <20210126124732.3320971-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/ruc.c:277: warning: Function parameter or member 'bth1' not described in 'hfi1_make_ruc_header_16B' drivers/infiniband/hw/hfi1/ruc.c:365: warning: Function parameter or member 'bth1' not described in 'hfi1_make_ruc_header_9B' drivers/infiniband/hw/hfi1/ruc.c:472: warning: Function parameter or member 'tid' not described in 'hfi1_schedule_send_yield' drivers/infiniband/hw/hfi1/ruc.c:472: warning: Excess function parameter 'timeout' description in 'hfi1_schedule_send_yield' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/ruc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/ruc.c b/drivers/infiniband/hw/hfi1/ruc.c index 23ac6057b2112..c3fa1814c6a86 100644 --- a/drivers/infiniband/hw/hfi1/ruc.c +++ b/drivers/infiniband/hw/hfi1/ruc.c @@ -260,6 +260,7 @@ static inline void hfi1_make_ruc_bth(struct rvt_qp *qp, * @qp: the queue pair * @ohdr: a pointer to the destination header memory * @bth0: bth0 passed in from the RC/UC builder + * @bth1: bth1 passed in from the RC/UC builder * @bth2: bth2 passed in from the RC/UC builder * @middle: non zero implies indicates ahg "could" be used * @ps: the current packet state @@ -348,6 +349,7 @@ static inline void hfi1_make_ruc_header_16B(struct rvt_qp *qp, * @qp: the queue pair * @ohdr: a pointer to the destination header memory * @bth0: bth0 passed in from the RC/UC builder + * @bth1: bth1 passed in from the RC/UC builder * @bth2: bth2 passed in from the RC/UC builder * @middle: non zero implies indicates ahg "could" be used * @ps: the current packet state @@ -455,11 +457,10 @@ void hfi1_make_ruc_header(struct rvt_qp *qp, struct ib_other_headers *ohdr, /** * hfi1_schedule_send_yield - test for a yield required for QP * send engine - * @timeout: Final time for timeout slice for jiffies * @qp: a pointer to QP * @ps: a pointer to a structure with commonly lookup values for * the the send engine progress - * @tid - true if it is the tid leg + * @tid: true if it is the tid leg * * This routine checks if the time slice for the QP has expired * for RC QPs, if so an additional work entry is queued. At this From patchwork Tue Jan 26 12:47:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046449 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D37C433E0 for ; Tue, 26 Jan 2021 12:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FA572224C for ; Tue, 26 Jan 2021 12:56:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404067AbhAZMzp (ORCPT ); Tue, 26 Jan 2021 07:55:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404098AbhAZMuD (ORCPT ); Tue, 26 Jan 2021 07:50:03 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E22D8C08EB28 for ; Tue, 26 Jan 2021 04:47:52 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id m13so1882638wro.12 for ; Tue, 26 Jan 2021 04:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KhBTgPPE+CNVhO1Y8qQbvF45hvKHKoqMW4XtGytDEOs=; b=cfwbVsKfOtrkKii2UrrmoX+t6KB5CDu+uAzLKYjRtQcEBbqL435TuCTuR0tDsfQf9q OFNFb0dcFT3Nj31cZ8dYKPkBktH/cvmzq6XTK3BiGAd8uBbbSEh3rDiPsC9RKyv3l7SQ 4BnPjpapNAstilkpKahZfuvrj+bZMUjaPcRCkUNreZ5oTxQ0UzzMWjznb74RPohoGxt6 UdQNhKDgFdIawrA1MX1txF++KP6FucsTnQWvnOlFlBHGngQh8+HkSz9iLGSdMWNmGnqN q2aJkdp12tgk1lcR3iiLAouxmIsPkyGtXMMFJHQyxwih8pL1cZ4WP2tZ1lshlUmsrYlK KjLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KhBTgPPE+CNVhO1Y8qQbvF45hvKHKoqMW4XtGytDEOs=; b=dGUh3e6c+DzeeV/6oTt2zM2Za+bGmEMSHPyXbSYwTIcAF4J9FKXdzAT35200eo9tCN xbuUs389evQCActC+o6hpSq/2guDTetPY2+dUpBiQtHWe8oudjFdDhFywFUDFcm9qreb k5+uNWnqos8wtppvtmqmkkcSJSHS6ru52LdLdJCb2EFTrtXSOe8AjRUCVpdiRrDK3MIr KnjadsvKl82c479Y3BUaa7SDVEt4EDlZ0aH+daY4W3Y9uPXEu5vWuszR8PgQ0lVHsFNl 5NvIdwInFfbeW8+va5tO3btCrUBmLxAYp+M5V1IOvxO3BcK29cV4fZkgnyikdgXMGsUE TVuQ== X-Gm-Message-State: AOAM533XwbLSIZL3n3wKHStrpT0cnEKbaSOzaoF/3BS7esfgOLOyExuw Wt5oyRsG9xcseB3O8ZY/gs0r4Q== X-Google-Smtp-Source: ABdhPJwxtpN3OCMIXfq63j1dD0WyBcmrYv3dGBVioIP73N0G/bUoqDHuRDPVnuAEsTGDpRWGjGQASQ== X-Received: by 2002:a5d:4243:: with SMTP id s3mr5900388wrr.31.1611665271660; Tue, 26 Jan 2021 04:47:51 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 14/20] RDMA/hw/hfi1/sdma: Fix misnaming of 'sdma_send_txlist()'s 'count_out' param Date: Tue, 26 Jan 2021 12:47:26 +0000 Message-Id: <20210126124732.3320971-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/sdma.c:2476: warning: Function parameter or member 'count_out' not described in 'sdma_send_txlist' drivers/infiniband/hw/hfi1/sdma.c:2476: warning: Excess function parameter 'count' description in 'sdma_send_txlist' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/sdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/sdma.c b/drivers/infiniband/hw/hfi1/sdma.c index 27ec2851160ae..46b5290b2839d 100644 --- a/drivers/infiniband/hw/hfi1/sdma.c +++ b/drivers/infiniband/hw/hfi1/sdma.c @@ -2448,11 +2448,11 @@ int sdma_send_txreq(struct sdma_engine *sde, * @sde: sdma engine to use * @wait: SE wait structure to use when full (may be NULL) * @tx_list: list of sdma_txreqs to submit - * @count: pointer to a u16 which, after return will contain the total number of - * sdma_txreqs removed from the tx_list. This will include sdma_txreqs - * whose SDMA descriptors are submitted to the ring and the sdma_txreqs - * which are added to SDMA engine flush list if the SDMA engine state is - * not running. + * @count_out: pointer to a u16 which, after return will contain the total number of + * sdma_txreqs removed from the tx_list. This will include sdma_txreqs + * whose SDMA descriptors are submitted to the ring and the sdma_txreqs + * which are added to SDMA engine flush list if the SDMA engine state is + * not running. * * The call submits the list into the ring. * From patchwork Tue Jan 26 12:47:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046435 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FE6C433E6 for ; Tue, 26 Jan 2021 12:54:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 915E52224C for ; Tue, 26 Jan 2021 12:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391796AbhAZMuQ (ORCPT ); Tue, 26 Jan 2021 07:50:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404097AbhAZMuD (ORCPT ); Tue, 26 Jan 2021 07:50:03 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258EFC08EB2B for ; Tue, 26 Jan 2021 04:47:54 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id d16so15649208wro.11 for ; Tue, 26 Jan 2021 04:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9/3ugDjDRvHTQ/02f6IlRMQWKsjtDgmsBi/8dZ2CLI4=; b=EQegMAgrLM+Vr8PO8VzM7X3XUCOndiJh4RMraOt81gPr7MwY3n9rPF7FSh4Du93Lz3 Rx4WQ+umSynWAJhTevwqFS3Mv+Sca2TGkcTknt3N0smXTkDzDYeIY044JrTgHbrrmIAg +V41G2CEe0nxpS4NcOezKqgHhsvb80vmTRe28HIzCgNcHfvMn22F/YOzU8NvA1+ov7Y/ lwuLuOr/kgvzbd0CuI1zZSx55iomagSI7Ro6XoA8nLuSC8LOc0sugmRvrDLS/7kwbE2e evgXPM2lyg67gnAHc1msOez/krfP2VJ90ATYy/e4RWt1tz7FoEGlu5R9yUxcg6xjKrVY DP2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9/3ugDjDRvHTQ/02f6IlRMQWKsjtDgmsBi/8dZ2CLI4=; b=tmXzXZRBJFWaf3mATVOGcjGUvjuVNJgkdkIKu9egJoWJ7+CcQDrA1VnNhAa3UXCkPn MmYZO2x14eErS29/zbxE81qKlZiLPLfCjDoBaDh1upDTiFeOHs14Fm8HZX0puePeIJiz n8hxkk/tkLxkpGDX+JwbhXP6BEIm42jLnma6/uidl5ubsnyTK/1dKQC8mpw7PDQXNRx2 9MgClQOdgaTH0qBOqDSpJxd/HQ6hvDZDN1cdNyb5hNEB+1SnGt6zXDWTktG2G3St55Px uasOn2H3oVH4J3wWl8/4JnjLpyghLTr4Sh7+s0cSbU2wK8/uVaMbA07TrDc1RGUtvX5f DtRQ== X-Gm-Message-State: AOAM531wkkezI2J5KOUhz0TksmWozGRu2+IcAQsKbeRUGkMYlFlNeQg7 YbLG/pXIHRSIP8Jjk44Cs9Ip+A== X-Google-Smtp-Source: ABdhPJyri6xa2WTEf8CycWDv4AHunjQCgUCllTOhxa8Z9mAIhGPlgIVDAh2Lzz/ZrrtFPDpswpzomA== X-Received: by 2002:a5d:4d86:: with SMTP id b6mr5909547wru.152.1611665272896; Tue, 26 Jan 2021 04:47:52 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 15/20] RDMA/hw/hfi1/tid_rdma: Fix a plethora of kernel-doc issues Date: Tue, 26 Jan 2021 12:47:27 +0000 Message-Id: <20210126124732.3320971-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/tid_rdma.c:321: warning: Function parameter or member 'rdi' not described in 'qp_to_rcd' drivers/infiniband/hw/hfi1/tid_rdma.c:321: warning: Function parameter or member 'qp' not described in 'qp_to_rcd' drivers/infiniband/hw/hfi1/tid_rdma.c:505: warning: Function parameter or member 'queue' not described in 'kernel_tid_waiters' drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'rcd' not described in 'dequeue_tid_waiter' drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'queue' not described in 'dequeue_tid_waiter' drivers/infiniband/hw/hfi1/tid_rdma.c:536: warning: Function parameter or member 'qp' not described in 'dequeue_tid_waiter' drivers/infiniband/hw/hfi1/tid_rdma.c:562: warning: Function parameter or member 'queue' not described in 'queue_qp_for_tid_wait' drivers/infiniband/hw/hfi1/tid_rdma.c:607: warning: Function parameter or member 'qp' not described in 'tid_rdma_schedule_tid_wakeup' drivers/infiniband/hw/hfi1/tid_rdma.c:639: warning: Function parameter or member 'work' not described in 'tid_rdma_trigger_resume' drivers/infiniband/hw/hfi1/tid_rdma.c:666: warning: Function parameter or member 'qp' not described in '_tid_rdma_flush_wait' drivers/infiniband/hw/hfi1/tid_rdma.c:666: warning: Function parameter or member 'queue' not described in '_tid_rdma_flush_wait' drivers/infiniband/hw/hfi1/tid_rdma.c:713: warning: Function parameter or member 'rcd' not described in 'kern_reserve_flow' drivers/infiniband/hw/hfi1/tid_rdma.c:713: warning: Function parameter or member 'last' not described in 'kern_reserve_flow' drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'flow' not described in 'tid_rdma_find_phys_blocks_4k' drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'pages' not described in 'tid_rdma_find_phys_blocks_4k' drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'npages' not described in 'tid_rdma_find_phys_blocks_4k' drivers/infiniband/hw/hfi1/tid_rdma.c:879: warning: Function parameter or member 'list' not described in 'tid_rdma_find_phys_blocks_4k' drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'list' not described in 'tid_flush_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'idx' not described in 'tid_flush_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'pages' not described in 'tid_flush_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:972: warning: Function parameter or member 'sets' not described in 'tid_flush_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'flow' not described in 'tid_rdma_find_phys_blocks_8k' drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'pages' not described in 'tid_rdma_find_phys_blocks_8k' drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'npages' not described in 'tid_rdma_find_phys_blocks_8k' drivers/infiniband/hw/hfi1/tid_rdma.c:1017: warning: Function parameter or member 'list' not described in 'tid_rdma_find_phys_blocks_8k' drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'flow' not described in 'kern_find_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'pages' not described in 'kern_find_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'ss' not described in 'kern_find_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:1083: warning: Function parameter or member 'last' not described in 'kern_find_pages' drivers/infiniband/hw/hfi1/tid_rdma.c:1604: warning: Function parameter or member 'req' not described in 'hfi1_kern_exp_rcv_free_flows' drivers/infiniband/hw/hfi1/tid_rdma.c:3458: warning: Function parameter or member 'qp' not described in 'hfi1_tid_write_alloc_resources' drivers/infiniband/hw/hfi1/tid_rdma.c:3458: warning: Function parameter or member 'intr_ctx' not described in 'hfi1_tid_write_alloc_resources' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/tid_rdma.c | 47 +++++++++++++++------------ 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c index 92aa2a9b3b5ac..0b1f9e4d038b0 100644 --- a/drivers/infiniband/hw/hfi1/tid_rdma.c +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c @@ -309,7 +309,8 @@ int hfi1_kern_exp_rcv_init(struct hfi1_ctxtdata *rcd, int reinit) /** * qp_to_rcd - determine the receive context used by a qp - * @qp - the qp + * @rdi: rvt dev struct + * @qp: the qp * * This routine returns the receive context associated * with a a qp's qpn. @@ -484,6 +485,7 @@ static struct rvt_qp *first_qp(struct hfi1_ctxtdata *rcd, /** * kernel_tid_waiters - determine rcd wait * @rcd: the receive context + * @queue: the queue to operate on * @qp: the head of the qp being processed * * This routine will return false IFF @@ -517,7 +519,9 @@ static bool kernel_tid_waiters(struct hfi1_ctxtdata *rcd, /** * dequeue_tid_waiter - dequeue the qp from the list - * @qp - the qp to remove the wait list + * @rcd: the receive context + * @queue: the queue to operate on + * @qp: the qp to remove the wait list * * This routine removes the indicated qp from the * wait list if it is there. @@ -549,6 +553,7 @@ static void dequeue_tid_waiter(struct hfi1_ctxtdata *rcd, /** * queue_qp_for_tid_wait - suspend QP on tid space * @rcd: the receive context + * @queue: the queue to operate on * @qp: the qp * * The qp is inserted at the tail of the rcd @@ -593,7 +598,7 @@ static void __trigger_tid_waiter(struct rvt_qp *qp) /** * tid_rdma_schedule_tid_wakeup - schedule wakeup for a qp - * @qp - the qp + * @qp: the qp * * trigger a schedule or a waiting qp in a deadlock * safe manner. The qp reference is held prior @@ -630,7 +635,7 @@ static void tid_rdma_schedule_tid_wakeup(struct rvt_qp *qp) /** * tid_rdma_trigger_resume - field a trigger work request - * @work - the work item + * @work: the work item * * Complete the off qp trigger processing by directly * calling the progress routine. @@ -654,7 +659,7 @@ static void tid_rdma_trigger_resume(struct work_struct *work) rvt_put_qp(qp); } -/** +/* * tid_rdma_flush_wait - unwind any tid space wait * * This is called when resetting a qp to @@ -693,8 +698,8 @@ void hfi1_tid_rdma_flush_wait(struct rvt_qp *qp) /* Flow functions */ /** * kern_reserve_flow - allocate a hardware flow - * @rcd - the context to use for allocation - * @last - the index of the preferred flow. Use RXE_NUM_TID_FLOWS to + * @rcd: the context to use for allocation + * @last: the index of the preferred flow. Use RXE_NUM_TID_FLOWS to * signify "don't care". * * Use a bit mask based allocation to reserve a hardware @@ -860,9 +865,10 @@ static u8 trdma_pset_order(struct tid_rdma_pageset *s) /** * tid_rdma_find_phys_blocks_4k - get groups base on mr info - * @npages - number of pages - * @pages - pointer to an array of page structs - * @list - page set array to return + * @flow: overall info for a TID RDMA segment + * @pages: pointer to an array of page structs + * @npages: number of pages + * @list: page set array to return * * This routine returns the number of groups associated with * the current sge information. This implementation is based @@ -949,10 +955,10 @@ static u32 tid_rdma_find_phys_blocks_4k(struct tid_rdma_flow *flow, /** * tid_flush_pages - dump out pages into pagesets - * @list - list of pagesets - * @idx - pointer to current page index - * @pages - number of pages to dump - * @sets - current number of pagesset + * @list: list of pagesets + * @idx: pointer to current page index + * @pages: number of pages to dump + * @sets: current number of pagesset * * This routine flushes out accumuated pages. * @@ -990,9 +996,10 @@ static u32 tid_flush_pages(struct tid_rdma_pageset *list, /** * tid_rdma_find_phys_blocks_8k - get groups base on mr info - * @pages - pointer to an array of page structs - * @npages - number of pages - * @list - page set array to return + * @flow: overall info for a TID RDMA segment + * @pages: pointer to an array of page structs + * @npages: number of pages + * @list: page set array to return * * This routine parses an array of pages to compute pagesets * in an 8k compatible way. @@ -1064,7 +1071,7 @@ static u32 tid_rdma_find_phys_blocks_8k(struct tid_rdma_flow *flow, return sets; } -/** +/* * Find pages for one segment of a sge array represented by @ss. The function * does not check the sge, the sge must have been checked for alignment with a * prior call to hfi1_kern_trdma_ok. Other sge checking is done as part of @@ -1598,7 +1605,7 @@ void hfi1_kern_exp_rcv_clear_all(struct tid_rdma_request *req) /** * hfi1_kern_exp_rcv_free_flows - free priviously allocated flow information - * @req - the tid rdma request to be cleaned + * @req: the tid rdma request to be cleaned */ static void hfi1_kern_exp_rcv_free_flows(struct tid_rdma_request *req) { @@ -3435,7 +3442,7 @@ static u32 hfi1_compute_tid_rnr_timeout(struct rvt_qp *qp, u32 to_seg) return 0; } -/** +/* * Central place for resource allocation at TID write responder, * is called from write_req and write_data interrupt handlers as * well as the send thread when a queued QP is scheduled for From patchwork Tue Jan 26 12:47:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046451 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECD5C433E0 for ; Tue, 26 Jan 2021 12:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7ACFC2224C for ; Tue, 26 Jan 2021 12:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404083AbhAZMzt (ORCPT ); Tue, 26 Jan 2021 07:55:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403819AbhAZMuG (ORCPT ); Tue, 26 Jan 2021 07:50:06 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F18C08EB2C for ; Tue, 26 Jan 2021 04:47:55 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id u14so2632514wmq.4 for ; Tue, 26 Jan 2021 04:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Be3Y0oHERhBykNWLBE00Jhbr48e+dcSVLp5rjpoZalM=; b=nkKmRuPQ9fIGmXOz5PMoJpeLhxuHTI96jpBNkOuLMEn4TTFO222OBWpIESVSPRHtFl PTEqnyYjB0yBuuI9+/GsQVw7zWh11U9IUlgc9tvvguKLEbiQpJ62s/Q5NWTBILJIYY6T LJBVKCBdC6l2h/epGGvz1OEuLNJgP7RcUjlgowV+4iiseyPL0vkZHwXt6ug/0tr/TZBZ OOzacdCTeTi1cCOHKu15kjxFJ+H/MZbXVxNH2D5JsbcTDRrL2iOAtScetqOgGKh4uRgG fleiAAnIrMMq2zf7bS/8sThB6hIqGq7OpT9KfldthUBdOkE8rCZUkKGbJdCjFkTpas4N Hycg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Be3Y0oHERhBykNWLBE00Jhbr48e+dcSVLp5rjpoZalM=; b=IRoJqxKGun+hb7DqhXFKQukyWp8TDxI3Yflj938lyilrI62QZen+dZ8n5XGjXAyR8r GUQjoOBkYvakhEK/xEzFUixOIxe8w/zuWk9EA+gS5zUbdY8x3n0vl7NpHG+5d/y5SEsY nCA4DP4DCprl4UDIF+fkkUoY06OIF6Rij71OnlylnTdkAN6ZD/VKHVXm6V919oMh96T5 id6NMHivX41HdS3nWh4lM9vAQ8RVLeIvmJmY0OMGIZOIpyQIm2QIePSL8kz3kyZNz7Hg tEb101qCuSg/DQ/2lzQkwom3x/PC00AZ9OFQih1x9YyAePBgqYXzo+4GXoBZDF2WAbTe Hghg== X-Gm-Message-State: AOAM532tDdwGPX0ED/bIIa1BzHlPMnnsT+/xJAoSZxU0o/GOeBhjPGJe BSJmn/3yn4tBXiKG3GdMCPgo/A== X-Google-Smtp-Source: ABdhPJy2R6IQ3V4KzwwBbMw7q+XXRTmfbultk90lXNGqksnMEK+Qzto0w37XWK1lRD227zQYOQFc8g== X-Received: by 2002:a1c:770d:: with SMTP id t13mr4518211wmi.35.1611665274061; Tue, 26 Jan 2021 04:47:54 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 16/20] RDMA/hw/hfi1/uc: Fix a little doc-rot Date: Tue, 26 Jan 2021 12:47:28 +0000 Message-Id: <20210126124732.3320971-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/uc.c:64: warning: Function parameter or member 'ps' not described in 'hfi1_make_uc_req' drivers/infiniband/hw/hfi1/uc.c:306: warning: Function parameter or member 'packet' not described in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'ibp' description in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'hdr' description in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'rcv_flags' description in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'data' description in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'tlen' description in 'hfi1_uc_rcv' drivers/infiniband/hw/hfi1/uc.c:306: warning: Excess function parameter 'qp' description in 'hfi1_uc_rcv' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/uc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/uc.c b/drivers/infiniband/hw/hfi1/uc.c index 1fb918399da06..5b0f536b34e0c 100644 --- a/drivers/infiniband/hw/hfi1/uc.c +++ b/drivers/infiniband/hw/hfi1/uc.c @@ -55,6 +55,7 @@ /** * hfi1_make_uc_req - construct a request packet (SEND, RDMA write) * @qp: a pointer to the QP + * @ps: the current packet state * * Assume s_lock is held. * @@ -291,12 +292,7 @@ int hfi1_make_uc_req(struct rvt_qp *qp, struct hfi1_pkt_state *ps) /** * hfi1_uc_rcv - handle an incoming UC packet - * @ibp: the port the packet came in on - * @hdr: the header of the packet - * @rcv_flags: flags relevant to rcv processing - * @data: the packet data - * @tlen: the length of the packet - * @qp: the QP for this packet. + * @packet: the packet structure * * This is called from qp_rcv() to process an incoming UC packet * for the given QP. From patchwork Tue Jan 26 12:47:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046457 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22953C433E0 for ; Tue, 26 Jan 2021 12:56:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF3223109 for ; Tue, 26 Jan 2021 12:56:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403819AbhAZM4A (ORCPT ); Tue, 26 Jan 2021 07:56:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404103AbhAZMuG (ORCPT ); Tue, 26 Jan 2021 07:50:06 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E2D5C08EB2F for ; Tue, 26 Jan 2021 04:47:56 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id 6so16315420wri.3 for ; Tue, 26 Jan 2021 04:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qncZWHsLqXASAb7WKMbAV3gMhi+sjt/v/oNjYxknz8Y=; b=NcIYoCqk3hUpJsDz9SfdkAFaGLumlfnhs1YR/p42LL4vdvcjB2Eylpt+wA4f29kfkP CnK8TqZJRq5EhPZC3C08uNaS6L1lQUUyQMNtJY7ZZRD272gVCXsN2syn8JMbHMaBDnKE +Zo0/q3WAI9LRKYTb009yKJp9wC/l9NiVdRHZxxuTcE+65GJe7cJ34P92CpIsfsqvDUs 5yfGbi+jUUpxu2rjM6Mj8QzLrBJG3HGsOPOaqhq5LnjHt07Pz27iTBXBwgFYogkJlPCW /h2fFdUF76tANhPTf+RBKYSyJmvt1ha93oyPlHNs8BQK34/6Uz1ZjJmgjDyEiQpm3uz5 kmEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qncZWHsLqXASAb7WKMbAV3gMhi+sjt/v/oNjYxknz8Y=; b=rGnRq/NDtvY3A9IckeErp5LvkG4ybD29hFAU40LVHyJm47UncFs+tru2llg7ih8qkA aiVdsP9D2ctk4AF31eSeUITR8Q1lz8eV5uauEYIGPD0vdZ61Wif52lpZDTFx2mbh01j5 aP5W5Zz/wqIFzbGobmVBI0Myl3VqD00nkMBpGYhZJTb+fZglQrVOWSiHrS5r9V6d4XBs wiY6kw033MWqDt+wUEZuZUhRJiSHALg4ZIo3kXumVT2th9L+HIyw2vJoFYkCrNZSxWfP VvkW2u5D1jXILZNNW8xIIMRCKzpuQ5jXpCeBUwalO/XXHyazABKxPq0QQfzSdiqD99w9 x19A== X-Gm-Message-State: AOAM532pvood0dgnuyK2fXf/IzZCFPVPSZ9tkxjxzRoTWr+0a4sr8Bk+ ezYSWuj4qg90bMJk0Owr8GonLA== X-Google-Smtp-Source: ABdhPJw2xjb1RdcsnXKRATtfdI88n+CathRcAI2SOo030+I1jUS4DZ75Hx3+2ch6KS6QY4E5AZ7xIg== X-Received: by 2002:adf:dd45:: with SMTP id u5mr5869894wrm.392.1611665275238; Tue, 26 Jan 2021 04:47:55 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 17/20] RDMA/hw/hfi1/ud: Fix a little more doc-rot Date: Tue, 26 Jan 2021 12:47:29 +0000 Message-Id: <20210126124732.3320971-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/ud.c:477: warning: Function parameter or member 'ps' not described in 'hfi1_make_ud_req' drivers/infiniband/hw/hfi1/ud.c:855: warning: Function parameter or member 'packet' not described in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'ibp' description in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'hdr' description in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'rcv_flags' description in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'data' description in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'tlen' description in 'hfi1_ud_rcv' drivers/infiniband/hw/hfi1/ud.c:855: warning: Excess function parameter 'qp' description in 'hfi1_ud_rcv' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/ud.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/ud.c b/drivers/infiniband/hw/hfi1/ud.c index e804af71b629d..6ecb984c85fac 100644 --- a/drivers/infiniband/hw/hfi1/ud.c +++ b/drivers/infiniband/hw/hfi1/ud.c @@ -468,6 +468,7 @@ void hfi1_make_ud_req_16B(struct rvt_qp *qp, struct hfi1_pkt_state *ps, /** * hfi1_make_ud_req - construct a UD request packet * @qp: the QP + * @ps: the current packet state * * Assume s_lock is held. * @@ -840,12 +841,7 @@ static int opa_smp_check(struct hfi1_ibport *ibp, u16 pkey, u8 sc5, /** * hfi1_ud_rcv - receive an incoming UD packet - * @ibp: the port the packet came in on - * @hdr: the packet header - * @rcv_flags: flags relevant to rcv processing - * @data: the packet data - * @tlen: the packet length - * @qp: the QP the packet came on + * @packet: the packet structure * * This is called from qp_rcv() to process an incoming UD packet * for the given QP. From patchwork Tue Jan 26 12:47:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046411 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DCEC433E6 for ; Tue, 26 Jan 2021 12:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1374D2310E for ; Tue, 26 Jan 2021 12:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403987AbhAZMu3 (ORCPT ); Tue, 26 Jan 2021 07:50:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404108AbhAZMuG (ORCPT ); Tue, 26 Jan 2021 07:50:06 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977EFC08EB30 for ; Tue, 26 Jan 2021 04:47:57 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id m13so1882875wro.12 for ; Tue, 26 Jan 2021 04:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WpANnWfGT2qFPSHlNEWTmbJ1paMcoIJGvrRr1eRAMJE=; b=elRCoD0E+0EyiixUe4a1EB+4QZXPB3Rc7DM40jZU9+fIbi8dg5nsnJG0nbovfzqy1M csONUjfx2MdwVvhkhkgRD7KhgaJSn/HM1hM7wrhMx+mq3Q+w/pyOVdfLyKyPJThdIyXx tTx7izzkrcjpvF/ybDkHNhY96HYJXm8R49kYKVYM0R8tZF2dAdNwMWxLm+F9Ng8GFViS deXzu9E57xoZRjxcr8LUXfv11flWbtwBhVgedFQzNQ1IE1WxgWsPynNLQOxy5k6bdgj3 XQ3D+2IcZJ2f9hM3vnr1DK8sIejTFlPSSpfto7GH7yXeMYWz6Mvfwa9/z7dOt7/KoH/E XK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WpANnWfGT2qFPSHlNEWTmbJ1paMcoIJGvrRr1eRAMJE=; b=J5F6BdXNLGylHDdpyD1+qYaKIrl99WTOgreB/cZYDLNdkkH6/BCFDVWbZWVZsIRfwD vOkuIPLI4k5Yli2+IoiTJIgpJvVl4BtHo0LqEliuLwLKjDCPVmez1ILSXxIwWn7zZJUH uJUTuU5rmnVIJ0EwUskYQNikAghy7NHpnDyXQfKBf+VsHrqsBPtzIt9SCPslZywPos6d qVCfsqBlPSOJInTv/4WVDahpzlvGmRmHJyI5NowLur1xuzeXAJIZsAVCCaCEN8Co6urB gZRhcrAfsssNveYiQmnPDOvJfMBW19WTlV+oPPiFhqn3Tztv4Leus46FTMUjsw7nUnRX sa1w== X-Gm-Message-State: AOAM532+XqY26n4QOm3twkZvnKxhQJUleAMqVk3GckyI4nxVSzwl0cB6 VcK8PUnTdDlCAn6JQMCvN0h17w== X-Google-Smtp-Source: ABdhPJxRSdr8DaSZ3Ha889ki6igIj2ynJ5QQ+X5CFywOPJ1iNvepjcEBe8xUh3/g3cl2uRdPipvcVA== X-Received: by 2002:adf:eb4e:: with SMTP id u14mr5939543wrn.99.1611665276345; Tue, 26 Jan 2021 04:47:56 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 18/20] RDMA/hw/hfi1/user_exp_rcv: Demote half-documented and kernel-doc abuses Date: Tue, 26 Jan 2021 12:47:30 +0000 Message-Id: <20210126124732.3320971-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'fd' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'tidbuf' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'node' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'idx' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'npages' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:174: warning: Function parameter or member 'mapped' not described in 'unpin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:196: warning: Function parameter or member 'fd' not described in 'pin_rcv_pages' drivers/infiniband/hw/hfi1/user_exp_rcv.c:196: warning: Function parameter or member 'tidbuf' not described in 'pin_rcv_pages' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index b94fc7fd75a96..58dcab2679d9d 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -154,12 +154,12 @@ void hfi1_user_exp_rcv_free(struct hfi1_filedata *fd) fd->entry_to_rb = NULL; } -/** +/* * Release pinned receive buffer pages. * - * @mapped - true if the pages have been DMA mapped. false otherwise. - * @idx - Index of the first page to unpin. - * @npages - No of pages to unpin. + * @mapped: true if the pages have been DMA mapped. false otherwise. + * @idx: Index of the first page to unpin. + * @npages: No of pages to unpin. * * If the pages have been DMA mapped (indicated by mapped parameter), their * info will be passed via a struct tid_rb_node. If they haven't been mapped, @@ -189,7 +189,7 @@ static void unpin_rcv_pages(struct hfi1_filedata *fd, fd->tid_n_pinned -= npages; } -/** +/* * Pin receive buffer pages. */ static int pin_rcv_pages(struct hfi1_filedata *fd, struct tid_user_buf *tidbuf) From patchwork Tue Jan 26 12:47:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046453 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD58C433DB for ; Tue, 26 Jan 2021 12:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D52A2224C for ; Tue, 26 Jan 2021 12:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403924AbhAZM4B (ORCPT ); Tue, 26 Jan 2021 07:56:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404105AbhAZMuG (ORCPT ); Tue, 26 Jan 2021 07:50:06 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1151C08EC28 for ; Tue, 26 Jan 2021 04:47:58 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id m13so1882934wro.12 for ; Tue, 26 Jan 2021 04:47:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hpZFRWRMBRyHqA4LFeJIkJ1VyU/15BjqrvkCVLk60G8=; b=DflQqkzq+/EGK2NRxBd+UtoUZey4O18FCOsB6PA4MWcs0g95luUnYoA6knuBlQ5/qp CgvuKM45GRD/OIqwCBbca5ujHMHfRJbTDzmUpXVbXYh4zY0KpMEuAbIzZ1XmYhvTwPap vYjczVegm3Q+G8SIyoUU8+YYzXF7fGtH8lbRsu4Uchkb/WGsFPE5/KJbYRFmt2Yk08hr 1GWbwyXOKtbBXbLPHYjlgM8LLjC3UAglmVnuur88kLNR/8kmS4wpSMUeoGsohdeHLrDH u4smr8dfKBuJigXsgKOGFABXrP/IH2m2crw6/yl26Qq+8JiE703LwKdkT4jAav7es7mJ dh+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hpZFRWRMBRyHqA4LFeJIkJ1VyU/15BjqrvkCVLk60G8=; b=Fd/h5fH2NiFMPFHL05XAR9PCJp/1cpK4W4iJbtctzwu23nKmrzgvcLJnlQKAcf3CXq gDG5dEZn3VoWMvvc60IfkRLKICbgP3TNpWhV0gLHoSodpJjUo/v9TIbJ1s4SddwlZWWx AJMyVGcBHobOE0uH/iQCepX6PBReB4M5FlT3+9/yXvVxihe7mhy959pmVspLa/lLSjIk BnqF2W7eDMlWXCCPwlRfod1uvYGIKpD3HLuKncATLkN58UpJgk+yzgMlA88uvsTSTXmi woWHfdSnkSUNWnQv/8bH6x+JXIFhZTqLTFz+TgWbGY+FqaMXx61oeYSOSxrLItuJLdkD 6n7w== X-Gm-Message-State: AOAM530q2a2rlrkAODXn//A73mJsc6zg3CyfDV9D+Tz18njNaCP3mDNX sGd5hhwHovqIoBOIghgFrxuXRw== X-Google-Smtp-Source: ABdhPJyVPFTqKtMzBmyMdMFKJ4bT4S7ncfaXrWgISj8V3pzak4nLhMepCV/vRlbcIr5IAY+QkkG3/w== X-Received: by 2002:adf:e610:: with SMTP id p16mr5842178wrm.169.1611665277555; Tue, 26 Jan 2021 04:47:57 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 19/20] RDMA/hw/hfi1/verbs: Demote non-conforming doc header and fix a misspelling Date: Tue, 26 Jan 2021 12:47:31 +0000 Message-Id: <20210126124732.3320971-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/verbs.c:741: warning: Function parameter or member 'qp' not described in 'update_tx_opstats' drivers/infiniband/hw/hfi1/verbs.c:1160: warning: Function parameter or member 'pkey' not described in 'egress_pkey_check' drivers/infiniband/hw/hfi1/verbs.c:1160: warning: Excess function parameter 'bkey' description in 'egress_pkey_check' drivers/infiniband/hw/hfi1/verbs.c:1217: warning: Function parameter or member 'qp' not described in 'get_send_routine' drivers/infiniband/hw/hfi1/verbs.c:1217: warning: Function parameter or member 'ps' not described in 'get_send_routine' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/verbs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c index 3591923abebb9..0dd4bb0a5a7e6 100644 --- a/drivers/infiniband/hw/hfi1/verbs.c +++ b/drivers/infiniband/hw/hfi1/verbs.c @@ -729,7 +729,7 @@ static noinline int build_verbs_ulp_payload( /** * update_tx_opstats - record stats by opcode - * @qp; the qp + * @qp: the qp * @ps: transmit packet state * @plen: the plen in dwords * @@ -1145,7 +1145,7 @@ static inline int egress_pkey_matches_entry(u16 pkey, u16 ent) * egress_pkey_check - check P_KEY of a packet * @ppd: Physical IB port data * @slid: SLID for packet - * @bkey: PKEY for header + * @pkey: PKEY for header * @sc5: SC for packet * @s_pkey_index: It will be used for look up optimization for kernel contexts * only. If it is negative value, then it means user contexts is calling this @@ -1206,7 +1206,7 @@ int egress_pkey_check(struct hfi1_pportdata *ppd, u32 slid, u16 pkey, return 1; } -/** +/* * get_send_routine - choose an egress routine * * Choose an egress routine based on QP type From patchwork Tue Jan 26 12:47:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12046455 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4231C433E0 for ; Tue, 26 Jan 2021 12:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C44D92224C for ; Tue, 26 Jan 2021 12:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403958AbhAZM4D (ORCPT ); Tue, 26 Jan 2021 07:56:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404114AbhAZMuI (ORCPT ); Tue, 26 Jan 2021 07:50:08 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7225C08EC2A for ; Tue, 26 Jan 2021 04:47:59 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id 7so16324509wrz.0 for ; Tue, 26 Jan 2021 04:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9JTe+jRXALQKf3yY8IU1E8sEuYfjFJES4qTh1TiteyM=; b=Meed0fqrtuRP5qb5w4GuMUsUbI4hj7GoqnFzKuoS/e3WeCj7/a6Vycj84cMinxtPCw mq5Y6noIM+LlWPZIfLKcIWyC/6ebjVbujaY0qIODGLptYZtWVdabraN2Sb7nhLtyYjpf J3LUIM3YmQZiyxmeORHTTFS8EppCtc4iMOrS3KbnvTyf/mlz/GQR9/r68lVL8ifUnTmc FhXWaWMCHTBlL94wQJTfshMfsUensOj+fwqvd4y4xWndBKylhMVyRpTPFCXNHG2zBjUZ mX+iDtpIaSMOSav7tet0FCTqiwHdloM/KiX9XVvdew1WtpXZik0LiiYCqTZtix7MxzVO tgxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9JTe+jRXALQKf3yY8IU1E8sEuYfjFJES4qTh1TiteyM=; b=pg5nttBYg2xNwg2rFo5ZmjiHH2upUgdbx41I9Oini5uARJOgiN83COFRworVpN6n86 DZ2SKQDE1llpOua8x8eHUqyoFHB0GguiPxT+FT8gmys1TQnRl1l31WtScc/hiJCzaAoI eHkSvGjdludRngtFqhnlLu1JfoTaKrVuWLPsIbPPeTZpW2xZOk+VH2rSWa9krPnu7IGX FosxA3Sktas2Ju3z+hu90zvQ+hlFqgeSsO/bcBP1KqIYMvGac1+EuR2kc3wweWahkarJ fU/G7xNVBrW37tJt1s1B4t1btUIFODsKMCxsFam6+cXsJAXEFhk72KPWmKw78icNalDX U1fQ== X-Gm-Message-State: AOAM5316DBigY0x+k/tcHrajJyMUIQJvmNTgexHSRPc5naFmIup8YouR GNW8A6sr4WEr66ALgCSq+RDzMg== X-Google-Smtp-Source: ABdhPJy1jf9vr6ciXCO7+QCbDSXqsRfYt98g7N9DvzH95d3RzqN0DIBwvucSHQbJf5P4sRL0S7d3Jw== X-Received: by 2002:adf:dc89:: with SMTP id r9mr5907515wrj.52.1611665278654; Tue, 26 Jan 2021 04:47:58 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id p15sm26942190wrt.15.2021.01.26.04.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 04:47:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 20/20] RDMA/hw/hfi1/rc: Demote incorrectly populated kernel-doc header Date: Tue, 26 Jan 2021 12:47:32 +0000 Message-Id: <20210126124732.3320971-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org> References: <20210126124732.3320971-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/hw/hfi1/rc.c:1388: warning: Function parameter or member 'packet' not described in 'hfi1_send_rc_ack' drivers/infiniband/hw/hfi1/rc.c:1388: warning: Function parameter or member 'is_fecn' not described in 'hfi1_send_rc_ack' drivers/infiniband/hw/hfi1/rc.c:1388: warning: Excess function parameter 'qp' description in 'hfi1_send_rc_ack' Cc: Mike Marciniszyn Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/hw/hfi1/rc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/rc.c b/drivers/infiniband/hw/hfi1/rc.c index 7194236aec8fe..0174b8ee9f00f 100644 --- a/drivers/infiniband/hw/hfi1/rc.c +++ b/drivers/infiniband/hw/hfi1/rc.c @@ -1376,9 +1376,8 @@ static const hfi1_make_rc_ack hfi1_make_rc_ack_tbl[2] = { [HFI1_PKT_TYPE_16B] = &hfi1_make_rc_ack_16B }; -/** +/* * hfi1_send_rc_ack - Construct an ACK packet and send it - * @qp: a pointer to the QP * * This is called from hfi1_rc_rcv() and handle_receive_interrupt(). * Note that RDMA reads and atomics are handled in the