From patchwork Wed Jan 27 08:58:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Biwen Li (OSS)" X-Patchwork-Id: 12049357 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C72C433DB for ; Wed, 27 Jan 2021 08:51:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28ED220754 for ; Wed, 27 Jan 2021 08:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28ED220754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=99qmfpYFnoEUAHXYPdLqkfMv/gqpl1Im2ou5kwoDrcs=; b=xknFDhv/ENnycaiPZDhew0K0/t iYFSzlAAygzISoPtLRYR3C3ukaP+lifDCJyMlxTA7oBJ50kdIZEsdCzG94n/wmYqLHxbpcHEJFosR a9x+J+qD2ar24RxEcE6SWPQSQjSVk/SBKW1LDibP1zZpRS3+M9cdbNBC1ykXo4ITyQakBKCbbDBQh gxvEZcs9OFbHoxuNQzFXyTCrsj5q8n8yoldado0oDhHnNi+oz3sWLGyH8+YuktKBSHHt80A7hAcGU cZAE57JhujMtvCuvuJscigHB4nvUXFPYVzJMfb1y+lMiQLRo4STxulcmqg7moid0v7mI4mFi8uItq jwgYo+1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4gWO-0007Tt-V2; Wed, 27 Jan 2021 08:49:53 +0000 Received: from inva020.nxp.com ([92.121.34.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4gWM-0007Sz-9A for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 08:49:50 +0000 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 21ADA1A0546; Wed, 27 Jan 2021 09:49:49 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 11F781A053C; Wed, 27 Jan 2021 09:49:45 +0100 (CET) Received: from localhost.localdomain (mega.ap.freescale.net [10.192.208.232]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 55A62402A9; Wed, 27 Jan 2021 09:49:39 +0100 (CET) From: Biwen Li To: mark.rutland@arm.com, leoyang.li@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org Subject: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Date: Wed, 27 Jan 2021 16:58:18 +0800 Message-Id: <20210127085818.23742-1-biwen.li@oss.nxp.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_034950_417814_B6E235E0 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Biwen Li , jiafei.pan@nxp.com, ran.wang_1@nxp.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Biwen Li Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow, ... [ 45.605239] Unbalanced IRQ 120 wake disable [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800 irq_set_irq_wake+0x154/0x1a0 ... [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0 [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0 ... [ 45.742825] Call trace: [ 45.745268] irq_set_irq_wake+0x154/0x1a0 [ 45.749278] ds3232_resume+0x38/0x50 On ls2088ardb: In suspend progress(# echo mem > /sys/power/state), pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend() ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), return -ENXIO, there get "Cannot set wakeup source" in ds3232_suspend(). In resume progress(wakeup by flextimer) dpm_resume_end()->dpm_resume() ->device_resume()->ds3232_resume() ->disable_irq_wake()->irq_set_irq_wake() ->set_irq_wake_real(), there get kernel call trace(Unbalanced IRQ 120 wake disable) Signed-off-by: Biwen Li --- Change in v2: - update description drivers/irqchip/irq-ls-extirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 564e6de0bd8e..3c6ed7b4744d 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -65,7 +65,7 @@ static struct irq_chip ls_extirq_chip = { .irq_set_type = ls_extirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE, }; static int