From patchwork Wed Jan 27 11:25:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BD1C433DB for ; Wed, 27 Jan 2021 11:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BD92207B7 for ; Wed, 27 Jan 2021 11:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237135AbhA0LtB (ORCPT ); Wed, 27 Jan 2021 06:49:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232148AbhA0L2O (ORCPT ); Wed, 27 Jan 2021 06:28:14 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70276C061788 for ; Wed, 27 Jan 2021 03:26:01 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id j18so1223705wmi.3 for ; Wed, 27 Jan 2021 03:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mqKIorWT4gXh/otNkPIF0uCkC/OA7zuZgaSdIUKa4VQ=; b=aENfasNI0ky/TTcKZj0RBlkmPCXTD05TgexoPZIddRhq2koMze0DuPLrwkMae41+Hp c4o6F6D3wsQBlrVlCmZ7aUQdCCtmmo1Zy/78VoBb3SeSGekBmMxa85XjSaL4+Z5W0ASW frcfDqvGEiRbLqe7mqxqfEYadOGB40lkBdpuV0z/FjpwvW2yJL5Pwh2NNPym0lQPP6q7 pVSQBXlr8NMYn89mIrrXheymk2bzoxqMB3pRsyc2GhVhJsPvPEnrPk6YOe4MBLgROBt8 xFOHtLnV/n+gPs2Qyi3kw1aR/PrbGWVqpF4DWAU84kXuY0JrWyd6GPdZQd3BqmzT/enI 8/Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mqKIorWT4gXh/otNkPIF0uCkC/OA7zuZgaSdIUKa4VQ=; b=szy+5ItlInO8AwU1Q27DtdyeIBk8BaC5wahbpbnk4BWzKLK50vLjGFLBMyYAsI+Snm L0cRWwANlw2PbeTrEMMyb6c0TrwmB7FqHNB6YzBWqvfsq5V0QtUhYPbLsbTZK44oByAc /ajl9s0VQnSJsH1Puh6pDgJLiSDq3Ydso61zisw/dA7IodPaI09sGZIBoqVmT4gGZSoY 9GYJ2nPHRh7M0A6+mwK54z16m0Et7dRm5vbQif1VzSYcKpUJvz5Bc/qALahEAo/HoITx tdgCoHUNjo1x5iZVo/WyXfPLuTdXd3BN3dPwHtrErrqEHVlALm3Ibdk/uZroRMWK2ZI/ znrg== X-Gm-Message-State: AOAM530D9FAkQnH/aR9w2B6xgR9A/vrV+tTpHDT9uj4/lOWxKwIG7i4B ItofBbCcQsHnhWHgOUQNuOfsng== X-Google-Smtp-Source: ABdhPJzD79rhcX17fcmbNib/cgUuSVbYrVZ1wACd3viDqTyTSWbDLxZfJHt8w81Z9WiY7cPeOnh/jg== X-Received: by 2002:a1c:4483:: with SMTP id r125mr3710279wma.80.1611746760177; Wed, 27 Jan 2021 03:26:00 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:25:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 01/12] thunderbolt: dma_port: Remove unused variable 'ret' Date: Wed, 27 Jan 2021 11:25:43 +0000 Message-Id: <20210127112554.3770172-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/dma_port.c: In function ‘dma_port_flash_write_block’: drivers/thunderbolt/dma_port.c:331:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/dma_port.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/thunderbolt/dma_port.c b/drivers/thunderbolt/dma_port.c index 847dd07a7b172..5aced91e17dc4 100644 --- a/drivers/thunderbolt/dma_port.c +++ b/drivers/thunderbolt/dma_port.c @@ -328,13 +328,12 @@ static int dma_port_flash_write_block(struct tb_dma_port *dma, u32 address, { struct tb_switch *sw = dma->sw; u32 in, dwaddress, dwords; - int ret; dwords = size / 4; /* Write the block to MAIL_DATA registers */ - ret = dma_port_write(sw->tb->ctl, buf, tb_route(sw), dma->port, - dma->base + MAIL_DATA, dwords, DMA_PORT_TIMEOUT); + dma_port_write(sw->tb->ctl, buf, tb_route(sw), dma->port, + dma->base + MAIL_DATA, dwords, DMA_PORT_TIMEOUT); in = MAIL_IN_CMD_FLASH_WRITE << MAIL_IN_CMD_SHIFT; From patchwork Wed Jan 27 11:25:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3E6C433E0 for ; Wed, 27 Jan 2021 11:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0FBE207B7 for ; Wed, 27 Jan 2021 11:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236995AbhA0LsI (ORCPT ); Wed, 27 Jan 2021 06:48:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236670AbhA0L2R (ORCPT ); Wed, 27 Jan 2021 06:28:17 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 997CCC06178B for ; Wed, 27 Jan 2021 03:26:02 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id s24so3110734wmj.0 for ; Wed, 27 Jan 2021 03:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eaLLflOnKxP3ffgsiKs11jelhSBcLmsQ05hbA36SRWk=; b=mop6sJKsuKx109i4wFRGzFHjuny65TlVpW/7jqa/q7gNTSVaUSOSdZ3d1poYKmgZnZ LFfIDPqBNfwkj809/WBG0/EPIbR91wJ0pZv2VkttW8wfp3PI858ttY5oqYaStU92ulC0 DTFAQS/CSfXFPx3pUYfdA93oroFJ1ttmFgdRoW9bZQrTZhyxGjI9zrnMcc1yY12eMlkn JOcrizBGsX3DzwOgb78uWR3SExVaTr0lakUgb/gy63zB7TVQud6x8KwFHTzaHSn2acSB FbMYD/wo0N/kXS+k3zUAEDBJxCJxJGQEeafDMfYrQKBSevW3TQYGo2cD0MkpktIku3mL t+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eaLLflOnKxP3ffgsiKs11jelhSBcLmsQ05hbA36SRWk=; b=qenQxtysGt69JrcH+8cEVsnhglVZEBE6r86NuZylyVgq1SYQ5MlkXVuP/Qfqm9n4uU xsV8uoZ+a496u/7R+K+dR7r4HWf7Rn5TDWaHFqQ4Xg6mvFEyckdCpKV4i/3abxXhveeI 6d6xAjzKO+0WWgH7Z4bT+b68fxPeGEOj7mwSoWeFQlt6nTO+d2wK0npzKI6o7Q3QnE2F AFunyVO2Gac7wTDyAgnknK1Z2euZ3AbFe4JNNkIbckSXkC6caqiPrHEB6K0GBVlABLHZ aKawYRpNJdGF2xVEvDkosKoUEbU11VsQZMT1xVKPohZM1aQGCB7ok+fq1HU1aIYHbLP+ IKQA== X-Gm-Message-State: AOAM530UpdE82fnb8gEEMUzGDPaT4qZhsvBjKHrwt5xkfxUzQuMfG7W3 Q33lM1zb63ykBW3TFdDtAdL6rA== X-Google-Smtp-Source: ABdhPJxszX1z1YoVOvKrPQMaHwIfewhwrriy4HtebjVjpjgLl2GWclwbcMjFkzPxFOv2GciQaXRU/Q== X-Received: by 2002:a1c:6486:: with SMTP id y128mr3965686wmb.12.1611746761314; Wed, 27 Jan 2021 03:26:01 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 02/12] thunderbolt: cap: Fix kernel-doc formatting issue Date: Wed, 27 Jan 2021 11:25:44 +0000 Message-Id: <20210127112554.3770172-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/cap.c:189: warning: Function parameter or member 'sw' not described in 'tb_switch_find_cap' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/cap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/cap.c b/drivers/thunderbolt/cap.c index 6f571e912cf21..8ecd610c62d50 100644 --- a/drivers/thunderbolt/cap.c +++ b/drivers/thunderbolt/cap.c @@ -178,7 +178,7 @@ int tb_switch_next_cap(struct tb_switch *sw, unsigned int offset) /** * tb_switch_find_cap() - Find switch capability - * @sw Switch to find the capability for + * @sw: Switch to find the capability for * @cap: Capability to look * * Returns offset to start of capability or %-ENOENT if no such From patchwork Wed Jan 27 11:25:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049749 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE06C433E6 for ; Wed, 27 Jan 2021 11:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92FC82078E for ; Wed, 27 Jan 2021 11:30:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236694AbhA0Lad (ORCPT ); Wed, 27 Jan 2021 06:30:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236691AbhA0L20 (ORCPT ); Wed, 27 Jan 2021 06:28:26 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A85C061793 for ; Wed, 27 Jan 2021 03:26:03 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d16so1484323wro.11 for ; Wed, 27 Jan 2021 03:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tS3BpQ7TcxBqrK3CV55kl5AeIBZ9mcF/pZlX65f8Y00=; b=Nu8+n1/ZihhGiy1TfuXunJaZiL8mlLgwXtD+3HKuHzCxGA5KBXuDQx/azGs77uccfH ymALA7L46gPGCSXzr2scD5uHg/vMcJB/W0FV3XSwn+KE+LXkkhQVdMSrpyS/U51C9gBq +ENefxVJsmwGUNg8439/6SfDAMbXQbKdYUeYGialfDkO/93iApVl5adpNukr1BSHHnf0 H5pvqFwEnx1LGGY47VMq1zC1gvxtHUG8vW1vRB3VF/04Mg1F8cFv1B2JP2b5/lDWKTm8 u/xGaXj6tsV66oW3kNZ/v0nE3TVUef4Hp+V8kSGawP1PGLFaAAqrDzAPe2gEN+l8M8R5 LqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tS3BpQ7TcxBqrK3CV55kl5AeIBZ9mcF/pZlX65f8Y00=; b=j5L1+cXd5yk+NEmhY1JBcLW3H1ChB0Y4iEGSjza4AUBl2LddoWLc0t2TL0r7A3u3Fd jeHyVcAOI8/iBhcLfTZU+HPfVNP4TkMPTjRFoUPQktYtdApFmNyUNyT5NQw0Tkkxxs6F iYu4oe0lO2V5jVIW96s5p4KUXrtzNUVpnOW9IA+5TLG0Oz4+1H1wDvWD2YH+9YQrohJc 6qlnnGTuLzzmIRDSovDdxKywlM9dyROlLH+bRPd5MOgUir6v6BKRBlHQaq4geYekJgWq 20IUk8rzIYM0LrgjwViWe/h11FIKZhEH6Q5jzi6vU9+PeCE4JdxElrej03SlYyF+Ufdt UshQ== X-Gm-Message-State: AOAM531RRiM5U3gkfE2uAAJUwGrK1vpi/zXrwXgqqwU2FbHRhfVIQu6q bnWGjjHHyOoS5uaSpL+1OS48Zg== X-Google-Smtp-Source: ABdhPJy6nMZ4WLsFP1oo29N2QsZtYnO46W7YC7oIsJ3Gtwq2ZObK+cQFj0glBklo0sMPKTLPLrAv6g== X-Received: by 2002:adf:f8c1:: with SMTP id f1mr10663596wrq.76.1611746762542; Wed, 27 Jan 2021 03:26:02 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 03/12] thunderbolt: ctl: Demote non-conformant kernel-doc headers Date: Wed, 27 Jan 2021 11:25:45 +0000 Message-Id: <20210127112554.3770172-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/ctl.c:38: warning: expecting prototype for struct tb_cfg. Prototype was for struct tb_ctl instead drivers/thunderbolt/ctl.c:350: warning: Function parameter or member 'ctl' not described in 'tb_ctl_tx' drivers/thunderbolt/ctl.c:350: warning: Function parameter or member 'data' not described in 'tb_ctl_tx' drivers/thunderbolt/ctl.c:350: warning: Function parameter or member 'len' not described in 'tb_ctl_tx' drivers/thunderbolt/ctl.c:350: warning: Function parameter or member 'type' not described in 'tb_ctl_tx' drivers/thunderbolt/ctl.c:350: warning: expecting prototype for tb_cfg_tx(). Prototype was for tb_ctl_tx() instead drivers/thunderbolt/ctl.c:383: warning: Function parameter or member 'ctl' not described in 'tb_ctl_handle_event' drivers/thunderbolt/ctl.c:383: warning: Function parameter or member 'type' not described in 'tb_ctl_handle_event' drivers/thunderbolt/ctl.c:383: warning: Function parameter or member 'pkg' not described in 'tb_ctl_handle_event' drivers/thunderbolt/ctl.c:383: warning: Function parameter or member 'size' not described in 'tb_ctl_handle_event' drivers/thunderbolt/ctl.c:611: warning: Function parameter or member 'nhi' not described in 'tb_ctl_alloc' drivers/thunderbolt/ctl.c:611: warning: Function parameter or member 'cb' not described in 'tb_ctl_alloc' drivers/thunderbolt/ctl.c:611: warning: Function parameter or member 'cb_data' not described in 'tb_ctl_alloc' drivers/thunderbolt/ctl.c:658: warning: Function parameter or member 'ctl' not described in 'tb_ctl_free' drivers/thunderbolt/ctl.c:682: warning: Function parameter or member 'ctl' not described in 'tb_ctl_start' drivers/thunderbolt/ctl.c:682: warning: expecting prototype for tb_cfg_start(). Prototype was for tb_ctl_start() instead drivers/thunderbolt/ctl.c:702: warning: Function parameter or member 'ctl' not described in 'tb_ctl_stop' drivers/thunderbolt/ctl.c:702: warning: expecting prototype for control(). Prototype was for tb_ctl_stop() instead drivers/thunderbolt/ctl.c:794: warning: Function parameter or member 'ctl' not described in 'tb_cfg_reset' drivers/thunderbolt/ctl.c:794: warning: Function parameter or member 'route' not described in 'tb_cfg_reset' drivers/thunderbolt/ctl.c:794: warning: Function parameter or member 'timeout_msec' not described in 'tb_cfg_reset' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'ctl' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'buffer' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'route' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'port' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'space' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'offset' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'length' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: Function parameter or member 'timeout_msec' not described in 'tb_cfg_read_raw' drivers/thunderbolt/ctl.c:830: warning: expecting prototype for tb_cfg_read(). Prototype was for tb_cfg_read_raw() instead drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'ctl' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'buffer' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'route' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'port' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'space' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'offset' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'length' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: Function parameter or member 'timeout_msec' not described in 'tb_cfg_write_raw' drivers/thunderbolt/ctl.c:893: warning: expecting prototype for tb_cfg_write(). Prototype was for tb_cfg_write_raw() instead drivers/thunderbolt/ctl.c:1033: warning: Function parameter or member 'ctl' not described in 'tb_cfg_get_upstream_port' drivers/thunderbolt/ctl.c:1033: warning: Function parameter or member 'route' not described in 'tb_cfg_get_upstream_port' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/ctl.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index bac08b820015d..e5d7ff6807721 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -19,7 +19,7 @@ #define TB_CTL_RX_PKG_COUNT 10 #define TB_CTL_RETRIES 4 -/** +/* * struct tb_cfg - thunderbolt control channel */ struct tb_ctl { @@ -338,7 +338,7 @@ static void tb_ctl_tx_callback(struct tb_ring *ring, struct ring_frame *frame, tb_ctl_pkg_free(pkg); } -/** +/* * tb_cfg_tx() - transmit a packet on the control channel * * len must be a multiple of four. @@ -375,7 +375,7 @@ static int tb_ctl_tx(struct tb_ctl *ctl, const void *data, size_t len, return res; } -/** +/* * tb_ctl_handle_event() - acknowledge a plug event, invoke ctl->callback */ static bool tb_ctl_handle_event(struct tb_ctl *ctl, enum tb_cfg_pkg_type type, @@ -600,7 +600,7 @@ struct tb_cfg_result tb_cfg_request_sync(struct tb_ctl *ctl, /* public interface, alloc/start/stop/free */ -/** +/* * tb_ctl_alloc() - allocate a control channel * * cb will be invoked once for every hot plug event. @@ -647,7 +647,7 @@ struct tb_ctl *tb_ctl_alloc(struct tb_nhi *nhi, event_cb cb, void *cb_data) return NULL; } -/** +/* * tb_ctl_free() - free a control channel * * Must be called after tb_ctl_stop. @@ -675,7 +675,7 @@ void tb_ctl_free(struct tb_ctl *ctl) kfree(ctl); } -/** +/* * tb_cfg_start() - start/resume the control channel */ void tb_ctl_start(struct tb_ctl *ctl) @@ -690,7 +690,7 @@ void tb_ctl_start(struct tb_ctl *ctl) ctl->running = true; } -/** +/* * control() - pause the control channel * * All invocations of ctl->callback will have finished after this method @@ -782,7 +782,7 @@ static bool tb_cfg_copy(struct tb_cfg_request *req, const struct ctl_pkg *pkg) return true; } -/** +/* * tb_cfg_reset() - send a reset packet and wait for a response * * If the switch at route is incorrectly configured then we will not receive a @@ -819,7 +819,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route, return res; } -/** +/* * tb_cfg_read() - read from config space into buffer * * Offset and length are in dwords. @@ -882,7 +882,7 @@ struct tb_cfg_result tb_cfg_read_raw(struct tb_ctl *ctl, void *buffer, return res; } -/** +/* * tb_cfg_write() - write from buffer into config space * * Offset and length are in dwords. @@ -1020,7 +1020,7 @@ int tb_cfg_write(struct tb_ctl *ctl, const void *buffer, u64 route, u32 port, return res.err; } -/** +/* * tb_cfg_get_upstream_port() - get upstream port number of switch at route * * Reads the first dword from the switches TB_CFG_SWITCH config area and From patchwork Wed Jan 27 11:25:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9A7C433DB for ; Wed, 27 Jan 2021 11:30:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 352D920773 for ; Wed, 27 Jan 2021 11:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236697AbhA0Lav (ORCPT ); Wed, 27 Jan 2021 06:30:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236704AbhA0L2l (ORCPT ); Wed, 27 Jan 2021 06:28:41 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDF59C061797 for ; Wed, 27 Jan 2021 03:26:04 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id q7so1484131wre.13 for ; Wed, 27 Jan 2021 03:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3gNjVcguBm3iHiG+H/50H6Ct3jriN+3gNPTKUDiVErk=; b=Wtq2YxioRtkgawh7qJpG8HD2X/HY1bKKGFuf8Pcz48KrwrLGePpkmmlSS1eUL+FMlK +gsf93A5JGiHJtLYqiOirMxkpo2lmzv7MNnzmjozAC3NSaVENeoMMDAJ1AZ7e9TQf51u +vfIb4aPkruQShNg3SV8Fc6+tYkjmqP/c6DoDifN9uEyqAxTCjciJOO1TbBram3V8aFp 0TprhXTdBq5PW6krbA0x77a8Eq2erIJ5JUXLTOv5zrII0OSya4x4VjIA6m5brHW8DnO9 UvhlO7nkrGkmgV2NQPDq0nQeEMvP+KMzV4N5KQan4V1fo3uFwxdVLiRo+wLjzzDoQR0o /cBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3gNjVcguBm3iHiG+H/50H6Ct3jriN+3gNPTKUDiVErk=; b=jG+/7bGpfU4qcoLGgox1g6cK4udWEbmGY0xuFx5c4IgThok0qoiX58nUy4tWphVjWi B97lQEVINUfywmOhJ84Of6RXGN1lRNLguXog9vzYeqDQ55eA4dP8exaiBgZezFN1UxNX TEccyCqpizpqJ13l5O0nxJrCYbRIiTMHUsLwx8q8k6xIhMaEvIzg9UdTwUnRfBy2OsgQ vtrsX3fvx1WIs6Kyhe+ziDRqkm8cmT+4cN6n5iaG7Kd3mfGaBwPhlMUgzCZQCie3/5Sh AyXoRWV+UB/6CGAF/yQJ+viYfLnwDzmWd19kbHbNlF8uR3NpWendDEU3AgTPXjf9pTfH Uhsg== X-Gm-Message-State: AOAM530QwEr6jzcjYTjXiD/PqBe78Kb/HRIdNZOaZicGn6ZthoTjNv52 ICZJpdO0Ur9ePay98b8Vet6F6w== X-Google-Smtp-Source: ABdhPJy4E+H0lQ3NmN4AOzPEglY0JTWYItaNl2G6bCZyk69savGjQ7hmVp0aic/hUbiYfbJaeMrzkw== X-Received: by 2002:adf:c14d:: with SMTP id w13mr10453640wre.383.1611746763650; Wed, 27 Jan 2021 03:26:03 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 04/12] thunderbolt: eeprom: Demote non-conformant kernel-doc headers to standard comment blocks Date: Wed, 27 Jan 2021 11:25:46 +0000 Message-Id: <20210127112554.3770172-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/eeprom.c:19: warning: Function parameter or member 'sw' not described in 'tb_eeprom_ctl_write' drivers/thunderbolt/eeprom.c:19: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_ctl_write' drivers/thunderbolt/eeprom.c:27: warning: Function parameter or member 'sw' not described in 'tb_eeprom_ctl_read' drivers/thunderbolt/eeprom.c:27: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_ctl_read' drivers/thunderbolt/eeprom.c:27: warning: expecting prototype for tb_eeprom_ctl_write(). Prototype was for tb_eeprom_ctl_read() instead drivers/thunderbolt/eeprom.c:43: warning: Function parameter or member 'sw' not described in 'tb_eeprom_active' drivers/thunderbolt/eeprom.c:43: warning: Function parameter or member 'enable' not described in 'tb_eeprom_active' drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'sw' not described in 'tb_eeprom_transfer' drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'ctl' not described in 'tb_eeprom_transfer' drivers/thunderbolt/eeprom.c:73: warning: Function parameter or member 'direction' not described in 'tb_eeprom_transfer' drivers/thunderbolt/eeprom.c:97: warning: Function parameter or member 'sw' not described in 'tb_eeprom_out' drivers/thunderbolt/eeprom.c:97: warning: Function parameter or member 'val' not described in 'tb_eeprom_out' drivers/thunderbolt/eeprom.c:117: warning: Function parameter or member 'sw' not described in 'tb_eeprom_in' drivers/thunderbolt/eeprom.c:117: warning: Function parameter or member 'val' not described in 'tb_eeprom_in' drivers/thunderbolt/eeprom.c:138: warning: Function parameter or member 'sw' not described in 'tb_eeprom_get_drom_offset' drivers/thunderbolt/eeprom.c:138: warning: Function parameter or member 'offset' not described in 'tb_eeprom_get_drom_offset' drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'sw' not described in 'tb_eeprom_read_n' drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'offset' not described in 'tb_eeprom_read_n' drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'val' not described in 'tb_eeprom_read_n' drivers/thunderbolt/eeprom.c:170: warning: Function parameter or member 'count' not described in 'tb_eeprom_read_n' drivers/thunderbolt/eeprom.c:288: warning: Function parameter or member 'sw' not described in 'tb_drom_read_uid_only' drivers/thunderbolt/eeprom.c:288: warning: Function parameter or member 'uid' not described in 'tb_drom_read_uid_only' drivers/thunderbolt/eeprom.c:383: warning: Function parameter or member 'sw' not described in 'tb_drom_parse_entries' drivers/thunderbolt/eeprom.c:417: warning: Function parameter or member 'sw' not described in 'tb_drom_copy_efi' drivers/thunderbolt/eeprom.c:417: warning: Function parameter or member 'size' not described in 'tb_drom_copy_efi' drivers/thunderbolt/eeprom.c:526: warning: Function parameter or member 'sw' not described in 'tb_drom_read' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/eeprom.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c index 0c8471be3e32f..e8cb8399069c9 100644 --- a/drivers/thunderbolt/eeprom.c +++ b/drivers/thunderbolt/eeprom.c @@ -12,7 +12,7 @@ #include #include "tb.h" -/** +/* * tb_eeprom_ctl_write() - write control word */ static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) @@ -20,7 +20,7 @@ static int tb_eeprom_ctl_write(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) return tb_sw_write(sw, ctl, TB_CFG_SWITCH, sw->cap_plug_events + 4, 1); } -/** +/* * tb_eeprom_ctl_write() - read control word */ static int tb_eeprom_ctl_read(struct tb_switch *sw, struct tb_eeprom_ctl *ctl) @@ -33,7 +33,7 @@ enum tb_eeprom_transfer { TB_EEPROM_OUT, }; -/** +/* * tb_eeprom_active - enable rom access * * WARNING: Always disable access after usage. Otherwise the controller will @@ -62,7 +62,7 @@ static int tb_eeprom_active(struct tb_switch *sw, bool enable) } } -/** +/* * tb_eeprom_transfer - transfer one bit * * If TB_EEPROM_IN is passed, then the bit can be retrieved from ctl->data_in. @@ -90,7 +90,7 @@ static int tb_eeprom_transfer(struct tb_switch *sw, struct tb_eeprom_ctl *ctl, return tb_eeprom_ctl_write(sw, ctl); } -/** +/* * tb_eeprom_out - write one byte to the bus */ static int tb_eeprom_out(struct tb_switch *sw, u8 val) @@ -110,7 +110,7 @@ static int tb_eeprom_out(struct tb_switch *sw, u8 val) return 0; } -/** +/* * tb_eeprom_in - read one byte from the bus */ static int tb_eeprom_in(struct tb_switch *sw, u8 *val) @@ -131,7 +131,7 @@ static int tb_eeprom_in(struct tb_switch *sw, u8 *val) return 0; } -/** +/* * tb_eeprom_get_drom_offset - get drom offset within eeprom */ static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset) @@ -162,7 +162,7 @@ static int tb_eeprom_get_drom_offset(struct tb_switch *sw, u16 *offset) return 0; } -/** +/* * tb_eeprom_read_n - read count bytes from offset into val */ static int tb_eeprom_read_n(struct tb_switch *sw, u16 offset, u8 *val, @@ -278,7 +278,7 @@ struct tb_drom_entry_port { } __packed; -/** +/* * tb_drom_read_uid_only - read uid directly from drom * * Does not use the cached copy in sw->drom. Used during resume to check switch @@ -374,7 +374,7 @@ static int tb_drom_parse_entry_port(struct tb_switch *sw, return 0; } -/** +/* * tb_drom_parse_entries - parse the linked list of drom entries * * Drom must have been copied to sw->drom. @@ -410,7 +410,7 @@ static int tb_drom_parse_entries(struct tb_switch *sw) return 0; } -/** +/* * tb_drom_copy_efi - copy drom supplied by EFI to sw->drom if present */ static int tb_drom_copy_efi(struct tb_switch *sw, u16 *size) @@ -519,7 +519,7 @@ static int tb_drom_read_n(struct tb_switch *sw, u16 offset, u8 *val, return tb_eeprom_read_n(sw, offset, val, count); } -/** +/* * tb_drom_read - copy drom to sw->drom and parse it */ int tb_drom_read(struct tb_switch *sw) From patchwork Wed Jan 27 11:25:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993D4C433E6 for ; Wed, 27 Jan 2021 11:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CB852076D for ; Wed, 27 Jan 2021 11:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237048AbhA0Lmh (ORCPT ); Wed, 27 Jan 2021 06:42:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236793AbhA0L3U (ORCPT ); Wed, 27 Jan 2021 06:29:20 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26A7DC0617AA for ; Wed, 27 Jan 2021 03:26:06 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id 7so1538803wrz.0 for ; Wed, 27 Jan 2021 03:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9+pPf3toKEse/9kjih6DD2KI63boeMHUYd5sQ1L4808=; b=EGJZw7wfgtfz2CzYV3daPIlaKtUeDRxMJKKiGrIQERCjYN8FFDybJWgKh+/vMdQQrJ b6SCg1l3YXhZXlopKmQdPBzFnGCbNaPosS9Uesaf5BLBaAOA1HU8U9lBp2L2ISjZsgCa 5o0HN+fm8nRkPPPugdclK7jLUYV+oZgQcAs8eP3P2gjMQ8yGkW/lXwDk3MJpegB9HoLx lQ2H8GMIpvmHiinVSyYKKcvwPwSJbIk5A9/bUXYNE8b2dfor0bUnG+Dblsofa2KoN5x4 Wch8x4suZCfNuj5TF3lwLXJuCRcAIOsN7i6+Zvm3HLP1HrJ9jvAfky34e2pNwJsS0gfF dUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9+pPf3toKEse/9kjih6DD2KI63boeMHUYd5sQ1L4808=; b=EB2XPqP7q8AFtJxy4bpzYu4YTnC2NpxNTBptoGnyONsIWippKhA66TFRX6xwNsxb+Q CzZaEK5JznEeATqj5dnPS88TYfN8atWDAwPyfkToTQBebOi4lTdVFEesllnoEKaCPD5B JqU2KTISenHu2W86zSKvoj7wT6mQvxi72Lqj9jRO6aOwKF+oPYvyW1QRqMa+9+PgRTed 1qDrADYw2dy70CVANliedBDhh4B7VVGWN5zciQrKkehcGDt8YpjbFAa4V1ceLK4j/vxP 6SIp8Mr4gLiwVMKoDh5b8ghWaloX8mxsyTzNijJGMy3UZAjYq7YNL2bfe/KeYqEBzMgw nhXg== X-Gm-Message-State: AOAM531wuZB23csKX85eBz69yDpRjpfEW/H2WEnmDWOp8VfhSyY7ZnAi uve1rUvBJRO2Sh3zLZHEfgqEjA== X-Google-Smtp-Source: ABdhPJwLt9fF+Qd6gWqSi22t+tjPmJ1gbZnyZUHjpQhmago9hDtiktK4oYSqHo90oUJdK/kuU2kzmQ== X-Received: by 2002:a5d:524f:: with SMTP id k15mr10815856wrc.16.1611746764884; Wed, 27 Jan 2021 03:26:04 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 05/12] thunderbolt: pa: Demote non-conformant kernel-doc headers Date: Wed, 27 Jan 2021 11:25:47 +0000 Message-Id: <20210127112554.3770172-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/path.c:476: warning: Function parameter or member 'path' not described in 'tb_path_activate' drivers/thunderbolt/path.c:568: warning: Function parameter or member 'path' not described in 'tb_path_is_invalid' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/path.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/path.c b/drivers/thunderbolt/path.c index ca7d738d66dea..758b5fa0060c6 100644 --- a/drivers/thunderbolt/path.c +++ b/drivers/thunderbolt/path.c @@ -464,7 +464,7 @@ void tb_path_deactivate(struct tb_path *path) path->activated = false; } -/** +/* * tb_path_activate() - activate a path * * Activate a path starting with the last hop and iterating backwards. The @@ -559,7 +559,7 @@ int tb_path_activate(struct tb_path *path) return res; } -/** +/* * tb_path_is_invalid() - check whether any ports on the path are invalid * * Return: Returns true if the path is invalid, false otherwise. From patchwork Wed Jan 27 11:25:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC947C433DB for ; Wed, 27 Jan 2021 11:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B26F2075B for ; Wed, 27 Jan 2021 11:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237078AbhA0Lme (ORCPT ); Wed, 27 Jan 2021 06:42:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236795AbhA0L3V (ORCPT ); Wed, 27 Jan 2021 06:29:21 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F28FC061351 for ; Wed, 27 Jan 2021 03:26:07 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id 7so1538873wrz.0 for ; Wed, 27 Jan 2021 03:26:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=svVOUGKG5Fv6t7oAvNImQmC5zwwJ4U0ey/3mhzQtIP4=; b=RQw8287NITYeNqTInH8hwgY4UTwjmsUno9caSnmGOl1zLHuayiE5rJ2fiiEuXSbeP6 H5HESNZOpwqyEvLrXVHbZR5HX1tOFS7EsZPHpDvyfzWy8N5wiauKQiVXQmEtu48AvsjU CgyJPy9FrN7NV6nm+d/grtY8TW5/MB4qpL9oid2Y6X9dLinRP43m5MaSOeUJHQMghP65 nXOSL1+0338DF+3oxLldc7jf2R3Kv7Sxcsk166jHtfs2e4zBiDuUMhlDIqgzIonbzg8h +qw6+ULYXP6ZLS3liXBN1aJkbO6cM8q4OYjMd8C3sjsfEg/36EHfxpHqG+7YBpZYtJPP CnIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=svVOUGKG5Fv6t7oAvNImQmC5zwwJ4U0ey/3mhzQtIP4=; b=OfsaAgVK0yms4fUlDPgnQn5SwV2i9Ktx0Ez9dKSGzDLH32WHWP/jK5tD4rGMhfXeD7 DpjyhxJZzIRXmB8PFUodI7ftxyrm5UmUGWBuXFqfWwRaryBV4xW6RCKaVq5Ajvjx2LeY ewaej5GyfSAYBvpRQnximWVhdmtjvtJZHds/iZbxmtjDEljupN2i060AScMkxnNcUGfx KPFJoVg3/Dm2bs7vgLE/ufaRzEhdSuEsUTdRSVnC9r147T6boPeb7X2PTc08Lpf22QZX VS4yPJZLnRoDL+FvfDOo7sNEBA0T0vHuB4tuCLT3ULqs5+n7JG+b6RMNfkvU329dyinU npqA== X-Gm-Message-State: AOAM530pj7pVBZ1KsqQLP+uP+n93Smp54fqi8EKSnu7AMykCmDn8gAmr zumXcfLXvDevmVXBsSXeZKXIKw== X-Google-Smtp-Source: ABdhPJwHTzrcFOoZyi1HeP3EtLePMxJE62a7mjl8dfor15nZfkZLeVwADi013e38+v4lDmcaCLfdxw== X-Received: by 2002:a5d:4292:: with SMTP id k18mr10798614wrq.218.1611746766164; Wed, 27 Jan 2021 03:26:06 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , linux-usb@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 06/12] thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' param Date: Wed, 27 Jan 2021 11:25:48 +0000 Message-Id: <20210127112554.3770172-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/xdomain.c:678: warning: Function parameter or member 'drv' not described in 'tb_unregister_service_driver' drivers/thunderbolt/xdomain.c:678: warning: Excess function parameter 'xdrv' description in 'tb_unregister_service_driver' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: linux-usb@vger.kernel.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/xdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index f2d4db1cd84d0..6e8bea6a7d392 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -670,7 +670,7 @@ EXPORT_SYMBOL_GPL(tb_register_service_driver); /** * tb_unregister_service_driver() - Unregister XDomain service driver - * @xdrv: Driver to unregister + * @drv: Driver to unregister * * Unregisters XDomain service driver from the bus. */ From patchwork Wed Jan 27 11:25:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6EAC433DB for ; Wed, 27 Jan 2021 11:44:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D50E2076B for ; Wed, 27 Jan 2021 11:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236774AbhA0LoA (ORCPT ); Wed, 27 Jan 2021 06:44:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236636AbhA0L3M (ORCPT ); Wed, 27 Jan 2021 06:29:12 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AD9C061354 for ; Wed, 27 Jan 2021 03:26:08 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id m187so1230433wme.2 for ; Wed, 27 Jan 2021 03:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uAcqugrgmh8drWeQR+i/2G20G7LeMdKvoS3TGhgRh3k=; b=ki5sKBbvUH97xRS17R7ZRIfdT505bJXJc9ycIieG3YZtQaTkl6hn3yT88GSXjJuHaU G8uyBhNCIhFO9tEnbFNRwqusT2pALL0FwFllWU2+xaIXeB0tpu2BvCR8Mm2p7WNtR/EA UF7gMvG9H6vTfL41sL8BMOkYwIpyE8FqlZeVbbVVOVjCtiqekiIPwYXSReB5adhLy7FH YhcNNMOKwxHYfgOX35RJibYYXNdxm9qbFNxss2BxQLPRkK5vMju+WJD0FdzGFUeDAp9J K+fJZ3OwNg6PL/c1WHUJ6qLk0sX/CykQF8o9ZM+aggfzWS9Es44h7IpCPzwKgf+5Yo+f jB5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uAcqugrgmh8drWeQR+i/2G20G7LeMdKvoS3TGhgRh3k=; b=MagSOxs6CuC5asnKE/0wD+xCzrNzneTLH4xZsep3LiqAlY229xD4H38Gf6DqERTyQ4 B0ljjqjmVHnAeetpN7rDY5hyUGhlpa28cm9BtGWLBiPjyw4QzuWkUWSoeZtIwLsulMvU Zn1I1aRsyW/rE/fJYosz24g4M09ofv8hN2tLauvKV+A9OLXo4Gwql+xKT4ZY5EeaNIAS p11VrV6HRDDPsLzwOIEi6OaGC0v3ZliihGFjweDDFA9vIW3DkyvIoh6d7yIVURYIZs0o d7mPLN2gRGJX6icLjSu9atZJZ3AbXYsYWZw16StvzyKrK/VUYaaNmxgNKgdwTuePRHni F6aw== X-Gm-Message-State: AOAM5306dfwJPArj/i//Pa2P0ka6BmpXqEOXEMHWGD/IJgqOeuGK19Vy 7meyqUYzxHTqxcLFrv5EfnH4Kw== X-Google-Smtp-Source: ABdhPJzrgEGUcdu6J/3N6xbN495gRs1VHWUonXUpRjsX+BWZK2Id+wPxgtjubHMm9Bnty6EeBy2rRQ== X-Received: by 2002:a7b:cf34:: with SMTP id m20mr3889202wmg.84.1611746767374; Wed, 27 Jan 2021 03:26:07 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 07/12] thunderbolt: nhi: Demote some non-conformant kernel-doc headers Date: Wed, 27 Jan 2021 11:25:49 +0000 Message-Id: <20210127112554.3770172-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/nhi.c:53: warning: Function parameter or member 'ring' not described in 'ring_interrupt_active' drivers/thunderbolt/nhi.c:53: warning: Function parameter or member 'active' not described in 'ring_interrupt_active' drivers/thunderbolt/nhi.c:114: warning: Function parameter or member 'nhi' not described in 'nhi_disable_interrupts' drivers/thunderbolt/nhi.c:191: warning: Function parameter or member 'ring' not described in 'ring_write_descriptors' drivers/thunderbolt/nhi.c:225: warning: Function parameter or member 'work' not described in 'ring_work' drivers/thunderbolt/nhi.c:599: warning: Function parameter or member 'ring' not described in 'tb_ring_start' drivers/thunderbolt/nhi.c:682: warning: Function parameter or member 'ring' not described in 'tb_ring_stop' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/nhi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index cfc622da4f832..2ba33b53d4eb1 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -44,7 +44,7 @@ static int ring_interrupt_index(struct tb_ring *ring) return bit; } -/** +/* * ring_interrupt_active() - activate/deactivate interrupts for a single ring * * ring->nhi->lock must be held. @@ -105,7 +105,7 @@ static void ring_interrupt_active(struct tb_ring *ring, bool active) iowrite32(new, ring->nhi->iobase + reg); } -/** +/* * nhi_disable_interrupts() - disable interrupts for all rings * * Use only during init and shutdown. @@ -182,7 +182,7 @@ static bool ring_empty(struct tb_ring *ring) return ring->head == ring->tail; } -/** +/* * ring_write_descriptors() - post frames from ring->queue to the controller * * ring->lock is held. @@ -212,7 +212,7 @@ static void ring_write_descriptors(struct tb_ring *ring) } } -/** +/* * ring_work() - progress completed frames * * If the ring is shutting down then all frames are marked as canceled and @@ -590,7 +590,7 @@ struct tb_ring *tb_ring_alloc_rx(struct tb_nhi *nhi, int hop, int size, } EXPORT_SYMBOL_GPL(tb_ring_alloc_rx); -/** +/* * tb_ring_start() - enable a ring * * Must not be invoked in parallel with tb_ring_stop(). @@ -665,7 +665,7 @@ void tb_ring_start(struct tb_ring *ring) } EXPORT_SYMBOL_GPL(tb_ring_start); -/** +/* * tb_ring_stop() - shutdown a ring * * Must not be invoked from a callback. @@ -754,7 +754,7 @@ void tb_ring_free(struct tb_ring *ring) dev_dbg(&ring->nhi->pdev->dev, "freeing %s %d\n", RING_TYPE(ring), ring->hop); - /** + /* * ring->work can no longer be scheduled (it is scheduled only * by nhi_interrupt_work, ring_stop and ring_msix). Wait for it * to finish before freeing the ring. From patchwork Wed Jan 27 11:25:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049785 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA703C433E0 for ; Wed, 27 Jan 2021 11:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A1EB2076B for ; Wed, 27 Jan 2021 11:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237053AbhA0LmA (ORCPT ); Wed, 27 Jan 2021 06:42:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236718AbhA0L3q (ORCPT ); Wed, 27 Jan 2021 06:29:46 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C303AC0612F2 for ; Wed, 27 Jan 2021 03:26:09 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id q7so1484389wre.13 for ; Wed, 27 Jan 2021 03:26:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nrHfRQQ/E55YMZ4NS0RU+tz/ZZcnxVsTRIQbMp7bfu4=; b=QsH4cxFeLPJSLDLgvVVWqbfs1nNYSguuJJ5RoM2X14aS59cXwZyyf/SthbmdwBcbpm k2isWMHqYx6x63QZoqbneCyFIEvv+YeTqhw+3NyWrQITgTT63lhMpFlW8bzA6PSHiI2s 4Frqm98pt97nNvnDEILxtkPvFP1LiSaqGZTiXWiW8QrAdyuxA4RxBJcZVc7PjKwXMwVe t7yBrUxT/0zIzxE/sT4XvdSo9ZHZNakYNxGWG+1rzSn6rNlpN5IfJwoi2bT6zi1QtzyV dIQFFYMVJjCqB3CIuzV0Ik+g3w7ZF3jaibbmlsSD9JLJYUQ2jMkNpC6JbxwL5sMy88O/ n6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nrHfRQQ/E55YMZ4NS0RU+tz/ZZcnxVsTRIQbMp7bfu4=; b=pCR2mHmLkXcYcznjo29+OQJ3+N5dXdwgUw5/WSL88J8p+TFZ1k+7a5qUnneBknFFIf jntHzeb/OlabAeegxOVGdgw6nYq9caZzVNE7x0/rWFPNibSVXmaD4bEjWj0v78m/TDvl NWj3bwhcg2LRLIY2G4j0tTfqk7c/mbahRIjEJjMy30rMUedbpkGciyqlVCyfdIJDR3OP QI5YIbjdlOxadZNGF+2Q2ZaeIkp2bGYYVo5Od5UwbGlCkheJVORf86nQXONo7T546QCp 1wFkmTQ6nUxdl+CrRx5MW9vukYMTfeEIMpz8QrvMu0XaIuTTFt94hCU52sFNNtlHOjek /cNQ== X-Gm-Message-State: AOAM530pmPGo3B647At87aPf0np/9tCOJwSHIeApWX2c4EklbCmdHbS9 KMab5ie0lV+IwsJU8PmI+avTnA== X-Google-Smtp-Source: ABdhPJzWI1nalbd0AEwTqiXOmP8+Kw8caxr4ZAdGpHQwJDkjZLaOARlqG0y7O6a0L58462LBm8WpYQ== X-Received: by 2002:a05:6000:1043:: with SMTP id c3mr10805222wrx.140.1611746768541; Wed, 27 Jan 2021 03:26:08 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 08/12] thunderbolt: tb: Kernel-doc function headers should document their parameters Date: Wed, 27 Jan 2021 11:25:50 +0000 Message-Id: <20210127112554.3770172-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/tb.c:535: warning: Function parameter or member 'sw' not described in 'tb_scan_switch' drivers/thunderbolt/tb.c:551: warning: Function parameter or member 'port' not described in 'tb_scan_port' drivers/thunderbolt/tb.c:711: warning: Function parameter or member 'tb' not described in 'tb_free_invalid_tunnels' drivers/thunderbolt/tb.c:726: warning: Function parameter or member 'sw' not described in 'tb_free_unplugged_children' drivers/thunderbolt/tb.c:1129: warning: Function parameter or member 'work' not described in 'tb_handle_hotplug' drivers/thunderbolt/tb.c:1239: warning: Function parameter or member 'tb' not described in 'tb_handle_event' drivers/thunderbolt/tb.c:1239: warning: Function parameter or member 'type' not described in 'tb_handle_event' drivers/thunderbolt/tb.c:1239: warning: Function parameter or member 'buf' not described in 'tb_handle_event' drivers/thunderbolt/tb.c:1239: warning: Function parameter or member 'size' not described in 'tb_handle_event' drivers/thunderbolt/tb.c:1239: warning: expecting prototype for tb_schedule_hotplug_handler(). Prototype was for tb_handle_event() instead Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/tb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c index d08879849abed..413955aa6a949 100644 --- a/drivers/thunderbolt/tb.c +++ b/drivers/thunderbolt/tb.c @@ -528,7 +528,7 @@ static int tb_create_usb3_tunnels(struct tb_switch *sw) static void tb_scan_port(struct tb_port *port); -/** +/* * tb_scan_switch() - scan for and initialize downstream switches */ static void tb_scan_switch(struct tb_switch *sw) @@ -544,7 +544,7 @@ static void tb_scan_switch(struct tb_switch *sw) pm_runtime_put_autosuspend(&sw->dev); } -/** +/* * tb_scan_port() - check for and initialize switches below port */ static void tb_scan_port(struct tb_port *port) @@ -704,7 +704,7 @@ static void tb_deactivate_and_free_tunnel(struct tb_tunnel *tunnel) tb_tunnel_free(tunnel); } -/** +/* * tb_free_invalid_tunnels() - destroy tunnels of devices that have gone away */ static void tb_free_invalid_tunnels(struct tb *tb) @@ -719,7 +719,7 @@ static void tb_free_invalid_tunnels(struct tb *tb) } } -/** +/* * tb_free_unplugged_children() - traverse hierarchy and free unplugged switches */ static void tb_free_unplugged_children(struct tb_switch *sw) @@ -1120,7 +1120,7 @@ static int tb_disconnect_xdomain_paths(struct tb *tb, struct tb_xdomain *xd) /* hotplug handling */ -/** +/* * tb_handle_hotplug() - handle hotplug event * * Executes on tb->wq. @@ -1229,7 +1229,7 @@ static void tb_handle_hotplug(struct work_struct *work) kfree(ev); } -/** +/* * tb_schedule_hotplug_handler() - callback function for the control channel * * Delegates to tb_handle_hotplug. From patchwork Wed Jan 27 11:25:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA933C433E0 for ; Wed, 27 Jan 2021 11:32:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0CBE2075E for ; Wed, 27 Jan 2021 11:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236875AbhA0Lcw (ORCPT ); Wed, 27 Jan 2021 06:32:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236691AbhA0Lan (ORCPT ); Wed, 27 Jan 2021 06:30:43 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04917C06121D for ; Wed, 27 Jan 2021 03:26:11 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id j18so1224132wmi.3 for ; Wed, 27 Jan 2021 03:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mwkTQ1nP1bLt6tR6lEnllegWqUs+MQYhQRklBiDlKoQ=; b=TECRuVSe4dnnPdOZ3qR5o+DV52hnLhGLAxQdA7gxPlQOxjeODPEdP7CQAZHat31ble wLQoPMy9pOhXcsz/6tW7pPJcKNhgLbTohtlvHttbI1k49AZeWJjjDOh7L8kG5ReuzLEi 828/CAZHL6Lzyi/TChi7d3krhiR23NS8cUjvSXXeCm5f0cnpqmm+WZFQNkUfiqwbCRzl 1abB6e9DEowFsRE9W6sVuPyJCU9t3ODjhnKbxw1EkJ7MGR7wZ/NfZvJIS4O3HEZSbiC/ nWkbPp8U6agq6crMMXjtYH+QYnybAS+CXhs6eNbh33tcQpA4S3joP06IZzVINNJ8A4N4 CHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mwkTQ1nP1bLt6tR6lEnllegWqUs+MQYhQRklBiDlKoQ=; b=VyOMUJVvHBJTO0sNrmr1ghYu337t48QyQ9WwRct/kncgB8NqF1qLGNfXMTJaBZ6H0E NH60zO1FzfPFfVG7Nx/EfmBWQtKKMzaZJvNfINoXwu+gjJS5cwzYSduQ2iGutfC7aK0Y 54shZ0WJ4aCPfGs/bZKIwixKtclC9raLfiqzc6k6IzOL4ILmchzoYnG1IQmQqQ4vTh7x oSGKtv7Av+jaRCD7K0eEz0TzESllLD6Ncv5GF8a7rJUwWaUBGe6WrbxJwkZi4FK4+Wzv p+mI1/z77ykYNZeMJ/gPHR7R7oQPQBKYXs8ZphArb0Mdrrd0sjuySuvOV2SiXdWSWJ5W zzBw== X-Gm-Message-State: AOAM533/0T9WUslwmbfd1gBLPIJ4WPGfN62mgx1SRCndzzLUxhU2Inx6 KWvJIwkbz29qGYf52S7C7fw9dA== X-Google-Smtp-Source: ABdhPJzWCLrV0XonIhL5ykP68TTE3wBEGA002zEywUiOWL+7xnfhuyOYUsnFiVlQ2vc9hHLEHxf5BQ== X-Received: by 2002:a1c:8002:: with SMTP id b2mr3944058wmd.94.1611746769810; Wed, 27 Jan 2021 03:26:09 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 09/12] thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers Date: Wed, 27 Jan 2021 11:25:51 +0000 Message-Id: <20210127112554.3770172-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/switch.c:540: warning: Function parameter or member 'port' not described in 'tb_wait_for_port' drivers/thunderbolt/switch.c:540: warning: Function parameter or member 'wait_if_unplugged' not described in 'tb_wait_for_port' drivers/thunderbolt/switch.c:599: warning: Function parameter or member 'port' not described in 'tb_port_add_nfc_credits' drivers/thunderbolt/switch.c:599: warning: Function parameter or member 'credits' not described in 'tb_port_add_nfc_credits' drivers/thunderbolt/switch.c:653: warning: Function parameter or member 'port' not described in 'tb_port_clear_counter' drivers/thunderbolt/switch.c:653: warning: Function parameter or member 'counter' not described in 'tb_port_clear_counter' drivers/thunderbolt/switch.c:730: warning: Function parameter or member 'port' not described in 'tb_init_port' drivers/thunderbolt/switch.c:1348: warning: Function parameter or member 'sw' not described in 'tb_plug_events_active' drivers/thunderbolt/switch.c:1348: warning: Function parameter or member 'active' not described in 'tb_plug_events_active' drivers/thunderbolt/switch.c:2654: warning: Function parameter or member 'sw' not described in 'tb_sw_set_unplugged' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/switch.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index cdba05e72486b..ce1b120d1cd46 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -523,7 +523,7 @@ int tb_port_state(struct tb_port *port) return phy.state; } -/** +/* * tb_wait_for_port() - wait for a port to become ready * * Wait up to 1 second for a port to reach state TB_PORT_UP. If @@ -587,7 +587,7 @@ int tb_wait_for_port(struct tb_port *port, bool wait_if_unplugged) return 0; } -/** +/* * tb_port_add_nfc_credits() - add/remove non flow controlled credits to port * * Change the number of NFC credits allocated to @port by @credits. To remove @@ -644,7 +644,7 @@ int tb_port_set_initial_credits(struct tb_port *port, u32 credits) return tb_port_write(port, &data, TB_CFG_PORT, ADP_CS_5, 1); } -/** +/* * tb_port_clear_counter() - clear a counter in TB_CFG_COUNTER * * Return: Returns 0 on success or an error code on failure. @@ -718,7 +718,7 @@ int tb_port_disable(struct tb_port *port) return __tb_port_enable(port, false); } -/** +/* * tb_init_port() - initialize a port * * This is a helper method for tb_switch_alloc. Does not check or initialize @@ -1337,7 +1337,7 @@ int tb_switch_reset(struct tb_switch *sw) return res.err; } -/** +/* * tb_plug_events_active() - enable/disable plug events on a switch * * Also configures a sane plug_events_delay of 255ms. @@ -2647,7 +2647,7 @@ void tb_switch_remove(struct tb_switch *sw) device_unregister(&sw->dev); } -/** +/* * tb_sw_set_unplugged() - set is_unplugged on switch and downstream switches */ void tb_sw_set_unplugged(struct tb_switch *sw) From patchwork Wed Jan 27 11:25:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E70C433E6 for ; Wed, 27 Jan 2021 11:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 083462075B for ; Wed, 27 Jan 2021 11:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236695AbhA0Lc7 (ORCPT ); Wed, 27 Jan 2021 06:32:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236704AbhA0La4 (ORCPT ); Wed, 27 Jan 2021 06:30:56 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC14C06121F for ; Wed, 27 Jan 2021 03:26:12 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id s24so3110990wmj.0 for ; Wed, 27 Jan 2021 03:26:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yXir64Bzd+GxcWUwcbNEQp4j7KexiYWTQQdXLaxG9xM=; b=SjJfQVN4LTSFL66kig3SXua8oK6mX5lWoDPFQTgmGBBQeO6VGAXx5gw6YgW6qifq5u Ur+obyedN3xqBuv7mY1pTnpyFQFf+/dpBbMAiFc71e3ViXwT4DkUJNIptbT6Z0K9NtUp z4X45gNibPLdT4CYrqaeAgrZJDg46VI92J+Q8mO2UT7Yf/lpCl/GsEGCYivwWCm2WGHH OkpjzWk/y8zFyEue1yrkjPX4BCqB05TGMBMDQ55GoauFiBuOgbhVb4wixzPQkT8IH+mH DoTE95X5RRT1CRjDZ6+c8MAaP8eHx3YpwydJlcw+RdHsYtQ6NMNP2HV+OVrdfP9SdvYK VvLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yXir64Bzd+GxcWUwcbNEQp4j7KexiYWTQQdXLaxG9xM=; b=Or3AjCZulUswD89lgAIvCRlaHVw+mn3gjvkROjPD2YduBOSNNqpdNCEtiMba6Opxem h2zLuCkRAh0/HsZgoP5KpLVBB5VvUaMDINZ9+oJ9SyI5ps6+fhl5iBlcRsN2l+kPC13P 1iF/ldSRgokQEaexPlHVMJHfmJSbQoNERjDffLo1r3u3m0h/ceD8BtflRCGOFjEXM/NY 9RXbkMx2/jVrMvZ3kR4t10ABbBVnNlQITQamnJz6Az6ScifXQF1w8yD/1LzTCAkVT/Nf afvf+0eFE2SxZSim0c3h1KzvOOVNs27tkPrmQYX5X+peSyuScV5kbBTW6p3r1TWVFUGt hMdQ== X-Gm-Message-State: AOAM531bG0jcmmeHYCc/mPIe23KgkNT79jQrNz+0j11WfuiuBi/YLtQA 1w+q4x+Wy2iLigfisd2eC2aPrA== X-Google-Smtp-Source: ABdhPJwGkJ0TXvfcvnLi89Ht5JLXKJ+TqLGZp0ZSYCdl953Pw0BxUPvwbBRH4Sp91og+mDF61+x5qA== X-Received: by 2002:a1c:1f04:: with SMTP id f4mr3839872wmf.98.1611746770928; Wed, 27 Jan 2021 03:26:10 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 10/12] thunderbolt: icm: Fix a couple of formatting issues Date: Wed, 27 Jan 2021 11:25:52 +0000 Message-Id: <20210127112554.3770172-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/icm.c:122: warning: Function parameter or member 'xdomain_connected' not described in 'icm' drivers/thunderbolt/icm.c:122: warning: Function parameter or member 'xdomain_disconnected' not described in 'icm' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/icm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c index b8c4159bc32d0..09c4a84413ec0 100644 --- a/drivers/thunderbolt/icm.c +++ b/drivers/thunderbolt/icm.c @@ -85,8 +85,8 @@ struct usb4_switch_nvm_auth { * @set_uuid: Set UUID for the root switch (optional) * @device_connected: Handle device connected ICM message * @device_disconnected: Handle device disconnected ICM message - * @xdomain_connected - Handle XDomain connected ICM message - * @xdomain_disconnected - Handle XDomain disconnected ICM message + * @xdomain_connected: Handle XDomain connected ICM message + * @xdomain_disconnected: Handle XDomain disconnected ICM message * @rtd3_veto: Handle RTD3 veto notification ICM message */ struct icm { From patchwork Wed Jan 27 11:25:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86EAC433DB for ; Wed, 27 Jan 2021 11:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 830CD20754 for ; Wed, 27 Jan 2021 11:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236891AbhA0Ld0 (ORCPT ); Wed, 27 Jan 2021 06:33:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236749AbhA0LbI (ORCPT ); Wed, 27 Jan 2021 06:31:08 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 395FAC061221 for ; Wed, 27 Jan 2021 03:26:13 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id i9so1317929wmq.1 for ; Wed, 27 Jan 2021 03:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HRGqS1Ub4m0YbvVmKTGmVzBFWciGxN2mIYxOHlmuFFQ=; b=aFxHUHZG0if3sG9m3uw+QqOVHvX6FbbHalFoG7h6dCnk8s42nSq/jKBdsJWQ0Hbq4p Z1SlStAl/veU82UOU+zuLWWwwPLQ3cGM4aWLgam854/2L3ZjWICBDEz8GSvXFWMtWsCw Czr1b/cwT6ymhR4o6GQV05OUSWK+jB0PPmbzyMn97mKM6dRLyTMzBxAm/9pvaE+vm+oV T2X1eeb0gUgd1xgKH2lKqpimfTvBfTzOfy4i8/qK8IEUbSGBt1z/FaOn6uDoIwgZt4sj 362O5PTo2SMXRygxmUwFf4dcnefnUgODnQurChgh1grzCXnDzJn5TQwuWRiFYMVZ8Y4k N77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HRGqS1Ub4m0YbvVmKTGmVzBFWciGxN2mIYxOHlmuFFQ=; b=BwzOdog09/kK6YmQTzkC6jMnXRUa4BvrbQ2BAwuRUd6qd56dQh0Pzm08rq6CEsF1MJ 6BmQMXwz4rwXkVEU3ZXA4c12zpmPFk2pvDsiH6b+3Y9r9NIW5gY4IIPZ6i2ltJ4riD21 SpNYNMSj6CF8BQ1sqdm5dXBKfxHtp7AxqldO+pLD0mZD80OJaec21V5vlfXMygFS1BLp ykrLhbbqPBAOV/eFBXsC/0G2vtXLZOWszT6SHc2uuZU3gTQF7ISEnf0ZvqkRwjQ13BrQ 6TvYC+/Fek10a84s83bayFsuc9j00PQvrZYd2WQv3pstlumXQIRP/Qu8h1vhz902T68c xqNQ== X-Gm-Message-State: AOAM533i8ie2NUSutHTz6JU/hdR9BHO5dzgSAMlucNf9rzuOXvO3Eq6e /OIe0L/9MMQ/Uq9/w5F78SyB1w== X-Google-Smtp-Source: ABdhPJzG1p4TDwfwkVY8TRuVEWbSgCecvhUfiUzcBZpZEG7669W9TlG+ARfXy+Ebey91FVQPSqnGog== X-Received: by 2002:a1c:dd08:: with SMTP id u8mr3766904wmg.121.1611746772007; Wed, 27 Jan 2021 03:26:12 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 11/12] thunderbolt: tunnel: Fix misspelling of 'receive_path' Date: Wed, 27 Jan 2021 11:25:53 +0000 Message-Id: <20210127112554.3770172-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/tunnel.c:841: warning: Function parameter or member 'receive_path' not described in 'tb_tunnel_alloc_dma' drivers/thunderbolt/tunnel.c:841: warning: Excess function parameter 'reveive_path' description in 'tb_tunnel_alloc_dma' Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/tunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/tunnel.c b/drivers/thunderbolt/tunnel.c index dcdf9c7a9caed..37943b0379abc 100644 --- a/drivers/thunderbolt/tunnel.c +++ b/drivers/thunderbolt/tunnel.c @@ -830,7 +830,7 @@ static void tb_dma_init_path(struct tb_path *path, unsigned int isb, * @transmit_path: HopID used for transmitting packets * @receive_ring: NHI ring number used to receive packets from the * other domain. Set to %0 if RX path is not needed. - * @reveive_path: HopID used for receiving packets + * @receive_path: HopID used for receiving packets * * Return: Returns a tb_tunnel on success or NULL on failure. */ From patchwork Wed Jan 27 11:25:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12049781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E40C433E0 for ; Wed, 27 Jan 2021 11:41:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AD4F2076D for ; Wed, 27 Jan 2021 11:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237037AbhA0Llg (ORCPT ); Wed, 27 Jan 2021 06:41:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236726AbhA0La6 (ORCPT ); Wed, 27 Jan 2021 06:30:58 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6553BC061222 for ; Wed, 27 Jan 2021 03:26:14 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id z6so1460838wrq.10 for ; Wed, 27 Jan 2021 03:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bv5N/W3oq+FZm8qEBRC53aadCUOUoa7ywZlmGmPMg74=; b=NK2TtYcdpOgyLLkQQic5gvtjp3/8VGKQr5GZThUNTjyAfO1pmjo7MWJNPtXgzp1KIO CH/gxQzwk618UaXMef+p+VpwV1+QCL7qpDSmAyPucEumV1UqiaH7DTDaqgKHXTvsrUuq ZUV2LNHehwRytkJXIroTKPhKVxMIngXvRJfqY/Wrg5MAML2J4nVbAAoxUBrB5mRfqGUS +M5GjKENRT4PYmWk32VwYzjagB4eh9lvBW2p+NjtmmLlIWF1zDnthz+zIGboKEoFARXI H9zMDaWg2I/bBlN5rCXNsQbgDte/Vr1K57tlWuH+JI4XrfgQYSwMz8vPtcQZqu1PXzvf WQTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bv5N/W3oq+FZm8qEBRC53aadCUOUoa7ywZlmGmPMg74=; b=uCADXv71/7JUgwAenTsOb115cl3z9kWiQOF+U2kw9fxo9JCrdZNrhQEuwg3cHMclYw j5Fr3icq7/5283JwOfJpvag52NnrPXxaw/OWTAn/Wl6KKyC4mbBfhEoitWo6iVapqFke xd1eqA6QHML7113ShX7nwcE/zaUIFRs2DbMkP8BsD4gGcoKpQhrAACZUq+5fTCxKKu2y SzKEbLfI7/M8Sw/+kZvtpy/NyURXxoIGNocDYd5SkbMWsGNRvDLcXXCB97243zZvHqhx rj5mO4X88Ati4fX5bZ2GU5OGtczk9Sf7KgG6xEjl30J9WIRlDz+yIJC10ZC1Emb7qU6G zjqA== X-Gm-Message-State: AOAM533vKEjZA1A6Xfhz9Ssd/gIHV8rn9+nxpEgatVepFzXNj8zsJ6xs XNENtzkrdMiqvgrsjDyUzv9lcA== X-Google-Smtp-Source: ABdhPJybnAUfr55viAi3nE368goiE4XSTFzPj50nTPATCsP9WDIBu1EsnC6PAvP3slyBbDvstAJUXg== X-Received: by 2002:adf:f8c1:: with SMTP id f1mr10664387wrq.76.1611746773216; Wed, 27 Jan 2021 03:26:13 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id m2sm2040065wml.34.2021.01.27.03.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 03:26:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: [PATCH 12/12] thunderbolt: swit: Fix function name in the header Date: Wed, 27 Jan 2021 11:25:54 +0000 Message-Id: <20210127112554.3770172-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/thunderbolt/switch.c:1322: warning: expecting prototype for reset_switch(). Prototype was for tb_switch_reset() instead Cc: Andreas Noever Cc: Michael Jamet Cc: Mika Westerberg Cc: Yehezkel Bernat Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/thunderbolt/switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index ce1b120d1cd46..6a3d5608431f6 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -1313,7 +1313,7 @@ static void tb_dump_switch(const struct tb *tb, const struct tb_switch *sw) } /** - * reset_switch() - reconfigure route, enable and send TB_CFG_PKG_RESET + * tb_switch_reset() - reconfigure route, enable and send TB_CFG_PKG_RESET * @sw: Switch to reset * * Return: Returns 0 on success or an error code on failure.