From patchwork Wed Feb 3 16:54:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064853 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0238FC433E9 for ; Wed, 3 Feb 2021 16:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EFB364F7E for ; Wed, 3 Feb 2021 16:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbhBCQ5k (ORCPT ); Wed, 3 Feb 2021 11:57:40 -0500 Received: from mail-eopbgr60134.outbound.protection.outlook.com ([40.107.6.134]:37202 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231342AbhBCQ4n (ORCPT ); Wed, 3 Feb 2021 11:56:43 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwnRxInHV4DvL8I+Aa1uUAGxJS0uZ4fuaK7LyxRBaoVACHBRjxAll6oeP12x6RZv9CfIfrfyJwMKFrSZVkn3xjoWhc4NcyYwAbwFDS4rkM7Mf85ckrmSRAM2cPtKE3WN/q+BpvkWIBpBS+oR8iAEH4RWclgulMqbmPt3OOroiUqPHbD5y59v8kie888RF+OC50IROq8VOQxYGChmlpDAjEqkAABXErOz/WbKSJUu2GeAWXfpMZAzktKDiMpC2IwXbLAn1pY4kbENa0MeRF4RHbAq4KThHs4wzL3tZxMZybPOmsgoDUbn70dkn5M7j/O8mHetmtokFsabR7dBUQHjDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKobMlmUZCHuwXlAIZFEsm+k37mhXtc3v8hZd1Jag9k=; b=LPsu+haoDPJ5tUBlVbd89jrOegRvH/R6uyVwZypweHr7bUh0RyQ250AM4tk3EPcxT5oPXf55r4RzuC5Ysn3Aa08IGcwNvV5DWtgGqvbcnYtMn8nCd5k+fSQLmDIX9KT7YZaP6wKGidr0IoGnIs/7X0JI6lXoKDCN7f1wTd7bcGR3CmPd3uAIjRJFMa3OKYKQT4lrUZ/wRrBicer7C45BJwKhJF0cqQ5q322O8gx1vb+1CUuEA2lCzK4MJISPZts0avNCKGvF/s6I/EOkDliIHRLSzdOuzMssrpvkxekeYqROtV1a6mbOdvNYBLvuWCF7T5XFy+BobDORVbEOMtJZ5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKobMlmUZCHuwXlAIZFEsm+k37mhXtc3v8hZd1Jag9k=; b=eyZ8LvG20fiwQrtKoeTzCbJzXI8jxoquG4A/REiGL9GUHf/+fix69aW/Jg7fR7yG0Dd2E55zQNGC75KC/pK5SV37mqxSM6oUwUHpNGEzxIoBFdvh3FXCeV8yj2mIlrYzcYxuAeiiEhtbzfIrE3yedKMEx0wIB8o8kjMB3C7wE1I= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:53 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:53 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/7] net: marvell: prestera: bump supported firmware version to 2.5 Date: Wed, 3 Feb 2021 18:54:52 +0200 Message-Id: <20210203165458.28717-2-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4bd69fb8-11cc-4937-f01c-08d8c8649169 X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:102; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QySS4O0hMVthFN9dHUYB4jajJXqozeRM7nROLASdgsvzbrX2tUrHB9tlpsZQlV1uMCXNGCXhZ/crk+ZLgbxYBCnFk8XQXzjRtXaKNbGgnGU0V/TW53m87SUX1Y2DiMcLL2AIVStbwhiu92JMtfjmH9vjkBgVwlFmNZ1yAffsEYpKg8qag3xC1vc1g7uH9aeM63mxx05FIu+jePoOYOp0Rw9SEAaz3PNia/JkfgXyhiuo2OqRsc4BDsJGI/ceNhKsZ0GTFUGwe+r3fQKy2j3m1D4DTZwEWRiPkDFiRKoeVnlSWltl6NoSACZsUVPGycj6cAA8zXpS19vr5qlAXTddplxqeezvg0nK1C3a2ivz66TaWGErwjYj0WWRTRxS49bFvBK8GaHejpiGWPiiAcBV2qy41ih57GILEAuhwtrnLZPLwFWNMQb0Nf2KuYGPmOkGqkhMeIQbZcMJhkvVr6KVD6cWwZcjl1qWFZPJ/x5kU0gi8KVGucNttv5U+yV30XPdpkOjUUJHoerbm5hFt5aHdQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(83380400001)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(4744005)(1076003)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Fyx+UlOBR4tKKAqTwN4/VB3E7uqqKV9XXXFRoL/snrT4UEWA+QxxUqKVH4qDZ78PMtwDTPBm3mZ+eqftyKStYgNZL8PCDLQBrPdNGQQEgR7FFACeH/j874OhiBikWGIjY7DzIAfNcDS/CPXUHb5zDVyOco4wqCYcZLppWg9Fe8lxH0zNHk3cxtOQfY+TGwrwYXP+6ZPj9ThWDhPcYIasDKDYhFF35PnTiQ5DZGSov/kaSvUkX9fos3xmmAzbj/cb+gV/hpKLUK3Z2L5tZ6Ce4/dYe2ls2eH9B3F9pwZ+w/YJ01Z/6S0cmL1j8bNjeaR5J1pqZZUrnqrhPx8bsse3uYx8gnWbruTD6gTQArIrNkOWyQ2srz4scrmypbACcfHNbcnKhvStzDqqleSS7b7fVvL8aFf3u4+w5ntRf+GYHESp621ir+26PQgA7tzgC0KJSwcSVvTLxXxgpJ/ZiedkS55P6UwaI05ytU/myiEZpexqI8IPS5JvttDum5oEaYs1zgXoHJo69vy6t6M4ylovoT7ZxlZ9nwjwJACtjN4vctcvM817ht8Dy3OWrXIh+xGqpBT/mwjrD+I/J2GWWrjoSSihDh0j7AYijMHQUG4yFhRFoaYku9qHjhupwau9zkZG4g83FWpjzL6Qx5Rrf8W4KQ1/xes39KtfbJmlpPB0cbpgZrqhJrryRO3Tny1Slk68Ok4sQdpNo8r4i7OTvgzTyl0sozvBJjGnX6nyPxLWvNo6Pn6Kfx5w/p5LiQgTB7nPSSSfIx+j/vMSMC0ANZj2cKXNUqlCcvhIgKir9kpqsB2ZkSGaqvM58BY+spZePb7dz7YwDETpozK4gXdKL5xgciQ8wOcY/Zu0gbgTTEu8Lfzu+GqaSI3JMfKJhJC0tNZRlmwYEQMz++P/SGvOooQeoEYh32ThUKRXDJuw2Aiy0N2mQgMHP6BzuiRgPV9zwoHrsHg8rfu2BPkRV/AzNkMZ8L0eorksHyDIHnp8/OW4A42QkM65YCZ3Ncouj6nfKpOhcQw28nSkd8SnjJm2cw53X5ct+vA/PpslBjSoWd4wVGFNhv42TbcSQLn5k+PfbxU9mSpgJaeQDjjn8kYBxC/0kZwI765lt+qbnz9VHy8g52eEkkv+PBVywYJ0j3M+J/PlOg3pTG5ch5U1u3BoneCVAthctzRuCBBde4CVtv2psGICHDT817KSxa8pI8HtdO/Qwyw5lkbcF+ktsTMz/SdxdEllSAF7qTTuW0SGqu8rPqFvIoBS33pzidAd9slBdwjylFZzudsrouyYhPwmHdjzp2uni5y/Sttfqo7usag2ufayc0d57fUHfuCfFqUXs5PJ X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd69fb8-11cc-4937-f01c-08d8c8649169 X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:53.6827 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kxlxWAYvLNCcNln5PlTQRr/jxxBxm3HZiUYssZHOGnmZYpBV1GBgN5qLFShuelOrg9BlbVkg6Y2JS0jAn1W4Rnkd101jLeezyJ84+Jbf+zc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org New firmware version has some ABI and feature changes like: - LAG support - initial L3 support - changed events handling logic Signed-off-by: Vadym Kochan --- drivers/net/ethernet/marvell/prestera/prestera_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c index be5677623455..b8a87d249647 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c @@ -14,7 +14,7 @@ #define PRESTERA_MSG_MAX_SIZE 1500 #define PRESTERA_SUPP_FW_MAJ_VER 2 -#define PRESTERA_SUPP_FW_MIN_VER 0 +#define PRESTERA_SUPP_FW_MIN_VER 5 #define PRESTERA_FW_PATH_FMT "mrvl/prestera/mvsw_prestera_fw-v%u.%u.img" From patchwork Wed Feb 3 16:54:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064849 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C43CC433E9 for ; Wed, 3 Feb 2021 16:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CA4464F87 for ; Wed, 3 Feb 2021 16:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbhBCQ5T (ORCPT ); Wed, 3 Feb 2021 11:57:19 -0500 Received: from mail-eopbgr60107.outbound.protection.outlook.com ([40.107.6.107]:21313 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230070AbhBCQ4x (ORCPT ); Wed, 3 Feb 2021 11:56:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjcTkBqlMcA0jwdpEnqh3OLDCdjDZUHwd/vANFNFAvzZYOeFY+pJsHeyFFSlD4c/piL53peatpZ9szculDjcIeuOyhaATsynKGHKbJrMNAES2EFLEX8VFhFMt/OL7Gy9bUFnphYReR9GZ91bnwX1cnL3MUvUIKlYeZnRpt6orNEmovsGcORAMv8aUezKByrGwO7cDeK6yM8pTxp28UVYyzt5TCEjYL4kiXytVYDNrbpCK61y5hnjZ78WtZvibSeRJP3mFryS4vYuu2TyGV0fry/kVThlRtYw6pzJJ705+JKVYLox/pvaXostXTXT6NniNIVUKVSeKTSsJ8SJKFP+9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0S9Hkz7cQJM0ta0QTcwlL9tSkCOPqJNCWO45uI5aBfs=; b=cD6kNEQuwaKSUAs4GmHvOX+xEeRdTTnC9TqxnOnBGd41SHJT46SXBhgOm2Vhx2Q1+dGL0fN5BabmkbtKpuKBDp4XKEnt0PGqRxJD2C6etccwuaj+gMtDW4HE/42LuH+ixF1kICaU6WqdmojMaChOaYeJ6PtzHN3sGyCIE0y6dgUBGYWxCsJcjr2kabOLcmjesUJ7v6Xg4YFtEf6RVhbLMCQjhi23mRzijhmAgAHCmH0r/wwOSDi1e46Licy9HWCfgDHiF0yyQK0SszES3oMP6cX/il3+GFdDhXfiULk8ByYUwNtM5vR7vkl1stwhTronGO+XWZELyCAwh5/sl1TSjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0S9Hkz7cQJM0ta0QTcwlL9tSkCOPqJNCWO45uI5aBfs=; b=ly0mH1Juxg1I7HtX64/gjscoqO1oOcJv/xVUAPiC6nISD/nSfl4zrnIEFP6x9uYB4XK0HYyX5w1l1Dir9hD940JzRch5wwGARb91v/g1ARrVjaQ9RfP0pgdJVSW1UzyVEQtQyJepDG0+7bf2k4dJtcAOzz3u/hYCK6XLwPk7qXk= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:55 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:54 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/7] net: marvell: prestera: disable events interrupt while handling Date: Wed, 3 Feb 2021 18:54:53 +0200 Message-Id: <20210203165458.28717-3-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9294346-1713-4dad-73bf-08d8c8649209 X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1079; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xNYK4e8BndsQu7s/X7gBzVVOS1DV+qYFTRe6XApmiHhJg/IK74pnTIL/qa3HZsrpo3aktKfvRTU1k4v35GnWWe+dY/llNA25kjczwaLoVXvJFRaPsZM6o5cQKfndOL+sLX+rKn8YXBV+qeR1Ub/IfbKbCX00OWPVFIvl+3dmetV9uJ6wHfqZrsoqktWjAjBvwQ64qfB1IEQOCHNGpJ+ZRXplSY8QeUJS+aHLU1U47CIQYC8yYO5VeZSM+EU5lmiSlWDStTJS5JME6bcgOuhWo7g3AqOm3ln/GSAuen9+bvhqJ42ZIj0ummsV/wi8+fYBW9cAuHgmG36Hai/pMZaScvCMuLDIREGB5a2ZIyEupEMGFBoyDUQktOxueArr21WnkbDr78DSu4KeACpgVoIkiu4P36/EvERKdPKpCyCiI4ZBaZlnVvJjNBS2EDgU7MKwetVxcA7bB9rW2SHfr2piOZ8sIN4KGTDY624nIN247gAiFyQpRE+RABfwNuluWVo/feX8GvXGEgTBQWe1v3D/Kw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(1076003)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: veTjTVJO/tg2zNpnxxs5SVVH3rste3q6GAx2cpman2OCHnTHS/PSX+3z4/tvwFB8jQeNuVqcEft3Ax38HTd+RLNwHM04oqaX9UzL+scwQ8ueu2aftqBYcblBZ+qBIGQAvttfQMwoawaemURDzsH/+Ypq46zkm4dLbHi93qAqnkwuq1yCPX2syx052Xp+Etv0GIrvqAku2vBckoR01rPlbzX+A9jlMzETl2mkYqQpJWsYWSC/bNaKRhOoLdQ9AvJayhlxle5Hfwieu+aqoJQaVhjMwvVbfswEd7nbQXWkRzls+BEg/Ec88hkt91pKkbzPjPbPNLZTBdfjCzwkNu5/9t8EM8l7U33KmPDXSaQfxSCjcQAHQmo6oIneC0B4vh7ydWuvsECpPpxj7Y2B4hX6WE/45SuitE5TWWJN/hNFE0yhx66zjVKJpCGJhAZ6SkXiT0eufzenl/cnwRggjH7KCriToRIM2d5sd6fhMZ8msnIaQCSdldZOwcycxv2Nup3U0lrZpnvJWV7vQthA/Ynj+KxdcJiQOST5nzwbIMB8VRo/pydiTv4DvdgnlGGNod36UwNaqiznM4XbYjDbuSakl2glOGI/EQcd095UQipyGjmkzmddWpoxQEjPH9iW9iqqbY5PSaEJltm0VmgO5wHY1Hi2pIuL9iu27IhTrDXzeqB94hcIcklBSIbTr+XQ8b/m24SfoR20L0z+Y5M4dzw8LSlJ067KvEnCJsa7Tsx0eYZ2XjcOfIHlMMynn4+tLWPfcGtmaEx96v8HjOW4u1pP88+Q/hnh5apbTxLP7AgpCbj3Ju1ep1eEesVkdaHbPaR+MOtyaEm5IIKoGjQudcBLKeeRZBRhab7ZYw+pWtq1rkJ9cG43gBrJItmeQ12xlzt/a6ogNn9reeW1NjaN+e1+QM96415JH8Hi+IomDhlpDG5EiiyJUYWdtzTkV3OKVbASWSNnBussjgDJBXVvY6HF9kjjIFXYRzEwEZXg/UGfUS0XMFRlSKW61FXaiMXkov5rY+FcR8Nk6qBkR3+kkgpRteT6VNWX/9H6G3NAEuxAGhmfrsvOBQsKrPJ2J8bC0dbktWZyymulsVwfiyn2lOVKM13nAzZZG4tGBSWrGOYcokrcYTWt/90DKcI3+/o9X72EtN71/3RHkuVxGTbiB8gBPM4HXno23byWGoZRPy+L6ji/s1yKB0jVPtfsqXVoO/iQ7gFBWN0BmtN5tR7llMwMR1HTpFO1aZr9Qjml1mWQ3d1y2E2I03dum1lWbx9D9xiX7NHGyo3W4SWp/s/dfKIgcqPYMtj39C4FM0tZmu+sbzjx6S8ZI3ceh7qkxnOWUDdQ X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: c9294346-1713-4dad-73bf-08d8c8649209 X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:54.8411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SzlNEmmFEsmT9Y8b7GJemDbXQaC2iSuzvHsg1r5I0e0me/vjJJt/RMvmcXSRGCrK1cg0uLWyFKqeoZe91aVqMyoaDOTPv2R6fVlgEK4qtC0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org There are change in firmware which requires that receiver will disable event interrupts before handling them and enable them after finish with handling. Events still may come into the queue but without receiver interruption. Signed-off-by: Vadym Kochan --- .../ethernet/marvell/prestera/prestera_pci.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c index b8a87d249647..f7b27ef02624 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 /* Copyright (c) 2019-2020 Marvell International Ltd. All rights reserved */ +#include #include #include #include @@ -144,6 +145,11 @@ struct prestera_fw_regs { /* PRESTERA_CMD_RCV_CTL_REG flags */ #define PRESTERA_CMD_F_REPL_SENT BIT(0) +#define PRESTERA_FW_EVT_CTL_STATUS_MASK GENMASK(1, 0) + +#define PRESTERA_FW_EVT_CTL_STATUS_ON 0 +#define PRESTERA_FW_EVT_CTL_STATUS_OFF 1 + #define PRESTERA_EVTQ_REG_OFFSET(q, f) \ (PRESTERA_FW_REG_OFFSET(evtq_list) + \ (q) * sizeof(struct prestera_fw_evtq_regs) + \ @@ -260,6 +266,15 @@ static u8 prestera_fw_evtq_pick(struct prestera_fw *fw) return PRESTERA_EVT_QNUM_MAX; } +static void prestera_fw_evt_ctl_status_set(struct prestera_fw *fw, u32 val) +{ + u32 status = prestera_fw_read(fw, PRESTERA_FW_STATUS_REG); + + u32p_replace_bits(&status, val, PRESTERA_FW_EVT_CTL_STATUS_MASK); + + prestera_fw_write(fw, PRESTERA_FW_STATUS_REG, status); +} + static void prestera_fw_evt_work_fn(struct work_struct *work) { struct prestera_fw *fw; @@ -269,6 +284,8 @@ static void prestera_fw_evt_work_fn(struct work_struct *work) fw = container_of(work, struct prestera_fw, evt_work); msg = fw->evt_msg; + prestera_fw_evt_ctl_status_set(fw, PRESTERA_FW_EVT_CTL_STATUS_OFF); + while ((qid = prestera_fw_evtq_pick(fw)) < PRESTERA_EVT_QNUM_MAX) { u32 idx; u32 len; @@ -288,6 +305,8 @@ static void prestera_fw_evt_work_fn(struct work_struct *work) if (fw->dev.recv_msg) fw->dev.recv_msg(&fw->dev, msg, len); } + + prestera_fw_evt_ctl_status_set(fw, PRESTERA_FW_EVT_CTL_STATUS_ON); } static int prestera_fw_wait_reg32(struct prestera_fw *fw, u32 reg, u32 cmp, From patchwork Wed Feb 3 16:54:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064863 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DD7C433DB for ; Wed, 3 Feb 2021 17:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 914BF64E46 for ; Wed, 3 Feb 2021 17:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231592AbhBCRCy (ORCPT ); Wed, 3 Feb 2021 12:02:54 -0500 Received: from mail-eopbgr00096.outbound.protection.outlook.com ([40.107.0.96]:21157 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231638AbhBCQ5W (ORCPT ); Wed, 3 Feb 2021 11:57:22 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmtRBqGS9PH0eg8RuA+gfETCVa8VO68AAZcN2PnO0bQjDhW7am3RUQO9mUtjF3CDD6lTahv/Xu6aw+VX0V/8jWpfrkZg84Uib0u5OE8sk19VQd/z4v2bITZmjsigjE7sBjGjWO5Bet4jxs63O/wkhgw8oWpLdecTPp4Tb/uQGxOkz1hYs41fEuY1OHeoh3fhDrtLN2DMEFGgPyUXyBZoyBQFqnzgwvUdoejlAJWuod9MyCbqh3JFAu7FbgMOK178iPuk9HGg1DlbjdouAmLtVJBI3evyFLDy9E8ouqbt3S46BQL/TGpf7JtHEQCPVnNj+0nqC3gVKA3XLS7WycQdIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qt4Fr/mDQpsiAzypSom9NNyGeswcc1Ph2rQk17+krZw=; b=cH2FrCmNosRZi36ikODXDCFF/CCTMB2RaM9/vbwbm6it8AGfqA51H54pHs1oXiSWopCxs3nQGutKt4qlXBY11jyERFCn2JKKwufaOQhgpN4AAokzCIGsV9yTBIRz9zhuJ7V2juB4RONl8nnlQsGcVThzVk3NYnHDDxVvlQWt8LWPE5DKzQaLklEykdT4ZN6J6o/Z39opG7EQBoHFxFyHB+eC8MBBWTmLLTJPjOR4IfyYqZM57dVLSA+8Z+lBfJ/WYaXEZxlz4S8iqS1l1P7VWmjH2LBXhP1NbayhJO0MTmQ5fWaguh1UZFG6iOIRI2CJ/CNZunOn67SzpisSJ0sT2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qt4Fr/mDQpsiAzypSom9NNyGeswcc1Ph2rQk17+krZw=; b=mWNNwZcrSc42nIEmLVMFU/qCeRY/gw2MngNkypsKkrQmJCmCAIJKkUU75lKxByiqsV3MO27ksoZuE/hCL8EqE+bDXhAmTd6mwlRRKMW25nealyxJh0UYvZzd36RtZMsLYYvdOZRc0dEbNmngBABfyNlclQNEevh38BHPwFOJ/Eg= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:56 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:56 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/7] net: marvell: prestera: add support for AC3X 98DX3265 device Date: Wed, 3 Feb 2021 18:54:54 +0200 Message-Id: <20210203165458.28717-4-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f5e14c1-d549-4a74-32e1-08d8c86492ba X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: arRaOu19TmOSAkXw8HPBryU6KIJ0FRcG66shKWTf0kNj4CDYoEE0dfzVhzplosEtvtBhMsy3Ns48kWrn78pWHDEhME6dG9hOaMdLGeItbcjDBPdCLv0ENT1Cd/7aVi1zC2XF+jU580CKLgWJT1EoGf6oNSlmONDZ59zHZWRG98RMilYTUUbF9IDA2rUf+H4vpuaBaSndwq2KSCupeX81Q+65DV847gLkhlNumLutfORnDT47BqQrw3AGMLmsmxsb0K95DOrMPPmUykrAbC5y7UX0GQhq4OGDLlUjOOss1N2rlycmQqTxYgzUd/xJdrqvIwXkE/8FwF/xPh/fGkBrO2Pezb8+zbNHgpXTiwIMzj1x/5raLWY1V1bpkQfXhPIc0kU0U7kpCxBsjT+mZxfDIoS1MtKdkzDIs+1DDZNXknAOJA3OBXkvxFqTsEDtLIaXgWh3e/fduaLXLkUPgvT4WKu5Sx+IQjfaNVn6bRRYUga8HEXClXVhHOXy5rPCvI+gEtNFkup96RpKAMRKaGjMM5mjSQkERUIcNGP/l4yWQSH/P0YopiAyOk4YZNeQ3vZ3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(4744005)(1076003)(66476007)(32563001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 2Usf4O6smNVKM1qeYFJcg7p89D47XjQwqgVx6kCrtP0MkEz4I3JXZfSVcvvAOtpFYqv3sxunNH0oX5yU8xtqNIJk7MRB35nEmTbd8wprGAezKmc4riNtySbef317gRulIj/MLYnmNI9U7qsjylp90w8zfnAaMcc5nnjsEbe7NeCGxnUlqjqJnQrg80sRiydMRICwgVPWfL7/6Fff/7EA2Ih9MYNkAa5EDAiy/Fpi+0TY4Qy99AHd0Pl2wixIoqdFnVmc8Fzf21DHlGVEKz3qHllKyggzKESwWpy9VKyLC+SbIuGKvbqGmGOQlS+2Wfre937rJ0LA3to09xZ/7foQlfkI6w002uoAvjROK3bfGjIqmu2sEJc8qh9FuHtqb07p/mJctEQOYB5d6CTuDsuzjqnRDPn3FHpODMU2AOiszI97MBDf/JgMDTslewluDEL/a6LCiz3AVZfBcH2QtSpvlHLvR1WGQeyRNGhS4EWaRBsrB9hmPsor5RdjwLiPT9viNrDzrWpV4K/axFRj5mCu58d9CAinYf10rUDatCGRNMYFb9CDkveqRbIv9vEZWDl9ZILoTEX1n2zOJvUe4vyfm8wWQHI2wQChMHks4oIlUZ9NsJN098bifA81nLMnS2WlIo0CNL9WJ+r+YUStGtX7w/WYyrWNMfAudCQI07ZJgw802l6fV6jYr9A4YszDpG8xHCHwaX+ujZqfQxb0O7ezXIBowyvmDEMiqxpH8GUhwReH5Zskj3X399LTSj6iAq9YcAZAWNZW1PeqDnNR/nLTgGJbI/byu5WDnKSOEVS1PBpwyEeYV2wGULONqW9rV27elME5PBXi6yvJNKwasUSdVh9lNhvUWC5teL4TXRsImbGkj7Lm7F864FOHSIauS8rDA2JIySmnxTSLc412+h5Yz8gKPeR/kU/OQrjCGzBBmB/zjuC1RXmfM5g1PcwoR+Ym7LfVWJpROrkWoqPO7okfSG+aLehVQWE28tahmpwJoK19kHFjWnzdyDsONKuvDlgaW7LDEmxYnRoqwCEVRyphVFAiZus+tlvwGBhiSRaChLiGckgKBRA4KDn99GysIFQt1qcbMTJ+925KYyyK0u+2Agm/z1GgOEtqMx6gd4V2s75qykMrF85qyo3uiiQ+p3Hmj5KQPtfq+cv/TurOaqNcUzA3kC+P8mk0OtEIegSZd7QvHuBnE7QRzonBASguaJZAnZaujssw26uRYCdHjxavircLX8Nv/+dP2Ouia6b7DZ9Jw3gDy/qyUcgqfso+4pAeQBUB59rQMmcVs040G35mbEf+WOwtHBHctYgPP1WR+mYEYVACb2kQUfukM3Gbxoxk X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 4f5e14c1-d549-4a74-32e1-08d8c86492ba X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:55.9074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hqi2QemnSAtuWHBammvSWyHhi37s0IdIOfenGGJIoyJeS89b7yUKUyShJ1YgRuBt/YxjpbySq+v+BXRMouQiZXrokhjVrgjwqtD79kw+ILg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Add PCI match for AC3X 98DX3265 device which is supported by the current driver and firmware. Signed-off-by: Vadym Kochan --- drivers/net/ethernet/marvell/prestera/prestera_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c index f7b27ef02624..b698a6b4a985 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c @@ -775,6 +775,7 @@ static void prestera_pci_remove(struct pci_dev *pdev) static const struct pci_device_id prestera_pci_devices[] = { { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0xC804) }, + { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0xC80C) }, { } }; MODULE_DEVICE_TABLE(pci, prestera_pci_devices); From patchwork Wed Feb 3 16:54:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064855 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1575DC433DB for ; Wed, 3 Feb 2021 16:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D83A64F7C for ; Wed, 3 Feb 2021 16:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231757AbhBCQ57 (ORCPT ); Wed, 3 Feb 2021 11:57:59 -0500 Received: from mail-eopbgr60134.outbound.protection.outlook.com ([40.107.6.134]:37202 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231626AbhBCQ5X (ORCPT ); Wed, 3 Feb 2021 11:57:23 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZ8hSfdYDqDjMIyhROFf4uhvkpIJYujc0/KcYGWm9GHFdPfpiuk5WVPp43Nuf4zIqkvIMuxicmaTAMvU4fA8u7gQJf2HpD4UjZtOYGKETvWel3AV83bjhG80CyCOdpKN1hsEGTPwzKtRfoTc+HZ9ox3Ql+wjWVJhsoco2dLFKn9JURF0ZhwoeXK7fpk7gD/FDaD44mlMdoNgRSfh+EMnVwjjET8XE0PXW8f2+3JDlXgbGh5yw0/InUj97YC2IUqvhfp2knmLYk7rTV0gltswOYxSA9k/HIDoQTsr8DdKvsof8CovNLTh+OlT96BzEccsWJ8OyJYKsrewmLjTxzqBwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0vJ3vUe+yGLGK4KPjKLp8fvM//b/UxaH0M9lH0L42A=; b=Ixaby4TaLhh5G/XfCY/FrQyW1SYatPj1L4BCUcVX8wT4jiS8E3qO1uNFZ5T7nadr6H4oBbBCYsuk28uK5vDGXY73YJd9N2g3UHA/jpdJNmVQLN2zLNQ/qxTMq2kh+6Ur5YDksOgerlsztgA4FbgBfW4Wgpw/jLBq2fdW6SUscuQ6u0uNFr7zucrHpfOXcBcG4UoShGW8JOQjB8kWwxKZZEG6QpH00DYyz5ut76DNaMm8/AoUmPJfckaHZWfN40B6uvNFP3C8cfrzQvQ3wgNM2r0wiE3UYLJlTQ3qyr1SDEjj75UcofjIKKzbjImD7fB9txWx/kPqeKPd27YTsVYHaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H0vJ3vUe+yGLGK4KPjKLp8fvM//b/UxaH0M9lH0L42A=; b=oNftFO7tcAEOfXT5JYI0bYII4/hPpKOPEBuUPhjBz7qP5AzEvWY6nSnxPrinEadUlIXk6fNLslXwSPI1JJAHyW6B9aW7C69cVL+dsLO6Nv3PMydiVfjLeFiTW+zqrsq5ghus25QG//8KU1ucbZihC5nkfOOM2mKqQGxs0xj6Fpo= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:57 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:57 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/7] net: marvell: prestera: move netdev topology validation to prestera_main Date: Wed, 3 Feb 2021 18:54:55 +0200 Message-Id: <20210203165458.28717-5-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e1237ee0-668c-470e-33ff-08d8c864935f X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GA1Wx/aQJ4pJZXZ7ivCXIGbLarXYZoBJTMI3KDnuI9BYYmrINipf0dHYVbe8vuAzvWNjiqw7JWTv/DJmkJwAYoIls9SM0/hUUV1cjxxb++/x+1Gi5c0uvdTE4uXUab9n2sYqtdeMhLV/61qYD2N+5Ji1GCn7YRZ/jFYF5zNaCEJNDhUmR7ohxVwiWL+Nv+x99QPS/pY5MHJKzTAFT9na+IjfOnsW2ftjBn4lj6GcAhh2WUOrqPjYwSuhI6ojOy2EVNYOwq3NS7c/wQMt5iAOizk9P9uQlrC9yPd48NYI61B+cu07O1l3VTtncDndIOkiZ3lpiS7BJe2lpuRJTXjxybtB/yN66R+URmVsOeBiE6QFuf8nUOa9errRQRb+6i81PlZOGCrYx9m+lFNWFKkmvM0ZXlYsueRV9DQ3jEY9Mf1vtLkt2rNt856DXxUt3rBV4npsamtc4pA+AjXnDKqN0/XMKIN1rqY6CPnYS24icMqAkuM35JX7PByMqwQlcJNC1Q6PpE++aHr8UlzzNMLB6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(83380400001)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(1076003)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: +yb1JFngi7vfhw+BRK3GJ5cPSZ1ph24b7gro+u0zxbVa8KaL/8I7gp78Qbd68qPn/3KqMxMtnU9j5JrcJ8JoFyUg7Mt/TZrpyr319VM0ceyjUEfErvKRpMW/BnCLU31xuNdY32W3/9YRXpL3LGUU8fCcm5gDz1IxoFPAQLXyBKwFmsfeZwuP/tAsZTbFgCxXv47lf2+rs8Z5oINMVV8qzlQcU5nDjxzKsLz2D8PB1TZ/sM2rfzZ3dbsr9yPenPHM0RlnaDGn0CkE1V8cwd2XmaDl3JKxd6aCb+157p6eck6MDkJeg4+MMJJi50P7drvuJHigYI3bkqGkMdN1qJy9UlD19U68+z6C0Vw7mXdnQfi1OF01aI4UeRRi/bYMLY04SGwOMN5wM7rfEtAEFoEGw1YTlnpnuDGQl2nnBXeLWp1rXUszxEKdsFQBYMa5v1XsvfQdWovFn+EeswcuXXPyfVesq6zoPMeS8TkRyOKiviJqWtl2lRKMKaCVazL+nUrlIv7ahxvYaQY4fsk8vXgXTl4mTBJh+bFj8HBOKUAAEycPaaups6Ms+qG9yZkwqvx6Smogmq4783U8GQvWrhuwIs8qsf4EIWzSWCxzcWnNxqnWWykxJ5tzdJXhbQl6rLg+IU232Yj/JWHkgXj40PiOFtVkId0o4KMkVs3XyYX74JULSu01fyk0W/PkGCDuDUlbuTTchmjQHt1MlTk6wqpjCy/ePGrsRtvBm8xDSTSN0XGepz5ZnOxhOt5JMbad5BSaV9Cx7lOPhxw7vRezZ0l2WPUoRwSO/P9Jj1sZOqB5u2bHGroemO3jOh94/Y+rV907MhH5KwdH352B2P+WuIzbhRT2sWHhHOigQBizRCUVvCow3zcWUDi2mufG3UINeA4qnivn9pKobU4Akb/BN53CIAZw537J6EZzisRBO4o3YJIyOo1pI8Q+Iz5SdYMtTMHH3X0iRijMmkPzm2goVbxGJkOLo/lpA3vi4IXQihljKpgGRBg6Rjo/fb4J+j7leL7h7+/JpurIYCuDfa1byLT3JDAPhmlDnXTpMgEQhr8CaRPdrelhgoEFjKmZnps2QTJgiG5CcrK3gVQU+aFXK0evZB/JtD5F7LvP0WNL30ZoTXi28vvEmtj3dsnzMjs0oQp0fF134P38k+8XGj/KeBLLIzM0eZtRfbztyu6FY+RIrTKtE7U2s43uvP+Vm8OryuGqJaPoCVvQDigoBH5ErKrF+yL3CCvO7OJ5WQisd0tng787zmN4xFsI6oCA5K091efN3vsfWE2w/LsLLbMDhPaDeX139qw0m3TW1YKG1fCc6PnscyQ0r4nD3GPF4o5EjyV+ X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: e1237ee0-668c-470e-33ff-08d8c864935f X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:56.9618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FOm+U6vuBzT1ZXaejl7mPSidsdkTOc7g1pTzw04ntgPrHcbNPTs89IbWAdxbDvHUaHhbgOaRRTGCDEXASxzQ6+qMNPASNic1o5D/kB1zPMg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Move handling of PRECHANGEUPPER event from prestera_switchdev to prestera_main which is responsible for basic netdev events handling and routing them to related module. Signed-off-by: Vadym Kochan Reviewed-by: Vladimir Oltean --- .../ethernet/marvell/prestera/prestera_main.c | 29 +++++++++++++++++-- .../marvell/prestera/prestera_switchdev.c | 20 ------------- 2 files changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 25dd903a3e92..53c7628a3938 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -510,13 +510,36 @@ struct prestera_port *prestera_port_dev_lower_find(struct net_device *dev) static int prestera_netdev_port_event(struct net_device *dev, unsigned long event, void *ptr) { + struct netdev_notifier_changeupper_info *info = ptr; + struct netlink_ext_ack *extack; + struct net_device *upper; + + extack = netdev_notifier_info_to_extack(&info->info); + upper = info->upper_dev; + switch (event) { case NETDEV_PRECHANGEUPPER: + if (!netif_is_bridge_master(upper)) { + NL_SET_ERR_MSG_MOD(extack, "Unknown upper device type"); + return -EINVAL; + } + + if (!info->linking) + break; + + if (netdev_has_any_upper_dev(upper)) { + NL_SET_ERR_MSG_MOD(extack, "Upper device is already enslaved"); + return -EINVAL; + } + break; + case NETDEV_CHANGEUPPER: - return prestera_bridge_port_event(dev, event, ptr); - default: - return 0; + if (netif_is_bridge_master(upper)) + return prestera_bridge_port_event(dev, event, ptr); + break; } + + return 0; } static int prestera_netdev_event_handler(struct notifier_block *nb, diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c index 8c2b03151736..7736d5f498c9 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c @@ -537,35 +537,15 @@ int prestera_bridge_port_event(struct net_device *dev, unsigned long event, void *ptr) { struct netdev_notifier_changeupper_info *info = ptr; - struct netlink_ext_ack *extack; struct prestera_port *port; struct net_device *upper; int err; - extack = netdev_notifier_info_to_extack(&info->info); port = netdev_priv(dev); upper = info->upper_dev; switch (event) { - case NETDEV_PRECHANGEUPPER: - if (!netif_is_bridge_master(upper)) { - NL_SET_ERR_MSG_MOD(extack, "Unknown upper device type"); - return -EINVAL; - } - - if (!info->linking) - break; - - if (netdev_has_any_upper_dev(upper)) { - NL_SET_ERR_MSG_MOD(extack, "Upper device is already enslaved"); - return -EINVAL; - } - break; - case NETDEV_CHANGEUPPER: - if (!netif_is_bridge_master(upper)) - break; - if (info->linking) { err = prestera_port_bridge_join(port, upper); if (err) From patchwork Wed Feb 3 16:54:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064857 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A713C433E6 for ; Wed, 3 Feb 2021 16:58:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEEE764E46 for ; Wed, 3 Feb 2021 16:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231394AbhBCQ62 (ORCPT ); Wed, 3 Feb 2021 11:58:28 -0500 Received: from mail-eopbgr60107.outbound.protection.outlook.com ([40.107.6.107]:21313 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230070AbhBCQ5c (ORCPT ); Wed, 3 Feb 2021 11:57:32 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwGX2TLo+EtSp/r/qAtn3+x+lzb7Vv//JUlW6ZqQnNDpoGYcuJutFx3Pkank6oaTDPdFosasZRFobGdKqN7QQzsNxg8QnuxQNKkq170+rY6q7PmquQsXdymHGCOTE6c0iV+33xtintfmJibExCldkwXRj2Y3ztFJP1bYBbHWVqC6UIA8DjVsOOUKTGG4W6wU5sKkuaxQYuogQhiluZq8ADU6O9WuTJOeANrdw2XRup6siFfFXLa+rb45PuYaRl3LxHaRPqnMFfXEQXyx9gsCinaqyziwb7aMefll2CAnNr6CbXDtVoiCaykkKXRK7AaYgmJyWe5ntfq4z9+3/K6Lqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mc9UlU1qnjKE/hKVAU0Vimn26h85YaJesg93lsuAZA=; b=AMOkrx8zqKv8l1jjYrNuI5aCM4hP40AncH7tnWeUq70l+/qXSZDMzKriBcWIJlHNw1uDxwt0KqYtG8aJLLqqc4Hfsx76+WsLStjMemTYIUYEETo40vY3C8dD19rleALiWZonI0xgEL2ewKLAMBfGJk11ia90jpz3TFszwW3RG9G9M0QOytFoml9ZPeE/GthgIt8W+5UIGWB6bWgRGsS0rYr1B9WD7hukokbzE5VvTX986yQwMG8rT9in6G4oLprh8GvFv5YMTiDnmCTlI+94d5lLi3H1I0EMxbdo/wxZ78H++9+DqZ611cpwPXYrLOHeZKVwQXOV6C1kX7Nk6qkkNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9mc9UlU1qnjKE/hKVAU0Vimn26h85YaJesg93lsuAZA=; b=pAyLZ7haVHz6/LEjwM6QexYUynyfsury4pNOCu4pox7opSNeLAESzSf7oHrps0Xx9JCMeQSfK8tHBukDa+var7x2rOvbBalU1ga+8KhC75oed1eFsIoUs8w9SIMLhSviaBLwPjLb7n4q1D9iRlVva5/vIjdBXIYMpLJcJ24P1rs= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:58 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:58 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org, Andrii Savka Subject: [PATCH net-next 5/7] net: marvell: prestera: add LAG support Date: Wed, 3 Feb 2021 18:54:56 +0200 Message-Id: <20210203165458.28717-6-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25441b93-1359-42d3-f7a1-08d8c864940d X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bH5zGna/rHImBowPh0Oj2yNEykRBheUu4g79b7XYl9Q5jAaBWbbnwjHbVPFi5Y6knoxGPB9DE6tmYodOl9CM8rZNJcWY4Sq1lyfqS45OX+w42qnFuaBJ3x739fX1kPnTmeleZxxzsYBVC3bXw1cPznKZ1WKNy0NeUuuGj0+Y0MgScyxMKbGtTkInfHxOFViMU3Ne16eMdfEe4yu8DGfeAH2cah+5ARJPsyeDoNClV6gvlIfxJIvEhyPi+/tkPDDT83ij1Rnjiu6fVpRqpIrBy9Vsbt3se78i9lwBzoWaW3wPDqvV1r/eNy8X95+mE3/W80keBVsISjJBxg4BLvsbwqtLsXq7znO7wtFlqTRGxx+luTITTVyPQfdp0RkrcJcmsvgbjZskD+/hDcEgCRDxK3Dxdn9r55mev51sLd1pd9q7c0memuFDEx3U7q0S3a2MJuzDTlRTneXMaCu5fnhsk/OstdZDA0QRqDTuxhEt1LE8BiuA7VODGNjtM9RHGAEn172JrNovjXM4dU+XSgyNRE81jfkCHWr/bf5AcRBQ4h00gvLtj0TQ1563gHmsS2uRtMOWkiRW52a2178UVSU4ZA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(83380400001)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(30864003)(26005)(6512007)(52116002)(107886003)(2906002)(316002)(2616005)(66946007)(8936002)(1076003)(66476007)(309714004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: ctb4fT+A8eFsXsse16QOPO2Gxzg4ys3MY87gZm9JVHZ0ZXLIUkrZopn2a0wuiBj5cL4pEOXqWca8FKpKTeMqlD2k5B5BkDpx0l+owj35F2pga5noC/QeUPzzeuu1eTkySQYt5MbWf8B6z2xiLJ8R89eFxq+PthsHkGOCtlxyelDM/YiXY2P0Aaxg2/4khYpHHHWHcAP7QQik1zbxNnnVyBtpcLuh7iW//v+tkS6Q3sutlRzxqqSq5VPyiBuiTVTYCqtqhWNlzws0KuyiAqcurmGJW2KEEfelBEl8ry/JYZhftXbK59yUle+6CgBIEEAkDvfkN+4FwdRRBZr2/39ASz3HDlYOfW+umgyV6YYB3YxTyAMcH3U9JxbV7gHiglu46nJfrh7ftSuvs0VA72psJ8HxYYR1iIsyphjJMmKnFN3Gy+uozr2hrfeW5zDf3hWMRwjfie6vTOou3rIogSBscjep1oiZDeRo/MXKL6NogRrndJOFHXnRdLWulTSzVMSjCnl6CanZHusKt3RevfNplXczIlcFGWe8ltIX5lvzaga8/j694IUbmVooxsS6iqpBb1IdrsuI3oWnEn9q/dhxugewNoUSoD1AUOIaMNgAotFgYhi6ptBf7ilgetmUryuRpbBjYbjelmSIS2SX75bOBzf+VhoBFfxHzLE5sos/8KVr+jdfwi6+jcKcVzs1f4vgvmWcidii48jG1xPtL56v6uMCkKSq1K1AbCKZG38dK2KVW9oyIk7IYmMrKKyPtoWaW4fjJb1t4FcHY5Smwz7ASlslkhTNBUWZ89VUR5EAnQitGP0Z3s/SUGvv0lT6DXEllIF5cE8dYLOvIHv18wGmr+Au3TRGrUqDVz5LG2UZJIJSXkx/EA2A+onw0rb+uMUazrizRdOVUMToWk95TYbpkAMvd+rtavTHHFAja/zymRr47M7WK4axXl7YlDG5zyv+PVjtjPe/ZOiI8Ensyd9C0hc0VOjBVt0agUVyRZY7qOVpAxk5UVEZUukL/TqND250vQftLhpfk4Ql7n801gyZrv8oGlCIbTEZyv3oo0x8JkabZfBWrJSgFVNKIhrHHCnfoXH3XxIJP348BcZMn+ekLwt26pEx2j2EyZR3j9pQADpzScmram6BkXtQjFK30ts0QxKfP8SCgeNpxItBcsE9YU6oE7GrD398uZkAWHu1QdFSIWobw/QNowCGzoW9mlhUmqE9jKLTayKIdviLcVbNkDCFwwqVBe8un2IvVMqlFE1erqCo5JwcWWz8RmoR+ox1q+lZ9ICQElb8alyKtaXKMaOXWXD8Zv8ewt33rtAynumEtZJCDQ8cfXHfGRcgw6JN X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 25441b93-1359-42d3-f7a1-08d8c864940d X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:58.1551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1V2wxUAJNAOnjk2wDzSBxVCXeajekbA9C+/rqoGZ38QobN1yaDCdL8va3NL4LthD+S5uFzmUR5zFAQvD/zcZUqVSfirF+S7ytHMoprs0wBY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Serhiy Boiko The following features are supported: - LAG basic operations - create/delete LAG - add/remove a member to LAG - enable/disable member in LAG - LAG Bridge support - LAG VLAN support - LAG FDB support Limitations: - Only HASH lag tx type is supported - The Hash parameters are not configurable. They are applied during the LAG creation stage. - Enslaving a port to the LAG device that already has an upper device is not supported. Co-developed-by: Andrii Savka Signed-off-by: Andrii Savka Signed-off-by: Serhiy Boiko Signed-off-by: Vadym Kochan --- .../net/ethernet/marvell/prestera/prestera.h | 30 ++- .../ethernet/marvell/prestera/prestera_hw.c | 180 ++++++++++++- .../ethernet/marvell/prestera/prestera_hw.h | 14 + .../ethernet/marvell/prestera/prestera_main.c | 247 +++++++++++++++++- .../marvell/prestera/prestera_switchdev.c | 109 ++++++-- .../marvell/prestera/prestera_switchdev.h | 4 +- 6 files changed, 538 insertions(+), 46 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera.h b/drivers/net/ethernet/marvell/prestera/prestera.h index 55aa4bf8a27c..ad0f33a7e517 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera.h +++ b/drivers/net/ethernet/marvell/prestera/prestera.h @@ -60,10 +60,19 @@ struct prestera_port_caps { u8 transceiver; }; +struct prestera_lag { + struct net_device *dev; + struct list_head members; + u16 member_count; + u16 lag_id; +}; + struct prestera_port { struct net_device *dev; struct prestera_switch *sw; struct devlink_port dl_port; + struct list_head lag_member; + struct prestera_lag *lag; u32 id; u32 hw_id; u32 dev_id; @@ -127,6 +136,12 @@ struct prestera_port_event { } data; }; +enum prestera_fdb_entry_type { + PRESTERA_FDB_ENTRY_TYPE_REG_PORT, + PRESTERA_FDB_ENTRY_TYPE_LAG, + PRESTERA_FDB_ENTRY_TYPE_MAX +}; + enum prestera_fdb_event_id { PRESTERA_FDB_EVENT_UNSPEC, PRESTERA_FDB_EVENT_LEARNED, @@ -134,7 +149,11 @@ enum prestera_fdb_event_id { }; struct prestera_fdb_event { - u32 port_id; + enum prestera_fdb_entry_type type; + union { + u32 port_id; + u16 lag_id; + } dest; u32 vid; union { u8 mac[ETH_ALEN]; @@ -165,6 +184,9 @@ struct prestera_switch { u32 mtu_min; u32 mtu_max; u8 id; + struct prestera_lag *lags; + u8 lag_member_max; + u8 lag_max; }; struct prestera_rxtx_params { @@ -203,4 +225,10 @@ int prestera_port_pvid_set(struct prestera_port *port, u16 vid); bool prestera_netdev_check(const struct net_device *dev); +bool prestera_port_is_lag_member(const struct prestera_port *port); + +struct prestera_lag *prestera_lag_by_id(struct prestera_switch *sw, u16 id); + +u16 prestera_port_lag_id(const struct prestera_port *port); + #endif /* _PRESTERA_H_ */ diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.c b/drivers/net/ethernet/marvell/prestera/prestera_hw.c index 0424718d5998..8afb45f66862 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.c @@ -39,6 +39,11 @@ enum prestera_cmd_type_t { PRESTERA_CMD_TYPE_RXTX_INIT = 0x800, PRESTERA_CMD_TYPE_RXTX_PORT_INIT = 0x801, + PRESTERA_CMD_TYPE_LAG_MEMBER_ADD = 0x900, + PRESTERA_CMD_TYPE_LAG_MEMBER_DELETE = 0x901, + PRESTERA_CMD_TYPE_LAG_MEMBER_ENABLE = 0x902, + PRESTERA_CMD_TYPE_LAG_MEMBER_DISABLE = 0x903, + PRESTERA_CMD_TYPE_STP_PORT_SET = 0x1000, PRESTERA_CMD_TYPE_ACK = 0x10000, @@ -127,6 +132,12 @@ enum { PRESTERA_FC_SYMM_ASYMM, }; +enum { + PRESTERA_HW_FDB_ENTRY_TYPE_REG_PORT = 0, + PRESTERA_HW_FDB_ENTRY_TYPE_LAG = 1, + PRESTERA_HW_FDB_ENTRY_TYPE_MAX = 2, +}; + struct prestera_fw_event_handler { struct list_head list; struct rcu_head rcu; @@ -168,6 +179,8 @@ struct prestera_msg_switch_init_resp { u32 port_count; u32 mtu_max; u8 switch_id; + u8 lag_max; + u8 lag_member_max; }; struct prestera_msg_port_autoneg_param { @@ -249,8 +262,13 @@ struct prestera_msg_vlan_req { struct prestera_msg_fdb_req { struct prestera_msg_cmd cmd; u8 dest_type; - u32 port; - u32 dev; + union { + struct { + u32 port; + u32 dev; + }; + u16 lag_id; + } dest; u8 mac[ETH_ALEN]; u16 vid; u8 dynamic; @@ -293,6 +311,13 @@ struct prestera_msg_rxtx_port_req { u32 dev; }; +struct prestera_msg_lag_req { + struct prestera_msg_cmd cmd; + u32 port; + u32 dev; + u16 lag_id; +}; + struct prestera_msg_event { u16 type; u16 id; @@ -315,7 +340,10 @@ union prestera_msg_event_fdb_param { struct prestera_msg_event_fdb { struct prestera_msg_event id; u8 dest_type; - u32 port_id; + union { + u32 port_id; + u16 lag_id; + } dest; u32 vid; union prestera_msg_event_fdb_param param; }; @@ -386,7 +414,19 @@ static int prestera_fw_parse_fdb_evt(void *msg, struct prestera_event *evt) { struct prestera_msg_event_fdb *hw_evt = msg; - evt->fdb_evt.port_id = hw_evt->port_id; + switch (hw_evt->dest_type) { + case PRESTERA_HW_FDB_ENTRY_TYPE_REG_PORT: + evt->fdb_evt.type = PRESTERA_FDB_ENTRY_TYPE_REG_PORT; + evt->fdb_evt.dest.port_id = hw_evt->dest.port_id; + break; + case PRESTERA_HW_FDB_ENTRY_TYPE_LAG: + evt->fdb_evt.type = PRESTERA_FDB_ENTRY_TYPE_LAG; + evt->fdb_evt.dest.lag_id = hw_evt->dest.lag_id; + break; + default: + return -EINVAL; + } + evt->fdb_evt.vid = hw_evt->vid; ether_addr_copy(evt->fdb_evt.data.mac, hw_evt->param.mac); @@ -531,6 +571,8 @@ int prestera_hw_switch_init(struct prestera_switch *sw) sw->mtu_min = PRESTERA_MIN_MTU; sw->mtu_max = resp.mtu_max; sw->id = resp.switch_id; + sw->lag_member_max = resp.lag_member_max; + sw->lag_max = resp.lag_max; return 0; } @@ -1067,8 +1109,10 @@ int prestera_hw_fdb_add(struct prestera_port *port, const unsigned char *mac, u16 vid, bool dynamic) { struct prestera_msg_fdb_req req = { - .port = port->hw_id, - .dev = port->dev_id, + .dest = { + .dev = port->dev_id, + .port = port->hw_id, + }, .vid = vid, .dynamic = dynamic, }; @@ -1083,8 +1127,10 @@ int prestera_hw_fdb_del(struct prestera_port *port, const unsigned char *mac, u16 vid) { struct prestera_msg_fdb_req req = { - .port = port->hw_id, - .dev = port->dev_id, + .dest = { + .dev = port->dev_id, + .port = port->hw_id, + }, .vid = vid, }; @@ -1094,11 +1140,48 @@ int prestera_hw_fdb_del(struct prestera_port *port, const unsigned char *mac, &req.cmd, sizeof(req)); } +int prestera_hw_lag_fdb_add(struct prestera_switch *sw, u16 lag_id, + const unsigned char *mac, u16 vid, bool dynamic) +{ + struct prestera_msg_fdb_req req = { + .dest_type = PRESTERA_HW_FDB_ENTRY_TYPE_LAG, + .dest = { + .lag_id = lag_id, + }, + .vid = vid, + .dynamic = dynamic, + }; + + ether_addr_copy(req.mac, mac); + + return prestera_cmd(sw, PRESTERA_CMD_TYPE_FDB_ADD, + &req.cmd, sizeof(req)); +} + +int prestera_hw_lag_fdb_del(struct prestera_switch *sw, u16 lag_id, + const unsigned char *mac, u16 vid) +{ + struct prestera_msg_fdb_req req = { + .dest_type = PRESTERA_HW_FDB_ENTRY_TYPE_LAG, + .dest = { + .lag_id = lag_id, + }, + .vid = vid, + }; + + ether_addr_copy(req.mac, mac); + + return prestera_cmd(sw, PRESTERA_CMD_TYPE_FDB_DELETE, + &req.cmd, sizeof(req)); +} + int prestera_hw_fdb_flush_port(struct prestera_port *port, u32 mode) { struct prestera_msg_fdb_req req = { - .port = port->hw_id, - .dev = port->dev_id, + .dest = { + .dev = port->dev_id, + .port = port->hw_id, + }, .flush_mode = mode, }; @@ -1121,8 +1204,10 @@ int prestera_hw_fdb_flush_port_vlan(struct prestera_port *port, u16 vid, u32 mode) { struct prestera_msg_fdb_req req = { - .port = port->hw_id, - .dev = port->dev_id, + .dest = { + .dev = port->dev_id, + .port = port->hw_id, + }, .vid = vid, .flush_mode = mode, }; @@ -1131,6 +1216,37 @@ int prestera_hw_fdb_flush_port_vlan(struct prestera_port *port, u16 vid, &req.cmd, sizeof(req)); } +int prestera_hw_fdb_flush_lag(struct prestera_switch *sw, u16 lag_id, + u32 mode) +{ + struct prestera_msg_fdb_req req = { + .dest_type = PRESTERA_HW_FDB_ENTRY_TYPE_LAG, + .dest = { + .lag_id = lag_id, + }, + .flush_mode = mode, + }; + + return prestera_cmd(sw, PRESTERA_CMD_TYPE_FDB_FLUSH_PORT, + &req.cmd, sizeof(req)); +} + +int prestera_hw_fdb_flush_lag_vlan(struct prestera_switch *sw, + u16 lag_id, u16 vid, u32 mode) +{ + struct prestera_msg_fdb_req req = { + .dest_type = PRESTERA_HW_FDB_ENTRY_TYPE_LAG, + .dest = { + .lag_id = lag_id, + }, + .vid = vid, + .flush_mode = mode, + }; + + return prestera_cmd(sw, PRESTERA_CMD_TYPE_FDB_FLUSH_PORT_VLAN, + &req.cmd, sizeof(req)); +} + int prestera_hw_bridge_create(struct prestera_switch *sw, u16 *bridge_id) { struct prestera_msg_bridge_resp resp; @@ -1212,6 +1328,46 @@ int prestera_hw_rxtx_port_init(struct prestera_port *port) &req.cmd, sizeof(req)); } +int prestera_hw_lag_member_add(struct prestera_port *port, u16 lag_id) +{ + struct prestera_msg_lag_req req = { + .port = port->hw_id, + .dev = port->dev_id, + .lag_id = lag_id, + }; + + return prestera_cmd(port->sw, PRESTERA_CMD_TYPE_LAG_MEMBER_ADD, + &req.cmd, sizeof(req)); +} + +int prestera_hw_lag_member_del(struct prestera_port *port, u16 lag_id) +{ + struct prestera_msg_lag_req req = { + .port = port->hw_id, + .dev = port->dev_id, + .lag_id = lag_id, + }; + + return prestera_cmd(port->sw, PRESTERA_CMD_TYPE_LAG_MEMBER_DELETE, + &req.cmd, sizeof(req)); +} + +int prestera_hw_lag_member_enable(struct prestera_port *port, u16 lag_id, + bool enable) +{ + struct prestera_msg_lag_req req = { + .port = port->hw_id, + .dev = port->dev_id, + .lag_id = lag_id, + }; + u32 cmd; + + cmd = enable ? PRESTERA_CMD_TYPE_LAG_MEMBER_ENABLE : + PRESTERA_CMD_TYPE_LAG_MEMBER_DISABLE; + + return prestera_cmd(port->sw, cmd, &req.cmd, sizeof(req)); +} + int prestera_hw_event_handler_register(struct prestera_switch *sw, enum prestera_event_type type, prestera_event_cb_t fn, diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.h b/drivers/net/ethernet/marvell/prestera/prestera_hw.h index b2b5ac95b4e3..68ce41595349 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.h +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.h @@ -179,4 +179,18 @@ int prestera_hw_rxtx_init(struct prestera_switch *sw, struct prestera_rxtx_params *params); int prestera_hw_rxtx_port_init(struct prestera_port *port); +/* LAG API */ +int prestera_hw_lag_member_add(struct prestera_port *port, u16 lag_id); +int prestera_hw_lag_member_del(struct prestera_port *port, u16 lag_id); +int prestera_hw_lag_member_enable(struct prestera_port *port, u16 lag_id, + bool enable); +int prestera_hw_lag_fdb_add(struct prestera_switch *sw, u16 lag_id, + const unsigned char *mac, u16 vid, bool dynamic); +int prestera_hw_lag_fdb_del(struct prestera_switch *sw, u16 lag_id, + const unsigned char *mac, u16 vid); +int prestera_hw_fdb_flush_lag(struct prestera_switch *sw, u16 lag_id, + u32 mode); +int prestera_hw_fdb_flush_lag_vlan(struct prestera_switch *sw, + u16 lag_id, u16 vid, u32 mode); + #endif /* _PRESTERA_HW_H_ */ diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 53c7628a3938..39465e65d09b 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -8,6 +8,7 @@ #include #include #include +#include #include "prestera.h" #include "prestera_hw.h" @@ -281,6 +282,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id) INIT_LIST_HEAD(&port->vlans_list); port->pvid = PRESTERA_DEFAULT_VID; + port->lag = NULL; port->dev = dev; port->id = id; port->sw = sw; @@ -474,6 +476,151 @@ static int prestera_switch_set_base_mac_addr(struct prestera_switch *sw) return prestera_hw_switch_mac_set(sw, sw->base_mac); } +struct prestera_lag *prestera_lag_by_id(struct prestera_switch *sw, u16 id) +{ + return id < sw->lag_max ? &sw->lags[id] : NULL; +} + +static struct prestera_lag *prestera_lag_by_dev(struct prestera_switch *sw, + struct net_device *dev) +{ + struct prestera_lag *lag; + u16 id; + + for (id = 0; id < sw->lag_max; id++) { + lag = &sw->lags[id]; + if (lag->dev == dev) + return lag; + } + + return NULL; +} + +static struct prestera_lag *prestera_lag_create(struct prestera_switch *sw, + struct net_device *lag_dev) +{ + struct prestera_lag *lag; + u16 id; + + for (id = 0; id < sw->lag_max; id++) { + lag = &sw->lags[id]; + if (!lag->dev) + break; + } + if (lag) { + INIT_LIST_HEAD(&lag->members); + lag->dev = lag_dev; + } + + return lag; +} + +static void prestera_lag_destroy(struct prestera_switch *sw, + struct prestera_lag *lag) +{ + WARN_ON(!list_empty(&lag->members)); + lag->member_count = 0; + lag->dev = NULL; +} + +static int prestera_lag_port_add(struct prestera_port *port, + struct net_device *lag_dev) +{ + struct prestera_switch *sw = port->sw; + struct prestera_lag *lag; + int err; + + lag = prestera_lag_by_dev(sw, lag_dev); + if (!lag) { + lag = prestera_lag_create(sw, lag_dev); + if (!lag) + return -ENOMEM; + } + + if (lag->member_count >= sw->lag_member_max) + return -ENOMEM; + + err = prestera_hw_lag_member_add(port, lag->lag_id); + if (err) { + if (!lag->member_count) + prestera_lag_destroy(sw, lag); + return err; + } + + list_add(&port->lag_member, &lag->members); + lag->member_count++; + port->lag = lag; + + return 0; +} + +static int prestera_lag_port_del(struct prestera_port *port) +{ + struct prestera_switch *sw = port->sw; + struct prestera_lag *lag = port->lag; + int err; + + if (!lag || !lag->member_count) + return -EINVAL; + + err = prestera_hw_lag_member_del(port, lag->lag_id); + if (err) + return err; + + list_del(&port->lag_member); + lag->member_count--; + port->lag = NULL; + + if (netif_is_bridge_port(lag->dev)) { + struct netdev_notifier_changeupper_info br_info; + + br_info.upper_dev = netdev_master_upper_dev_get(lag->dev); + br_info.linking = false; + + prestera_bridge_port_event(lag->dev, port->dev, + NETDEV_CHANGEUPPER, &br_info); + } + + if (!lag->member_count) + prestera_lag_destroy(sw, lag); + + return 0; +} + +bool prestera_port_is_lag_member(const struct prestera_port *port) +{ + return !!port->lag; +} + +u16 prestera_port_lag_id(const struct prestera_port *port) +{ + return port->lag->lag_id; +} + +static int prestera_lag_init(struct prestera_switch *sw) +{ + u16 id; + + sw->lags = kcalloc(sw->lag_max, sizeof(*sw->lags), GFP_KERNEL); + if (!sw->lags) + return -ENOMEM; + + for (id = 0; id < sw->lag_max; id++) + sw->lags[id].lag_id = id; + + return 0; +} + +static void prestera_lag_fini(struct prestera_switch *sw) +{ + u8 idx; + + for (idx = 0; idx < sw->lag_max; idx++) + WARN_ON(sw->lags[idx].member_count); + + kfree(sw->lags); +} + bool prestera_netdev_check(const struct net_device *dev) { return dev->netdev_ops == &prestera_netdev_ops; @@ -507,19 +654,54 @@ struct prestera_port *prestera_port_dev_lower_find(struct net_device *dev) return port; } -static int prestera_netdev_port_event(struct net_device *dev, +static int prestera_netdev_port_lower_event(struct net_device *dev, + unsigned long event, void *ptr) +{ + struct netdev_notifier_changelowerstate_info *info = ptr; + struct netdev_lag_lower_state_info *lower_state_info; + struct prestera_port *port = netdev_priv(dev); + bool enabled; + + if (!netif_is_lag_port(dev)) + return 0; + if (!prestera_port_is_lag_member(port)) + return 0; + + lower_state_info = info->lower_state_info; + enabled = lower_state_info->tx_enabled; + + return prestera_hw_lag_member_enable(port, port->lag->lag_id, enabled); +} + +static bool prestera_lag_master_check(struct net_device *lag_dev, + struct netdev_lag_upper_info *info, + struct netlink_ext_ack *ext_ack) +{ + if (info->tx_type != NETDEV_LAG_TX_TYPE_HASH) { + NL_SET_ERR_MSG_MOD(ext_ack, "Unsupported LAG Tx type"); + return false; + } + + return true; +} + +static int prestera_netdev_port_event(struct net_device *lower, + struct net_device *dev, unsigned long event, void *ptr) { struct netdev_notifier_changeupper_info *info = ptr; + struct prestera_port *port = netdev_priv(dev); struct netlink_ext_ack *extack; struct net_device *upper; + int err; extack = netdev_notifier_info_to_extack(&info->info); upper = info->upper_dev; switch (event) { case NETDEV_PRECHANGEUPPER: - if (!netif_is_bridge_master(upper)) { + if (!netif_is_bridge_master(upper) && + !netif_is_lag_master(upper)) { NL_SET_ERR_MSG_MOD(extack, "Unknown upper device type"); return -EINVAL; } @@ -531,12 +713,60 @@ static int prestera_netdev_port_event(struct net_device *dev, NL_SET_ERR_MSG_MOD(extack, "Upper device is already enslaved"); return -EINVAL; } + + if (netif_is_lag_master(upper) && + !prestera_lag_master_check(upper, info->upper_info, extack)) + return -EINVAL; + if (netif_is_lag_master(upper) && vlan_uses_dev(dev)) { + NL_SET_ERR_MSG_MOD(extack, + "Master device is a LAG master and port has a VLAN"); + return -EINVAL; + } + if (netif_is_lag_port(dev) && is_vlan_dev(upper) && + !netif_is_lag_master(vlan_dev_real_dev(upper))) { + NL_SET_ERR_MSG_MOD(extack, + "Can not put a VLAN on a LAG port"); + return -EINVAL; + } break; case NETDEV_CHANGEUPPER: if (netif_is_bridge_master(upper)) - return prestera_bridge_port_event(dev, event, ptr); + return prestera_bridge_port_event(lower, dev, event, + ptr); + + if (netif_is_lag_master(upper)) { + if (info->linking) { + err = prestera_lag_port_add(port, upper); + if (err) + return err; + } else { + prestera_lag_port_del(port); + } + } break; + + case NETDEV_CHANGELOWERSTATE: + return prestera_netdev_port_lower_event(dev, event, ptr); + } + + return 0; +} + +static int prestera_netdevice_lag_event(struct net_device *lag_dev, + unsigned long event, void *ptr) +{ + struct net_device *dev; + struct list_head *iter; + int err; + + netdev_for_each_lower_dev(lag_dev, dev, iter) { + if (prestera_netdev_check(dev)) { + err = prestera_netdev_port_event(lag_dev, dev, event, + ptr); + if (err) + return err; + } } return 0; @@ -549,7 +779,9 @@ static int prestera_netdev_event_handler(struct notifier_block *nb, int err = 0; if (prestera_netdev_check(dev)) - err = prestera_netdev_port_event(dev, event, ptr); + err = prestera_netdev_port_event(dev, dev, event, ptr); + else if (netif_is_lag_master(dev)) + err = prestera_netdevice_lag_event(dev, event, ptr); return notifier_from_errno(err); } @@ -603,6 +835,10 @@ static int prestera_switch_init(struct prestera_switch *sw) if (err) goto err_dl_register; + err = prestera_lag_init(sw); + if (err) + goto err_lag_init; + err = prestera_create_ports(sw); if (err) goto err_ports_create; @@ -610,6 +846,8 @@ static int prestera_switch_init(struct prestera_switch *sw) return 0; err_ports_create: + prestera_lag_fini(sw); +err_lag_init: prestera_devlink_unregister(sw); err_dl_register: prestera_event_handlers_unregister(sw); @@ -627,6 +865,7 @@ static int prestera_switch_init(struct prestera_switch *sw) static void prestera_switch_fini(struct prestera_switch *sw) { prestera_destroy_ports(sw); + prestera_lag_fini(sw); prestera_devlink_unregister(sw); prestera_event_handlers_unregister(sw); prestera_rxtx_switch_fini(sw); diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c index 7736d5f498c9..3750c66a550b 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c @@ -180,6 +180,45 @@ prestera_port_vlan_create(struct prestera_port *port, u16 vid, bool untagged) return ERR_PTR(err); } +static int prestera_fdb_add(struct prestera_port *port, + const unsigned char *mac, u16 vid, bool dynamic) +{ + if (prestera_port_is_lag_member(port)) + return prestera_hw_lag_fdb_add(port->sw, prestera_port_lag_id(port), + mac, vid, dynamic); + else + return prestera_hw_fdb_add(port, mac, vid, dynamic); +} + +static int prestera_fdb_del(struct prestera_port *port, + const unsigned char *mac, u16 vid) +{ + if (prestera_port_is_lag_member(port)) + return prestera_hw_lag_fdb_del(port->sw, prestera_port_lag_id(port), + mac, vid); + else + return prestera_hw_fdb_del(port, mac, vid); +} + +static int prestera_fdb_flush_port_vlan(struct prestera_port *port, u16 vid, + u32 mode) +{ + if (prestera_port_is_lag_member(port)) + return prestera_hw_fdb_flush_lag_vlan(port->sw, prestera_port_lag_id(port), + vid, mode); + else + return prestera_hw_fdb_flush_port_vlan(port, vid, mode); +} + +static int prestera_fdb_flush_port(struct prestera_port *port, u32 mode) +{ + if (prestera_port_is_lag_member(port)) + return prestera_hw_fdb_flush_lag(port->sw, prestera_port_lag_id(port), + mode); + else + return prestera_hw_fdb_flush_port(port, mode); +} + static void prestera_port_vlan_bridge_leave(struct prestera_port_vlan *port_vlan) { @@ -199,11 +238,11 @@ prestera_port_vlan_bridge_leave(struct prestera_port_vlan *port_vlan) last_port = port_count == 1; if (last_vlan) - prestera_hw_fdb_flush_port(port, fdb_flush_mode); + prestera_fdb_flush_port(port, fdb_flush_mode); else if (last_port) prestera_hw_fdb_flush_vlan(port->sw, vid, fdb_flush_mode); else - prestera_hw_fdb_flush_port_vlan(port, vid, fdb_flush_mode); + prestera_fdb_flush_port_vlan(port, vid, fdb_flush_mode); list_del(&port_vlan->br_vlan_head); prestera_bridge_vlan_put(br_vlan); @@ -394,9 +433,9 @@ prestera_bridge_port_add(struct prestera_bridge *bridge, struct net_device *dev) } static int -prestera_bridge_1d_port_join(struct prestera_bridge_port *br_port) +prestera_bridge_1d_port_join(struct prestera_bridge_port *br_port, + struct prestera_port *port) { - struct prestera_port *port = netdev_priv(br_port->dev); struct prestera_bridge *bridge = br_port->bridge; int err; @@ -423,6 +462,7 @@ prestera_bridge_1d_port_join(struct prestera_bridge_port *br_port) } static int prestera_port_bridge_join(struct prestera_port *port, + struct net_device *lower, struct net_device *upper) { struct prestera_switchdev *swdev = port->sw->swdev; @@ -437,7 +477,7 @@ static int prestera_port_bridge_join(struct prestera_port *port, return PTR_ERR(bridge); } - br_port = prestera_bridge_port_add(bridge, port->dev); + br_port = prestera_bridge_port_add(bridge, lower); if (IS_ERR(br_port)) { err = PTR_ERR(br_port); goto err_brport_create; @@ -446,7 +486,7 @@ static int prestera_port_bridge_join(struct prestera_port *port, if (bridge->vlan_enabled) return 0; - err = prestera_bridge_1d_port_join(br_port); + err = prestera_bridge_1d_port_join(br_port, port); if (err) goto err_port_join; @@ -459,19 +499,17 @@ static int prestera_port_bridge_join(struct prestera_port *port, return err; } -static void prestera_bridge_1q_port_leave(struct prestera_bridge_port *br_port) +static void prestera_bridge_1q_port_leave(struct prestera_bridge_port *br_port, + struct prestera_port *port) { - struct prestera_port *port = netdev_priv(br_port->dev); - - prestera_hw_fdb_flush_port(port, PRESTERA_FDB_FLUSH_MODE_ALL); + prestera_fdb_flush_port(port, PRESTERA_FDB_FLUSH_MODE_ALL); prestera_port_pvid_set(port, PRESTERA_DEFAULT_VID); } -static void prestera_bridge_1d_port_leave(struct prestera_bridge_port *br_port) +static void prestera_bridge_1d_port_leave(struct prestera_bridge_port *br_port, + struct prestera_port *port) { - struct prestera_port *port = netdev_priv(br_port->dev); - - prestera_hw_fdb_flush_port(port, PRESTERA_FDB_FLUSH_MODE_ALL); + prestera_fdb_flush_port(port, PRESTERA_FDB_FLUSH_MODE_ALL); prestera_hw_bridge_port_delete(port, br_port->bridge->bridge_id); } @@ -506,6 +544,7 @@ static int prestera_port_vid_stp_set(struct prestera_port *port, u16 vid, } static void prestera_port_bridge_leave(struct prestera_port *port, + struct net_device *lower, struct net_device *upper) { struct prestera_switchdev *swdev = port->sw->swdev; @@ -516,16 +555,16 @@ static void prestera_port_bridge_leave(struct prestera_port *port, if (!bridge) return; - br_port = __prestera_bridge_port_by_dev(bridge, port->dev); + br_port = __prestera_bridge_port_by_dev(bridge, lower); if (!br_port) return; bridge = br_port->bridge; if (bridge->vlan_enabled) - prestera_bridge_1q_port_leave(br_port); + prestera_bridge_1q_port_leave(br_port, port); else - prestera_bridge_1d_port_leave(br_port); + prestera_bridge_1d_port_leave(br_port, port); prestera_hw_port_learning_set(port, false); prestera_hw_port_flood_set(port, false); @@ -533,8 +572,8 @@ static void prestera_port_bridge_leave(struct prestera_port *port, prestera_bridge_port_put(br_port); } -int prestera_bridge_port_event(struct net_device *dev, unsigned long event, - void *ptr) +int prestera_bridge_port_event(struct net_device *lower, struct net_device *dev, + unsigned long event, void *ptr) { struct netdev_notifier_changeupper_info *info = ptr; struct prestera_port *port; @@ -547,11 +586,11 @@ int prestera_bridge_port_event(struct net_device *dev, unsigned long event, switch (event) { case NETDEV_CHANGEUPPER: if (info->linking) { - err = prestera_port_bridge_join(port, upper); + err = prestera_port_bridge_join(port, lower, upper); if (err) return err; } else { - prestera_port_bridge_leave(port, upper); + prestera_port_bridge_leave(port, lower, upper); } break; } @@ -745,9 +784,9 @@ static int prestera_port_fdb_set(struct prestera_port *port, vid = bridge->bridge_id; if (adding) - err = prestera_hw_fdb_add(port, fdb_info->addr, vid, false); + err = prestera_fdb_add(port, fdb_info->addr, vid, false); else - err = prestera_hw_fdb_del(port, fdb_info->addr, vid); + err = prestera_fdb_del(port, fdb_info->addr, vid); return err; } @@ -1088,10 +1127,26 @@ static void prestera_fdb_event(struct prestera_switch *sw, struct prestera_event *evt, void *arg) { struct switchdev_notifier_fdb_info info; + struct net_device *dev = NULL; struct prestera_port *port; + struct prestera_lag *lag; - port = prestera_find_port(sw, evt->fdb_evt.port_id); - if (!port) + switch (evt->fdb_evt.type) { + case PRESTERA_FDB_ENTRY_TYPE_REG_PORT: + port = prestera_find_port(sw, evt->fdb_evt.dest.port_id); + if (port) + dev = port->dev; + break; + case PRESTERA_FDB_ENTRY_TYPE_LAG: + lag = prestera_lag_by_id(sw, evt->fdb_evt.dest.lag_id); + if (lag) + dev = lag->dev; + break; + default: + return; + } + + if (!dev) return; info.addr = evt->fdb_evt.data.mac; @@ -1103,11 +1158,11 @@ static void prestera_fdb_event(struct prestera_switch *sw, switch (evt->id) { case PRESTERA_FDB_EVENT_LEARNED: call_switchdev_notifiers(SWITCHDEV_FDB_ADD_TO_BRIDGE, - port->dev, &info.info, NULL); + dev, &info.info, NULL); break; case PRESTERA_FDB_EVENT_AGED: call_switchdev_notifiers(SWITCHDEV_FDB_DEL_TO_BRIDGE, - port->dev, &info.info, NULL); + dev, &info.info, NULL); break; } diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.h b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.h index 606e21d2355b..70e9ed87e24a 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.h +++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.h @@ -7,7 +7,7 @@ int prestera_switchdev_init(struct prestera_switch *sw); void prestera_switchdev_fini(struct prestera_switch *sw); -int prestera_bridge_port_event(struct net_device *dev, unsigned long event, - void *ptr); +int prestera_bridge_port_event(struct net_device *lower, struct net_device *dev, + unsigned long event, void *ptr); #endif /* _PRESTERA_SWITCHDEV_H_ */ From patchwork Wed Feb 3 16:54:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064861 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEAAC433E6 for ; Wed, 3 Feb 2021 17:00:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0773E64F87 for ; Wed, 3 Feb 2021 17:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbhBCRAp (ORCPT ); Wed, 3 Feb 2021 12:00:45 -0500 Received: from mail-eopbgr00102.outbound.protection.outlook.com ([40.107.0.102]:12569 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231346AbhBCQ6Y (ORCPT ); Wed, 3 Feb 2021 11:58:24 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcOpSeYYs2upq9Vs3nh1WpQudJbNbC0GgWLf4Yn0oUKmvuarONaTC3mlhxjvQAPNbXp5ZR1An6X6B32ANiOgQyo/veD/Vx+YqnHVpqnGAEWfIHT/RJiWNUkAJxMRw9CWXwztpYd5XUE0F7IpJ4oxV856VQmw7ZXxDURkgz1ltT7vcmxbilej5AjrDDxxcmaVAUMcEwDlGWmNbzvKvILdVPvV47frbGzxMn5D+IdT0ZQnNDkxUD5LtW2c66pyk9T8daEE0ltWvUWcSDJFbSSoK2BjT8a5wTg+hE81IoYd57Q7rHfadfcmxNQ5lUKm9o7ZvNgjs2VzabRUg2o835Q89Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zpfapr/sa3BpW0murgJm1XZxqAkEZMYlcfEr0buk54g=; b=BJiNAgR7oWZ+87XXDrG7LGzzfkU6FsqYJEWcPQ99cm3+BztYw1aaFGoJB0Y1Uiw3792bN3X9JLMRcPQ6yJAdbbOlMRBSGRVDVmO4iPhu0IS/Yh48Q+JgAblTd/FuKRStGEG/YoTnn3qS6OZL8GbG/9Rcr4hbKKHHbIiOLLQWB5cPT80uI00jImgHYR08WtT7VPzNVrccPDFTYEbtuJCLweqqMzPVdJiLPGCw2rdWKKGOZ1x+Ntd0dGUBCK3TyptJtlvGwXyR4EbK94De21uLHyWaovEf0HylR7RORznzVtJh8xi3uhR345x9EfpD67sOofbFCMfrZhWO0PAoWZL4/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zpfapr/sa3BpW0murgJm1XZxqAkEZMYlcfEr0buk54g=; b=tSzTIQEF6y0HeD7GZ9UO0pFKEnqQ/WwALbwvPzo0TYend6QArhxtOon6GolLq6JcKzpaZzm+6nMbOcBqsX927piXrsuib/aakUDSp03FquBtd2q6DQHSihycTKAICYo1oolB+WPIMtCbW7VkRTjiuGtwYkiXgnl5V4bAz1w94h4= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:55:59 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:55:59 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 6/7] net: marvell: prestera: align flood setting according to latest firmware version Date: Wed, 3 Feb 2021 18:54:57 +0200 Message-Id: <20210203165458.28717-7-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:58 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea929631-b43e-48cf-3581-08d8c86494b2 X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:644; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HSNauWN7h6pYwnZ8GNYVhzk++neyOaB3ySV6+o5RRNMfLSTlSb4GZsmuZd94p2FlZYVMJVaOAzwBd90hyGg+aJ3xN58+ZUrPLaBeBy8QoZ8FtHMJdgMqRldbH2JWoK02Pu5iQaZX3NC7BXNKvEGi3tUYOJSs/m21sQIfiJHXsu+qQ6cfARwjRK71fRP7sIM0VL56aveJp6GgVPloxfPxXGMJrGCHGNDnyaEa6kGEduZniZ/91Hk4ocmTLz7bNMnUQZgkaVKBGoK4x1sYMu1zdj9JOu1txckPzXCcL5flcTjLL/i94cceQA/MOi+EPdApjiorXCW6l7VG9i4sSgwqOAm/ZiYV5afKOyaC/tc5hweWUmmw8xwrZqL+enPvFsSRpdG90xLB1dcpFQEKuue/hLdRSiX+gPY0wWRx83xzhw7y4C9WSXxH6oqJEC9ekykCXSNLmKdpJ2qc5/sAv2Os2P3q8o2ej4JM79mwzcDMASpsZmwSjBAmCmXmXjtlD6pC+tY6UWokmfjHu0jtOTJv1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(83380400001)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(1076003)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: zVoe7KahsrwTzzMoLCk1ZlsY+n4mGTTnmBFyV62ANzKJ+WthXWxUCTPL2MQK/Yc7scxB0hYC1vJG+SNfRlZthA7axqvqCbt850uK45QQnlu/IhFkmHyYyeAaRZOCd7bYw1KU0aM5CxOLILBKYsTNBav2u01b8bBhUqUvvjhngt9wxuMdhEvVlb/R2e9g2KGKeWEpjTAyC35CRiaoCmuMSkiVBbtzay/9Hsr13zN/yOO54F+Pdi5OdwZczQGjD9oEzF5n6cYl/5i8ruHj+ZYcc9HXiOt91RF5USRIXDhW7RSUD2CJ73R0hDCjzWB+y9D8nOi7drm7vPgmIepsdcBfvwrd7+BhOxPk9vUru16NyjepbeXM00YuhiZ4aHusoNcbmtvs2RDMH+EYw1QkDKq28b0KZeBGpMnF2nIWBoppPCPWZPkIhMRHP9cOKNgX8bYooMdFp/swtIzr99JCx3/NKH87pqG+j89qTYgZRvdjXGQkhYvJhmC7/BCzvERiaP9qo562F63nka0VhTS27m3K7oBr6hh1rj7xTuelYkbk0u8Y1G2oaL39FSwkB4snzT+N6zrdlIFchuCAvf8XFChCHLcsVWvzgZU/BySzTxhIZJHdcwVNN0iS8hlxpX8GFrwSiAEo2n9bjt9mRGiRb1v+YBitXF2iVhEekt2wrPHE1s7Jzu6UWj0Gb4OK7gaD5ptEO+2adxvJ7Cg/DUQfwfOEXwhUsFX2wkH6w55SxU4OYbaM7XC7F/PqZaO/52kBMerTsqW89SWI69FCCwofg72Az3BFF52SSahNqQ0vNlXQ7XR5AWKQAVa6vzzz6XiXU4l4sVkgpp1aiIsGIdmWbAwCPmlQWQqVWwhgoL3Q9RwMNPmcfDuNgcKoZ0nWtpoIv/stnlgokLX0bkIWdJlbAfTWHjIQ/v24oakNMVR0RoPnq6oNzBVGjAe3HDgd6BBevwhepPf1vz5vCYzuW0FDhMn30ZFgC6J+UBK2dBDUzs+Z4988ZE7WXgRyiu8Q9m7CFa1axB4SwtxZGaiGy+aB7R0rAn328luuvH6YKEApW86nHDy6K5HFbeA5cbZvGF2wmTJSfJxZ47esuu2+ILDJa3eI2pBEctf3frvP+/4eCSHZGt17ukxQI2TatdK3p+8bvrQieJOMPFJd208B1MmlyR4ss3quRLppCrFAsjTcWJYZYMESxH5BqLo1taVxFpSXn36qFPR5lUA+rktRPfPQGSZ59J12ZfVJ4hyEGao3f9sM85RIF6FXTV42vMcW6TGoeInB0tdZYNEb0pdJZaT/yKHxaTNqi0HS9+YDf6ZAGMaRui8rBypwRVxU6ci7d1saLlW7 X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: ea929631-b43e-48cf-3581-08d8c86494b2 X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:55:59.1815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uJ6vqzai84J3pIqRnNEC4ibADpR2lW/nUkM2jB9j9TLelmRRQH4BZp8fZaSreILldxNdtZCPg/tcoixuBYUZpbyvRwHyLc+G3xCO4wWYqCI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Latest FW IPC floow message format was changed to configure uc/mc flooding separately, so change code according to this. Signed-off-by: Vadym Kochan --- .../ethernet/marvell/prestera/prestera_hw.c | 37 +++++++++++++-- .../ethernet/marvell/prestera/prestera_hw.h | 3 +- .../marvell/prestera/prestera_switchdev.c | 46 +++++++++++++++---- 3 files changed, 72 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.c b/drivers/net/ethernet/marvell/prestera/prestera_hw.c index 8afb45f66862..75034dcb3649 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.c @@ -90,6 +90,11 @@ enum { PRESTERA_PORT_TP_AUTO, }; +enum { + PRESTERA_PORT_FLOOD_TYPE_UC = 0, + PRESTERA_PORT_FLOOD_TYPE_MC = 1, +}; + enum { PRESTERA_PORT_GOOD_OCTETS_RCV_CNT, PRESTERA_PORT_BAD_OCTETS_RCV_CNT, @@ -201,6 +206,11 @@ struct prestera_msg_port_mdix_param { u8 admin_mode; }; +struct prestera_msg_port_flood_param { + u8 type; + u8 enable; +}; + union prestera_msg_port_param { u8 admin_state; u8 oper_state; @@ -209,7 +219,6 @@ union prestera_msg_port_param { u8 accept_frm_type; u32 speed; u8 learning; - u8 flood; u32 link_mode; u8 type; u8 duplex; @@ -218,6 +227,7 @@ union prestera_msg_port_param { struct prestera_msg_port_mdix_param mdix; struct prestera_msg_port_autoneg_param autoneg; struct prestera_msg_port_cap_param cap; + struct prestera_msg_port_flood_param flood; }; struct prestera_msg_port_attr_req { @@ -1030,14 +1040,35 @@ int prestera_hw_port_learning_set(struct prestera_port *port, bool enable) &req.cmd, sizeof(req)); } -int prestera_hw_port_flood_set(struct prestera_port *port, bool flood) +int prestera_hw_port_uc_flood_set(struct prestera_port *port, bool flood) +{ + struct prestera_msg_port_attr_req req = { + .attr = PRESTERA_CMD_PORT_ATTR_FLOOD, + .port = port->hw_id, + .dev = port->dev_id, + .param = { + .flood = { + .type = PRESTERA_PORT_FLOOD_TYPE_UC, + .enable = flood, + } + } + }; + + return prestera_cmd(port->sw, PRESTERA_CMD_TYPE_PORT_ATTR_SET, + &req.cmd, sizeof(req)); +} + +int prestera_hw_port_mc_flood_set(struct prestera_port *port, bool flood) { struct prestera_msg_port_attr_req req = { .attr = PRESTERA_CMD_PORT_ATTR_FLOOD, .port = port->hw_id, .dev = port->dev_id, .param = { - .flood = flood, + .flood = { + .type = PRESTERA_PORT_FLOOD_TYPE_MC, + .enable = flood, + } } }; diff --git a/drivers/net/ethernet/marvell/prestera/prestera_hw.h b/drivers/net/ethernet/marvell/prestera/prestera_hw.h index 68ce41595349..03b52db6f359 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_hw.h +++ b/drivers/net/ethernet/marvell/prestera/prestera_hw.h @@ -138,7 +138,8 @@ int prestera_hw_port_mdix_get(const struct prestera_port *port, u8 *status, int prestera_hw_port_mdix_set(const struct prestera_port *port, u8 mode); int prestera_hw_port_speed_get(const struct prestera_port *port, u32 *speed); int prestera_hw_port_learning_set(struct prestera_port *port, bool enable); -int prestera_hw_port_flood_set(struct prestera_port *port, bool flood); +int prestera_hw_port_uc_flood_set(struct prestera_port *port, bool flood); +int prestera_hw_port_mc_flood_set(struct prestera_port *port, bool flood); int prestera_hw_port_accept_frm_type(struct prestera_port *port, enum prestera_accept_frm_type type); /* Vlan API */ diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c index 3750c66a550b..8449539fe944 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c @@ -443,9 +443,13 @@ prestera_bridge_1d_port_join(struct prestera_bridge_port *br_port, if (err) return err; - err = prestera_hw_port_flood_set(port, br_port->flags & BR_FLOOD); + err = prestera_hw_port_uc_flood_set(port, br_port->flags & BR_FLOOD); if (err) - goto err_port_flood_set; + goto err_port_uc_flood_set; + + err = prestera_hw_port_mc_flood_set(port, br_port->flags & BR_MCAST_FLOOD); + if (err) + goto err_port_mc_flood_set; err = prestera_hw_port_learning_set(port, br_port->flags & BR_LEARNING); if (err) @@ -454,8 +458,10 @@ prestera_bridge_1d_port_join(struct prestera_bridge_port *br_port, return 0; err_port_learning_set: - prestera_hw_port_flood_set(port, false); -err_port_flood_set: + prestera_hw_port_mc_flood_set(port, false); +err_port_mc_flood_set: + prestera_hw_port_uc_flood_set(port, false); +err_port_uc_flood_set: prestera_hw_bridge_port_delete(port, bridge->bridge_id); return err; @@ -567,7 +573,8 @@ static void prestera_port_bridge_leave(struct prestera_port *port, prestera_bridge_1d_port_leave(br_port, port); prestera_hw_port_learning_set(port, false); - prestera_hw_port_flood_set(port, false); + prestera_hw_port_uc_flood_set(port, false); + prestera_hw_port_mc_flood_set(port, false); prestera_port_vid_stp_set(port, PRESTERA_VID_ALL, BR_STATE_FORWARDING); prestera_bridge_port_put(br_port); } @@ -609,17 +616,28 @@ static int prestera_port_attr_br_flags_set(struct prestera_port *port, if (!br_port) return 0; - err = prestera_hw_port_flood_set(port, flags & BR_FLOOD); + err = prestera_hw_port_uc_flood_set(port, flags & BR_FLOOD); if (err) - return err; + goto err_port_uc_flood_set; + + err = prestera_hw_port_mc_flood_set(port, flags & BR_MCAST_FLOOD); + if (err) + goto err_port_mc_flood_set; err = prestera_hw_port_learning_set(port, flags & BR_LEARNING); if (err) - return err; + goto err_port_learning_set; memcpy(&br_port->flags, &flags, sizeof(flags)); return 0; + +err_port_learning_set: + prestera_hw_port_mc_flood_set(port, false); +err_port_mc_flood_set: + prestera_hw_port_uc_flood_set(port, false); +err_port_uc_flood_set: + return err; } static int prestera_port_attr_br_ageing_set(struct prestera_port *port, @@ -914,9 +932,13 @@ prestera_port_vlan_bridge_join(struct prestera_port_vlan *port_vlan, if (port_vlan->br_port) return 0; - err = prestera_hw_port_flood_set(port, br_port->flags & BR_FLOOD); + err = prestera_hw_port_uc_flood_set(port, br_port->flags & BR_FLOOD); if (err) - return err; + goto err_port_uc_flood_set; + + err = prestera_hw_port_mc_flood_set(port, br_port->flags & BR_MCAST_FLOOD); + if (err) + goto err_port_mc_flood_set; err = prestera_hw_port_learning_set(port, br_port->flags & BR_LEARNING); if (err) @@ -947,6 +969,10 @@ prestera_port_vlan_bridge_join(struct prestera_port_vlan *port_vlan, err_port_vid_stp_set: prestera_hw_port_learning_set(port, false); err_port_learning_set: + prestera_hw_port_mc_flood_set(port, false); +err_port_mc_flood_set: + prestera_hw_port_uc_flood_set(port, false); +err_port_uc_flood_set: return err; } From patchwork Wed Feb 3 16:54:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 12064859 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2EDC433E0 for ; Wed, 3 Feb 2021 16:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A394964E46 for ; Wed, 3 Feb 2021 16:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbhBCQ7P (ORCPT ); Wed, 3 Feb 2021 11:59:15 -0500 Received: from mail-eopbgr00096.outbound.protection.outlook.com ([40.107.0.96]:21157 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231761AbhBCQ6E (ORCPT ); Wed, 3 Feb 2021 11:58:04 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRgBDB0nHgMnzPdcBs+P/lRdEdycMUNtBBZGh0rVsst53LbdlfSWzKTVzn/ReNGl4UytUU+rIZ1pz2AtayGeinC2RvqETMjI3IVLKhK/ik3WmOxeWX8Rd8FLcMKRidN2zN0yn3jH2eNw4BitQceBmWqrzSW9Cd3nTd3cnWAtnNlIpmLW3vzUHjxPq+iKWwLk3PEw9mYFR1XuKzja3fyTaYy5dzRWlA5TLFw2TZ0Kt141p6TrK2xRxDZohI91i03fgCFE2HnqLgKfm8za6UVyCa7s0uaqgzR94flc+AkVAW+Z/m1ZNra3g4SB0xQ7qXvGfVMaiFcUH1QeFizpzgN7Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U68oR9IpMYbdQeZf3zPXyAyevSD/TnNuxfBGQSbUIxU=; b=lrtadPSpYp7ExkrkIytqZ9yMIP3ZxwW+2fRzhhM4cgRx6aHrOs4iCdLV8o11NyCIe4T7X4IKRUjm+mCohR4JzVrM018wS+N4nS4mo9Y7TQKSuJPqVqDpiVx38rhVwSNj2CGmhZUCrArswyRmKI46VEyrqWGYy/zpVpAi/3WQq1v+zKjSfeXspA47vdgEHWpvinDRApYvHcLx/3NKcO7d2h//zZE7mK8OENUDMkozikNeU/q+ORhpH3cGFGezBinsL+et98m4701UYZDTq4mLTkS1rSSSreBwCtnztu8JPcjJFfYpJdR4Bc2bVV+8az/VfP7IEwrYTRKYfb/LyLMeNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=plvision.eu; dmarc=pass action=none header.from=plvision.eu; dkim=pass header.d=plvision.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plvision.eu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U68oR9IpMYbdQeZf3zPXyAyevSD/TnNuxfBGQSbUIxU=; b=jkYd0dNV7bExWbJFszmjMr5OwxTy7iFrpV7gzgCSeBQUOqvn3h0ERjdRnDWFj9vi4spXc73MKOXwaot/bOcaoMbww5eMFHEhtylNgsKc80v5B49r7ZsrGvE/hEXZdD7F1DnbOmBcLruJ4KL47ODjWGNAEny5uTC+yS7mQVIGHe0= Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=plvision.eu; Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16; Wed, 3 Feb 2021 16:56:00 +0000 Received: from HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f]) by HE1P190MB0539.EURP190.PROD.OUTLOOK.COM ([fe80::bc8b:6638:a839:2a8f%5]) with mapi id 15.20.3805.023; Wed, 3 Feb 2021 16:56:00 +0000 From: Vadym Kochan To: "David S. Miller" , Jakub Kicinski , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , netdev@vger.kernel.org Cc: Mickey Rachamim , Vadym Kochan , linux-kernel@vger.kernel.org Subject: [PATCH net-next 7/7] net: marvell: prestera: fix port event handling on init Date: Wed, 3 Feb 2021 18:54:58 +0200 Message-Id: <20210203165458.28717-8-vadym.kochan@plvision.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210203165458.28717-1-vadym.kochan@plvision.eu> References: <20210203165458.28717-1-vadym.kochan@plvision.eu> X-Originating-IP: [217.20.186.93] X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) To HE1P190MB0539.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:56::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc60716vkochan.x.ow.s (217.20.186.93) by AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Wed, 3 Feb 2021 16:55:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef115064-1f0e-4aa4-d7e5-08d8c864954c X-MS-TrafficTypeDiagnostic: HE1P190MB0539: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BqAY4NzdpKaZ5eA3dRKHfvsM9qiB6e1A+xn9GXiGIMTKrqeFZaz10OT7yt2p3I5B3RYZ830DJDEafZxU0MmC9dOjhoj+tGJ6LdOG9SDHB9CUl3zumqJrxI/pSBwKCqe9Ofd6FuwJ2D8REzVbO4m3PP6vtx6Nb211d1Ins8z4t2kQ164RwUoM3/Oozfknyb+Csz/zBSAqhe2BxwvsmBLuHDvP7tZoCbgDbe+jUBu/3sg/lBUs9pU/VY+uZn2YayqzAcXHMgc0sTbFgt6B5fWAl7nk6VU7AwlnPYKd9NecJuXfrzPCuYnxb9O2y8BRNhbMVLVqT7cVzyaMj0RyV5ls1+HrPDetbRpXcarsPbZ/Ao9W3Gz1iv+5vnoOXQ34XA+BiR+GGxZY7uY85yYxHOqNm8m5TgS3WyAS2Fjvz9f/+mHoCSMF5I+EgOxi3vmxe/GEG/y/wM3VudvOD1v2Ln56UHpHArvlERtsP5ePogyyKwI4D7WIkiCnBkUwHwYgLbOPqHD/879rPp5b4XI+qpBwyw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(376002)(136003)(346002)(478600001)(6486002)(110136005)(54906003)(83380400001)(45080400002)(8676002)(66556008)(44832011)(5660300002)(956004)(4326008)(6506007)(16526019)(36756003)(86362001)(186003)(26005)(6512007)(52116002)(2906002)(316002)(2616005)(66946007)(8936002)(1076003)(66476007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 9K60y9W494ALdPISHmfT3Q+8vWtKm/SAGMpZYK0YrD/aTVeHkLYv1OHTFyLD8c5mD2QOWEZQCOsNIH7dg1c0R2VTHrhlfhJwxbdTDnV5FdoqfMyuIruHx9ZO2mj2GDWuLUYWVjZ3M8Qa6gxkQQf4CA4r2IDPVGrtCAIEiCYEhjivZbt1JSSiMJ1/ButiQ4PEBNHIh3CqmBU7K4vkpARKTC0MM1IJJ2YrNvHAgQZaawtQTfftpTb41M8ogUxfRm+XOMt6yZ2sQPbYCfUoQ+qeLlRL3pjChU+Ikzsv+SkvJvxszDmlaLk9fqD+OUW4uFnx4ADRCJPKer765Q0GfDYxrtyPUe0cJM0M85LFTuAIibheMa6RR0sqVNq7t9F1GN+OQwlw4kS5RAUzATK72A64WBeUnVMoWKyD+Q2wIO3v5lFLc0RHr/AvbdnoppKSFXf96Ng1jXGVLSVf3uWFD5drGe+DALQbp1plzLe96nYTH+5cYbLYAjoUK3/kXOtl04EQB25jGYQHr0q74OB+5UF8zmS7DK6n+BOOL+XJak9Da4RFQcC9LaXNIJ8X+t0DRBKPdXkLadZQYg+ygpqrir8vAJckYmhSEhodGrOVNMNlG3xMOMd8L5S7SwhS7QVn+FHwK4ibGwm3Zw2DhV/nb47yPRJ+xSiyw6jCXy9SCIONLdUZNZvp+ARKXvFDdNfdSeT4iBklMDVKchDzBL9tO3K2WDE2+KI3ZfuninPWUfL2vLlSw+twtwVoxc5+pFRbTkk8FIyq8lwmOi2qNTj3c76NAadzBXNca+0pM5gdGaGVS7BTayBvVG6TJ71MZmZf+Ih70lA3vW1rEV1FpKlNEM7PQHO6A1kIXw5ay8+0Q/gmyB19ex2nuJbzu4UPxKwN2AK8qcyNyIfTfcUfBn9mtiQYsGAffOmfJIgA+sgIoMjch3uUCo/XdLvcveMuO4HHPPzExaUyKG+tUxwHzur6IdWMpV5XzLBueCMUID6g+B9qIORJBDN2EveFM8Cl/M8z7ZD7FduhNWxSgdn1M7/IZTuPb2mOzqCdNKSDb3952+Rm2XazOJ1DgD0InYrOIsegSyBRPh6YpOZ2PuPRRTKYcB0mDYqZ1bxOPal6wxR2kAMypBRsBhKYVdYO8+MhhG3I0EBN1zmSecbF6Pk1EbA2d81CQqnEHlRhKeOAvCxr1jon9fNnus0flyZ/DjXSEcZBySgOZ7Zts9/dJGYsWA8ZEbZCTA30QYbyoX+cUVtE7wZVXuEqHU1hp+eHRmi6OBwYPeXOlASykFX7rJW6eKcjIpNUR9vUxsBulpTKQCavomrh+6TW9Z3BC7qHtglN/nQp0ohG X-OriginatorOrg: plvision.eu X-MS-Exchange-CrossTenant-Network-Message-Id: ef115064-1f0e-4aa4-d7e5-08d8c864954c X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2021 16:56:00.2079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VwXFTBxMMdrfbQzSUH2h+I4HYZYp4xKcfFONoInq6X2wWY2ZtGjYAOvf6TMP2er7GJXCES7LLKTjqjlvEa8NRDmvFJZBPdM2i8ivAroYnIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0539 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For some reason there might be a crash during ports creation if port events are handling at the same time because fw may send initial port event with down state. The crash points to cancel_delayed_work() which is called when port went is down. Currently I did not find out the real cause of the issue, so fixed it by cancel port stats work only if previous port's state was up & runnig. The following is the crash which can be triggered: [ 28.311104] Unable to handle kernel paging request at virtual address 000071775f776600 [ 28.319097] Mem abort info: [ 28.321914] ESR = 0x96000004 [ 28.324996] EC = 0x25: DABT (current EL), IL = 32 bits [ 28.330350] SET = 0, FnV = 0 [ 28.333430] EA = 0, S1PTW = 0 [ 28.336597] Data abort info: [ 28.339499] ISV = 0, ISS = 0x00000004 [ 28.343362] CM = 0, WnR = 0 [ 28.346354] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000100bf7000 [ 28.352842] [000071775f776600] pgd=0000000000000000, p4d=0000000000000000 [ 28.359695] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 28.365310] Modules linked in: prestera_pci(+) prestera uio_pdrv_genirq [ 28.372005] CPU: 0 PID: 1291 Comm: kworker/0:1H Not tainted 5.11.0-rc4 #1 [ 28.378846] Hardware name: DNI AmazonGo1 A7040 board (DT) [ 28.384283] Workqueue: prestera_fw_wq prestera_fw_evt_work_fn [prestera_pci] [ 28.391413] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--) [ 28.397468] pc : get_work_pool+0x48/0x60 [ 28.401442] lr : try_to_grab_pending+0x6c/0x1b0 [ 28.406018] sp : ffff80001391bc60 [ 28.409358] x29: ffff80001391bc60 x28: 0000000000000000 [ 28.414725] x27: ffff000104fc8b40 x26: ffff80001127de88 [ 28.420089] x25: 0000000000000000 x24: ffff000106119760 [ 28.425452] x23: ffff00010775dd60 x22: ffff00010567e000 [ 28.430814] x21: 0000000000000000 x20: ffff80001391bcb0 [ 28.436175] x19: ffff00010775deb8 x18: 00000000000000c0 [ 28.441537] x17: 0000000000000000 x16: 000000008d9b0e88 [ 28.446898] x15: 0000000000000001 x14: 00000000000002ba [ 28.452261] x13: 80a3002c00000002 x12: 00000000000005f4 [ 28.457622] x11: 0000000000000030 x10: 000000000000000c [ 28.462985] x9 : 000000000000000c x8 : 0000000000000030 [ 28.468346] x7 : ffff800014400000 x6 : ffff000106119758 [ 28.473708] x5 : 0000000000000003 x4 : ffff00010775dc60 [ 28.479068] x3 : 0000000000000000 x2 : 0000000000000060 [ 28.484429] x1 : 000071775f776600 x0 : ffff00010775deb8 [ 28.489791] Call trace: [ 28.492259] get_work_pool+0x48/0x60 [ 28.495874] cancel_delayed_work+0x38/0xb0 [ 28.500011] prestera_port_handle_event+0x90/0xa0 [prestera] [ 28.505743] prestera_evt_recv+0x98/0xe0 [prestera] [ 28.510683] prestera_fw_evt_work_fn+0x180/0x228 [prestera_pci] [ 28.516660] process_one_work+0x1e8/0x360 [ 28.520710] worker_thread+0x44/0x480 [ 28.524412] kthread+0x154/0x160 [ 28.527670] ret_from_fork+0x10/0x38 [ 28.531290] Code: a8c17bfd d50323bf d65f03c0 9278dc21 (f9400020) [ 28.537429] ---[ end trace 5eced933df3a080b ]--- Signed-off-by: Vadym Kochan --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 39465e65d09b..122324dae47d 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -433,7 +433,8 @@ static void prestera_port_handle_event(struct prestera_switch *sw, netif_carrier_on(port->dev); if (!delayed_work_pending(caching_dw)) queue_delayed_work(prestera_wq, caching_dw, 0); - } else { + } else if (netif_running(port->dev) && + netif_carrier_ok(port->dev)) { netif_carrier_off(port->dev); if (delayed_work_pending(caching_dw)) cancel_delayed_work(caching_dw);