From patchwork Thu Feb 4 11:09:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067013 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FFAC433E6 for ; Thu, 4 Feb 2021 11:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACDEA64F58 for ; Thu, 4 Feb 2021 11:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235631AbhBDLLF (ORCPT ); Thu, 4 Feb 2021 06:11:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235624AbhBDLKq (ORCPT ); Thu, 4 Feb 2021 06:10:46 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6071AC0613ED for ; Thu, 4 Feb 2021 03:10:06 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id a1so3005453wrq.6 for ; Thu, 04 Feb 2021 03:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t1Hcpu/GsWIJa0ISm8bZ6HXe5H9dtQ9e34hCFzoGJVs=; b=GqGjTH3exPZnUvuas4XWPGoETlhvPot3+TvjkOlDnxXoe1coZAt2hy/jT3XKnkw6fh LGklIUq3zBgQ9jgyWRbi/e2qTa+QBTpniwrYo+NSlKVCjg/KQXXeNmb8n13P0g8F8yY1 n3drLix+WlfPPYGTgkDxPcesnJ9vYZm/dLFPMd7drEiwSFEBeRSD0Iz8LbUhQ3IOQyK5 2bLD5kx6MQnR72F7ZbfJeM6Oy6gvgo5De/X1RNQ83wcQ368guKzegRsbSnin3uejNjhn F13499ZOFCdtjxeGUrJ420lTbM4Mrem03vUVRJM0wFzInoE1iCVzRjouEFhNKsTKt3NY WEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t1Hcpu/GsWIJa0ISm8bZ6HXe5H9dtQ9e34hCFzoGJVs=; b=HIerv+6t533ONosw3NVa9RsQZa8cHKsh5v1zj2CbWU4gwu+MenDmK1ctjZmh+6lhYj +pGiPH8IjdlHeQkc+KGYjBOjYF300oiXRcS0PbUAE7PgHPHKWf9RGUF5EQ/vQFFV1/19 xr0+rmof7jEzJu4mlIpYI1Kw0qnCJaaeExRsZoxRhzwIFlCMHoG77/TJslVtrbHx6iPV x5kDdEfbEvmqjzOxsvr81lj0PuCTKvp3nXliCifUt2JAjcXEbPT2WTpD7QjsxgYamnbA RX6dUcZFXZq+u1eoRsP8jF6JNm9QYT+N0crwOo4Ijx1ny6V0/n6tP/4zqy2l0STrU6qQ urBw== X-Gm-Message-State: AOAM531Sx7eNqt9e9rJm2oh7zSCkyMD3Y5wwqqi9w80lUzq2FzwcqYl3 /pZN6Hjbz+SD+JtxZUJ1KBKfpg== X-Google-Smtp-Source: ABdhPJwjdkC95lnOwPsXjE3KbW1ymbODYl/4EWoKmla9E92T0UEh0s4HJSxjepfmFWLxqqxeWowLog== X-Received: by 2002:a5d:4142:: with SMTP id c2mr8797431wrq.359.1612437005106; Thu, 04 Feb 2021 03:10:05 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Zaibo Xu , Jonathan Cameron , linux-crypto@vger.kernel.org Subject: [PATCH 01/20] crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param Date: Thu, 4 Feb 2021 11:09:41 +0000 Message-Id: <20210204111000.2800436-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/hisilicon/sec/sec_drv.c:843: warning: Function parameter or member 'queue' not described in 'sec_queue_empty' Cc: Herbert Xu Cc: "David S. Miller" Cc: Zaibo Xu Cc: Jonathan Cameron Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/hisilicon/sec/sec_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/hisilicon/sec/sec_drv.c b/drivers/crypto/hisilicon/sec/sec_drv.c index 91ee2bb575df2..3c26871db12f3 100644 --- a/drivers/crypto/hisilicon/sec/sec_drv.c +++ b/drivers/crypto/hisilicon/sec/sec_drv.c @@ -834,6 +834,7 @@ int sec_queue_stop_release(struct sec_queue *queue) /** * sec_queue_empty() - Is this hardware queue currently empty. + * @queue: The queue to test * * We need to know if we have an empty queue for some of the chaining modes * as if it is not empty we may need to hold the message in a software queue From patchwork Thu Feb 4 11:09:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067015 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA80C43381 for ; Thu, 4 Feb 2021 11:11:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3E3764F60 for ; Thu, 4 Feb 2021 11:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235637AbhBDLLI (ORCPT ); Thu, 4 Feb 2021 06:11:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235542AbhBDLKr (ORCPT ); Thu, 4 Feb 2021 06:10:47 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68230C061788 for ; Thu, 4 Feb 2021 03:10:07 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id c12so2982641wrc.7 for ; Thu, 04 Feb 2021 03:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gipN5H3JyGASQHPNrRrSjgiDn340aoFup6C6RtL10J0=; b=GKy/jC8shsYQTi1fR/pF2UkgIqyPlcGlKnclGVNETMvnhowrPblVoiWk9+LeYYs4GB FnvtDOLIKwsK18ocX1wEomU3+YEoTsftzO9t2enDt+PEDbMPycojH/YY232kQI8eSCzH WJvqLeq4R8g3gwm90IDdLJFNmOZzvrupdg+aOR7y62B3QuLaLXvOsLCAzJ3kAk/KWyp6 Ud0Fq8XkYD5POx903d6zOCpxXfmvL/qmA0RKA7CFDEQHBIWe5gbw1xBJBfIqc3aZA+AV 1OQlwb4xkg76BKtnz/TeqfDFqMup1clJouQ5xTEzHSEKBZgdGJeAUjxj5IiflkzRnJh1 JqRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gipN5H3JyGASQHPNrRrSjgiDn340aoFup6C6RtL10J0=; b=ITsDeAR4ALsIERk+3ShFCSHcpVhOp7rCrAy/ZtcHkyuZYaANU6pMcJDNi3EjHMetRq PvEF0iRZIGYchtwPZhyKLPMpZuYakhVQcQw7Gxs1l5Op3sJA3TzVpc9jncbw3/fSWt0c 4KPgK5Gg8KIYzgPf9OMo9KjfyM1D84WGy4kCDUQatfsA9vjq3HZ+m1ENTH+UTrEPhzfp BUB9/RshUZ2XAEg4jjTBRwmx+3FddYZZbcCR/Jr7EJAt3yjWuzYvlak3Ai7J4rzHP6KC 9eUHWl+44UmqtyvWMkb6zHTid7hU4e12BZH19Lr9RqtQ+kk9QRdNM578sLIfJW5QXVit 40ew== X-Gm-Message-State: AOAM533XBXTK/+R+K9HpVA9tF90gagGVDokLITHD1Wr6OyAMtctyTIDJ prIgHnRTixO8UcBGQlhojBXjLA== X-Google-Smtp-Source: ABdhPJx2hwmcLvyC+zMd2izO+NVfPDts/lbQ2wAdZhz0mk7pgq1qVNsO8X5x4bj0aL8tddGnhFUBeA== X-Received: by 2002:a5d:4b0b:: with SMTP id v11mr8570035wrq.226.1612437006136; Thu, 04 Feb 2021 03:10:06 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Takashi Iwai , linux-crypto@vger.kernel.org Subject: [PATCH 02/20] crypto: bcm: util: Repair a couple of documentation formatting issues Date: Thu, 4 Feb 2021 11:09:42 +0000 Message-Id: <20210204111000.2800436-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'from_nents' not described in 'spu_msg_sg_add' drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'length' not described in 'spu_msg_sg_add' Cc: Herbert Xu Cc: "David S. Miller" Cc: Takashi Iwai Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c index c4669a96eaecf..d5d9cabea55aa 100644 --- a/drivers/crypto/bcm/util.c +++ b/drivers/crypto/bcm/util.c @@ -119,8 +119,8 @@ int spu_sg_count(struct scatterlist *sg_list, unsigned int skip, int nbytes) * @from_skip: number of bytes to skip in from_sg. Non-zero when previous * request included part of the buffer in entry in from_sg. * Assumes from_skip < from_sg->length. - * @from_nents number of entries in from_sg - * @length number of bytes to copy. may reach this limit before exhausting + * @from_nents: number of entries in from_sg + * @length: number of bytes to copy. may reach this limit before exhausting * from_sg. * * Copies the entries themselves, not the data in the entries. Assumes to_sg has From patchwork Thu Feb 4 11:09:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067017 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFECC433E0 for ; Thu, 4 Feb 2021 11:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 847F864F60 for ; Thu, 4 Feb 2021 11:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235661AbhBDLLe (ORCPT ); Thu, 4 Feb 2021 06:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235623AbhBDLLb (ORCPT ); Thu, 4 Feb 2021 06:11:31 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91E96C06178B for ; Thu, 4 Feb 2021 03:10:08 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id 7so3062245wrz.0 for ; Thu, 04 Feb 2021 03:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EFpX+AmGU+/V3bANCqUU3BguvAC+waEIfHhaAdI4zMs=; b=hv1VBzJc6RilH2aUMiuk9Ns6LYXu2wa4OjuB1dtlBKNQoUwuZi1zdEuhynoL4Qr0sl zqvRLwKWWrIX+Zuda0m/14lI0psfn2i9Ws28XwDAEcFS8uQgjaLBnuDAj2424NU/MZdg bJC0bjoXMrAW1YDA4a8iv3PIyPjcYzUVf44Zn8+D3L1kpHfZY91MGJ7OBj7M7xYxIbnT pC3d0vfoY4BZS2eDEImbR/BoeMQeUBxWFBDCBkvbZmUm5Z/adSkHh4ckAP1OnVAwWmRd EtlecuTomKf+rSFNglyaSRXiyLYh+uGQ49JqyVAqjji82ZXTFGBNEJiAWlWnq9KfRTY2 SYEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EFpX+AmGU+/V3bANCqUU3BguvAC+waEIfHhaAdI4zMs=; b=GzzEASzcHZu8onN49en/+ZeczhC/1K4vh1J1F1FUVRmqQX2j6sHkOz5Neji403YPFL UWKsEc7W6OLoVpl1j3riBp1yvdp/oCaQZc/UzmCnCV6rSnEpEAaS7L13qK6qlTLjLB0b 4A0x5Q6j1d14fXxb7rydlPGCxng28oc3hVKobk3DYN3fyxb4FOJ9t3BA+MgmFZEEJM+J XZnNiWSi2Zpgn96eOAsLA4jT/GOgYTBxN2AM706WtWV4qC2w+HmiaYAbOZ3enSUKe/PJ 4/iDboB37n+hnxBHZwkUYi73iugQV2ZUodn57i+e6J1WCJAg/usOYwFOdq+iiHrKis9Q DhdA== X-Gm-Message-State: AOAM530vFc4p/193BZZiZ2+NU9kUdSPeXmCjdxmmPuxVo5GgdoujLBH3 v0HEHosBCCs78M8c+uO4XL2jaw== X-Google-Smtp-Source: ABdhPJwJoinTJrS70FP+INyhS5zItFKn/Hlz+JZP5Bfka/wi3Li3Vy649PizAtfAUivpTpZCP3jaxQ== X-Received: by 2002:a5d:6b47:: with SMTP id x7mr8918819wrw.170.1612437007388; Thu, 04 Feb 2021 03:10:07 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Herbert Xu , "David S. Miller" , Manoj Malviya , Atul Gupta , Jitendra Lulla , M R Gowda , Harsh Jain , linux-crypto@vger.kernel.org Subject: [PATCH 03/20] crypto: chelsio: chcr_core: File headers are not good candidates for kernel-doc Date: Thu, 4 Feb 2021 11:09:43 +0000 Message-Id: <20210204111000.2800436-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on line: Cc: Ayush Sawal Cc: Vinay Kumar Yadav Cc: Rohit Maheshwari Cc: Herbert Xu Cc: "David S. Miller" Cc: Manoj Malviya Cc: Atul Gupta Cc: Jitendra Lulla Cc: M R Gowda Cc: Harsh Jain Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/chelsio/chcr_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c index f91f9d762a45e..f03ef4a23f96d 100644 --- a/drivers/crypto/chelsio/chcr_core.c +++ b/drivers/crypto/chelsio/chcr_core.c @@ -1,4 +1,4 @@ -/** +/* * This file is part of the Chelsio T4/T5/T6 Ethernet driver for Linux. * * Copyright (C) 2011-2016 Chelsio Communications. All rights reserved. From patchwork Thu Feb 4 11:09:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067019 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3106FC433DB for ; Thu, 4 Feb 2021 11:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0362F64F60 for ; Thu, 4 Feb 2021 11:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235666AbhBDLLi (ORCPT ); Thu, 4 Feb 2021 06:11:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235623AbhBDLLe (ORCPT ); Thu, 4 Feb 2021 06:11:34 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD77DC061794 for ; Thu, 4 Feb 2021 03:10:09 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id d16so2953732wro.11 for ; Thu, 04 Feb 2021 03:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UuJJvnBY1RT5AmJ5CEhkK6udrJuyZm280OjEkcYs/fQ=; b=HCGu7dsDqG4pkWy8ockT5UO+pq22sAnePsOuQg+uVYtRaK/OQphQlcxTjFJIKCHuir SpaoujMIk8FfAnv860dMGKAMiz0SMmR2yvVwDsC2bDsUxkESYR3eHXOdw5nZ0imM/tqA 7CRrZkRe0JtqTUdogu7T5Rv0Xq1l+VGdsQ/oc4EuB+y3/wUbyZtxGwDrBRj8R6hzcWs2 BAa0cQt4IQpXG4rs7bdLaZqfVrp2l5TdHxqHkDRd7enoxlJgCDUh+PKWyAdZs186elSe yPaRNmsEb4r9Ihw3d6B9HW3+COwQVnGBWPb3eA+bXfKhYyLhDXGCWnTuhjxNnY8JUmlE w5ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UuJJvnBY1RT5AmJ5CEhkK6udrJuyZm280OjEkcYs/fQ=; b=KSFoPBWkwByf8ZH68z4+R1e+FkeG80CgX9UGJ7AHaRiEzW/IgIrfPnVlcomaeCH3wT g34myTlaFN7YqhuPwWdGmwD+/8zXaPYNn02gPSrYhX3bhh4cXtbpACYzQ0CnNFSHmByW htWjYoU1E4BvuBxVb+lUXSRztZ3WoSA8j7GXVOYj5VMWoEW/AXvEpM+vdgfRyDr504m4 btwGxlANpQ48j6v0ORNbspRusmf+XYFrLec+OLtBuUk5kOz6Pq1rqrlEFpR00ktT1+DX PAbDxrMHK8Wm1yPTOn2mLl3ob2p/uxMiaWTNI0OkqXMmcooJYpnwYv5cCrctztLd4tTs J4HA== X-Gm-Message-State: AOAM530JdMjE39vgXxMYrDkRrcOFWlF8T5uKvogfQVGKoLVOBc4B2Bbz UVPRhJIfEOdDLLfOt/jVzietz9R7n8ryTQ== X-Google-Smtp-Source: ABdhPJySJSWFjuE4JIiwrvf+jyaIlEDIGGf7ANwv7vOVJ9x5/EdqbI4lkAi16yQIPc4Drn88FhZFhQ== X-Received: by 2002:a05:6000:12c8:: with SMTP id l8mr8537957wrx.81.1612437008481; Thu, 04 Feb 2021 03:10:08 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Shujuan Chen , Joakim Bech , Berne Hebark , Niklas Hernaeus , Andreas Westin , linux-crypto@vger.kernel.org Subject: [PATCH 04/20] crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others Date: Thu, 4 Feb 2021 11:09:44 +0000 Message-Id: <20210204111000.2800436-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The ones remove here not only fail to conform to kernel-doc, but also provide no value, so let's remove them completely in this case. Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or member 'ctx' not described in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:368: warning: Excess function parameter 'hash_ctx' description in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:551: warning: expecting prototype for hash_init(). Prototype was for ux500_hash_init() instead drivers/crypto/ux500/hash/hash_core.c:592: warning: Function parameter or member 'length' not described in 'hash_processblock' drivers/crypto/ux500/hash/hash_core.c:1302: warning: expecting prototype for hash_update(). Prototype was for ahash_update() instead drivers/crypto/ux500/hash/hash_core.c:1322: warning: expecting prototype for hash_final(). Prototype was for ahash_final() instead drivers/crypto/ux500/hash/hash_core.c:1622: warning: Function parameter or member 'device_data' not described in 'ahash_algs_register_all' drivers/crypto/ux500/hash/hash_core.c:1622: warning: expecting prototype for hash_algs_register_all(). Prototype was for ahash_algs_register_all() instead drivers/crypto/ux500/hash/hash_core.c:1647: warning: Function parameter or member 'device_data' not described in 'ahash_algs_unregister_all' drivers/crypto/ux500/hash/hash_core.c:1647: warning: expecting prototype for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: Andreas Westin Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/hash/hash_core.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index da284b0ea1b26..bcaf6ba3e9235 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -356,7 +356,7 @@ static int hash_enable_power(struct hash_device_data *device_data, /** * hash_get_device_data - Checks for an available hash device and return it. - * @hash_ctx: Structure for the hash context. + * @ctx: Structure for the hash context. * @device_data: Structure for the hash device. * * This function check for an available hash device and return it to @@ -542,7 +542,7 @@ static bool hash_dma_valid_data(struct scatterlist *sg, int datasize) } /** - * hash_init - Common hash init function for SHA1/SHA2 (SHA256). + * ux500_hash_init - Common hash init function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. * * Initialize structures. @@ -585,6 +585,7 @@ static int ux500_hash_init(struct ahash_request *req) * @device_data: Structure for the hash device. * @message: Block (512 bits) of message to be written to * the HASH hardware. + * @length: Message length * */ static void hash_processblock(struct hash_device_data *device_data, @@ -1295,7 +1296,7 @@ void hash_get_digest(struct hash_device_data *device_data, } /** - * hash_update - The hash update function for SHA1/SHA2 (SHA256). + * ahash_update - The hash update function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_update(struct ahash_request *req) @@ -1315,7 +1316,7 @@ static int ahash_update(struct ahash_request *req) } /** - * hash_final - The hash final function for SHA1/SHA2 (SHA256). + * ahash_final - The hash final function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_final(struct ahash_request *req) @@ -1615,9 +1616,6 @@ static struct hash_algo_template hash_algs[] = { } }; -/** - * hash_algs_register_all - - */ static int ahash_algs_register_all(struct hash_device_data *device_data) { int ret; @@ -1640,9 +1638,6 @@ static int ahash_algs_register_all(struct hash_device_data *device_data) return ret; } -/** - * hash_algs_unregister_all - - */ static void ahash_algs_unregister_all(struct hash_device_data *device_data) { int i; From patchwork Thu Feb 4 11:09:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067033 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F00C433E0 for ; Thu, 4 Feb 2021 11:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6624E64F60 for ; Thu, 4 Feb 2021 11:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235720AbhBDLMZ (ORCPT ); Thu, 4 Feb 2021 06:12:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235675AbhBDLLr (ORCPT ); Thu, 4 Feb 2021 06:11:47 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A4FC0617A7 for ; Thu, 4 Feb 2021 03:10:11 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id f16so2735532wmq.5 for ; Thu, 04 Feb 2021 03:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9PQJyorI7NSFOmBlzU3qYIYb38rUcKuWau7MQ0QjGLc=; b=FSr/KZivxIq+H/JsqxnJyXqNIN1K1v9CM8MSNUgKhBPSIYQoO9U08WhO3MexdqcSzu gpILk81W/zf9kGFNHKPWIuVEZNPAcRAw39QXhu6cW1zh0dTinkZbWbc4dd09ItE6twgb Fmhnwo5w4g0oDXtBu38c0voaX/yr0AlkAIvqVbWlfwz88N7myvfqTLv6to2OZDpMuZag L6R6aj7lbNhQ6WkdObOHke2kK/qaRDeB4HhnJRr3rkqdCWcAr3qA4O7H9ATKSwDZ6DPy CZaxYueFvtlzAd5KvpTMazQG34Ws82FZ6ActFk41KPqJJi48ARBHtoeY03glTGrZ1fSN GN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9PQJyorI7NSFOmBlzU3qYIYb38rUcKuWau7MQ0QjGLc=; b=s0Oj71hoQyv2ZZGJe4MoLmHE7AAhhadebuxm1Cd7mxR4ST91P4AbXs9qYVJ9l44S6i aRY1O0VdPvt8bdRqUIoVj/FA9ZcZ9JqRhqy3EXk53aXDzmdkqUeSqgVAu0f/fLDxnplv fJwB+Tv9IYqhIlX3DX1BEMdz5xwuRFWawbkhjfwkEnlSy4L6tPzoPMdgfFiHyjKbXEb+ lPk/SvTo/33A43AvJEkFjd5yhAP9WOgN5eQbre92RmEJxqGfExD5Ouwsos/Rd5pBLC6p LqIfJ8l4We0M7d33WMi5tBALxpqoqeAnLa8bYsNHHBGl58RKQUsfSdMgneszsMbxijfd kxaw== X-Gm-Message-State: AOAM530DFPqfDctRF1KXwby088tEc+MegWlJzhRCj/GXUpN0Q+LvTi7z F/LbRGnVON0V7PmhY8hmFuxpmYp71oPFxw== X-Google-Smtp-Source: ABdhPJw0oFT5FZf9Plohvjcn/VRefliidr4eJiCyxMnCCg5f/bFrZ7r6V1nVsPxpSfSXwXt+rvWBjA== X-Received: by 2002:a05:600c:230e:: with SMTP id 14mr7003253wmo.161.1612437009685; Thu, 04 Feb 2021 03:10:09 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 05/20] crypto: bcm: spu: Fix formatting and misspelling issues Date: Thu, 4 Feb 2021 11:09:45 +0000 Message-Id: <20210204111000.2800436-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/spu.c:464: warning: Excess function parameter 'Return' description in 'spum_gcm_ccm_pad_len' drivers/crypto/bcm/spu.c:524: warning: Function parameter or member 'iv_len' not described in 'spum_aead_ivlen' drivers/crypto/bcm/spu.c:524: warning: expecting prototype for spu_aead_ivlen(). Prototype was for spum_aead_ivlen() instead drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg_digest_size' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'htype' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:583: warning: bad line: drivers/crypto/bcm/spu.c:927: warning: Function parameter or member 'is_inbound' not described in 'spum_cipher_req_finish' drivers/crypto/bcm/spu.c:927: warning: Excess function parameter 'isInbound' description in 'spum_cipher_req_finish' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/spu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c index 007abf92cc05b..6283e8c6d51d3 100644 --- a/drivers/crypto/bcm/spu.c +++ b/drivers/crypto/bcm/spu.c @@ -457,7 +457,7 @@ u16 spum_hash_pad_len(enum hash_alg hash_alg, enum hash_mode hash_mode, * @cipher_mode: Algo type * @data_size: Length of plaintext (bytes) * - * @Return: Length of padding, in bytes + * Return: Length of padding, in bytes */ u32 spum_gcm_ccm_pad_len(enum spu_cipher_mode cipher_mode, unsigned int data_size) @@ -510,10 +510,10 @@ u32 spum_assoc_resp_len(enum spu_cipher_mode cipher_mode, } /** - * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included + * spum_aead_ivlen() - Calculate the length of the AEAD IV to be included * in a SPU request after the AAD and before the payload. * @cipher_mode: cipher mode - * @iv_ctr_len: initialization vector length in bytes + * @iv_len: initialization vector length in bytes * * In Linux ~4.2 and later, the assoc_data sg includes the IV. So no need * to include the IV as a separate field in the SPU request msg. @@ -543,9 +543,9 @@ enum hash_type spum_hash_type(u32 src_sent) /** * spum_digest_size() - Determine the size of a hash digest to expect the SPU to * return. - * alg_digest_size: Number of bytes in the final digest for the given algo - * alg: The hash algorithm - * htype: Type of hash operation (init, update, full, etc) + * @alg_digest_size: Number of bytes in the final digest for the given algo + * @alg: The hash algorithm + * @htype: Type of hash operation (init, update, full, etc) * * When doing incremental hashing for an algorithm with a truncated hash * (e.g., SHA224), the SPU returns the full digest so that it can be fed back as @@ -580,7 +580,7 @@ u32 spum_digest_size(u32 alg_digest_size, enum hash_alg alg, * @aead_parms: Parameters related to AEAD operation * @data_size: Length of data to be encrypted or authenticated. If AEAD, does * not include length of AAD. - + * * Return: the length of the SPU header in bytes. 0 if an error occurs. */ u32 spum_create_request(u8 *spu_hdr, @@ -911,7 +911,7 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms) * setkey() time in spu_cipher_req_init(). * @spu_hdr: Start of the request message header (MH field) * @spu_req_hdr_len: Length in bytes of the SPU request header - * @isInbound: 0 encrypt, 1 decrypt + * @is_inbound: 0 encrypt, 1 decrypt * @cipher_parms: Parameters describing cipher operation to be performed * @data_size: Length of the data in the BD field * From patchwork Thu Feb 4 11:09:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067031 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7465CC433E6 for ; Thu, 4 Feb 2021 11:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4424364F5C for ; Thu, 4 Feb 2021 11:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235700AbhBDLMH (ORCPT ); Thu, 4 Feb 2021 06:12:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235676AbhBDLLs (ORCPT ); Thu, 4 Feb 2021 06:11:48 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8EE8C0617AA for ; Thu, 4 Feb 2021 03:10:11 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id c127so2619806wmf.5 for ; Thu, 04 Feb 2021 03:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a2lURvcXUAZ56o/yGYVgo6mp0F/K9gLatpjFLDr+G/I=; b=V9jzeEe7iyd/YDg6OYfRwyL21PZ5X/2P5QTnGWFRem+ALb5v5ZWl3H+ahTpTjdyOGk 2wnJjy7BgMTUN9qLgIa/nvo/1A8y7LWCjupX1IY83coEJ9pQL687Fs0NwmA/n5ooTjUm OFv1m8uf49xbKfUHoG0P1CyX/uoai4oArpOo0p8uIrcSAZfYM9RMo8dG0zWOrjFiON0I 0Kse5fpaaTUp+zArXeOvAwcTNl3oEIRm7oxmT9yD4f477G4qiz84YKibzcExHFYV0RGz oZoMFUk0+UXrBRTpR8F6ULHBdiGQOD1Llw/Ky7jUyWetDLxzqcJkshQU12Nv6m1ngseY hpzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a2lURvcXUAZ56o/yGYVgo6mp0F/K9gLatpjFLDr+G/I=; b=NlFYksPnimyDX+vzBPBlrnfwmT3ebJPqJvJoXNjvS2OH3fmd6eK3Vty+ieY/24XNih 4vvsOa6O8uiinyAikzgdCfF9EixMndR3t7EaLlnG7/MnFsBYClTHE5hpjCXlmptniytN QaR7BhRP/8ZFNnY7h3jaMtRY6AW4smH0OcwWSIzxuNQwAq9cIB49OrN5S/0MzUB2QEof cAjoBfjuBQBVGuGlILDYYd4ITADWlzcPh04grMsS5+ql0eyd6iQ0D0W+3ihJGfyMAnf/ nTpoofKNmqlFWKE9hGRn7PcRADmz7hUXINbWB/pPUemsLEvV1DZDzMIjWOyFhMT85EFX udyA== X-Gm-Message-State: AOAM5312xwz5PSRTVRHiy6VnOhv9Q612Lwd0pF1rCONm2sK/ctuB/TMU J1tMTeH8uNj5E1glJBgXjfY0hw== X-Google-Smtp-Source: ABdhPJwsjLElKxrRS5U+fKqac2/+gHlJnWj1+tLjCIOu7H5XbP7NufH5kTAz1uR6B/nsvyYS58hATw== X-Received: by 2002:a1c:9845:: with SMTP id a66mr6772136wme.121.1612437010723; Thu, 04 Feb 2021 03:10:10 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Daniele Alessandrelli , Declan Murphy , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs Date: Thu, 4 Feb 2021 11:09:46 +0000 Message-Id: <20210204111000.2800436-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead Cc: Daniele Alessandrelli Cc: Declan Murphy Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Daniele Alessandrelli --- drivers/crypto/keembay/ocs-hcu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c index 81eecacf603ad..d522757855fb0 100644 --- a/drivers/crypto/keembay/ocs-hcu.c +++ b/drivers/crypto/keembay/ocs-hcu.c @@ -93,7 +93,7 @@ #define OCS_HCU_WAIT_BUSY_TIMEOUT_US 1000000 /** - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list. + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list. * @src_addr: Source address of the data. * @src_len: Length of data to be fetched. * @nxt_desc: Next descriptor to fetch. @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo) } /** - * ocs_hcu_digest() - Perform a hashing iteration. + * ocs_hcu_hash_update() - Perform a hashing iteration. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev, } /** - * ocs_hcu_hash_final() - Update and finalize hash computation. + * ocs_hcu_hash_finup() - Update and finalize hash computation. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. From patchwork Thu Feb 4 11:09:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067035 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E1DC433E6 for ; Thu, 4 Feb 2021 11:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C39564F5C for ; Thu, 4 Feb 2021 11:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235675AbhBDLM0 (ORCPT ); Thu, 4 Feb 2021 06:12:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235660AbhBDLLr (ORCPT ); Thu, 4 Feb 2021 06:11:47 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A4F8C061351 for ; Thu, 4 Feb 2021 03:10:13 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id u14so3030878wri.3 for ; Thu, 04 Feb 2021 03:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YOJ+0stIceIdJi6gdHHRkXSCGMt50djacvzyyNbvVcw=; b=OkprnsvGh/4iCVbft5YmnR2Jb6HJNl6FUvgyi0ohzPlkDoyujE+PV5tWOq5p7rXNKl rP4BL5KekdTmr/3Ac3WvbUdHnG2gkp8ufWZCbv82f2YBnhSuCzurxhyE/1x/ENxBydTq rWv2ylS0JpMRPOkNLVcHpE4ifph9eOOgdJ/2LfFE066u9neRaRKJezY7RgQIFBosG4as S9QOX49y5XkhJAhuxvgZGZa5VCHaM9UQ4Lsgsu9jF1kzx+COOOIxm1MJ9UVP9i2kdN+t RGXwGtGmPIpM845VkU5T5EFqYaJpnIWN9LTh1I6I7iSndZNea1aEe5Fy/nDvEILOOAC4 CikA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YOJ+0stIceIdJi6gdHHRkXSCGMt50djacvzyyNbvVcw=; b=q77HdJgv4QFq90aLTKFlj/I0og2aYID27jwBlEfdIR8cwJIx4MqujiaB4aOLUf903q jWG/LRoAygrowFFHataSV3MvZHJpo0Tsu1X9mDQ4y935ifzbXUxzbwtaRr//r1eTJMKx 2JeInX6PpmUads2JKcGVyh6ZVO0xGc3osY98TtpkPrr39QV7JnUZpsLGhiKNmjDqLPrE GX+z/i9mDLBrsPEJ4FZMo8Qa9faFWV6eP1l/tJ78sPz7/YUpTwAfo0ksVAu2N/rrr4bS NcRTfIztLctCvtnoH6YOUw413s+BOvOXXVjXnEJZ3c2kj4pDrPAR/AX+0zDNPrqJ/ubY FOrQ== X-Gm-Message-State: AOAM532bShoBi8bQ8yUFc1clWvrtqMozI3TDrX1cnDAhHVcp3mDm9q3/ YYCnMDOTdzQB1B01203Sm8/U2Q== X-Google-Smtp-Source: ABdhPJxsnmj8WFYBbrPuL737dyiQwIOcvHYZDrCiZ0g8tQ+Jk0OwlAxkU1M4333vGD76oNv/VA5yAA== X-Received: by 2002:a5d:68c4:: with SMTP id p4mr2686890wrw.62.1612437012061; Thu, 04 Feb 2021 03:10:12 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 07/20] crypto: bcm: spu2: Fix a whole host of kernel-doc misdemeanours Date: Thu, 4 Feb 2021 11:09:47 +0000 Message-Id: <20210204111000.2800436-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'fmd' not described in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'spu2_type' not described in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:557: warning: Excess function parameter 'spu2_cipher_type' description in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:615: warning: Function parameter or member 'auth_first' not described in 'spu2_fmd_ctrl0_write' drivers/crypto/bcm/spu2.c:615: warning: Excess function parameter 'authFirst' description in 'spu2_fmd_ctrl0_write' drivers/crypto/bcm/spu2.c:666: warning: Function parameter or member 'is_inbound' not described in 'spu2_fmd_ctrl1_write' drivers/crypto/bcm/spu2.c:803: warning: expecting prototype for spu_payload_length(). Prototype was for spu2_payload_length() instead drivers/crypto/bcm/spu2.c:825: warning: Function parameter or member 'is_hash' not described in 'spu2_response_hdr_len' drivers/crypto/bcm/spu2.c:825: warning: expecting prototype for spu_response_hdr_len(). Prototype was for spu2_response_hdr_len() instead drivers/crypto/bcm/spu2.c:843: warning: expecting prototype for spu_hash_pad_len(). Prototype was for spu2_hash_pad_len() instead drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'cipher_mode' not described in 'spu2_gcm_ccm_pad_len' drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'data_size' not described in 'spu2_gcm_ccm_pad_len' drivers/crypto/bcm/spu2.c:855: warning: expecting prototype for spu2_gcm_ccm_padlen(). Prototype was for spu2_gcm_ccm_pad_len() instead drivers/crypto/bcm/spu2.c:872: warning: expecting prototype for spu_assoc_resp_len(). Prototype was for spu2_assoc_resp_len() instead drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg_digest_size' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'htype' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:945: warning: expecting prototype for spu_create_request(). Prototype was for spu2_create_request() instead drivers/crypto/bcm/spu2.c:1122: warning: expecting prototype for spu_cipher_req_init(). Prototype was for spu2_cipher_req_init() instead drivers/crypto/bcm/spu2.c:1182: warning: Function parameter or member 'is_inbound' not described in 'spu2_cipher_req_finish' drivers/crypto/bcm/spu2.c:1182: warning: expecting prototype for spu_cipher_req_finish(). Prototype was for spu2_cipher_req_finish() instead drivers/crypto/bcm/spu2.c:1243: warning: expecting prototype for spu_request_pad(). Prototype was for spu2_request_pad() instead drivers/crypto/bcm/spu2.c:1321: warning: expecting prototype for spu_status_process(). Prototype was for spu2_status_process() instead Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/spu2.c | 43 ++++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c index 2db35b5ccaa24..07989bb8c220a 100644 --- a/drivers/crypto/bcm/spu2.c +++ b/drivers/crypto/bcm/spu2.c @@ -543,7 +543,8 @@ void spu2_dump_msg_hdr(u8 *buf, unsigned int buf_len) /** * spu2_fmd_init() - At setkey time, initialize the fixed meta data for * subsequent skcipher requests for this context. - * @spu2_cipher_type: Cipher algorithm + * @fmd: Start of FMD field to be written + * @spu2_type: Cipher algorithm * @spu2_mode: Cipher mode * @cipher_key_len: Length of cipher key, in bytes * @cipher_iv_len: Length of cipher initialization vector, in bytes @@ -598,7 +599,7 @@ static int spu2_fmd_init(struct SPU2_FMD *fmd, * SPU request packet. * @fmd: Start of FMD field to be written * @is_inbound: true if decrypting. false if encrypting. - * @authFirst: true if alg authenticates before encrypting + * @auth_first: true if alg authenticates before encrypting * @protocol: protocol selector * @cipher_type: cipher algorithm * @cipher_mode: cipher mode @@ -640,6 +641,7 @@ static void spu2_fmd_ctrl0_write(struct SPU2_FMD *fmd, * spu2_fmd_ctrl1_write() - Write ctrl1 field in fixed metadata (FMD) field of * SPU request packet. * @fmd: Start of FMD field to be written + * @is_inbound: true if decrypting. false if encrypting. * @assoc_size: Length of additional associated data, in bytes * @auth_key_len: Length of authentication key, in bytes * @cipher_key_len: Length of cipher key, in bytes @@ -793,7 +795,7 @@ u32 spu2_ctx_max_payload(enum spu_cipher_alg cipher_alg, } /** - * spu_payload_length() - Given a SPU2 message header, extract the payload + * spu2_payload_length() - Given a SPU2 message header, extract the payload * length. * @spu_hdr: Start of SPU message header (FMD) * @@ -812,10 +814,11 @@ u32 spu2_payload_length(u8 *spu_hdr) } /** - * spu_response_hdr_len() - Determine the expected length of a SPU response + * spu2_response_hdr_len() - Determine the expected length of a SPU response * header. * @auth_key_len: Length of authentication key, in bytes * @enc_key_len: Length of encryption key, in bytes + * @is_hash: Unused * * For SPU2, includes just FMD. OMD is never requested. * @@ -827,7 +830,7 @@ u16 spu2_response_hdr_len(u16 auth_key_len, u16 enc_key_len, bool is_hash) } /** - * spu_hash_pad_len() - Calculate the length of hash padding required to extend + * spu2_hash_pad_len() - Calculate the length of hash padding required to extend * data to a full block size. * @hash_alg: hash algorithm * @hash_mode: hash mode @@ -845,8 +848,10 @@ u16 spu2_hash_pad_len(enum hash_alg hash_alg, enum hash_mode hash_mode, } /** - * spu2_gcm_ccm_padlen() - Determine the length of GCM/CCM padding for either + * spu2_gcm_ccm_pad_len() - Determine the length of GCM/CCM padding for either * the AAD field or the data. + * @cipher_mode: Unused + * @data_size: Unused * * Return: 0. Unlike SPU-M, SPU2 hardware does any GCM/CCM padding required. */ @@ -857,7 +862,7 @@ u32 spu2_gcm_ccm_pad_len(enum spu_cipher_mode cipher_mode, } /** - * spu_assoc_resp_len() - Determine the size of the AAD2 buffer needed to catch + * spu2_assoc_resp_len() - Determine the size of the AAD2 buffer needed to catch * associated data in a SPU2 output packet. * @cipher_mode: cipher mode * @assoc_len: length of additional associated data, in bytes @@ -878,11 +883,11 @@ u32 spu2_assoc_resp_len(enum spu_cipher_mode cipher_mode, return resp_len; } -/* - * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included +/** + * spu2_aead_ivlen() - Calculate the length of the AEAD IV to be included * in a SPU request after the AAD and before the payload. * @cipher_mode: cipher mode - * @iv_ctr_len: initialization vector length in bytes + * @iv_len: initialization vector length in bytes * * For SPU2, AEAD IV is included in OMD and does not need to be repeated * prior to the payload. @@ -909,9 +914,9 @@ enum hash_type spu2_hash_type(u32 src_sent) /** * spu2_digest_size() - Determine the size of a hash digest to expect the SPU to * return. - * alg_digest_size: Number of bytes in the final digest for the given algo - * alg: The hash algorithm - * htype: Type of hash operation (init, update, full, etc) + * @alg_digest_size: Number of bytes in the final digest for the given algo + * @alg: The hash algorithm + * @htype: Type of hash operation (init, update, full, etc) * */ u32 spu2_digest_size(u32 alg_digest_size, enum hash_alg alg, @@ -921,7 +926,7 @@ u32 spu2_digest_size(u32 alg_digest_size, enum hash_alg alg, } /** - * spu_create_request() - Build a SPU2 request message header, includint FMD and + * spu2_create_request() - Build a SPU2 request message header, includint FMD and * OMD. * @spu_hdr: Start of buffer where SPU request header is to be written * @req_opts: SPU request message options @@ -1105,7 +1110,7 @@ u32 spu2_create_request(u8 *spu_hdr, } /** - * spu_cipher_req_init() - Build an skcipher SPU2 request message header, + * spu2_cipher_req_init() - Build an skcipher SPU2 request message header, * including FMD and OMD. * @spu_hdr: Location of start of SPU request (FMD field) * @cipher_parms: Parameters describing cipher request @@ -1162,11 +1167,11 @@ u16 spu2_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms) } /** - * spu_cipher_req_finish() - Finish building a SPU request message header for a + * spu2_cipher_req_finish() - Finish building a SPU request message header for a * block cipher request. * @spu_hdr: Start of the request message header (MH field) * @spu_req_hdr_len: Length in bytes of the SPU request header - * @isInbound: 0 encrypt, 1 decrypt + * @is_inbound: 0 encrypt, 1 decrypt * @cipher_parms: Parameters describing cipher operation to be performed * @data_size: Length of the data in the BD field * @@ -1222,7 +1227,7 @@ void spu2_cipher_req_finish(u8 *spu_hdr, } /** - * spu_request_pad() - Create pad bytes at the end of the data. + * spu2_request_pad() - Create pad bytes at the end of the data. * @pad_start: Start of buffer where pad bytes are to be written * @gcm_padding: Length of GCM padding, in bytes * @hash_pad_len: Number of bytes of padding extend data to full block @@ -1311,7 +1316,7 @@ u8 spu2_rx_status_len(void) } /** - * spu_status_process() - Process the status from a SPU response message. + * spu2_status_process() - Process the status from a SPU response message. * @statp: start of STATUS word * * Return: 0 - if status is good and response should be processed From patchwork Thu Feb 4 11:09:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067039 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC8AC433E0 for ; Thu, 4 Feb 2021 11:13:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F378364F5C for ; Thu, 4 Feb 2021 11:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235748AbhBDLNU (ORCPT ); Thu, 4 Feb 2021 06:13:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235705AbhBDLMM (ORCPT ); Thu, 4 Feb 2021 06:12:12 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C713C061352 for ; Thu, 4 Feb 2021 03:10:14 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id j11so2752102wmi.3 for ; Thu, 04 Feb 2021 03:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jD3fDhqrGmZlQJN4sE5tqUAObb8EheXiffPU2HNHONI=; b=SZwwWIeVUbG3QySuaV0bjefGVojXmvsBnf9OYpQkKUvrnDCTOz+SDdZdx557SGy7El E5ZPs6j/XSEL0D9wmKBdkDNTySxzq7Vl49xedFQDnrCEJgbQ0EHVSWrfHHw492aotv79 dsEeAEPP5du/ijeMImA+bpaUTWR6LihUNwMRIHRtnNX2w5vTdds2aC/l7z/HBN9VKjoN 7FMf1ohwJF0XNhE6UhUhflqOFeQl46S78SZdtcf42pFpO8iBsgjvfiybhLV7g5Gsq7lZ kG6ah3FwOu28XQyE91aJ22X5TQkQ8NGIKw5HmYmygpAe0sBXNdgqLD6U16BiIuAn3rAG QmLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jD3fDhqrGmZlQJN4sE5tqUAObb8EheXiffPU2HNHONI=; b=eOFQ9B6X8WUkJyZ9cjLYFYSVBEK9CP9htTxWmPtKRqWtah8A/z5aVra3zQsFSVxu+q cJmKpkuwOSQUT+1i6y7zTDz2mZV+8eQawEWAFrFha8FE1PgSml9SWMfNYklnMPIlOUnz imZTDlJrQgT2UxwOGvPL/3mFGFxF3EKIQpkJVZno22RxgZ6UO2MQtKP+vAE9tGY0lSq9 W1aA2GOZ05XtZRUHLKiM1yrASyIRXp0lNUw5euCE8/LuAovCRkvmVZIxLIWBsKEks2qU DmhMdN7/BRgGRbA7fF4i247QPQj9tIJDEOD1lRZNXnEP4kzCy0a+m/4BOBrXSuXlXJWq e5rA== X-Gm-Message-State: AOAM533q177SNU15A0VvZW6JVG5P3/8E+pEvzyo/CUIXBiqcYlBrHFMr hZOtqEpuD4CfAF6yEgcJV066gA== X-Google-Smtp-Source: ABdhPJzVT/7n6AdOU6B1akQQoIhqbYcrMOm6Gs+rjqT0lZnEi6yTeq/L26AxS87ReLE9AQ6SRbroOg== X-Received: by 2002:a1c:1b15:: with SMTP id b21mr3910742wmb.116.1612437013148; Thu, 04 Feb 2021 03:10:13 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , "Gustavo A. R. Silva" , Shujuan Chen , Jonas Linde , Niklas Hernaeus , Joakim Bech , Berne Hebark , linux-crypto@vger.kernel.org Subject: [PATCH 08/20] crypto: ux500: cryp: Demote some conformant non-kernel headers fix another Date: Thu, 4 Feb 2021 11:09:48 +0000 Message-Id: <20210204111000.2800436-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/cryp/cryp.c:19: warning: Incorrect use of kernel-doc format: * cryp_wait_until_done - wait until the device logic is not busy drivers/crypto/ux500/cryp/cryp.c:22: warning: Function parameter or member 'device_data' not described in 'cryp_wait_until_done' drivers/crypto/ux500/cryp/cryp.c:22: warning: expecting prototype for ST(). Prototype was for cryp_wait_until_done() instead drivers/crypto/ux500/cryp/cryp.c:292: warning: Function parameter or member 'cryp_mode' not described in 'cryp_save_device_context' Cc: Herbert Xu Cc: "David S. Miller" Cc: "Gustavo A. R. Silva" Cc: Shujuan Chen Cc: Jonas Linde Cc: Niklas Hernaeus Cc: Joakim Bech Cc: Berne Hebark Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ux500/cryp/cryp.c b/drivers/crypto/ux500/cryp/cryp.c index 9866c2a5e9a70..759d0d9786fd1 100644 --- a/drivers/crypto/ux500/cryp/cryp.c +++ b/drivers/crypto/ux500/cryp/cryp.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Jonas Linde for ST-Ericsson. @@ -15,7 +15,7 @@ #include "cryp_p.h" #include "cryp.h" -/** +/* * cryp_wait_until_done - wait until the device logic is not busy */ void cryp_wait_until_done(struct cryp_device_data *device_data) @@ -285,6 +285,7 @@ int cryp_configure_init_vector(struct cryp_device_data *device_data, * other device context parameter * @device_data: Pointer to the device data struct for base address. * @ctx: Crypto device context + * @cryp_mode: Mode: Polling, Interrupt or DMA */ void cryp_save_device_context(struct cryp_device_data *device_data, struct cryp_device_context *ctx, From patchwork Thu Feb 4 11:09:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067041 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75303C433E0 for ; Thu, 4 Feb 2021 11:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45FC064F5C for ; Thu, 4 Feb 2021 11:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhBDLNn (ORCPT ); Thu, 4 Feb 2021 06:13:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235707AbhBDLMN (ORCPT ); Thu, 4 Feb 2021 06:12:13 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8084EC061354 for ; Thu, 4 Feb 2021 03:10:15 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id t142so586209wmt.1 for ; Thu, 04 Feb 2021 03:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=trb1gYFzPUUg8uq7WKCS8xTgh11NyriG6ftUBu1Ewok=; b=Gi5+E6fczIL1TMNS+SiiMfhWSn0MgAOwW1Y5q9y/wnnkLhri4gsMZWClg6sD4Myxdb Id3u6wIwHCsme2xp1E+1czYA94c5X8WJVuI9jgFdM+MCQCA2UVV25HGh5Svnk1iZ/2Wz LiqZyE5ktBUaAiPNZl4Lr7E/DkBTvONVsE+/eN3T/rv+Mi65h6gw2F6Oy1dbexkrq5gA qAvYwzAf/ZowfI4hiteB1SwUB3SZv9bo5iB5aBuFwe0MmOSlrtQkJmhB1IImzYghg7j8 Im/MPx/TrceWNYgDeWguc5nH+fEbRR7GT4USjgjaapE1OYp2B4WlzBN0mVpuIPxNbI8g G+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=trb1gYFzPUUg8uq7WKCS8xTgh11NyriG6ftUBu1Ewok=; b=LWYI32E51yAe9J7Q8twCxHQwMwUn59AsgYstq2aF0EHoJbTHc004Bg5aMoHwsAWiNI s5A6NrAlHXgU0UsLOJdjP+GNczHobSuzncfNLisPSDGNVdO9OLMZG+T8l9XkTJl+MtYj UIz447Rh5xoHdhy9b6S+VtviQi4bIvt7VOxDVWKrWMqViUgHmbGXApq5cc9oGOHw5Ka8 FcL79QbcMfQ+41uYxtjKAWvt8suB9/3Oam57Y1IsKSZlXDL9SmjswWeV+opMU2CR0mjV beHYuI/jN30bAGMOJ7lujnIUwOEsEFc/vwTN+lpL91zSiJMt4PFte2PGSrSd9CsGS8Nz YjdA== X-Gm-Message-State: AOAM533bnbo613KzHkZJdBDrBZHpbCczLcAT+fuMzUgCwEjLE4W4RLK6 tuJf/ip+UadTBwUFv2kfzovyBQ== X-Google-Smtp-Source: ABdhPJzrfuBFqr+PYF2oOLIi5LxzlWlKdWdoKlj475mia7KZa9QKAXn+t2C1kmSmxVpmFfknLtFEvQ== X-Received: by 2002:a1c:65d5:: with SMTP id z204mr7053809wmb.184.1612437014285; Thu, 04 Feb 2021 03:10:14 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Shujuan Chen , Jonas Linde , Joakim Bech , Berne Hebark , Niklas Hernaeus , linux-crypto@vger.kernel.org Subject: [PATCH 09/20] crypto: ux500: cryp_irq: File headers are not good kernel-doc candidates Date: Thu, 4 Feb 2021 11:09:49 +0000 Message-Id: <20210204111000.2800436-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'device_data' not described in 'cryp_enable_irq_src' drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'irq_src' not described in 'cryp_enable_irq_src' drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: expecting prototype for ST(). Prototype was for cryp_enable_irq_src() instead Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Jonas Linde Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ux500/cryp/cryp_irq.c b/drivers/crypto/ux500/cryp/cryp_irq.c index 7ebde69e8c76b..6d2f07bec98a7 100644 --- a/drivers/crypto/ux500/cryp/cryp_irq.c +++ b/drivers/crypto/ux500/cryp/cryp_irq.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Jonas Linde for ST-Ericsson. From patchwork Thu Feb 4 11:09:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067037 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8387FC433DB for ; Thu, 4 Feb 2021 11:12:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56AD164F60 for ; Thu, 4 Feb 2021 11:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbhBDLMl (ORCPT ); Thu, 4 Feb 2021 06:12:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235682AbhBDLLu (ORCPT ); Thu, 4 Feb 2021 06:11:50 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1DB6C0612F2 for ; Thu, 4 Feb 2021 03:10:16 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id v15so3019270wrx.4 for ; Thu, 04 Feb 2021 03:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=avN1u0Er/3jjbceQj3GDRB5KtHhfEhx0wpHOx8svPCg=; b=tbTk9psUc52Wwl90sZuJm/3vqked4L4RjNIaBf8tRL3qUxnaYWAE+Ijgg+Mwqge9mh C+lQ2LAaNUd9Jby+KXE88A9m6VnjNMqHu3U+EsZWNpHpUszlyKG37cJ9SOo0WjV/mT/H xJ020nufrEvJlN3WnYNB8z0mFMgP2fOISxcMVHdZUIxQtwUjbPr3FrvLIJtN3NyLBrZZ lk03+BTzI04dXjyjLMiY6b+JWk4ZeMOBhbROzr4VHLi+VTfY902xPc80ZK5aJsSZQb2n p0AALHyUhOwxR8ahBOkzU2+qOXqLDLRKm4bZwq+Seczaee2tiX+pXxfT6FVQn4Ic5JY4 pG/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=avN1u0Er/3jjbceQj3GDRB5KtHhfEhx0wpHOx8svPCg=; b=YmTjSDlTVNjLqxarN0P5y61SjEDCOWo1vToHH+c4CbK/r/mE6LRp1mW+VPiRP6WAP3 Fa9A30VMJ3J0Nue3GPlWTviAvdzhq5gQ0jZW2XMgp7GP8h0fl/EQuDK2qCo4KTHVd6/0 QeqT/GrW+nWYuRNHNCDujWaqiiU8vnRTgf1MXEFmB6OX5xe2F9QISjaHo1L3ezah4kti 25q9Vs+2rf8CvD13EE/9BViVneZsGk1Q8w5U93YbMPqSXWjgpnN6pf8DPYn5I2R+/TK9 UY0JwsWIGN/VGpiFvP+M9t068Wgm/AAMHG87/9S2TVD1u2mc84h9VpXMNxu6/W0d1sy6 8idg== X-Gm-Message-State: AOAM533tEUcKOpqVuVNz+AsFhn/X9aZhFD+HeEOYDVE0JaqXGBsV4K0E 7ErNy0YX7uOTI3uB+WSqw76nxw== X-Google-Smtp-Source: ABdhPJzTMVni3uUeJoJsuMcvVIXormUpRYGc5uC7YJqFJZbIZqsofBqllUbt0pYWV02sTZYFmPC61g== X-Received: by 2002:adf:dd05:: with SMTP id a5mr8572303wrm.402.1612437015406; Thu, 04 Feb 2021 03:10:15 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Herbert Xu , "David S. Miller" , Manoj Malviya , Atul Gupta , Jitendra Lulla , M R Gowda , Harsh Jain , linux-crypto@vger.kernel.org Subject: [PATCH 10/20] crypto: chelsio: chcr_algo: Fix a couple of kernel-doc issues caused by doc-rot Date: Thu, 4 Feb 2021 11:09:50 +0000 Message-Id: <20210204111000.2800436-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member 'wrparam' not described in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'req' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'ctx' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'qid' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'op_type' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'req' not described in 'create_hash_wr' drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'param' not described in 'create_hash_wr' Cc: Ayush Sawal Cc: Vinay Kumar Yadav Cc: Rohit Maheshwari Cc: Herbert Xu Cc: "David S. Miller" Cc: Manoj Malviya Cc: Atul Gupta Cc: Jitendra Lulla Cc: M R Gowda Cc: Harsh Jain Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/chelsio/chcr_algo.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index f5a336634daa6..f77d3fd962bf8 100644 --- a/drivers/crypto/chelsio/chcr_algo.c +++ b/drivers/crypto/chelsio/chcr_algo.c @@ -797,10 +797,7 @@ static inline void create_wreq(struct chcr_context *ctx, /** * create_cipher_wr - form the WR for cipher operations - * @req: cipher req. - * @ctx: crypto driver context of the request. - * @qid: ingress qid where response of this WR should be received. - * @op_type: encryption or decryption + * @wrparam: Container for create_cipher_wr()'s parameters */ static struct sk_buff *create_cipher_wr(struct cipher_wr_param *wrparam) { @@ -1559,7 +1556,8 @@ static inline void chcr_free_shash(struct crypto_shash *base_hash) /** * create_hash_wr - Create hash work request - * @req - Cipher req base + * @req: Cipher req base + * @param: Container for create_hash_wr()'s parameters */ static struct sk_buff *create_hash_wr(struct ahash_request *req, struct hash_wr_param *param) From patchwork Thu Feb 4 11:09:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067065 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0CFC433E6 for ; Thu, 4 Feb 2021 11:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B0AF64DBA for ; Thu, 4 Feb 2021 11:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235574AbhBDLSM (ORCPT ); Thu, 4 Feb 2021 06:18:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235710AbhBDLMP (ORCPT ); Thu, 4 Feb 2021 06:12:15 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C30C06121C for ; Thu, 4 Feb 2021 03:10:17 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id j11so2752253wmi.3 for ; Thu, 04 Feb 2021 03:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zBZEiBnCpDze/1GuNJ3i38XwYi6MurOqLTEFwMePbaw=; b=P9bFnE5keghdh3BWBUni3jDga4wzhgq6MltnIId6KX0E3x3XTkggNsmjWbaYy/CbvQ 5PI5SiqqrEnylEv2Kb2BcDmwoSuuXytdIbhaWuHUEO5NJfsqGHMa7rdAJlKyTTteJWAF HwM4Ugjfd4P2UIcA1Kl1XU9+6uwaaD/gGJdRQMeTu91HD0lmmBjgqQ1myxJPJy3ap0li xFQOKxmaMFOsMlKGvAYN/AOLw+npaUZLgWIBHgg9YzLiJpn3jN1UgpZd78eT63HMxGJR 76KYyHGu36j2+iTkHinJ49RIPRe9Nqp1HKCUTwijHUr9fZ7c2HW8y/nlBGeOBx9zMUK3 mVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zBZEiBnCpDze/1GuNJ3i38XwYi6MurOqLTEFwMePbaw=; b=O1CbzhLMXhXRybvK/dsLa3hfhVQvAYwJDsBivqV/usfEibkjzESkslSNB+Uxpi71gg qu+JBWZcL5Af8lKz3VwbfB/J5J0Cs8B9IMSRusH3gATp3pLXr/gSeBhNIfKIZCgyAPuB YXd5tBBY7oQOGLEBvYPtLLqyjsWn1OJh16ja2UReQZ3z6o+nEaaN/yaSu2PE6a5KF1Nb lResyFnjGMejI2N2Lv+y4aD8L7kS0c2BpeP6IIUWzgQiEp7LG9bgGpeZaa5SjYvNH5S4 xJXPL2B185HJcNz5T7+Jy8zk9y8Q/qSHHbSdVVMiNGZK6oX3atf4h6HqHZJhAbwa7wTt tDIg== X-Gm-Message-State: AOAM530U9QG7nWaef076AuL45qTO5LIo2HKgXSbItwij8aqQtE/wd+WJ 3jW0Ibiurpgeek8/VQ8qAMhejQ== X-Google-Smtp-Source: ABdhPJxa0jBjTk9Ppr0Vm14I1WsrfGS8lDuYZwfoumBJ/YUQ89k6+Y07+/2DRivZIeayEMmQPc1/wg== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr6821220wmh.38.1612437016576; Thu, 04 Feb 2021 03:10:16 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Shujuan Chen , Joakim Bech , Berne Hebark , Niklas Hernaeus , Jonas Linde , Andreas Westin , linux-crypto@vger.kernel.org Subject: [PATCH 11/20] crypto: ux500: cryp_core: Fix formatting issue and add description for 'session_id' Date: Thu, 4 Feb 2021 11:09:51 +0000 Message-Id: <20210204111000.2800436-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/cryp/cryp_core.c:42: warning: expecting prototype for ST(). Prototype was for CRYP_MAX_KEY_SIZE() instead drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'key' not described in 'cryp_ctx' drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'session_id' not described in 'cryp_ctx' Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: Jonas Linde Cc: Andreas Westin Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c index c3adeb2e58232..25ce56d05084e 100644 --- a/drivers/crypto/ux500/cryp/cryp_core.c +++ b/drivers/crypto/ux500/cryp/cryp_core.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Joakim Bech for ST-Ericsson. @@ -62,7 +62,7 @@ struct cryp_driver_data { /** * struct cryp_ctx - Crypto context * @config: Crypto mode. - * @key[CRYP_MAX_KEY_SIZE]: Key. + * @key: Key array. * @keylen: Length of key. * @iv: Pointer to initialization vector. * @indata: Pointer to indata. @@ -73,6 +73,7 @@ struct cryp_driver_data { * @updated: Updated flag. * @dev_ctx: Device dependent context. * @device: Pointer to the device. + * @session_id: Atomic session ID. */ struct cryp_ctx { struct cryp_config config; From patchwork Thu Feb 4 11:09:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067061 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1930AC433E0 for ; Thu, 4 Feb 2021 11:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D414464DBA for ; Thu, 4 Feb 2021 11:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235692AbhBDLRW (ORCPT ); Thu, 4 Feb 2021 06:17:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235714AbhBDLMR (ORCPT ); Thu, 4 Feb 2021 06:12:17 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D88C06121E for ; Thu, 4 Feb 2021 03:10:18 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id j11so2752303wmi.3 for ; Thu, 04 Feb 2021 03:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PLs7LqNAnAgmBAtmZ421+3eJ35mH5VQmNcNQ6hrZ2jk=; b=w/YWwwHoBalPlN40RqolDputHUgs7ltrteDMkwSbm450sjnKe1GilEIqQfKOXYqVwT p6puBv8aesKr6hgfHUiv1B8b86YehM3QV2FYexzTjV/OqgDNe4CH8gsM8XEhHE5Z0wXs z1ywor6NhTVY05+bdkOpo0gNIEXWZ+NckY194k9i6cdc+Gqaa2StQ9lDAcdaTUSthi+d D7qBXrPlPKs2HVbkCFG4TyjQbVEyV00Q2Vz16RnI/HC856+Y0STTCBN5AiOyulcpTvOc UQo2UFGhjJM4dMBVOLVpGSBR3ogP1goMVoSma2uWn7PL4yVKWH2s4mNnyK3SyjSdav6s yuKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PLs7LqNAnAgmBAtmZ421+3eJ35mH5VQmNcNQ6hrZ2jk=; b=OG8voaQECwuk4XHzkdSVoCbwF03Zvlgj/s4MVzAhfvjo8Y3B2var18VrHOn7FeJati 83xBtlu5RD0/3H3Z1M2NE56o2/p/hTnylwQH+Y16hNBqVgHaN05RRkA396WQR6BY1akl Op91Mv9SaHoGvPCj2qU0SrGDERIZ+w5/zZs9+WTQxc3rHLONh36hCLfveE4oO6y2RPT2 9BirLN7jNc2NMUdODnaKEC/e9PT40of6Ow31yjXHAIYQLZkmkf2MphgGZ3KuTd4lCRYZ XJP0KSga7lrpat14Tex9MlF+kK9ONgRxZVDat+codRJdapBL4IEq08PL+1C2i/VhLEQe RcOQ== X-Gm-Message-State: AOAM530ve/F0/hGXhrGdDjJyokIjO6AyHgJsHaxZi8WQr0Cgmet6cmrp NpgQgXI3En2zTK8DQyI+dVmnIA== X-Google-Smtp-Source: ABdhPJwJkNyvrnalG1Avr6T8KZZg+DzNeFqzqCm+eQXMQLyMgzq5Tvxx/4+S0HlsUpBPvunszAe/Ng== X-Received: by 2002:a1c:3587:: with SMTP id c129mr6949813wma.76.1612437017719; Thu, 04 Feb 2021 03:10:17 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Tudor Ambarus , Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/20] crypto: atmel-ecc: Struct headers need to start with keyword 'struct' Date: Thu, 4 Feb 2021 11:09:52 +0000 Message-Id: <20210204111000.2800436-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/atmel-ecc.c:41: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx ' Cc: Tudor Ambarus Cc: Herbert Xu Cc: "David S. Miller" Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Tudor Ambarus --- drivers/crypto/atmel-ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 9bd8e5167be34..66a31e5739f4c 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -26,7 +26,7 @@ static struct atmel_ecc_driver_data driver_data; /** - * atmel_ecdh_ctx - transformation context + * struct atmel_ecdh_ctx - transformation context * @client : pointer to i2c client device * @fallback : used for unsupported curves or when user wants to use its own * private key. From patchwork Thu Feb 4 11:09:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067057 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1BEC433E9 for ; Thu, 4 Feb 2021 11:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90EC564D9D for ; Thu, 4 Feb 2021 11:17:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235693AbhBDLRX (ORCPT ); Thu, 4 Feb 2021 06:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235620AbhBDLMT (ORCPT ); Thu, 4 Feb 2021 06:12:19 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F563C061220 for ; Thu, 4 Feb 2021 03:10:20 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id m1so2640631wml.2 for ; Thu, 04 Feb 2021 03:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SaJWQD4EKpGmPpCanTvsNZ7Bn2MtR7BiI9nKxNlqVtw=; b=U+WBo23B0peFGorO7gesn2YLEsU8eTQip1OggOGRWj1tPIbr8SwXLLk1casRK5oCnn wkWdjrLJKUtXzardMlzF4vwCmPlwj1cLOQoxfEGW++0ld+5uHLBWyCN5ko9hoTUckX+X uArTd51/R6O83F5TihJAeEchRufyzEB0S3wmgVSyBcEydwdWTYM5I/rDflMzWqkQqi53 9NOZ8rJCvTUn+25rZDqOLL289kDdHhGluWeno1A5xodiH1HDLi5RkgPSbKc5mpClIYvz JPzzOSL/SLa965FohBQyvskS+qj9B32WsihhrnY9rRdcE268GDj0rbquT3YAZOy01gh3 x4rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SaJWQD4EKpGmPpCanTvsNZ7Bn2MtR7BiI9nKxNlqVtw=; b=LBBCLoeCqfzO35Quso3XgPznx8psK8lp4UK5tHN3MJyG7CAtolMIxP3Nl5T2xke8II QI+jxfhbcpMO3C20TQhCFzIOU/xSgmi+zPWEMNdwOT9cXmiXUgdKohTuNFUyuGQHVxTI rvrUmCHah6UKfrnuXbVH9YF4byjQZtdCL+ZyZNfsSkkcB0/zVJ+Rh85UBr+IefBzA5UO WhTlr+MaxeCcTieKLrHH9Ng5i6VHBdLez9HYHPpfmdRUcAMZLtDSAxykK3u89doYew4l +7OK7rtrEA2ZhY9b+d7PYUYtF4wGZ9kes94odeBYrzkBsIXG5z/Ye+mYXdt55XKZ1kQN rOpQ== X-Gm-Message-State: AOAM533+xMxvV2Y+suaopLY2BvpgTiYeQVufarxK7E/Lc2Da4LN+bBi2 LLfoWB9ULkgm9IbEyQYoPYv2xQ== X-Google-Smtp-Source: ABdhPJxXqrSBs7UvzogxtH4gMcXG9+M+TmLs+sXRxykZ+DZpXvSgND5kRWDw2l55vrKZjOgmA443ew== X-Received: by 2002:a7b:c856:: with SMTP id c22mr1529367wml.5.1612437018821; Thu, 04 Feb 2021 03:10:18 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Rob Rice , linux-crypto@vger.kernel.org Subject: [PATCH 13/20] crypto: bcm: cipher: Provide description for 'req' and fix formatting issues Date: Thu, 4 Feb 2021 11:09:53 +0000 Message-Id: <20210204111000.2800436-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/cipher.c:1048: warning: Function parameter or member 'req' not described in 'spu_aead_rx_sg_create' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'cipher' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'key' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'keylen' not described in 'rfc4543_gcm_esp_setkey' Cc: Herbert Xu Cc: "David S. Miller" Cc: Rob Rice Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/cipher.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 851b149f71701..053315e260c22 100644 --- a/drivers/crypto/bcm/cipher.c +++ b/drivers/crypto/bcm/cipher.c @@ -1019,6 +1019,7 @@ static void handle_ahash_resp(struct iproc_reqctx_s *rctx) * a SPU response message for an AEAD request. Includes buffers to catch SPU * message headers and the response data. * @mssg: mailbox message containing the receive sg + * @req: Crypto API request * @rctx: crypto request context * @rx_frag_num: number of scatterlist elements required to hold the * SPU response message @@ -2952,9 +2953,9 @@ static int aead_gcm_esp_setkey(struct crypto_aead *cipher, /** * rfc4543_gcm_esp_setkey() - setkey operation for RFC4543 variant of GCM/GMAC. - * cipher: AEAD structure - * key: Key followed by 4 bytes of salt - * keylen: Length of key plus salt, in bytes + * @cipher: AEAD structure + * @key: Key followed by 4 bytes of salt + * @keylen: Length of key plus salt, in bytes * * Extracts salt from key and stores it to be prepended to IV on each request. * Digest is always 16 bytes From patchwork Thu Feb 4 11:09:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067063 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A557FC433E0 for ; Thu, 4 Feb 2021 11:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 802E164DBA for ; Thu, 4 Feb 2021 11:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235558AbhBDLSE (ORCPT ); Thu, 4 Feb 2021 06:18:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235712AbhBDLMQ (ORCPT ); Thu, 4 Feb 2021 06:12:16 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58561C061223 for ; Thu, 4 Feb 2021 03:10:21 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id o10so5705546wmc.1 for ; Thu, 04 Feb 2021 03:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uyplMPucg3iOrY2nniY7G/Evy8Npfc2vFaJnW0PI2LM=; b=ekSQxHuxk0xtv21ZbQcl2ycKHt8Ml1KkajwaP+MZ+rkIEOSQZN9fbTd68tzTYsXJQ9 +rQ0llJvLZ8qiSdH/lZPKwZNHsU3cdD+iyEO0eNGKU4JOpzZwnGJJaZ+DDtr5MH6ZZX/ S8d31UtxU4seUHnrcDhWzqwl0aZcR6YZVZV7M+IvYbDsaRwSgiB987TrWAqzH7pmJVfA MfI8emBtsqNE+bdcIo9IVdA0IRz3IANyq3P5wIJHyCQdfz35SGGo6ttWiPDa2cQ7EV8x iiYDsDd5ifoCTI86AVcyAe31nuMsbq60tYKq9eTidpAbJ0pDdOS207XZUJ6SjA36ko+4 eg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uyplMPucg3iOrY2nniY7G/Evy8Npfc2vFaJnW0PI2LM=; b=eQnmpYXj2ziLaaNmbAzwpjM+E86VPlAizGLOvAT9srHe9mwGjMJl7YyXhb2uOc2qZw bXwPRuEOVPJSxE1vjlYOPyvSzA55EB7SItPSdb+kaHVEjsynCcKoZZNewdR68ySjpopV l2AHBL5L9YtpPMIYXAJVSEyry/oscepLVUh9lHsiRnHjja6LwKMNqPurK8z8TnK4JPEc sIbxyIJFX8wg2OZXBOT9hPCSa1hKJvP8zmlxE4ArYk0DHLKDqhLJ30rwPrgd766NmtJd 9Pyihe3lH1UAPe27jQlJzmvIOoW75xrrP6lMY2fyGzJQY3EmFxMqBmgbn9KxSzwDgyl7 CAAw== X-Gm-Message-State: AOAM532Pp6y25qEKe5I1zui5S5a4TiBloPJjEpgXJyH+wMZeTjlD3mdv Ixl8I5rJ9GKjK4cSrtaVzvrXFw== X-Google-Smtp-Source: ABdhPJy1JNJu3m4t+MVtGxQYZO5Rm/NID114zcurjbrW+Yzs0lZ8GlMJ8K6ULDLLoxf2mMqmiHtcWQ== X-Received: by 2002:a1c:720d:: with SMTP id n13mr6860166wmc.103.1612437019961; Thu, 04 Feb 2021 03:10:19 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 14/20] crypto: caam: caampkc: Provide the name of the function Date: Thu, 4 Feb 2021 11:09:54 +0000 Message-Id: <20210204111000.2800436-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Horia Geantă --- drivers/crypto/caam/caampkc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index dd5f101e43f83..e313233ec6de7 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -187,7 +187,8 @@ static void rsa_priv_f_done(struct device *dev, u32 *desc, u32 err, } /** - * Count leading zeros, need it to strip, from a given scatterlist + * caam_rsa_count_leading_zeros - Count leading zeros, need it to strip, + * from a given scatterlist * * @sgl : scatterlist to count zeros from * @nbytes: number of zeros, in bytes, to strip From patchwork Thu Feb 4 11:09:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067055 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306F7C433DB for ; Thu, 4 Feb 2021 11:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E117E64DBA for ; Thu, 4 Feb 2021 11:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235680AbhBDLRU (ORCPT ); Thu, 4 Feb 2021 06:17:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235715AbhBDLMR (ORCPT ); Thu, 4 Feb 2021 06:12:17 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32AF1C061225 for ; Thu, 4 Feb 2021 03:10:22 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id i9so2643446wmq.1 for ; Thu, 04 Feb 2021 03:10:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cxGJzZpz6qA+xiFT2fhj08K+AKiamZQBAjKu1cuB41g=; b=jyzJD24RWHuFc5gDwgp323TJgiD6YaBqxMG6JkMwvjTxcEH7LlCcpHG82W+8onqbfD IAfOefk8CiqkWG36lQ28CVBCphq/KgkKuepfBF0mbuniWh5ZtkKIbyo+prC9vXxRF2eb fFtE0vGQ/sNuTSjxnXD8iI5P6qI7On5v1kbxDeS2yUQ1G5T5G1rrl2SI694sSjiuhbrz LgxPl/W8gdORHLo+1GHLho7+XoF9aRSOax5OeXK9lyNMoP37DsfhkerUXNewLL8qtm4z i7JGhPPFCuPiavkerDwp4Cs1LhpGQzAQVKjx2gOF7SDXB5Ph0TtQA136NQ6vnyj2KD0D Ll4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cxGJzZpz6qA+xiFT2fhj08K+AKiamZQBAjKu1cuB41g=; b=J1CrUYiQGuyfNs8h2v8UUgCDjgx/r5f/ln4W9SALqrYJEFY+b3Shx04F3lgJDO0D1l bAFRVMYAazFi07PoNFrXgJLqHYIIURqaSDlW40MeQdv9Jo8+X5kDK9ptmflAtMlgJ4Ou QSBS7D0LgIygjhmqfU+a+zZy54qkA1l6sQ0GHCMAIjQaU/u2GIrJp8WEHpTQL7gf80d6 BxhKJfyJbqXSaQrt60MUQQmAdka6a4D8dlaMKrHG1XfRsEJb40XVvUW0y55ni6Wpz7h/ Z4N2JsFVODfSDYdmLBS6fO1kKgUi11zgTvixbb228bkPDhZGvojixrIT67TpumVv12c+ 6MhA== X-Gm-Message-State: AOAM530hM6b5c7sxgfxmUmkbIa+LKZzMKPtdgJrrDZFbBInWLSr+sfS1 KcsyKCjfsgv0bRorQDlAubdFpw== X-Google-Smtp-Source: ABdhPJwd9xdvyO+0bCKJVzM+EKxnNtd4uas/Onrew1JvEjI4x3rojBBg47BW4DbMHR4XwYf9F06qlg== X-Received: by 2002:a1c:1b15:: with SMTP id b21mr3911278wmb.116.1612437020990; Thu, 04 Feb 2021 03:10:20 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:20 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 15/20] crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related descriptions Date: Thu, 4 Feb 2021 11:09:55 +0000 Message-Id: <20210204111000.2800436-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx' drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx' Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/caam/caamalg_qi2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c index a780e627838ae..22e45c5bf2023 100644 --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c @@ -71,6 +71,8 @@ struct caam_skcipher_alg { * @adata: authentication algorithm details * @cdata: encryption algorithm details * @authsize: authentication tag (a.k.a. ICV / MAC) size + * @xts_key_fallback: whether to set the fallback key + * @fallback: the fallback key */ struct caam_ctx { struct caam_flc flc[NUM_OP]; From patchwork Thu Feb 4 11:09:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067059 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 039A8C433DB for ; Thu, 4 Feb 2021 11:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE9C864DBA for ; Thu, 4 Feb 2021 11:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235608AbhBDLRZ (ORCPT ); Thu, 4 Feb 2021 06:17:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235716AbhBDLMT (ORCPT ); Thu, 4 Feb 2021 06:12:19 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8523FC0611C0 for ; Thu, 4 Feb 2021 03:10:23 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id w4so2744673wmi.4 for ; Thu, 04 Feb 2021 03:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VZFcUa8z9ij8GsVZGG8CeCF7Ivx0FCQR9n9Ud5IB6q0=; b=yoOOHsJmUFa9/ZMIOvUiWAVGaV0lecpKRROSNn73bOTaoWxilhWpNvougW3IaJU11M BVkhVn/LG7rzlvj+VFlMOu2jZ16XdmDP7j7nFPRSoQfbQGizNQ0MysoTX/Ih0sURIkkJ jj2NKa4nkkgpng7ay0Yb/XckBZF6BoHaNRvJxyE0CFDhvk/OQMGNw6P52ILsu/BLONMX sGU9ch76oz25jqxjuLtMuFlH5wg1GQjs8Su8XyxDU7H84HQ6aUmAroBCLgq4h+/I22QB U8SZRrv4BsmpmnvZt6lJ9Y4abHaGLyIEQ9BJGCbmgZEEN4Cbv/Cjar+aCibvBqgV7jDz IW/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VZFcUa8z9ij8GsVZGG8CeCF7Ivx0FCQR9n9Ud5IB6q0=; b=KGppnKUiWVWglRkjH+SH1uouvYgywF/LJfNaZTNTpfS38EtD15s+NhnWCUAMIbE93y V7n9sQ3Px/qWgPVSnp8gt6K9KzxTbH8WEj3DVO6+FBMZ+nocGwgy7SmSNwLiIKWyzVmC rYkbrGsmoy2sBBMmuv27JrH8sFv4B2y+iIpaDQoeoZYoMtMSPbTAKzxVVGRcis7SUPNF 0Da4PrvEd/F5SXHJr8IouoNEXl2qcmq05TXdT5tgp25NZeLuapBMdjMTk0jzsPKZFLPl 3yq47BM210DuOgoXjPdYte7j9U0yLoRI1pY0RSTW0juBaFVJo7Y3y13mH/fGelAwtCHm +bsQ== X-Gm-Message-State: AOAM533bLW5KzI4hW/g+d6aB0E0UWjGYX4ekgIhHIGGu8aIbSTbdTQpm 8AQ5ZnKPVruYnm8yLttC97A9Cw== X-Google-Smtp-Source: ABdhPJyH2Oy1OTUDZXbRtCQuenPHqsyeaSnIpQ8LSjm16+yMUa9mogmKK1zeOQjPoP79U3cAkVO7Jg== X-Received: by 2002:a1c:1f4d:: with SMTP id f74mr7213122wmf.12.1612437022191; Thu, 04 Feb 2021 03:10:22 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Henrique Cerri , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 16/20] crypto: vmx: Source headers are not good kernel-doc candidates Date: Thu, 4 Feb 2021 11:09:56 +0000 Message-Id: <20210204111000.2800436-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/vmx.c b/drivers/crypto/vmx/vmx.c index a40d08e75fc0b..7eb713cc87c8c 100644 --- a/drivers/crypto/vmx/vmx.c +++ b/drivers/crypto/vmx/vmx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting VMX instructions on the Power 8 * * Copyright (C) 2015 International Business Machines Inc. From patchwork Thu Feb 4 11:09:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067047 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BF7C433E0 for ; Thu, 4 Feb 2021 11:15:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD8AF64F5C for ; Thu, 4 Feb 2021 11:15:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235677AbhBDLPL (ORCPT ); Thu, 4 Feb 2021 06:15:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235614AbhBDLMo (ORCPT ); Thu, 4 Feb 2021 06:12:44 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7218C0611C1 for ; Thu, 4 Feb 2021 03:10:24 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id a1so3006625wrq.6 for ; Thu, 04 Feb 2021 03:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WH1ZkfxgQ3lo4eJG51Uh12VlkOp1jMaFfnNoEjI139M=; b=Fwbq732n3XUVYiF70e2xZk4Vv0WePzbXGtV9K9CQP0xq5MmYe2c1lY5kO8By5tRjBe h/KA0K8rJ45UbLKMQLzOekJPUNVk5R0Om5p11Ff0vp99wZakGBPCBj8dWsHSAvV/t1Jy Em53nt90VnSrtADHul75DC0T1PvBiYW6mxchyjXt+UDaBOqcW3io+1cHBqMULe5ZSN9k 9VaxajxrSgxEtiTW6jkWSFCATt4sKdT1RhryJqH+6qBX9rzO/9FE9T8WR7IlAugxKF4f AKRQOxG56UXsyGqq9pkdFUnBuY5dZU6VpUrZCTdsDpJvbLR08WYPESgjONFzBpadKw1x 3MPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WH1ZkfxgQ3lo4eJG51Uh12VlkOp1jMaFfnNoEjI139M=; b=TTuqBn5LYKDq1tmhr/zsZYkiTFe9BTMo0YYFLkSJzN7ZfJg+v+QYy3YCjAyAkSikx8 ZAwcqJXeoMTCyvu5JohM9s1OTNw2kKNIzzY0GPPnPFdgKhxC8UXdo9FynI5jmLwyvNcS aSNaXtT2O46ehTUXE7UjectkieE+5NJbqEv6YEPR/Uu25p9yqLQjcO2HQwabQPprKfs+ qsu9X43Zw3mc6kLdcow4IqflpZlwIGSK+SDlcL5JwLQJwDedmE0/hD3Eown9NHwgvXoU ne8+l4CuAOqj//53sbpq7NuB9ThsoWgibcXhxYZa6ebMybsPbU6Gkf6nv5gpc6PRRRSq LMbA== X-Gm-Message-State: AOAM533nJmest3aFp95VWUt0Uhh+F9UbAoyYpbXIRQBFo0Cm5H1NhHEn FtcgJjqUmxCwbx/ZYR/5fJsSzQ== X-Google-Smtp-Source: ABdhPJzjUp9+e7p/dg0UnaZ0rUY3UY0nKqEvrLN6uQoqxKKkifC3adrh0/+QNGokJy751vuZFU+CFw== X-Received: by 2002:a5d:420d:: with SMTP id n13mr8658453wrq.320.1612437023472; Thu, 04 Feb 2021 03:10:23 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Kent Yoder , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 17/20] crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc Date: Thu, 4 Feb 2021 11:09:57 +0000 Message-Id: <20210204111000.2800436-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-aes-cbc.c b/drivers/crypto/nx/nx-aes-cbc.c index 92e921eceed75..d6314ea9ae896 100644 --- a/drivers/crypto/nx/nx-aes-cbc.c +++ b/drivers/crypto/nx/nx-aes-cbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * AES CBC routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. From patchwork Thu Feb 4 11:09:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067043 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3707C433DB for ; Thu, 4 Feb 2021 11:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8222264F60 for ; Thu, 4 Feb 2021 11:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235583AbhBDLOs (ORCPT ); Thu, 4 Feb 2021 06:14:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235723AbhBDLM0 (ORCPT ); Thu, 4 Feb 2021 06:12:26 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10294C0611C3 for ; Thu, 4 Feb 2021 03:10:26 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 190so2770829wmz.0 for ; Thu, 04 Feb 2021 03:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3IEsVjEj58gpnbEtzruF6QIgBE7zuGLR+EproOK/53M=; b=pwnuFV934+1NBMnFc5tehmnUsznGHtEqWZhqeblMxHAXEAiQO6GdBjD9HxbnteJQcr 685CCA/s/RxaZFiIYu0DrIFt0EcTLzuxK77dJBvb+mRTMK3sUOvkv9but9M6CN43Z2J1 I7oJqVe5vMwwwgDcI5hJhNzeX6RutJNg35WaQCJ9FcrtDIAUFz3JXOjcPProru5uu5UK 0zOkNV8vIv+vwRwAD//KlfbPZStVsvZTPQNg5fIw5RhfnWevY5A4EH/gLo7FTAROjK+4 9ff74FS33cbCNPcvFgudhYPqg/Pq5qkF0Xg1xI2vN8P+tsvv96rzaDvzdNQsrA/CTTqj CwSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3IEsVjEj58gpnbEtzruF6QIgBE7zuGLR+EproOK/53M=; b=L1SQprjlv63vrapsev8xtZl7fZdpJvOdGkyhlI3wfAmgNw/rBZ9t7XgfJ+6b7SQyUn 3SNGiwcE0jaLEAmXFXUd158GUUpBqv13+r8BoOr5Emm4hcCQBzpOhz50zc5QkQ82xCrk /ZEygqbIGhW10KIH8SUrXCImTcHoJohPt4Rm5JRC1UKEA973tdzZ590PBw4xuN27CF5M majFMSc/8tElvrRVJAvgaxkBs6mxd9nH4oav0qtdcKE8VbO+9ZZnXUsVJoC8M0MDm4YT rCrFrd2IUbjjq7gB5TuyMEa2HOAQQ60tFtGmQZQXkDAbWlZ8dZh0+khl643V6jO/7xeN HFZA== X-Gm-Message-State: AOAM5313+213s743BH4xHU1fxb2O4mk+XU5lptM0eClw4TRzstjkrmAi /Jnl7alA6S0njPUjxaMyGxUV/A== X-Google-Smtp-Source: ABdhPJwzTr8uy4M0IvB8VO2hwiH8qyYaC4erJaP/nR/itMDq7tvkpIn8Do6atM7jT0LKBKilP1cAUQ== X-Received: by 2002:a1c:f70f:: with SMTP id v15mr6821758wmh.38.1612437024780; Thu, 04 Feb 2021 03:10:24 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Kent Yoder , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 18/20] crypto: nx: nx_debugfs: Header comments should not be kernel-doc Date: Thu, 4 Feb 2021 11:09:58 +0000 Message-Id: <20210204111000.2800436-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init' drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c index 1975bcbee9974..ee7cd88bb10a7 100644 --- a/drivers/crypto/nx/nx_debugfs.c +++ b/drivers/crypto/nx/nx_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * debugfs routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. From patchwork Thu Feb 4 11:09:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067045 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E9FC433E6 for ; Thu, 4 Feb 2021 11:15:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAA0D64F58 for ; Thu, 4 Feb 2021 11:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235723AbhBDLPA (ORCPT ); Thu, 4 Feb 2021 06:15:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235560AbhBDLMx (ORCPT ); Thu, 4 Feb 2021 06:12:53 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE6CBC0611BD for ; Thu, 4 Feb 2021 03:10:28 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id m1so2641032wml.2 for ; Thu, 04 Feb 2021 03:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qhRaK7PEb1+VQbMXp2izacC8TWHkvWpyOp/JFxz8PSk=; b=t5B27kseFaSQ07V34VI0+HtMHwzq/iu5wofl4aAA12lmp4bvmT9K7iM/vMiDXIvfmp 5gVTdvI880u0uezN8PA5uIEwySqb7up76wrmGmKbG1myjs2VLsWE41EmwhWLr4HqTC1N dSWu8oC3jxsrIUtMphZ3UnYweS/gT1cGYPQro/LAqTh8PfiMVie9VOuiCMMw/FCWcRVp KYrsbsjbMBWMfB4KzcX4FNY+xNmfKOi2vhUA9bUpdllUDvj/CfDlineW9XKQ3Y3VG35l XWS4BgTzWKinSO0ZTFANwZbF6Ha33pKPf9YaE8v6ow6eiLsU6AlkdjcQfU9JeHTSEMv0 eGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qhRaK7PEb1+VQbMXp2izacC8TWHkvWpyOp/JFxz8PSk=; b=k4b8PKgRhgcncvUprI8L8744DdIcFq7fssBZARV4a2ddTQpGwxs1/qDnhrLSAnI9QG oV42uXVAbgwBpZuI2ii8ilzuUrCmqmkCzwbm2vTz4YknR8Cy/akh6/puUL+TMfuuCGVc wmApRbhSug/48mTD4XFWRx1ZeFqJ1xinjraNCmtcUFZChfNt0TkcpeyNWox8qG/1kBIe pwt2WBAbzhcZTYsvJuNfY6Ib84agmoKpnVVEeW87WwQD53ZKNeuMvYckjYpRfW94jb8e HRyGlXfVKyb/tOSNekbJMKGUUdc/rRhKcQ/JYGEcZYBhWh/nqIMmpBYuZyeNzguKyH0i HLiQ== X-Gm-Message-State: AOAM5315znERCDv58fsbFVNlFU83kSg2u2JwjiAIc+Tjz8BBXlLwOyRE DyxBem5JvhGjRn/WP5WWr+lx9hA9IOrveg== X-Google-Smtp-Source: ABdhPJy3ovJmVWJwfdQ/ifr6A3rN/+QEp57dStSFcBGixXRzwdnUgrj5/e3P+zqOCrmcKmI+TdyFRA== X-Received: by 2002:a1c:6688:: with SMTP id a130mr6944242wmc.1.1612437025976; Thu, 04 Feb 2021 03:10:25 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Kent Yoder , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 19/20] crypto: nx: Demote header comment and add description for 'nbytes' Date: Thu, 4 Feb 2021 11:09:59 +0000 Message-Id: <20210204111000.2800436-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format: * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list' Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 0d2dc5be7f192..010be6793c9fc 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. @@ -200,7 +200,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *nx_dst, * @sg: sg list head * @end: sg lisg end * @delta: is the amount we need to crop in order to bound the list. - * + * @nbytes: length of data in the scatterlists or data length - whichever + * is greater. */ static long int trim_sg_list(struct nx_sg *sg, struct nx_sg *end, From patchwork Thu Feb 4 11:10:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12067049 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C45C433DB for ; Thu, 4 Feb 2021 11:16:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E786E64F60 for ; Thu, 4 Feb 2021 11:16:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235788AbhBDLPx (ORCPT ); Thu, 4 Feb 2021 06:15:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235749AbhBDLNX (ORCPT ); Thu, 4 Feb 2021 06:13:23 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD59EC061A10 for ; Thu, 4 Feb 2021 03:10:29 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id w4so2744954wmi.4 for ; Thu, 04 Feb 2021 03:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hrNr+lBWtFId4EzjUkysKAYnQC+wg9XBY1JaRyhRGmU=; b=wCl0IaHIQhVpYAG4G1XGZ11OJZCpT+nf40JxNtK/yc+i2oMo9dm0aJhJzAqrUs5tZq FvFd5kcpNZcSkMIkXUKXojCIAXax2YYl6f3UUb7+IcUKpRf4nxy2ZTwBCW79IwyBXPxe nopVLMan39vBhud+20LlTluJ6uScxi/yGDBBp/YSapWUhKBRLo35hbP6iqXDZBnKJcbC CFwip/DRDdTdyItXEtbWAmYNzhJE8Vvg7y6c3IcP5y2n5d0INnR0TZodPX/41Y5ytAoQ RaM+Ba3HalHyJBPImyICoe+EABpG6OYlwTQ/m0DC5KZBtguzx6yVEoQh2iE7p8a7P0UZ abBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hrNr+lBWtFId4EzjUkysKAYnQC+wg9XBY1JaRyhRGmU=; b=UypXwHa7zEC4vRfs1hOd8Etp0T+MxhHH5VSUqFKyzbNfZbtzMxyMEBhETZydy9izEi 7dh9An/n5n+nie0YIxjcQkZiKkyQHELL113bOXbpuvsMQQGW0xSBfYd4YJo9/N0LqNx8 etFhZU6VFjR4v7PzeSnPkttKlGsZeyLL0Yd4hNI2SNNsNauu96CQn1EunTzPq3e/fZYr 0YHoJTFUV499UYTsH3D1BUS/3oeMMFpMXBnHSWexpmUXNqTwCf6MwRmi216JXSuu1DLE yZA+MPv367xJsnGim0BmIwh2kMrc1UcZQr1159TL4+yS+siA3g2Wek0XvMfPz2YJCwZn Uweg== X-Gm-Message-State: AOAM5337TqzxsRgeK6B3i1bihCaLOuOPMjnTJNhPZINaXV0Ldp2OmnUa DZnvwNuOzQVDkmGj2vqqWuIf2A== X-Google-Smtp-Source: ABdhPJyQt1sKw0ek1Sz27bkoNIJ4Dc3TqSZmz3zCEA0n7R042NG3hUP1E6LQ8QMiCibzFOUbIpWBnA== X-Received: by 2002:a1c:9ec9:: with SMTP id h192mr7238710wme.28.1612437028668; Thu, 04 Feb 2021 03:10:28 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 20/20] crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers Date: Thu, 4 Feb 2021 11:10:00 +0000 Message-Id: <20210204111000.2800436-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/cavium/nitrox/nitrox_isr.c:17: warning: expecting prototype for One vector for each type of ring(). Prototype was for NR_RING_VECTORS() instead drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'irq' not described in 'nps_core_int_isr' drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'data' not described in 'nps_core_int_isr' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cavium/nitrox/nitrox_isr.c b/drivers/crypto/cavium/nitrox/nitrox_isr.c index 99b053094f5af..c288c4b51783d 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_isr.c +++ b/drivers/crypto/cavium/nitrox/nitrox_isr.c @@ -10,7 +10,7 @@ #include "nitrox_isr.h" #include "nitrox_mbx.h" -/** +/* * One vector for each type of ring * - NPS packet ring, AQMQ ring and ZQMQ ring */ @@ -216,7 +216,7 @@ static void nps_core_int_tasklet(unsigned long data) } } -/** +/* * nps_core_int_isr - interrupt handler for NITROX errors and * mailbox communication */