From patchwork Mon Feb 22 02:47:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiyuan Dai X-Patchwork-Id: 12097865 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C2E4C433DB for ; Mon, 22 Feb 2021 02:48:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43B26614A5 for ; Mon, 22 Feb 2021 02:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43B26614A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phytium.com.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B77976B006C; Sun, 21 Feb 2021 21:48:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B00146B0070; Sun, 21 Feb 2021 21:48:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C8336B0071; Sun, 21 Feb 2021 21:48:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 83B4B6B006C for ; Sun, 21 Feb 2021 21:48:44 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 32E02878D for ; Mon, 22 Feb 2021 02:48:44 +0000 (UTC) X-FDA: 77844370968.09.D0A7B50 Received: from zg8tmtu5ljy1ljeznc42.icoremail.net (zg8tmtu5ljy1ljeznc42.icoremail.net [159.65.134.6]) by imf08.hostedemail.com (Postfix) with SMTP id 70C5880192D4 for ; Mon, 22 Feb 2021 02:48:27 +0000 (UTC) Received: from centos7u5.localdomain (unknown [202.43.158.76]) by c1app2 (Coremail) with SMTP id AgINCgBnvSk9GzNg+MkTAw--.26618S3; Mon, 22 Feb 2021 10:47:26 +0800 (CST) From: Zhiyuan Dai To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhiyuan Dai Subject: [PATCH] mm/dmapool: switch from strlcpy to strscpy Date: Mon, 22 Feb 2021 10:47:30 +0800 Message-Id: <1613962050-14188-1-git-send-email-daizhiyuan@phytium.com.cn> X-Mailer: git-send-email 1.8.3.1 X-CM-TRANSID: AgINCgBnvSk9GzNg+MkTAw--.26618S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr4rAFyDtw4UArW7Ww4Durg_yoW3Zrc_u3 WUtFW8XF45JF9Fv3Z0krWqya47Aw1kuFyDAFs7Xr9rKayfJayDKFykXrya9ryUuw12qrZx Cw1DArW3C34fGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJV W0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_Gr1l 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUDWrAUUUUU= X-Originating-IP: [202.43.158.76] X-CM-SenderInfo: hgdl6xpl1xt0o6sk53xlxphulrpou0/ X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 70C5880192D4 X-Stat-Signature: 8rnf1q6qyterjpca8ro5kbrzgzhbb7ko Received-SPF: none (phytium.com.cn>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=zg8tmtu5ljy1ljeznc42.icoremail.net; client-ip=159.65.134.6 X-HE-DKIM-Result: none/none X-HE-Tag: 1613962107-211515 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: strlcpy is marked as deprecated in Documentation/process/deprecated.rst, and there is no functional difference when the caller expects truncation (when not checking the return value). strscpy is relatively better as it also avoids scanning the whole source string. Signed-off-by: Zhiyuan Dai --- mm/dmapool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index a97c972..38cf2a7 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -156,7 +156,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, if (!retval) return retval; - strlcpy(retval->name, name, sizeof(retval->name)); + strscpy(retval->name, name, sizeof(retval->name)); retval->dev = dev;