From patchwork Mon Feb 22 19:50:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= X-Patchwork-Id: 12099465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1796C433E0 for ; Mon, 22 Feb 2021 19:52:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CB0C64E02 for ; Mon, 22 Feb 2021 19:52:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CB0C64E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0phygbKJck1Y00fGaq0BVULmOlTnJLOR3a2gwzSrisY=; b=by4bxJ/3kZ33uTplI6ocBONJDO hBLkj6DCRMpd/v8mHPeR67ecqnTOgpNiMQ/iQXs8Zc55E/w63BH/K+ikaIxgeZxyvQeeBWVEtjNdL VJm+agaCyNEkz03mnYQv+4vnCdCKqVwjVV4UueE/7hNviOQNTnq8ZBwzpIarlt6MR5x+4BhlAN6bn vL/sEve0mKkCdoue0gWPmXu1mOf8WHwzsOjIk5N1vTwZtmnBGKrnmWDgXHqV0HHHySY+jplA1fCU7 ga+1aYmbSn5e0M1kUGFnES3zeMPhdY94O30qnesiQ5s1oc2FurfNu20YcL2xBpF2r16k0M7lzWRvl M3j+g0OQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEHEF-0004y7-24; Mon, 22 Feb 2021 19:50:47 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEHEC-0004xg-6a; Mon, 22 Feb 2021 19:50:45 +0000 Received: by mail-wm1-x32a.google.com with SMTP id n10so377866wmq.0; Mon, 22 Feb 2021 11:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=MfN9Cgym1FbsMVOmP8YcLwSJUz55n9T6vsrfPvdXcUk=; b=EZcjwsDZ8hKOkl4+hJ1+TzRFkoBNFQeFzt/9YNFA72zbPtAUu5F42HJelDudXgXz2E oU6hqvYlAFTy0NuoNedM6NlEuHOGvVXFFp2aoyUjPXPrTU50xe5nO8UsniTpKf2yX5ld A9faKDe8lW6S4089xdILMSCao51emUGKi9EC7sO7CZl87k88bX00rzgXxuNJDZ9PapTM 5DTPG/+ugwj0OafqSyQ1LlQTLxdIlh+SGiA+fQwHxEOjyTbeA5RYfy2DH7xu0ddGorIE fNMtwQZk9Shj2clEqEwCY11BaaiDF+bo9/6G0XqFplGp6yYhXV03kz5dFyCo5RTktzT0 AQ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MfN9Cgym1FbsMVOmP8YcLwSJUz55n9T6vsrfPvdXcUk=; b=fmNsL2QuktIc6SAqDq5dTpmC39doEPC6GEaw+VMtJk2Hl9FePGul/M/gg/scyR9PIS oiLi+uZ+xdqGafrELk7ZOgkeiVubIe71r74CyY+1kL3VufCnRUCIlBaAgF1etwUMUsKT OaxHfceumPXsWisAxwtINcn+DJzsAn53oj7+wbItehQMiofe2cuYOhsdoBmVnABZ8dFG 1zDCD3XqYwskhXrdXQyXjs+49VMbYltEery4WuzwZq1zTK7uhWdEqQwt7SEV27tmb1RC hiSBTaOcr/lXfU5KERt0AT7aeWJV8Y+5Lr17TlCOvuWJ28X634kOviD6CBkIsot3tmit dsvg== X-Gm-Message-State: AOAM530Xb8QSVyBWqP3U6Hmxdd7fEgTT70BOJ7D9PAjb5RUfqRwECHaA caMVWsiq9lGHhMl7UPlIOHA= X-Google-Smtp-Source: ABdhPJy2ifgy8J+cwpkeeQYb40XpclKC9lDt6RF4Y3BvYOmHi6zm4x3CP/D/ulT0lNWGPVs5nMeGgQ== X-Received: by 2002:a05:600c:350c:: with SMTP id h12mr21264827wmq.39.1614023442747; Mon, 22 Feb 2021 11:50:42 -0800 (PST) Received: from skynet.lan (170.red-88-1-105.dynamicip.rima-tde.net. [88.1.105.170]) by smtp.gmail.com with ESMTPSA id o15sm302426wmh.39.2021.02.22.11.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 11:50:42 -0800 (PST) From: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= To: mpm@selenic.com, herbert@gondor.apana.org.au, nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rikard.falkeborn@gmail.com, noltari@gmail.com, linux-crypto@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stijn@linux-ipv6.be, ynezz@true.cz Subject: [PATCH v3] hwrng: bcm2835: set quality Date: Mon, 22 Feb 2021 20:50:40 +0100 Message-Id: <20210222195040.16900-1-noltari@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210220195748.3153-1-noltari@gmail.com> References: <20210220195748.3153-1-noltari@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210222_145044_313758_72CBEC00 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This allows devices without a high precission timer to speed up boot from more than 100s to lest than 30s. BCM2835 rngtest: root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000 rngtest 6.10 Copyright (c) 2004 by Henrique de Moraes Holschuh This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. rngtest: starting FIPS tests... rngtest: bits received from input: 20000032 rngtest: FIPS 140-2 successes: 996 rngtest: FIPS 140-2 failures: 4 rngtest: FIPS 140-2(2001-10-10) Monobit: 0 rngtest: FIPS 140-2(2001-10-10) Poker: 0 rngtest: FIPS 140-2(2001-10-10) Runs: 1 rngtest: FIPS 140-2(2001-10-10) Long run: 3 rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 rngtest: input channel speed: (min=146.002; avg=349.394; max=1302083.333)Kibits/s rngtest: FIPS tests speed: (min=12.126; avg=22.750; max=23.432)Mibits/s rngtest: Program run time: 56826982 microseconds 996 successes and 4 failures -> 99.6% success rate 1024 * 99.6% = 1019 (rounded down to 1000) BCM6368 rngtest: root@OpenWrt:/# root@OpenWrt:/# cat /dev/hwrng | rngtest -c 1000 rngtest 6.10 Copyright (c) 2004 by Henrique de Moraes Holschuh This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. rngtest: starting FIPS tests... rngtest: bits received from input: 20000032 rngtest: FIPS 140-2 successes: 751 rngtest: FIPS 140-2 failures: 249 rngtest: FIPS 140-2(2001-10-10) Monobit: 0 rngtest: FIPS 140-2(2001-10-10) Poker: 34 rngtest: FIPS 140-2(2001-10-10) Runs: 245 rngtest: FIPS 140-2(2001-10-10) Long run: 0 rngtest: FIPS 140-2(2001-10-10) Continuous run: 0 rngtest: input channel speed: (min=1.202; avg=16.434; max=1003.868)Mibits/s rngtest: FIPS tests speed: (min=761.155; avg=8343.383; max=15662.590)Kibits/s rngtest: Program run time: 3539183 microseconds cat: write error: Broken pipe Signed-off-by: Álvaro Fernández Rojas --- v3: set different qualities for each SoC v2: add jusftification drivers/char/hw_random/bcm2835-rng.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c index 1a7c43b43c6b..a6121a04f624 100644 --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -121,6 +121,15 @@ static void bcm2835_rng_cleanup(struct hwrng *rng) struct bcm2835_rng_of_data { bool mask_interrupts; + unsigned short quality; +}; + +static const struct bcm2835_rng_of_data bcm283x_rng_of_data = { + .quality = 1000, +}; + +static const struct bcm2835_rng_of_data bcm6368_rng_of_data = { + .quality = 700, }; static const struct bcm2835_rng_of_data nsp_rng_of_data = { @@ -128,10 +137,10 @@ static const struct bcm2835_rng_of_data nsp_rng_of_data = { }; static const struct of_device_id bcm2835_rng_of_match[] = { - { .compatible = "brcm,bcm2835-rng"}, + { .compatible = "brcm,bcm2835-rng", .data = &bcm283x_rng_of_data }, { .compatible = "brcm,bcm-nsp-rng", .data = &nsp_rng_of_data }, { .compatible = "brcm,bcm5301x-rng", .data = &nsp_rng_of_data }, - { .compatible = "brcm,bcm6368-rng"}, + { .compatible = "brcm,bcm6368-rng", .data = &bcm6368_rng_of_data }, {}, }; @@ -171,8 +180,10 @@ static int bcm2835_rng_probe(struct platform_device *pdev) /* Check for rng init function, execute it */ of_data = rng_id->data; - if (of_data) + if (of_data) { priv->mask_interrupts = of_data->mask_interrupts; + priv->rng.quality = of_data->quality; + } } /* register driver */