From patchwork Wed Feb 24 10:15:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin, Wayne" X-Patchwork-Id: 12101631 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 671AFC433E0 for ; Wed, 24 Feb 2021 10:17:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0519A64EC9 for ; Wed, 24 Feb 2021 10:17:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0519A64EC9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41AA789C9C; Wed, 24 Feb 2021 10:17:10 +0000 (UTC) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-eopbgr760057.outbound.protection.outlook.com [40.107.76.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE32289C9C for ; Wed, 24 Feb 2021 10:17:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXQ9BOGpRLl+N0WmVNabjs8Lx6wyxMPl0GcH6X/jiEqMaol2926hxXch12zgLrSZPHY6GUo1l9Yn4qlQF5Eatb6UpYONuARpGueiYfzxMpVd7tn28jro2ebfK/m88rToYV9f5sAgocgJxJQL/BeO3Ne2payiuSr41SwQhKjmteFpG+5NSHBkel542KVQWfcGMG+oZh/gnGUVRD2/p40S9Pjmw6b56kh1v105ygnFtGfHFLLSCt58F74x/RMtufkCdM2eDSzGR+OJMBxWAIcnKHI9HxCQSmVqrfIn7mScLSouoV2VC92W5aRDMvcgmFEwEraAhmVu+hhdmZN3PPvBhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfAGH/InJNV4Axu7T4UHZ97O/YdkgGJ0McbrJgl2qxk=; b=f/do/eXMHb1vVhyCwNRJxJz3jpOV1jv5tIbqvNHnMuHzrd7JAW0CjjsxqZNHkTLhrUrjDivkPRmjMMsjA3C0Rajg07stX9XTRJXXR8CkfDhrCU6tT9kgqC7Eu8hxXCszGYaU3/bqVLXtpt/GjcU85TGDJzz/M21m1vf3Kjc9628xA5zdi7+33Vn2awmkrzTplTT4IbsI9ObwySiqNhmiLRLb3lIgkQnpZip4OZ5xLXV36+O9Brnbk5XwIKEYcKerzgjhxYw4rTi9YVT1T9jyUMRFXKcBp1NkyyM2KzhJUnjlQbJVQ3HGqRGht7wN93Ee1zAhzKuopYAYLt3sgdJCVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IfAGH/InJNV4Axu7T4UHZ97O/YdkgGJ0McbrJgl2qxk=; b=c2fyfXFHmq/Zo+aS0wNNLGpq7ZxOZSkqJq5CT7ZehdtHFxhYr7T8xmYdGE0czE3jwKgeJqo+3nl3mztM4bVKwV0aok90b5pu/LuR9U/2AhSDjgTT+4hr/v+qIPoDnMnTbc7LQrUwSv4oeuQFAti8dRuQz0Ft14TniqAhzMYM9t8= Received: from BN6PR2001CA0022.namprd20.prod.outlook.com (2603:10b6:404:b4::32) by DM5PR12MB1610.namprd12.prod.outlook.com (2603:10b6:4:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.29; Wed, 24 Feb 2021 10:17:07 +0000 Received: from BN8NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:404:b4:cafe::85) by BN6PR2001CA0022.outlook.office365.com (2603:10b6:404:b4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Wed, 24 Feb 2021 10:17:07 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=fail action=none header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 165.204.84.17 as permitted sender) Received: from SATLEXMB02.amd.com (165.204.84.17) by BN8NAM11FT043.mail.protection.outlook.com (10.13.177.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3868.27 via Frontend Transport; Wed, 24 Feb 2021 10:17:05 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 24 Feb 2021 04:17:05 -0600 Received: from SATLEXMB02.amd.com (10.181.40.143) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 24 Feb 2021 04:17:04 -0600 Received: from wayne-System-Product-Name.amd.com (10.180.168.240) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 24 Feb 2021 04:17:02 -0600 From: Wayne Lin To: Subject: [PATCH v2 1/2] drm/dp_mst: Revise broadcast msg lct & lcr Date: Wed, 24 Feb 2021 18:15:20 +0800 Message-ID: <20210224101521.6713-2-Wayne.Lin@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210224101521.6713-1-Wayne.Lin@amd.com> References: <20210224101521.6713-1-Wayne.Lin@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b31f797-6079-4d02-33f4-08d8d8ad55ec X-MS-TrafficTypeDiagnostic: DM5PR12MB1610: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: blsKVezJLOyhvXtRwsGFaLIoZgwcfIGFwPppk1Cs0P3SSwbsOXwyzUbn1rfqqaPOQazw8bls+722lEb5OTNAUcOAYiIIESao36Dm9QluzcWGXLsS8Bu2LBwMJqAe0ziLmmRc7IrcUfdfw+gGXMojcd+SN7ekUh4yy1gqu8XHzA2r6zpCsrs02iqT5cf8dg8lm0Sf6LkR0CjLQqz8xFvYxbQX1NWyHz8+hvyvpSojoURVl/8UoLkxX1o8ryiZOM1VvcGOAyXdxoeHMDKW6L4zdkPYA3QSCbieHvewlVH2XJhCfkrjz+KGtQ4jk7QjLrM+rruYmEswGe9E4zQSZWp5iBlarj0zwNpgb3r6Dlmi86OquWRz9UxtstSh1e26Xq93QLAXxMCBgf0aYoWpt5Dugjy99tNwOMhPJ8kZGrB5tf++IAplnzaZYxt+5GbWY0iYhs7uaxmGUKb+AVPQyDCELulH9fTJM89pX5KKSIxEcGBAFFAPtWHb9uHZRB7ceNbX7ax16AjJefJzeosfZ6hzpi49aHgRt4to1gI/oFCvL7qlvTSOaWn7j8S8goWuPCZjB5cR55nm6HGGfVq5B8Do0T9DIevRcts3y9vxTXDJtkf7rJPaOdoIAY3U9ijmuyVqc6eWf62kuoOsu3zGleHOlM9NQCRCE4+yli0kULlPjyxmn/DUMjIBSbgn3Z2aCku0 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SATLEXMB02.amd.com; PTR:ErrorRetry; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(376002)(39860400002)(36840700001)(46966006)(26005)(36756003)(70586007)(478600001)(5660300002)(186003)(8676002)(7696005)(1076003)(36860700001)(6666004)(86362001)(4326008)(426003)(336012)(82740400003)(70206006)(54906003)(316002)(2616005)(81166007)(2906002)(356005)(6916009)(83380400001)(47076005)(82310400003)(8936002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2021 10:17:05.4860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b31f797-6079-4d02-33f4-08d8d8ad55ec X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB02.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1610 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eryk.brol@amd.com, qingqing.zhuo@amd.com, stable@vger.kernel.org, jerry.zuo@amd.com, Wayne Lin , Nicholas.Kazlauskas@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [Why & How] According to DP spec, broadcast message LCT equals to 1 and LCR equals to 6. Current implementation is incorrect. Fix it. In addition, revise a bit the hdr->rad handling to include broadcast case. Signed-off-by: Wayne Lin Cc: stable@vger.kernel.org --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 17dbed0a9800..f11b3f718031 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2727,10 +2727,15 @@ static int set_hdr_from_dst_qlock(struct drm_dp_sideband_msg_hdr *hdr, else hdr->broadcast = 0; hdr->path_msg = txmsg->path_msg; - hdr->lct = mstb->lct; - hdr->lcr = mstb->lct - 1; - if (mstb->lct > 1) - memcpy(hdr->rad, mstb->rad, mstb->lct / 2); + if (hdr->broadcast) { + hdr->lct = 1; + hdr->lcr = 6; + } else { + hdr->lct = mstb->lct; + hdr->lcr = mstb->lct - 1; + } + + memcpy(hdr->rad, mstb->rad, hdr->lct / 2); return 0; } From patchwork Wed Feb 24 10:15:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin, Wayne" X-Patchwork-Id: 12101633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D06C433E0 for ; Wed, 24 Feb 2021 10:17:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C7956023C for ; Wed, 24 Feb 2021 10:17:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C7956023C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 86C0289F8E; Wed, 24 Feb 2021 10:17:19 +0000 (UTC) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2087.outbound.protection.outlook.com [40.107.243.87]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32FFD89F8E for ; Wed, 24 Feb 2021 10:17:19 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1f2P3yhLHYHU9NZ+aquLjHSHGR+slZ3pNns1o+enRQMpD5YR6DvBKyia3ePOmf8+evoYs037t8m7KAjWnpmPMRFSOCc4qb74NehIlCcorP3kwmt3xnbqJ81eOhY5oCwdVBHaEkjXIHjyvKV4Al/iX9lKDEM6CNOWGgXSG1UqTfyVsom3wVaUyoNHnhwc6RzlE932QF9B0j7cRGbAyUIqwV4y987o0LCDQTcrMlSLma0DVa1RUScUmmAWM+UDlbxaTgwSI4GQw4aOctL61rwSUnB1N/MuHkWu3wPxRzUznyFVACpyKI6XeN+FB3zKsGnd3RvXrvM3lln7BD20sJOFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WEP1rtU3coCRUi9rCYPz3zRmSIrPhmefGygOyX1n/g=; b=gKqxKrDK/JokwO/OChDRgElovVn1iHrN850BgrMEG7giBVPmUum/xOQQEGfnfLgj0zebMd8yGF4GAlAsbFCeirpfsT5bvUWGykCf3FzBQaPl4Xfx5qnm/ODhhN9FgsJa/H1cnXqYJCtdqlwqGR5nqbwXhrCopb2ikpWizVYgIzCYdNiYh7WowQ6dK17DgQxhGvQd8EWZJzSjYU/9Sr6qSXWK5CnOjBDE8hjos+2uXMqCFUqlqMXZp2zGR3/yVOyxoRIqiuKMcvy+sF3bo/0JqRYb6KVHSRhM5BvHQKI6BmZ+cIDX06Y9vyTIUogxGjJJTQeo1+0WyujUJ+EkR+sJ1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2WEP1rtU3coCRUi9rCYPz3zRmSIrPhmefGygOyX1n/g=; b=UyTamRBrLASjLXt4Mv1XoXWjaCNO4wldHjqeB4sIRR3OweIBizllC9SUNNWN9fTAxYqJg0uqGZWXQ1w6QcBLNbBck1jm5oPOJssnkyEA7Wj5UhLxMo0LwfJ9GUgyPiIn/fdNaVbjOGsfuLbQJkxHBEoEIIw+14+M1BMmac4jhGM= Received: from DM5PR1101CA0022.namprd11.prod.outlook.com (2603:10b6:4:4c::32) by DM6PR12MB4498.namprd12.prod.outlook.com (2603:10b6:5:2a2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Wed, 24 Feb 2021 10:17:11 +0000 Received: from DM6NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:4:4c:cafe::b2) by DM5PR1101CA0022.outlook.office365.com (2603:10b6:4:4c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Wed, 24 Feb 2021 10:17:11 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.freedesktop.org; dkim=none (message not signed) header.d=none;lists.freedesktop.org; dmarc=fail action=none header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 165.204.84.17 as permitted sender) Received: from SATLEXMB01.amd.com (165.204.84.17) by DM6NAM11FT062.mail.protection.outlook.com (10.13.173.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3868.27 via Frontend Transport; Wed, 24 Feb 2021 10:17:09 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB01.amd.com (10.181.40.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 24 Feb 2021 04:17:09 -0600 Received: from SATLEXMB02.amd.com (10.181.40.143) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 24 Feb 2021 04:17:08 -0600 Received: from wayne-System-Product-Name.amd.com (10.180.168.240) by SATLEXMB02.amd.com (10.181.40.143) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 24 Feb 2021 04:17:06 -0600 From: Wayne Lin To: Subject: [PATCH v2 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast Date: Wed, 24 Feb 2021 18:15:21 +0800 Message-ID: <20210224101521.6713-3-Wayne.Lin@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210224101521.6713-1-Wayne.Lin@amd.com> References: <20210224101521.6713-1-Wayne.Lin@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a0bd8fa-1046-4106-6a21-08d8d8ad5877 X-MS-TrafficTypeDiagnostic: DM6PR12MB4498: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:843; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JktcPcyKsZpMS1IRmt98c3/TDYUMDsKr6nhyVTu46DfzaLACiOMduf5+/8BbeNLNsRXfFpXKXk/YjR+05yq4O+2WIMPIgB5/DUyQ7fAXSEeoGAiNdp7Cj7yDcTJEEKcL5F/FqtOcsJpz6Dm9SxShHqNHXepIsQ/fUlQDSu1NrYkfR/nsSc/l3Eq9tJaimELy05dP9dPmqQG6QqoN4Nwm3dF97pBMgqiCBQF+nSjZp6sPM0QL+7DSnMclylA3gOMl8LPcS7aNgX86Q7bnSvmWL5FrS5PhR8wp9AKGc4dRC1QVK+YLTzw8j8TLq2DWR4OnOOKQT3rVCvSsD3JJNxXpkkwaXc+aJCwsBMSWgXZ9R/7IJbiGhsDsHXmPZ70aCN2NhimyDlOA0fVnsAcOh7ZYptoyOCqydIjiFScjTCEw2YLSB9M/bDbCxUrrTjHJkcTIvF4NyNuQ76D0EgJeXRALDktp+TY8cTsSm+hk14hv4FN10xZyZHuR9lYWdBZp6Wlu7k7v7T7DwK3HFGVKGLFuO4CcfhFTczYEKJGMs2mkzRau1BjoUvHykhldqO1BrdRmTRZrOOXijs+Rws7QBmxNF5/XYvG1ZyUKJlYuQemb3b+Vnj0HWUkv4rckXuKGu/omZIFQAf4GApHWE/SOZstoF4FiSt7tlV5x2jgiOtIGCT9gYogAXKweAtKLIHYYV20h X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SATLEXMB01.amd.com; PTR:ErrorRetry; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966006)(36840700001)(83380400001)(82740400003)(36860700001)(426003)(478600001)(54906003)(5660300002)(6916009)(6666004)(81166007)(2616005)(36756003)(2906002)(356005)(336012)(316002)(1076003)(26005)(8676002)(186003)(70586007)(70206006)(86362001)(4326008)(47076005)(8936002)(82310400003)(7696005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2021 10:17:09.7098 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0bd8fa-1046-4106-6a21-08d8d8ad5877 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB01.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4498 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eryk.brol@amd.com, qingqing.zhuo@amd.com, stable@vger.kernel.org, jerry.zuo@amd.com, Wayne Lin , Nicholas.Kazlauskas@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [Why & How] According to DP spec, CLEAR_PAYLOAD_ID_TABLE is a path broadcast request message and current implementation is incorrect. Fix it. Signed-off-by: Wayne Lin Cc: stable@vger.kernel.org --- drivers/gpu/drm/drm_dp_mst_topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index f11b3f718031..c32b98389349 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -1072,6 +1072,7 @@ static void build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg) req.req_type = DP_CLEAR_PAYLOAD_ID_TABLE; drm_dp_encode_sideband_req(&req, msg); + msg->path_msg = true; } static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg, @@ -2722,7 +2723,8 @@ static int set_hdr_from_dst_qlock(struct drm_dp_sideband_msg_hdr *hdr, req_type = txmsg->msg[0] & 0x7f; if (req_type == DP_CONNECTION_STATUS_NOTIFY || - req_type == DP_RESOURCE_STATUS_NOTIFY) + req_type == DP_RESOURCE_STATUS_NOTIFY || + req_type == DP_CLEAR_PAYLOAD_ID_TABLE) hdr->broadcast = 1; else hdr->broadcast = 0;