From patchwork Mon Mar 8 11:37:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 12122037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0D4C433DB for ; Mon, 8 Mar 2021 11:39:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB7A8651A7 for ; Mon, 8 Mar 2021 11:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB7A8651A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DA48D174A; Mon, 8 Mar 2021 12:38:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DA48D174A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615203536; bh=92frqUm/t/g603rYhm/sF+1S0xjbjNSinXZQ2Y9isS0=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=A4vRP215PP40Yggx2UOgX+FLoal84Z+a+5RPMYwCjXfLSqiTEB0RXY3lK2nRHENrJ upna0+281z4ZSkxv/jen2HAzvKw/2uWAFs4oDe+q5hA+o4c7GOg+i8guTqo8khQrVL Ab9blEqni23wZHH3OGMSDZN5sMvSQ9sFefoaAdCM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24CEEF8016C; Mon, 8 Mar 2021 12:38:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1CA54F801D8; Mon, 8 Mar 2021 12:38:04 +0100 (CET) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1E436F800D0 for ; Mon, 8 Mar 2021 12:37:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1E436F800D0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qTGAAgs1" Received: by mail-wm1-x32d.google.com with SMTP id d139-20020a1c1d910000b029010b895cb6f2so3593425wmd.5 for ; Mon, 08 Mar 2021 03:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o8ABSumopRxhX3bOOU+CF2r1YImKGUPBBN79DPzPoQc=; b=qTGAAgs1+zy1cao2XlPMOo2/qIYHp62VyXADDPlERMV4r9K9nlfQ9GH0iuIgOJza6k QgqkH/b8u6xt7ca1LyFoSFBtdxoxS4Cia6VH2aJr5NhtkemK1kx1hUDP7QTJl0SB6xWE kCrWKnYBEC29/yt9r0AEvlHoZ+2NU/GuAQoGf6htGAunvnCf9IjsyoPzNZO+f+0zpJq8 iq2rlAO5xqBLR+gZEe3G6ACQ/Hd1H9/nUdMAobkRovNdogUwJUrPRLIy9OZ1bRZ3Z/rE cNWxztnJghjHHpyehxQpgXjDCcrn3TqqNLVDerc0uYM/N3vRhF1aKwX5SfaxVYVL1u7Q HNeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o8ABSumopRxhX3bOOU+CF2r1YImKGUPBBN79DPzPoQc=; b=NBUQvkZciVahfcAZQL6GfeHxn2zoBw2kVNJf5BXfntJez85Yngx7ZeqPixl8D1V7Md gVoNF+k/siGirqQeVkSVqpjrq/MVcJgl6d5KvHwDSW5/DFyiFS9LeR3HiyD5pUBRRr9c JkHBD9NA2Rl+PyqHvYJHCU9q3vw9uqsMx86ssgHCFlUiPQhJvJb5fGLM5m0LQn9kfWjT Zn+E6sh+8w/3Jpmdj6CHNRwZFeRIMQPKfZyerfop0jFKTZoT1AK7be87KtQJVw5y307t hfqLAOq+UBKDVImakFNjDJtS5thMsCv2PiEmjfyo9SxiIEe+gractZ9UdT95ix8PiO9L x+7A== X-Gm-Message-State: AOAM531mVz1TWbHp1KebEkQhlaO01Yyq34UOovXapWEWUcFcudgyAVB7 7AXmlY9K149Te7VYYkZgJNWsjQ== X-Google-Smtp-Source: ABdhPJzvtP3yUsWdjFWnv3mLUSZ+nE32zs5G58Bd972PHZWHpFni40FibDAuNT8E0DM5cs8JyEeZXA== X-Received: by 2002:a1c:4182:: with SMTP id o124mr22327685wma.61.1615203475530; Mon, 08 Mar 2021 03:37:55 -0800 (PST) Received: from srini-hackbox.lan (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.gmail.com with ESMTPSA id w6sm19448899wrl.49.2021.03.08.03.37.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 03:37:55 -0800 (PST) From: Srinivas Kandagatla To: vkoul@kernel.org Subject: [PATCH] soundwire: bus: Fix device found flag correctly Date: Mon, 8 Mar 2021 11:37:52 +0000 Message-Id: <20210308113752.19661-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, Srinivas Kandagatla , sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" found flag that is used to indicate SoundWire device on the bus is not reset correctly after one iteration, this could miss adding devices that are enumerated on the bus but on in device list. Fixes: d52d7a1be02c ("soundwire: Add Slave status handling helpers") Signed-off-by: Srinivas Kandagatla Reviewed-by: Pierre-Louis Bossart --- drivers/soundwire/bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c index a9ab4a6264e0..188e391c5a83 100644 --- a/drivers/soundwire/bus.c +++ b/drivers/soundwire/bus.c @@ -712,7 +712,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) struct sdw_slave *slave, *_s; struct sdw_slave_id id; struct sdw_msg msg; - bool found = false; + bool found; int count = 0, ret; u64 addr; @@ -744,6 +744,7 @@ static int sdw_program_device_num(struct sdw_bus *bus) sdw_extract_slave_id(bus, addr, &id); + found = false; /* Now compare with entries */ list_for_each_entry_safe(slave, _s, &bus->slaves, node) { if (sdw_compare_devid(slave, id) == 0) {