From patchwork Tue Mar 9 03:00:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangfei Gao X-Patchwork-Id: 12123887 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A38C433E6 for ; Tue, 9 Mar 2021 03:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FF1E65295 for ; Tue, 9 Mar 2021 03:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhCIDBg (ORCPT ); Mon, 8 Mar 2021 22:01:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230328AbhCIDBO (ORCPT ); Mon, 8 Mar 2021 22:01:14 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D9AAC06174A for ; Mon, 8 Mar 2021 19:01:14 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id 16so1358118pgo.13 for ; Mon, 08 Mar 2021 19:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xwRgjZcAZ1ubRMYqNPR3lzpRRMZVD65trB3Jo7QAQDE=; b=BpsKsKKEGV4Q8tZLIracC064LXu4EhmpaRab2r/UWWvS6AtqSPN2u15MIzC7N+aUyN kFZ8gKGmYVqOTZmZoZ6EkZ8VzQtBzVcG90/alidQ1sfEmuTNV58orapJxrgoVqpUzBGf CpO7VXHOB1HO1r4zyxOga8v3TI8587V2hiYgQO1VcTpVK0EMzWWD5MpKo5eawb00DUET OykXY4yv6cg/VbggLKVUNURQ8RjLFbu4PuniRyG1F7ejK9Yl1e7KzErgQyTmjc3URmsr l6M1dquu5953pAtBDif2JnDbF/8vkVCMjI1Jc2Re8AfPG22q6ox7/kEgybN/JGwgmpmu 6+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xwRgjZcAZ1ubRMYqNPR3lzpRRMZVD65trB3Jo7QAQDE=; b=WgBe08qXPwAVt3CV8sasKQjtaydY1qz1qAFAzKxZj0BcdTRab6vBtbPauov3bzGHkj kJne6RUCa4ah4gaBLA+1nkuLlWFWsYjwsUiAgOBkerlhu/0ITTtEzcTnsB46pHle9lKw 3WC0bqsbJG+XSChv5ihM0H/Ay0gp3J/6fjoDadWk8lclm83gA7AxMDlRvA7iMX86iRg7 mW3M9bUiOcYBahRaL63kId6mfkeaOK1WTDvXq7ukTStwnGMLSCcDTJY+ovA/vHpBHz3P G/ckxAt07fLaVQgFXXBm0a8rV2r3ATwMLi064E4HtQekgunNEqXyG2IlJ9/1TSXelmt/ 1PtA== X-Gm-Message-State: AOAM532GCMHuY0JOxuNZmk5s3oNUEV2H3Ns5kATPdZVRdXxYk6+oK3YO 8mApQ97DBa8SavjmKuhDkXH6xw== X-Google-Smtp-Source: ABdhPJyuSxJJPCTr8ggWaLG5PoVz+cgp0/JSQ3HmniHYtu6KbTJ5qzYIzpa0kF9N+HlOFfEwKQScTA== X-Received: by 2002:a62:ea09:0:b029:1ee:3bac:8012 with SMTP id t9-20020a62ea090000b02901ee3bac8012mr23555442pfh.35.1615258873988; Mon, 08 Mar 2021 19:01:13 -0800 (PST) Received: from localhost.localdomain ([240e:362:435:6a00:e593:6e0:bfb4:a65f]) by smtp.gmail.com with ESMTPSA id y24sm3162782pfn.213.2021.03.08.19.01.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Mar 2021 19:01:13 -0800 (PST) From: Zhangfei Gao To: Bjorn Helgaas , Greg Kroah-Hartman , Arnd Bergmann , jean-philippe , kenneth-lee-2012@foxmail.com, Wangzhou , kw@linux.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangfei Gao Subject: [PATCH v3 1/3] PCI: PASID can be enabled without TLP prefix Date: Tue, 9 Mar 2021 11:00:35 +0800 Message-Id: <1615258837-12189-2-git-send-email-zhangfei.gao@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> References: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org A PASID-like feature is implemented on AMBA without using TLP prefixes and these devices have PASID capability though not supporting TLP. Adding a pasid_no_tlp bit for "PASID works without TLP prefixes" and pci_enable_pasid() checks pasid_no_tlp as well as eetlp_prefix_path. Suggested-by: Bjorn Helgaas Signed-off-by: Zhangfei Gao --- drivers/pci/ats.c | 2 +- include/linux/pci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 793d381..88f981b 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -380,7 +380,7 @@ int pci_enable_pasid(struct pci_dev *pdev, int features) if (WARN_ON(pdev->pasid_enabled)) return -EBUSY; - if (!pdev->eetlp_prefix_path) + if (!pdev->eetlp_prefix_path && !pdev->pasid_no_tlp) return -EINVAL; if (!pasid) diff --git a/include/linux/pci.h b/include/linux/pci.h index 86c799c..1daa943 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -388,6 +388,7 @@ struct pci_dev { supported from root to here */ u16 l1ss; /* L1SS Capability pointer */ #endif + unsigned int pasid_no_tlp:1; /* PASID works without TLP Prefix */ unsigned int eetlp_prefix_path:1; /* End-to-End TLP Prefix */ pci_channel_state_t error_state; /* Current connectivity state */ From patchwork Tue Mar 9 03:00:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangfei Gao X-Patchwork-Id: 12123885 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E05C433DB for ; Tue, 9 Mar 2021 03:02:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC6096528A for ; Tue, 9 Mar 2021 03:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbhCIDBg (ORCPT ); Mon, 8 Mar 2021 22:01:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbhCIDBZ (ORCPT ); Mon, 8 Mar 2021 22:01:25 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7144C06175F for ; Mon, 8 Mar 2021 19:01:25 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id y67so8569662pfb.2 for ; Mon, 08 Mar 2021 19:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F7buwKY8MjxUAqEk7jUYBTTks8KQaYnNtOOELg5e79I=; b=q5nLn8kKw/gYdrH1lCiRkep1A+QCVlGPHwuYveE6xtpdF+OK1w0n5WGIZm7GGPaUFB gzpzVyDcgx+DxA2Ucfy2lL3A33V899Dev1GXxSvL7P2KncjjNJpSPvwVh9mApR5/3C86 4fMVysdO/22+Iro+fZDM3YmFB/H0wPZhTWTjgaOjM0oXO1FQS7kcbBL+K4VaeSDuOtyb /UwUzHf+/0OjLKFiV6NT+FNTbHQ9nCdVBudXUJgnvzWnShypbms4UQWggidrXmLoHgEl 6yrB6keC1LknwaHb4CvUlo7Eh2iaIlbADIgHk/9GgBiDDwQv1B2iciMQXadcfVHHU2fN rBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F7buwKY8MjxUAqEk7jUYBTTks8KQaYnNtOOELg5e79I=; b=UBnAVLEHVARJNvOzG1JpwL3IE9Eeh813Rv6ukhmYjCOnMT2SaA0rbHpAwKBgRgOBA4 CMEfaOMx6Yf0hqNZAbJkVforwlr7TEYfAjM8vqACglR8xDaXEP4kyOiAbvBYyJuWJLUc Gvzibd1K5h+hRnsgSWpU//SBcuUs/BEoOJgay9fTW1e33K3si4D9scRCVUVyo03tiyoQ NFK2silJu0/M/QAuGmL1LAZOsU68Q+QP4TFXcVX9BbAIJduqH7IzLikh2f1qiFtiOdq7 EnpAH5kqRlhrwrceXhYiD57ulejew12Dy09iavzEop/6nWthbqkIE8QYaGikKxKzay+j 4lOQ== X-Gm-Message-State: AOAM532qVO9bX9JYK2AU5Aoifuw3tn9BbtbZfAI34tFyMt+ChMtoGUG4 S2kybxqIS+bPJfYWn+ZxfsKKQw== X-Google-Smtp-Source: ABdhPJzjhdKhRy0M+FqwKVzYU2PmHGpbirTvEbdRzsc1JI7zCJe+fZttcis/LpLWAoLpZ04Hyus3dw== X-Received: by 2002:aa7:9202:0:b029:1f2:9439:f4b4 with SMTP id 2-20020aa792020000b02901f29439f4b4mr12567264pfo.12.1615258885416; Mon, 08 Mar 2021 19:01:25 -0800 (PST) Received: from localhost.localdomain ([240e:362:435:6a00:e593:6e0:bfb4:a65f]) by smtp.gmail.com with ESMTPSA id y24sm3162782pfn.213.2021.03.08.19.01.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Mar 2021 19:01:25 -0800 (PST) From: Zhangfei Gao To: Bjorn Helgaas , Greg Kroah-Hartman , Arnd Bergmann , jean-philippe , kenneth-lee-2012@foxmail.com, Wangzhou , kw@linux.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangfei Gao Subject: [PATCH v3 2/3] PCI: Add a quirk to set pasid_no_tlp for HiSilicon chips Date: Tue, 9 Mar 2021 11:00:36 +0800 Message-Id: <1615258837-12189-3-git-send-email-zhangfei.gao@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> References: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices have PASID capability though not supporting TLP. Add a quirk to set pasid_no_tlp for these devices. Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed-off-by: Zhou Wang --- drivers/pci/quirks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 653660e..873d27f 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1825,6 +1825,20 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_E7525_MCH, quir DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_HUAWEI, 0x1610, PCI_CLASS_BRIDGE_PCI, 8, quirk_pcie_mch); +static void quirk_huawei_pcie_sva(struct pci_dev *pdev) +{ + if (pdev->revision != 0x21 && pdev->revision != 0x30) + return; + + pdev->pasid_no_tlp = 1; +} +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa250, quirk_huawei_pcie_sva); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa251, quirk_huawei_pcie_sva); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa255, quirk_huawei_pcie_sva); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa256, quirk_huawei_pcie_sva); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa258, quirk_huawei_pcie_sva); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa259, quirk_huawei_pcie_sva); + /* * It's possible for the MSI to get corrupted if SHPC and ACPI are used * together on certain PXH-based systems. From patchwork Tue Mar 9 03:00:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangfei Gao X-Patchwork-Id: 12123889 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DE2C433E0 for ; Tue, 9 Mar 2021 03:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C3066528A for ; Tue, 9 Mar 2021 03:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhCIDCJ (ORCPT ); Mon, 8 Mar 2021 22:02:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231192AbhCIDBs (ORCPT ); Mon, 8 Mar 2021 22:01:48 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518C0C06175F for ; Mon, 8 Mar 2021 19:01:37 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id n10so7781084pgl.10 for ; Mon, 08 Mar 2021 19:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+Oax13Ycnamx9wpLhQGKhXcDOzjUXN2vJc4TQ71GNsU=; b=gU4WUzJlwjKAVJ+7f5U3W7EoMep8jE8tU3N4kRRikpr9TVxYr+2pwRsF7I4ndPwa16 1Mz0eXNDtbWKFnBh/FIgV4P6wP2WB6h94iNTbY/OnKONp7yyqNp7TW8WMly3z71VJpAI uAILr9IwVVVHXM2qELYdt5Xg2o/ST7i9/aNsYip1s7UvrmCq8mwZxoLlREtl/4lqr9aC fqmEKAsRoMPENgnbQrR6eaTDW4pj+h2Xe4cZuw5Jp5+HyCEhtZegQJvigJ6FbDbWPFa8 z510+9woum7443Wl2SJOHM4wiB+AapECLkiFExhs3t5znpsptVSxyWo+P0kSNA8bsK/9 o9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+Oax13Ycnamx9wpLhQGKhXcDOzjUXN2vJc4TQ71GNsU=; b=Op97bajQIUW+/AW84mGirisFB7yYpPlm95zT5YPTU3vmq++LeMDMW6gXz2lmTHCuOt g/mfntJ6k/YRCROLxsDjXxqXq3e743FKDX06Qrus8C41IdSrbS6KGnd5Gn5104c/SBrM 4YqNQ6tUYWHuFh2b6oBA7MR7Xv8ijAQZenIYsyAD7E7IMx1IuuKhmem9IkTHROCqD5PK Ak010Yv276o0MYTr7moQ8vrk6puacrwsxMBjU3YMDv6Uk8VXEUNzSFEvxxtx1TS+ItAU sYJIEqbEjsaG3DIrXHKubvawJU1iyrSQTtm9m4dhzxclsrsRZvyW/HxIpOYpEvqiCMp8 XeXg== X-Gm-Message-State: AOAM532PHpojtMg5MQtjIV6Dd/Mil3h+5COZqxbZhTN/zz6J+Y0f3caa OPuN7O8JcIcv5WbSgYZERxP/zA== X-Google-Smtp-Source: ABdhPJynv1TkKneRotBRZI8yhqktf8YsZeI40s4m68ksFSB8eHzgb/WqgWbRHq0gOKDfgjeCaW56nQ== X-Received: by 2002:a62:7ecc:0:b029:1ee:f61b:a63f with SMTP id z195-20020a627ecc0000b02901eef61ba63fmr23596993pfc.57.1615258896884; Mon, 08 Mar 2021 19:01:36 -0800 (PST) Received: from localhost.localdomain ([240e:362:435:6a00:e593:6e0:bfb4:a65f]) by smtp.gmail.com with ESMTPSA id y24sm3162782pfn.213.2021.03.08.19.01.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Mar 2021 19:01:36 -0800 (PST) From: Zhangfei Gao To: Bjorn Helgaas , Greg Kroah-Hartman , Arnd Bergmann , jean-philippe , kenneth-lee-2012@foxmail.com, Wangzhou , kw@linux.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Zhangfei Gao Subject: [PATCH v3 3/3] PCI: Set dma-can-stall for HiSilicon chips Date: Tue, 9 Mar 2021 11:00:37 +0800 Message-Id: <1615258837-12189-4-git-send-email-zhangfei.gao@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> References: <1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices can support SVA via SMMU stall feature, by setting dma-can-stall for ACPI platforms. Property dma-can-stall depends on patchset https://lore.kernel.org/linux-iommu/20210302092644.2553014-1-jean-philippe@linaro.org/ Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed-off-by: Zhou Wang --- drivers/pci/quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 873d27f..b866cdf 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -1827,10 +1827,23 @@ DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_HUAWEI, 0x1610, PCI_CLASS_BRIDGE_PCI static void quirk_huawei_pcie_sva(struct pci_dev *pdev) { + struct property_entry properties[] = { + PROPERTY_ENTRY_BOOL("dma-can-stall"), + {}, + }; + if (pdev->revision != 0x21 && pdev->revision != 0x30) return; pdev->pasid_no_tlp = 1; + + /* + * Set the dma-can-stall property on ACPI platforms. Device tree + * can set it directly. + */ + if (!pdev->dev.of_node && + device_add_properties(&pdev->dev, properties)) + pci_warn(pdev, "could not add stall property"); } DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa250, quirk_huawei_pcie_sva); DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_HUAWEI, 0xa251, quirk_huawei_pcie_sva);