From patchwork Fri Mar 12 11:09:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134369 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C87FC43331 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19C9864FF9 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234076AbhCLLJW (ORCPT ); Fri, 12 Mar 2021 06:09:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234132AbhCLLJP (ORCPT ); Fri, 12 Mar 2021 06:09:15 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C1ABC061761 for ; Fri, 12 Mar 2021 03:09:15 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id e9so1542620wrw.10 for ; Fri, 12 Mar 2021 03:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KXQyr4IBlf8BJXFjheDlLrWyrqRa2WbuLrndUKgj2RE=; b=c4Js0gyWEoLDKpmd1C7WpG0VFopaDp1dQm2+VZf0oryUz1eScc7ZxDbqb+LyE87I5F ePVh3XrvR5lX4IELD37RfRM7gJwEC/tMnPK8m9tRdac5lSxZImh3Le4HEntJ0AQRJYuW uJ3Bnp7fjJr+6WYfuUkTAs4LMiiLOLCLKVtXEqGsc88TZgFFa4Vqy8o6jhI6epPJA89d 7p4FLUSIEm9tQdL2Yf2XMdYQiKEK8b2H/1zq9Po+je7ZIsue6FooKvz+5oheoS1dQiNO +82mmwN6XRHI0a4fFBoAjow4p9XtzjUkzKq+p6RfaipS6RgUon1w75j7slPCa5RCoNv+ y+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KXQyr4IBlf8BJXFjheDlLrWyrqRa2WbuLrndUKgj2RE=; b=MeMg9PnfkHRQSLAFB6EgUv/CuC0iWgp3etDTeiY6ZsvrAnVHTgL/E5xkBH1UmZkEXH 2qca5UH/F3bgZ98Cpngcz9vXafZnrOtGXbzSqqwvRecMxEjOpRrWg4clyDGCVqwrF43a GKejNBfrdgJSVDJ+xf+wfrm0BRTGIQuXXBdSCckxNlk0OOiATnwvFVlmCzst/MM6dQmq fbhW/6i6G/qW9kXx+Zktpn8sTMRMW70tqxGZ8yzSldw6SSKDRptFvoqT9nC0R9kFhjb+ CKaAG3uR3IDsNzsTXEuQinWoSU7XVNBbyKt+hndyxGb6T6ldY4o35alPs63t5WIwWJaG W3yA== X-Gm-Message-State: AOAM533YwMkvzC/+8AM1xFGnmdrxt2huMNMrSm0Gjp2zT8JqYY8HmlNR DS/CTKWerPUFIXscLQnl1UHvJg== X-Google-Smtp-Source: ABdhPJxk0DwjcM/U/+T+uTxhmPkRR+tX9XIpFD8h/LWICV/2kERf8CJbZMSjxrmB5XjT2NMLQPXlMA== X-Received: by 2002:a5d:550b:: with SMTP id b11mr13671486wrv.313.1615547354239; Fri, 12 Mar 2021 03:09:14 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id b65sm1833255wmh.4.2021.03.12.03.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:09:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Richard Cochran , "David S. Miller" , Jakub Kicinski , Flavio Suligoi , netdev@vger.kernel.org Subject: [PATCH 1/4] ptp_pch: Remove unused function 'pch_ch_control_read()' Date: Fri, 12 Mar 2021 11:09:07 +0000 Message-Id: <20210312110910.2221265-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312110910.2221265-1-lee.jones@linaro.org> References: <20210312110910.2221265-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] Cc: Richard Cochran (maintainer:PTP HARDWARE CLOCK SUPPORT) Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Flavio Suligoi Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 1 - drivers/ptp/ptp_pch.c | 11 ----------- 2 files changed, 12 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h index 55cef5b16aa5f..3ce4899a0417a 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h @@ -612,7 +612,6 @@ void pch_gbe_free_tx_resources(struct pch_gbe_adapter *adapter, void pch_gbe_free_rx_resources(struct pch_gbe_adapter *adapter, struct pch_gbe_rx_ring *rx_ring); void pch_gbe_update_stats(struct pch_gbe_adapter *adapter); -u32 pch_ch_control_read(struct pci_dev *pdev); void pch_ch_control_write(struct pci_dev *pdev, u32 val); u32 pch_ch_event_read(struct pci_dev *pdev); void pch_ch_event_write(struct pci_dev *pdev, u32 val); diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index ce10ecd41ba0f..f7ff7230623e0 100644 --- a/drivers/ptp/ptp_pch.c +++ b/drivers/ptp/ptp_pch.c @@ -179,17 +179,6 @@ static inline void pch_block_reset(struct pch_dev *chip) iowrite32(val, (&chip->regs->control)); } -u32 pch_ch_control_read(struct pci_dev *pdev) -{ - struct pch_dev *chip = pci_get_drvdata(pdev); - u32 val; - - val = ioread32(&chip->regs->ch_control); - - return val; -} -EXPORT_SYMBOL(pch_ch_control_read); - void pch_ch_control_write(struct pci_dev *pdev, u32 val) { struct pch_dev *chip = pci_get_drvdata(pdev); From patchwork Fri Mar 12 11:09:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134373 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBD0C43332 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 471EB64FE0 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234091AbhCLLJX (ORCPT ); Fri, 12 Mar 2021 06:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234134AbhCLLJQ (ORCPT ); Fri, 12 Mar 2021 06:09:16 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70DE9C061574 for ; Fri, 12 Mar 2021 03:09:16 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id l12so4577466wry.2 for ; Fri, 12 Mar 2021 03:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D6lQXV61iewTKIv5i4KOkr8EKJzCNFbTLpbymYvdwHU=; b=RwobTaYwbQS+lj0odiENE5fNvUZZOxmZSzfVlIdeLeYumq932qYV8X2CWN5yUkPA9E /9Ywyr4RCRrFPvVvaSuWPWpWZyBCBxbTRIVqlsSmoCzDw0+wFRgCDdHsCEpatHBmJdqr GuNt7JsXwfSrhQKJr/ecX8iAGyk8r12DJqNST43JBtVAzA0Ek3mxsrZVq+GVBgpPI63L LGH4E1jAJofw96hVrhN4jdDaY9CCopN//3b4KRFTiw6athMIU8lwoKtx6iYJMR2Wvfsx j/2WvUXwTcr0YFr3vCFOVyjInwkZs2ZiRYFV6lGlc6eEKgXuvWxA2nFx9Nx8pkI7rJkO swkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D6lQXV61iewTKIv5i4KOkr8EKJzCNFbTLpbymYvdwHU=; b=EI2i9QcFhu6QsorOCJDPYhHv/NGOYVzf4X8jC3PKAzZ0Fmftp7obek9m4IX8FaGt3+ KG8kDFsEQkicZb6BxLCXHiNG2KIdtZhf5xmn4ABadj06VX6OicH/oeofnJM1Hu3PTe2p Boa5GOQ6RLYXiq47589PaI/CAoKFKuQezwB/U8+h12aBATfB/9d+Gn0lthddjibL0VzI vcur7Odr3N4mvWKVblLE3XC5b/YBIlGFke51ubQL2MLEeR2dWFuNLHi2eYjaKp9A+bq1 aTavWw5ClVocwJS3dCx5jY3vbm/2cYN6PA6bjQi4elBQRGGqTN0/81g0/4oBQ+RFh2CP fJfw== X-Gm-Message-State: AOAM532a2Leb5zvBs/kI6ve8mon5VLpaf/IiN7EfCT/5IqocG7TFGKwh v5JJ0gdYK2ciShlBbHwTTl5lmg== X-Google-Smtp-Source: ABdhPJwasaqKf97Mz2slYVBHqf9MlRKv71YKNgaCQBZJ8yUWUOzKYm82Yh5qDUGeMUpLrNePoCa74w== X-Received: by 2002:adf:97d5:: with SMTP id t21mr13311278wrb.139.1615547355144; Fri, 12 Mar 2021 03:09:15 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id b65sm1833255wmh.4.2021.03.12.03.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:09:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Richard Cochran , "David S. Miller" , Jakub Kicinski , Flavio Suligoi , netdev@vger.kernel.org Subject: [PATCH 2/4] ptp_pch: Move 'pch_*()' prototypes to shared header Date: Fri, 12 Mar 2021 11:09:08 +0000 Message-Id: <20210312110910.2221265-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312110910.2221265-1-lee.jones@linaro.org> References: <20210312110910.2221265-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:201:5: warning: no previous prototype for ‘pch_ch_event_read’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:212:6: warning: no previous prototype for ‘pch_ch_event_write’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:220:5: warning: no previous prototype for ‘pch_src_uuid_lo_read’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:231:5: warning: no previous prototype for ‘pch_src_uuid_hi_read’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:242:5: warning: no previous prototype for ‘pch_rx_snap_read’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:259:5: warning: no previous prototype for ‘pch_tx_snap_read’ [-Wmissing-prototypes] drivers/ptp/ptp_pch.c:300:5: warning: no previous prototype for ‘pch_set_station_address’ [-Wmissing-prototypes] Cc: Richard Cochran (maintainer:PTP HARDWARE CLOCK SUPPORT) Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Flavio Suligoi Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 8 ------- .../ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 1 + drivers/ptp/ptp_pch.c | 1 + include/linux/ptp_pch.h | 22 +++++++++++++++++++ 4 files changed, 24 insertions(+), 8 deletions(-) create mode 100644 include/linux/ptp_pch.h diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h index 3ce4899a0417a..a6823c4d355d5 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h @@ -612,14 +612,6 @@ void pch_gbe_free_tx_resources(struct pch_gbe_adapter *adapter, void pch_gbe_free_rx_resources(struct pch_gbe_adapter *adapter, struct pch_gbe_rx_ring *rx_ring); void pch_gbe_update_stats(struct pch_gbe_adapter *adapter); -void pch_ch_control_write(struct pci_dev *pdev, u32 val); -u32 pch_ch_event_read(struct pci_dev *pdev); -void pch_ch_event_write(struct pci_dev *pdev, u32 val); -u32 pch_src_uuid_lo_read(struct pci_dev *pdev); -u32 pch_src_uuid_hi_read(struct pci_dev *pdev); -u64 pch_rx_snap_read(struct pci_dev *pdev); -u64 pch_tx_snap_read(struct pci_dev *pdev); -int pch_set_station_address(u8 *addr, struct pci_dev *pdev); /* pch_gbe_param.c */ void pch_gbe_check_options(struct pch_gbe_adapter *adapter); diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c index 140cee7c459d0..334af49e5add1 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #define DRV_VERSION "1.01" diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index f7ff7230623e0..fa4417ad02e0c 100644 --- a/drivers/ptp/ptp_pch.c +++ b/drivers/ptp/ptp_pch.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #define STATION_ADDR_LEN 20 diff --git a/include/linux/ptp_pch.h b/include/linux/ptp_pch.h new file mode 100644 index 0000000000000..51818198c2921 --- /dev/null +++ b/include/linux/ptp_pch.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * PTP PCH + * + * Copyright 2019 Linaro Ltd. + * + * Author Lee Jones + */ + +#ifndef _PTP_PCH_H_ +#define _PTP_PCH_H_ + +void pch_ch_control_write(struct pci_dev *pdev, u32 val); +u32 pch_ch_event_read(struct pci_dev *pdev); +void pch_ch_event_write(struct pci_dev *pdev, u32 val); +u32 pch_src_uuid_lo_read(struct pci_dev *pdev); +u32 pch_src_uuid_hi_read(struct pci_dev *pdev); +u64 pch_rx_snap_read(struct pci_dev *pdev); +u64 pch_tx_snap_read(struct pci_dev *pdev); +int pch_set_station_address(u8 *addr, struct pci_dev *pdev); + +#endif /* _PTP_PCH_H_ */ From patchwork Fri Mar 12 11:09:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDAEC43333 for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC8A64FFA for ; Fri, 12 Mar 2021 11:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234153AbhCLLJ0 (ORCPT ); Fri, 12 Mar 2021 06:09:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234137AbhCLLJR (ORCPT ); Fri, 12 Mar 2021 06:09:17 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A9CC061761 for ; Fri, 12 Mar 2021 03:09:17 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id e9so1542681wrw.10 for ; Fri, 12 Mar 2021 03:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZUveGSK6npk+QC7yNW+jetwhUE1LMyTcafYKcvUPbJg=; b=HtV+vx+dDBMdKSoFQBtUj3Qj5DXlD8N49u7k8YbucAZ/rl+eZ/su8Coa4vOMozqw4Z R62GV6sQuAwiTgmPOBDJy5OpBWuuTHeVqIEH+sF4alkZVi8wTLwl3RXnGhrK8KMycVBq gbQc7f/lDG9bqOldjobRuPE+P4O+B3nCxhFd1XAzHqaKQiThdlCJBOI00l4Z1jMu/6Ra Q1PWOl3bfXB4gFagpmz9w0OpEHUAySpTlD43zy+V3r+oYeDu6jVITifFOb5qAxDQuHZb 1ZTnR030A9QG/5dFbw8gcsDKTdiBCzb1xwEefSAq3kaBgSaUk1MdAoW5d8wpQkQTv7XU wEgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZUveGSK6npk+QC7yNW+jetwhUE1LMyTcafYKcvUPbJg=; b=NLuFyeHbZ2WFeXD6MHbBYW41QSxvuZ0dxoGhp7iJMsEQtgshaqPu8xnQ8zy5D92hXD GKrUf0i99PdpehpwjLwThzqLSxg7xTGT1myb1XPkRzvvFAfJue4S+OlwWE2tLHTdLoRv ar5SJDyeMtPWJt8FJ5vEfKJlXG6TIFdD3PKN+mYadzb09nu+FEA5PufQok0nLaERmH7W +dgCMTd+pCg5MDJOwhRc8wsTWbGDZ02jotZglyhw5yjNOh5/dbPD+3v8/ktYlLdF0rgu osrXuHS+RgZ/78r4LF4Asqxp9laisyfUA3eLfMLVM5IgdSB9POY51EZs/73G9Ab44bWd fWAw== X-Gm-Message-State: AOAM530qsl6G2Tdz9i8guFHoDxlEX72o11buacMEWe9L0gol91cgUs3K Ne1sVhmTMJFFxvbrLpwbW2JnRQ== X-Google-Smtp-Source: ABdhPJyHjEoKvLyPV7yLmDisgrMONtxyetTll9HcG55CZuw+qxTIA+YsnK2unQ03AFR6B0m/NqjZQA== X-Received: by 2002:a05:6000:250:: with SMTP id m16mr13662032wrz.325.1615547356191; Fri, 12 Mar 2021 03:09:16 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id b65sm1833255wmh.4.2021.03.12.03.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:09:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Richard Cochran , IDT-support-1588@lm.renesas.com, netdev@vger.kernel.org Subject: [PATCH 3/4] ptp: ptp_clockmatrix: Demote non-kernel-doc header to standard comment Date: Fri, 12 Mar 2021 11:09:09 +0000 Message-Id: <20210312110910.2221265-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312110910.2221265-1-lee.jones@linaro.org> References: <20210312110910.2221265-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand * @brief Maximum absolute value for write phase offset in picoseconds drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand * @brief Maximum absolute value for write phase offset in picoseconds drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand * @brief Maximum absolute value for write phase offset in picoseconds drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand * @brief Maximum absolute value for write phase offset in picoseconds drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand * @brief Maximum absolute value for write phase offset in picoseconds Cc: Richard Cochran Cc: IDT-support-1588@lm.renesas.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ptp/ptp_clockmatrix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index 75463c2e2b867..fa636951169e5 100644 --- a/drivers/ptp/ptp_clockmatrix.c +++ b/drivers/ptp/ptp_clockmatrix.c @@ -1404,8 +1404,8 @@ static int idtcm_set_pll_mode(struct idtcm_channel *channel, /* PTP Hardware Clock interface */ -/** - * @brief Maximum absolute value for write phase offset in picoseconds +/* + * Maximum absolute value for write phase offset in picoseconds * * Destination signed register is 32-bit register in resolution of 50ps * From patchwork Fri Mar 12 11:09:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12134375 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02158C433E6 for ; Fri, 12 Mar 2021 11:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3DCF64FEE for ; Fri, 12 Mar 2021 11:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233884AbhCLLJx (ORCPT ); Fri, 12 Mar 2021 06:09:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234055AbhCLLJS (ORCPT ); Fri, 12 Mar 2021 06:09:18 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56C93C061574 for ; Fri, 12 Mar 2021 03:09:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id y16so4586066wrw.3 for ; Fri, 12 Mar 2021 03:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZLANRHliRO73E/sxll05XoJuWbOQ7cfgrUcNCab2WrE=; b=F6WN3Mo8QzSuMitYPhDY5pFMEMdgvHcA8euhraBsMg5y4Ghj/V1/4oSsOa6NeQRGZ9 qDY67j4czyel4Pqt5xdxCXHIzA4ngSdX6SUS5ZU2+OXZm2YbEIQ/T4a3h+hb4Veu1Sj9 e4O+Wdngyz55/G7XS4VAIGqXefmP4pE/q5LRUifn8G5+bJOO9HJLlqoeAvXq0l2eB7U3 YhyP2bTsW/xBJKNXFiLwugkEx8IT6G33WyBVe1KWK2E+0LFOB2IlZgKB7VV13V+iVL+q zTJ+A5a4xFIq0zw+0WfB6ml7l+RcrCCZ2Qlu0J/EjL94g5GNSu1gub+V0BB+zXzEqTQT ut+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZLANRHliRO73E/sxll05XoJuWbOQ7cfgrUcNCab2WrE=; b=fC5XLR6yfWV6Icdjnm9mquhE/uxx+zqtfO3/ZOb9FZwAtOTVt3VPSWQhS1jhqcD09k V1jxVZXfGMDAmWWfXKIgSQV/ZaLQxNEcSGScgr83zY9ahKJe/RbvTWS/X0VLxAcScGuY EDhGLecSxpQKTl5SnHJtF+CcNJ+EWnkp0EkCTF1rruzwASN8pz+efRfwj5NIDm5owpJy i2MNekeTP6UKSkSHycd//iAeo6ru29M8VHykpzm/29SoW9H4R6wQ7jfYjeUzr7TBdGJZ 8oIhmf7kCe3P/nYBcB9OUoJDHuNj07r1QLxDOXEPe5sVCR45kmGNtE08/cds6VLRHhN1 bk4A== X-Gm-Message-State: AOAM533TXVfNIYETyNTRkgMgnn/XicXetbj2mXK0xIOY+hKTDEpGRMqa DEg2qkLeYu7KVLvIhN+1EoLWzw== X-Google-Smtp-Source: ABdhPJzBZxEfRiXDIa54RX+VDX64gnUgXaLm+YOS8fR0v6kksaceGaXE+M9CpZAg5QJjonQ+nBkgDg== X-Received: by 2002:a5d:4fd0:: with SMTP id h16mr12939845wrw.178.1615547357082; Fri, 12 Mar 2021 03:09:17 -0800 (PST) Received: from dell.default ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id b65sm1833255wmh.4.2021.03.12.03.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 03:09:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Richard Cochran , LAPIS SEMICONDUCTOR , netdev@vger.kernel.org Subject: [PATCH 4/4] ptp: ptp_p: Demote non-conformant kernel-doc headers and supply a param description Date: Fri, 12 Mar 2021 11:09:10 +0000 Message-Id: <20210312110910.2221265-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210312110910.2221265-1-lee.jones@linaro.org> References: <20210312110910.2221265-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'control' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'event' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'addend' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'accum' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'test' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_compare' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rsystime_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rsystime_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'systime_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'systime_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'trgt_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'trgt_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'asms_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'asms_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'amms_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'amms_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ch_control' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ch_event' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'tx_snap_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'tx_snap_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rx_snap_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rx_snap_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'src_uuid_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'src_uuid_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_status' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_snap_lo' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_snap_hi' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_sel' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_st' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'reserve1' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'stl_max_set_en' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'stl_max_set' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'reserve2' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'srst' not described in 'pch_ts_regs' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'regs' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'ptp_clock' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'caps' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'exts0_enabled' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'exts1_enabled' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'mem_base' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'mem_size' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'irq' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'pdev' not described in 'pch_dev' drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'register_lock' not described in 'pch_dev' drivers/ptp/ptp_pch.c:128: warning: Function parameter or member 'station' not described in 'pch_params' drivers/ptp/ptp_pch.c:291: warning: Function parameter or member 'pdev' not described in 'pch_set_station_address' Cc: Richard Cochran Cc: LAPIS SEMICONDUCTOR Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ptp/ptp_pch.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index fa4417ad02e0c..a17e8cc642c5f 100644 --- a/drivers/ptp/ptp_pch.c +++ b/drivers/ptp/ptp_pch.c @@ -37,7 +37,8 @@ enum pch_status { PCH_FAILED, PCH_UNSUPPORTED, }; -/** + +/* * struct pch_ts_regs - IEEE 1588 registers */ struct pch_ts_regs { @@ -103,7 +104,8 @@ struct pch_ts_regs { #define PCH_IEEE1588_ETH (1 << 0) #define PCH_IEEE1588_CAN (1 << 1) -/** + +/* * struct pch_dev - Driver private data */ struct pch_dev { @@ -120,7 +122,7 @@ struct pch_dev { spinlock_t register_lock; }; -/** +/* * struct pch_params - 1588 module parameter */ struct pch_params { @@ -286,6 +288,7 @@ static void pch_reset(struct pch_dev *chip) * IEEE 1588 hardware when looking at PTP * traffic on the ethernet interface * @addr: dress which contain the column separated address to be used. + * @pdev: PCI device. */ int pch_set_station_address(u8 *addr, struct pci_dev *pdev) {