From patchwork Tue Mar 16 21:56:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 12144231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A2BEC433DB for ; Tue, 16 Mar 2021 21:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FAD764FAB for ; Tue, 16 Mar 2021 21:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229887AbhCPV5E (ORCPT ); Tue, 16 Mar 2021 17:57:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhCPV5D (ORCPT ); Tue, 16 Mar 2021 17:57:03 -0400 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69C55C06174A for ; Tue, 16 Mar 2021 14:57:03 -0700 (PDT) Received: by mail-qt1-x849.google.com with SMTP id l13so12677017qtu.6 for ; Tue, 16 Mar 2021 14:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=6DfkZN7WQbO1dvbjrdbjBHr+qM1rCOx1KfIaAxgNHAw=; b=RmnPRgfnot0nvRyG2KYcw9NGB4ZvTwu9Igo7aDUa0v8DYGP12qcseVIbhjRiNJ/+uC X9Zz8L+09dHMJQYpEyyoKSBmkx+o9d26i0jb/7HcIeElMU4NsXQerYAwjgl6BuXcsmwe OdjYwfyVGMHkDjpdcfAZBkE0p6L2wUVUN4q+77H9EQe8iEebfD49iT9/tKwdrKdXdNs2 ekLoYHO6ptkiLYW8sxBlcmi+iOy+9nmqp2W1dbZwWZvNSZIwR3ON1Dugrl45Hr942Oxn VdX3JYqqT/ei+W/6E6cNbOd92PzpKmZNczxv5EnLoR+JVf8YIwJ8rL9vue1on0rneoum nBYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=6DfkZN7WQbO1dvbjrdbjBHr+qM1rCOx1KfIaAxgNHAw=; b=iQ5AL3tBXcvbOqjAgc6pgWRtBYm72ISfJLUt0s9ijxww9w2mnY49OM5wdJhMJSeFtd 7VLh0bNMrtUQpMyB/JSzDu4oTWoaGaByIAmDXI3uWTCtj4ryz0XEaOhT2o1MyTlDXv15 GoH8FpDMcNimsaxmJp6bdlpD/71fD1eOFW02UR9Krowb1bzTR0khiP10BI/QDKTio3t5 gC+vtlV1vjmjhMA/98BbHdEjQcql3/zCjh9XcebCGRYQznSddb+QYSfiPC19bp6oWWii nSa7R9zp4Fz4j9pJe3vzFlPWOrK/OG8oNMGNQQRh2FEcQLvJsSPUrxciJgzsX6q5EjOY 6HAg== X-Gm-Message-State: AOAM532tuU5twzhezDpK7KPMGAE51zbLnA4wX0jty8TzxF/wBofn2ftL lNE137RQLuhAfSB7rirfbvr2dzVdz84= X-Google-Smtp-Source: ABdhPJz6tEHn3wR8lIfXg5Ff/co+kHwF3TzWU0RX2p1hKNtmrEA++I2Me3P9dZxPY6pWwm81PCku2iF39mY= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:e53d:77e7:f975:af74]) (user=badhri job=sendgmr) by 2002:a0c:8ec1:: with SMTP id y1mr2065111qvb.11.1615931822559; Tue, 16 Mar 2021 14:57:02 -0700 (PDT) Date: Tue, 16 Mar 2021 14:56:57 -0700 Message-Id: <20210316215657.387357-1-badhri@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog Subject: [PATCH] usb: typec: tcpm: Invoke power_supply_changed for tcpm-source-psy- From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Adam Thomson , Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org tcpm-source-psy- does not invoke power_supply_changed API when one of the published power supply property is changed. power_supply_changed needs to be called to notify userspace clients(uevents) and kernel clients. Fixes: f2a8aa053c176("typec: tcpm: Represent source supply through power_supply") Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tcpm/tcpm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 11d0c40bc47d..e8936ea17f80 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -945,6 +945,7 @@ static int tcpm_set_current_limit(struct tcpm_port *port, u32 max_ma, u32 mv) port->supply_voltage = mv; port->current_limit = max_ma; + power_supply_changed(port->psy); if (port->tcpc->set_current_limit) ret = port->tcpc->set_current_limit(port->tcpc, max_ma, mv); @@ -2931,6 +2932,7 @@ static int tcpm_pd_select_pdo(struct tcpm_port *port, int *sink_pdo, port->pps_data.supported = false; port->usb_type = POWER_SUPPLY_USB_TYPE_PD; + power_supply_changed(port->psy); /* * Select the source PDO providing the most power which has a @@ -2955,6 +2957,7 @@ static int tcpm_pd_select_pdo(struct tcpm_port *port, int *sink_pdo, port->pps_data.supported = true; port->usb_type = POWER_SUPPLY_USB_TYPE_PD_PPS; + power_supply_changed(port->psy); } continue; default: @@ -3112,6 +3115,7 @@ static unsigned int tcpm_pd_select_pps_apdo(struct tcpm_port *port) port->pps_data.out_volt)); port->pps_data.op_curr = min(port->pps_data.max_curr, port->pps_data.op_curr); + power_supply_changed(port->psy); } return src_pdo; @@ -3347,6 +3351,7 @@ static int tcpm_set_charge(struct tcpm_port *port, bool charge) return ret; } port->vbus_charge = charge; + power_supply_changed(port->psy); return 0; } @@ -3530,6 +3535,7 @@ static void tcpm_reset_port(struct tcpm_port *port) port->try_src_count = 0; port->try_snk_count = 0; port->usb_type = POWER_SUPPLY_USB_TYPE_C; + power_supply_changed(port->psy); port->nr_sink_caps = 0; port->sink_cap_done = false; if (port->tcpc->enable_frs) @@ -5957,7 +5963,7 @@ static int tcpm_psy_set_prop(struct power_supply *psy, ret = -EINVAL; break; } - + power_supply_changed(port->psy); return ret; } @@ -6110,6 +6116,7 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) err = devm_tcpm_psy_register(port); if (err) goto out_role_sw_put; + power_supply_changed(port->psy); port->typec_port = typec_register_port(port->dev, &port->typec_caps); if (IS_ERR(port->typec_port)) {