From patchwork Thu Mar 18 12:44:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148113 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA2BC4332E for ; Thu, 18 Mar 2021 12:45:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D18A464F8B for ; Thu, 18 Mar 2021 12:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbhCRMo4 (ORCPT ); Thu, 18 Mar 2021 08:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbhCRMod (ORCPT ); Thu, 18 Mar 2021 08:44:33 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7CEAC06174A for ; Thu, 18 Mar 2021 05:44:32 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id z2so5377702wrl.5 for ; Thu, 18 Mar 2021 05:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cqK2Pp2ViTz0xdgYhapttz8LcH4etuWNmG0+y0P94Tk=; b=OA9EIYsInkm8+sbKDz65mq57blKnFk/VyB2KwDk4y5vDgz6vnx4e19aC7mQ4UamzvD 8axwr/dUv/8a30fI7OPHVI6nG5Hpj237RPlR9w/4Me0kWU4D65vEKauzTCHvM4TXlXqt Ye7le7bu5vxmYtgQ29JW01tPCw2+eLDnmKkReOUOeOlRJm3h00gybG0Sn/tofbARn+4v Nk5YEyh5SBRVM0kgOl5TGaU9YS4XgQ5LCG97a7VD6aXvKM0TL921nV8IgWxH1wHDN7KQ WXx50dqy7LYZI2p5efB/j3TTR1hXGzQgwh9pxXBQSeD7rVwlAxlcvUqX9+LFOEy3NaNA gkPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cqK2Pp2ViTz0xdgYhapttz8LcH4etuWNmG0+y0P94Tk=; b=NHaVg+bhx3pBz8lb0JO3pKJJfV/Svo1esb0SUriIIKWLDssma8oNxhbDFIBXD2xPqf HJkisp7BdiePcILUQSeCvPTKFzyzBLIQiZ2TbD5oc2hYt1BFV8cneFKijEYNgcyhMFpY 8mMttSe0lfeu2iNnzEMZzgvJcfy3TnFz91z9hufC/rw1YYykmYPKyiCSTcbGZAe6qLCE RRtjD8pfDE0zAjZIDUUgO+X9w4nz9NJvc+Wh1cpvj2OtPaqkSUVOcdQxhNDzxf3GE6zM KKs/4FYJhEwSgin3QMe7budQfw0nHllmC7iiBrRNJrbGSmRXjD1RI3iglc1zJYb6oyLv AquA== X-Gm-Message-State: AOAM530yIs6/UyYD0OfVHefXpn/tFsuXh/f9V8LHlNi5uPgjLHDwKYdD TIqi4sNePo8O/5ryxvyOpGhfuw== X-Google-Smtp-Source: ABdhPJwV0CtMRkwCaOXy/5vvgsMtNuWjcOi3sZABwA4HMtXR7vy5o/de4/orKnRynrT1wJ3qUCKnpw== X-Received: by 2002:adf:ea8d:: with SMTP id s13mr9585919wrm.32.1616071471400; Thu, 18 Mar 2021 05:44:31 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:31 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Zaibo Xu , Jonathan Cameron , linux-crypto@vger.kernel.org Subject: [PATCH 01/10] crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param Date: Thu, 18 Mar 2021 12:44:13 +0000 Message-Id: <20210318124422.3200180-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/hisilicon/sec/sec_drv.c:843: warning: Function parameter or member 'queue' not described in 'sec_queue_empty' Cc: Herbert Xu Cc: "David S. Miller" Cc: Zaibo Xu Cc: Jonathan Cameron Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/hisilicon/sec/sec_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/hisilicon/sec/sec_drv.c b/drivers/crypto/hisilicon/sec/sec_drv.c index 91ee2bb575df2..3c26871db12f3 100644 --- a/drivers/crypto/hisilicon/sec/sec_drv.c +++ b/drivers/crypto/hisilicon/sec/sec_drv.c @@ -834,6 +834,7 @@ int sec_queue_stop_release(struct sec_queue *queue) /** * sec_queue_empty() - Is this hardware queue currently empty. + * @queue: The queue to test * * We need to know if we have an empty queue for some of the chaining modes * as if it is not empty we may need to hold the message in a software queue From patchwork Thu Mar 18 12:44:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148115 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 315F2C43331 for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC84C64F75 for ; Thu, 18 Mar 2021 12:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbhCRMo5 (ORCPT ); Thu, 18 Mar 2021 08:44:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231316AbhCRMoe (ORCPT ); Thu, 18 Mar 2021 08:44:34 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADD69C06174A for ; Thu, 18 Mar 2021 05:44:33 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id y124-20020a1c32820000b029010c93864955so5332613wmy.5 for ; Thu, 18 Mar 2021 05:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=erPTjshbhLchKwQuh0XQUk+wc12RIGoz2km1xclT6d4=; b=ee/c4LUZpdK7VWKlie0diTxa9C6IwX6xHHt5fpJpDfVU/2sGHpJkVdVgqIPHgCNyyT Y9T9l19vxjRlyvRkwD/oJ/+QQOz6De6DDqSrIoIusa6tWpbLG2TfGvhIBeHouPP+JZXi bNvjU6OhWb1r++FZSK1596YVUKZXW6oEPS6EmNJAfEKA4EUusVcSPFebPPUDYWYctExD mrdmrDbhxj1eXxGXoO80xyC1biQTsQo2z0Slm36dSvfl/YK67RltFLQcw6tWDyPZkhIK uZYQerUg1xl9cXcV/qk2dTicU6vlOiCVkVrlNLefgf68D3g9JFhkJDQ/H5xzF2Hj06mi Nkaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=erPTjshbhLchKwQuh0XQUk+wc12RIGoz2km1xclT6d4=; b=hyZXNBJUXH94GK0SWmwYymnjSm2WahPfMIZAN2SPSPqfhBvmnSrP8b/RJyhOkx3EPp sbIeedITEk0Zz2F+MHWK1gJHj+8hMi1TdsRaRXkRFSI9yCZN7kCsmiEOC3aQ55jADWR8 TugyE3zBDiIBXwAkOXiY38eKS1meMgYjDOcux5WbjFXBYx0QD6bS46L1d7bOQCb9ocVl e3Q4iQQyr+Si2gWrrsiM618fuwZ+A5PDBJeiKtEDTr6HM2EuXCYUwPpjZz7amY66qLQt PqzEp/Gc4S+bVdeA13gUzX/U2Tb0XfMc1X1oqh1I4Qe7DLr1jmBp8UkJkJw8JMbQcKip sSgg== X-Gm-Message-State: AOAM530CmuWMT+jQG54Jba4aJY4p1+QKqCnMloepZC2DcokP/s2isqW8 cGQu+y77mgXhHYXcnqWevVD1Tw== X-Google-Smtp-Source: ABdhPJwifFzixttf+LcL61nVk6fXeDzOYtrp+S9Yt//DjsPNRcXkWTUyYPbaiUa5bMAj8u1urYyUeg== X-Received: by 2002:a05:600c:3541:: with SMTP id i1mr3485980wmq.97.1616071472368; Thu, 18 Mar 2021 05:44:32 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:31 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Rob Rice , linux-crypto@vger.kernel.org Subject: [PATCH 02/10] crypto: bcm: Fix a whole host of kernel-doc misdemeanours Date: Thu, 18 Mar 2021 12:44:14 +0000 Message-Id: <20210318124422.3200180-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'from_nents' not described in 'spu_msg_sg_add' drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'length' not described in 'spu_msg_sg_add' drivers/crypto/bcm/spu.c:464: warning: Excess function parameter 'Return' description in 'spum_gcm_ccm_pad_len' drivers/crypto/bcm/spu.c:524: warning: Function parameter or member 'iv_len' not described in 'spum_aead_ivlen' drivers/crypto/bcm/spu.c:524: warning: expecting prototype for spu_aead_ivlen(). Prototype was for spum_aead_ivlen() instead drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg_digest_size' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'htype' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:583: warning: bad line: drivers/crypto/bcm/spu.c:927: warning: Function parameter or member 'is_inbound' not described in 'spum_cipher_req_finish' drivers/crypto/bcm/spu.c:927: warning: Excess function parameter 'isInbound' description in 'spum_cipher_req_finish' drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'fmd' not described in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'spu2_type' not described in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:557: warning: Excess function parameter 'spu2_cipher_type' description in 'spu2_fmd_init' drivers/crypto/bcm/spu2.c:615: warning: Function parameter or member 'auth_first' not described in 'spu2_fmd_ctrl0_write' drivers/crypto/bcm/spu2.c:615: warning: Excess function parameter 'authFirst' description in 'spu2_fmd_ctrl0_write' drivers/crypto/bcm/spu2.c:666: warning: Function parameter or member 'is_inbound' not described in 'spu2_fmd_ctrl1_write' drivers/crypto/bcm/spu2.c:803: warning: expecting prototype for spu_payload_length(). Prototype was for spu2_payload_length() instead drivers/crypto/bcm/spu2.c:825: warning: Function parameter or member 'is_hash' not described in 'spu2_response_hdr_len' drivers/crypto/bcm/spu2.c:825: warning: expecting prototype for spu_response_hdr_len(). Prototype was for spu2_response_hdr_len() instead drivers/crypto/bcm/spu2.c:843: warning: expecting prototype for spu_hash_pad_len(). Prototype was for spu2_hash_pad_len() instead drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'cipher_mode' not described in 'spu2_gcm_ccm_pad_len' drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'data_size' not described in 'spu2_gcm_ccm_pad_len' drivers/crypto/bcm/spu2.c:855: warning: expecting prototype for spu2_gcm_ccm_padlen(). Prototype was for spu2_gcm_ccm_pad_len() instead drivers/crypto/bcm/spu2.c:872: warning: expecting prototype for spu_assoc_resp_len(). Prototype was for spu2_assoc_resp_len() instead drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg_digest_size' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'htype' not described in 'spu2_digest_size' drivers/crypto/bcm/spu2.c:945: warning: expecting prototype for spu_create_request(). Prototype was for spu2_create_request() instead drivers/crypto/bcm/spu2.c:1122: warning: expecting prototype for spu_cipher_req_init(). Prototype was for spu2_cipher_req_init() instead drivers/crypto/bcm/spu2.c:1182: warning: Function parameter or member 'is_inbound' not described in 'spu2_cipher_req_finish' drivers/crypto/bcm/spu2.c:1182: warning: expecting prototype for spu_cipher_req_finish(). Prototype was for spu2_cipher_req_finish() instead drivers/crypto/bcm/spu2.c:1243: warning: expecting prototype for spu_request_pad(). Prototype was for spu2_request_pad() instead drivers/crypto/bcm/spu2.c:1321: warning: expecting prototype for spu_status_process(). Prototype was for spu2_status_process() instead drivers/crypto/bcm/cipher.c:1048: warning: Function parameter or member 'req' not described in 'spu_aead_rx_sg_create' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'cipher' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'key' not described in 'rfc4543_gcm_esp_setkey' drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'keylen' not described in 'rfc4543_gcm_esp_setkey' Cc: Herbert Xu Cc: "David S. Miller" Cc: Rob Rice Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/cipher.c | 7 +++--- drivers/crypto/bcm/spu.c | 16 +++++++------- drivers/crypto/bcm/spu2.c | 43 +++++++++++++++++++++---------------- drivers/crypto/bcm/util.c | 4 ++-- 4 files changed, 38 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 851b149f71701..053315e260c22 100644 --- a/drivers/crypto/bcm/cipher.c +++ b/drivers/crypto/bcm/cipher.c @@ -1019,6 +1019,7 @@ static void handle_ahash_resp(struct iproc_reqctx_s *rctx) * a SPU response message for an AEAD request. Includes buffers to catch SPU * message headers and the response data. * @mssg: mailbox message containing the receive sg + * @req: Crypto API request * @rctx: crypto request context * @rx_frag_num: number of scatterlist elements required to hold the * SPU response message @@ -2952,9 +2953,9 @@ static int aead_gcm_esp_setkey(struct crypto_aead *cipher, /** * rfc4543_gcm_esp_setkey() - setkey operation for RFC4543 variant of GCM/GMAC. - * cipher: AEAD structure - * key: Key followed by 4 bytes of salt - * keylen: Length of key plus salt, in bytes + * @cipher: AEAD structure + * @key: Key followed by 4 bytes of salt + * @keylen: Length of key plus salt, in bytes * * Extracts salt from key and stores it to be prepended to IV on each request. * Digest is always 16 bytes diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c index 007abf92cc05b..6283e8c6d51d3 100644 --- a/drivers/crypto/bcm/spu.c +++ b/drivers/crypto/bcm/spu.c @@ -457,7 +457,7 @@ u16 spum_hash_pad_len(enum hash_alg hash_alg, enum hash_mode hash_mode, * @cipher_mode: Algo type * @data_size: Length of plaintext (bytes) * - * @Return: Length of padding, in bytes + * Return: Length of padding, in bytes */ u32 spum_gcm_ccm_pad_len(enum spu_cipher_mode cipher_mode, unsigned int data_size) @@ -510,10 +510,10 @@ u32 spum_assoc_resp_len(enum spu_cipher_mode cipher_mode, } /** - * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included + * spum_aead_ivlen() - Calculate the length of the AEAD IV to be included * in a SPU request after the AAD and before the payload. * @cipher_mode: cipher mode - * @iv_ctr_len: initialization vector length in bytes + * @iv_len: initialization vector length in bytes * * In Linux ~4.2 and later, the assoc_data sg includes the IV. So no need * to include the IV as a separate field in the SPU request msg. @@ -543,9 +543,9 @@ enum hash_type spum_hash_type(u32 src_sent) /** * spum_digest_size() - Determine the size of a hash digest to expect the SPU to * return. - * alg_digest_size: Number of bytes in the final digest for the given algo - * alg: The hash algorithm - * htype: Type of hash operation (init, update, full, etc) + * @alg_digest_size: Number of bytes in the final digest for the given algo + * @alg: The hash algorithm + * @htype: Type of hash operation (init, update, full, etc) * * When doing incremental hashing for an algorithm with a truncated hash * (e.g., SHA224), the SPU returns the full digest so that it can be fed back as @@ -580,7 +580,7 @@ u32 spum_digest_size(u32 alg_digest_size, enum hash_alg alg, * @aead_parms: Parameters related to AEAD operation * @data_size: Length of data to be encrypted or authenticated. If AEAD, does * not include length of AAD. - + * * Return: the length of the SPU header in bytes. 0 if an error occurs. */ u32 spum_create_request(u8 *spu_hdr, @@ -911,7 +911,7 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms) * setkey() time in spu_cipher_req_init(). * @spu_hdr: Start of the request message header (MH field) * @spu_req_hdr_len: Length in bytes of the SPU request header - * @isInbound: 0 encrypt, 1 decrypt + * @is_inbound: 0 encrypt, 1 decrypt * @cipher_parms: Parameters describing cipher operation to be performed * @data_size: Length of the data in the BD field * diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c index 2db35b5ccaa24..07989bb8c220a 100644 --- a/drivers/crypto/bcm/spu2.c +++ b/drivers/crypto/bcm/spu2.c @@ -543,7 +543,8 @@ void spu2_dump_msg_hdr(u8 *buf, unsigned int buf_len) /** * spu2_fmd_init() - At setkey time, initialize the fixed meta data for * subsequent skcipher requests for this context. - * @spu2_cipher_type: Cipher algorithm + * @fmd: Start of FMD field to be written + * @spu2_type: Cipher algorithm * @spu2_mode: Cipher mode * @cipher_key_len: Length of cipher key, in bytes * @cipher_iv_len: Length of cipher initialization vector, in bytes @@ -598,7 +599,7 @@ static int spu2_fmd_init(struct SPU2_FMD *fmd, * SPU request packet. * @fmd: Start of FMD field to be written * @is_inbound: true if decrypting. false if encrypting. - * @authFirst: true if alg authenticates before encrypting + * @auth_first: true if alg authenticates before encrypting * @protocol: protocol selector * @cipher_type: cipher algorithm * @cipher_mode: cipher mode @@ -640,6 +641,7 @@ static void spu2_fmd_ctrl0_write(struct SPU2_FMD *fmd, * spu2_fmd_ctrl1_write() - Write ctrl1 field in fixed metadata (FMD) field of * SPU request packet. * @fmd: Start of FMD field to be written + * @is_inbound: true if decrypting. false if encrypting. * @assoc_size: Length of additional associated data, in bytes * @auth_key_len: Length of authentication key, in bytes * @cipher_key_len: Length of cipher key, in bytes @@ -793,7 +795,7 @@ u32 spu2_ctx_max_payload(enum spu_cipher_alg cipher_alg, } /** - * spu_payload_length() - Given a SPU2 message header, extract the payload + * spu2_payload_length() - Given a SPU2 message header, extract the payload * length. * @spu_hdr: Start of SPU message header (FMD) * @@ -812,10 +814,11 @@ u32 spu2_payload_length(u8 *spu_hdr) } /** - * spu_response_hdr_len() - Determine the expected length of a SPU response + * spu2_response_hdr_len() - Determine the expected length of a SPU response * header. * @auth_key_len: Length of authentication key, in bytes * @enc_key_len: Length of encryption key, in bytes + * @is_hash: Unused * * For SPU2, includes just FMD. OMD is never requested. * @@ -827,7 +830,7 @@ u16 spu2_response_hdr_len(u16 auth_key_len, u16 enc_key_len, bool is_hash) } /** - * spu_hash_pad_len() - Calculate the length of hash padding required to extend + * spu2_hash_pad_len() - Calculate the length of hash padding required to extend * data to a full block size. * @hash_alg: hash algorithm * @hash_mode: hash mode @@ -845,8 +848,10 @@ u16 spu2_hash_pad_len(enum hash_alg hash_alg, enum hash_mode hash_mode, } /** - * spu2_gcm_ccm_padlen() - Determine the length of GCM/CCM padding for either + * spu2_gcm_ccm_pad_len() - Determine the length of GCM/CCM padding for either * the AAD field or the data. + * @cipher_mode: Unused + * @data_size: Unused * * Return: 0. Unlike SPU-M, SPU2 hardware does any GCM/CCM padding required. */ @@ -857,7 +862,7 @@ u32 spu2_gcm_ccm_pad_len(enum spu_cipher_mode cipher_mode, } /** - * spu_assoc_resp_len() - Determine the size of the AAD2 buffer needed to catch + * spu2_assoc_resp_len() - Determine the size of the AAD2 buffer needed to catch * associated data in a SPU2 output packet. * @cipher_mode: cipher mode * @assoc_len: length of additional associated data, in bytes @@ -878,11 +883,11 @@ u32 spu2_assoc_resp_len(enum spu_cipher_mode cipher_mode, return resp_len; } -/* - * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included +/** + * spu2_aead_ivlen() - Calculate the length of the AEAD IV to be included * in a SPU request after the AAD and before the payload. * @cipher_mode: cipher mode - * @iv_ctr_len: initialization vector length in bytes + * @iv_len: initialization vector length in bytes * * For SPU2, AEAD IV is included in OMD and does not need to be repeated * prior to the payload. @@ -909,9 +914,9 @@ enum hash_type spu2_hash_type(u32 src_sent) /** * spu2_digest_size() - Determine the size of a hash digest to expect the SPU to * return. - * alg_digest_size: Number of bytes in the final digest for the given algo - * alg: The hash algorithm - * htype: Type of hash operation (init, update, full, etc) + * @alg_digest_size: Number of bytes in the final digest for the given algo + * @alg: The hash algorithm + * @htype: Type of hash operation (init, update, full, etc) * */ u32 spu2_digest_size(u32 alg_digest_size, enum hash_alg alg, @@ -921,7 +926,7 @@ u32 spu2_digest_size(u32 alg_digest_size, enum hash_alg alg, } /** - * spu_create_request() - Build a SPU2 request message header, includint FMD and + * spu2_create_request() - Build a SPU2 request message header, includint FMD and * OMD. * @spu_hdr: Start of buffer where SPU request header is to be written * @req_opts: SPU request message options @@ -1105,7 +1110,7 @@ u32 spu2_create_request(u8 *spu_hdr, } /** - * spu_cipher_req_init() - Build an skcipher SPU2 request message header, + * spu2_cipher_req_init() - Build an skcipher SPU2 request message header, * including FMD and OMD. * @spu_hdr: Location of start of SPU request (FMD field) * @cipher_parms: Parameters describing cipher request @@ -1162,11 +1167,11 @@ u16 spu2_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms) } /** - * spu_cipher_req_finish() - Finish building a SPU request message header for a + * spu2_cipher_req_finish() - Finish building a SPU request message header for a * block cipher request. * @spu_hdr: Start of the request message header (MH field) * @spu_req_hdr_len: Length in bytes of the SPU request header - * @isInbound: 0 encrypt, 1 decrypt + * @is_inbound: 0 encrypt, 1 decrypt * @cipher_parms: Parameters describing cipher operation to be performed * @data_size: Length of the data in the BD field * @@ -1222,7 +1227,7 @@ void spu2_cipher_req_finish(u8 *spu_hdr, } /** - * spu_request_pad() - Create pad bytes at the end of the data. + * spu2_request_pad() - Create pad bytes at the end of the data. * @pad_start: Start of buffer where pad bytes are to be written * @gcm_padding: Length of GCM padding, in bytes * @hash_pad_len: Number of bytes of padding extend data to full block @@ -1311,7 +1316,7 @@ u8 spu2_rx_status_len(void) } /** - * spu_status_process() - Process the status from a SPU response message. + * spu2_status_process() - Process the status from a SPU response message. * @statp: start of STATUS word * * Return: 0 - if status is good and response should be processed diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c index c4669a96eaecf..d5d9cabea55aa 100644 --- a/drivers/crypto/bcm/util.c +++ b/drivers/crypto/bcm/util.c @@ -119,8 +119,8 @@ int spu_sg_count(struct scatterlist *sg_list, unsigned int skip, int nbytes) * @from_skip: number of bytes to skip in from_sg. Non-zero when previous * request included part of the buffer in entry in from_sg. * Assumes from_skip < from_sg->length. - * @from_nents number of entries in from_sg - * @length number of bytes to copy. may reach this limit before exhausting + * @from_nents: number of entries in from_sg + * @length: number of bytes to copy. may reach this limit before exhausting * from_sg. * * Copies the entries themselves, not the data in the entries. Assumes to_sg has From patchwork Thu Mar 18 12:44:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148129 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB53CC43333 for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90C7864F6E for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbhCRMo6 (ORCPT ); Thu, 18 Mar 2021 08:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbhCRMof (ORCPT ); Thu, 18 Mar 2021 08:44:35 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D106C06175F for ; Thu, 18 Mar 2021 05:44:34 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id j7so5392371wrd.1 for ; Thu, 18 Mar 2021 05:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HZrsJeCHjZzLqDs78jg58TD58YS3CDAKgLNjuHszhbU=; b=GB1tHMwOe8xB2YCpzMzEyAQ/aaFW/MRJKBLj+9Zqr1WZTsDxjjyqXq/HD7Gk7pnbs8 ZZhHAqdQUcQtHN7PLy4pmYIdfC5Skh8ZF8R3GKwuDEXxZlmXsnTrHFpdTmq+k0520N/O Qz2XoGjmE3LLPhujJ1oXCi5u+PpGpEtgnIm0rKrk0oK3TvU9liZFROdY6k/sGNuJlqYh fynD0wYZzkCuN/s+0pN6/c5fCLJ0pAn1+AcIvQc/W2zDeUBntfZRgfitkJnpzPM7LHa8 TIJpMQAmFF9kbeKq1RN9dvAtXGqFOD4EKmd3ZuQlBu0hSzGpFjO8BeqGA7lklCcaa+9f gCfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HZrsJeCHjZzLqDs78jg58TD58YS3CDAKgLNjuHszhbU=; b=B1ezZDigD5sicJapDDlSMXF5x0LaVOLS10CdDh8TvgYA0+zvz9PZ8muL3RuG2dWd1S K8rdmwxj83ylJyoN31iARtpSUzw0lmbtQxc+Iq5DFooO31JVPQLAt3QB6EbBVSPHW2I3 6jMKDma83H+eydS7McDlt9WLyYIR8S8tPiHttSDi3zEFgZ77wvC9uQrIlzU+4t+0mNcz A1zy9KqBiahWzYClm9vx10EYpKmtUHda5snvV0HOXcgzqY7soY5sGFRiflJJDp+wetod 66P/Kgmr0aofwx/Y3swfGkRxied2iinJw12/vr7AU5QmQ5mXWuUfe7iFQh1qiMPK5GPf OKaQ== X-Gm-Message-State: AOAM530xQBCt2TCdhdUMn4v+GHtsAnYxjdR/XaKrICwSnL4FdtKOvk4L m9X+DnmSc9KCjv3mZk1jME5uEw== X-Google-Smtp-Source: ABdhPJytI/0ZX0w0UTk5BnrMKYr8R35Ov9/amsgdtQ26LTMo74EsYmQH31oOTcZvrpPo+m8bTaCanQ== X-Received: by 2002:a05:6000:114e:: with SMTP id d14mr9605253wrx.236.1616071473401; Thu, 18 Mar 2021 05:44:33 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:33 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Herbert Xu , "David S. Miller" , Manoj Malviya , Atul Gupta , Jitendra Lulla , M R Gowda , Harsh Jain , linux-crypto@vger.kernel.org Subject: [PATCH 03/10] crypto: chelsio: chcr_core: Fix some kernel-doc issues Date: Thu, 18 Mar 2021 12:44:15 +0000 Message-Id: <20210318124422.3200180-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on line: drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member 'wrparam' not described in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'req' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'ctx' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'qid' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'op_type' description in 'create_cipher_wr' drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'req' not described in 'create_hash_wr' drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'param' not described in 'create_hash_wr' Cc: Ayush Sawal Cc: Vinay Kumar Yadav Cc: Rohit Maheshwari Cc: Herbert Xu Cc: "David S. Miller" Cc: Manoj Malviya Cc: Atul Gupta Cc: Jitendra Lulla Cc: M R Gowda Cc: Harsh Jain Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/chelsio/chcr_algo.c | 8 +++----- drivers/crypto/chelsio/chcr_core.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c index f5a336634daa6..f77d3fd962bf8 100644 --- a/drivers/crypto/chelsio/chcr_algo.c +++ b/drivers/crypto/chelsio/chcr_algo.c @@ -797,10 +797,7 @@ static inline void create_wreq(struct chcr_context *ctx, /** * create_cipher_wr - form the WR for cipher operations - * @req: cipher req. - * @ctx: crypto driver context of the request. - * @qid: ingress qid where response of this WR should be received. - * @op_type: encryption or decryption + * @wrparam: Container for create_cipher_wr()'s parameters */ static struct sk_buff *create_cipher_wr(struct cipher_wr_param *wrparam) { @@ -1559,7 +1556,8 @@ static inline void chcr_free_shash(struct crypto_shash *base_hash) /** * create_hash_wr - Create hash work request - * @req - Cipher req base + * @req: Cipher req base + * @param: Container for create_hash_wr()'s parameters */ static struct sk_buff *create_hash_wr(struct ahash_request *req, struct hash_wr_param *param) diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c index f91f9d762a45e..f03ef4a23f96d 100644 --- a/drivers/crypto/chelsio/chcr_core.c +++ b/drivers/crypto/chelsio/chcr_core.c @@ -1,4 +1,4 @@ -/** +/* * This file is part of the Chelsio T4/T5/T6 Ethernet driver for Linux. * * Copyright (C) 2011-2016 Chelsio Communications. All rights reserved. From patchwork Thu Mar 18 12:44:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148125 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F06DC43332 for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62D4864F75 for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231375AbhCRMo7 (ORCPT ); Thu, 18 Mar 2021 08:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231322AbhCRMof (ORCPT ); Thu, 18 Mar 2021 08:44:35 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D90C06174A for ; Thu, 18 Mar 2021 05:44:35 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id z2so5377883wrl.5 for ; Thu, 18 Mar 2021 05:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GVJx+OIpfKowVFAHFOdCV34ApK3YA2W1l4+0ZHpyDsw=; b=oGDY3f1hsLm/RRceUXYCZGe+2E0KHDebnMjvny/6+Yagr9ieN2j8lO5C8vjZzHMz7X 7nAV7LLYH10IRNIgLxGfNmp1Kum+lgpQl0PqzF9yp4/xMpugGIWehf7PI4LYJVhoBqDQ g41+/wiUN0dAaum5iOgMg9aC1UkR22yz/jdB+/Wiqg3Gt9JHNlis7eWQ6n8MqBb35Qa4 tFxVgMEfeqNv0DFLQPKpzeDRmvCYxGhihqRESBl4DVX2Q4qx/cxD1bBLHXEiM4LXg3lk NFG/aeBC3XVox9ORyb5x08AYb95qHo/w86EUWgrj/7DIaMzVy4aUBZoM6OAy72ml1KTh DLtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GVJx+OIpfKowVFAHFOdCV34ApK3YA2W1l4+0ZHpyDsw=; b=N3ZMlew72mx+FV1p+R/2xvJmJt/wyGHVTpjaNF43P4dMBLAvoTEqikcLJGnvqa5mP8 pjQ5MhEekJ3TM/li4vmUiPXP6oKIP3+cP4vceizUvV9Wpngzt8SlM7vx+O9a2z9GLbC3 /imFqbGEoLjWAug6Njur3nNs230B5rlwWIZhlwQZ4u7D7DkC9Bt9OKYKqPUmTEocCYz3 YskQlPhK3gc36xImO336iLdNi0/T6Ibt5pjLy5mckAg7I+wYaoAVHEsV94FVRyX3+PPw mW3wnncLKkiR1RmZbNd3O4rH9FC4IuFi+UCs3AQowLUtwYdMlCYyy1q6I9QrXuinUbMN XZxw== X-Gm-Message-State: AOAM531twgCh/orXuFQvTZe6qhDQTAs7+G2I/dysrMcswbDNj8zAvudH ZR7Sa7AoPyNB+ok9gVuG2otYDA== X-Google-Smtp-Source: ABdhPJz+3dqBeG+BvnsNt/dKos5qgphcI0MBVWV7mfP9zSF43K5SROETB9Vehj9QEcVv/n7nGdT7JA== X-Received: by 2002:adf:e60e:: with SMTP id p14mr9567459wrm.221.1616071474295; Thu, 18 Mar 2021 05:44:34 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:33 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , Shujuan Chen , Joakim Bech , Berne Hebark , Niklas Hernaeus , Jonas Linde , Andreas Westin , linux-crypto@vger.kernel.org Subject: [PATCH 04/10] crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others Date: Thu, 18 Mar 2021 12:44:16 +0000 Message-Id: <20210318124422.3200180-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The ones remove here not only fail to conform to kernel-doc, but also provide no value, so let's remove them completely in this case. Fixes the following W=1 kernel build warning(s): drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or member 'ctx' not described in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:368: warning: Excess function parameter 'hash_ctx' description in 'hash_get_device_data' drivers/crypto/ux500/hash/hash_core.c:551: warning: expecting prototype for hash_init(). Prototype was for ux500_hash_init() instead drivers/crypto/ux500/hash/hash_core.c:592: warning: Function parameter or member 'length' not described in 'hash_processblock' drivers/crypto/ux500/hash/hash_core.c:1302: warning: expecting prototype for hash_update(). Prototype was for ahash_update() instead drivers/crypto/ux500/hash/hash_core.c:1322: warning: expecting prototype for hash_final(). Prototype was for ahash_final() instead drivers/crypto/ux500/hash/hash_core.c:1622: warning: Function parameter or member 'device_data' not described in 'ahash_algs_register_all' drivers/crypto/ux500/hash/hash_core.c:1622: warning: expecting prototype for hash_algs_register_all(). Prototype was for ahash_algs_register_all() instead drivers/crypto/ux500/hash/hash_core.c:1647: warning: Function parameter or member 'device_data' not described in 'ahash_algs_unregister_all' drivers/crypto/ux500/hash/hash_core.c:1647: warning: expecting prototype for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead drivers/crypto/ux500/cryp/cryp.c:19: warning: Incorrect use of kernel-doc format: * cryp_wait_until_done - wait until the device logic is not busy drivers/crypto/ux500/cryp/cryp.c:22: warning: Function parameter or member 'device_data' not described in 'cryp_wait_until_done' drivers/crypto/ux500/cryp/cryp.c:22: warning: expecting prototype for ST(). Prototype was for cryp_wait_until_done() instead drivers/crypto/ux500/cryp/cryp.c:292: warning: Function parameter or member 'cryp_mode' not described in 'cryp_save_device_context' drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'device_data' not described in 'cryp_enable_irq_src' drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'irq_src' not described in 'cryp_enable_irq_src' drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: expecting prototype for ST(). Prototype was for cryp_enable_irq_src() instead drivers/crypto/ux500/cryp/cryp_core.c:42: warning: expecting prototype for ST(). Prototype was for CRYP_MAX_KEY_SIZE() instead drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'key' not described in 'cryp_ctx' drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'session_id' not described in 'cryp_ctx' Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: Jonas Linde Cc: Andreas Westin Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp.c | 5 +++-- drivers/crypto/ux500/cryp/cryp_core.c | 5 +++-- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- drivers/crypto/ux500/hash/hash_core.c | 15 +++++---------- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/crypto/ux500/cryp/cryp.c b/drivers/crypto/ux500/cryp/cryp.c index 9866c2a5e9a70..759d0d9786fd1 100644 --- a/drivers/crypto/ux500/cryp/cryp.c +++ b/drivers/crypto/ux500/cryp/cryp.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Jonas Linde for ST-Ericsson. @@ -15,7 +15,7 @@ #include "cryp_p.h" #include "cryp.h" -/** +/* * cryp_wait_until_done - wait until the device logic is not busy */ void cryp_wait_until_done(struct cryp_device_data *device_data) @@ -285,6 +285,7 @@ int cryp_configure_init_vector(struct cryp_device_data *device_data, * other device context parameter * @device_data: Pointer to the device data struct for base address. * @ctx: Crypto device context + * @cryp_mode: Mode: Polling, Interrupt or DMA */ void cryp_save_device_context(struct cryp_device_data *device_data, struct cryp_device_context *ctx, diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c index c3adeb2e58232..25ce56d05084e 100644 --- a/drivers/crypto/ux500/cryp/cryp_core.c +++ b/drivers/crypto/ux500/cryp/cryp_core.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Joakim Bech for ST-Ericsson. @@ -62,7 +62,7 @@ struct cryp_driver_data { /** * struct cryp_ctx - Crypto context * @config: Crypto mode. - * @key[CRYP_MAX_KEY_SIZE]: Key. + * @key: Key array. * @keylen: Length of key. * @iv: Pointer to initialization vector. * @indata: Pointer to indata. @@ -73,6 +73,7 @@ struct cryp_driver_data { * @updated: Updated flag. * @dev_ctx: Device dependent context. * @device: Pointer to the device. + * @session_id: Atomic session ID. */ struct cryp_ctx { struct cryp_config config; diff --git a/drivers/crypto/ux500/cryp/cryp_irq.c b/drivers/crypto/ux500/cryp/cryp_irq.c index 7ebde69e8c76b..6d2f07bec98a7 100644 --- a/drivers/crypto/ux500/cryp/cryp_irq.c +++ b/drivers/crypto/ux500/cryp/cryp_irq.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Copyright (C) ST-Ericsson SA 2010 * Author: Shujuan Chen for ST-Ericsson. * Author: Jonas Linde for ST-Ericsson. diff --git a/drivers/crypto/ux500/hash/hash_core.c b/drivers/crypto/ux500/hash/hash_core.c index da284b0ea1b26..bcaf6ba3e9235 100644 --- a/drivers/crypto/ux500/hash/hash_core.c +++ b/drivers/crypto/ux500/hash/hash_core.c @@ -356,7 +356,7 @@ static int hash_enable_power(struct hash_device_data *device_data, /** * hash_get_device_data - Checks for an available hash device and return it. - * @hash_ctx: Structure for the hash context. + * @ctx: Structure for the hash context. * @device_data: Structure for the hash device. * * This function check for an available hash device and return it to @@ -542,7 +542,7 @@ static bool hash_dma_valid_data(struct scatterlist *sg, int datasize) } /** - * hash_init - Common hash init function for SHA1/SHA2 (SHA256). + * ux500_hash_init - Common hash init function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. * * Initialize structures. @@ -585,6 +585,7 @@ static int ux500_hash_init(struct ahash_request *req) * @device_data: Structure for the hash device. * @message: Block (512 bits) of message to be written to * the HASH hardware. + * @length: Message length * */ static void hash_processblock(struct hash_device_data *device_data, @@ -1295,7 +1296,7 @@ void hash_get_digest(struct hash_device_data *device_data, } /** - * hash_update - The hash update function for SHA1/SHA2 (SHA256). + * ahash_update - The hash update function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_update(struct ahash_request *req) @@ -1315,7 +1316,7 @@ static int ahash_update(struct ahash_request *req) } /** - * hash_final - The hash final function for SHA1/SHA2 (SHA256). + * ahash_final - The hash final function for SHA1/SHA2 (SHA256). * @req: The hash request for the job. */ static int ahash_final(struct ahash_request *req) @@ -1615,9 +1616,6 @@ static struct hash_algo_template hash_algs[] = { } }; -/** - * hash_algs_register_all - - */ static int ahash_algs_register_all(struct hash_device_data *device_data) { int ret; @@ -1640,9 +1638,6 @@ static int ahash_algs_register_all(struct hash_device_data *device_data) return ret; } -/** - * hash_algs_unregister_all - - */ static void ahash_algs_unregister_all(struct hash_device_data *device_data) { int i; From patchwork Thu Mar 18 12:44:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148131 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF97C4321A for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA8EA64F72 for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231382AbhCRMpA (ORCPT ); Thu, 18 Mar 2021 08:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231326AbhCRMoh (ORCPT ); Thu, 18 Mar 2021 08:44:37 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC505C06174A for ; Thu, 18 Mar 2021 05:44:36 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id a132-20020a1c668a0000b029010f141fe7c2so3116940wmc.0 for ; Thu, 18 Mar 2021 05:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rd9z4w9LE1HolCnpzEf+gv0c+Los0igJWAfUgufQ4UM=; b=smUYcY3bH6WJZsnhdH1GiU+qMOjP0jFa4N5IWcbWJ8GIsDAqrL5z2tg1883ti4JXHb rSsi2zIvxaHh/Ax5K9gr7b8H/5t3UtAX78WeciTMwnIMPtmBYsM0BCvcgJ/cp7cD5MN2 rSeUKblpDgAomDYbwLu6ASR9A1Ct+39A6HxCAmBSNwE1zJksMc2OEh/RabX/rSCHIfaE RQg+vge8s2xtwDK/WVbePmUkim+Eb5D00J47djQOLpR4bqwCl3s6Aq8pU5JwhTZwMYn3 nyih1ocJSztiO0tyA19Nsx5+B7ngCml3YBhtlvP6H9CQritTWMD7x01d7ZbM0ZkTuK3g BJMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rd9z4w9LE1HolCnpzEf+gv0c+Los0igJWAfUgufQ4UM=; b=Lu7rbQc594wRFA8T2HKQjrzNiAyZBjVLFwqpmMwoZ1fON7ws9ovn4mWqDAXQTeSlnh KeTfWLiBb35V//Pne2znUVn3Ird0/XbJG23o3nF9CltKkD7GeCtO19fnR0qSkX52uc0C cN8NXVxjlSZQvVZTdE2WzeYhNXEUOaUEcbrkBLZzz0VkhZkSwiZEBGmNv3xFVof2iUV4 sLouGEVFyytR+NiY0kqBuVY5ZmzmlqaWzEI9AbH55O0FxVPVUpxlK053GpI9OaKXpDUC MabvPV56JdTaFPlYv4BHcNsRe3NoJOqExsu710vUHCgom54cpyr7waIVZyU9dsL2kDc4 5gsQ== X-Gm-Message-State: AOAM531bHvkVDQkpgNAApsjGyTFnazWdWIXc1h+BGRjsqVuG6oxibXTM WyWDPNn6Ye4Ab/Isa/jaS4gtPg== X-Google-Smtp-Source: ABdhPJygbhjJs4HBWO1eviqQN63QCzvlzS87m5Lpk7e6AsEBKZ2xZx+9+p4VQO9m9wx6pJdMAcPGHg== X-Received: by 2002:a05:600c:210a:: with SMTP id u10mr3560775wml.147.1616071475551; Thu, 18 Mar 2021 05:44:35 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:35 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Daniele Alessandrelli , Declan Murphy , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs Date: Thu, 18 Mar 2021 12:44:17 +0000 Message-Id: <20210318124422.3200180-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead Cc: Daniele Alessandrelli Cc: Declan Murphy Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Daniele Alessandrelli --- drivers/crypto/keembay/ocs-hcu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c index 81eecacf603ad..deb9bd460ee62 100644 --- a/drivers/crypto/keembay/ocs-hcu.c +++ b/drivers/crypto/keembay/ocs-hcu.c @@ -93,7 +93,7 @@ #define OCS_HCU_WAIT_BUSY_TIMEOUT_US 1000000 /** - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list. + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list. * @src_addr: Source address of the data. * @src_len: Length of data to be fetched. * @nxt_desc: Next descriptor to fetch. @@ -107,7 +107,7 @@ struct ocs_hcu_dma_entry { }; /** - * struct ocs_dma_list - OCS-specific DMA linked list. + * struct ocs_hcu_dma_list - OCS-specific DMA linked list. * @head: The head of the list (points to the array backing the list). * @tail: The current tail of the list; NULL if the list is empty. * @dma_addr: The DMA address of @head (i.e., the DMA address of the backing @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo) } /** - * ocs_hcu_digest() - Perform a hashing iteration. + * ocs_hcu_hash_update() - Perform a hashing iteration. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev, } /** - * ocs_hcu_hash_final() - Update and finalize hash computation. + * ocs_hcu_hash_finup() - Update and finalize hash computation. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. From patchwork Thu Mar 18 12:44:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148117 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539A9C432C3 for ; Thu, 18 Mar 2021 12:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6B4764F6F for ; Thu, 18 Mar 2021 12:45:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbhCRMpB (ORCPT ); Thu, 18 Mar 2021 08:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231328AbhCRMoh (ORCPT ); Thu, 18 Mar 2021 08:44:37 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9514DC06175F for ; Thu, 18 Mar 2021 05:44:37 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id g20so3459404wmk.3 for ; Thu, 18 Mar 2021 05:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=V3/tc0Yb6jrNSgFN3wzJjGp740jB6twjzIpO+YKSzDo=; b=aUM2L0+pi/1cI3jATJQAlraEb4KXpWG+rU4TizHnfrUYZmIvpEP1xfkQTgcwNHdZyh UflbNqAPANaQe+LcS+pKV+QUJBY1LIkBcDTVlvZD3LgH1jBv8XjM5189zmcTYS+2r1yZ lQ7IukKrv8o6znuYrXHAI/u3dD2ie7xA10DBvncwPPfxftToByDADIn4HP55yajJ5yWJ EWK21J1WinSmihtJY0Nmv8oMSe7aL+REVU0Qob68rN8H7dD3OKJ9amNVmumeEja9ykQ1 lljl/7MDjS1zdbF0VTxlOF6dSdcOrMLHnKHDPegRPxfqKCxZsOFJ1noMeQsZMgSbftNL ZEQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V3/tc0Yb6jrNSgFN3wzJjGp740jB6twjzIpO+YKSzDo=; b=To4S4Koz2P4BGfMSNC52G1ZGmpQ2GXMpVsI88p2yGqK5CtmXKHrTElqHYwErgz8gvv mOgDrtlGajiRIQOqJXzgsSdqcnW7KLvHeY8wdZYI2r5ORrIJvOKSmLe4ZbJkaTFeISbm q9CPzmSodRCiXk19949xNpzVjbXredpFR+cOgDg5+UMPLBgmon0IlgA7bJaSdSzCJUSI HON5d6zGK/xG4VTZnt5Fnb0Y20iOi/6qgFh6CL2Nj0IF/kaA88xFlR9qumoiCtDlg3zd fHF+ErK2PZSWgYGJMNyq4/LzDVsQ7hwapQar5I0UUBDGplfXWJGIcSmE37Pjr0r9G29A 4n6Q== X-Gm-Message-State: AOAM532AmlXvMDS36Ol10tTbfpBcZwL9lssAe/AisYx+RJwJ02HbA6X7 f2CVYZJSa01889qJu3Kljxd58A== X-Google-Smtp-Source: ABdhPJyKR338FNSwiovSQH97gzw+u/TywpTayrlftICyjXcQzKH05FqBFmP+pXqU11eWzlEYaNL3+g== X-Received: by 2002:a1c:7210:: with SMTP id n16mr3403759wmc.13.1616071476358; Thu, 18 Mar 2021 05:44:36 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Tudor Ambarus , Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/10] crypto: atmel-ecc: Struct headers need to start with keyword 'struct' Date: Thu, 18 Mar 2021 12:44:18 +0000 Message-Id: <20210318124422.3200180-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/atmel-ecc.c:41: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx ' Cc: Tudor Ambarus Cc: Herbert Xu Cc: "David S. Miller" Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-crypto@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Tudor Ambarus --- drivers/crypto/atmel-ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 515946c99394e..333fbefbbccbd 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -26,7 +26,7 @@ static struct atmel_ecc_driver_data driver_data; /** - * atmel_ecdh_ctx - transformation context + * struct atmel_ecdh_ctx - transformation context * @client : pointer to i2c client device * @fallback : used for unsupported curves or when user wants to use its own * private key. From patchwork Thu Mar 18 12:44:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148123 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D55C43619 for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 075CE64F69 for ; Thu, 18 Mar 2021 12:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbhCRMpB (ORCPT ); Thu, 18 Mar 2021 08:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbhCRMoi (ORCPT ); Thu, 18 Mar 2021 08:44:38 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1FDC06174A for ; Thu, 18 Mar 2021 05:44:38 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id g20so3459435wmk.3 for ; Thu, 18 Mar 2021 05:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fMTahAsaElMxqi8eZGk2JR1LgFKDb6Ye/mNpDFgFc8o=; b=dvpUi70deEjAO/2KnUGPQa0XxK3Y2FGyWvK8WilSPi5yM7x/GlW/mmywfd0OuvFXsO w6lhV+d8yzST2Zg9qCt55bDyrDOBVmv6AHYEOr8K5hdCWTHz8iJG7+mxg/p5ffvqiVfP x6Pm3TTB+MVoJLj/cI6sNyfjnzaBEWo3tSmdpO7rTketyLx1nolyDmibGPoJTmGHI6kG 7gvqDNcNKuCMvX9QvMZp972j+gpvWSjK8TEy5GaCdJk1S8Xi9rjFo1EqB8vQy10zPGtS UfgSE/gkIOUPiYE1Hi+pbdsENjj5b8vMpXZTGfTIw78mDjnOsXKTVMVp0eB7UbzJxJLM ABeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fMTahAsaElMxqi8eZGk2JR1LgFKDb6Ye/mNpDFgFc8o=; b=rS3vAyP3Cg6FB2OpAC3fjgY6qwyHpAM5yxIAF+9rb7xbhNaVh7ncziB2wYrQa0bcSG sN/c97rHsjuhkvae0DXV5r2PgBMFQSx484wc1liXbmAHWstF1/CceGzUAU/Kr/nq8+GC rE/UqEciuVysQPrn3K9I6JYXDeM1L5j6v9Yn891NXlYc3VJcJCB3mqLeXKv2zW8At9eQ VwB/GbeewpBWDuuW/FFzktKlw4du6ZRPkFApTTH7AgHrvViAytHV1n3rsMJiqqT9fl9+ BjCU/VZpaoHNZfN8PXm8P4fNz7OK3weHHiooPOILWxSyFMCShyknEwugyl8xjG0MU3WE dLMQ== X-Gm-Message-State: AOAM533xiQcKI3fUyglQoOUUpRgA8LcQ3oHR4pzVmZG6+ZgrlxV1oNrU +qvNIvkFn/U3+OONxcOPz58n/w== X-Google-Smtp-Source: ABdhPJzQx6Slpl2jsjhrwVq5uOSUJdpe2/Tb4K7eDbq/y5pEeET6/wucfCz6Y0rTCocip+3mo9Z6mg== X-Received: by 2002:a1c:bc56:: with SMTP id m83mr3548402wmf.174.1616071477165; Thu, 18 Mar 2021 05:44:37 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:36 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Horia_Geant=C4=83?= , Aymen Sghaier , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 07/10] crypto: caam: caampkc: Provide the name of the function and provide missing descriptions Date: Thu, 18 Mar 2021 12:44:19 +0000 Message-Id: <20210318124422.3200180-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx' drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx' Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones Reviewed-by: Horia Geantă --- drivers/crypto/caam/caamalg_qi2.c | 3 +++ drivers/crypto/caam/caampkc.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c index a780e627838ae..8b8ed77d8715d 100644 --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c @@ -71,6 +71,9 @@ struct caam_skcipher_alg { * @adata: authentication algorithm details * @cdata: encryption algorithm details * @authsize: authentication tag (a.k.a. ICV / MAC) size + * @xts_key_fallback: true if fallback tfm needs to be used due + * to unsupported xts key lengths + * @fallback: xts fallback tfm */ struct caam_ctx { struct caam_flc flc[NUM_OP]; diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index dd5f101e43f83..e313233ec6de7 100644 --- a/drivers/crypto/caam/caampkc.c +++ b/drivers/crypto/caam/caampkc.c @@ -187,7 +187,8 @@ static void rsa_priv_f_done(struct device *dev, u32 *desc, u32 err, } /** - * Count leading zeros, need it to strip, from a given scatterlist + * caam_rsa_count_leading_zeros - Count leading zeros, need it to strip, + * from a given scatterlist * * @sgl : scatterlist to count zeros from * @nbytes: number of zeros, in bytes, to strip From patchwork Thu Mar 18 12:44:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148121 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20347C4360C for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE34E64F79 for ; Thu, 18 Mar 2021 12:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbhCRMpC (ORCPT ); Thu, 18 Mar 2021 08:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231332AbhCRMoj (ORCPT ); Thu, 18 Mar 2021 08:44:39 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53D92C06175F for ; Thu, 18 Mar 2021 05:44:39 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id x13so5389148wrs.9 for ; Thu, 18 Mar 2021 05:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4foJK0tE+WL3lsMryI6KM5lFp3YWmzugBxJCQxMDWAg=; b=KjxlBIL/5+bh5fCH7X6TiEm7gUUM3pQbhOECaOyCDUnlciMaN1ctbqgcMIBXwrnAix dEnoldKG99BkcDQji16mtek9bLZ2WbPFggh6TrJBcd993prFyPlOYME5ezAzuyLIZpZb Hfuost30WbKwgh03ZN1jcoo6VrNFfwSOhB14knCXVBoc6oW4lb9E0gtPquJSEHOv8EdB 8qC9cfLnT6Y6MakvSODWSZjn6RN0HA1ZfTeVvb2WvpqSqqOqnxK6Skkm/AQVvbPJXSnU haEHCQIN2IRct3EXsXdJMjsZf16uARxNIPS2KvH3wlHfaxb017igCrGak719QHLDy36i Dvbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4foJK0tE+WL3lsMryI6KM5lFp3YWmzugBxJCQxMDWAg=; b=ALAAfm2TzvF8IF7cReig0bp82YSP5lry9pTeIGigy3c4+aFyafEWVLBo+byVja+7Ky DXSXV6XoZyocGyp4YatTGjNd+mzoqaHX9M0hwZu1G3fkyXbE1NSCnTG1oMeouXfZ37sZ sRNOBiQ5I353waoQ4MZ4w9AoBl1kvhN4jpRrtxUQk9mNENsm3cOcp7P8BpOwWdid+q9I aeczzm71GO8IS7ST/XOaWnosQE+lbNciNb0x7FKAyZpT+VgSJAtsJvc2qGcDB8764nuB 4YhuGATck4LLTxp6aKnFTd09N2HkXifcqNLjDs4e+Uc8XtuN0GFQwNBz1rGeODoawAJE CDSg== X-Gm-Message-State: AOAM533pdcWS7e2tRRd16BebRXmVj3g41vEjC8q79CRyZMnHygdIfkk2 LAe1jq+o8RlsyaH9DDt2ny8L8g== X-Google-Smtp-Source: ABdhPJzMvwSvkYM8ayiGVbfuAWWsOBZ/YUhWo0aTK8kgiiyjoTePFruMU6I3YjYgOX4ZpbmmIBxTbg== X-Received: by 2002:a5d:4fca:: with SMTP id h10mr10054325wrw.70.1616071478056; Thu, 18 Mar 2021 05:44:38 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:37 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Henrique Cerri , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 08/10] crypto: vmx: Source headers are not good kernel-doc candidates Date: Thu, 18 Mar 2021 12:44:20 +0000 Message-Id: <20210318124422.3200180-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/vmx.c b/drivers/crypto/vmx/vmx.c index a40d08e75fc0b..7eb713cc87c8c 100644 --- a/drivers/crypto/vmx/vmx.c +++ b/drivers/crypto/vmx/vmx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting VMX instructions on the Power 8 * * Copyright (C) 2015 International Business Machines Inc. From patchwork Thu Mar 18 12:44:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148119 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D5B9C43603 for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF82D64F6A for ; Thu, 18 Mar 2021 12:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbhCRMpD (ORCPT ); Thu, 18 Mar 2021 08:45:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbhCRMok (ORCPT ); Thu, 18 Mar 2021 08:44:40 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CA9AC06175F for ; Thu, 18 Mar 2021 05:44:40 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id o16so5400991wrn.0 for ; Thu, 18 Mar 2021 05:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zaL0nEsFAcBhqqjVU0O9HWEXuIfJLm4ctcMaPZZ2Fv8=; b=u1uybo/3FAiXPDTpmZbhBVHRlCyMsvBiUVr1KAvKPW/DdL0v2F3sz3aE7rCh9B0/Le RhXj8JlOQu6ABxbUgMbvk1ThGTUYdZxSOzQDxKtLxJGHVSSR7Y3FbnziMeJD2pscp5YE PXNc30MtxRnWOQORn2ijZxgqSSepMjnOJ4It8tGdYoTBFlKAZO/815gsueRm0M4uZHU/ jcUnbDyyyrmBvnVBvdi4/PioB1vuvbHs14VrSoBzUDMfKDZOukoeTgMU/lCJRceY/sud NofUP7YfGoSyhb/jtbSfFNqRkJ7HbdkH90gZO0pXAu2VgHuJItjKA/NXnzRAibHwKcz7 XFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zaL0nEsFAcBhqqjVU0O9HWEXuIfJLm4ctcMaPZZ2Fv8=; b=qCSDY1a1Q8CxNq0qDjZfDi27tHO3G/XodqQthwm6yITamTYWC7bdthU4fTuLJWUOO6 4ximYGviKHcsG1bmcyBwQdEMtJFpdLnJuMO2XVUZaZKU4LvirdvgXydHNPQXqi5nIa1d UqVHNfWHhTOisWGcRrMU/EdeI885IU4HGXTfon9CuARzOUVo4qDMFoF+ZQ9wN8bLWh7M 2kkxiq+/9S4nkDTlxmZ8Vs7Cp5KBBZND0+pazFH+KPSid/0ZNyhG1lkmWUwefjjYG+5c l3FbeYRypjmzGIgIGX/DmZ+Z7FbUEvkTuL4GmEq+F04KhJD/wjum1me9MHkup9Lin40J Bn6g== X-Gm-Message-State: AOAM531lYLymr6M6nHTV8OBh+rJ55l1H0BAAzw1w6XJvImLh7uZS+oHU XwNq9He+QmSuvPvJyX9+i6/APQ== X-Google-Smtp-Source: ABdhPJyjLfIa9YueaDjBRXGN+wEAk47szCZUoN6lqkyrN05yel9okdpLdt34EXFVhs28uVSpXSBIxQ== X-Received: by 2002:adf:c587:: with SMTP id m7mr9362514wrg.369.1616071479028; Thu, 18 Mar 2021 05:44:39 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:38 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Breno_Leit=C3=A3o?= , Nayna Jain , Paulo Flabiano Smorigo , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Herbert Xu , "David S. Miller" , Kent Yoder , linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 09/10] crypto: nx: nx-aes-cbc: Repair some kernel-doc problems Date: Thu, 18 Mar 2021 12:44:21 +0000 Message-Id: <20210318124422.3200180-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init' drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format: * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list' Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-crypto@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- drivers/crypto/nx/nx.c | 5 +++-- drivers/crypto/nx/nx_debugfs.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-cbc.c b/drivers/crypto/nx/nx-aes-cbc.c index 92e921eceed75..d6314ea9ae896 100644 --- a/drivers/crypto/nx/nx-aes-cbc.c +++ b/drivers/crypto/nx/nx-aes-cbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * AES CBC routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 1d0e8a1ba1605..010e87d9da36b 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. @@ -200,7 +200,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *nx_dst, * @sg: sg list head * @end: sg lisg end * @delta: is the amount we need to crop in order to bound the list. - * + * @nbytes: length of data in the scatterlists or data length - whichever + * is greater. */ static long int trim_sg_list(struct nx_sg *sg, struct nx_sg *end, diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c index 1975bcbee9974..ee7cd88bb10a7 100644 --- a/drivers/crypto/nx/nx_debugfs.c +++ b/drivers/crypto/nx/nx_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * debugfs routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. From patchwork Thu Mar 18 12:44:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12148127 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB18C4361B for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5120564F9A for ; Thu, 18 Mar 2021 12:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbhCRMpD (ORCPT ); Thu, 18 Mar 2021 08:45:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231344AbhCRMom (ORCPT ); Thu, 18 Mar 2021 08:44:42 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8F82C06174A for ; Thu, 18 Mar 2021 05:44:41 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id p19so3471855wmq.1 for ; Thu, 18 Mar 2021 05:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TY1HutZnteRyydV5Ih0Egjx6tbg8POtzIYYu0tZ9gLI=; b=YpCedp9IdwWeyxohsMCGQpMQoLV/hkD4ApREPjeUj04im6YuhY7tA13/cQE/+ppygN gD4CV7xwu/vJdv5lQCoaNMHriSIdIv5N5QBPK4Wmn0C4U2djRnpU7/C+E5upxSCkWGzE tOHe9MF2in8lHi0Op/RB+Od7D9SCVOqREpzBkQArb4HKpO6hAcjGDN64seMVmvqwHPEP r9nseEw/mDgKSTAg8kqsHIeCaOWrJc1XDZrInFEKRSwtrMPhD7pJ9wZh3wzYT+Lm4bQO CoTKTy2nH43TNBDPGKNNWkgx4Qf9u4MvFGSgQqtWJC8oTc7Xsla9O4alkLDH06QTK7hS e9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TY1HutZnteRyydV5Ih0Egjx6tbg8POtzIYYu0tZ9gLI=; b=lk9MMFMiwQ8ZSafSYBAed0EJJgI1bpa9TYvEnIT4vdS5MkRwvhbxiomgczcXmrtvze cYPHsFzzNsFINB9LYBOF7QQEyuTYoTfFWJLwtJXGXF4/OyrnejjCfdBQwdDRF7zESchV 3aM3bkzHaVcMyHOFHyLoASI7bPETk4OwpMgka54Q/5rUT5d1cHLMDpsHQojEtCojV9xd JpeNwISySwZemWDjOsqo+NO4EaHs6uNv2mNIEt1MU/GUDkCso1mmDRtsXqmhpBLxNz6x qcCUUlOOTjOdpF3+poSwYFSaEu8R/Kquq9ZT4ywYFa7iJsKtJT6w69+mcWAj5XJpAmzl VlcQ== X-Gm-Message-State: AOAM532PDfVcr9WSF305oSejT/tPrCyPdyjwEiD7ngIb1KTXwRLSlpOg Wj+AEog4e/bPO+A52LLtVI1lXA== X-Google-Smtp-Source: ABdhPJwayS+6aJydxHj5yStfZeVa3lyWXiOrvhsKnl33t0rWgECJEOb5yGGRqE5y2RprFfC7xgfXqg== X-Received: by 2002:a05:600c:3514:: with SMTP id h20mr3567716wmq.45.1616071480151; Thu, 18 Mar 2021 05:44:40 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id q15sm2813900wrx.56.2021.03.18.05.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 05:44:39 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 10/10] crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers Date: Thu, 18 Mar 2021 12:44:22 +0000 Message-Id: <20210318124422.3200180-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318124422.3200180-1-lee.jones@linaro.org> References: <20210318124422.3200180-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/cavium/nitrox/nitrox_isr.c:17: warning: expecting prototype for One vector for each type of ring(). Prototype was for NR_RING_VECTORS() instead drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'irq' not described in 'nps_core_int_isr' drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'data' not described in 'nps_core_int_isr' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cavium/nitrox/nitrox_isr.c b/drivers/crypto/cavium/nitrox/nitrox_isr.c index 99b053094f5af..c288c4b51783d 100644 --- a/drivers/crypto/cavium/nitrox/nitrox_isr.c +++ b/drivers/crypto/cavium/nitrox/nitrox_isr.c @@ -10,7 +10,7 @@ #include "nitrox_isr.h" #include "nitrox_mbx.h" -/** +/* * One vector for each type of ring * - NPS packet ring, AQMQ ring and ZQMQ ring */ @@ -216,7 +216,7 @@ static void nps_core_int_tasklet(unsigned long data) } } -/** +/* * nps_core_int_isr - interrupt handler for NITROX errors and * mailbox communication */