From patchwork Sun Mar 21 21:25:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 12153341 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C240C433C1 for ; Sun, 21 Mar 2021 21:25:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1B986024A for ; Sun, 21 Mar 2021 21:25:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1B986024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EDCFE6B0070; Sun, 21 Mar 2021 17:25:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D486B0071; Sun, 21 Mar 2021 17:25:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D55C56B0072; Sun, 21 Mar 2021 17:25:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id BA1B86B0070 for ; Sun, 21 Mar 2021 17:25:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 732291802201F for ; Sun, 21 Mar 2021 21:25:16 +0000 (UTC) X-FDA: 77945162232.03.70007C1 Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by imf15.hostedemail.com (Postfix) with ESMTP id C13F3A0009DE for ; Sun, 21 Mar 2021 21:25:15 +0000 (UTC) Received: by sf.home (Postfix, from userid 1000) id 43C355A22061; Sun, 21 Mar 2021 21:25:07 +0000 (GMT) From: Sergei Trofimovich To: Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Sergei Trofimovich Subject: [PATCH] mm: add page_owner_stack=off to make stack collection optional Date: Sun, 21 Mar 2021 21:25:01 +0000 Message-Id: <20210321212501.2504947-1-slyfox@gentoo.org> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 X-Stat-Signature: 63mxg76kxuh65pngzbbic7mgetb9a7ah X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C13F3A0009DE Received-SPF: none (gentoo.org>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=smtp.gentoo.org; client-ip=140.211.166.183 X-HE-DKIM-Result: none/none X-HE-Tag: 1616361915-768273 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On some architectures (like ia64) stack walking is slow and currently requires memory allocation. This causes stack collection for page_owner=on to fall into recursion. This patch implements a page_owner_stack=off to allow page stats collection. Signed-off-by: Sergei Trofimovich --- .../admin-guide/kernel-parameters.txt | 6 +++++ mm/Kconfig.debug | 3 ++- mm/page_owner.c | 23 +++++++++++++------ 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index 04545725f187..3e710c4ab4df 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -3518,6 +3518,12 @@ we can turn it on. on: enable the feature + page_owner_stack= [KNL] Boot-time parameter option disabling stack + collection of page allocation. Has effect only if + "page_owner=on" is set. Useful for cases when stack + collection is too slow or not feasible. + off: disable the feature + page_poison= [KNL] Boot-time parameter changing the state of poisoning on the buddy allocator, available with CONFIG_PAGE_POISONING=y. diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index 1e73717802f8..c1ecaf066c93 100644 --- a/mm/Kconfig.debug +++ b/mm/Kconfig.debug @@ -57,7 +57,8 @@ config PAGE_OWNER help to find bare alloc_page(s) leaks. Even if you include this feature on your build, it is disabled in default. You should pass "page_owner=on" to boot parameter in order to enable it. Eats - a fair amount of memory if enabled. See tools/vm/page_owner_sort.c + a fair amount of memory if enabled. Call chain tracking can be + disabled with "page_owner_stack=off". See tools/vm/page_owner_sort.c for user-space helper. If unsure, say N. diff --git a/mm/page_owner.c b/mm/page_owner.c index d15c7c4994f5..2cc1113fa28d 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -31,6 +31,7 @@ struct page_owner { }; static bool page_owner_enabled = false; +static bool page_owner_stack_enabled = true; DEFINE_STATIC_KEY_FALSE(page_owner_inited); static depot_stack_handle_t dummy_handle; @@ -41,21 +42,26 @@ static void init_early_allocated_pages(void); static int __init early_page_owner_param(char *buf) { - if (!buf) - return -EINVAL; - - if (strcmp(buf, "on") == 0) - page_owner_enabled = true; - - return 0; + return kstrtobool(buf, &page_owner_enabled); } early_param("page_owner", early_page_owner_param); +static int __init early_page_owner_stack_param(char *buf) +{ + return kstrtobool(buf, &page_owner_stack_enabled); +} +early_param("page_owner_stack", early_page_owner_stack_param); + static bool need_page_owner(void) { return page_owner_enabled; } +static bool need_page_owner_stack(void) +{ + return page_owner_stack_enabled; +} + static __always_inline depot_stack_handle_t create_dummy_stack(void) { unsigned long entries[4]; @@ -122,6 +128,9 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags) depot_stack_handle_t handle; unsigned int nr_entries; + if (!need_page_owner_stack()) + return failure_handle; + nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 2); /*