From patchwork Tue Nov 20 15:46:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 10690543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 840A715A7 for ; Tue, 20 Nov 2018 15:46:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 702BB2A7EC for ; Tue, 20 Nov 2018 15:46:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 616A12A8B9; Tue, 20 Nov 2018 15:46:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 00EE02A7EC for ; Tue, 20 Nov 2018 15:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbeKUCQI (ORCPT ); Tue, 20 Nov 2018 21:16:08 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42913 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbeKUCQI (ORCPT ); Tue, 20 Nov 2018 21:16:08 -0500 Received: by mail-pf1-f194.google.com with SMTP id 64so1171648pfr.9; Tue, 20 Nov 2018 07:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kDTNf0YfFqmPIA1/Izli7zQXedYowG6g+6+gdNz3G1k=; b=I2bkaT4pycDlR63CnTw+LcgtoihDjkoAbDAoIEayFGe0O54ZGs+Za/i1NnV9unl2qc n1qEyz6zKhzq85Kx91XmNi9VTOr2yZsC0wySIZUThUoN02M9yaikcbTO+cVSbb6+1R+Y 5TIHspzc2e2ldo8K2MrjorO05wOeABzID0Jocr1z2/wO1R1jTVg0wGAjOQ87YAq0Fwpr Q/M0AEJKHFlYsd9Z1G0UvNAL/r/Ml93uGUU0prr5wJ3U/mgYLMHBuYAm9kFdiF9QTXuH BEMP6fTLkePkwiGkanb09ZAKZonqHx2RIgqAwDu16GwDHIM0BCSHIZmly010D6b6B+4/ Amng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kDTNf0YfFqmPIA1/Izli7zQXedYowG6g+6+gdNz3G1k=; b=XurAnBecO81pRp/QnitU35N3H7eTDQrv3t3lqqDGVNoSAUFOAtxLX2++FYxd9fRCsf SruGJqy+GGNi7T/mK53x3AjZFLpPDhVblfZkmKzC/XcOwwJzDdmxPclb/GktQu5FWLFu S+A5Ts8PWvHvofTC9Pw/jPaqx+QJ1+ND6Zv1HW+f81FF4Nf5pVJ7pHQgpmlwFsFkJCQb feYdKNHtSsFRfI46XcI0M7JRMO56kQxUQGTKH29hKZ6QMO9103RQiLw+H09DFGov5VNT q8mGoLpapFA4Z32/jA0HF1INzEfXaxtBaySo6EPgIgmiL83iIbue7IYFjjCfrdGh6JXH dW/Q== X-Gm-Message-State: AA+aEWZP5HXxOcMkTb5AY5OrUkeaOqHMUVILUxa4suFtb6AEqaeVQNcE VAO7LZQp/XEQlmHqyVHsy5I= X-Google-Smtp-Source: AFSGD/W7l3HuINN23UnBtDu7PDb2C7ptl8Dd/7Zh2XOvfEMIMse2rxGjIsCy3MvP8CoC0t7j0k/uuQ== X-Received: by 2002:a63:2141:: with SMTP id s1mr2390804pgm.148.1542728781340; Tue, 20 Nov 2018 07:46:21 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id h17-v6sm61988023pfj.125.2018.11.20.07.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 07:46:20 -0800 (PST) From: Yangtao Li To: lorenzo.pieralisi@arm.com, daniel.lezcano@linaro.org, rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH v2] cpuidle: big.LITTLE: add of_node_put() Date: Tue, 20 Nov 2018 10:46:17 -0500 Message-Id: <20181120154617.20903-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The of_node_put() is missing.So we call the of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- Changes in v2 -update changelog -do that right after its last use to also cover error handling. --- drivers/cpuidle/cpuidle-big_little.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c index db2ede565f1a..650f063ef809 100644 --- a/drivers/cpuidle/cpuidle-big_little.c +++ b/drivers/cpuidle/cpuidle-big_little.c @@ -174,8 +174,12 @@ static int __init bl_idle_init(void) /* * Initialize the driver just for a compliant set of machines */ - if (!of_match_node(compatible_machine_match, root)) + if (!of_match_node(compatible_machine_match, root)){ + of_node_put(root); return -ENODEV; + } + + of_node_put(root); if (!mcpm_is_available()) return -EUNATCH;