From patchwork Tue Mar 23 04:19:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12156857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707A7C433E0 for ; Tue, 23 Mar 2021 04:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31F0761992 for ; Tue, 23 Mar 2021 04:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229451AbhCWET5 (ORCPT ); Tue, 23 Mar 2021 00:19:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:45946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbhCWETs (ORCPT ); Tue, 23 Mar 2021 00:19:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E8B16198E; Tue, 23 Mar 2021 04:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616473188; bh=Oy2mR/qeC/0tXF/T1jSuG7BtEihUBdRSfPOwZs25P08=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UKUlTylUJlmxf/EZ9uRC8h1nbIazUbVY4FB3ErtKbjg2sHsB9UqpLlaZTuWevt1Tb Q4y+pQHHbsM88kRLUhC/2lyFYFNO7TBHaz624tP2bdRkhs+w4QkR1eWmaMe/Q8q3RP QdqsPGka5eby/FBwAqKbXk7nBovxxwpsXNJyfPdxWAp8pkdIbPxaw2F7djJP0mk4AK xixJMgn49TD4a77FGgaQj6LCQWfbO/1/O5qLz0ydF3WuGB2OUOTja7cT2gP+JeeC0R G+azBWicxXrGIIlP5hFxFkHE3GTX8nxJVo8MSQbunGiO2QaZp8Uy0xHMiELMllqTOD AALWluOzKYrIQ== Subject: [PATCH 1/3] populate: create block devices when pre-populating filesystems From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Mon, 22 Mar 2021 21:19:48 -0700 Message-ID: <161647318806.3429609.966502470186246038.stgit@magnolia> In-Reply-To: <161647318241.3429609.1862044070327396092.stgit@magnolia> References: <161647318241.3429609.1862044070327396092.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Darrick J. Wong I just noticed that the fs population helper creates a chardev file "S_IFBLK" on the scratch filesystem. This seems bogus (particularly since we actually also create a chardev named S_IFCHR) so fix up the mknod calls. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- common/populate | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/populate b/common/populate index 4135d89d..8f42a528 100644 --- a/common/populate +++ b/common/populate @@ -230,7 +230,7 @@ _scratch_xfs_populate() { # Char & block echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 - mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1 + mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR @@ -402,7 +402,7 @@ _scratch_ext4_populate() { # Char & block echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 - mknod "${SCRATCH_MNT}/S_IFBLK" c 1 1 + mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR From patchwork Tue Mar 23 04:19:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12156853 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54720C433DB for ; Tue, 23 Mar 2021 04:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0488661990 for ; Tue, 23 Mar 2021 04:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229452AbhCWET5 (ORCPT ); Tue, 23 Mar 2021 00:19:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhCWETy (ORCPT ); Tue, 23 Mar 2021 00:19:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D466461990; Tue, 23 Mar 2021 04:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616473193; bh=5o3PRU4OvnC1W0sNVlX3XyQIhh7K8DWWmcpgWYJ/pvs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=J+5jrkv7RavLHBPGkRNVK6Dh0JsH5L72hJ4+JpHZgydYlPSymjOeq4Nb+bnhUGkcE BsaVtm050KqeDXsk3xdu5z9nh91WJQdIUlZWJJHZyN7vTNiObf14Ai6Rk1Mq3o8/XG 1bnJ7IyNNRA6S1sxuRGktcRQAzNJdHwfPKH5qesLseVZ9/jtEE/tgUb6Vpwt8bjY0n Mofd9ihDGGoZyBw+0ouyU1AlOMytKZmDpQLShk7rIjFNKu3FRnmAoQ/ZVgnGCc81xB eqgdfHHA2ULRgCpub20yt61kbp17Blc7qaoaPsUxTIZ8oFoGTSjX5Ns0lgT9BeksQd gpSJSZK0Ae48g== Subject: [PATCH 2/3] common/populate: create fifos when pre-populating filesystems From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Mon, 22 Mar 2021 21:19:53 -0700 Message-ID: <161647319358.3429609.6818899550213439595.stgit@magnolia> In-Reply-To: <161647318241.3429609.1862044070327396092.stgit@magnolia> References: <161647318241.3429609.1862044070327396092.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Darrick J. Wong Create fifos when populating the scratch filesystem for completeness. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- common/populate | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/common/populate b/common/populate index 8f42a528..c01b7e0e 100644 --- a/common/populate +++ b/common/populate @@ -231,6 +231,7 @@ _scratch_xfs_populate() { echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 + mknod "${SCRATCH_MNT}/S_IFIFO" p # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR @@ -403,6 +404,7 @@ _scratch_ext4_populate() { echo "+ special" mknod "${SCRATCH_MNT}/S_IFCHR" c 1 1 mknod "${SCRATCH_MNT}/S_IFBLK" b 1 1 + mknod "${SCRATCH_MNT}/S_IFIFO" p # special file with an xattr setfacl -P -m u:nobody:r ${SCRATCH_MNT}/S_IFCHR @@ -580,6 +582,7 @@ _scratch_xfs_populate_check() { extents_slink="$(__populate_find_inode "${SCRATCH_MNT}/S_IFLNK.FMT_EXTENTS")" bdev="$(__populate_find_inode "${SCRATCH_MNT}/S_IFBLK")" cdev="$(__populate_find_inode "${SCRATCH_MNT}/S_IFCHR")" + fifo="$(__populate_find_inode "${SCRATCH_MNT}/S_IFIFO")" local_attr="$(__populate_find_inode "${SCRATCH_MNT}/ATTR.FMT_LOCAL")" leaf_attr="$(__populate_find_inode "${SCRATCH_MNT}/ATTR.FMT_LEAF")" node_attr="$(__populate_find_inode "${SCRATCH_MNT}/ATTR.FMT_NODE")" @@ -605,6 +608,7 @@ _scratch_xfs_populate_check() { __populate_check_xfs_dformat "${btree_dir}" "btree" __populate_check_xfs_dformat "${bdev}" "dev" __populate_check_xfs_dformat "${cdev}" "dev" + __populate_check_xfs_dformat "${fifo}" "dev" __populate_check_xfs_attr "${local_attr}" "local" __populate_check_xfs_attr "${leaf_attr}" "leaf" __populate_check_xfs_attr "${node_attr}" "node" From patchwork Tue Mar 23 04:19:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 12156859 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60E9C433C1 for ; Tue, 23 Mar 2021 04:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8405C619AE for ; Tue, 23 Mar 2021 04:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbhCWEU3 (ORCPT ); Tue, 23 Mar 2021 00:20:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:46144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhCWET7 (ORCPT ); Tue, 23 Mar 2021 00:19:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5A11A6198E; Tue, 23 Mar 2021 04:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616473199; bh=CZb3ZIvrFD4xXviq3uk8k4wTqG9BYGXiirhmTUr59jQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=o87J1y2aiRxPFYXOY20xhQrnnwA9W+g33aJYirOszpiuY7MxvCYdBZ13YEedgkvPM EydMWc24SiJ11g819nP3k28oULF9n/znzv7agEPm0QLEwfZUSxh9iUAPNG1hyH3Dvb Bj/kHUZ6SazIZa/wz0OS39VT/Q7WG/6NLacJKcESxuX1c8P46CHi02aDr0zdqF2tUf PDFUtj6t7zm+U/LFEcxT5jAr2rOCXF+hB6aM2BY5TZ0ahLULCrD7JlkEfRWYcZCQ5O h29wjKutBpt3IewY8KusmuPgFOyGmtXHCkyH6CRkOybeQNnR/qDgScwFp24+C33WVK ktVpqhMWexDhg== Subject: [PATCH 3/3] common/populate: change how we describe cached populated images From: "Darrick J. Wong" To: djwong@kernel.org, guaneryu@gmail.com Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Date: Mon, 22 Mar 2021 21:19:59 -0700 Message-ID: <161647319905.3429609.14862078528489327236.stgit@magnolia> In-Reply-To: <161647318241.3429609.1862044070327396092.stgit@magnolia> References: <161647318241.3429609.1862044070327396092.stgit@magnolia> User-Agent: StGit/0.19 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Darrick J. Wong The device name of a secondary storage device isn't all that important, but the size is. Signed-off-by: Darrick J. Wong --- common/populate | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/common/populate b/common/populate index c01b7e0e..94bf5ce9 100644 --- a/common/populate +++ b/common/populate @@ -808,13 +808,23 @@ _fill_fs() _scratch_populate_cache_tag() { local extra_descr="" local size="$(blockdev --getsz "${SCRATCH_DEV}")" + local logdev="none" + local rtdev="none" + + if [ "${USE_EXTERNAL}" = "yes" ] && [ -n "${SCRATCH_LOGDEV}" ]; then + logdev="$(blockdev --getsz "${SCRATCH_LOGDEV}")" + fi + + if [ "${USE_EXTERNAL}" = "yes" ] && [ -n "${SCRATCH_RTDEV}" ]; then + rtdev="$(blockdev --getsz "${SCRATCH_RTDEV}")" + fi case "${FSTYP}" in "ext4") - extra_descr="LOGDEV ${SCRATCH_LOGDEV} USE_EXTERNAL ${USE_EXTERNAL}" + extra_descr="LOGDEV_SIZE ${logdev}" ;; "xfs") - extra_descr="LOGDEV ${SCRATCH_LOGDEV} USE_EXTERNAL ${USE_EXTERNAL} RTDEV ${SCRATCH_RTDEV}" + extra_descr="LOGDEV_SIZE ${logdev} RTDEV_SIZE ${rtdev}" _populate_xfs_qmount_option if echo "${MOUNT_OPTIONS}" | grep -q 'usrquota'; then extra_descr="${extra_descr} QUOTAS"