From patchwork Tue Nov 20 13:56:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 10690739 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF76714E2 for ; Tue, 20 Nov 2018 16:25:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EE0D2A9DB for ; Tue, 20 Nov 2018 16:25:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 934672A9F1; Tue, 20 Nov 2018 16:25:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 478092A9DB for ; Tue, 20 Nov 2018 16:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=kYJLQ1P34MFwjylYw38Fk6ILFL0na7F8b3wmZRKTxgc=; b=Qos fsbut07NKA1zK5nFlDRk1EtUxksHlqZXJpJSuLT7yesFCRNxpw+c8bTi4uUEzpjG5mxEnzoSeYCoi 0GvKMbmB0CifqLArSqDFn2O+aljlPvQlpcCYwBFFh88veYus8+CsQB2csvsApYC9rnW1M1Fej1tzt +dbnWI8YAWLX3kdI62H31Ug6wj9zqsldIi5w+HYv96gDKYwxv72UN0FpUzEJYeW8+colOFQUnKRwx oD4sxuFQbaaWIohdDFKLuLNA90XSL71UYOhZDS0Tcuk6Oje6BTG42g01n2Am2mQ2/85XBEyg3uyqa 8j6bZ7vmvAGrvrTA18Vi48UlhlTNnow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP8qP-0006Rc-6p; Tue, 20 Nov 2018 16:25:45 +0000 Received: from casper.infradead.org ([85.118.1.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP8lA-0001iL-AJ for linux-arm-kernel@bombadil.infradead.org; Tue, 20 Nov 2018 16:20:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6pmlTDFihEBurm1dLJqxoC6KqTTJxAXpBV9ussy6bQU=; b=XXJdd7xwarL2Rg+IK+DrOitB1 2AOBrtzZsvUgMYzWBclu9ynWm5RoeulH0wdnurgILjsRHc6nnw29WoqnFARUwx0SmqlywBqA66zC+ 4O2vvN8iUDNSudoPgouzI7N1uGhvIzTH0zO2p6dSaGXG61/5LtpHxZ2MG23krFkU+c2xTzGqjaJzL TAjziZuCbdjJTGfOguof25PwcS8CFJOtvUo5GinVBdTF4vvQWHJYA7mEwbcUjnBb4jTRonlkKo92F 0YLgeGYjwsmIahLeDyN0NncAlBmuUpX6zdBmbDxBoY15CwJbRVUDjgMLnMN0sYrdxTlvIowYYgUth 3TOLPLTkA==; Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP6Ww-0006gq-4f for linux-arm-kernel@lists.infradead.org; Tue, 20 Nov 2018 13:57:31 +0000 Received: by mail-pg1-x542.google.com with SMTP id 17so951824pgg.1 for ; Tue, 20 Nov 2018 05:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6pmlTDFihEBurm1dLJqxoC6KqTTJxAXpBV9ussy6bQU=; b=t83HAtYUh91BViAkEApdq7rcZRf9JtcAbAe+Dj5y7eXmG8gX0nZjPmILkTXYlwneVp jkGWYFgV5dgbsXhe9TzxEZe9Ag/YsMhUpYNM4oSuSd/EdRktXHSvclBAUFyB6e5kohJ8 NIgtNily3kx0bfPJyZQ3japSWLNZIf8cBE4kyO3rbMXZ2lymgR08n1RTehHeZMEJsVTa 2Q7IlpIvhTnN6aB7RmGfDLfnTC+a8Tsk6ta2SMzn8QHdMyZ9j52Jws8fMLN1skZ2zoGl ZOkKm8Wad/tDZQnLGHtn5rKZ0+5uu8l/Xf0+/SLZAv5MEJhKTSnkWZ3FPygcMYUL08Ra E+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6pmlTDFihEBurm1dLJqxoC6KqTTJxAXpBV9ussy6bQU=; b=oheB8vW1nlax5O/nvuTMsLOB7KPpl99VfJbISFrudIWM5ow0HufJlvj8RR6+cal8V8 1ThzR2xH5ikK1wyzy71idMlAcTk8aV1dFRFMUq7IglnjvvUK/BICZHfS5zX/hLH4NnX4 X+nTueRO3l4NeYPs/qWgu8CCC3xtG4hbpsvonEgK4z5L405O9OCTD+wrkObWQEdPC6eZ 6YN8HEaV1Xx2MZ7409zGH9UQuKS4/2pqyDaXb0PFS3LrnwwMWP34WTxv5UfzTeWBXeGm JC1FV7T51NNe/KgqC73kJwZ5BIDhjcrf3Qme+VMAm0i51e5DPGjPiYOdSXA0xckKAAhZ 3sJg== X-Gm-Message-State: AGRZ1gJ0+Le9VY/OsmBcjNB1RScw0I8J1LXPGBrLOlrLSo4o9jYuqgMn 2M2C0puUCVZ1Hp6qDTi9DsE= X-Google-Smtp-Source: AJdET5dBOMfbIDqeIx3eW0bfrdCurno1vpsxWSZnkEORK0HbwIPU9AIgtoLNTHWbqsF7RVWTnTIUIA== X-Received: by 2002:a62:d2c1:: with SMTP id c184mr2283706pfg.248.1542722177304; Tue, 20 Nov 2018 05:56:17 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id o189sm20501945pfg.117.2018.11.20.05.56.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 05:56:16 -0800 (PST) From: Yangtao Li To: linux@armlinux.org.uk, akpm@linux-foundation.org, mhocko@suse.com, rppt@linux.vnet.ibm.com, robh@kernel.org Subject: [PATCH] arm: add missing of_node_put() Date: Tue, 20 Nov 2018 08:56:13 -0500 Message-Id: <20181120135613.20249-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181120_135730_204874_FCCB6A67 X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP use of_node_put() to release the refcount. Signed-off-by: Yangtao Li --- arch/arm/kernel/devtree.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c index e3057c1b55b9..9576adf0d15b 100644 --- a/arch/arm/kernel/devtree.c +++ b/arch/arm/kernel/devtree.c @@ -101,7 +101,7 @@ void __init arm_dt_init_cpu_maps(void) if (!cell || prop_bytes < sizeof(*cell)) { pr_debug(" * %pOF missing reg property\n", cpu); of_node_put(cpu); - return; + goto out; } /* @@ -115,7 +115,7 @@ void __init arm_dt_init_cpu_maps(void) if (prop_bytes || (hwid & ~MPIDR_HWID_BITMASK)) { of_node_put(cpu); - return; + goto out; } /* @@ -129,7 +129,7 @@ void __init arm_dt_init_cpu_maps(void) if (WARN(tmp_map[j] == hwid, "Duplicate /cpu reg properties in the DT\n")) { of_node_put(cpu); - return; + goto out; } /* @@ -171,7 +171,7 @@ void __init arm_dt_init_cpu_maps(void) if (!bootcpu_valid) { pr_warn("DT missing boot CPU MPIDR[23:0], fall back to default cpu_logical_map\n"); - return; + goto out; } /* @@ -184,6 +184,8 @@ void __init arm_dt_init_cpu_maps(void) cpu_logical_map(i) = tmp_map[i]; pr_debug("cpu logical map 0x%x\n", cpu_logical_map(i)); } +out: + of_node_put(cpus); } bool arch_match_cpu_phys_id(int cpu, u64 phys_id)