From patchwork Tue Mar 23 14:24:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12158175 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9539C433C1 for ; Tue, 23 Mar 2021 14:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A95D5619B6 for ; Tue, 23 Mar 2021 14:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbhCWOYr (ORCPT ); Tue, 23 Mar 2021 10:24:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34545 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232037AbhCWOY0 (ORCPT ); Tue, 23 Mar 2021 10:24:26 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lOhxF-0000jQ-Pj; Tue, 23 Mar 2021 14:24:21 +0000 From: Colin King To: Mirela Rabulea , NXP Linux Team , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] media: imx-jpeg: Pass the v4l2_jpeg_header header argument by reference Date: Tue, 23 Mar 2021 14:24:21 +0000 Message-Id: <20210323142421.348695-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Colin Ian King Currently the header argument is being passed by value, so a copy of 256 byte structure on the stack is potentially occurring. Fix this by passing by reference to avoid any large stack copies. Addresses-Coverity: ("Big parameter passed by value") Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder") Signed-off-by: Colin Ian King Reviewed-by: Mirela Rabulea --- drivers/media/platform/imx-jpeg/mxc-jpeg.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index adb1715c75d7..f13a8efc35ad 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -1114,21 +1114,21 @@ static int mxc_jpeg_valid_comp_id(struct device *dev, } static u32 mxc_jpeg_get_image_format(struct device *dev, - const struct v4l2_jpeg_header header) + const struct v4l2_jpeg_header *header) { int i; u32 fourcc = 0; for (i = 0; i < MXC_JPEG_NUM_FORMATS; i++) - if (mxc_formats[i].subsampling == header.frame.subsampling && - mxc_formats[i].nc == header.frame.num_components) { + if (mxc_formats[i].subsampling == header->frame.subsampling && + mxc_formats[i].nc == header->frame.num_components) { fourcc = mxc_formats[i].fourcc; break; } if (fourcc == 0) { dev_err(dev, "Could not identify image format nc=%d, subsampling=%d\n", - header.frame.num_components, - header.frame.subsampling); + header->frame.num_components, + header->frame.subsampling); return fourcc; } /* @@ -1137,7 +1137,7 @@ static u32 mxc_jpeg_get_image_format(struct device *dev, * ITU-T T.872 chapter 6.5.3 APP14 marker segment for colour encoding */ if (fourcc == V4L2_PIX_FMT_YUV24 || fourcc == V4L2_PIX_FMT_RGB24) { - if (header.app14_tf == V4L2_JPEG_APP14_TF_CMYK_RGB) + if (header->app14_tf == V4L2_JPEG_APP14_TF_CMYK_RGB) fourcc = V4L2_PIX_FMT_RGB24; else fourcc = V4L2_PIX_FMT_YUV24; @@ -1258,7 +1258,7 @@ static int mxc_jpeg_parse(struct mxc_jpeg_ctx *ctx, if (!mxc_jpeg_valid_comp_id(dev, psof, psos)) dev_warn(dev, "JPEG component ids should be 0-3 or 1-4"); - fourcc = mxc_jpeg_get_image_format(dev, header); + fourcc = mxc_jpeg_get_image_format(dev, &header); if (fourcc == 0) return -EINVAL;