From patchwork Fri Mar 26 14:34:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166841 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCEEC433E0 for ; Fri, 26 Mar 2021 14:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 086B961A24 for ; Fri, 26 Mar 2021 14:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbhCZOfP (ORCPT ); Fri, 26 Mar 2021 10:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbhCZOfH (ORCPT ); Fri, 26 Mar 2021 10:35:07 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0766C0613BB for ; Fri, 26 Mar 2021 07:35:04 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id e18so5870183wrt.6 for ; Fri, 26 Mar 2021 07:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DBKiLgurMgloDH4dmthaQmSJlqRwCd+7wWZCtSqyx24=; b=bvITmmoWQkz/BAmA8clyA6v/M3+4LVQGjzfWYcjfQB8daWbjdZi/gq9mTkUXL2fw/W dW3SpncUQ97s56AZ3GH3+VJFN7bcHm/EADf3xINuOVau4zU3K8WwwIAD+g28RNoYrGN2 AwYI4kqLEsWZ7rRn1m+Yd+TmBHbO4T0OOG2gWLu5SF/aLQwXLieq49mggUigXX7XRh9Y yBXuRgHE3KZnHY8QKTUQPz0FeWMzisZRBtF+nks1p3OoPj7yIgZ3kQIqNOIRyuGKAIWK p6qN1u9PEaJ9ZUoPhRKrzT3FFazBauvOgSMjB8fdSYkfyBoq3L6fdNBy+xo8zBMhRdB3 +oqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DBKiLgurMgloDH4dmthaQmSJlqRwCd+7wWZCtSqyx24=; b=bdpBPbkMoiGoftdp7AaZl4GCATrkZZ5sGA/YLERE15LOu1sWpeuISRuiihTiTwhcfX iwsuXozihJMfXr16JL3EqZnI8AcVHKxcb8p4ngme0x+EhWk8howrNTQj0BgY0eG4u/ym Qe1S4f0YrOHDkhENEJ6otB4l9wgkKR1CEO346Y+p/P8kg2RbFRD9Zn9yFQ8Z9ikvb5Nh 9QzIRUuR/V1t1zM+tX/DEE/Pl1U0o736C9QafEFtaOJzcETKy1a1h4J+lm2z1HIObTyf 8CMddvlqXs+ADTQWR4bthbxevFX8UOnXsUPf/m0mm+7s79EmDnU91L68e5NiegRVYlTl +Rzw== X-Gm-Message-State: AOAM531QsETKCtICAeUYgQZAWLozSgc5ZBVneNFibcC9uue5A6wXPidR dfUQbm51nFILgWeT2dAV2MLZHg== X-Google-Smtp-Source: ABdhPJxwACsNiurDP1jau2TYaMay4rZXKsXCowrA5fXjZmBqZzO64ouadUb6/eu9bYXbgxk/H6PaiA== X-Received: by 2002:adf:f4ce:: with SMTP id h14mr14682728wrp.257.1616769303585; Fri, 26 Mar 2021 07:35:03 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:03 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err' Date: Fri, 26 Mar 2021 14:34:34 +0000 Message-Id: <20210326143458.508959-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/client.c: In function ‘ishtp_cl_disconnect’: drivers/hid/intel-ish-hid/ishtp/client.c:266:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index 1cc157126fce7..c81a1f8a92685 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -263,7 +263,6 @@ EXPORT_SYMBOL(ishtp_cl_unlink); int ishtp_cl_disconnect(struct ishtp_cl *cl) { struct ishtp_device *dev; - int err; if (WARN_ON(!cl || !cl->dev)) return -ENODEV; @@ -283,7 +282,7 @@ int ishtp_cl_disconnect(struct ishtp_cl *cl) return -ENODEV; } - err = wait_event_interruptible_timeout(cl->wait_ctrl_res, + wait_event_interruptible_timeout(cl->wait_ctrl_res, (dev->dev_state != ISHTP_DEV_ENABLED || cl->state == ISHTP_CL_DISCONNECTED), ishtp_secs_to_jiffies(ISHTP_CL_CONNECT_TIMEOUT)); From patchwork Fri Mar 26 14:34:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166845 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 682AAC433EA for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47D57619F2 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230274AbhCZOfS (ORCPT ); Fri, 26 Mar 2021 10:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbhCZOfI (ORCPT ); Fri, 26 Mar 2021 10:35:08 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3AC1C0613BC for ; Fri, 26 Mar 2021 07:35:05 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id e18so5870243wrt.6 for ; Fri, 26 Mar 2021 07:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QVmPdW315bcMNCrhn2o1gVugo/fPOa1lxmMCL3Wjz+Y=; b=ED8HacYfYn6YJjZ0KkKvWkz8yYZq1TC+nrf/H+kyQ1IIfzl50xLOCLW4Fm+JEwgUzA xp+L5FlsRqou4qpw9+VZ+4DEuus50xbo0Qyfh+ZOuySePEB1EW1eGMmG21yX1zb6t1PJ czXpkjIvhXlibEKrL1H21gusLkrBcLoEAZw6tXqbE0xJ43SqmvNKX7s/2IdlJ4Ou9Nua yLSqhX9Nsy8rJcvbsRS5Rs1gsVJ4BJXZqymsSFboYExammE9/wscC5GgAjUfcJ8BtXrq 6+MLu3+qYLrXuluhvLsxFQ8zGEbMVYnhjgJuUWklHogHD4KqmjVa4lfpOzhw1bG8qyIG yHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QVmPdW315bcMNCrhn2o1gVugo/fPOa1lxmMCL3Wjz+Y=; b=F5aYpCad8IrzvAFWu4c6pgYTPAu1PZnqzJHsceI1PFWCJ1fGQooyha7A/ic5X6JsiG bnomqwjnuzXT0B0ztq6WvDZF6Hzkb4yhjMIWH7nt8Frurscdtogndz8/XbdahTHk2y2d huBeLddZzhj5JA6j34mD3H76lLb+rpyENZ5l9qEP+xAnp6g4ak11edHmIgiYPhLPb+VD nkUryfL+KemxnbyIQ/+1K+TBKpcY9bCAbtbh45KwcPCd2FOr2ji3dFxCD5FgZNAt4sck 18obsN3T3r++kSb4q4eVK8WVH3icEu/U7T43d1a6FkwMlRq85XEIWLISZZUCMnCji4us UEaA== X-Gm-Message-State: AOAM530DJhUpmiO9yfEBf6Y5lc5wVCWwZ9nUpYp8SAGLHa/Y0i1/0UiK xdZ3Q6gM87CsM/V5kNvhil9TSz5SMS73oQ== X-Google-Smtp-Source: ABdhPJxc+5Hvcu230xbJbWY1bi5eCDiEqxgDh38Ziv7bn5I5Jtxr6pSdOylVXcjcAyF+PLWt6vev1w== X-Received: by 2002:a5d:4fd0:: with SMTP id h16mr14405613wrw.178.1616769304525; Fri, 26 Mar 2021 07:35:04 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:04 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Date: Fri, 26 Mar 2021 14:34:35 +0000 Message-Id: <20210326143458.508959-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++ drivers/hid/intel-ish-hid/ishtp-hid.h | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 0f1b5283bab42..24599280105d8 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -11,6 +11,11 @@ #include #include "ishtp-hid.h" +/* ISH Transport protocol (ISHTP in short) GUID */ +static const guid_t hid_ishtp_guid = + GUID_INIT(0x33AECD58, 0xB679, 0x4E54, + 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); + /* Rx ring buffer pool size */ #define HID_CL_RX_RING_SIZE 32 #define HID_CL_TX_RING_SIZE 16 diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h index 5ffd0da3cf1fa..e2423f7d2b547 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.h +++ b/drivers/hid/intel-ish-hid/ishtp-hid.h @@ -20,11 +20,6 @@ extern void (*hid_print_trace)(void *unused, const char *format, ...); #define hid_ishtp_trace(client, ...) \ (hid_print_trace)(NULL, __VA_ARGS__) -/* ISH Transport protocol (ISHTP in short) GUID */ -static const guid_t hid_ishtp_guid = - GUID_INIT(0x33AECD58, 0xB679, 0x4E54, - 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); - /* ISH HID message structure */ struct hostif_msg_hdr { uint8_t command; /* Bit 7: is_response */ From patchwork Fri Mar 26 14:34:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166847 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C5DC433EB for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33C0A61A49 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbhCZOfQ (ORCPT ); Fri, 26 Mar 2021 10:35:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbhCZOfI (ORCPT ); Fri, 26 Mar 2021 10:35:08 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7BCC0613BE for ; Fri, 26 Mar 2021 07:35:06 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id x13so5845599wrs.9 for ; Fri, 26 Mar 2021 07:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+wgJT+2rlYaTQGPBJtoa9jo055QORNuijpExOiSwidg=; b=lhmKo8zYKTVyHkCYOUL8Dmj6IslDEfKHrK7GAtHgyFM+v+1DMGJttuRZCYrRqhawjr PirvVfHNF9jYSluJR4hybQ/3tCmoo56VvcgBlA+HranEzseWKphmEjEU5UQfxAVYpSiX dK4LtlrTSfBVJHwjXbG8sx4RFK1aZ8ZH+8gERBrmfT6APFWq4Cbzfiso0lau9kKcrEzM 3GLT7dNmExpzi8s+Mra9LKmfWL4lvMp9zuAGuMKbSjaKMPOzg2NrgdZzLrEPgryvJtEN ctf+Sb46ftgGZq2s29qGWzB8fXw0zGb9zm6bzFwFJ1Oo00AaQ5fL5BtlnBkax8hKKqJW 5hCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+wgJT+2rlYaTQGPBJtoa9jo055QORNuijpExOiSwidg=; b=Lx4JGgextnoRHTZEE3/TCo0atXfz+2y6RhwH3GuRAwJ1f2GGYUmrjTfX8DKtesivXH Os+TMoK9EdF/+mh4Jv2YWFWOruOl1dcQRZ4J2m07K8nuEvoOP81PCDPxleLV9XHmEen4 Ram9T4rm71WtFppuyFvElO+yHika1Afl628CspjCNnyp/WKs9svJHw0PqSfDll7VXZiJ qxO/vcHPFh5F/QY+SRg+h/AnwlaiczStIYVH4RGz2p/JhdkqEGPyuE00Xilgtwnzjd6X iWdunii2nhQYM5eVRzpje6sWMU2Ptt/FS4nQW2qL1aAjTTK+OXX/19b4CH3lLt6y87SS eqzw== X-Gm-Message-State: AOAM53256y04v2Ntyqwcce0jusAMZCaHBZyqttIwmwBz444CD4GC9LE5 NmtfAyP1OtiSIY4YHD6pNnC+tQ== X-Google-Smtp-Source: ABdhPJyimJxsZ3rpCSt/gL4lDDTPGwlAOyhXFrW4+tUdqifDhNF/eAHunyWtOVKE1d7NoJ9tWlVVqg== X-Received: by 2002:a5d:4e85:: with SMTP id e5mr15102455wru.218.1616769305350; Fri, 26 Mar 2021 07:35:05 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:05 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , Kai-Heng Feng , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' Date: Fri, 26 Mar 2021 14:34:36 +0000 Message-Id: <20210326143458.508959-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ipc/pci-ish.c: In function ‘ish_resume_handler’: drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Zhang Lixu Cc: Kai-Heng Feng Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c index 06081cf9b85a2..61efc30ed9afb 100644 --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c @@ -261,7 +261,6 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work) struct pci_dev *pdev = to_pci_dev(ish_resume_device); struct ishtp_device *dev = pci_get_drvdata(pdev); uint32_t fwsts = dev->ops->get_fw_status(dev); - int ret; if (ish_should_leave_d0i3(pdev) && !dev->suspend_flag && IPC_IS_ISH_ILUP(fwsts)) { @@ -273,7 +272,7 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work) /* Waiting to get resume response */ if (dev->resume_flag) - ret = wait_event_interruptible_timeout(dev->resume_wait, + wait_event_interruptible_timeout(dev->resume_wait, !dev->resume_flag, msecs_to_jiffies(WAIT_FOR_RESUME_ACK_MS)); From patchwork Fri Mar 26 14:34:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166843 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190FCC433E8 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0768461A18 for ; Fri, 26 Mar 2021 14:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbhCZOfR (ORCPT ); Fri, 26 Mar 2021 10:35:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbhCZOfI (ORCPT ); Fri, 26 Mar 2021 10:35:08 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81084C0613B2 for ; Fri, 26 Mar 2021 07:35:07 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id b9so5844998wrt.8 for ; Fri, 26 Mar 2021 07:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KY+ot5dzoWxg13y22fAr16+A3Tqxw//rMDzqbWyDuaI=; b=e5yd/ueye/lKJH2c40Aeqvr4G3DXwcpQzPjCIFfr+s2BV+TGCk/I5W7r/K4w4+fRoQ gxklrV/kmFnk5mbKiUJ63f3wXyZ7woUvAgUKsEy2o/nFdNTYqleS5DwBCi4dlosL++GA 3M7XHNlHMN/O5wAM1P0ITL+WgqCMdeIhvcGr1O5uensGqZxrASHEj7FFFHTPbV2oTzln wiXx5JVb53jeR+3+RS8vA0gbIztp8rlQ8GQipYoh1c5B20MDfImhvf3Yjn+NdkqsWLHV XEZoGMnu92awWzJ+df0f0UOClWcz7vpbYwmpn1pVwD2SdZ3uTGs8DDUBUWf13Qss+iKk wpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KY+ot5dzoWxg13y22fAr16+A3Tqxw//rMDzqbWyDuaI=; b=IaKsU2QZ4mFj4kGAkUVS1sV90uEaoJwoAeOLUQv2U0nYvFLvyGGq5kxMs1wq64YoZ4 bYaRBDDD4lz6h3jbZoGrMGfDOYXjdxZZpLMAE6F3zHdLglOhjKHFxRomFEOXmATE/Zc3 iIAKfyKM0b4I0btOZBmQtdQNgy4RrQZDdJ2AX/vZs3ieSMpMOfY00wc9tK8OnS/BZeIX I18ffSisNS5bLxceqoCw9KlxgXqCPSOnl5E3i7twD1C+ZUmDzyiI70YJ0EyFukJqNj4G SSW2kEyrkRMjTFVhFr1JR6qPWAnpHYNbYXqEpMpPlZSCLYznG1aVb0uRducyZvBJIxGE +UWQ== X-Gm-Message-State: AOAM53367R7G00b3B6CJWKa38WQBv1AtnBZq5DT3D7V+dTtKlTEaVnnX +KFB0rIWmCKEEowO5M78xg3JnQ== X-Google-Smtp-Source: ABdhPJy0qmvZuHKAQADNW0Bwq0kJZfWnVUFoAsQsXQYa3YacplAADX8qwz2tRaJA751tWOaAegTxZA== X-Received: by 2002:a5d:6092:: with SMTP id w18mr14806536wrt.52.1616769306280; Fri, 26 Mar 2021 07:35:06 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:05 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= , linux-input@vger.kernel.org Subject: [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions Date: Fri, 26 Mar 2021 14:34:37 +0000 Message-Id: <20210326143458.508959-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id' drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device' drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device' drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback' drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Uwe Kleine-König" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/bus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c index ffc9ce5c86ee6..c1c7d5356208d 100644 --- a/drivers/hid/intel-ish-hid/ishtp/bus.c +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c @@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client); /** * ishtp_get_fw_client_id() - Get fw client id + * @fw_client: firmware client used to fetch the ID * * This interface is used to reset HW get FW client id. * @@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void) /** * ishtp_device() - Return device pointer + * @device: ISH-TP client device instance * * This interface is used to return device pointer from ishtp_cl_device * instance. @@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device); * ishtp_get_pci_device() - Return PCI device dev pointer * This interface is used to return PCI device pointer * from ishtp_cl_device instance. + * @device: ISH-TP client device instance * * Return: device *. */ @@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device); /** * ishtp_trace_callback() - Return trace callback + * @cl_device: ISH-TP client device instance * * This interface is used to return trace callback function pointer. * @@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback); /** * ish_hw_reset() - Call HW reset IPC callback + * @dev: ISHTP device instance * * This interface is used to reset HW in case of error. * From patchwork Fri Mar 26 14:34:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166849 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1494C433DB for ; Fri, 26 Mar 2021 14:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 750B061A18 for ; Fri, 26 Mar 2021 14:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbhCZOfo (ORCPT ); Fri, 26 Mar 2021 10:35:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbhCZOfJ (ORCPT ); Fri, 26 Mar 2021 10:35:09 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B738C0613B3 for ; Fri, 26 Mar 2021 07:35:08 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id v4so5828453wrp.13 for ; Fri, 26 Mar 2021 07:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gdgFIP4Ey3DU3/Bk4Kw+HV9BNhlKbYnUBqgpZv4uG1E=; b=d6INxl4zZP1t4Ec5hvZNbzYKCqsprbycn/+myx5F8Ser+KW/Vh11ZMDbZZBgIsw4ag 0QYJL4tsjV2fN3ea3Cy/icF6I2jfn9U62p1ekikhR+d8FHIAmdUAKVn8QaEzZHM/GM/n 4p+V3u3VsUIMtGb3Jr2/uoE9M8IaRfgJwNSGOeNCiUCQ/iA2aKo3EBWI7wdLF3H+rDpK br/ahWUm+IbFf4kLHidS2k5krganrlvxzJjQvaMofKl5HoM/CnuD6CmwIy2AGqHrTqGI IuYbuNgDyoPuJhJvvG/fJHjN4MQSxTMrSX/mDqfhBrdJ7vK6a3n6/VQU57kBli1umuNn HTDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gdgFIP4Ey3DU3/Bk4Kw+HV9BNhlKbYnUBqgpZv4uG1E=; b=LLxz93Mnwk5Fk6JsgLpVr6NqD/9/qGneNZtlrpDaw6mUgViDcAVgf3xpU0j5gkrY63 sb7oYAuH8WbcTWbSnC99Ma+STVjBDAPIf/R4mzfVpRxZzqZUWljM44A0wWt02nLKCUCa AZom4UBClow82Ee7+fepx77Ls6h55kSMuIOKI+wBe4WDv1iGPDvo4aWsFsOlQJj4Drsv JRdvT16EiXvQIdWEJuaAwbNpInkLRNBXL0ec9k1irC5+X9kTfzLbGc8pKLij/rUuxJJp JUk8/GZUrt7/FFAPc0iB3RHWqHsIzIdLym60VGIRrjAoZxIjmOiydPwT8nUWQZCV3Cvu cwAw== X-Gm-Message-State: AOAM530sBUzKmXDr8TJBxV9zeUrYvSPmQrMElK3t+TuMqbzMNpU3rZ/Z g/xRBnuAe31MiWAWBySINEGUUHqUgg2lOA== X-Google-Smtp-Source: ABdhPJyXs3KlUi7iOdPWxatL4DJcaZHu6NnzdgGpexJkxA6o/CUtEyKwJ8M7M12AOQEZ/ApCaopMhg== X-Received: by 2002:a5d:44c5:: with SMTP id z5mr14273093wrr.319.1616769307150; Fri, 26 Mar 2021 07:35:07 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:06 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error Date: Fri, 26 Mar 2021 14:34:38 +0000 Message-Id: <20210326143458.508959-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/hbm.c:409: warning: expecting prototype for ishtp_client_disconnect_request(). Prototype was for ishtp_hbm_fw_disconnect_req() instead drivers/hid/intel-ish-hid/ishtp/hbm.c:433: warning: wrong kernel-doc identifier on line: Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c index dbfae60f26216..9c031a06e4c40 100644 --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c @@ -398,7 +398,7 @@ static void ishtp_hbm_cl_connect_res(struct ishtp_device *dev, } /** - * ishtp_client_disconnect_request() - Receive disconnect request + * ishtp_hbm_fw_disconnect_req() - Receive disconnect request * @dev: ISHTP device instance * @disconnect_req: disconnect request structure * @@ -430,7 +430,7 @@ static void ishtp_hbm_fw_disconnect_req(struct ishtp_device *dev, } /** - * ishtp_hbm_dma_xfer_ack(() - Receive transfer ACK + * ishtp_hbm_dma_xfer_ack() - Receive transfer ACK * @dev: ISHTP device instance * @dma_xfer: HBM transfer message * From patchwork Fri Mar 26 14:34:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166851 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A8ECC433E2 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11E0961A05 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbhCZOfr (ORCPT ); Fri, 26 Mar 2021 10:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230198AbhCZOfK (ORCPT ); Fri, 26 Mar 2021 10:35:10 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78DA5C0613B5 for ; Fri, 26 Mar 2021 07:35:09 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id g20so3097642wmk.3 for ; Fri, 26 Mar 2021 07:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=B2LHHGKt5RYtaAQDcE2ea2YjPdmOcookzVWUcAeW2fSKBOJYI4+/tTokzh72qclZTH o9XkPL0/M9rjfnS0EZXsGyJLZuK/uhjxvHwy1BgLn7IF2r6pLi5+aL1OsFmoaK4rM18+ /8iiG42d8nOg7/rkGhD126LKouPNXEJWi2msD9kTTxN49Wxj2WHPgltfnrXugkf++PmV Dnkl+/l2GOSiKRL9zXMtTp+NQdKdWLXML6VUtuhVoVumEgKfU33KjTxhACDeTX0YFY2P 2zDhuvtdB3zSN3PqLen9XWHTHmRYsWQtS5DmLO0R+qUVl5hEEGYzb45za+kw3BYdKZZb ph4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YVoLbq8RBXUfihLEoAO2RhgjiaRVSJgl/YQpPYdz058=; b=Ncyp+PvQhfSvQL+oTNIEN1AJ9k35FigkS/2I22WKeL9Jhnjsb2v1H5bLrEdbjY+Oco AKykBFiFV+aMQZEjedHKIPJP1tdvzftL5l5qTpe3nUdg6PeXojC2IkWguytBnMqWM/bO 3FFR4R0uF5yorUhSqa0zJMKIofXD9cCaZ0eMEKDYKPI4yLST2jDsZhKQiVIcHQQcewUt SD6oBUl3vgG1UHh76ordKWZqG0dUsZqZb7uo0dFC82sAr3s9VxC8mrLQR3bB1FRPBHLL ZkarWpVOA/XEidNipPlCz7vpR2kL1FmEjnEjmqCDI+qGXs6nil5vZZ/0PjV4qcFn0iVT knHQ== X-Gm-Message-State: AOAM532vDNgSt19n/UFnYl1TZZtBX2mV5Qs3Z3HgOD5MesCagvzAy8Qe Nqi6sAj9XGl2wL800tMz9loIkQ== X-Google-Smtp-Source: ABdhPJyOl6H0eBdmFimOW38fifNp/S8IZLg8/1blX0NB8KwX5xbBrC5A0cvRaugsDJzcDYhO6id48Q== X-Received: by 2002:a1c:4e0f:: with SMTP id g15mr13424401wmh.144.1616769308209; Fri, 26 Mar 2021 07:35:08 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:07 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , message to , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Date: Fri, 26 Mar 2021 14:34:39 +0000 Message-Id: <20210326143458.508959-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: message to Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/usbkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c index d5b7a696a68c5..d0c640be8a885 100644 --- a/drivers/hid/usbhid/usbkbd.c +++ b/drivers/hid/usbhid/usbkbd.c @@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = { * new key is pressed or a key that was pressed is released. * @led: URB for sending LEDs (e.g. numlock, ...) * @newleds: data that will be sent with the @led URB representing which LEDs - should be on + * should be on * @name: Name of the keyboard. @dev's name field points to this buffer * @phys: Physical path of the keyboard. @dev's phys field points to this * buffer From patchwork Fri Mar 26 14:34:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166867 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB56C433DB for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E32E61A18 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbhCZOfy (ORCPT ); Fri, 26 Mar 2021 10:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhCZOfL (ORCPT ); Fri, 26 Mar 2021 10:35:11 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BCC6C0613AA for ; Fri, 26 Mar 2021 07:35:10 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 12so3096423wmf.5 for ; Fri, 26 Mar 2021 07:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FY6S2XOQI5BNN866n3675udEzH1TqJJkuTkGcMouhCM=; b=ia2sZt4iVeYOTP2LfQDVWQBZ/6HWewnM0yGBM2AU/4Pe0UtMK3nKZOc2gJEAVvAe15 qxhmfAC5pnU8Igr7U378tRR5M2RYwb0glErGgfG4NdynYb1/Z+xjR6rLUTxjAxCQAuQk dxa8M/YjOjm3htK9a9ZMYcrbjy8nItZ60SuRclkwaTA40xwNQRA90KfJdI5pgekLL/Is 5kGQpKXDhc8gQuLZlH6vMOGnNCLK3piGeE8MLG3zLLgDcIOT+puo1Cb9aTIeIjW5UGhL 3s71rMR8Av/MZa+nFKflF0/QFhR/4hOtBW12sm9KI8VhJ4yGhc6Ueh6JUp3xWl0l/y9r jwfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FY6S2XOQI5BNN866n3675udEzH1TqJJkuTkGcMouhCM=; b=WXKzoZH+VqvbZG9sIqCWeE5dglVbwEfTrvZqFEdoXeZdd6+KiAulj/5nFsKGQG5WeB QYcwrzakmmhLnqh1uJjociQpAbkHXxYVGIFLeDWeLD/xa6IVuJi9Ynynq3axnErtrZUN vKzvEhmes/fsxHiaZjcxfyT+U9lu0dNpC7UvPTpropfo86Pn+iyVWtzLSVNRp9IOJlHz qK9DDVXw7/WiGBjUyAZXSy04pnVZB5E7VGqAxetM4ooczxFMFgs7MCMX4fgpwvpUcNCg dSQs8q+0Jgz+8WLcnhSHUTnG7cEetqCpmPNO2aK6hRQzZrpeMJ24Uy5yVTJv0Q1FLPFZ 5SgQ== X-Gm-Message-State: AOAM5302jd7BTUNVIvazInqCvTfTP1fw1mZt/9s4kZM5BzgWkXeF9joZ NTcvHNUKlr2dDF5UbLRnvq6+yg== X-Google-Smtp-Source: ABdhPJwIv3+vhzC+cqzxmfce1IJXzerLfzCwAC57Y2r1nGVwi5Jy41HJ5CoXVxpufIS6PnJBE9X+QA== X-Received: by 2002:a05:600c:4d95:: with SMTP id v21mr2766752wmp.184.1616769309158; Fri, 26 Mar 2021 07:35:09 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:08 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot Date: Fri, 26 Mar 2021 14:34:40 +0000 Message-Id: <20210326143458.508959-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_allocate' drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Excess function parameter 'dev' description in 'ishtp_cl_allocate' Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Lee Jones Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index c81a1f8a92685..585a5c4066cb3 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -111,7 +111,7 @@ static void ishtp_cl_init(struct ishtp_cl *cl, struct ishtp_device *dev) /** * ishtp_cl_allocate() - allocates client structure and sets it up. - * @dev: ishtp device + * @cl_device: ishtp client device * * Allocate memory for new client device and call to initialize each field. * From patchwork Fri Mar 26 14:34:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166857 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C687AC433EC for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B01C261A44 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhCZOfu (ORCPT ); Fri, 26 Mar 2021 10:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbhCZOfO (ORCPT ); Fri, 26 Mar 2021 10:35:14 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C001C0613B3 for ; Fri, 26 Mar 2021 07:35:11 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id x16so5867646wrn.4 for ; Fri, 26 Mar 2021 07:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=FQWiQy0EIE+653fmzj9XU1SF5NMeZNCgs/VV4mo5PT9LyRG571UmXuJauUJ0aL1lsQ 31HG7A3ja6wq0s6hA1qzpq9p/RAo62r0dAKvoUHFRvBJyr4R4GZ46OnKPqEbtmWzAcKa 634knbEo7HgrGK+FcjSGYELCBL1XnOzC+eiEoCU/gWLWFRISxi7wr6FrfE8yCPZPJaQu pSvz3r5gB73TV5rLg+heSe/IcHsdsj8ItZktZAI5J5mW3RX0vDxiVu+22B34cQIJfrk9 odZrgDQ8EtlwoHtFND6OdBiltcah311hZtwgV1F3y0Z2qFULwLJAOvY5jUAnZ35QhkWs zbfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E7/N3FVykAR22YhzUhZ15csg3vPH/3PyPAZDl2mJTyE=; b=U3IenOzrQbR5rcTSFHRkcY1Noj0UAbSw4XhosQ7vAPQJYG6oFNQvq9YmPY9JserQ3f faiBdjP5phf+j6M1SQOgdN4SdS+Y/8PaYYazgfrAqnmCkTjfah1glmB3PaKaltMdm2/I x5Fn3IDS1L2x1hpp6/n9qHuf57uLaGBnYvZBgLItbXm0LxSWHMoDfT4nLz2Difdq2mPU /eH/tbJtFRTZ+pBUTdaZhOeACroKSeqsloyR/Qjvw0YgxCYHbLZbek6RwstPSStpLtQL 4nhJtYckGAJtr40g5iIJzsVC5IGDLkygIffAiS319mQv3wr2VZsgaw1QG0jAfgpudRTP OWQA== X-Gm-Message-State: AOAM532QJki7InUrBLCeDQnNf6kuCXvhl6GwdoUrKVu3hAUIcx9UCEmd DIUXtd/sH+ALppDqX37uJ0uu7Q== X-Google-Smtp-Source: ABdhPJxFiTlqN3F0RkSV5mVncLvGDUsps6SqQ0/eWlY0L1Lcp/6xy75ULVxXD1xv8pgKWF11ZcnP9g== X-Received: by 2002:a5d:6307:: with SMTP id i7mr15081102wru.305.1616769310126; Fri, 26 Mar 2021 07:35:10 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:09 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Anssi Hannula , linux-usb@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Date: Fri, 26 Mar 2021 14:34:41 +0000 Message-Id: <20210326143458.508959-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback' drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects' drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Anssi Hannula Cc: linux-usb@vger.kernel.org Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/usbhid/hid-pidff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index fddac7c72f645..ea126c50acc3b 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n) HID_REQ_SET_REPORT); } -/** +/* * Play the effect with effect id @effect_id for @value times */ static int pidff_playback(struct input_dev *dev, int effect_id, int value) @@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff) return 0; } -/** +/* * Find the implemented effect types */ static int pidff_find_effects(struct pidff_device *pidff, From patchwork Fri Mar 26 14:34:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166855 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCF6C433E9 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7561361A26 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbhCZOft (ORCPT ); Fri, 26 Mar 2021 10:35:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230236AbhCZOfO (ORCPT ); Fri, 26 Mar 2021 10:35:14 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4813FC0613B4 for ; Fri, 26 Mar 2021 07:35:12 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id u5-20020a7bcb050000b029010e9316b9d5so3120359wmj.2 for ; Fri, 26 Mar 2021 07:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7SaTEj4RTZdOjBa5WGjzyPtQsvCc3pHayG7DFxx2S1o=; b=YYE41tgmks1szX8Y1bR3nupGt01CbJK5hySL9qrXdTmsJ7+++1TBQi+K0Q4loXrl+b ggEyIdSV/O3aTSGuQa5gpW7HCNOvGG4pRhlga3TQZ6GMkX/sAdlRXyP7So29PlkBF2QD yqezQFHKwzU5du6L18QCyjIHDfPCi9r5dI7K1r+UzUfR8HJL/1ECB/m0fAmuyuFNRVPA XXIbP7dCYCG1GDyGlSNXgXq/+2Iky09szLpz8JUF49HdF2zvDiaE7+5UH1L7LUGNaUji dkrGaSU9pyZQSI5+GKPeD/1rBCEm29oEZDVb03TfNDQKIMBsFZUBy90umgS2hLs2GHxe bY8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7SaTEj4RTZdOjBa5WGjzyPtQsvCc3pHayG7DFxx2S1o=; b=CGomXNQkJ4B0vTv3k6ZLxIVjXxO+UN26nBl9YTdLsjG32lMJLJ/tv/BYPlR47vImPl qbjRfFynOe+TaV8K1qhquJSV5UV+Owtv7jfWAD6DUwUA4b6x7XWCrB1CRXXoMZctm1Tl hqhObso/oM8iCVdcXGcu4wPrEqb9Rsjegvbl5dSNK7xTOJZV1TBdzsGVqOrwRGp5fjTI LfpYV6NQDJ27PLp6RsEi2/m8o2gIetnWuiAta/RVwUQ5vM32JqBf+NZgrc7bc2rvU99l MKaElDtWJgqdfyLO4ap8UXihntectnqZjBcH//uOJ8sxKl6m04YR5PFpiKmPELgI459d 5TpQ== X-Gm-Message-State: AOAM533R5UajvqyOAHVKF3ndn+VMbHFBSTwFu5rwSa9nDOComHnQRbFi Ndn10n1+WB+LgLaIrH38vrpwwg== X-Google-Smtp-Source: ABdhPJz5f/KrNiqbesoFd5oKM3CYtNcIMzjaUKyZXEZWay2H6+zQTJ7SicPowiz8MnzODgFqK3MLyw== X-Received: by 2002:a05:600c:4a06:: with SMTP id c6mr13421638wmp.35.1616769311064; Fri, 26 Mar 2021 07:35:11 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:10 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Henrik Rydberg , Masaki Ota , linux-input@vger.kernel.org Subject: [PATCH 09/25] HID: hid-alps: Correct struct misnaming Date: Fri, 26 Mar 2021 14:34:42 +0000 Message-Id: <20210326143458.508959-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-alps.c:113: warning: expecting prototype for struct u1_data. Prototype was for struct alps_dev instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Henrik Rydberg Cc: Masaki Ota Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-alps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 6b665931147df..2b986d0dbde46 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -74,7 +74,7 @@ enum dev_num { UNKNOWN, }; /** - * struct u1_data + * struct alps_dev * * @input: pointer to the kernel input device * @input2: pointer to the kernel input2 device From patchwork Fri Mar 26 14:34:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166865 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FD9C433F4 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DCDE619F2 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbhCZOfx (ORCPT ); Fri, 26 Mar 2021 10:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbhCZOfP (ORCPT ); Fri, 26 Mar 2021 10:35:15 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5ECAC0613BA for ; Fri, 26 Mar 2021 07:35:13 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id k128so3095433wmk.4 for ; Fri, 26 Mar 2021 07:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gK4GBHDnYjUKGItp7Cpn1OqRPa6zrE034rZiLZ47Q+0=; b=FQgVhM/HPmIVSaTR75VGvplCpT7A/KPgSILda5lhc4gG8cVL8wV363q2YP+MKT6ofS qtp1/el3hpW/j7iCBAJnS61kbgUgdf/9XFnERQE32l8LoSMOY8ri5jNb36Tot+BIOwNQ xlCPwO2nXo6Bi2SF43RlOTlky0nw+kpPePRZYzYf4SaMuO+8wCOIM7DUUTUGCTi4qmAn LIpeeZtt6Bv3HMyZIWAsnwhGUHc7Azqyr0+o3nWqO1YNp4t61K4IgTQCWCOHrlHaYzC+ 22caIlgT+ccj+M1xjj3O2lfz+JDBIMpb6YzfdPO4TTHt2TTtEM7c97cPEigXlYbQsCoJ Kg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gK4GBHDnYjUKGItp7Cpn1OqRPa6zrE034rZiLZ47Q+0=; b=Klb5d1Z9XPVexp4L77OatrAvdQZ/SL+65oJPFzISKERELtaEji7F5psHJyCZ4AXwhf piIc0KqDPs9F4v0JUx6dwW3pNiqegd+q9RF2nUWNv2363FzNsZNus8SEWcIhMkElZP+8 F4mEoe8M1WoAUk5OtyBtvBH+7lVCUOFNzkQyhXmh1J2k8MsEPYKTdbFHTu1qQCtlBEaB Imn6EiafEMRHIzL6BVlqKkJ1PhyvJ1J6srga0SYm5Ey4eHZIFWo0BtbJas8VJew7gQgw MgSXU2XKdSWiu6jlGfUvXLyBE4wEhMEr8UoUTB7xPktwbG6xyggBvq6GKo3hmpsj8AJW zbPw== X-Gm-Message-State: AOAM533YZqUnP5/NeX36todr6+iqM8SCwwaY7RVuhR3jnpmUTo7OdUKH Oyy5WwWpB94Eci3O/ezuzJr1EmycOu+bTw== X-Google-Smtp-Source: ABdhPJw+y6RAQUFh0yOSkeayDQx3lR4W+C9cJD48v/0NkLQc6flNcqartCxarA+D9tpVMmL5IMFB7w== X-Received: by 2002:a05:600c:1553:: with SMTP id f19mr13397053wmg.33.1616769312057; Fri, 26 Mar 2021 07:35:12 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:11 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error Date: Fri, 26 Mar 2021 14:34:43 +0000 Message-Id: <20210326143458.508959-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.c:263: warning: expecting prototype for ishtp_hid_probe(). Prototype was for ishtp_hid_remove() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index 393bed0abee99..14c271d7d8a94 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c @@ -254,7 +254,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, } /** - * ishtp_hid_probe() - Remove registered hid device + * ishtp_hid_remove() - Remove registered hid device * @client_data: client data pointer * * This function is used to destroy allocatd HID device. From patchwork Fri Mar 26 14:34:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166853 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C4D4C433E4 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34E0461A51 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbhCZOfr (ORCPT ); Fri, 26 Mar 2021 10:35:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhCZOfP (ORCPT ); Fri, 26 Mar 2021 10:35:15 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6636C0613BB for ; Fri, 26 Mar 2021 07:35:14 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id k128so3095453wmk.4 for ; Fri, 26 Mar 2021 07:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dvVvI/0Wq9ZseHcmz0Zvsivscrc/Hml5KLcDLhGdq8Q=; b=smSaR1uiakul9vdqFvb9YgWh4OKhF08d0JzTod+aEWKDwhNZ6k/TlFu7fQQqBT/dNL 6v/A7fm6GfMpe1sLSb3EOLBAxdueMEarsWLtFaCtU5JUSVMjEmHFyKdqt1WwyIfLZBFC o/RIgx+ip27kU87XZiVWR7sSNx8PtdFMEXAtBqJwwBvvif8G7FYB9hFXSaxYfZv3wFOY Ak0PH0KPxED+JSpAW5hJVgI41p8fGlU8WLrOXbY/qA8C/WOyo35qSHuKPjRknUvLFRTt O4yNxlLhO4pMB7I0jrLUgLcp+yGCpYZgrK0PvCEzx3eAI4/TKVw/LN9y+cEO0LRdjpWc kefg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dvVvI/0Wq9ZseHcmz0Zvsivscrc/Hml5KLcDLhGdq8Q=; b=t/BV2/tAb/kVimTKETcymmdngRjiQxETYuQMwIq7ocRyKRGPj/DGn57y6W/ZeAa4gu p+ew9Thkbk7HoO5p9s6xuStbsK0OSr/vVEZ7bS4BedJr4WeIvwEEO6//JAHJfou7+4aZ o3sEcA6qLE3ysWdDZlK2UwrmIXpYBrFQNfF9iXeSSKZySGuz5MeaCY+qPVXF5wWoWncr gDnL16iap1V+WO3/MietBQb/mfrYJMen6u9+gOcVS45nsQxJhciQ72Fjy6MOuw9xWh7v 2U2ooXE3Hydohs1uztJhd3v6aaBlrMN7BqxCsrMv9yIlqYvhaYTt0dsece6btUUaZALb FdXQ== X-Gm-Message-State: AOAM533XhaLEoLsW8AmF6QW/755dqlRgAQBe261BabQyxemaSiLS9EfF ZkBoh65q3/YcJgWf6QE4MmHhcQ== X-Google-Smtp-Source: ABdhPJy4cPgeUtt+hXmAcmdBV050qDTDvNCgcfFSBylDcvsoPURbP7UhNazAD0cKIvwyFp+F1SIuHw== X-Received: by 2002:a05:600c:19d1:: with SMTP id u17mr13278235wmq.141.1616769312972; Fri, 26 Mar 2021 07:35:12 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:12 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Vojtech Pavlik , Michael Haboustak , linux-input@vger.kernel.org Subject: [PATCH 11/25] HID: hid-core: Fix incorrect function name in header Date: Fri, 26 Mar 2021 14:34:44 +0000 Message-Id: <20210326143458.508959-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-core.c:2142: warning: expecting prototype for store_new_id(). Prototype was for new_id_store() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Vojtech Pavlik Cc: Michael Haboustak Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 097cb1ee31268..0ae9f6df59d10 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2129,7 +2129,7 @@ struct hid_dynid { }; /** - * store_new_id - add a new HID device ID to this driver and re-probe devices + * new_id_store - add a new HID device ID to this driver and re-probe devices * @drv: target device driver * @buf: buffer for scanning device ID data * @count: input size From patchwork Fri Mar 26 14:34:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166863 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD8FC433F2 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9E7661A33 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbhCZOfv (ORCPT ); Fri, 26 Mar 2021 10:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230250AbhCZOfQ (ORCPT ); Fri, 26 Mar 2021 10:35:16 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74894C0613AA for ; Fri, 26 Mar 2021 07:35:15 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v4so5828828wrp.13 for ; Fri, 26 Mar 2021 07:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ncO0eu8eiprdEfj3NwDMj19+723Jp3QnJo+qgAuvBoM=; b=D3M2AflPHYIVQMrCYBkEBM7J18KaEGT7snF1NuKp19oo6CWsWqMxQru/X11H8JFLJf iKXohymfei2sqRC9xr8JGOW/+ZJnKaZSTQ7Xjz5eArm2BCn6ViNEFpZJqK07fmo2bAgU YKZFlVVbl3rCUQ3gyzOBfY08LbvTmfcmiSxKk1SI88TrivNerJt+P3OHDJ2Q0VLDZv1w pOIn07GzR4TtY/7hZz7Qo9yFe3twde1MGRfah/U+Y+E5QVALf9ToIZNlUTYJb1MKdSM5 nKB8rcFDa4LhBrAo53pl7QB1sKnaKJkaQWjTySXoc3sloRYTlNefcQ2ITRKPldgKAFgX ZqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ncO0eu8eiprdEfj3NwDMj19+723Jp3QnJo+qgAuvBoM=; b=IwTxkSkTrj+nj4EnkcwWuG8KYVic89t7ig/oGPhb1r5TL7XEDIIQxLVWGqtOQPGLel AXFhS4ZsNCo+Ar/tKnOecK3oFso82E8BHsg21IvU4fKEaaB9t9gBt5ON1EnYVtZP1BX7 qZRTnMYcksem2MdizpVR50bKsJc4k3dXq/hLSBaaLca5Z/Wn/JdQdfi2JQIBbMnT036z eF2dO6a9Y2WCiImWite4cl5ndEM3cJ8mAf1R24gM230prBIbNKzNsIL8CsCf+NDpXyF0 yTJeM2fNmCqGzD9sA/OIDgAagvw/aeeV+9F8QuELuXi3/4PJi+jH+AKqdxdWzt5cX806 nrdA== X-Gm-Message-State: AOAM530BZbU78Y+s5p7LmNX7B0tPMhY9spzqRp51CRlnFO+1SFQ7x5ZQ 6QCUCqMhwrO48kQqI+SBuFC5ag== X-Google-Smtp-Source: ABdhPJxyz85Q/+mRvHz1FDY3Yxoego7N1UdFt2rgIPb7W9U3d8zDHFD6Hu4HykqzJPVkIWwH5f+XhQ== X-Received: by 2002:adf:ea0e:: with SMTP id q14mr15168379wrm.389.1616769314240; Fri, 26 Mar 2021 07:35:14 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:13 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Zhang Lixu , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-input@vger.kernel.org Subject: [PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header Date: Fri, 26 Mar 2021 14:34:45 +0000 Message-Id: <20210326143458.508959-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ipc/ipc.c:553: warning: expecting prototype for ish_fw_reset_work_fn(). Prototype was for fw_reset_work_fn() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Zhang Lixu Cc: "Krzysztof Wilczyński" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c index 47bbeb8b492b0..9037816e2bf74 100644 --- a/drivers/hid/intel-ish-hid/ipc/ipc.c +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c @@ -544,7 +544,7 @@ static int ish_fw_reset_handler(struct ishtp_device *dev) #define TIMEOUT_FOR_HW_RDY_MS 300 /** - * ish_fw_reset_work_fn() - FW reset worker function + * fw_reset_work_fn() - FW reset worker function * @unused: not used * * Call ish_fw_reset_handler to complete FW reset From patchwork Fri Mar 26 14:34:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166861 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EADBC433F1 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C0F361A2A for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbhCZOfv (ORCPT ); Fri, 26 Mar 2021 10:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbhCZOfQ (ORCPT ); Fri, 26 Mar 2021 10:35:16 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60982C0613B1 for ; Fri, 26 Mar 2021 07:35:16 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id v4so5828875wrp.13 for ; Fri, 26 Mar 2021 07:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NJdO66bBiMjdzl40aPWSxjSxYbd7b06CD4GwxwSgEOE=; b=oVXBaSdzja21bLFS3YKojWhTspCiskPc7lUKekQuR/j9cR93Rwf9uysg2BjcZ9Z27U B2l2s8IIwAWFB9C6ncYz2DkG/DlgonSbi6LFDvDJmr3Z7alQ+o/MBmqKjBqPl37tfoa2 1CupoabpsVd65MqH4Dl7w+RpMtLyfAyhy/9HLpFOYkyHlJHUIeNaKZx9t+HMITZB3SNn 0qz/FJ0oD8bMBp9FGdQM/L2GiSPZLmMhklY/0ICvm6qU3H0nguYmjo77q4Ouk9K8obdN H/0MNhsikXBVl+w+KDM2jil8AJNJNsnjLShkFp/mfm+N9EjAkk7WoDDped3QJxIqXg8O H8sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NJdO66bBiMjdzl40aPWSxjSxYbd7b06CD4GwxwSgEOE=; b=LXrVWfGW81Zl3s66YKV/ZqmHEVcu9RqwmJtc/A3C4TmReNv0rxmI7FsNipcidRqG+P CnQ5RXeI8nlgkO0SemjzAYvreHqsoOW0g/Q2s6WedLt6ylCh1buCRH7tulNUK7mgQj1n nHnwLmih1nXN+6tuLFqI+0tVZc9eDIHxD6d+uUr1XcMy75yu2SHUkrhCS20PBFGGwjky Ev+5fy+yZbrkGOHaxkgtfQxF1PVFwRCo7ojDDrh1XaRTKI+L4RjgmTZertaTKyDtzu58 L80Ev3nlvuvT0AyPKtuTXpr26XU40fDukyPnzjJ7UMkn4nw2O3U56IzQrcqyS4Pf5T6U VlFw== X-Gm-Message-State: AOAM530zGXMhOOEOZTNihZwHIUEh/Dh5wagj0JAnu6oN/u/v0XSSZCr9 QVxHtE/G0v/4OnAdWM98KzcWlw== X-Google-Smtp-Source: ABdhPJzcEyClgXLnv43H5eGGmUS6hcRJB94AGPu07sy9CmEwQHq2sO2bCC6k/4Kduzrxiv4bqTNuTw== X-Received: by 2002:adf:90f0:: with SMTP id i103mr14537444wri.318.1616769315151; Fri, 26 Mar 2021 07:35:15 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:14 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() Date: Fri, 26 Mar 2021 14:34:46 +0000 Message-Id: <20210326143458.508959-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp-hid-client.c:36: warning: expecting prototype for report_bad_packets(). Prototype was for report_bad_packet() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 24599280105d8..042a7091802dd 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -23,7 +23,7 @@ static const guid_t hid_ishtp_guid = #define cl_data_to_dev(client_data) ishtp_device(client_data->cl_device) /** - * report_bad_packets() - Report bad packets + * report_bad_packet() - Report bad packets * @hid_ishtp_cl: Client instance to get stats * @recv_buf: Raw received host interface message * @cur_pos: Current position index in payload From patchwork Fri Mar 26 14:34:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166859 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A5DC433EA for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C61761A27 for ; Fri, 26 Mar 2021 14:36:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230442AbhCZOfu (ORCPT ); Fri, 26 Mar 2021 10:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230271AbhCZOfR (ORCPT ); Fri, 26 Mar 2021 10:35:17 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE72C0613B3 for ; Fri, 26 Mar 2021 07:35:17 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id x13so5846109wrs.9 for ; Fri, 26 Mar 2021 07:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KfriQXFxUvhVGCpwETjq8GWLI1DKoZwsNAe/TYwrv1c=; b=ghIHk4GlZC5aYoLhvt/vuXGDzZlXns6m03U+T+WQOjnWn3ugz7Ej4YW3+deYR8DsMA n+YGcWCNvi43WQTC9g7YXw06COmnX7WyhwPzxBMmtrIO7D+Jy2ytxAE25eKBk46iealD c7e62MRFOGZDcedmuGN+fVd3P+li++rQWVKh0EPF/v6oSjAdj3dnmfPoQ5O1bKG2p+te pUdTld+oLQRnI+EHKdqncsJgVKrH3aPx+tIDTr/5EkDpAOjY44d1NBUMRclWSyEoGOuw fPR0Jjmj7uiVemy4FRowu4BS4JeBY7qmPLAPBOvV+6QaRGPE+GXuLTJt+Qiw2iU8Z/pl yPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KfriQXFxUvhVGCpwETjq8GWLI1DKoZwsNAe/TYwrv1c=; b=QvgPWjhmNCUAnpivbCRJBpMPye3d+a61ds8Sn4/JdW+0Xb7Pt9ntKc9AeQTzXI5w6K 2nFOthWH21G6yBbgm9L/ITDc2BV4ej4PgEEmbplYrUqH9ze3l3jZlRPDwSaaeiFOx7vl IkYhnwbheYZ4TBMtJQu6/rBupww1Goso1dnviVZfb1D4zjaXoBinMzEFiEdZI+xz/ndK 57NYhheMVJkM1h3vdALVCQRZjzI9gkpw8UdLtIZu0+wT3WMMpVxnGW5A8OZUc33GNv+i CcKMCKB2Rz+dtkPiqmuvXDUXias+/8fgIiEf0dMNBytAcm047hsm+2n7yTUf0N3pMbd/ QeRQ== X-Gm-Message-State: AOAM531Ji7La03QgdeKefYfxIEc7zYtGiMgpGtJLuzBBgAkisYa1P9K6 E6kfmALRcic4fXO4oWxl6k00kw== X-Google-Smtp-Source: ABdhPJxeseGkHowzWx525L+U0ZeaNPO56s/H9Fg/4iQEmMjylJLcsFebVgK/pjc7GkHSOBZmAo9uoA== X-Received: by 2002:a05:6000:18cd:: with SMTP id w13mr14717926wrq.20.1616769316045; Fri, 26 Mar 2021 07:35:16 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:15 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable() Date: Fri, 26 Mar 2021 14:34:47 +0000 Message-Id: <20210326143458.508959-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-kye.c:666: warning: expecting prototype for Enable fully(). Prototype was for kye_tablet_enable() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-kye.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c index c8b40c07eca69..f46616390a984 100644 --- a/drivers/hid/hid-kye.c +++ b/drivers/hid/hid-kye.c @@ -655,7 +655,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc, } /** - * Enable fully-functional tablet mode by setting a special feature report. + * kye_tablet_enable() - Enable fully-functional tablet mode by setting a special feature report. * * @hdev: HID device * From patchwork Fri Mar 26 14:34:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166871 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80343C433FB for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D82F61A3F for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230465AbhCZOfz (ORCPT ); Fri, 26 Mar 2021 10:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhCZOfS (ORCPT ); Fri, 26 Mar 2021 10:35:18 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C315C0613AA for ; Fri, 26 Mar 2021 07:35:18 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id j7so5896143wrd.1 for ; Fri, 26 Mar 2021 07:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=rhuQcSAmr2qobE5MLtzwGEi0Lr/Y4/8iBHF839/53MF2Y9lFQ8GQCe+x75wrZgsaAb LMgYAGmQsYZiHJpvm/vSh8fcstZ+DFoaGyOUuXaT0cP+EsWE1v4/JdDHvgDy+DOYGv5M YYcUQfeJq1REa1KWNc+wm6CuQbE9ZF5o79O0SwBP2m3L9QLTrcO1HVJPhQbXEY7pJ7qW 3jprm3kXueIE5fFH1JsBSfeNzWZTnvfbivyVhNtP1bANq+VAhso2JPqVVREHvmNpEwfE +unXLRSzUoiys9tWkPjK4aKv0SmMFZBvt96R9lTaj4rHBbpeNVu2PZlfevGLXEkVaKqJ pdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NvG+DHxLWGqXLwCLHTxA35O2VaR78VX0X5hX1fU7v18=; b=gZaikoREBhmKEc+nTPzDAHtMTGC4pLboIi5vmw2SyezbwOHzBLNJQdaE90/1bDaQER IVJ5W4UzVUauhvSJy5ExmP+7OoixmrulapzCenFqvOLhmW++Q/oWP9y4dbZm1adjPO/T egdNPmXWZvKsaeoLvoi7/8OWv5+BoVhx2tAZOcQINiRgZBdUwrfOxX1oGV4MC3gzuWbM rEuAUH5d2ylGX8S+kWnktuovvzaCA1pxgW3xOzHXmotXs/NHskxTZkhDphODZkt8+Lr/ H47vmqO9vyEuvjfFsHtcJcjXRoNu7rMzVoidyWx9kW7sKCX2SJJlTSKIepMpn0DPYu+N DYeQ== X-Gm-Message-State: AOAM533PBYao+hTtalRLrIc+6aR+VGG7ejo9R5ojBEKmdQalXirt4xr1 6njw0zQVrhV5fKNhuUI7gcZcmA== X-Google-Smtp-Source: ABdhPJzgKpsg9ZVy78ChKXvRowZScKs621lCXY6MP2Gg/TMjc06X/cYy+pFccB0s4qBADlRtz+WTDw== X-Received: by 2002:a5d:4688:: with SMTP id u8mr14801801wrq.39.1616769316887; Fri, 26 Mar 2021 07:35:16 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:16 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Bruno_Pr=C3=A9mont?= , Jiri Kosina , Benjamin Tissoires , "L. Vinyard, Jr" , linux-input@vger.kernel.org Subject: [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret' Date: Fri, 26 Mar 2021 14:34:48 +0000 Message-Id: <20210326143458.508959-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’: drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: "Bruno Prémont" Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "L. Vinyard, Jr" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-picolcd_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index 1b5c63241af05..bbda231a7ce30 100644 --- a/drivers/hid/hid-picolcd_core.c +++ b/drivers/hid/hid-picolcd_core.c @@ -329,7 +329,6 @@ static int picolcd_raw_event(struct hid_device *hdev, { struct picolcd_data *data = hid_get_drvdata(hdev); unsigned long flags; - int ret = 0; if (!data) return 1; @@ -342,9 +341,9 @@ static int picolcd_raw_event(struct hid_device *hdev, if (report->id == REPORT_KEY_STATE) { if (data->input_keys) - ret = picolcd_raw_keypad(data, report, raw_data+1, size-1); + picolcd_raw_keypad(data, report, raw_data+1, size-1); } else if (report->id == REPORT_IR_DATA) { - ret = picolcd_raw_cir(data, report, raw_data+1, size-1); + picolcd_raw_cir(data, report, raw_data+1, size-1); } else { spin_lock_irqsave(&data->lock, flags); /* From patchwork Fri Mar 26 14:34:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166873 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941C7C433F8 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DE9661A24 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230475AbhCZOf4 (ORCPT ); Fri, 26 Mar 2021 10:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhCZOfU (ORCPT ); Fri, 26 Mar 2021 10:35:20 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12966C0613B1 for ; Fri, 26 Mar 2021 07:35:19 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id j7so5896213wrd.1 for ; Fri, 26 Mar 2021 07:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GplnaeoWUVj8YBA4hvKiO7ws+s2Csp6NEYWiX1mt5gw=; b=gVdY+BmiCv/le2JaAaXRNqHZOQ8FZPr77309AVj8qiOYOzB9wwc47ATRvKul6T1NMP sMaB3udcySV2cCjdqJ+8S5gvcJc3cwMtvek2Yk+zte3A4Y5Aaj/ttoXO3Qr21eXHsXJA +KdCKUwMY0faf8nInYF4e1kbRs4brqRmeIOnZlnjfKkG/qyrE6QM9dnZzCyN9HBJgWJN FJXL/foszoatEtn2KABcnNNi7sO/40iEDJyYspDOT49dQK7vkAARyAa/cmJ1OOu5nL3n uD9m3g8oT8AP+dNSMQqA2EpjCgMPx6HrRIzZn0KNGPvstVJZBts/2fvzmcDZc0zKfAI5 O4nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GplnaeoWUVj8YBA4hvKiO7ws+s2Csp6NEYWiX1mt5gw=; b=YDGxIVdaRJoaBGH3QlmMjD7DOCn/AzaGjARuz1Bf8+PexXA3A3HTTeYMZXmA7XbtzR tCJklinGIw/IFyuQZkpthBawNQ5GUSvCaaSbkTn0+tDpjptNVUGSNGlTiZq5E5L83iSW rj/X0lX/AeV4YGDn8LAGPdZCniQ4gh9AxhahBmjpHQtjy5PSRrWym6zFp6nb7AxAlfdB knSlbnLVBmFaieeCYWqm5tpKjqMyfvkQq4/K7tQ6V5NgjzTrOpL9oQX7mWzs9O/FDTAq NeQLfCGUalOt/Bzwh4GXFvL9RBj0jrRr6eXZIp9p/2/+8PEUCr4dLuB9qfJ6sZUVGyac OQdg== X-Gm-Message-State: AOAM5311wXidgKtG6Bvu3mP83orSL0+/6Kb9yMW1AyYTBYvPa+CM9DaV aipU06+FpLr3IqlPanw3aJQH5Q== X-Google-Smtp-Source: ABdhPJxrW/9zfhqyJX4I2dQcZ7VFapl1sAqOLChKrPCi63yz44kL11ViapqAsr1hJOmqk6421X27uw== X-Received: by 2002:adf:fa8d:: with SMTP id h13mr14798114wrr.331.1616769317753; Fri, 26 Mar 2021 07:35:17 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:17 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Henrik Rydberg , Lopez Casado , linux-input@vger.kernel.org Subject: [PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses Date: Fri, 26 Mar 2021 14:34:49 +0000 Message-Id: <20210326143458.508959-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'hidpp' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'message' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'response' not described in 'hidpp_send_message_sync' drivers/hid/hid-logitech-hidpp.c:275: warning: expecting prototype for and something else(). Prototype was for hidpp_send_message_sync() instead drivers/hid/hid-logitech-hidpp.c:427: warning: wrong kernel-doc identifier on line: drivers/hid/hid-logitech-hidpp.c:470: warning: Function parameter or member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'hidpp' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'feature_index' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'items' not described in 'hidpp_touchpad_fw_items_set' drivers/hid/hid-logitech-hidpp.c:1894: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Henrik Rydberg Cc: Lopez Casado Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-logitech-hidpp.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index d459e2dbe6474..d598094dadd0c 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -261,7 +261,7 @@ static int __hidpp_send_report(struct hid_device *hdev, return ret == fields_count ? 0 : -1; } -/** +/* * hidpp_send_message_sync() returns 0 in case of success, and something else * in case of a failure. * - If ' something else' is positive, that means that an error has been raised @@ -423,7 +423,7 @@ static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp, (report->rap.sub_id == 0x41)); } -/** +/* * hidpp_prefix_name() prefixes the current given name with "Logitech ". */ static void hidpp_prefix_name(char **name, int name_length) @@ -454,6 +454,7 @@ static void hidpp_prefix_name(char **name, int name_length) * hidpp_scroll_counter_handle_scroll() - Send high- and low-resolution scroll * events given a high-resolution wheel * movement. + * @input_dev: Pointer to the input device * @counter: a hid_scroll_counter struct describing the wheel. * @hi_res_value: the movement of the wheel, in the mouse's high-resolution * units. @@ -1884,7 +1885,7 @@ struct hidpp_touchpad_fw_items { uint8_t persistent; }; -/** +/* * send a set state command to the device by reading the current items->state * field. items is then filled with the current state. */ From patchwork Fri Mar 26 14:34:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166869 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E5FC43381 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4170461A05 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbhCZOf5 (ORCPT ); Fri, 26 Mar 2021 10:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbhCZOfU (ORCPT ); Fri, 26 Mar 2021 10:35:20 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F74C0613B3 for ; Fri, 26 Mar 2021 07:35:20 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id x13so5846236wrs.9 for ; Fri, 26 Mar 2021 07:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QyPG1WEqZFTBuDaWcANV4HkcWu30kB5AaRBOC44dMcU=; b=SnsafZq5e1+1/iZIm3WR65o+iG0/ODTGJk/7ETvhgN7CEu5HRWnJNdVg40nfYqWfbO UrEREZCk+q7udUP3bSU6brrWo0DOtTSI3CB7EiYpN7gXdmEQcOckMpy98SbOeP3fhTgr trT8s1skyIzCkbNsKuVRNWDT7iRn2yQlM1ci7v5Os1fDRxy7vdC+plqlnzyIRaik7+RT 4xpRSsPSu0x+pBNYHgzwq9UqGThUsue8SOorkldDqqlMvWOgRYoWeyT6Chmu5UpbBFs0 0Zwt3zL3d5AtE3n/fveorFHLgLuj2uawCORzzBqxKqvgx5bom7hWgYbrCOUIg5c8XKih BU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QyPG1WEqZFTBuDaWcANV4HkcWu30kB5AaRBOC44dMcU=; b=UiWTU+FPvpkhaUk9BZNSR6Z889X2LDgWqFZMnCqUX3op4za3aJaKHT/TvARmgeDA05 VOXhqw58nXvciBLgacj4CBsNYvpTODGcPpPla9DiXM/uK6gQ6XaD8bKgeXJQG/uQVYVh zkszRVaNaFzjkp+T2du2isVO7szxRwF/LB9jhgyAKEsm1cqRrNrUtwFTUmruWb9uUg64 qOA/UqsOtR3xebK4ooF8/X0CggpvHvAjPsX41tEZHhT2WZiMRcTi3gw6D7h9Q1YAMSnK 4ZMucMtoRTJnn5Rabiu9ixjo+hQsG9W0OtNs2Nvd5+g5eCuBoNeMKLr8wwwmXsYBWrxJ 3nPA== X-Gm-Message-State: AOAM532Z3N1Yzhx1WE7j6JEyRV4qrYb/d36fVmZUqTeWDsssBpmiXAoV UB1zo28LWA03pzx1RH5vdk025w== X-Google-Smtp-Source: ABdhPJwOUj3cYauEQvI4kOqQkvYnSogsSqs1r7Xq61RvYSr9UXt0UirtesVDyK9o5Z5ECViF7WsNeg== X-Received: by 2002:adf:ef4c:: with SMTP id c12mr15089412wrp.112.1616769318787; Fri, 26 Mar 2021 07:35:18 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs Date: Fri, 26 Mar 2021 14:34:50 +0000 Message-Id: <20210326143458.508959-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-uclogic-rdesc.c:645: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-rdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-uclogic-rdesc.c b/drivers/hid/hid-uclogic-rdesc.c index bf5da6de7bba9..6dd6dcd09c8bc 100644 --- a/drivers/hid/hid-uclogic-rdesc.c +++ b/drivers/hid/hid-uclogic-rdesc.c @@ -641,7 +641,7 @@ const __u8 uclogic_rdesc_pen_v2_template_arr[] = { const size_t uclogic_rdesc_pen_v2_template_size = sizeof(uclogic_rdesc_pen_v2_template_arr); -/** +/* * Expand to the contents of a generic buttonpad report descriptor. * * @_padding: Padding from the end of button bits at bit 44, until From patchwork Fri Mar 26 14:34:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166875 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CA3C433FC for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95E3661A18 for ; Fri, 26 Mar 2021 14:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbhCZOf5 (ORCPT ); Fri, 26 Mar 2021 10:35:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbhCZOfV (ORCPT ); Fri, 26 Mar 2021 10:35:21 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13CB9C0613B1 for ; Fri, 26 Mar 2021 07:35:21 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id x16so5868170wrn.4 for ; Fri, 26 Mar 2021 07:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5ncqrjTAWBMAuIT+QNk4MgUhfbKLtj8kt+uo2wlM/dg=; b=weMDUSGRSCQGL4pgXx8iQgbzg5Nye4DqunH91ALPfVpL5kE61ywzM7VTxlg2W7Es4D oNQa61mKg+gtrY4ryXcuLjSNGXUo582RhCNDzKcAWTNYnZqo+iEGaTZB7ODutah3VICz +ev6t1uq/xB+BZt0yxA4rdMu4uEmmHNJS57KeVoZc+ZBZsfg1oYGKCBVStk7iWMD2no/ 0gFlTPKYmzJ6xHMKfMj+hVG4nuYcjMFnEMqeDwgoqa5NpL46gHUhKu04TXjeijAwJaaR 7EMiJjqTZBorv+b5NJvNcnTGRJA4riENhLqjOa0iZosr5fYSrUcJlh13WbZxUGjW+fLz Pbrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ncqrjTAWBMAuIT+QNk4MgUhfbKLtj8kt+uo2wlM/dg=; b=TznThZ0f6Y8MugK3oHJTvMZiaHB1+0/9nMhlZC6+CZR59k6Qb0N9lPh+Srf7MN7QuF 0Di8jSq/Co04vk72LNVnvTCdN02mYsAJRu4VD1xLCZIELC7vemlLDZk7SatfvOyP69or ZOwZ5YwyKK0hZSpWeNolVY569iin8EskD61kun+cVXfcQVBFErxrdsfFFOfCo2bFnywv Fe8HeaOpkgMvlHf/TXbOzPrVTBTeeiirRh0rXe5Fr03bd8bkLjOVc5pwX6aBsiRJtrQE HuCR8JaN4ojgoUABRtVh4hhg9xXitY0u+kUvApYcqOcB3GfZ+6XTc1xkHzNWZdY/Hl1E EltA== X-Gm-Message-State: AOAM532lk6VcT5LQ2/aJqNTPuFnl3gC8jRGMsT50OqzfqzcHNZY7ioBw QQzvpAEDfonsYwU9LYMPgsyKfA== X-Google-Smtp-Source: ABdhPJxmQkgaSlZ6BYyWv6tZwjthp9lMrPlua6NXOhA6VZmavOYOxv6tr/znawI4FNqHcL2lE7SBRQ== X-Received: by 2002:a5d:6307:: with SMTP id i7mr15081805wru.305.1616769319829; Fri, 26 Mar 2021 07:35:19 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:19 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Maxime Coquelin , Alexandre Torgue , Dario Pagani , Kim Kuparinen , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Date: Fri, 26 Mar 2021 14:34:51 +0000 Message-Id: <20210326143458.508959-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = ' drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info ' drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line: drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response ' drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line: drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler' drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line: Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Dario Pagani Cc: Kim Kuparinen Cc: linux-input@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones --- drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index bfcd08759ba09..4f9c0642e816b 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * When connected to the machine, the Thrustmaster wheels appear as * a «generic» hid gamepad called "Thrustmaster FFB Wheel". * @@ -19,7 +19,7 @@ #include #include -/** +/* * These interrupts are used to prevent a nasty crash when initializing the * T300RS. Used in thrustmaster_interrupts(). */ @@ -36,7 +36,7 @@ static const unsigned int setup_arr_sizes[] = { ARRAY_SIZE(setup_3), ARRAY_SIZE(setup_4) }; -/** +/* * This struct contains for each type of * Thrustmaster wheel * @@ -49,7 +49,7 @@ static const unsigned int setup_arr_sizes[] = { struct tm_wheel_info { uint16_t wheel_type; - /** + /* * See when the USB control out packet is prepared... * @TODO The TMX seems to require multiple control codes to switch. */ @@ -58,7 +58,7 @@ struct tm_wheel_info { char const *const wheel_name; }; -/** +/* * Known wheels. * Note: TMX does not work as it requires 2 control packets */ @@ -72,7 +72,7 @@ static const struct tm_wheel_info tm_wheels_infos[] = { static const uint8_t tm_wheels_infos_length = 4; -/** +/* * This structs contains (in little endian) the response data * of the wheel to the request 73 * @@ -82,7 +82,7 @@ static const uint8_t tm_wheels_infos_length = 4; */ struct __packed tm_wheel_response { - /** + /* * Seems to be the type of packet * - 0x0049 if is data.a (15 bytes) * - 0x0047 if is data.b (7 bytes) @@ -93,7 +93,7 @@ struct __packed tm_wheel_response struct __packed { uint16_t field0; uint16_t field1; - /** + /* * Seems to be the model code of the wheel * Read table thrustmaster_wheels to values */ @@ -122,7 +122,7 @@ struct tm_wheel { struct usb_ctrlrequest *change_request; }; -/** The control packet to send to wheel */ +/* The control packet to send to wheel */ static const struct usb_ctrlrequest model_request = { .bRequestType = 0xc1, .bRequest = 73, @@ -139,7 +139,7 @@ static const struct usb_ctrlrequest change_request = { .wLength = 0 }; -/** +/* * On some setups initializing the T300RS crashes the kernel, * these interrupts fix that particular issue. So far they haven't caused any * adverse effects in other wheels. @@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb) hid_warn(hdev, "URB to change wheel mode seems to have failed with error %d\n", urb->status); } -/** +/* * Called by the USB subsystem when the wheel responses to our request * to get [what it seems to be] the wheel's model. * @@ -261,7 +261,7 @@ static void thrustmaster_remove(struct hid_device *hdev) hid_hw_stop(hdev); } -/** +/* * Function called by HID when a hid Thrustmaster FFB wheel is connected to the host. * This function starts the hid dev, tries to allocate the tm_wheel data structure and * finally send an USB CONTROL REQUEST to the wheel to get [what it seems to be] its From patchwork Fri Mar 26 14:34:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166885 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D6AC43446 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 507E561A26 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbhCZOf6 (ORCPT ); Fri, 26 Mar 2021 10:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhCZOfW (ORCPT ); Fri, 26 Mar 2021 10:35:22 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34939C0613B1 for ; Fri, 26 Mar 2021 07:35:22 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id x16so5868228wrn.4 for ; Fri, 26 Mar 2021 07:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xh7i5Zt9zY8KA4+yMY4ctmVEgG+7w746xU8n69jbbEs=; b=fLcj8t4LYR6hRhlXGoJbtXpS9AeaTkfx75kb7h/IAQkN9bkwczcfHP3SpsfBobIXv2 8Txb2yVtWky8UpSkBZnd4SoEHbYDnOY2ZHvtSLUfONx2PLo5jiUbNcBHM/Ultuq53wNb /qzmdvlfRUM5xz2gx0M0FVisLXL6vDI3xqDjXzFmJGiBveGl8FHa6Kb+X6sH8bcl1Xvz BHBuPt9HoZDMONgY+VJw1WH+rZAXuHkg2B1oWpQ3xbTdnelsjhi7F3oiZo9XHG/WVqLR +BWBn/NJa4iGkF42GxiYMq6RB7IUnmZA/vxVs4cdqP6x8CCXbkruUN1Tz3gz5+sAdepC 6b2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xh7i5Zt9zY8KA4+yMY4ctmVEgG+7w746xU8n69jbbEs=; b=ZR1EdocyOAMoQR5tTaDy4e70qz55iomhKj43LRXxZ0K66eQH17CXopVmSKaaxUlOTV AczXuZPP9WBf/ilW/ErL77c4c4/C1SApbX3HnaxVac99HWcqufrEdMnGbFQ0+tdyBE6R DJ61YAsyEY09Kj8Yor+Sg9VxkcFAUMFY7UesuncMVkjbC5RUbbj/Brl7pLPRfgri+cn1 MJsIXEjjzuNOkzY1nAQj1Qt8/GIJ0Nv/ANQI64iITs/+ADMDP6qewzoyrEs72ov3NPkM 1rar06w8Mg3L+KPkPdd6x2sKZGeobNLo52bLDmMQNuilXsOmfxPoVTQYb2zQ1pjvV3zv FPiA== X-Gm-Message-State: AOAM531FwXfQrDHm+b6qSHC79/ThcceBfVWdriogDbgWlXUo28Nenm7v Kk5MsBtOr01/4y86stYMRwn0rw== X-Google-Smtp-Source: ABdhPJwb/a/SRwF/DAAw8ogBKfBvlx8OkfX2V5/f/vRfPam9TRSF9EbP2sUYi4E/UDR4SJzevq431Q== X-Received: by 2002:adf:ea0e:: with SMTP id q14mr15168861wrm.389.1616769320924; Fri, 26 Mar 2021 07:35:20 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:20 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 19/25] HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers Date: Fri, 26 Mar 2021 14:34:52 +0000 Message-Id: <20210326143458.508959-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-uclogic-params.c:33: warning: expecting prototype for Convert a pen in(). Prototype was for uclogic_params_pen_inrange_to_str() instead drivers/hid/hid-uclogic-params.c:519: warning: wrong kernel-doc identifier on line: drivers/hid/hid-uclogic-params.c:706: warning: expecting prototype for uclogic_params_init(). Prototype was for uclogic_params_huion_init() instead Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/hid-uclogic-params.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c index 6af25c38b9ccb..3d67b748a3b95 100644 --- a/drivers/hid/hid-uclogic-params.c +++ b/drivers/hid/hid-uclogic-params.c @@ -21,7 +21,8 @@ #include /** - * Convert a pen in-range reporting type to a string. + * uclogic_params_pen_inrange_to_str() - Convert a pen in-range reporting type + * to a string. * * @inrange: The in-range reporting type to convert. * @@ -516,7 +517,8 @@ void uclogic_params_cleanup(struct uclogic_params *params) } /** - * Get a replacement report descriptor for a tablet's interface. + * uclogic_params_get_desc() - Get a replacement report descriptor for a + * tablet's interface. * * @params: The parameters of a tablet interface to get report * descriptor for. Cannot be NULL. @@ -689,7 +691,7 @@ static void uclogic_params_init_with_pen_unused(struct uclogic_params *params) } /** - * uclogic_params_init() - initialize a Huion tablet interface and discover + * uclogic_params_huion_init() - initialize a Huion tablet interface and discover * its parameters. * * @params: Parameters to fill in (to be cleaned with From patchwork Fri Mar 26 14:34:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166887 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFF46C4345A for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3BB161A32 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230490AbhCZOf6 (ORCPT ); Fri, 26 Mar 2021 10:35:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbhCZOfY (ORCPT ); Fri, 26 Mar 2021 10:35:24 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A920C0613AA for ; Fri, 26 Mar 2021 07:35:23 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id c8so5843696wrq.11 for ; Fri, 26 Mar 2021 07:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3OURK0/BtiRmYmxdr9eDjqtjV+BCQ8RHntM2yCP2zSg=; b=PtT7cwy7Kq+1bup/YFbEJarCVzHxuEVc84amtcMt2h+VpFZrtcrInuDnq6EqibA2Fd fj68TSdpiKv4NbeM2Uww/Bs+rUREHG1Ec0QSCmFZdLwd/BrgKiKUI61ekI12IC8wH6la uNBN7ibIy1PNF2z9mutas7vHVc6k/3Xe9IbpSZaIi4YeGFe9WL5soXxTfHc3gvbrFhVm zAjvp5E8L1Dr79OibPl0dfASqXLujV2VUIBhSL268DEwj1FvBNG2DRuLL+w3jstQznTr ScQzsT5V3hDnqeV4Ac7uuKMutmm9q5NiAbXe/ozjwXZ5prQy6O7QC8hBbLGTeDGMefxK fo6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3OURK0/BtiRmYmxdr9eDjqtjV+BCQ8RHntM2yCP2zSg=; b=r+EnXB0bs6Bhm6J7Qv7OQBpLKrDF0km/UamwKfWNblKhLBH8caEc9JmfUfqI0kDDvI z0IHU1LSCkzukI0TBrtOgGK6xqaC3Eh42lKzkKcXxCs8wJ5EqI9f/0brUwBCfUkmRoKS I6wOI3YnIfQ+N0N0m5Er4N+F5JZ6EW6gEeqxrmQ1AKSyp3CuTNAJ6EwnWSnmyARECytB Mz8jTWk+3+19jaU+Op4uu+BtJs1guf1Qh31VFXzDSSQUbKNh+u7K9BtpuzuxluEvpvor 15UYZ7EwkSHe15SKYMhqX/hRgm/L1qqzG70M3sFRGNQygZUMt5ewILhf1YXuN6IMXF3+ uiNg== X-Gm-Message-State: AOAM533NLiQZ8/Bs+ovxn/AZbjR8K8itPkocAqEhhQBFrjL5Om9+G8xM uVyTGP00pvYZFRmH+/SSM9Jeng== X-Google-Smtp-Source: ABdhPJyx2thqrRk6seohVbZh5o5G2l8H68FVAIdYkEEG0m4XDCj/sno1gMcTDejHXnqfiBiYzqMxXQ== X-Received: by 2002:adf:dfc3:: with SMTP id q3mr15131963wrn.121.1616769322202; Fri, 26 Mar 2021 07:35:22 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:21 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , Benjamin Tissoires , linux-input@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 20/25] HID: hid-sensor-custom: Remove unused variable 'ret' Date: Fri, 26 Mar 2021 14:34:53 +0000 Message-Id: <20210326143458.508959-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-sensor-custom.c: In function ‘store_value’: drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Jonathan Cameron --- drivers/hid/hid-sensor-custom.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-sensor-custom.c b/drivers/hid/hid-sensor-custom.c index 2628bc53ed809..2e6662173a79c 100644 --- a/drivers/hid/hid-sensor-custom.c +++ b/drivers/hid/hid-sensor-custom.c @@ -397,15 +397,14 @@ static ssize_t store_value(struct device *dev, struct device_attribute *attr, if (!strncmp(name, "value", strlen("value"))) { u32 report_id; - int ret; if (kstrtoint(buf, 0, &value) != 0) return -EINVAL; report_id = sensor_inst->fields[field_index].attribute. report_id; - ret = sensor_hub_set_feature(sensor_inst->hsdev, report_id, - index, sizeof(value), &value); + sensor_hub_set_feature(sensor_inst->hsdev, report_id, + index, sizeof(value), &value); } else return -EINVAL; From patchwork Fri Mar 26 14:34:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166889 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3598C43459 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94C9A61A05 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbhCZOf7 (ORCPT ); Fri, 26 Mar 2021 10:35:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbhCZOfZ (ORCPT ); Fri, 26 Mar 2021 10:35:25 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB4BBC0613B1 for ; Fri, 26 Mar 2021 07:35:24 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id j18so5882357wra.2 for ; Fri, 26 Mar 2021 07:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ccGk85Qb+R/2lzURMS8M3ry2sPIqf4RAKxkbH0HWWQ0=; b=MQ8AqYo029jcxTkqz0fgQ0hfg9qfIz0zHA/0DYIrzjy5Wy0fxLFqL+KsGKFznObPEk CEeJjoFgVL5bXtmaxF6i5/cyoHXom73K7cqUKGzbk9QTmgdbq+teGlkGm4pZr4ZybdwT 5M4Nrc99xI/Tbls+jXiZTKmShFx2ZtPh/eQjI6vZcIwMU5DXYst5davdCMTcHD8WD9CX FH3m7ourYeOpAa8FS3Fe4KlpOlDA7sygkHybN0BncjL7It8RnOPAj60NwvugvEGGShcl uq+XY5dFYgIuLxqwRC/ILbZA/qV13dO39oo2VtcPN8ok2bPEUxsODa+6pui5lurU3pIy 0MdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ccGk85Qb+R/2lzURMS8M3ry2sPIqf4RAKxkbH0HWWQ0=; b=faWyB3lGRpx+cHjZj2In4u0STxkdwqqgYnhl2JrGEP8N99gUXwtapUpsjhRbZUqmvK yt8MrGDpf9wQ1XTHwI+04ig+sd+Nu45xpQ2/2i3S18cXAJQcyU9xBMjpEQpM3YASV8cn +9RL4oWbrlHbfvzuJGdmwk2bzjTMVEI4pe6kw6P5soA1AWUY2v2r/pIIQWtAnZafiAwQ MfQemiC1kBgtgbSRo4tzY+xUvrXEXmj9sDidbmNHF96QFH0xu/LOnVGYhg2DmJABAqni ESKSNuB/0x/3Sl9DOkOQOBZ92fGAnI8fBLrR4rjSjc/UFYu7pYRNR0JoMKKI2Ggmrh5+ ylbg== X-Gm-Message-State: AOAM531jMrGHjW3Jj0BqWPn6B5a2zL14L+YyB6vpHJ5+TAj02lg1oErY opdbbaeJb0D3yFz5RYefHISmjg== X-Google-Smtp-Source: ABdhPJzNOI+5IVpNAxH3g74ZP94Kypg0a6A8+oRK0jJF2OD8NoyZx0Ghj9YnEuQ1ML1qp6uREg4qkg== X-Received: by 2002:a5d:4e85:: with SMTP id e5mr15103731wru.218.1616769323414; Fri, 26 Mar 2021 07:35:23 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:23 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH 21/25] HID: wacom_sys: Demote kernel-doc abuse Date: Fri, 26 Mar 2021 14:34:54 +0000 Message-Id: <20210326143458.508959-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/wacom_sys.c:1505: warning: Function parameter or member 'wacom' not described in 'wacom_led_next' drivers/hid/wacom_sys.c:1505: warning: Function parameter or member 'cur' not described in 'wacom_led_next' Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/hid/wacom_sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 8328ef155c468..57bfa0ae98361 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1495,7 +1495,7 @@ struct wacom_led *wacom_led_find(struct wacom *wacom, unsigned int group_id, return &group->leds[id]; } -/** +/* * wacom_led_next: gives the next available led with a wacom trigger. * * returns the next available struct wacom_led which has its default trigger From patchwork Fri Mar 26 14:34:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166877 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE99DC4345C for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E055D61A05 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbhCZOgA (ORCPT ); Fri, 26 Mar 2021 10:36:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbhCZOf0 (ORCPT ); Fri, 26 Mar 2021 10:35:26 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFE83C0613B1 for ; Fri, 26 Mar 2021 07:35:25 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id x16so5868434wrn.4 for ; Fri, 26 Mar 2021 07:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YMBBfLBQyPfcs/BjCQH23mCoZ18SMLXlxq4s4Yi+O24=; b=SzlRTOBcfb8HruNCzxQ/XXDAxq8fqES6yINPpKxgv4YKBPLmmbqmuPhwiUVO/O/bUW P1w/L8olV5BC+2GhwMbfJzWKf+I0byxOzDmxedHXQRpbaUn7kLwJTP3EYVK9rUnFTuOX LSPAQMbX/Q5Z9jQhWhH72x2cn7ShB3260TwJY25LbnCBInnTAVHXAYq5MrO24MNb+/nk 3JFUCg6Dz1iHWIaWHwysjygdZsVzZpilI2K649/2LGwPBWT6xLAlqMoZIUed5yLxFyr3 Md0ubvCnN3awJtJHYKf5OU0rJagj7ePess/DcrJvayL0t57GgwR5I2DPAW5/L1/rCSIY 4Xxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YMBBfLBQyPfcs/BjCQH23mCoZ18SMLXlxq4s4Yi+O24=; b=kcTlDn83fyrN/44mYHVpzilTBBo9/yv8hk+v+Faq0nWewXne5I2vywmzGd/V7JVjem 7l5aCJcP6GJnW0lvAkxnQVgOvCJtsxPJptox3bwiFdYc3ULCaH+cUyHYsJrbsK+5IAs9 lbw2R3Ll2ug3Mhj5Jcs/kz0bZflWbTUi9NbmVX3fUzUu1ExZ8JL3ZZ5W0iXFJD8lqNTS QvmTA7wGXtRsHqciEKdVCH8VketbzLy1OLyHKOqUoDUhMRhC7QLSX8oqNiDRzoFyRGbZ wxasCJNaNwxnEfwE2pJh57cDgRhHpyh3T9CmlT1mCQhNprlzPQWAsaT0BpoLchUh4z8+ Mltg== X-Gm-Message-State: AOAM531PsSzA1lSShcIPruCboRoqSjkWIrYp7dvQo2EXJC8J6hJu9/IC oRqrsiM1zGdSQf18ZLc5Cw+aSA== X-Google-Smtp-Source: ABdhPJxVEQw3OXVcUWupqGocVo9kUby54BTdwkPyGcKLXqoHGoInXFiNk3GDV8kL7UYSFgCKfKInWQ== X-Received: by 2002:a5d:6092:: with SMTP id w18mr14807891wrt.52.1616769324690; Fri, 26 Mar 2021 07:35:24 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:24 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , Benjamin Tissoires , linux-input@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 22/25] HID: hid-sensor-hub: Remove unused struct member 'quirks' Date: Fri, 26 Mar 2021 14:34:55 +0000 Message-Id: <20210326143458.508959-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Commit b0f847e16c1ea ("HID: hid-sensor-hub: Force logical minimum to 1 for power and report state") removed the last used quirk handled by this driver. Fixes the following W=1 kernel build warning(s): drivers/hid/hid-sensor-hub.c:39: warning: Function parameter or member 'quirks' not described in 'sensor_hub_data' Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Jonathan Cameron --- drivers/hid/hid-sensor-hub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 3dd7d32467378..36b6852f75dd5 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -34,7 +34,6 @@ struct sensor_hub_data { spinlock_t dyn_callback_lock; struct mfd_cell *hid_sensor_hub_client_devs; int hid_sensor_client_cnt; - unsigned long quirks; int ref_cnt; }; @@ -615,7 +614,6 @@ static int sensor_hub_probe(struct hid_device *hdev, } hid_set_drvdata(hdev, sd); - sd->quirks = id->driver_data; spin_lock_init(&sd->lock); spin_lock_init(&sd->dyn_callback_lock); From patchwork Fri Mar 26 14:34:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166881 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB28AC4345B for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8DC461A3F for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhCZOgB (ORCPT ); Fri, 26 Mar 2021 10:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbhCZOf1 (ORCPT ); Fri, 26 Mar 2021 10:35:27 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 279B5C0613B4 for ; Fri, 26 Mar 2021 07:35:27 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id e18so5871460wrt.6 for ; Fri, 26 Mar 2021 07:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cQiBvBGnEPCfXvDLlcXYmYRETtwubP2zncCLn7n+qro=; b=I00rzJ2Pb7xw7qyx/Ux/iw5avL4Qa+ePqFm2O47i8SPa2MwvByhdllikoreR5RZPq5 gmf29+BchuESCtjhbW500HI1pMhjDYSqXRz0zpDsl0VWtvfTtm+yyvYEQLZq7ygzrLax uhk3PwjegUKYtD9HfqGHoLz2N1l+lBtd/82MXC7T39KAink0dpxWK8q0V+o75Bz6ijTg VQELl51GdcI6SVg266nyjrsOigDblcjUYU/UG48jNjSZGpYeMgUzogjETeYNI8OXS9ws bzBYIx32n/T5T2bFM/Cb5T+T45cBCLIOP22bxe37CEx/vLAW5+ETfsOQhYNDt5YYlW+o duEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cQiBvBGnEPCfXvDLlcXYmYRETtwubP2zncCLn7n+qro=; b=XQlREJeY545Sn9idcDZVEjEOe9AtzaB6U9SLdVA32pSfKQJvtoMLTpyZ3G71PfCyU2 wDRXXdQ+d2YzM8EvFsQifTf3WaQ7EXD1Yn3GPvu/Du3sx7lKltInqlPPrP8V+9NraR9F KGLHJrDJyEbYOT2xGcVyzFIIcOREo8KSZ8pQ/mSxA/9GYxGDmtkcT/dWj+dUJyTKv1Ai u5No63RXRwzjiz4NkBJu1QOIgKfgN5cm2tOy6P/U7Gkb+E3Ky02/wnirH7Ybigd/sVkA Fgv2vbyqKXd8lbTFIIr+9mwtMrhGZHPJKSdI+pUZ+TCu2u8k7+4KqNjaujTGAbW3wlZS 8HHQ== X-Gm-Message-State: AOAM533r30f7UsIsgx2mk1SBLyb5DnCTJo0IWSa6WpZAbeX/KU5vEMkf UnhTWa9cjjfB4cCdLIWNZicTRw== X-Google-Smtp-Source: ABdhPJxVQH9E7yz/g9mCKCmuf6kL2CneZmZwGC42RiuDWq3ME4fXeUoxutDqT538V/wUc8tO54qLtA== X-Received: by 2002:adf:e34f:: with SMTP id n15mr14838333wrj.224.1616769325875; Fri, 26 Mar 2021 07:35:25 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:25 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , Benjamin Tissoires , linux-input@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH 23/25] HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition Date: Fri, 26 Mar 2021 14:34:56 +0000 Message-Id: <20210326143458.508959-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/hid-sensor-hub.c:54: warning: Function parameter or member 'hsdev' not described in 'hid_sensor_hub_callbacks_list' Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Cc: linux-input@vger.kernel.org Cc: linux-iio@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Jonathan Cameron --- drivers/hid/hid-sensor-hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index 36b6852f75dd5..95cf88f3bafb9 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -18,7 +18,6 @@ /** * struct sensor_hub_data - Hold a instance data for a HID hub device - * @hsdev: Stored hid instance for current hub device. * @mutex: Mutex to serialize synchronous request. * @lock: Spin lock to protect pending request structure. * @dyn_callback_list: Holds callback function @@ -41,6 +40,7 @@ struct sensor_hub_data { * struct hid_sensor_hub_callbacks_list - Stores callback list * @list: list head. * @usage_id: usage id for a physical device. + * @hsdev: Stored hid instance for current hub device. * @usage_callback: Stores registered callback functions. * @priv: Private data for a physical device. */ From patchwork Fri Mar 26 14:34:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166879 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B42C4345E for ; Fri, 26 Mar 2021 14:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BF1C61A54 for ; Fri, 26 Mar 2021 14:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbhCZOgB (ORCPT ); Fri, 26 Mar 2021 10:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230390AbhCZOf3 (ORCPT ); Fri, 26 Mar 2021 10:35:29 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81FF0C0613B1 for ; Fri, 26 Mar 2021 07:35:28 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id j18so5882550wra.2 for ; Fri, 26 Mar 2021 07:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HbWsUdS40uUZ3dqqAk74P4eL9H356rB4HhtuuV/k+mc=; b=GepEdxXdoOebrZzGX05sl0zwz0j0wmHbdjIrJY1qGIYLFrERfXU3aEWPFLCxeFsfVF aCVh7y4I8PC2EcjQX1R0d0GJlHH5Fnp2l9oCM8RexhEMGsenjXvf3fd8Mm+ch21rymN/ iAX7zkqQATzQyOsq9X0FrnbHd1zfJSTJjsJTdjX4knpTDCcT5bVOY0jQoifKdvY/SkfG XEqsFvBvac1qh7+kV6Awj82p/Wj55KAm5+cEI/1pyf9xJgLn6PjWknxtaty/n9MDhDn6 0rDJhHp85fMuWSkO7dOTSqRTaOWmqRc3r43j9zB+904c8lNOF83DP4gOnChAjmoQQVpb WLbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HbWsUdS40uUZ3dqqAk74P4eL9H356rB4HhtuuV/k+mc=; b=lTNRGCKRiMveFz0k8Q7+xCfhnlHL9pmNcdyCDZkO6s06WRPTrv/7uz3NxIAxzb/tHm tNsvEqqVQij8Dxn4hzkud/wDpuxuimzboqCPZjh4xuCH8DhqiHuKajC299Xa9FqRrrwb OsCTCD/lgLpPhRwOstB78cWm7yiMv/566WW+tH1s3dvCcd9fKKvhNRJ0Yh/ZaLLnrmo4 pH9o7yXywn2Rh01zidlFlLhmbzerEkf2Jp+u+Z7l+xCHSBimJ3Wj/8XhtIX7rruCeOg1 1qI2fi/wVRbXdjD1t+4Yh0xMEWj4KR4qXOFz2FNnVLp0rXPC7sBxb5kDH6UEDvReWoow KDcQ== X-Gm-Message-State: AOAM530xOZOwfvf2fKgE5ixZ43a46B8Bwzl1bHv6ygx/0M602JHPc3SO 6ifnjQt7dbGfu/JbkgmD09MYUA== X-Google-Smtp-Source: ABdhPJyJTAw8LMWoQ88NuL2NCsfi+lxuv6aowZPT3nUlMAQ3C9g3dtr3UCCOQZDBIyRbE7mJxa0asA== X-Received: by 2002:adf:ef4c:: with SMTP id c12mr15090023wrp.112.1616769327200; Fri, 26 Mar 2021 07:35:27 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:26 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Rushikesh S Kadam , linux-input@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 24/25] HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues Date: Fri, 26 Mar 2021 14:34:57 +0000 Message-Id: <20210326143458.508959-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org And demote non-conformant header Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_QUERY' not described in enum 'ish_loader_commands' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_XFER_FRAGMENT' not described in enum 'ish_loader_commands' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:46: warning: Enum value 'LOADER_CMD_START' not described in enum 'ish_loader_commands' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:108: warning: Function parameter or member 'reserved' not described in 'loader_msg_hdr' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'data' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'max_size' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'size' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'error' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'received' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:196: warning: Function parameter or member 'wait_queue' not described in 'response_info' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'loader_ishtp_cl' not described in 'ishtp_cl_data' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_data' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'response' not described in 'ishtp_cl_data' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'flag_retry' not described in 'ishtp_cl_data' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:233: warning: Function parameter or member 'retry_count' not described in 'ishtp_cl_data' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:252: warning: Function parameter or member 'client_data' not described in 'get_firmware_variant' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:252: warning: Function parameter or member 'filename' not described in 'get_firmware_variant' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'out_msg' not described in 'loader_cl_send' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'out_size' not described in 'loader_cl_send' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'in_msg' not described in 'loader_cl_send' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: Function parameter or member 'in_size' not described in 'loader_cl_send' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:281: warning: expecting prototype for Send message from host to firmware(). Prototype was for loader_cl_send() instead drivers/hid/intel-ish-hid/ishtp-fw-loader.c:445: warning: Function parameter or member 'cl_device' not described in 'loader_cl_event_cb' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:445: warning: Excess function parameter 'device' description in 'loader_cl_event_cb' drivers/hid/intel-ish-hid/ishtp-fw-loader.c:551: warning: expecting prototype for Loads ISH firmware using ishtp interface(). Prototype was for ish_fw_xfer_ishtp() instead drivers/hid/intel-ish-hid/ishtp-fw-loader.c:745: warning: expecting prototype for Start executing ISH main firmware(). Prototype was for ish_fw_start() instead drivers/hid/intel-ish-hid/ishtp-fw-loader.c:767: warning: expecting prototype for Loads ISH firmware from host(). Prototype was for load_fw_from_host() instead Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Sumit Semwal Cc: "Christian König" Cc: Rushikesh S Kadam Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 +++++++++++---------- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c index edb0bd084c275..d20d74a890e90 100644 --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c @@ -31,13 +31,13 @@ /** * enum ish_loader_commands - ISH loader host commands. - * LOADER_CMD_XFER_QUERY Query the Shim firmware loader for + * @LOADER_CMD_XFER_QUERY: Query the Shim firmware loader for * capabilities - * LOADER_CMD_XFER_FRAGMENT Transfer one firmware image fragment at a + * @LOADER_CMD_XFER_FRAGMENT: Transfer one firmware image fragment at a * time. The command may be executed * multiple times until the entire firmware * image is downloaded to SRAM. - * LOADER_CMD_START Start executing the main firmware. + * @LOADER_CMD_START: Start executing the main firmware. */ enum ish_loader_commands { LOADER_CMD_XFER_QUERY = 0, @@ -95,6 +95,7 @@ static int dma_buf_size_limit = 4 * PAGE_SIZE; /** * struct loader_msg_hdr - Header for ISH Loader commands. * @command: LOADER_CMD* commands. Bit 7 is the response. + * @reserved: Reserved space * @status: Command response status. Non 0, is error * condition. * @@ -173,16 +174,16 @@ struct loader_start { * struct response_info - Encapsulate firmware response related * information for passing between function * loader_cl_send() and process_recv() callback. - * @data Copy the data received from firmware here. - * @max_size Max size allocated for the @data buffer. If the + * @data: Copy the data received from firmware here. + * @max_size: Max size allocated for the @data buffer. If the * received data exceeds this value, we log an * error. - * @size Actual size of data received from firmware. - * @error Returns 0 for success, negative error code for a + * @size: Actual size of data received from firmware. + * @error: Returns 0 for success, negative error code for a * failure in function process_recv(). - * @received Set to true on receiving a valid firmware + * @received: Set to true on receiving a valid firmware * response to host command - * @wait_queue Wait queue for Host firmware loading where the + * @wait_queue: Wait queue for Host firmware loading where the * client sends message to ISH firmware and waits * for response */ @@ -195,13 +196,13 @@ struct response_info { wait_queue_head_t wait_queue; }; -/** +/* * struct ishtp_cl_data - Encapsulate per ISH-TP Client Data. * @work_ishtp_reset: Work queue for reset handling. * @work_fw_load: Work queue for host firmware loading. - * @flag_retry Flag for indicating host firmware loading should + * @flag_retry: Flag for indicating host firmware loading should * be retried. - * @retry_count Count the number of retries. + * @retry_count: Count the number of retries. * * This structure is used to store data per client. */ @@ -240,8 +241,8 @@ struct ishtp_cl_data { /** * get_firmware_variant() - Gets the filename of firmware image to be * loaded based on platform variant. - * @client_data Client data instance. - * @filename Returns firmware filename. + * @client_data: Client data instance. + * @filename: Returns firmware filename. * * Queries the firmware-name device property string. * @@ -266,11 +267,11 @@ static int get_firmware_variant(struct ishtp_cl_data *client_data, /** * loader_cl_send() Send message from host to firmware * @client_data: Client data instance - * @out_msg Message buffer to be sent to firmware - * @out_size Size of out going message - * @in_msg Message buffer where the incoming data copied. + * @out_msg: Message buffer to be sent to firmware + * @out_size: Size of out going message + * @in_msg: Message buffer where the incoming data copied. * This buffer is allocated by calling - * @in_size Max size of incoming message + * @in_size: Max size of incoming message * * Return: Number of bytes copied in the in_msg on success, negative * error code on failure. @@ -435,7 +436,7 @@ static void process_recv(struct ishtp_cl *loader_ishtp_cl, /** * loader_cl_event_cb() - bus driver callback for incoming message - * @device: Pointer to the ishtp client device for which this + * @cl_device: Pointer to the ishtp client device for which this * message is targeted * * Remove the packet from the list and process the message by calling @@ -536,7 +537,7 @@ static int ish_query_loader_prop(struct ishtp_cl_data *client_data, } /** - * ish_fw_xfer_ishtp() Loads ISH firmware using ishtp interface + * ish_fw_xfer_ishtp() - Loads ISH firmware using ishtp interface * @client_data: Client data instance * @fw: Pointer to firmware data struct in host memory * @@ -733,7 +734,7 @@ static int ish_fw_xfer_direct_dma(struct ishtp_cl_data *client_data, } /** - * ish_fw_start() Start executing ISH main firmware + * ish_fw_start() - Start executing ISH main firmware * @client_data: client data instance * * This function sends message to Shim firmware loader to start @@ -756,7 +757,7 @@ static int ish_fw_start(struct ishtp_cl_data *client_data) } /** - * load_fw_from_host() Loads ISH firmware from host + * load_fw_from_host() - Loads ISH firmware from host * @client_data: Client data instance * * This function loads the ISH firmware to ISH SRAM and starts execution From patchwork Fri Mar 26 14:34:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166883 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A687C4345D for ; Fri, 26 Mar 2021 14:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF52E61A32 for ; Fri, 26 Mar 2021 14:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231137AbhCZOgC (ORCPT ); Fri, 26 Mar 2021 10:36:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbhCZOfa (ORCPT ); Fri, 26 Mar 2021 10:35:30 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D942AC0613AA for ; Fri, 26 Mar 2021 07:35:29 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id b9so5846127wrt.8 for ; Fri, 26 Mar 2021 07:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ClFGCdlyfHku/4SK1RS5YcXqT4jfIPIFaVtjJpjt8dI=; b=zBUWxDzz0qsrzy2U455hoEcT4SP9C4Lm/4mPsseMd6sftp+9qjrwtdVWRDIlVUR2x+ w6h7Q0xiW8Bzp6YynifdA8gq/zqqyRwbcDo66EEm8S1Drim13BvKjZKbpx2IFJ57IggZ 8dM0l76bPEoIA5gXy/ZPQH4V/8H9iGTmt4h5xfzYRtTSThHrC2Lr/W5to69igPN6TzzE P/RSQKpbeewsihN0s8oZBQyC2/RNS7miSKfZXusQQFsHdcOJgHbOOpFli/+4kyosRl51 KMDV47YmxBnIuVteCrUTadawpoAUFNmitlpM5WQNd+Jn1Vpz/XhyrpeYeAXCaCuf0s+G V1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ClFGCdlyfHku/4SK1RS5YcXqT4jfIPIFaVtjJpjt8dI=; b=A4GwjsbWXMkDv1HYDjYH+0V/BBzF8J4/of0iHwzR2KycwgAZZ13kNO7dVX3LH3sT8b uOWrheCzllLOgOoktn7+kkfuL8rfPJK9M/lRbrhfLcyYjifRD8cQ/E1qb5vcaGHp1VhG +h3GAMJupwUx9JNeOpK/P1HzLkGgprEvYPqkDDGot46AfgJ2ZGdnNwE86BfngVPfeyOZ HZR97FNeuyskq4li/c9HAJYBzCOhUmGTbUdyTQM45ieNNYU96fI3sV1vSFH4ye1scY1Y JSUrwAozo1povoHVVRaJDNNcagmwKUSFWyJOCgX0nt0tvXq6tJQCZOgnULPL0v2URjdg BfeA== X-Gm-Message-State: AOAM532NA545NoF4pxuYi4hkz+4Bn/8o7anZa6Undv5e0LPQSZ8bQVuL f1qqttHxAz4sCPE3BhMGd2EEaQ== X-Google-Smtp-Source: ABdhPJxJ43fMfcqtKUbjAcvCSxXzdtMVZTMWkDgD6B8lxdQ7AyQZa2evvtl6rXxcLldcDxglGsetBQ== X-Received: by 2002:adf:cf11:: with SMTP id o17mr14923097wrj.391.1616769328584; Fri, 26 Mar 2021 07:35:28 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:28 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org, Arnd Bergmann Subject: [PATCH 25/25] HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning Date: Fri, 26 Mar 2021 14:34:58 +0000 Message-Id: <20210326143458.508959-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/hid/intel-ish-hid/ishtp/bus.c: In function ‘ishtp_trace_callback’: drivers/hid/intel-ish-hid/ishtp/bus.c:876:29: warning: return type might be a candidate for a format attribute [-Wsuggest-attribute=format] 876 | return cl_device->ishtp_dev->print_log; | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Suggested-by: Arnd Bergmann Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 4 ++-- drivers/hid/intel-ish-hid/ishtp-hid.h | 4 ++-- drivers/hid/intel-ish-hid/ishtp/bus.c | 4 ++-- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 ++-- include/linux/intel-ish-client-if.h | 8 +++++++- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 042a7091802dd..6b1fa971b33e2 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -784,7 +784,7 @@ static void hid_ishtp_cl_reset_handler(struct work_struct *work) } } -void (*hid_print_trace)(void *unused, const char *format, ...); +ishtp_print_log ishtp_hid_print_trace; /** * hid_ishtp_cl_probe() - ISHTP client driver probe @@ -823,7 +823,7 @@ static int hid_ishtp_cl_probe(struct ishtp_cl_device *cl_device) INIT_WORK(&client_data->work, hid_ishtp_cl_reset_handler); - hid_print_trace = ishtp_trace_callback(cl_device); + ishtp_hid_print_trace = ishtp_trace_callback(cl_device); rv = hid_ishtp_cl_init(hid_ishtp_cl, 0); if (rv) { diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h index e2423f7d2b547..f88443a7d935e 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.h +++ b/drivers/hid/intel-ish-hid/ishtp-hid.h @@ -16,9 +16,9 @@ #define IS_RESPONSE 0x80 /* Used to dump to Linux trace buffer, if enabled */ -extern void (*hid_print_trace)(void *unused, const char *format, ...); +extern ishtp_print_log ishtp_hid_print_trace; #define hid_ishtp_trace(client, ...) \ - (hid_print_trace)(NULL, __VA_ARGS__) + (ishtp_hid_print_trace)(NULL, __VA_ARGS__) /* ISH HID message structure */ struct hostif_msg_hdr { diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c index c1c7d5356208d..f0802b047ed8d 100644 --- a/drivers/hid/intel-ish-hid/ishtp/bus.c +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c @@ -869,9 +869,9 @@ EXPORT_SYMBOL(ishtp_get_pci_device); * * This interface is used to return trace callback function pointer. * - * Return: void *. + * Return: *ishtp_print_log() */ -void *ishtp_trace_callback(struct ishtp_cl_device *cl_device) +ishtp_print_log ishtp_trace_callback(struct ishtp_cl_device *cl_device) { return cl_device->ishtp_dev->print_log; } diff --git a/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h b/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h index 1cc6364aa957f..f579b16e6d7a9 100644 --- a/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h +++ b/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h @@ -10,6 +10,7 @@ #include #include +#include #include "bus.h" #include "hbm.h" @@ -202,8 +203,7 @@ struct ishtp_device { uint64_t ishtp_host_dma_rx_buf_phys; /* Dump to trace buffers if enabled*/ - __printf(2, 3) void (*print_log)(struct ishtp_device *dev, - const char *format, ...); + ishtp_print_log print_log; /* Debug stats */ unsigned int ipc_rx_cnt; diff --git a/include/linux/intel-ish-client-if.h b/include/linux/intel-ish-client-if.h index 94669e21dc8b3..25e2b4e805023 100644 --- a/include/linux/intel-ish-client-if.h +++ b/include/linux/intel-ish-client-if.h @@ -8,11 +8,17 @@ #ifndef _INTEL_ISH_CLIENT_IF_H_ #define _INTEL_ISH_CLIENT_IF_H_ +#include +#include + struct ishtp_cl_device; struct ishtp_device; struct ishtp_cl; struct ishtp_fw_client; +typedef __printf(2, 3) void (*ishtp_print_log)(struct ishtp_device *dev, + const char *format, ...); + /* Client state */ enum cl_state { ISHTP_CL_INITIALIZING = 0, @@ -76,7 +82,7 @@ int ishtp_register_event_cb(struct ishtp_cl_device *device, /* Get the device * from ishtp device instance */ struct device *ishtp_device(struct ishtp_cl_device *cl_device); /* Trace interface for clients */ -void *ishtp_trace_callback(struct ishtp_cl_device *cl_device); +ishtp_print_log ishtp_trace_callback(struct ishtp_cl_device *cl_device); /* Get device pointer of PCI device for DMA acces */ struct device *ishtp_get_pci_device(struct ishtp_cl_device *cl_device);