From patchwork Mon Mar 29 12:17:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quan Nguyen X-Patchwork-Id: 12170901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7E2C433E0 for ; Mon, 29 Mar 2021 19:43:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC1F16192F for ; Mon, 29 Mar 2021 19:43:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC1F16192F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ThvCfCZIHYi/467FJbkhR4GCDJ27HJIYR2o0Wu8ITPg=; b=mWgnwNUfOUV85GwU9ioPnNLiY tFkp3wr1wlwz9mgsDaZdhPjuzePjg8Tcs/eGkwkSTOKdPA7Vey9TJdw+BRxdi5Zs7pR9Flkxb2Eyb YEnoAhj3RfBpk/2YR2lwOsrn+raOi4cstQKbfkqiatQBqDY1lrykqb5+D7VVmWYqKBjLBupJljcGf ppbmKX1gQdcS4MAtlQW1jNpn/qLL1EGRXHDmJpPrnyOxjP6+inTwM2iAczWWcez2bHZNaibxqWyyo 8PWo49OAqp9BgZuUsksWUxn/h3UKgAO/pAptmcrkKvrQt3bqoeP6nDtmMk9JYIHEsBPtXu7vMz5ic oJEdYaQlw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQxgw-001H5U-OS; Mon, 29 Mar 2021 19:36:51 +0000 Received: from mail-bn8nam11on2125.outbound.protection.outlook.com ([40.107.236.125] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQqqo-000doQ-FZ for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 12:18:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ASjHxlzU/83jjWYKHZIc/6G4s2uCjPaZ/2UntYSBz7kryL+9/hp2dyKzmxQgi17c3aho1prYpQu6VAk0+0Qa+MffVXdxrmSsX/qZH3mAyyfsVoyFHrgFheNEkYw1dEhajmY9u4hsAwlFcO5QvqYkrL/qvtBHWH1Rra3yIZeW3lWBE0pqP83c3cKdwvuZzl2bDTP4wnlbv6148g/GzyYcG+dZf4+551AsknmKHAHVL8HdQFqaEuox5CgmweOuIIp0iCdJqY45zFXw2Z1Gld9uKoTWIZoYhSsmCvMGUGswSTZIfSSRNnYPX+ZEoS11YAkInJIiwEgE5hLGiiPTAvEYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObTdeZ8zsjlufq5/WNaeZ0cI2o4TsSWrRB99EetYum4=; b=dezEa/mW0Q50rQx0jhMvQ8z+KWYYWkdKctzf03O39lN7MC5X56dzWk5n49rBvcA1Oi4rI6RNOtYnn/1wkBd7ZGwpJ+sNoMGkxkWnruEypBBsGOClpcX8WuPGunbAV7XvggSF5nPoj8AFunPZooDfKnIt8c9Q8WRr+CEMoTvwJgA7jnp6U0J/5AKexd4+wgmaER/BZs8tmHF+jFA9b1Iur3/mfeuRD21qwV5i4FOFzvtfpD32Ce2Nbxa5lsnH5UjzB/zyT1/ERbeN8D8zdCRaGEekL6HyMCNL1UBLDFGDAY9UXNKezLcJ43m+ohQG1fBkiED2Qj3Hs1EnYEE8ZxFVYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObTdeZ8zsjlufq5/WNaeZ0cI2o4TsSWrRB99EetYum4=; b=UMnvoExxDtYF2RhE4n7W+rSwYGFr1lQyylB9MKGCxRQYHYQlbKRiiUMwlr9OOnbJhANbhygaDSGeMGfehHk3tcEc2DWvAd//MDouEE5cnuu1rP6mU7s7M54F58obqnS7S+E4lPTDr9G+pg2cTjPUKu6IBWWFMNI+A7mP0zBdyzk= Authentication-Results: acm.org; dkim=none (message not signed) header.d=none;acm.org; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by CO1PR01MB6679.prod.exchangelabs.com (2603:10b6:303:f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Mon, 29 Mar 2021 12:18:31 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 12:18:31 +0000 From: Quan Nguyen To: Corey Minyard , Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: [PATCH v1 1/3] i2c: i2c-core-smbus: Expose PEC calculate function for generic use Date: Mon, 29 Mar 2021 19:17:57 +0700 Message-Id: <20210329121759.5644-2-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20210329121759.5644-1-quan@os.amperecomputing.com> References: <20210329121759.5644-1-quan@os.amperecomputing.com> X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hcm-sw-17.amperecomputing.com (118.69.219.201) by HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.14 via Frontend Transport; Mon, 29 Mar 2021 12:18:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee65b826-7160-44ae-2c3a-08d8f2acc3fe X-MS-TrafficTypeDiagnostic: CO1PR01MB6679: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lkcZvIiTmGuq8XTNPfLcoERkBvh+3Lq9BbQzBrZM/IXgUGdOxtqnvxo254MRAbr5k7Gkq9fAzj2nfSAMyaNc6q5B9Uggy5zD58mtTIGFHysk08WQBP3v6Xh6BHRSQ2IZM+fQ5FbabaubTC9cb2gCmzZ9qOMoZc1oqG4l40EAGEUyTk1X6R3OOCdrXiwHkXub45CcALvT+Ah10CzW+BJlH25NWVidXKt6XfRVQk1sNDE5mTdUK4/DMWr3ykwZklwWeHSo8B0rdXzniA4e3Ze70hIgjoWa5pvAftOS5bmgf+D0mo2LSuGkNUuigeXMF7mruReUddLOq8x0/u0GGOF+rMKFECsQl0RhPgrcu3Q4a/wIdMjhijI0EshOu+errxG7rGA7oXP0rH5pXzKX5mcYzs0+KqyUuPFUl+yyl5SXew5QbBKQHHN6zXt2cPSWhFRvUjGBIhtB7eBWbs+0vLjp54+PIIxzPhSCMqmc8anGvgP4ggUSfzUXpIyUP9Zm+c37MiJLYbw/MebIP+FVsg/msrysWqu0zLFSzmkc8A0Acm49JG+xnXC/Ks3yRtrIESFhQy3wyR/VieZfOScnkV07XJau4i99jjjNkqYtU52b2RZVppeN/NmfEv6Go5Vt0mVdWWgwBorEyb3ODaKit4EoAeq6FMGCkti+X6Q63pQF2isjdZlSJf3DWUzh8iMBAIYc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR0102MB3482.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(39840400004)(396003)(346002)(136003)(921005)(52116002)(6506007)(66556008)(4326008)(6486002)(16526019)(54906003)(2906002)(107886003)(956004)(6512007)(110136005)(86362001)(8676002)(38100700001)(8936002)(1076003)(66476007)(5660300002)(2616005)(83380400001)(7416002)(316002)(26005)(478600001)(66946007)(6666004)(186003)(41533002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: wI0izVF6VsbQRmoX5ezlG2BEqxPbFF2dG7yhRHNfRedunNfXbOPunRa7mVw4PM/vrC0MIvP8I6MDDleFzHo5P1suMLltNq/JOImTt8C1DOoCV2pFK589U1vcquVRyqSOW55tNIBzSnQzEVRIqwXc9+iT2009RefAzjr2VxUR4iDQ8nsQ+duOmK2m950jRVBKFoikRSBqIMcZXGJA1cq9WHYdRRFTTzQEf8HIaMztc7UYLXvDxjT5weO+1danJB/wMf9KChx2dbKncz9CTGnuML6X8DaU0koMlgwTxrYRKwns2clpVOPJi6ZRpNSUPvTr21mZABCfRnLXpFORmVUDEwpAUgCtplRIIBIlY7U0cRkW4Uil/xidqJanSpEBcFiJU6PZ/U1SbPn6+SzaWWRdlCMpz1ZfFqdYT7jquLZiaau1HrNPLuCpvM89In+Y+giwgbCbgURObe50jZlgGx8UZrzT+fvA9Su3faKAuKPxbp7lZ/2Vm5J2IPwEdn/7EQFVX4r8qQDgTCgn3irRCQYHpDV582h/I0UbWncaa9ZKB6tARCnIV0p2ZrNf7ngI/js/r39GVLLGP3OM+pnI0rN7aJHLMTrt2fyUQj7N2NPzRu0EGcPWV3ZrWFRR0ceIKccDfRzPLGh7X7MvaFZQ02oPPZP3hzpDrZxWyoozX4DXEjFGJvveyZQSeb/g+iWPLRWAD1KZSJEnItDGSolQ0zEPB0cBTuDEgB1F73VugEFvGhVrOa5AROKzMgCUw4yppooJcrrRZC/Dn8DnoPjPc81o2kO5DFKfNwPhzHjMQxJEL2Mi+vpjI10VIcrsaY+5on0WDFM0Winw+jrYo1e3Af3oKB4LGt9Oh6R7YmSkN0hkRKvgMRkwC0kukEXVFHPQAehOMOgbGiZn2jlG2gYeFN2ZMr0y76Ldn7RisqJVs18osCUQOFnOnw+5f/l7bodO/dUCjtIxZocm1aOaAHBtt3Nr4tzPnh+YUNdmhZm011irkFBGyEiYe2tSgJn8o1Xs9AyU1TyFjiZ21kt9aexkqcN8c2Mtu5WzrAsGgPXeVW4PxmBCulxsKTqM7njFlX0agF0Oc4Qo6RQLMnBpi2obZ8UTxpp1/S348M+oj9BKMvKhxexdQYEf8XgpcY7qwunnEqoEuNnAK/9u9UPOYlweMgvWfE83/ZP0lCyOmYn0B8X8gOcdT5zvgr/2RprRxMhNK6BX2oFyvQXGHOarbEJBWhedROYjlPvxteQrE/hKxfzxEAsrI064STS+/2LkJEtZJwBInENKJRnTHDNvTU59H2Tw71B4wQxvej9CTKIuVuHAMDsUZ3OZ8curBxXUqhli+YoQ X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee65b826-7160-44ae-2c3a-08d8f2acc3fe X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 12:18:31.4103 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bb0hzPJ/ybSXHOGuSp3Dy44EySeq9aZEZ93phVuoBfVuFXg7G9A/Z0enoLP0e4AWtRHO8eyJa3HfkDVPnx1LgbzWP8k/2z1czQBnTNETiPM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6679 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_131834_590871_49E06426 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Expose the PEC calculation i2c_smbus_pec() for generic use. Signed-off-by: Quan Nguyen --- drivers/i2c/i2c-core-smbus.c | 12 ++++++++++-- include/linux/i2c.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c index d2d32c0fd8c3..e5b2d1465e7e 100644 --- a/drivers/i2c/i2c-core-smbus.c +++ b/drivers/i2c/i2c-core-smbus.c @@ -37,8 +37,15 @@ static u8 crc8(u16 data) return (u8)(data >> 8); } -/* Incremental CRC8 over count bytes in the array pointed to by p */ -static u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count) +/** + * i2c_smbus_pec - Incremental CRC8 over the given input data array + * @crc: previous return crc8 value + * @p: pointer to data buffer. + * @count: number of bytes in data buffer. + * + * Incremental CRC8 over count bytes in the array pointed to by p + */ +u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count) { int i; @@ -46,6 +53,7 @@ static u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count) crc = crc8((crc ^ p[i]) << 8); return crc; } +EXPORT_SYMBOL(i2c_smbus_pec); /* Assume a 7-bit address, which is reasonable for SMBus */ static u8 i2c_smbus_msg_pec(u8 pec, struct i2c_msg *msg) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 56622658b215..0d75e5bcdde6 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -144,6 +144,7 @@ s32 __i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr, /* Now follow the 'nice' access routines. These also document the calling conventions of i2c_smbus_xfer. */ +u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count); s32 i2c_smbus_read_byte(const struct i2c_client *client); s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value); s32 i2c_smbus_read_byte_data(const struct i2c_client *client, u8 command); From patchwork Mon Mar 29 12:17:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Quan Nguyen X-Patchwork-Id: 12170905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8E4C433DB for ; Mon, 29 Mar 2021 19:44:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28E38617C9 for ; Mon, 29 Mar 2021 19:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28E38617C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gdXuz4sAgiB3hpazgqw6iPP1jUp672P4oG+jjUrJsOE=; b=j7JXbBZ4ykopGZ06+ad4kMO96 D/ElsKHbesk8+U3+N0Vc9apP+/nTQgF3KOTHN6TGo/5kH7YWsVSc2DCrKFzWgYZKm8Od+jp9SSpVJ Ukv73/bWeXw0tJvrkDTUCiiG+XOOmfBuwgSK3fx9sWoFcaoZdIM6wS25m/izhral30XjGKDpyMVph ivZ5+gKeDYjtYb69TxuN6NpidvKgTm1WdXvpjLBwLfnepWnoz1YgN1YjoVYjQyoQ0sWfxKp+8VI0B 8MS2nqQoJIJqPrTGRP9qGINivgdjtn8IL9ygta235eA6yxaZDrJ8Ngb7qCcvy3nV0qvYf+zEDoY1b 3oyWRktfA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQxhO-001HCe-W8; Mon, 29 Mar 2021 19:37:19 +0000 Received: from mail-bn8nam12on2127.outbound.protection.outlook.com ([40.107.237.127] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQqqu-000dpZ-KS for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 12:18:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RnpvCOnuv8hChhFwCx38l1dbobSGtwrFHcL1AOhBEzXoV0fMKeR61Bt1pNuK5w+4OMrX3jEYV8qEY47XWF/PRVkIIXV9M/0U7cFdEb1EooDPLvaw6oSUWv9j3xdgejK/Si5Qh/lB8j29fz/mWWhgGOGK6ztxVBP/AtuqEvfIb2nDMMdmQJsXYNrky0aK6abXY+n9wVtPzC6ZUAwSE5S2B7HtdMviuus5XUaueuT1Tvmv8eWwo5KmJqaZWGw7+87hik8dvPV/mTwSJINCWbq93WaF+vfH41Bnu+C621cqcIgr6MCimOGzvcsVnAG8i9e7ldKbiA1o/qFcHV6mH45cpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmTD/UAk6wbBkI+OBSheNaNjRlvzJADBqzqKzbZAtIk=; b=IWinMc8CuQs8UaQHnl52DTr06JZr1zt63CHC4eaNRijLUQR9kVt+BpgeFEhb8ONa5OMYmiVfXuNzfynHZIfqbXxl33f6H0I1EasvBr2Jd4uljBNtbwRDLihArsoICQTWaNdP/GXxS8dbKAwfI40NyaJ5w658Bq8cEFzidzntBFlc0ZxxIw+gXqqa45B09llYeFHzJ17EbMVllr6zOUWqGTKKLsFrzZWL4l+42Qpt5Y52+tPoyT8DUZedjgepk/UG7Y1dqF+jAba9plc/mMt0hdZ2T1eXsscQC6PvE2KzP/hPpLDApvNHK/UPx8haAwCXsATiF3vtBZjL1hltVqM0lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmTD/UAk6wbBkI+OBSheNaNjRlvzJADBqzqKzbZAtIk=; b=T0FETEOXm0UbUJ53d4MqR/bZN3hEtLWLjWYN3BZzkqqY+EYMiVhFX31o6o+lj3krNiXbZaA0JX8dIYlYYrXc5XGjMP0fmywK6R3s2F5R/E5puDyFn9wX/X0xVadMDcj9ZyQOTx8Qvo0nB8pVwSw4A4Zozh8zqDv9v9iDBHuX4Hk= Authentication-Results: acm.org; dkim=none (message not signed) header.d=none;acm.org; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by CO2PR01MB2198.prod.exchangelabs.com (2603:10b6:102:10::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Mon, 29 Mar 2021 12:18:36 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 12:18:35 +0000 From: Quan Nguyen To: Corey Minyard , Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: [PATCH v1 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver Date: Mon, 29 Mar 2021 19:17:58 +0700 Message-Id: <20210329121759.5644-3-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20210329121759.5644-1-quan@os.amperecomputing.com> References: <20210329121759.5644-1-quan@os.amperecomputing.com> X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hcm-sw-17.amperecomputing.com (118.69.219.201) by HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.14 via Frontend Transport; Mon, 29 Mar 2021 12:18:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 65213569-e6b5-47e3-5b3a-08d8f2acc699 X-MS-TrafficTypeDiagnostic: CO2PR01MB2198: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PnKL6B5ACfK/Pcpf5SKfwkj5sU9lSdHmg2leRmYI9PTRrMj/NUME16dw41oXRgw4z1AeZv4o+/+pgLvrQMzBdOcCQ87JoaPR6IuMcRR/u7RSbgd6oMVKe+MCep+8Rkmus76i7KRxazLtLjjrFX24pweWY7NdH7Osp+/Q/D4OYuPwD7EPNb25G0UmRbrle53tCpknQZ4IiM9uEuNDa2CU1M5gym4IZQ7nTXMdoa/lsgTJeHVB8ga8yR6O9y9YFJXL2NJbPnLmPGmoCPnuOWGa2dwi5An2bxBHk1F1NKJqW4lhTPluV8YiRYWaoKhHv63blAV3oXlBZ6Oc5PmJUrJqkjHu4BgzrXDJrJ3IIzZxvYKtnkM5hKUifCCZ8gUqV28Z5wcsrh24XQfyCwZJlIpxZw3j31SBB+U6YB28Qs7vS3gvpgdJRAVjqenV0zCFLdD2vXxr/5apHeTmjJ8WXdAd7jciFXlyi9ctqUTLXAmtNhJYX9ZOmwPpHS9VOfzPGS+Agw9V7YaMTHTt+ODOqpdblRy5eIczcOq//5ix8kTG3f8W+7GZd2XXUswlIpGrS7KmEuQap4zTBLe3ihtRaFGsLykEVq/gVMHtFsAp0+yakANAbLjfCBzy5p+BCYtVaJGXsmVr+ktTuV/YYueA3uFpuVhSWqS55PzVTqYyXr7KzFY7xCvN2zp7/5AYz8SuKK3WyRVRgzoTrdHEGeh0nPratKB4+RFS5PLKi+lAnlNcnQIPB1MZDrpsrh75YRx+5CO2CFc837z0Vpgps3DcCPN3dw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR0102MB3482.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39840400004)(366004)(136003)(376002)(346002)(66476007)(54906003)(52116002)(38100700001)(110136005)(66946007)(6506007)(316002)(86362001)(478600001)(107886003)(30864003)(8936002)(186003)(2616005)(66556008)(16526019)(4326008)(6666004)(26005)(8676002)(956004)(1076003)(7416002)(5660300002)(2906002)(83380400001)(921005)(6486002)(6512007)(2004002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?q?PCkmBS4pe3C0uhZrk5IOthZznBhc0y?= =?utf-8?q?02WZZfwh3Q7xeFqf3yKwEqFcs+oX+xsBilVblGKn+8vLwDhV0wUN0mHl0MD6H/QVL?= =?utf-8?q?7uS6WVG2L4jKxrKTuzqRcLl3URDomN/8Pd6JxYk5SVWNRXJzeidJHhleMxHlreZTt?= =?utf-8?q?jamLdIqg5oOwV/QeQ2SnsBcd/xd19SeRl4RfhTVS+XegQtEnJtOtURZFalsJfPkn7?= =?utf-8?q?qDBCYul52V69ICmFS27X+YIUx8W5D4rfwaRn82gkf9rlrn3hcdfFhXg99Sw9s118i?= =?utf-8?q?Fglpgg6R2Lt9GxmzyuBnBeM25EjCh0YHhmMG/IVBcTeatpetTeFBA4f9ouZzJVdQX?= =?utf-8?q?aF8KfxM9hpyGnG+yYCrm3Rr7EiDVerzWESsoEIRSeh+jaUomVizFk7WT0KtHzNtOY?= =?utf-8?q?YOLTsOcGxXa+tPDbT5sAgpUhPiItuvRULTq35NHqTJ60U1bD7/nEzyPOBBR7hd0W9?= =?utf-8?q?D9l2Oylfe2kYWhnHdkfvqMbtHdHkQTFSaUomnbAkv0MaCQzCCIzECLx+1ABURTX1B?= =?utf-8?q?MvzJDoP2qmMiYeubziF3PzsyedqXq4pQ70RGsXbZ7SpwQmwdjAGTiCjK5JR5LSbcB?= =?utf-8?q?GaXmRRMviyBES1yEIRTHVGr9d5lGtJYLk92tskZq5r7cNnoKmeuPbivTrG+30bPO2?= =?utf-8?q?DvJvCF32Z0+j5NGnBV88Jelvysjyz2ulAVJ2ErQXz51Yay/ifwNtmVbNXRLOmcVGU?= =?utf-8?q?0nARmJVkerpEwQvwNDrTNgPASQmkcwqEbUVEFhrvsmpd7D6nDMizCLCkXUGD1pod2?= =?utf-8?q?KfklkZvvYZW3Jj4OtsSKq52Ij6dv/GMPDRWvUl/oAxfhWCNhYC+Mysj4k3RFAh5fA?= =?utf-8?q?pSQgkII/4Celj+yOL96aApttuojjC6VmpZ2AgpxspKogjYOKUTFxwiMKPAR4Pjrq+?= =?utf-8?q?oVPH6ZMtjx4xRUvAL5rf49/Xs4+LRkaLxyBgFmKU7ULeBFRRIs65cEoUjAGRybiCr?= =?utf-8?q?+sJ26yvn4WYMmZ34sMRmfi9eE+M15YUiCPMMxIbeoHbWx7C4SQCBjx+b5FHJuw+GJ?= =?utf-8?q?Dsa5WT5IJkcNm7S6RplSt49P+7e0LqZz0WEV+psFOow8gR83pTgMW28PQBlwVPrzy?= =?utf-8?q?3WHpKEArebUfQlHJIeu2Ev6ZpWTsVP71IOokVIIpZwMmbsE63jjm87iA9uiT9v3jO?= =?utf-8?q?UmYG/BjkEjo96rjC+HqSdgXwAjceMi022qftILv7uEjh4XOJQ3PT6fM1WUw2wO144?= =?utf-8?q?Rwyqg5uX9WNAG0DvWTxK9LFUo+AYgF/8qqmr1Y6+z7/ERgkHKexFKRIVq0kCP9bwY?= =?utf-8?q?8Iq2iH0ZoL+I4o?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65213569-e6b5-47e3-5b3a-08d8f2acc699 X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 12:18:35.8407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +OwnOBrE/2VDJy3e8/ersuCkhUdzNgL+zkDVhXJ8T27vuTYH7gB0efSyp3MkqIhIDaTFVgzhHQeBKi04nWVhR3NXnkF+9Ud8G25VL6ao9UQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR01MB2198 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_131840_987151_65578AEE X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The SMBus system interface (SSIF) IPMI BMC driver can be used to perform in-band IPMI communication with their host in management (BMC) side. This commits adds support specifically for Aspeed AST2500 which commonly used as Board Management Controllers. Signed-off-by: Quan Nguyen Reported-by: kernel test robot --- drivers/char/ipmi/Kconfig | 22 + drivers/char/ipmi/Makefile | 2 + drivers/char/ipmi/ssif_bmc.c | 645 ++++++++++++++++++++++++++++ drivers/char/ipmi/ssif_bmc.h | 92 ++++ drivers/char/ipmi/ssif_bmc_aspeed.c | 132 ++++++ 5 files changed, 893 insertions(+) create mode 100644 drivers/char/ipmi/ssif_bmc.c create mode 100644 drivers/char/ipmi/ssif_bmc.h create mode 100644 drivers/char/ipmi/ssif_bmc_aspeed.c diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index 07847d9a459a..d67fd204409a 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -133,6 +133,28 @@ config ASPEED_BT_IPMI_BMC found on Aspeed SOCs (AST2400 and AST2500). The driver implements the BMC side of the BT interface. +config SSIF_IPMI_BMC + tristate "SSIF IPMI BMC driver" + help + This enables the IPMI SMBus system interface (SSIF) at the + management (BMC) side. + + The driver implements the BMC side of the SMBus system + interface (SSIF). + +config ASPEED_SSIF_IPMI_BMC + depends on ARCH_ASPEED || COMPILE_TEST + depends on I2C + select SSIF_IPMI_BMC + select I2C_SLAVE + tristate "Aspeed SSIF IPMI BMC driver" + help + Provides a driver for the SSIF IPMI interface found on + Aspeed AST2500 SoC. + + The driver implements the BMC side of the SMBus system + interface (SSIF), specific for Aspeed AST2500 SoC. + config IPMB_DEVICE_INTERFACE tristate 'IPMB Interface handler' depends on I2C diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile index 0822adc2ec41..05b993f7335b 100644 --- a/drivers/char/ipmi/Makefile +++ b/drivers/char/ipmi/Makefile @@ -27,3 +27,5 @@ obj-$(CONFIG_ASPEED_BT_IPMI_BMC) += bt-bmc.o obj-$(CONFIG_ASPEED_KCS_IPMI_BMC) += kcs_bmc_aspeed.o obj-$(CONFIG_NPCM7XX_KCS_IPMI_BMC) += kcs_bmc_npcm7xx.o obj-$(CONFIG_IPMB_DEVICE_INTERFACE) += ipmb_dev_int.o +obj-$(CONFIG_SSIF_IPMI_BMC) += ssif_bmc.o +obj-$(CONFIG_ASPEED_SSIF_IPMI_BMC) += ssif_bmc_aspeed.o diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c new file mode 100644 index 000000000000..ae6e8750c795 --- /dev/null +++ b/drivers/char/ipmi/ssif_bmc.c @@ -0,0 +1,645 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * The driver for BMC side of SSIF interface + * + * Copyright (c) 2021, Ampere Computing LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "ssif_bmc.h" + +/* + * Call in WRITE context + */ +static int send_ssif_bmc_response(struct ssif_bmc_ctx *ssif_bmc, bool non_blocking) +{ + unsigned long flags; + int ret; + + if (!non_blocking) { +retry: + ret = wait_event_interruptible(ssif_bmc->wait_queue, + !ssif_bmc->response_in_progress); + if (ret) + return ret; + } + + spin_lock_irqsave(&ssif_bmc->lock, flags); + if (ssif_bmc->response_in_progress) { + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + if (non_blocking) + return -EAGAIN; + + goto retry; + } + + /* + * Check the response data length from userspace to determine the type + * of the response message whether it is single-part or multi-part. + */ + ssif_bmc->is_singlepart_read = + (ssif_msg_len(&ssif_bmc->response) <= (MAX_PAYLOAD_PER_TRANSACTION + 1)) ? + true : false; /* 1: byte of length */ + + ssif_bmc->response_in_progress = true; + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + + return 0; +} + +/* + * Call in READ context + */ +static int receive_ssif_bmc_request(struct ssif_bmc_ctx *ssif_bmc, bool non_blocking) +{ + unsigned long flags; + int ret; + + if (!non_blocking) { +retry: + ret = wait_event_interruptible(ssif_bmc->wait_queue, + ssif_bmc->request_available); + if (ret) + return ret; + } + + spin_lock_irqsave(&ssif_bmc->lock, flags); + if (!ssif_bmc->request_available) { + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + if (non_blocking) + return -EAGAIN; + goto retry; + } + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + + return 0; +} + +/* Handle SSIF message that will be sent to user */ +static ssize_t ssif_bmc_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) +{ + struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file); + struct ssif_msg msg; + unsigned long flags; + ssize_t ret; + + mutex_lock(&ssif_bmc->file_mutex); + + ret = receive_ssif_bmc_request(ssif_bmc, file->f_flags & O_NONBLOCK); + if (ret < 0) + goto out; + + spin_lock_irqsave(&ssif_bmc->lock, flags); + count = min_t(ssize_t, count, ssif_msg_len(&ssif_bmc->request)); + memcpy(&msg, &ssif_bmc->request, count); + ssif_bmc->request_available = false; + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + + ret = copy_to_user(buf, &msg, count); +out: + mutex_unlock(&ssif_bmc->file_mutex); + + return (ret < 0) ? ret : count; +} + +/* Handle SSIF message that is written by user */ +static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t count, + loff_t *ppos) +{ + struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file); + struct ssif_msg msg; + unsigned long flags; + ssize_t ret; + + if (count > sizeof(struct ssif_msg)) + return -EINVAL; + + mutex_lock(&ssif_bmc->file_mutex); + + ret = copy_from_user(&msg, buf, count); + if (ret) + goto out; + + spin_lock_irqsave(&ssif_bmc->lock, flags); + if (count >= ssif_msg_len(&ssif_bmc->response)) + memcpy(&ssif_bmc->response, &msg, count); + else + ret = -EINVAL; + spin_unlock_irqrestore(&ssif_bmc->lock, flags); + + if (ret) + goto out; + + ret = send_ssif_bmc_response(ssif_bmc, file->f_flags & O_NONBLOCK); + if (!ret && ssif_bmc->set_ssif_bmc_status) + ssif_bmc->set_ssif_bmc_status(ssif_bmc, SSIF_BMC_READY); +out: + mutex_unlock(&ssif_bmc->file_mutex); + + return (ret < 0) ? ret : count; +} + +static long ssif_bmc_ioctl(struct file *file, unsigned int cmd, unsigned long param) +{ + return 0; +} + +static unsigned int ssif_bmc_poll(struct file *file, poll_table *wait) +{ + struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file); + unsigned int mask = 0; + + mutex_lock(&ssif_bmc->file_mutex); + poll_wait(file, &ssif_bmc->wait_queue, wait); + + /* + * The request message is now available so userspace application can + * get the request + */ + if (ssif_bmc->request_available) + mask |= POLLIN; + + mutex_unlock(&ssif_bmc->file_mutex); + return mask; +} + +/* + * System calls to device interface for user apps + */ +static const struct file_operations ssif_bmc_fops = { + .owner = THIS_MODULE, + .read = ssif_bmc_read, + .write = ssif_bmc_write, + .poll = ssif_bmc_poll, + .unlocked_ioctl = ssif_bmc_ioctl, +}; + +/* Called with ssif_bmc->lock held. */ +static int handle_request(struct ssif_bmc_ctx *ssif_bmc) +{ + if (ssif_bmc->set_ssif_bmc_status) + ssif_bmc->set_ssif_bmc_status(ssif_bmc, SSIF_BMC_BUSY); + + /* Request message is available to process */ + ssif_bmc->request_available = true; + /* + * This is the new READ request. + * Clear the response buffer of the previous transaction + */ + memset(&ssif_bmc->response, 0, sizeof(struct ssif_msg)); + wake_up_all(&ssif_bmc->wait_queue); + return 0; +} + +/* Called with ssif_bmc->lock held. */ +static int complete_response(struct ssif_bmc_ctx *ssif_bmc) +{ + /* Invalidate response in buffer to denote it having been sent. */ + ssif_bmc->response.len = 0; + ssif_bmc->response_in_progress = false; + ssif_bmc->nbytes_processed = 0; + ssif_bmc->remain_len = 0; + memset(&ssif_bmc->response_buf, 0, MAX_PAYLOAD_PER_TRANSACTION); + wake_up_all(&ssif_bmc->wait_queue); + return 0; +} + +static void set_multipart_response_buffer(struct ssif_bmc_ctx *ssif_bmc, u8 *val) +{ + u8 response_len = 0; + int idx = 0; + u8 data_len; + + data_len = ssif_bmc->response.len; + switch (ssif_bmc->smbus_cmd) { + case SSIF_IPMI_MULTIPART_READ_START: + /* + * Read Start length is 32 bytes. + * Read Start transfer first 30 bytes of IPMI response + * and 2 special code 0x00, 0x01. + */ + *val = MAX_PAYLOAD_PER_TRANSACTION; + ssif_bmc->remain_len = data_len - MAX_IPMI_DATA_PER_START_TRANSACTION; + ssif_bmc->block_num = 0; + + ssif_bmc->response_buf[idx++] = 0x00; /* Start Flag */ + ssif_bmc->response_buf[idx++] = 0x01; /* Start Flag */ + ssif_bmc->response_buf[idx++] = ssif_bmc->response.netfn_lun; + ssif_bmc->response_buf[idx++] = ssif_bmc->response.cmd; + ssif_bmc->response_buf[idx++] = ssif_bmc->response.payload[0]; + + response_len = MAX_PAYLOAD_PER_TRANSACTION - idx; + + memcpy(&ssif_bmc->response_buf[idx], &ssif_bmc->response.payload[1], + response_len); + break; + + case SSIF_IPMI_MULTIPART_READ_MIDDLE: + /* + * IPMI READ Middle or READ End messages can carry up to 31 bytes + * IPMI data plus block number byte. + */ + if (ssif_bmc->remain_len < MAX_IPMI_DATA_PER_MIDDLE_TRANSACTION) { + /* + * This is READ End message + * Return length is the remaining response data length + * plus block number + * Block number 0xFF is to indicate this is last message + * + * Return length is: remain response plus block number + */ + *val = ssif_bmc->remain_len + 1; + ssif_bmc->block_num = 0xFF; + ssif_bmc->response_buf[idx++] = ssif_bmc->block_num; + response_len = ssif_bmc->remain_len; + } else { + /* + * This is READ Middle message + * Response length is the maximum SMBUS transfer length + * Block number byte is incremented + * Return length is maximum SMBUS transfer length + */ + *val = MAX_PAYLOAD_PER_TRANSACTION; + ssif_bmc->remain_len -= MAX_IPMI_DATA_PER_MIDDLE_TRANSACTION; + response_len = MAX_IPMI_DATA_PER_MIDDLE_TRANSACTION; + ssif_bmc->response_buf[idx++] = ssif_bmc->block_num; + ssif_bmc->block_num++; + } + + memcpy(&ssif_bmc->response_buf[idx], + ssif_bmc->response.payload + 1 + ssif_bmc->nbytes_processed, + response_len); + break; + + default: + /* Do not expect to go to this case */ + pr_err("Error: Unexpected SMBus command received 0x%x\n", ssif_bmc->smbus_cmd); + break; + } + + ssif_bmc->nbytes_processed += response_len; +} + +static void set_singlepart_response_buffer(struct ssif_bmc_ctx *ssif_bmc, u8 *val) +{ + u8 *buf = (u8 *)&ssif_bmc->response; + + /* + * Do not expect the IPMI response has data length 0. + * With some I2C SMBus controllers (Aspeed I2C), return 0 for + * the SMBus Read Request callback might cause bad state for + * the bus. So return 1 byte length so that master will + * resend the Read Request because the length of response is + * less than a normal IPMI response. + * + * Otherwise, return the length of IPMI response + */ + *val = (buf[ssif_bmc->msg_idx]) ? buf[ssif_bmc->msg_idx] : 0x1; +} + +/* Process the IPMI response that will be read by master */ +static void handle_read_processed(struct ssif_bmc_ctx *ssif_bmc, u8 *val) +{ + u8 *buf; + u8 pec_len, addr, len; + u8 pec = 0; + + pec_len = ssif_bmc->pec_support ? 1 : 0; + /* PEC - Start Read Address */ + addr = GET_8BIT_ADDR(ssif_bmc->client->addr); + pec = i2c_smbus_pec(pec, &addr, 1); + /* PEC - SSIF Command */ + pec = i2c_smbus_pec(pec, &ssif_bmc->smbus_cmd, 1); + /* PEC - Restart Write Address */ + addr = addr | 0x01; + pec = i2c_smbus_pec(pec, &addr, 1); + + if (ssif_bmc->is_singlepart_read) { + /* Single-part Read processing */ + buf = (u8 *)&ssif_bmc->response; + + if (ssif_bmc->response.len && ssif_bmc->msg_idx < ssif_bmc->response.len) { + ssif_bmc->msg_idx++; + *val = buf[ssif_bmc->msg_idx]; + } else if (ssif_bmc->response.len && + (ssif_bmc->msg_idx == ssif_bmc->response.len)) { + ssif_bmc->msg_idx++; + *val = i2c_smbus_pec(pec, buf, ssif_msg_len(&ssif_bmc->response)); + } else { + *val = 0; + } + /* Invalidate response buffer to denote it is sent */ + if (ssif_bmc->msg_idx + 1 >= (ssif_msg_len(&ssif_bmc->response) + pec_len)) + complete_response(ssif_bmc); + } else { + /* Multi-part Read processing */ + switch (ssif_bmc->smbus_cmd) { + case SSIF_IPMI_MULTIPART_READ_START: + case SSIF_IPMI_MULTIPART_READ_MIDDLE: + buf = (u8 *)&ssif_bmc->response_buf; + *val = buf[ssif_bmc->msg_idx]; + ssif_bmc->msg_idx++; + break; + default: + /* Do not expect to go to this case */ + pr_err("Error: Unexpected SMBus command received 0x%x\n", + ssif_bmc->smbus_cmd); + break; + } + len = (ssif_bmc->block_num == 0xFF) ? + ssif_bmc->remain_len + 1 : MAX_PAYLOAD_PER_TRANSACTION; + if (ssif_bmc->msg_idx == (len + 1)) { + pec = i2c_smbus_pec(pec, &len, 1); + *val = i2c_smbus_pec(pec, ssif_bmc->response_buf, len); + } + /* Invalidate response buffer to denote last response is sent */ + if (ssif_bmc->block_num == 0xFF && + ssif_bmc->msg_idx > (ssif_bmc->remain_len + pec_len)) { + complete_response(ssif_bmc); + } + } +} + +static void handle_write_received(struct ssif_bmc_ctx *ssif_bmc, u8 *val) +{ + u8 *buf; + u8 smbus_cmd; + + buf = (u8 *)&ssif_bmc->request; + if (ssif_bmc->msg_idx >= sizeof(struct ssif_msg)) + return; + + smbus_cmd = ssif_bmc->smbus_cmd; + switch (smbus_cmd) { + case SSIF_IPMI_SINGLEPART_WRITE: + /* Single-part write */ + buf[ssif_bmc->msg_idx - 1] = *val; + ssif_bmc->msg_idx++; + + break; + case SSIF_IPMI_MULTIPART_WRITE_START: + /* Reset length to zero */ + if (ssif_bmc->msg_idx == 1) + ssif_bmc->request.len = 0; + + fallthrough; + case SSIF_IPMI_MULTIPART_WRITE_MIDDLE: + case SSIF_IPMI_MULTIPART_WRITE_END: + /* Multi-part write, 2nd byte received is length */ + if (ssif_bmc->msg_idx == 1) { + ssif_bmc->request.len += *val; + ssif_bmc->recv_len = *val; + } else { + buf[ssif_bmc->msg_idx - 1 + + ssif_bmc->request.len - ssif_bmc->recv_len] = *val; + } + + ssif_bmc->msg_idx++; + + break; + default: + /* Do not expect to go to this case */ + pr_err("Error: Unexpected SMBus command received 0x%x\n", ssif_bmc->smbus_cmd); + break; + } +} + +static bool validate_pec(struct ssif_bmc_ctx *ssif_bmc) +{ + u8 rpec = 0, cpec = 0; + bool ret = true; + u8 addr, index; + u8 *buf; + + buf = (u8 *)&ssif_bmc->request; + switch (ssif_bmc->smbus_cmd) { + case SSIF_IPMI_SINGLEPART_WRITE: + if ((ssif_bmc->msg_idx - 1) == ssif_msg_len(&ssif_bmc->request)) { + /* PEC is not included */ + ssif_bmc->pec_support = false; + return true; + } + + if ((ssif_bmc->msg_idx - 1) != (ssif_msg_len(&ssif_bmc->request) + 1)) + goto error; + + /* PEC is included */ + ssif_bmc->pec_support = true; + rpec = buf[ssif_bmc->msg_idx - 2]; + addr = GET_8BIT_ADDR(ssif_bmc->client->addr); + cpec = i2c_smbus_pec(cpec, &addr, 1); + cpec = i2c_smbus_pec(cpec, &ssif_bmc->smbus_cmd, 1); + cpec = i2c_smbus_pec(cpec, buf, ssif_msg_len(&ssif_bmc->request)); + if (rpec != cpec) { + pr_err("Bad PEC 0x%02x vs. 0x%02x\n", rpec, cpec); + ret = false; + } + + break; + case SSIF_IPMI_MULTIPART_WRITE_START: + case SSIF_IPMI_MULTIPART_WRITE_MIDDLE: + case SSIF_IPMI_MULTIPART_WRITE_END: + index = ssif_bmc->request.len - ssif_bmc->recv_len; + if ((ssif_bmc->msg_idx - 1 + index) == ssif_msg_len(&ssif_bmc->request)) { + /* PEC is not included */ + ssif_bmc->pec_support = false; + return true; + } + + if ((ssif_bmc->msg_idx - 1 + index) != (ssif_msg_len(&ssif_bmc->request) + 1)) + goto error; + + /* PEC is included */ + ssif_bmc->pec_support = true; + rpec = buf[ssif_bmc->msg_idx - 2 + index]; + addr = GET_8BIT_ADDR(ssif_bmc->client->addr); + cpec = i2c_smbus_pec(cpec, &addr, 1); + cpec = i2c_smbus_pec(cpec, &ssif_bmc->smbus_cmd, 1); + cpec = i2c_smbus_pec(cpec, &ssif_bmc->recv_len, 1); + /* As SMBus specification does not allow the length + * (byte count) in the Write-Block protocol to be zero. + * Therefore, it is illegal to have the last Middle + * transaction in the sequence carry 32-bytes and have + * a length of ‘0’ in the End transaction. + * But some users may try to use this way and we should + * prevent ssif_bmc driver broken in this case. + */ + if (ssif_bmc->recv_len != 0) + cpec = i2c_smbus_pec(cpec, buf + 1 + index, ssif_bmc->recv_len); + + if (rpec != cpec) { + pr_err("Bad PEC 0x%02x vs. 0x%02x\n", rpec, cpec); + ret = false; + } + + break; + default: + break; + } + + return ret; +error: + /* Do not expect to go to this case */ + pr_err("Error: Unexpected length received %d\n", ssif_msg_len(&ssif_bmc->request)); + + return false; +} + +static void complete_write_received(struct ssif_bmc_ctx *ssif_bmc) +{ + u8 cmd = ssif_bmc->smbus_cmd; + + /* A BMC that receives an invalid PEC shall drop the data for the write + * transaction and any further transactions (read or write) until + * the next valid read or write Start transaction is received + */ + if (!validate_pec(ssif_bmc)) { + pr_err("Received invalid PEC\n"); + return; + } + + if (cmd == SSIF_IPMI_SINGLEPART_WRITE || cmd == SSIF_IPMI_MULTIPART_WRITE_END) + handle_request(ssif_bmc); +} + +/* + * Callback function to handle I2C slave events + */ +static int ssif_bmc_cb(struct i2c_client *client, enum i2c_slave_event event, u8 *val) +{ + struct ssif_bmc_ctx *ssif_bmc = i2c_get_clientdata(client); + + spin_lock(&ssif_bmc->lock); + + /* I2C Event Handler: + * I2C_SLAVE_READ_REQUESTED 0x0 + * I2C_SLAVE_WRITE_REQUESTED 0x1 + * I2C_SLAVE_READ_PROCESSED 0x2 + * I2C_SLAVE_WRITE_RECEIVED 0x3 + * I2C_SLAVE_STOP 0x4 + */ + switch (event) { + case I2C_SLAVE_READ_REQUESTED: + ssif_bmc->msg_idx = 0; + if (ssif_bmc->is_singlepart_read) + set_singlepart_response_buffer(ssif_bmc, val); + else + set_multipart_response_buffer(ssif_bmc, val); + break; + + case I2C_SLAVE_WRITE_REQUESTED: + ssif_bmc->msg_idx = 0; + break; + + case I2C_SLAVE_READ_PROCESSED: + handle_read_processed(ssif_bmc, val); + break; + + case I2C_SLAVE_WRITE_RECEIVED: + /* + * First byte is SMBUS command, not a part of SSIF message. + * SSIF request buffer starts with msg_idx 1 for the first + * buffer byte. + */ + if (ssif_bmc->msg_idx == 0) { + /* SMBUS command can vary (single or multi-part) */ + ssif_bmc->smbus_cmd = *val; + ssif_bmc->msg_idx++; + } else { + handle_write_received(ssif_bmc, val); + } + + break; + + case I2C_SLAVE_STOP: + /* + * PEC byte is appended at the end of each transaction. + * Detect PEC is support or not after receiving write request + * completely. + */ + if (ssif_bmc->last_event == I2C_SLAVE_WRITE_RECEIVED) + complete_write_received(ssif_bmc); + /* Reset message index */ + ssif_bmc->msg_idx = 0; + break; + + default: + break; + } + ssif_bmc->last_event = event; + spin_unlock(&ssif_bmc->lock); + + return 0; +} + +struct ssif_bmc_ctx *ssif_bmc_alloc(struct i2c_client *client, int sizeof_priv) +{ + struct ssif_bmc_ctx *ssif_bmc; + int ret; + + ssif_bmc = devm_kzalloc(&client->dev, sizeof(*ssif_bmc) + sizeof_priv, GFP_KERNEL); + if (!ssif_bmc) + return ERR_PTR(-ENOMEM); + + spin_lock_init(&ssif_bmc->lock); + + init_waitqueue_head(&ssif_bmc->wait_queue); + ssif_bmc->request_available = false; + ssif_bmc->response_in_progress = false; + + mutex_init(&ssif_bmc->file_mutex); + + /* Register misc device interface */ + ssif_bmc->miscdev.minor = MISC_DYNAMIC_MINOR; + ssif_bmc->miscdev.name = DEVICE_NAME; + ssif_bmc->miscdev.fops = &ssif_bmc_fops; + ssif_bmc->miscdev.parent = &client->dev; + ret = misc_register(&ssif_bmc->miscdev); + if (ret) + goto out; + + ssif_bmc->client = client; + ssif_bmc->client->flags |= I2C_CLIENT_SLAVE; + + /* Register I2C slave */ + i2c_set_clientdata(client, ssif_bmc); + ret = i2c_slave_register(client, ssif_bmc_cb); + if (ret) { + misc_deregister(&ssif_bmc->miscdev); + goto out; + } + + return ssif_bmc; + +out: + devm_kfree(&client->dev, ssif_bmc); + return ERR_PTR(ret); +} +EXPORT_SYMBOL(ssif_bmc_alloc); + +MODULE_AUTHOR("Chuong Tran "); +MODULE_AUTHOR("Quan Nguyen "); +MODULE_DESCRIPTION("Linux device driver of the BMC IPMI SSIF interface."); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/char/ipmi/ssif_bmc.h b/drivers/char/ipmi/ssif_bmc.h new file mode 100644 index 000000000000..a2ee090572db --- /dev/null +++ b/drivers/char/ipmi/ssif_bmc.h @@ -0,0 +1,92 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * The driver for BMC side of SSIF interface + * + * Copyright (c) 2021, Ampere Computing LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ +#ifndef __SSIF_BMC_H__ +#define __SSIF_BMC_H__ + +#define DEVICE_NAME "ipmi-ssif-host" + +#define GET_8BIT_ADDR(addr_7bit) (((addr_7bit) << 1) & 0xff) + +#define MSG_PAYLOAD_LEN_MAX 252 + +/* A standard SMBus Transaction is limited to 32 data bytes */ +#define MAX_PAYLOAD_PER_TRANSACTION 32 + +#define MAX_IPMI_DATA_PER_START_TRANSACTION 30 +#define MAX_IPMI_DATA_PER_MIDDLE_TRANSACTION 31 + +#define SSIF_IPMI_SINGLEPART_WRITE 0x2 +#define SSIF_IPMI_SINGLEPART_READ 0x3 +#define SSIF_IPMI_MULTIPART_WRITE_START 0x6 +#define SSIF_IPMI_MULTIPART_WRITE_MIDDLE 0x7 +#define SSIF_IPMI_MULTIPART_WRITE_END 0x8 +#define SSIF_IPMI_MULTIPART_READ_START 0x3 +#define SSIF_IPMI_MULTIPART_READ_MIDDLE 0x9 + +struct ssif_msg { + u8 len; + u8 netfn_lun; + u8 cmd; + u8 payload[MSG_PAYLOAD_LEN_MAX]; +} __packed; + +static inline u32 ssif_msg_len(struct ssif_msg *ssif_msg) +{ + return ssif_msg->len + 1; +} + +#define SSIF_BMC_BUSY 0x01 +#define SSIF_BMC_READY 0x02 + +struct ssif_bmc_ctx { + struct i2c_client *client; + struct miscdevice miscdev; + u8 smbus_cmd; + struct ssif_msg request; + bool request_available; + struct ssif_msg response; + bool response_in_progress; + /* Response buffer for Multi-part Read Transaction */ + u8 response_buf[MAX_PAYLOAD_PER_TRANSACTION]; + /* Flag to identify a Multi-part Read Transaction */ + bool is_singlepart_read; + u8 nbytes_processed; + u8 remain_len; + u8 recv_len; + /* Block Number of a Multi-part Read Transaction */ + u8 block_num; + size_t msg_idx; + enum i2c_slave_event last_event; + bool pec_support; + spinlock_t lock; + wait_queue_head_t wait_queue; + struct mutex file_mutex; + void (*set_ssif_bmc_status)(struct ssif_bmc_ctx *ssif_bmc, unsigned int flags); + void *priv; +}; + +static inline struct ssif_bmc_ctx *to_ssif_bmc(struct file *file) +{ + return container_of(file->private_data, struct ssif_bmc_ctx, miscdev); +} + +struct ssif_bmc_ctx *ssif_bmc_alloc(struct i2c_client *client, int sizeof_priv); + +#endif /* __SSIF_BMC_H__ */ diff --git a/drivers/char/ipmi/ssif_bmc_aspeed.c b/drivers/char/ipmi/ssif_bmc_aspeed.c new file mode 100644 index 000000000000..02abfca90986 --- /dev/null +++ b/drivers/char/ipmi/ssif_bmc_aspeed.c @@ -0,0 +1,132 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * The driver for BMC side of Aspeed SSIF interface + * + * Copyright (c) 2021, Ampere Computing LLC + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include +#include +#include +#include +#include + +#include "ssif_bmc.h" + +struct aspeed_i2c_bus { + struct i2c_adapter adap; + struct device *dev; + void __iomem *base; + struct reset_control *rst; + /* Synchronizes I/O mem access to base. */ + spinlock_t lock; +}; + +#define ASPEED_I2C_INTR_CTRL_REG 0x0c +#define ASPEED_I2CD_INTR_SLAVE_MATCH BIT(7) +#define ASPEED_I2CD_INTR_RX_DONE BIT(2) +void aspeed_i2c_enable_interrupt(struct aspeed_i2c_bus *bus, unsigned long mask) +{ + unsigned long current_mask; + + current_mask = readl(bus->base + ASPEED_I2C_INTR_CTRL_REG); + writel(current_mask | mask, bus->base + ASPEED_I2C_INTR_CTRL_REG); +} + +void aspeed_i2c_disable_interrupt(struct aspeed_i2c_bus *bus, unsigned long mask) +{ + unsigned long current_mask; + + current_mask = readl(bus->base + ASPEED_I2C_INTR_CTRL_REG); + writel(current_mask & ~mask, bus->base + ASPEED_I2C_INTR_CTRL_REG); +} + +void aspeed_set_ssif_bmc_status(struct ssif_bmc_ctx *ssif_bmc, unsigned int status) +{ + struct aspeed_i2c_bus *bus; + unsigned long flags; + + bus = (struct aspeed_i2c_bus *)ssif_bmc->priv; + if (!bus) + return; + + spin_lock_irqsave(&bus->lock, flags); + + if (status & SSIF_BMC_BUSY) { + /* Ignore RX_DONE and SLAVE_MATCH when slave busy processing */ + aspeed_i2c_disable_interrupt(bus, ASPEED_I2CD_INTR_RX_DONE); + aspeed_i2c_disable_interrupt(bus, ASPEED_I2CD_INTR_SLAVE_MATCH); + } else if (status & SSIF_BMC_READY) { + /* Enable RX_DONE and SLAVE_MATCH when slave ready */ + aspeed_i2c_enable_interrupt(bus, ASPEED_I2CD_INTR_RX_DONE); + aspeed_i2c_enable_interrupt(bus, ASPEED_I2CD_INTR_SLAVE_MATCH); + } + + spin_unlock_irqrestore(&bus->lock, flags); +} + +static int ssif_bmc_probe(struct i2c_client *client, const struct i2c_device_id *id) +{ + struct ssif_bmc_ctx *ssif_bmc; + + ssif_bmc = ssif_bmc_alloc(client, sizeof(struct aspeed_i2c_bus)); + if (IS_ERR(ssif_bmc)) + return PTR_ERR(ssif_bmc); + + ssif_bmc->priv = i2c_get_adapdata(client->adapter); + ssif_bmc->set_ssif_bmc_status = aspeed_set_ssif_bmc_status; + + return 0; +} + +static int ssif_bmc_remove(struct i2c_client *client) +{ + struct ssif_bmc_ctx *ssif_bmc = i2c_get_clientdata(client); + + i2c_slave_unregister(client); + misc_deregister(&ssif_bmc->miscdev); + + return 0; +} + +static const struct of_device_id ssif_bmc_match[] = { + { .compatible = "aspeed,ast2500-ssif-bmc" }, + { }, +}; + +static const struct i2c_device_id ssif_bmc_id[] = { + { DEVICE_NAME, 0 }, + { }, +}; + +MODULE_DEVICE_TABLE(i2c, ssif_bmc_id); + +static struct i2c_driver ssif_bmc_driver = { + .driver = { + .name = DEVICE_NAME, + .of_match_table = ssif_bmc_match, + }, + .probe = ssif_bmc_probe, + .remove = ssif_bmc_remove, + .id_table = ssif_bmc_id, +}; + +module_i2c_driver(ssif_bmc_driver); + +MODULE_AUTHOR("Chuong Tran "); +MODULE_AUTHOR("Quan Nguyen "); +MODULE_DESCRIPTION("Linux device driver of Aspeed BMC IPMI SSIF interface."); +MODULE_LICENSE("GPL v2"); From patchwork Mon Mar 29 12:17:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quan Nguyen X-Patchwork-Id: 12170903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8F5C433E0 for ; Mon, 29 Mar 2021 19:44:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BD9A617C9 for ; Mon, 29 Mar 2021 19:44:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BD9A617C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W0U1xQ1WvBrpT2h4QgUyvi3iPWT0p8PMvFaG1P5I8+g=; b=rJMbf6xabx63YZbEwcPAPazVT D9L0C0LHz+lMGIDVgSe+NpRy74hoKyYWgy2yHaJ/T8m/mySSD39hhPxccaCElUV/u3cEzIxH+CQWQ 9FdtsPAgrE6lJuP+jOAus/izXrNec27cR1AIwMjE2sG4wlQwEYbXU8N58zr3BqKsQVyoG8f5YzAgk BTdA4VxS0NjsFJ3RysHXtylVsCzGnZ/7y19ZOn0nbR8+u3+Rh8m3389kbgGKpiSzjMjIIHckNRpX1 AvN6Hl2nc89nUxh15knj37gZpHsq49Jw4XOT6FIj2ak67P5hCtn1qjoe+J0VO4teffzPCyT4PaqVh crQNcu/bA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQxhu-001HLN-5g; Mon, 29 Mar 2021 19:37:50 +0000 Received: from mail-mw2nam12on2126.outbound.protection.outlook.com ([40.107.244.126] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQqqy-000dq2-O1 for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 12:18:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVO8+G/yVE+0hzptPYhPgxrRr1uvDpCDnALSPGpGynussmHgABuUUhmMkDPmGo4t23U9HMQlg34VTaUlZltvgwaKwD3rIPM+IZ66S1FDm8Eb1WZB01AQtKQ7qi0yVgNRJLJ8iYzpI6s8QwJ81d8LgcC93QksgHYpUrZP5c8Uq0NulWBXfeNXjCx8MaX+S7WyMjCiff/v7dRUOp42wFwOsHcflW7kU95z/H59NyN3LEQGpOT7yx+LSfBe2zhGRVYMpChg5dtARdlIUQkui/wETNmC9yDKFYwV7LSm3wcXdVN1CKmNRawQZNqUF/alMIB5VFlwdzkXiEx8d44yIeJD4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDKOwdplJFsue3nynYNcN8vpg88fsI9i8TnpdlofzgA=; b=lCM/QLpKeATeGO2wpydCHh2LCaT2H35IhkTiLDNN38onjGx9QjRcv2jlRPyoRVoRhdZX/a7LOx+1PY628Hg4750EkIIrN9v9taNsqIjvT4QMyKhrbsrrjZZyf4FUxGBE4qEJBm5bYYDDSsiQZ7kttRzPhCKP88hzKYhjCNBLa3YMOlH93BCxhKmYz/YFEL2yzRbIK8i+ouMVUFrRcjv071hU8lFSd9ANB+94BCGkFVQF8rQi4En8e/ZUKzPX3YIaBTOJpwnys6Y/s9ZoAU5IwrhKrBWZbZ91UFUWmyeRoTQlshKjF4YclgO/frHB8rVGT5JD6Dlxap/utQI3jiMIpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDKOwdplJFsue3nynYNcN8vpg88fsI9i8TnpdlofzgA=; b=aXNDbJms5Jic0RFSuN6MwiTMAihgavQS/svT+7eTUf2OcJSiy2fUnVcHoJPdNcd82PkARKmzCW9zjmbA10PbnVeB4m0Bgf8ZDBYz1WJkdNyAfbjsCu4v1sWvJ7N7VVJ56oSHuY6EAP9g5zyifLnsPOX/LSijJPNaWeM2DXYcACs= Authentication-Results: acm.org; dkim=none (message not signed) header.d=none;acm.org; dmarc=none action=none header.from=os.amperecomputing.com; Received: from MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) by CO1PR01MB6679.prod.exchangelabs.com (2603:10b6:303:f5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Mon, 29 Mar 2021 12:18:40 +0000 Received: from MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503]) by MW2PR0102MB3482.prod.exchangelabs.com ([fe80::d840:7aa7:58d4:b503%5]) with mapi id 15.20.3977.033; Mon, 29 Mar 2021 12:18:40 +0000 From: Quan Nguyen To: Corey Minyard , Rob Herring , Joel Stanley , Andrew Jeffery , Wolfram Sang , Philipp Zabel , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Cc: openbmc@lists.ozlabs.org, Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: [PATCH v1 3/3] bindings: ipmi: Add binding for Aspeed SSIF BMC driver Date: Mon, 29 Mar 2021 19:17:59 +0700 Message-Id: <20210329121759.5644-4-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20210329121759.5644-1-quan@os.amperecomputing.com> References: <20210329121759.5644-1-quan@os.amperecomputing.com> X-Originating-IP: [118.69.219.201] X-ClientProxiedBy: HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) To MW2PR0102MB3482.prod.exchangelabs.com (2603:10b6:302:c::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hcm-sw-17.amperecomputing.com (118.69.219.201) by HKAPR03CA0027.apcprd03.prod.outlook.com (2603:1096:203:c9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.14 via Frontend Transport; Mon, 29 Mar 2021 12:18:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46ea3989-e7c9-4691-91e2-08d8f2acc942 X-MS-TrafficTypeDiagnostic: CO1PR01MB6679: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZSjvsP07r12ybwdhCSpuKWhi2qRPzMUHkD9LP7+0LoKMfaAm0PuxdfTJT+TZZKwr7iX6OmumHVb9RZdYsbNN7ijBK1FtifjBsqaxjDXLaNQzl0X7IlsYk8kDPzjlFXEqkkpaXANvmymizeJ5V+voI9B3G56/sXWx4YfM8t2LSEljyj1lew39/G1Gn+BhcHyM0BqAbvYHtt3CFKQooPqLY3/3To12deD7lUVYPqgaA40ukKXF4FNod2fNNMefGRyCcuJmbqLkIhhc8V0PxY55YBRXz5gWcNE5RGJ0v+i6hs1hsHulLBEgvRtT/GegInxPi6xsdfSWpsRb3km6VPyq7asVVzQJqXLGizoKbDKHUFkn9OVXJ2/RBE6kwlr0AFXPrHSOcUrDoIYaMhYghuEonTAH5THz4C7pu+0BFEJQcD5gYS1Fbr1fMhyFys500kL83vV8LQSXnW4/cUumd6dCFQ+QCAaVatIaQieMgXYhQTQRUcPvd1AA4tSBEUD4E/zmSwHObGS2eZgLMvhyO68abQ8mo28pf247+U49qf5AgkLpdokWkZvRy77xxLkTyCdhMBoSghnJerbS8iHEsbKFEXbKbYMrTHrxXR8GFKR4Z5yK9+HjYoM7888Qft921bDogTh7jg0E0dTF6CeLb2eJ+0nQq5s66aKDju+tnE5vHl0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR0102MB3482.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(39840400004)(396003)(346002)(136003)(921005)(52116002)(6506007)(66556008)(4326008)(6486002)(16526019)(54906003)(2906002)(107886003)(956004)(6512007)(110136005)(86362001)(8676002)(38100700001)(8936002)(1076003)(66476007)(5660300002)(2616005)(7416002)(316002)(26005)(478600001)(66946007)(6666004)(186003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: /mwKPzIZJsdMvpHpvGdAgrYSiPtlzGwGB1GYOfN08x0zZxp1/rS8DDbEM9cWJaw+w87WhVNFs2+A7ajdBP8Es28azjHTgmqwdqBpWdR55fhXgXXTfN8vmYxXzkLn87yKmS1IJmYmiAjU5ronEEXyBypyP0Gy54YLU0kXWdkirCV86yYJ3yW31mMNv4pOG1S3+ADUEn8y2Uv2w6eKLRkA7f7lR5vQXo3BS0g6SHVAp+UZefRXJuRzogRMGifiAVFSaygfAMVWo6KiY9zPn4e28YZBtmslMELr5bSdWaQZkfsPRPu7xLkLUmzXH15vI4Q6fDeN7yLSCHzYERaNtTLa32gxr06iwSugdltM+46xj79sAh/qpYNjQ6QbSCgWPQ54bS4x30d/1V2XIRQXvhHDgqoPH/eJ9hEoTcYBJeHod1XvFDUORX5OCxRcjw35CizMH/uZa0+vU6w61TdOqbXHFS8LVczPfagPjJBVxbj37P1ma9cdERGptZfGk1DWZ89Ttult2G+6MNVhmxk1y50uPzSw6JCWu+SCpfXXut8MYcw7LZwZnvygzK2/hEuZ742tY/DC+2uA1KMVFnav6NQAeInBEzWZjfoC4bZq4BBhj3uVG8gF7wndF93vjVD/OXLRDcosu5vnGjfHCuV1M5cSH0+BKeju1UiOIW3AeZztPOWRGn86dRBt4f+4djZPhSPx8xvNfX2Ml1DEAj1Hze25W8PThe3azFz8zoRcsDUZlJhLIktjyvB+FjXP1HEC8IFds0hpqETov7NqPdnRP8s0yjVKrkYKTshuquzeUHH5bGRh9c61dgT1zfN6T7VU5JrVu9xfj958q/298Jh/JIbHYqA+xb0DGg6l12poO+BbzntyEsxQNlQ2QNKnvC1s+7Ln91N/4P0pH+0k3hNjBeVLGplOUCLXI/Nr8yAUrEfEVfx70tKqsjiwHGNuCxjU+QS1rroBglQQKIqRYRiwgKNJr3qwJgXXi0eIwv2YHOYMpDn4krx8DKAuewKaHLzwHX+Zs7cnH1Rem9d5tWWKH7/jOqpV6bhVnvvbYSgp0Gz2+WODqNPbpSdACHggK/aB/kW3ekvuVd3TgNFgTCSBoz/lTPoVza0WzuD43GAD3yKQr/Ayx7ne5+0etZJLjrzFtKK2sQVLyuoG2puq4UntYsMefo4IM0cOoDap/8a7cWPhCMGelRPQQ+gB1OrhnXfAS6wh54k50qAVef5PRhowmuS4t4saK7oP1qFvhP32NZ9xfJ1Blsjf80rhqYRjn90DLcdH+Mwq1d4vZdrEQjl8EBTN8AZ756yCtQCQBl50xnRSNbfS60xjktBP/3mORJ3Eg4b5 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46ea3989-e7c9-4691-91e2-08d8f2acc942 X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2021 12:18:40.3891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: reBwA3rMYilNvsFOEQbxHp95W50/CLt8fPjKrcm3lhGa98Mb2P0IDGVPQMYIypkhz63wrULkj7i5acLFH++dNu4wUez2IBQ/LqXepeQKmSs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6679 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_131845_005757_7C583D90 X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add device tree binding document for the Aspeed SSIF BMC driver. Signed-off-by: Quan Nguyen --- .../bindings/ipmi/aspeed-ssif-bmc.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt new file mode 100644 index 000000000000..1616f0188db9 --- /dev/null +++ b/Documentation/devicetree/bindings/ipmi/aspeed-ssif-bmc.txt @@ -0,0 +1,18 @@ +# Aspeed SSIF (SMBus system interface) IPMI BMC interface + +The Aspeed AST2500 are commonly used as BMCs (Baseboard Management Controllers) +and the SSIF slave interface can be used to perform in-band IPMI communication +with their host. + +Required properties: + +- compatible : should be + "aspeed,ast2500-ssif-bmc" +- reg: I2C address the registers + +Example: + + ssif-bmc@10 { + compatible = "aspeed,ast2500-ssif-bmc"; + reg = <0x10>; + };