From patchwork Wed Nov 21 16:35:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 10692815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D44D01751 for ; Wed, 21 Nov 2018 16:43:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C212A2C41A for ; Wed, 21 Nov 2018 16:43:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B3AA82C478; Wed, 21 Nov 2018 16:43:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5B61A2C466 for ; Wed, 21 Nov 2018 16:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=VSivvu3PABUrW3Jc6awWwUTbNqfeVs2ertjZutixgZo=; b=deX RdFbELEmBEpWeLdmXit0/ngg/9UO5NPIcjUHSTB3DPN6ohcZaDXtigqCZbYsq/XEGOFlkeIAEe8rx 58mvP2eNhOhSVXiBniV6Yp9dIWXcYVUrG0IB04TFe27fpC6P+kGV54ty3fvzFlW7zLa90THn0oJaJ wTHZYTSlmn7vdqiP0x7kSJrfvgAlcABfras3lMPA2h+ONntMvm9oanOPbxvuiOOsRdPrCdxqETKti GD3LXqL+C2nnLndOJlR4CRDLcOq+d0KhWWcoCF6IrQWUpcSW3kXRktZSselTToMiGxpcSAy+uoaFt ZoIeX+sy+BvMIE2Tk0I2cXBA0t2g1bQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPVag-0004Na-NZ; Wed, 21 Nov 2018 16:43:02 +0000 Received: from www.osadl.org ([62.245.132.105]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gPVac-0004Mk-KI; Wed, 21 Nov 2018 16:43:00 +0000 Received: from debian01.hofrr.at (178.115.242.59.static.drei.at [178.115.242.59]) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id wALGccSH001213; Wed, 21 Nov 2018 17:38:38 +0100 From: Nicholas Mc Guire To: Linus Walleij Subject: [PATCH] gpio: mt7621: handle failure of devm_kasprintf() Date: Wed, 21 Nov 2018 17:35:42 +0100 Message-Id: <1542818142-27800-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 2.1.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181121_084258_962488_974FAEF5 X-CRM114-Status: UNSURE ( 7.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergio Paracuellos , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , linux-mediatek@lists.infradead.org, Nicholas Mc Guire , Matthias Brugger , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP kasprintf() may return NULL on failure of internal allocation thus the assigned label is not safe if not explicitly checked. On error mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the (unlikely) failure case should be fine here. Signed-off-by: Nicholas Mc Guire Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") --- Problem located with experimental coccinelle script Patch was compile tested with: omega2p_defconfig, SOC_MT7621=y, GPIOLIB=y, GPIO_MT7621=y Patch is against 4.20-rc3 (localversion-next is next-20181121) drivers/gpio/gpio-mt7621.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index d72af6f..42f0c67 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -244,6 +244,10 @@ mediatek_gpio_bank_probe(struct device *dev, rg->chip.of_xlate = mediatek_gpio_xlate; rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d", dev_name(dev), bank); + if (!rg->chip.label) { + dev_err(dev, "Could not allocate label\n"); + return -ENOMEM; + } ret = devm_gpiochip_add_data(dev, &rg->chip, mtk); if (ret < 0) {