From patchwork Wed Nov 21 17:33:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 10692877 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3A37617FE for ; Wed, 21 Nov 2018 17:34:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 205972C030 for ; Wed, 21 Nov 2018 17:34:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 141322C122; Wed, 21 Nov 2018 17:34:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B73352C0B9 for ; Wed, 21 Nov 2018 17:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730060AbeKVEJN (ORCPT ); Wed, 21 Nov 2018 23:09:13 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:15667 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727787AbeKVEJN (ORCPT ); Wed, 21 Nov 2018 23:09:13 -0500 X-IronPort-AV: E=Sophos;i="5.56,261,1539640800"; d="scan'208";a="356666851" Received: from 136.3.95.79.rev.sfr.net (HELO hadrien) ([79.95.3.136]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 18:33:52 +0100 Date: Wed, 21 Nov 2018 18:33:51 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Anatolij Gustschin cc: linux-usb@vger.kernel.org, linux-spi@vger.kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, broonie@kernel.org, atull@kernel.org, mdf@kernel.org, kbuild-all@01.org Subject: [PATCH] usb: misc: fix boolconv.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: kbuild test robot drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices") CC: Anatolij Gustschin Signed-off-by: kbuild test robot Signd-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201 :::::: branch date: 17 hours ago :::::: commit date: 17 hours ago Please take the patch only if it's a positive warning. Thanks! ft232h-intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/misc/ft232h-intf.c +++ b/drivers/usb/misc/ft232h-intf.c @@ -813,7 +813,7 @@ static int ftdi_mpsse_gpio_get(struct gp dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset); - low = offset < 5 ? true : false; + low = offset < 5; mutex_lock(&priv->ops_mutex);