From patchwork Fri Apr 2 10:50:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 12180761 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF76C433ED for ; Fri, 2 Apr 2021 10:52:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87A6961103 for ; Fri, 2 Apr 2021 10:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87A6961103 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Iu/ryq+QPufsErMdijL2bteJd3Ztl3lZ6PYFNkQisdA=; b=KAz5Akhjpc7ZyDHH/Htmow5Niw tUlXzYb7FXqh1FwI6KwnZNXxQ0U7sGcVrbTe20udZ5TuvglCc4z5+dfog9bIjHIU0DiDCVSxwofy0 gEFmXi8jRgTYN/uHbUddzxQ/FEUMHKdwYPJvVnPJM8bdtKSam+hM9Jc7uSvbqlIN5v+VWKSeZpVbL DgGKdZavGNSdNfrNd4gTYkggDQm/PlX2FsUnVGyhLkaMW0RbEDdwBp/pjsIGNb8cdEBY7tvKVqUyQ R4H1zTr0WZ09GVjkLeDBYx7ZK/d0jMwJz0xCbL87t9WIO7y8zakVUrDvJnvaWwMRg0v5QPITO4DF1 5BYewb+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lSHNz-00Codd-Jv; Fri, 02 Apr 2021 10:50:43 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lSHNr-00CodH-9L for linux-arm-kernel@lists.infradead.org; Fri, 02 Apr 2021 10:50:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617360635; x=1648896635; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+hFB1fZnifLkBRCu8m8oE8PjCj413ujdaqs2fWQwwIA=; b=WIGtC6/MVq7ThTcFlQFbj+gSzKshhatSkKBUlwm7fjkbmd6CtFhx1jSa X/07ZgjYn7/IO7jTz2TyUv0BmhpyHXnHKE6fNWR+NKJSyiwI5bM7D6wJn OEzjQhuARC7uv8rtBvtEQ38CNraoTuhJGVqYGXuh6p63CnB0rsV2MQ2rH r0hEeMcl7GjY75W4lAfeQsFH1uR40RH+U3ZLoT+F3uqoFwab1mDIG1KSC dqMCBfP6j+0qgNiB1p37rugz337R1tnyN54t+tJH6UebTtfGdOq5fZpN/ qEqEO6lyiwYDB1RDPMIsFRsWB8+TxVuEyqivTnBLLor3oWpFrLGevaC2/ Q==; IronPort-SDR: DmlQURt0aJ7/F5PN6pMUPZw+IyVWj5f8d1Ck3bG8yTCHvABwg0aGkrmLNQoUrUlwg51FRyTgIz jOUoCoKPPkSCrIbaBTk/A9U6+mxAnQjMyMqXET3M0c2Rq4iW7VM623+Owi7i6TKOEmatuYcuXo 8BYI3Hq/4ObA5FtqfZmdndi0fw4ubT3Kn2ZTe7eFsBZekbThpjqMjGzx5bFZxzWchbCymTcpqO NdXpBd4jFsh5MlCEWPRyCaunMhPAIV/EBMjo56Pdf/I0noFNEcbwN5+6a+6ktf/2vIMHqg9aYl pqc= X-IronPort-AV: E=Sophos;i="5.81,299,1610434800"; d="scan'208";a="112251059" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Apr 2021 03:50:29 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 2 Apr 2021 03:50:29 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 2 Apr 2021 03:50:26 -0700 From: Claudiu Beznea To: , , , CC: , , , Claudiu Beznea , kernel test robot , "Dan Carpenter" Subject: [PATCH v2 1/1] power: reset: at91-reset: use devm_of_iomap Date: Fri, 2 Apr 2021 13:50:18 +0300 Message-ID: <20210402105018.2212-1-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210402_115036_226229_107DB3A0 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use devm_of_iomap() to map resources. This will avoid the necessity to track the mapped resources and free them on failure path or on remove. Reported-by: kernel test robot Reported-by: Dan Carpenter Suggested-by: Nicolas Ferre Signed-off-by: Claudiu Beznea --- Changes in v2: - use devm_of_iomap() - change commit description and title to match to the new approach - add Suggested-by tag drivers/power/reset/at91-reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 3ff9d93a5226..026649409135 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -192,7 +192,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) if (!reset) return -ENOMEM; - reset->rstc_base = of_iomap(pdev->dev.of_node, 0); + reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL); if (!reset->rstc_base) { dev_err(&pdev->dev, "Could not map reset controller address\n"); return -ENODEV; @@ -202,7 +202,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) /* we need to shutdown the ddr controller, so get ramc base */ for_each_matching_node_and_match(np, at91_ramc_of_match, &match) { reset->ramc_lpr = (u32)match->data; - reset->ramc_base[idx] = of_iomap(np, 0); + reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL); if (!reset->ramc_base[idx]) { dev_err(&pdev->dev, "Could not map ram controller address\n"); of_node_put(np);