From patchwork Fri Apr 2 20:22:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Uladzislau Rezki (Sony)" X-Patchwork-Id: 12181509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA642C433B4 for ; Fri, 2 Apr 2021 20:22:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7928D6113E for ; Fri, 2 Apr 2021 20:22:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7928D6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBEC86B0093; Fri, 2 Apr 2021 16:22:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6E276B0095; Fri, 2 Apr 2021 16:22:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEA536B0096; Fri, 2 Apr 2021 16:22:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 916176B0093 for ; Fri, 2 Apr 2021 16:22:50 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3D04182F99EC for ; Fri, 2 Apr 2021 20:22:50 +0000 (UTC) X-FDA: 77988550500.07.8FB6AC5 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf28.hostedemail.com (Postfix) with ESMTP id C0E072000259 for ; Fri, 2 Apr 2021 20:22:49 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id o126so9060567lfa.0 for ; Fri, 02 Apr 2021 13:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IMrRePfGs1rF/T8z45CYbyde8SGCiB/0IWN15dBKTJI=; b=K/dv6wv+PFj+4PI8hAV+9SsaiW/csXqkRnIg0Lhz25DtvvFyM5j4fzl5WAlAbqsO+N PAa2YIePQr+RXXRmAxCIVT0HcpHgkZpsN65u1on1d2/XZ1oHKHnDWMJjH9ZD4ms7dYXv r7JhzLv4NQN5Io/A0HWsKHulRwwGxcAHSn07B5GjiZbsmeTXz/heoPGD0Lku7RBtKpiM r253J8ed/4MfFl72mCLyjCEb+0GS/c/T6yH8o0Nqe7QNiir1s6NI1XE5TOlQc80gh9gq rnTPEFs7cwieMQKbyrqBKwyw1SNeh4hE8BKcfyAyUIZ9vanSlTL0nL4jCdAUyktHL8nA pUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=IMrRePfGs1rF/T8z45CYbyde8SGCiB/0IWN15dBKTJI=; b=Njjr+c/l0jo0k3/Xavi1pwuNk3OffNiF0KJegO5ng+nXS038Xg+3VkG5HkNVsu4SKv rtxTYlI9t5PjdzvX5+8HXroJ00KmJu0zX+oQSiTbbUe10TaIEi9Py827m4lHPXqlxK/M tVIrhFZB3dN9ARft5Y+C7mCunKi4TW3+6Q1xZ4MC3+NExO6R+Aeu9Ryqz5kCqRauKhAr vAxmu8SH/3zXpYQ+1jje4g2hUl9zSySEmpqAfeMvZT+X5AZRuIQcaJcLvbPXqa1hmUwv 7zZ4UnCfxo9844avtYFcm9AJEnDGRzzMO2NygZJn6upth1GZdnN2arfq/C2bOOTB49qh 6zSg== X-Gm-Message-State: AOAM533qTymPN8cWzPnL0WdlwT5f6fnl1MMY+u/x3qFTEJAazNojGAhR Gd/aMNG0yiPOBTHgOOFhSNc= X-Google-Smtp-Source: ABdhPJxK5ZwN9Lka2IUo+p5XW2oAQOlP4IKexiSST1atXqp4cdaQFESzv6Asos86tQX1NOCn4tJybg== X-Received: by 2002:a19:2216:: with SMTP id i22mr9727882lfi.57.1617394968170; Fri, 02 Apr 2021 13:22:48 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id f11sm952514lfr.119.2021.04.02.13.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 13:22:47 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH-next 1/5] lib/test_vmalloc.c: remove two kvfree_rcu() tests Date: Fri, 2 Apr 2021 22:22:33 +0200 Message-Id: <20210402202237.20334-1-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C0E072000259 X-Stat-Signature: brju3yzyi3um7z6inuk9uggy8axsbfpw Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-lf1-f53.google.com; client-ip=209.85.167.53 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617394969-564946 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Remove two test cases related to kvfree_rcu() and SLAB. Those are considered as redundant now, because similar test functionality has recently been introduced in the "rcuscale" RCU test-suite. Signed-off-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 40 ---------------------------------------- 1 file changed, 40 deletions(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index 5cf2fe9aab9e..4eb6abdaa74e 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -47,8 +47,6 @@ __param(int, run_test_mask, INT_MAX, "\t\tid: 128, name: pcpu_alloc_test\n" "\t\tid: 256, name: kvfree_rcu_1_arg_vmalloc_test\n" "\t\tid: 512, name: kvfree_rcu_2_arg_vmalloc_test\n" - "\t\tid: 1024, name: kvfree_rcu_1_arg_slab_test\n" - "\t\tid: 2048, name: kvfree_rcu_2_arg_slab_test\n" /* Add a new test case description here. */ ); @@ -363,42 +361,6 @@ kvfree_rcu_2_arg_vmalloc_test(void) return 0; } -static int -kvfree_rcu_1_arg_slab_test(void) -{ - struct test_kvfree_rcu *p; - int i; - - for (i = 0; i < test_loop_count; i++) { - p = kmalloc(sizeof(*p), GFP_KERNEL); - if (!p) - return -1; - - p->array[0] = 'a'; - kvfree_rcu(p); - } - - return 0; -} - -static int -kvfree_rcu_2_arg_slab_test(void) -{ - struct test_kvfree_rcu *p; - int i; - - for (i = 0; i < test_loop_count; i++) { - p = kmalloc(sizeof(*p), GFP_KERNEL); - if (!p) - return -1; - - p->array[0] = 'a'; - kvfree_rcu(p, rcu); - } - - return 0; -} - struct test_case_desc { const char *test_name; int (*test_func)(void); @@ -415,8 +377,6 @@ static struct test_case_desc test_case_array[] = { { "pcpu_alloc_test", pcpu_alloc_test }, { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test }, { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test }, - { "kvfree_rcu_1_arg_slab_test", kvfree_rcu_1_arg_slab_test }, - { "kvfree_rcu_2_arg_slab_test", kvfree_rcu_2_arg_slab_test }, /* Add a new test case here. */ }; From patchwork Fri Apr 2 20:22:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Uladzislau Rezki (Sony)" X-Patchwork-Id: 12181511 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E3FC43460 for ; Fri, 2 Apr 2021 20:22:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 866AE61151 for ; Fri, 2 Apr 2021 20:22:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866AE61151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A27EA6B0095; Fri, 2 Apr 2021 16:22:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D9A76B0098; Fri, 2 Apr 2021 16:22:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78D416B0099; Fri, 2 Apr 2021 16:22:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 568D56B0095 for ; Fri, 2 Apr 2021 16:22:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0049B184B009D for ; Fri, 2 Apr 2021 20:22:50 +0000 (UTC) X-FDA: 77988550542.19.30F2D69 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 354CEC0001FE for ; Fri, 2 Apr 2021 20:22:48 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id o16so6651112ljp.3 for ; Fri, 02 Apr 2021 13:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NlTZYOTP6gxY+A8f1lp9gD0t94fGeKsz+KEdX5TSTq4=; b=IL8emjWCMFzBpzm2REpTKSDItPqwcRHkwDyhpVa+fQUkJHytbmfdiE4bYlyWATY2+w vGTzZ0xBGkMjQPOKifR5x0SRxTG5xC72QHw+kb5i6FZbHNZsW5bB5fBxr6sojWyFhWt4 X1xXaYrNxVN9lblPGDiEvQMy5/KffFH4hkIo8BEUkoY3t793mTbMa9DxGLkN3te4my0o RXKafDau/hoEXeBFpQ4TuNACE7UmlDCyaBx8kX6IhRI6V4d1HnMZ/KogECpPd0Hd3Ub0 53KDDwBj5vpxhBAzPjV0CNJ/XDi9uCuiiJ7J/rXVXGxLoqAYHSZmfWj+F8WQOdZ5e5N+ CtOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NlTZYOTP6gxY+A8f1lp9gD0t94fGeKsz+KEdX5TSTq4=; b=q4J+D0GWncxciuwV7FtXNheWa7XJhLEsWrDdKHiDlMKkaqP1LrV87elr3H5Y6vg8Yw tSp3kj9PmxZTMryYWBXsQ1+9bYndLuMnqyT5CXAlq/6ciyP6xy0tknaVAQ73uvaIp0jv tOpnbKqLSi8aOdbR61J6eUkoxeRPFgLLaSUfBczmnsLqz2iKt8CK67yPFZZMU1ggwuom t5Ib4j/339M59LkgHuk5s+a6tH/tqyGAbDOG/EzXF9TAq9pjnpKyoj3+D7uEsIW+3Iqe YasLik2R5NHBz0vAQoR22T3DasRzzle3JXKnFzWXY4YoBfS1eXBupHdr1vsA3U7vEQuT KzUA== X-Gm-Message-State: AOAM531XWXm+JtYhHrQBhiIqqSaVQMBf8pvgUsJzdWiXbE6nmn+LQlIo 9+wSUTRZa72AXrojRxklFI8= X-Google-Smtp-Source: ABdhPJxrao1ogZYKuL2wEhq0h305cuoO/EgEpfZutWpdL6CCxZVyr0MHx315wkyYwd+B5ezHkncHwQ== X-Received: by 2002:a2e:6e17:: with SMTP id j23mr9128468ljc.209.1617394969128; Fri, 02 Apr 2021 13:22:49 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id f11sm952514lfr.119.2021.04.02.13.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 13:22:48 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH-next 2/5] lib/test_vmalloc.c: add a new 'nr_threads' parameter Date: Fri, 2 Apr 2021 22:22:34 +0200 Message-Id: <20210402202237.20334-2-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210402202237.20334-1-urezki@gmail.com> References: <20210402202237.20334-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 354CEC0001FE X-Stat-Signature: bfncxrzh3spws8p9kzhsh7oiqt7a5m97 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-lj1-f173.google.com; client-ip=209.85.208.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617394968-180089 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: By using this parameter we can specify how many workers are created to perform vmalloc tests. By default it is one CPU. The maximum value is set to 1024. As a result of this change a 'single_cpu_test' one becomes obsolete, therefore it is no longer needed. Signed-off-by: Uladzislau Rezki (Sony) --- lib/test_vmalloc.c | 88 +++++++++++++++++++++------------------------- 1 file changed, 40 insertions(+), 48 deletions(-) diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index 4eb6abdaa74e..d337985e4c5e 100644 --- a/lib/test_vmalloc.c +++ b/lib/test_vmalloc.c @@ -23,8 +23,8 @@ module_param(name, type, 0444); \ MODULE_PARM_DESC(name, msg) \ -__param(bool, single_cpu_test, false, - "Use single first online CPU to run tests"); +__param(int, nr_threads, 0, + "Number of workers to perform tests(min: 1 max: 1024)"); __param(bool, sequential_test_order, false, "Use sequential stress tests order"); @@ -50,13 +50,6 @@ __param(int, run_test_mask, INT_MAX, /* Add a new test case description here. */ ); -/* - * Depends on single_cpu_test parameter. If it is true, then - * use first online CPU to trigger a test on, otherwise go with - * all online CPUs. - */ -static cpumask_t cpus_run_test_mask = CPU_MASK_NONE; - /* * Read write semaphore for synchronization of setup * phase that is done in main thread and workers. @@ -386,16 +379,13 @@ struct test_case_data { u64 time; }; -/* Split it to get rid of: WARNING: line over 80 characters */ -static struct test_case_data - per_cpu_test_data[NR_CPUS][ARRAY_SIZE(test_case_array)]; - static struct test_driver { struct task_struct *task; + struct test_case_data data[ARRAY_SIZE(test_case_array)]; + unsigned long start; unsigned long stop; - int cpu; -} per_cpu_test_driver[NR_CPUS]; +} *tdriver; static void shuffle_array(int *arr, int n) { @@ -423,9 +413,6 @@ static int test_func(void *private) ktime_t kt; u64 delta; - if (set_cpus_allowed_ptr(current, cpumask_of(t->cpu)) < 0) - pr_err("Failed to set affinity to %d CPU\n", t->cpu); - for (i = 0; i < ARRAY_SIZE(test_case_array); i++) random_array[i] = i; @@ -450,9 +437,9 @@ static int test_func(void *private) kt = ktime_get(); for (j = 0; j < test_repeat_count; j++) { if (!test_case_array[index].test_func()) - per_cpu_test_data[t->cpu][index].test_passed++; + t->data[index].test_passed++; else - per_cpu_test_data[t->cpu][index].test_failed++; + t->data[index].test_failed++; } /* @@ -461,7 +448,7 @@ static int test_func(void *private) delta = (u64) ktime_us_delta(ktime_get(), kt); do_div(delta, (u32) test_repeat_count); - per_cpu_test_data[t->cpu][index].time = delta; + t->data[index].time = delta; } t->stop = get_cycles(); @@ -477,53 +464,56 @@ static int test_func(void *private) return 0; } -static void +static int init_test_configurtion(void) { /* - * Reset all data of all CPUs. + * A maximum number of workers is defined as hard-coded + * value and set to 1024. We add such gap just in case + * and for potential heavy stressing. */ - memset(per_cpu_test_data, 0, sizeof(per_cpu_test_data)); + nr_threads = clamp(nr_threads, 1, 1024); - if (single_cpu_test) - cpumask_set_cpu(cpumask_first(cpu_online_mask), - &cpus_run_test_mask); - else - cpumask_and(&cpus_run_test_mask, cpu_online_mask, - cpu_online_mask); + /* Allocate the space for test instances. */ + tdriver = kcalloc(nr_threads, sizeof(*tdriver), GFP_KERNEL); + if (tdriver == NULL) + return -1; if (test_repeat_count <= 0) test_repeat_count = 1; if (test_loop_count <= 0) test_loop_count = 1; + + return 0; } static void do_concurrent_test(void) { - int cpu, ret; + int i, ret; /* * Set some basic configurations plus sanity check. */ - init_test_configurtion(); + ret = init_test_configurtion(); + if (ret < 0) + return; /* * Put on hold all workers. */ down_write(&prepare_for_test_rwsem); - for_each_cpu(cpu, &cpus_run_test_mask) { - struct test_driver *t = &per_cpu_test_driver[cpu]; + for (i = 0; i < nr_threads; i++) { + struct test_driver *t = &tdriver[i]; - t->cpu = cpu; - t->task = kthread_run(test_func, t, "vmalloc_test/%d", cpu); + t->task = kthread_run(test_func, t, "vmalloc_test/%d", i); if (!IS_ERR(t->task)) /* Success. */ atomic_inc(&test_n_undone); else - pr_err("Failed to start kthread for %d CPU\n", cpu); + pr_err("Failed to start %d kthread\n", i); } /* @@ -541,29 +531,31 @@ static void do_concurrent_test(void) ret = wait_for_completion_timeout(&test_all_done_comp, HZ); } while (!ret); - for_each_cpu(cpu, &cpus_run_test_mask) { - struct test_driver *t = &per_cpu_test_driver[cpu]; - int i; + for (i = 0; i < nr_threads; i++) { + struct test_driver *t = &tdriver[i]; + int j; if (!IS_ERR(t->task)) kthread_stop(t->task); - for (i = 0; i < ARRAY_SIZE(test_case_array); i++) { - if (!((run_test_mask & (1 << i)) >> i)) + for (j = 0; j < ARRAY_SIZE(test_case_array); j++) { + if (!((run_test_mask & (1 << j)) >> j)) continue; pr_info( "Summary: %s passed: %d failed: %d repeat: %d loops: %d avg: %llu usec\n", - test_case_array[i].test_name, - per_cpu_test_data[cpu][i].test_passed, - per_cpu_test_data[cpu][i].test_failed, + test_case_array[j].test_name, + t->data[j].test_passed, + t->data[j].test_failed, test_repeat_count, test_loop_count, - per_cpu_test_data[cpu][i].time); + t->data[j].time); } - pr_info("All test took CPU%d=%lu cycles\n", - cpu, t->stop - t->start); + pr_info("All test took worker%d=%lu cycles\n", + i, t->stop - t->start); } + + kfree(tdriver); } static int vmalloc_test_init(void) From patchwork Fri Apr 2 20:22:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Uladzislau Rezki (Sony)" X-Patchwork-Id: 12181513 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1F6C433B4 for ; Fri, 2 Apr 2021 20:22:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C24261154 for ; Fri, 2 Apr 2021 20:22:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C24261154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 285786B0098; Fri, 2 Apr 2021 16:22:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25D8A6B009A; Fri, 2 Apr 2021 16:22:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FEAE6B009B; Fri, 2 Apr 2021 16:22:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id E24D86B0098 for ; Fri, 2 Apr 2021 16:22:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A553282F9870 for ; Fri, 2 Apr 2021 20:22:51 +0000 (UTC) X-FDA: 77988550542.11.6D638B8 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf02.hostedemail.com (Postfix) with ESMTP id B898140002CD for ; Fri, 2 Apr 2021 20:22:47 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id 12so8911718lfq.13 for ; Fri, 02 Apr 2021 13:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FuM4xH1nH2MjkVsKxAPd9c0o/UVsSU6PVrCfHekMLP0=; b=HGiJplNIiEH49Jc+MlHgbms83lQfmWfQQvLsBsGybACK6X10jxnc1dYwNuuV15UZCX jhZP18OliuP+gcBgdvqhkPcbd3k65haQ3WlFQMeLfOGqdptBZYGTEFZF99j0I5pv1P3j 7ClfoHpOBXfsphKUAz9CKwioYHbBzGASq5cx/VeAOVvjP35FDsbuulQHqQO0OPXsbJXz 1K9ekdx3MygGIACspecePntZyfNEF9+xXWn9ufGdk1SQvcQSwGRq0qRK0zcl+2cj19z6 c66yIaQGfx1RF0UzxmsqkgcUTe4CZeTKvthqPorMptIg+zsH3B2RWIfPfQ1ZiMTV3xtf HPkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FuM4xH1nH2MjkVsKxAPd9c0o/UVsSU6PVrCfHekMLP0=; b=A76zkmgX+voxu9v7YpV9LC4oRG9hsymdA5JB6qo6k42eQKLVOrB74LHJK6o/wq9x3f lwUgEhQyPMzUR5pZV5X202lVuo6UvOgWxwAlzJQ1q/PduKSMppZx3w6aRQn6teItre3D XmMUPGGoJo838buohC7m8ouFF/rCbXEzL/qAiXBBOQC4SJG7d0K77CEizHrgnWBjdDAn oAGpphhVOZB5749j1AlMq2H6sSzoRkVHsc8jfZOj2iynoT4q28P9IfYfjhT5cmpSwLkY sB2DueuSWhv9G78jJDQrjicGkWQ0ULOdq8Znxug8msyjcn2qBDHNHQ9dz6x+hR/mTOCp WxtQ== X-Gm-Message-State: AOAM530OW35rI7Wa5EqJhthnVJZSqti//OYT7yhri1d7s40p2bm1blL8 nhsh80UcmHABQBRzVCZz/Tk= X-Google-Smtp-Source: ABdhPJw4j+0eY/DUzPzdoOF9LRcINRLYxtb4g8ug6Fp5KR0G9M/RO9DMa5S7TgsP7x1z5tA0JXaCjA== X-Received: by 2002:ac2:57c6:: with SMTP id k6mr9832610lfo.264.1617394970033; Fri, 02 Apr 2021 13:22:50 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id f11sm952514lfr.119.2021.04.02.13.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 13:22:49 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt , linux-kselftest@vger.kernel.org, Shuah Khan Subject: [PATCH-next 3/5] vm/test_vmalloc.sh: adapt for updated driver interface Date: Fri, 2 Apr 2021 22:22:35 +0200 Message-Id: <20210402202237.20334-3-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210402202237.20334-1-urezki@gmail.com> References: <20210402202237.20334-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B898140002CD X-Stat-Signature: n17w5y19yquk1gq9ddyp64cb8xo6wf3k Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail-lf1-f49.google.com; client-ip=209.85.167.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617394967-989338 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A 'single_cpu_test' parameter is odd and it does not exist anymore. Instead there was introduced a 'nr_threads' one. If it is not set it behaves as the former parameter. That is why update a "stress mode" according to this change specifying number of workers which are equal to number of CPUs. Also update an output of help message based on a new interface. CC: linux-kselftest@vger.kernel.org CC: Shuah Khan Signed-off-by: Uladzislau Rezki (Sony) --- tools/testing/selftests/vm/test_vmalloc.sh | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/vm/test_vmalloc.sh b/tools/testing/selftests/vm/test_vmalloc.sh index 06d2bb109f06..d73b846736f1 100755 --- a/tools/testing/selftests/vm/test_vmalloc.sh +++ b/tools/testing/selftests/vm/test_vmalloc.sh @@ -11,6 +11,7 @@ TEST_NAME="vmalloc" DRIVER="test_${TEST_NAME}" +NUM_CPUS=`grep -c ^processor /proc/cpuinfo` # 1 if fails exitcode=1 @@ -22,9 +23,9 @@ ksft_skip=4 # Static templates for performance, stressing and smoke tests. # Also it is possible to pass any supported parameters manualy. # -PERF_PARAM="single_cpu_test=1 sequential_test_order=1 test_repeat_count=3" -SMOKE_PARAM="single_cpu_test=1 test_loop_count=10000 test_repeat_count=10" -STRESS_PARAM="test_repeat_count=20" +PERF_PARAM="sequential_test_order=1 test_repeat_count=3" +SMOKE_PARAM="test_loop_count=10000 test_repeat_count=10" +STRESS_PARAM="nr_threads=$NUM_CPUS test_repeat_count=20" check_test_requirements() { @@ -58,8 +59,8 @@ run_perfformance_check() run_stability_check() { - echo "Run stability tests. In order to stress vmalloc subsystem we run" - echo "all available test cases on all available CPUs simultaneously." + echo "Run stability tests. In order to stress vmalloc subsystem all" + echo "available test cases are run by NUM_CPUS workers simultaneously." echo "It will take time, so be patient." modprobe $DRIVER $STRESS_PARAM > /dev/null 2>&1 @@ -92,17 +93,17 @@ usage() echo "# Shows help message" echo "./${DRIVER}.sh" echo - echo "# Runs 1 test(id_1), repeats it 5 times on all online CPUs" - echo "./${DRIVER}.sh run_test_mask=1 test_repeat_count=5" + echo "# Runs 1 test(id_1), repeats it 5 times by NUM_CPUS workers" + echo "./${DRIVER}.sh nr_threads=$NUM_CPUS run_test_mask=1 test_repeat_count=5" echo echo -n "# Runs 4 tests(id_1|id_2|id_4|id_16) on one CPU with " echo "sequential order" - echo -n "./${DRIVER}.sh single_cpu_test=1 sequential_test_order=1 " + echo -n "./${DRIVER}.sh sequential_test_order=1 " echo "run_test_mask=23" echo - echo -n "# Runs all tests on all online CPUs, shuffled order, repeats " + echo -n "# Runs all tests by NUM_CPUS workers, shuffled order, repeats " echo "20 times" - echo "./${DRIVER}.sh test_repeat_count=20" + echo "./${DRIVER}.sh nr_threads=$NUM_CPUS test_repeat_count=20" echo echo "# Performance analysis" echo "./${DRIVER}.sh performance" From patchwork Fri Apr 2 20:22:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Uladzislau Rezki (Sony)" X-Patchwork-Id: 12181515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5374C43461 for ; Fri, 2 Apr 2021 20:22:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7212561168 for ; Fri, 2 Apr 2021 20:22:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7212561168 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76A1A6B009A; Fri, 2 Apr 2021 16:22:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719376B009C; Fri, 2 Apr 2021 16:22:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520FC6B009D; Fri, 2 Apr 2021 16:22:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 2120C6B009A for ; Fri, 2 Apr 2021 16:22:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DCB6D184B009D for ; Fri, 2 Apr 2021 20:22:52 +0000 (UTC) X-FDA: 77988550584.29.5968989 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf24.hostedemail.com (Postfix) with ESMTP id 87AC1A00038C for ; Fri, 2 Apr 2021 20:22:50 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id n138so9013190lfa.3 for ; Fri, 02 Apr 2021 13:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TPp5hmBkKmG7G/BogtZYwpF2ZqC9GPGqxLj7HZ4GHEc=; b=C5LIGAPLdvor1WU3eE6WVYmmUsYBKDJxINoQD4JGpkc5pgEUXZO8zpbfmDxXbQgrpk aRJ9N6H0/mxhg4FK+gOekMOPIsJA3a0DGVIJArzCRovJK3yEldVKMdxxCjRRCdE5TGCi 3YXGQn+SwKTpwL9I+KRk7ZaxuN606tBVFiHw5xhtS6LEL8lGMC+GyxH8zxqUaXfGuNZN 8NASV9Q36joo2U1elr4mXSH1K4OtNBn0kZ6irL3hbQswIn4F3/Z9sqUP3xInbQLBbwds BL+dyWDXH2DQrpMcLP081s2ugUadzRECjpcerWAagN/0AE6cCfBTboxRuknp91B5h512 8P0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TPp5hmBkKmG7G/BogtZYwpF2ZqC9GPGqxLj7HZ4GHEc=; b=THs4VGQ+TzLQwtgbzOi+sEv8s/NJW+UxgZQQZTynDpTuI/ADTjYuFs7Su2Wfodzwye ESgMpWKAbX6roWCRd8ADioLM5jYspC+9g1assdU6sEANxMgX0VEQd+C0OvAV1jaVWvzp QS7pr1j/XqIeiUwe3JUsg3WwvqBjcMOZIxsg7Bfz00UE2S6MtFgrdghBBbrm8uIXkdoM ULVthZC0zbCqNmRm5fDOnzX4mEksdVxzZ5naPMt/rgyOrP9qyRuT/Jv+HHCHvC20iMGP HpvzyOHqHEbA56Bx5m1OXRUOdE1/QF6sTx9hGNH1FvYRYV4zdifL+BeVJBuPCDfIb2J7 ud4A== X-Gm-Message-State: AOAM531EPVTDuIi2hbGPN0AwibTDfjaM06OQC01Mu156zkvDH5GlYJb8 wlFraMM0bpcKf9jPYS0qNig= X-Google-Smtp-Source: ABdhPJycCgbuewUDCT7jlGaEzljaZ4quXQcfLi67z6o6c8OPyv/4jUaybvTf8xE5nllI5qjrGP6i/w== X-Received: by 2002:a05:6512:314d:: with SMTP id s13mr9436973lfi.95.1617394971196; Fri, 02 Apr 2021 13:22:51 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id f11sm952514lfr.119.2021.04.02.13.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 13:22:50 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH-next 4/5] mm/vmalloc: refactor the preloading loagic Date: Fri, 2 Apr 2021 22:22:36 +0200 Message-Id: <20210402202237.20334-4-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210402202237.20334-1-urezki@gmail.com> References: <20210402202237.20334-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 87AC1A00038C X-Stat-Signature: swhiodfjo7c8hjsw8ebfcaif74xxqrd1 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-lf1-f48.google.com; client-ip=209.85.167.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617394970-588115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Instead of keeping open-coded style, move the code related to preloading into a separate function. Therefore introduce the preload_this_cpu_lock() routine that prelaods a current CPU with one extra vmap_area object. There is no functional change as a result of this patch. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 60 +++++++++++++++++++++++----------------------------- 1 file changed, 27 insertions(+), 33 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 8b564f91a610..093c7e034ca2 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1430,6 +1430,29 @@ static void free_vmap_area(struct vmap_area *va) spin_unlock(&free_vmap_area_lock); } +static inline void +preload_this_cpu_lock(spinlock_t *lock, gfp_t gfp_mask, int node) +{ + struct vmap_area *va = NULL; + + /* + * Preload this CPU with one extra vmap_area object. It is used + * when fit type of free area is NE_FIT_TYPE. It guarantees that + * a CPU that does an allocation is preloaded. + * + * We do it in non-atomic context, thus it allows us to use more + * permissive allocation masks to be more stable under low memory + * condition and high memory pressure. + */ + if (!this_cpu_read(ne_fit_preload_node)) + va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); + + spin_lock(lock); + + if (va && __this_cpu_cmpxchg(ne_fit_preload_node, NULL, va)) + kmem_cache_free(vmap_area_cachep, va); +} + /* * Allocate a region of KVA of the specified size and alignment, within the * vstart and vend. @@ -1439,7 +1462,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, unsigned long vstart, unsigned long vend, int node, gfp_t gfp_mask) { - struct vmap_area *va, *pva; + struct vmap_area *va; unsigned long addr; int purged = 0; int ret; @@ -1465,43 +1488,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask); retry: - /* - * Preload this CPU with one extra vmap_area object. It is used - * when fit type of free area is NE_FIT_TYPE. Please note, it - * does not guarantee that an allocation occurs on a CPU that - * is preloaded, instead we minimize the case when it is not. - * It can happen because of cpu migration, because there is a - * race until the below spinlock is taken. - * - * The preload is done in non-atomic context, thus it allows us - * to use more permissive allocation masks to be more stable under - * low memory condition and high memory pressure. In rare case, - * if not preloaded, GFP_NOWAIT is used. - * - * Set "pva" to NULL here, because of "retry" path. - */ - pva = NULL; - - if (!this_cpu_read(ne_fit_preload_node)) - /* - * Even if it fails we do not really care about that. - * Just proceed as it is. If needed "overflow" path - * will refill the cache we allocate from. - */ - pva = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node); - - spin_lock(&free_vmap_area_lock); - - if (pva && __this_cpu_cmpxchg(ne_fit_preload_node, NULL, pva)) - kmem_cache_free(vmap_area_cachep, pva); + preload_this_cpu_lock(&free_vmap_area_lock, gfp_mask, node); + addr = __alloc_vmap_area(size, align, vstart, vend); + spin_unlock(&free_vmap_area_lock); /* * If an allocation fails, the "vend" address is * returned. Therefore trigger the overflow path. */ - addr = __alloc_vmap_area(size, align, vstart, vend); - spin_unlock(&free_vmap_area_lock); - if (unlikely(addr == vend)) goto overflow; From patchwork Fri Apr 2 20:22:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Uladzislau Rezki (Sony)" X-Patchwork-Id: 12181517 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62EEC433B4 for ; Fri, 2 Apr 2021 20:22:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6F8646113E for ; Fri, 2 Apr 2021 20:22:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F8646113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4833A6B009C; Fri, 2 Apr 2021 16:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4380D6B009E; Fri, 2 Apr 2021 16:22:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D76C6B009F; Fri, 2 Apr 2021 16:22:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id DD35C6B009C for ; Fri, 2 Apr 2021 16:22:53 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 999E91C310 for ; Fri, 2 Apr 2021 20:22:53 +0000 (UTC) X-FDA: 77988550626.33.D0E6E28 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 20B2180192C0 for ; Fri, 2 Apr 2021 20:22:50 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id c6so5149810lji.8 for ; Fri, 02 Apr 2021 13:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QEz4oFoQYZ69/xxwT/aHjc5mSVtFDWMrpjWevrV34Wo=; b=b4Txbpwmnn7KJtqwLk6uV4b7L8nc/7b1Nv3dGDYBwzt2CnW9cg8nr13jjoAaPLiknl B+Gzwgj2s4oohWzZkH0VwNrgWDo0Q6/tN8ci6LOm34sqEllhfq5nanjy6oFIz/zOdcC7 ExpCbtPG6n6HbOdgstu9KxWO4q4vfjBfxdJrUxb91zWvyWKcS5a74TDLiLxpWv7DAonL r7B27BKEkKPvCL1mQV4uVsS9zynKNwF1gvra8i3sm9iiMRturcvs+eA08FzabztlZsoB 0RjF6vyA778g5+ar/q+eQSBStOnGfGqiODkz9NRs3ly+FpuUGgNv48W9rHIDKyu1WCpn qW0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QEz4oFoQYZ69/xxwT/aHjc5mSVtFDWMrpjWevrV34Wo=; b=V9c4AnJBbvIWmRoU07+uHlkiIIoFxtVdLCuFYWY18foRAmYKEq2txfPjbLK3J6DuzT HywQsCLfi/PUXW4gZtuElsHBOtS3rMeaEZ6UwwwewU0IezuRhRcIe8qpxWhRrO/4nDBR m0jLfRi0i4RQ426e9UppiqYPFQJC3Oolr7ZtpoLYISBh1ONWRcBXTqoCaMDDcUM9q1pR 2ofsi7pYPoPeLCTrec8hn9APDF/Ub9vzVcZcZtOCezZOi4K7BVfA91FgNahWUWqLCUIn GoFZq2eES0AcUfX0SY13LUYxKvxNkKlGwvZI0fiuxpWjEjT6lkRfENUILbmSH34Z2cTF XoUQ== X-Gm-Message-State: AOAM533pJ4bgsMiBV/vfY0rHBgQh89YBAsP3k3+AE3mO/fPnj7Rqh1xO N/y4cYtPbWDtd8/zkETnCpM= X-Google-Smtp-Source: ABdhPJyNsBsDI+cKgn5n6SDR0U/DIbyOU+44ERqHPUKLVgIKciOkzzeFPIKpVByGE7Vbt8lTrGNFNg== X-Received: by 2002:a2e:5c03:: with SMTP id q3mr9511957ljb.68.1617394972062; Fri, 02 Apr 2021 13:22:52 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id f11sm952514lfr.119.2021.04.02.13.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 13:22:51 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH-next 5/5] mm/vmalloc: remove an empty line Date: Fri, 2 Apr 2021 22:22:37 +0200 Message-Id: <20210402202237.20334-5-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210402202237.20334-1-urezki@gmail.com> References: <20210402202237.20334-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 20B2180192C0 X-Stat-Signature: eqh1huuegnir1m1isayw6janz7b7o3by Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-lj1-f180.google.com; client-ip=209.85.208.180 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617394970-546979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 093c7e034ca2..1e643280cbcf 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1503,7 +1503,6 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, va->va_end = addr + size; va->vm = NULL; - spin_lock(&vmap_area_lock); insert_vmap_area(va, &vmap_area_root, &vmap_area_list); spin_unlock(&vmap_area_lock);