From patchwork Wed Apr 7 06:35:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4DF6C433ED for ; Wed, 7 Apr 2021 06:36:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B21E36052B for ; Wed, 7 Apr 2021 06:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345800AbhDGGgL (ORCPT ); Wed, 7 Apr 2021 02:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345797AbhDGGgJ (ORCPT ); Wed, 7 Apr 2021 02:36:09 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D547C061756; Tue, 6 Apr 2021 23:35:59 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id y2so8830346plg.5; Tue, 06 Apr 2021 23:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6C1VG94DXJmRElgd9BUdwwz/TIojJvKsjgpldW3yH08=; b=dbybRTa/Ml6XWFTXvUPiV1wTcKtPk0A6X8l9l8EA8SrHjiWYSqY7BU8G2N0D3CbRg+ gg0ugqFFeUUYnbI+dXUjQn4fEEwcsb5wRU57EMVUazh+ROIbxcNOcnMnRHbm3mWD2KSs mnPScFC/fFdc7duNYLFrV1nVjeFVFTzX7HSaigdLC4O5Gg8ARKxlXF8cVtjaARDI8wWB g3jgLq9f87yEGaicajMjSJuFgmJH9aFyDBvVyzYPdxuVPMjzWHOhZTCXuPT0gVTll1QR Gk7ngBjKKPAJ7zoehiy4tUg2TLVj0o0r++E3nvLEUfTG+/X9yuKweoRtUrh1A2Xyz4LC eOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6C1VG94DXJmRElgd9BUdwwz/TIojJvKsjgpldW3yH08=; b=Ed625wllxVdXqIf9tDdP150ip6fcmE5EAM+q+j750qlwJCKgwDAPNLTYY0rQwsjKpm PccUX/AMZ+xyIqBGQDdifHuylAHPRimZPh1FjLbHqe/RZ6t800vJOeUwxV9V96qCykzx PCPkIQCIsgHHwcOOFzvDpQNVC3HuE7tAAqxnnP+ZoCZC/6VZdhspIjEHAlhyI1EgLmc2 vwWrdUnM2dVYrn0MRICTXI98rf7s5JuTgYzVPDb3hBxyR4rS3kGPyRRAHk8yCkISikNN YcNXF8JAodhb9Gdahe40ff0RsnRS8KDuFFrXfEU79O5AsCg1jZc3aJCq53lb0msut2Y2 b1tQ== X-Gm-Message-State: AOAM533fXqrfrnMH0nG7ND8IWw8hqOPSUJoc5Esvwd9PbRlu+mPlYAeM Phem9hAMb3M/G1ovUTClZFI= X-Google-Smtp-Source: ABdhPJwm6c7FEAbAd5EvvprcxCDFCYTJLgDE0AVQ43UGbHpu8AaOLI/APORmFUkmZhJEEhV/eg1i1g== X-Received: by 2002:a17:902:6ac3:b029:e6:c6a3:a697 with SMTP id i3-20020a1709026ac3b02900e6c6a3a697mr1846232plt.2.1617777358776; Tue, 06 Apr 2021 23:35:58 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id p5sm4232548pfg.85.2021.04.06.23.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:35:58 -0700 (PDT) Date: Tue, 6 Apr 2021 23:35:56 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/49] staging: sm750fb: Update dvi_ctrl_device to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for dvi_ctrl_device structure and its usages. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 30 ++++++++-------- drivers/staging/sm750fb/ddk750_dvi.h | 20 +++++------ drivers/staging/sm750fb/ddk750_sii164.c | 48 ++++++++++++------------- drivers/staging/sm750fb/ddk750_sii164.h | 20 +++++------ 4 files changed, 59 insertions(+), 59 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index cd564ea40779..db19bf732482 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -11,20 +11,20 @@ * function API. Please set the function pointer to NULL whenever the function * is not supported. */ -static struct dvi_ctrl_device g_dcftSupportedDviController[] = { +static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #ifdef DVI_CTRL_SII164 { - .pfnInit = sii164InitChip, - .pfnGetVendorId = sii164GetVendorID, - .pfnGetDeviceId = sii164GetDeviceID, + .pfn_init = sii164_init_chip, + .pfn_get_vendor_id = sii164_get_vendor_id, + .pfn_get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .pfnResetChip = sii164ResetChip, - .pfnGetChipString = sii164GetChipString, - .pfnSetPower = sii164SetPower, - .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, - .pfnIsConnected = sii164IsConnected, - .pfnCheckInterrupt = sii164CheckInterrupt, - .pfnClearInterrupt = sii164ClearInterrupt, + .pfn_reset_chip = sii164_reset_chip, + .pfn_get_chip_string = sii164_get_chip_string, + .pfn_set_power = sii164_set_power, + .pfn_enable_hot_plug_detection = sii164_enable_hot_plug_detection, + .pfn_is_connected = sii164_is_connected, + .pfn_check_interrupt = sii164_check_interrupt, + .pfn_clear_interrupt = sii164_clear_interrupt, #endif }, #endif @@ -41,11 +41,11 @@ int dviInit(unsigned char edge_select, unsigned char pll_filter_enable, unsigned char pll_filter_value) { - struct dvi_ctrl_device *pCurrentDviCtrl; + struct dvi_ctrl_device *current_dvi_ctrl; - pCurrentDviCtrl = g_dcftSupportedDviController; - if (pCurrentDviCtrl->pfnInit) { - return pCurrentDviCtrl->pfnInit(edge_select, + current_dvi_ctrl = dcft_supported_dvi_controller; + if (current_dvi_ctrl->pfn_init) { + return current_dvi_ctrl->pfn_init(edge_select, bus_select, dual_edge_clk_select, hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 1c7a565b617a..4ca2591ea94b 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -27,16 +27,16 @@ typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void); /* Structure to hold all the function pointer to the DVI Controller. */ struct dvi_ctrl_device { - PFN_DVICTRL_INIT pfnInit; - PFN_DVICTRL_RESETCHIP pfnResetChip; - PFN_DVICTRL_GETCHIPSTRING pfnGetChipString; - PFN_DVICTRL_GETVENDORID pfnGetVendorId; - PFN_DVICTRL_GETDEVICEID pfnGetDeviceId; - PFN_DVICTRL_SETPOWER pfnSetPower; - PFN_DVICTRL_HOTPLUGDETECTION pfnEnableHotPlugDetection; - PFN_DVICTRL_ISCONNECTED pfnIsConnected; - PFN_DVICTRL_CHECKINTERRUPT pfnCheckInterrupt; - PFN_DVICTRL_CLEARINTERRUPT pfnClearInterrupt; + PFN_DVICTRL_INIT pfn_init; + PFN_DVICTRL_RESETCHIP pfn_reset_chip; + PFN_DVICTRL_GETCHIPSTRING pfn_get_chip_string; + PFN_DVICTRL_GETVENDORID pfn_get_vendor_id; + PFN_DVICTRL_GETDEVICEID pfn_get_device_id; + PFN_DVICTRL_SETPOWER pfn_set_power; + PFN_DVICTRL_HOTPLUGDETECTION pfn_enable_hot_plug_detection; + PFN_DVICTRL_ISCONNECTED pfn_is_connected; + PFN_DVICTRL_CHECKINTERRUPT pfn_check_interrupt; + PFN_DVICTRL_CLEARINTERRUPT pfn_clear_interrupt; }; #define DVI_CTRL_SII164 diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 73e0e9f41ec5..6c343e2e0433 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -29,13 +29,13 @@ static char *gDviCtrlChipName = "Silicon Image SiI 164"; #endif /* - * sii164GetVendorID + * sii164_get_vendor_id * This function gets the vendor ID of the DVI controller chip. * * Output: * Vendor ID */ -unsigned short sii164GetVendorID(void) +unsigned short sii164_get_vendor_id(void) { unsigned short vendorID; @@ -48,13 +48,13 @@ unsigned short sii164GetVendorID(void) } /* - * sii164GetDeviceID + * sii164_get_device_id * This function gets the device ID of the DVI controller chip. * * Output: * Device ID */ -unsigned short sii164GetDeviceID(void) +unsigned short sii164_get_device_id(void) { unsigned short deviceID; @@ -72,7 +72,7 @@ unsigned short sii164GetDeviceID(void) */ /* - * sii164InitChip + * sii164_init_chip * This function initialize and detect the DVI controller chip. * * Input: @@ -118,7 +118,7 @@ unsigned short sii164GetDeviceID(void) * 0 - Success * -1 - Fail. */ -long sii164InitChip(unsigned char edge_select, +long sii164_init_chip(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, @@ -140,8 +140,8 @@ long sii164InitChip(unsigned char edge_select, #endif /* Check if SII164 Chip exists */ - if ((sii164GetVendorID() == SII164_VENDOR_ID) && - (sii164GetDeviceID() == SII164_DEVICE_ID)) { + if ((sii164_get_vendor_id() == SII164_VENDOR_ID) && + (sii164_get_device_id() == SII164_DEVICE_ID)) { /* * Initialize SII164 controller chip. */ @@ -250,36 +250,36 @@ long sii164InitChip(unsigned char edge_select, #ifdef SII164_FULL_FUNCTIONS /* - * sii164ResetChip + * sii164_reset_chip * This function resets the DVI Controller Chip. */ -void sii164ResetChip(void) +void sii164_reset_chip(void) { /* Power down */ - sii164SetPower(0); - sii164SetPower(1); + sii164_set_power(0); + sii164_set_power(1); } /* - * sii164GetChipString + * sii164_get_chip_string * This function returns a char string name of the current DVI Controller * chip. * * It's convenient for application need to display the chip name. */ -char *sii164GetChipString(void) +char *sii164_get_chip_string(void) { return gDviCtrlChipName; } /* - * sii164SetPower + * sii164_set_power * This function sets the power configuration of the DVI Controller Chip. * * Input: * powerUp - Flag to set the power down or up */ -void sii164SetPower(unsigned char powerUp) +void sii164_set_power(unsigned char powerUp) { unsigned char config; @@ -329,12 +329,12 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) } /* - * sii164EnableHotPlugDetection + * sii164_enable_hot_plug_detection * This function enables the Hot Plug detection. * * enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection */ -void sii164EnableHotPlugDetection(unsigned char enableHotPlug) +void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) { unsigned char detectReg; @@ -350,14 +350,14 @@ void sii164EnableHotPlugDetection(unsigned char enableHotPlug) } /* - * sii164IsConnected + * sii164_is_connected * Check if the DVI Monitor is connected. * * Output: * 0 - Not Connected * 1 - Connected */ -unsigned char sii164IsConnected(void) +unsigned char sii164_is_connected(void) { unsigned char hotPlugValue; @@ -370,14 +370,14 @@ unsigned char sii164IsConnected(void) } /* - * sii164CheckInterrupt + * sii164_check_interrupt * Checks if interrupt has occurred. * * Output: * 0 - No interrupt * 1 - Interrupt occurs */ -unsigned char sii164CheckInterrupt(void) +unsigned char sii164_check_interrupt(void) { unsigned char detectReg; @@ -390,10 +390,10 @@ unsigned char sii164CheckInterrupt(void) } /* - * sii164ClearInterrupt + * sii164_clear_interrupt * Clear the hot plug interrupt. */ -void sii164ClearInterrupt(void) +void sii164_clear_interrupt(void) { unsigned char detectReg; diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h index d940cb729066..cf17b9029496 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.h +++ b/drivers/staging/sm750fb/ddk750_sii164.h @@ -16,7 +16,7 @@ enum sii164_hot_plug_mode { }; /* Silicon Image SiI164 chip prototype */ -long sii164InitChip(unsigned char edgeSelect, +long sii164_init_chip(unsigned char edgeSelect, unsigned char busSelect, unsigned char dualEdgeClkSelect, unsigned char hsyncEnable, @@ -27,17 +27,17 @@ long sii164InitChip(unsigned char edgeSelect, unsigned char pllFilterEnable, unsigned char pllFilterValue); -unsigned short sii164GetVendorID(void); -unsigned short sii164GetDeviceID(void); +unsigned short sii164_get_vendor_id(void); +unsigned short sii164_get_device_id(void); #ifdef SII164_FULL_FUNCTIONS -void sii164ResetChip(void); -char *sii164GetChipString(void); -void sii164SetPower(unsigned char powerUp); -void sii164EnableHotPlugDetection(unsigned char enableHotPlug); -unsigned char sii164IsConnected(void); -unsigned char sii164CheckInterrupt(void); -void sii164ClearInterrupt(void); +void sii164_reset_chip(void); +char *sii164_get_chip_string(void); +void sii164_set_power(unsigned char powerUp); +void sii164_enable_hot_plug_detection(unsigned char enableHotPlug); +unsigned char sii164_is_connected(void); +unsigned char sii164_check_interrupt(void); +void sii164_clear_interrupt(void); #endif /* * below register definition is used for From patchwork Wed Apr 7 06:36:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED477C433ED for ; Wed, 7 Apr 2021 06:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA353613C0 for ; Wed, 7 Apr 2021 06:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345797AbhDGGgO (ORCPT ); Wed, 7 Apr 2021 02:36:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345860AbhDGGgN (ORCPT ); Wed, 7 Apr 2021 02:36:13 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199CAC061756; Tue, 6 Apr 2021 23:36:04 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id a6so5495143pls.1; Tue, 06 Apr 2021 23:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PxKQLgSh2nb/XH5YpVxCcvU5M202Y3gpnJJ5xTXypQU=; b=Pk9+F3zXJx2odkFEnk3qTPJQJawwOiW7zo1VDocATkl0Xo1xLZK1O9MDIwZOax71Sp Eo4zma5NCIzHy/LFdHZnkAA/FvAUNUCymAD1GaeIGvrfFHtn9CXxklMr/0i5BU96QDR1 DzxeUsW3eJIG8OVIocHhKN550jENBzZ9F+ad5bAvKGzcx/SvSVQO7vY/Onr74Nwdz5BK H7jiHTq6xkr6a0st1fZE17sGNH8UF0X4nepevpeXwZxts+h7fiLD5ubymz3L5+MvM+hp vDGPGHaNDm11XCGe5Gin1/aRGoCPt+9PnDSZ+4IE8FJrA+JhIB8h1rO0hCyr6eWiAZeW H9Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PxKQLgSh2nb/XH5YpVxCcvU5M202Y3gpnJJ5xTXypQU=; b=UEg7QVXI6TgYMIhnlHqMjL9fjBNwE9Syv2yV3NVrfguAHs7fLPVIGLFM/PiAjsonDU b8ZiYg8PAP61sopn8wPgvaSc75N3Wh80E11/mjIAPOFtdaI/0e32hKCG4vnHXtkJ3fkM skFFUGYPEtWhn/PzNqCE5B73ZdvxNo3v+fuKUJcq7DJwTM4XEEo0Hq4fFwjnoJasLJOS SgkvTUo35gJyN5Wz9hleLZrf64r/+wLSG1pae0Qwl+uOR4lHVOwxw3hFWKsAPmAAbhZI wala3im+5aSZBrnxo3zRute4fEZ7uzeMTLPzIJUTmTlv5aJ1fGMKLvpF3rYclH4hYCO1 ZmkA== X-Gm-Message-State: AOAM532iQuK7Vg+GxivdkVYT5n1ap+BjLKpaDlQ1JuvYDDkQH4WXTexi fs7BsGju3GdQxmbVQl9ZT3s= X-Google-Smtp-Source: ABdhPJz5BHdME/ZkEDDAA94wWwwQO3IeFNw2DCQZ0XToLxKfItLff/Yx2kMf8yf03KEQnHPpjLtUBw== X-Received: by 2002:a17:902:a513:b029:e5:d91c:2ede with SMTP id s19-20020a170902a513b02900e5d91c2edemr1773981plq.65.1617777363671; Tue, 06 Apr 2021 23:36:03 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id z23sm20476921pgn.88.2021.04.06.23.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:03 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:01 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/49] staging: sm750fb: Rename dviInit to dvi_init and update param names Message-ID: <6c6ecf7eee7d41492dbbcc4410db7eefd1fbb13d.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function dviInit and its parameter names in ddk750_dvi.h. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 2 +- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index db19bf732482..943cbcafcffa 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -30,7 +30,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #endif }; -int dviInit(unsigned char edge_select, +int dvi_init(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 4ca2591ea94b..fbc897c7efb8 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -42,16 +42,16 @@ struct dvi_ctrl_device { #define DVI_CTRL_SII164 /* dvi functions prototype */ -int dviInit(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +int dvi_init(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); #endif From patchwork Wed Apr 7 06:36:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F00C433ED for ; Wed, 7 Apr 2021 06:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FE5A6052B for ; Wed, 7 Apr 2021 06:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345860AbhDGGgR (ORCPT ); Wed, 7 Apr 2021 02:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348815AbhDGGgP (ORCPT ); Wed, 7 Apr 2021 02:36:15 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 886EEC06174A; Tue, 6 Apr 2021 23:36:06 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id k23-20020a17090a5917b02901043e35ad4aso719570pji.3; Tue, 06 Apr 2021 23:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OH0zYh2ZFmb689ReWGztZUI2CNWri3Mtoqhtg+OoAIA=; b=q/PqrlHVdCpvFjAw95bHjGsgaRHjqqCSP3+wsmNOWSPAFCBky2VtW8Y+LC+NdU2gNq LfyL/RLPB5ly2rl9c4PBIWGvdC44KvWWsWf+3GDVSGzNY7Fun3Awd/99A68XSxrSZs3n 3cBfuVymGxQ6WMfH8+TuZSohcFrZbBB2jvj1c8vLihkHL4chhss0Ovrspycv0XVP2BI3 yYMiV6Awwaz1F2qxvHajDd2B5V8g9xvwZXWpvff9/wZhhDDRONIc7A1+YNTwTDCK67jb sIHCzb4sILGrx8JxZE/tKGFtcwfBdyInUvEI4JzBQinOxPfL8oeXAM9Ze/Y0OacqtmCK Dmeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OH0zYh2ZFmb689ReWGztZUI2CNWri3Mtoqhtg+OoAIA=; b=AQDjRU8Z+NL0YsCpTDjExhFOxnIFNXqjjUY9LYlZnYVWMPKwhQrkAz0A8ijGLYlfoM n6o+lobSI9HpBhryivamA/58nUA9O5H8jy22u4EHS5jvwfIKs5tNi5amcdPG10zqExNo +XRoj6+csFhSJv/8Cnxes3u+XDNS/5TXqQ333sichLrFOG3WLggVssF0gvCG5okZU/qM GL7psaIJeGk0xAIpKnL9h6DjF891fAxA1+UzJpLdMqiO2JOACwFc2N50bVrFrq14r140 Mzt98Zid8fXF7MZDtfVm9qQE+VZpZoCrEAFNUGzmIxsyMja6PDNMP6hv1gaJCi6UlgiS c3GQ== X-Gm-Message-State: AOAM533vkNxhYLwjmpbRQok5xXWKdH68WMUoJp3QWTC17Hzzid7koc3K D7YA4oDdAe+d0l0MQVKew3MhFxI98aj4vQ== X-Google-Smtp-Source: ABdhPJyQUOXMZVoOmoZsPyEGgo8FcUEFzPIawSF1BczppHICzW6bmSbZIAGb4ojPKN2ea+3zkDEi3A== X-Received: by 2002:a17:90a:c004:: with SMTP id p4mr1824906pjt.202.1617777366153; Tue, 06 Apr 2021 23:36:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id j20sm4187921pjn.27.2021.04.06.23.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:05 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:03 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/49] staging: sm750fb: Update param names of PFN_DVICTRL_INIT function pointer Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for parameter names in the type definition of PFN_DVICTRL_INIT function pointer. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index fbc897c7efb8..b2fd56ef51fc 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -4,16 +4,16 @@ /* dvi chip stuffs structros */ -typedef long (*PFN_DVICTRL_INIT)(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); typedef void (*PFN_DVICTRL_RESETCHIP)(void); typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void); From patchwork Wed Apr 7 06:36:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6C2C43461 for ; Wed, 7 Apr 2021 06:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 692176052B for ; Wed, 7 Apr 2021 06:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348857AbhDGGgS (ORCPT ); Wed, 7 Apr 2021 02:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348819AbhDGGgR (ORCPT ); Wed, 7 Apr 2021 02:36:17 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE56EC06174A; Tue, 6 Apr 2021 23:36:08 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id f29so9802956pgm.8; Tue, 06 Apr 2021 23:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d8ovuxYfB9+zqQGeJgdR8CqV8t9xX0UspHjHO2iP+oI=; b=PxdfwCQBWektpoQgkVweDVbU9rIFcwh7WpqLH1rEqatdwu50J2VaJ2jlMu/EpOUpXu BeHfMx7icVFrUAhKQnV2ST7plccdNO8o7ZRYhXXI2S6n/APsm9aTlAbhSIlX/MZa9608 FKr0zp3zuORjznT3hKNJyA9UaA2GgO3Z1jIzeSp/REnr1VzVPCnsX6Wb9GVJURisgTd5 ULgg01iDi7NDUybUWI6/2gWrmaQJKCKIOdSOAyzybF4on1cAMP2CQ+c8UFs9TIoAjfR4 f7KouwPWP9UMIMPbsO+yvM5iFXPy1dP3iM0qqU7Yxv7ASJ/g1YFzmUXHGf3g2Aq8V28a uL8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d8ovuxYfB9+zqQGeJgdR8CqV8t9xX0UspHjHO2iP+oI=; b=fNTxx5Xo7n7LsfcOHLz3Ln1kHqMkg8ibHMJhJ771ujklLKrVDZ1qfi4L6ZjRzUu0VH LgmjKXyUlB20DN3FcyxRpwWnbRbO5h9BBA2cVfu03Kni7UnvMPnMyaTDobiM0FThubSg /Dpf67v4Y4uIERUhG/aZ2SvuNlXn5sdLP7dNO9KyK+JwJ982U1j4EdyuTRydx9hB52u7 bQxeIPw7yvOXtC23nZJwtWVTjVaQjbbyurn5GkmSfYWsavkHqiqtDjANv+eGn1WaNvs0 FYeLWisg0NNTLpStHN1OSdB55xERojcWRAiBOZ8bldcd+Yooo562FmR+l6eqzvJxz9hb YkrQ== X-Gm-Message-State: AOAM532BNAxynymtv9nMMQpvXoLGEx4fKMgI9i+MLVGNpnvf72hlebny OM6DSS9N2ICF8ZtkrAf+3U4= X-Google-Smtp-Source: ABdhPJzYdiOWR58SziSMST5L8m60UsYF/HgfFlh9MmXvieSHl52C4trBgIXQBhIa6Z5s8REh2AlfEg== X-Received: by 2002:a63:5c48:: with SMTP id n8mr1836343pgm.411.1617777368335; Tue, 06 Apr 2021 23:36:08 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id h1sm20780672pfq.137.2021.04.06.23.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:07 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:06 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/49] staging: sm750fb: Remove type names in variables and type definitions Message-ID: <9c9f21eab07b55b365cf0265ec81aaf4a8fc0c2f.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Remove type names used in variables and type definitions for dvi_ctrl_device structure. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.c | 24 ++++++++--------- drivers/staging/sm750fb/ddk750_dvi.h | 40 ++++++++++++++-------------- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c index 943cbcafcffa..2743778abaab 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.c +++ b/drivers/staging/sm750fb/ddk750_dvi.c @@ -14,17 +14,17 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #ifdef DVI_CTRL_SII164 { - .pfn_init = sii164_init_chip, - .pfn_get_vendor_id = sii164_get_vendor_id, - .pfn_get_device_id = sii164_get_device_id, + .init = sii164_init_chip, + .get_vendor_id = sii164_get_vendor_id, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .pfn_reset_chip = sii164_reset_chip, - .pfn_get_chip_string = sii164_get_chip_string, - .pfn_set_power = sii164_set_power, - .pfn_enable_hot_plug_detection = sii164_enable_hot_plug_detection, - .pfn_is_connected = sii164_is_connected, - .pfn_check_interrupt = sii164_check_interrupt, - .pfn_clear_interrupt = sii164_clear_interrupt, + .reset_chip = sii164_reset_chip, + .get_chip_string = sii164_get_chip_string, + .set_power = sii164_set_power, + .enable_hot_plug_detection = sii164_enable_hot_plug_detection, + .is_connected = sii164_is_connected, + .check_interrupt = sii164_check_interrupt, + .clear_interrupt = sii164_clear_interrupt, #endif }, #endif @@ -44,8 +44,8 @@ int dvi_init(unsigned char edge_select, struct dvi_ctrl_device *current_dvi_ctrl; current_dvi_ctrl = dcft_supported_dvi_controller; - if (current_dvi_ctrl->pfn_init) { - return current_dvi_ctrl->pfn_init(edge_select, + if (current_dvi_ctrl->init) { + return current_dvi_ctrl->init(edge_select, bus_select, dual_edge_clk_select, hsync_enable, diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index b2fd56ef51fc..8aee0cdf63a4 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -4,7 +4,7 @@ /* dvi chip stuffs structros */ -typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select, +typedef long (*DVICTRL_INIT)(unsigned char edge_select, unsigned char bus_select, unsigned char dual_edge_clk_select, unsigned char hsync_enable, @@ -15,28 +15,28 @@ typedef long (*PFN_DVICTRL_INIT)(unsigned char edge_select, unsigned char pll_filter_enable, unsigned char pll_filter_value); -typedef void (*PFN_DVICTRL_RESETCHIP)(void); -typedef char* (*PFN_DVICTRL_GETCHIPSTRING)(void); -typedef unsigned short (*PFN_DVICTRL_GETVENDORID)(void); -typedef unsigned short (*PFN_DVICTRL_GETDEVICEID)(void); -typedef void (*PFN_DVICTRL_SETPOWER)(unsigned char powerUp); -typedef void (*PFN_DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug); -typedef unsigned char (*PFN_DVICTRL_ISCONNECTED)(void); -typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void); -typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void); +typedef void (*DVICTRL_RESETCHIP)(void); +typedef char* (*DVICTRL_GETCHIPSTRING)(void); +typedef unsigned short (*DVICTRL_GETVENDORID)(void); +typedef unsigned short (*DVICTRL_GETDEVICEID)(void); +typedef void (*DVICTRL_SETPOWER)(unsigned char powerUp); +typedef void (*DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug); +typedef unsigned char (*DVICTRL_ISCONNECTED)(void); +typedef unsigned char (*DVICTRL_CHECKINTERRUPT)(void); +typedef void (*DVICTRL_CLEARINTERRUPT)(void); /* Structure to hold all the function pointer to the DVI Controller. */ struct dvi_ctrl_device { - PFN_DVICTRL_INIT pfn_init; - PFN_DVICTRL_RESETCHIP pfn_reset_chip; - PFN_DVICTRL_GETCHIPSTRING pfn_get_chip_string; - PFN_DVICTRL_GETVENDORID pfn_get_vendor_id; - PFN_DVICTRL_GETDEVICEID pfn_get_device_id; - PFN_DVICTRL_SETPOWER pfn_set_power; - PFN_DVICTRL_HOTPLUGDETECTION pfn_enable_hot_plug_detection; - PFN_DVICTRL_ISCONNECTED pfn_is_connected; - PFN_DVICTRL_CHECKINTERRUPT pfn_check_interrupt; - PFN_DVICTRL_CLEARINTERRUPT pfn_clear_interrupt; + DVICTRL_INIT init; + DVICTRL_RESETCHIP reset_chip; + DVICTRL_GETCHIPSTRING get_chip_string; + DVICTRL_GETVENDORID get_vendor_id; + DVICTRL_GETDEVICEID get_device_id; + DVICTRL_SETPOWER set_power; + DVICTRL_HOTPLUGDETECTION enable_hot_plug_detection; + DVICTRL_ISCONNECTED is_connected; + DVICTRL_CHECKINTERRUPT check_interrupt; + DVICTRL_CLEARINTERRUPT clear_interrupt; }; #define DVI_CTRL_SII164 From patchwork Wed Apr 7 06:36:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 506C0C433B4 for ; Wed, 7 Apr 2021 06:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 214346052B for ; Wed, 7 Apr 2021 06:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348854AbhDGGgY (ORCPT ); Wed, 7 Apr 2021 02:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348883AbhDGGgX (ORCPT ); Wed, 7 Apr 2021 02:36:23 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B88F7C06174A; Tue, 6 Apr 2021 23:36:13 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id f29so9803075pgm.8; Tue, 06 Apr 2021 23:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DybsWO6cYupTAYK5TY3h7KJtjw7Gu9U9lSriFDUMaw8=; b=FdKvOV3IL4dnT5Qd/skievzAJiYmP8mOYgeLLnlq8L9EL4D4WJkv9ydKhfJHdfDcpD 3mmH7Ir/l5o9MTRgL7OacSM9crrSypLeLHN1TyKvyqucvvP9juoFuXW9fep1pOgnBlj8 6HM+IH4/WtAUjyAhoJWv1TpXk3OTWDuvCWnBQ77qnw/IIoOOLMx/RoR5k3cOtQVAzs0N hgOecVo+7k1TP9tlKQ5sQDHt4BhkQG6cGZIYyB11VhyqLiaQEc9QEXWuocbp2k2gHkkJ NUW1A0bUUkKs/ivXH8cT1c13KiHIQZRHTPjvV1wcJ1cYnPNyfF3AT+R4XUZCLsy7lwVY jLdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DybsWO6cYupTAYK5TY3h7KJtjw7Gu9U9lSriFDUMaw8=; b=C8eVMB8bZv+0Kir2bwEscE2oPROmiu3dTFO0Sx/hA3GlXKwpEfacsXaPTn/af+Lcvg VkQ93uxNlYGNeRZDP2ceu8E+P3SdNmwF1kSLtyY6vIpEVT0fgxNGxSWg/4p2w2qbzBni Udqmd0/kMSa2aGEHuRW7x3Ir/jmljJx+08uQYhqNtKxEpOIPuaYBpkTzJM81J9Am/J8S y2vFh1WWlhbOxfH5erpQiE/xOWLTZLnhs/Wrg8TWLWw3XgIbkzZiy+MpMgmUmrSOkrM/ CTy6bvAvrozLq1+WnZkYry1ISNpyBZ/nkMzla2rok/46QdQ00ENZLre1gUllM+SSqyUz YYBg== X-Gm-Message-State: AOAM533907fSYjVzwftroxJSZJVDbzGLuIhZsKFb3UQm6BDxt0tSP0HC V0LcZ3WRwT9L1W/Be0MKMWM= X-Google-Smtp-Source: ABdhPJwuyTAC8jxTxOk3Mmj1dDuxKrU16iQQtdWCrgRfJU7JlDZ3fSgVkVL7AJIYC/S1Qw5EZuHKEQ== X-Received: by 2002:a05:6a00:158b:b029:241:a969:4da6 with SMTP id u11-20020a056a00158bb0290241a9694da6mr1584990pfk.27.1617777373300; Tue, 06 Apr 2021 23:36:13 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id mu6sm4115326pjb.35.2021.04.06.23.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:12 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:10 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/49] staging: sm750fb: Remove remaining camel case names in ddk750_dvi.h Message-ID: <2ee5dbf98547860d93d5c72b73ea61991dac0b1c.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for type definitions DVICTRL_SETPOWER and DVICTRL_HOTPLUGDETECTION in ddk750_dvi.h. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_dvi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.h b/drivers/staging/sm750fb/ddk750_dvi.h index 8aee0cdf63a4..d953fb5ab9f2 100644 --- a/drivers/staging/sm750fb/ddk750_dvi.h +++ b/drivers/staging/sm750fb/ddk750_dvi.h @@ -19,8 +19,8 @@ typedef void (*DVICTRL_RESETCHIP)(void); typedef char* (*DVICTRL_GETCHIPSTRING)(void); typedef unsigned short (*DVICTRL_GETVENDORID)(void); typedef unsigned short (*DVICTRL_GETDEVICEID)(void); -typedef void (*DVICTRL_SETPOWER)(unsigned char powerUp); -typedef void (*DVICTRL_HOTPLUGDETECTION)(unsigned char enableHotPlug); +typedef void (*DVICTRL_SETPOWER)(unsigned char power_up); +typedef void (*DVICTRL_HOTPLUGDETECTION)(unsigned char enable_hot_plug); typedef unsigned char (*DVICTRL_ISCONNECTED)(void); typedef unsigned char (*DVICTRL_CHECKINTERRUPT)(void); typedef void (*DVICTRL_CLEARINTERRUPT)(void); From patchwork Wed Apr 7 06:36:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60077C43460 for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 377586124C for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348895AbhDGGge (ORCPT ); Wed, 7 Apr 2021 02:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348878AbhDGGg1 (ORCPT ); Wed, 7 Apr 2021 02:36:27 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84B78C061756; Tue, 6 Apr 2021 23:36:15 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id y2so8830659plg.5; Tue, 06 Apr 2021 23:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nbXo1IxGweA//u4mbIa93kKWNX3fgy1vKyjQx5w3BBQ=; b=ZqoVq74+Pip01x1DlbjW34pRjJf5G0G3dBYHsQYrLNNSnfKiaKZFYf2fW2WICQQGhZ hjVQPHrOh0R1P9UGm7qzvfc9etyl2d0JnIrVAZyC+XNqDxXB9QbV2S/ZIlhnkPgnZRFh CcIQvyxwZP+mjT0SII7AcWRdhBACReIK03ZXkDidXuJpd6IXnuWkCaOR+uFQfPPvd6bm 9OhNHhhZPzdliWu+8A80Z6wQtg0MbKtgLx4UBL8nbH/rkH95AQYpR2mDRCQkBMtA3/IJ TFSyHASWkcNPlEgEWA/c24GXMn/y0mnyyLbzi+9TCXBlP+5F1HRSpubbq7+17VECgPlP 6Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nbXo1IxGweA//u4mbIa93kKWNX3fgy1vKyjQx5w3BBQ=; b=NMXBNZVolUk5KQgLmk+/j1hr4rLOQOfisZKx1LfltVOm4CHKIVXU2+zim5r1yYgwl0 ciOEvDi+qZkR740O48CG+xKU30aYqJtTrSWmkl+phs240+3WOG/Z1Fnb/Q2SdVQvncSY xhOtXASbac5KR18oJgbU8noYOYtc+BowF+x4GFueAi3S+QG8QuZrk4uWodKBanYc+lr4 WcGZNQ/phf40mymbshs67B6HlyaYk5GRFXuAvAJ35neDuISy3wsZzCP2vXwjSHaziQFw ugp+9NwchgHNioKR8LmYuCx0ZbpQhLo7De3KcBylyQvwsxYHL9PyCy0/2yAV5x4rRiBe 5/ww== X-Gm-Message-State: AOAM530+snXExsDbajXk+S3vxN8PZabKtMG+080RwAEMNtmJR3S0aDwy vGHl7dSxTUxMahk45wmZE2c= X-Google-Smtp-Source: ABdhPJwfW5mvaupNug1y63+8B7XCnyNIMU83jfAc56VjkaKr9Vl8Pxzv5szf1jX/yYIXeWNtnlNnpg== X-Received: by 2002:a17:90a:c211:: with SMTP id e17mr1894147pjt.52.1617777375051; Tue, 06 Apr 2021 23:36:15 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id k15sm21048620pfi.0.2021.04.06.23.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:14 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:12 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/49] staging: sm750fb: Update displayControlAdjust_SM750LE to snake case Message-ID: <36f24931c96cb315c32a06f5ae374f652dee96e4.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function displayControlAdjust_SM750LE, including its name, parameters, and body. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 40 +++++++++++++-------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index e00a6cb31947..2fae81b47f46 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -14,13 +14,13 @@ * in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, - unsigned long dispControl) +display_control_adjust_sm750le(struct mode_parameter *mode_param, + unsigned long disp_control) { unsigned long x, y; - x = pModeParam->horizontal_display_end; - y = pModeParam->vertical_display_end; + x = mode_param->horizontal_display_end; + y = mode_param->vertical_display_end; /* * SM750LE has to set up the top-left and bottom-right @@ -36,42 +36,42 @@ displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK)); /* - * Assume common fields in dispControl have been properly set before + * Assume common fields in disp_control have been properly set before * calling this function. - * This function only sets the extra fields in dispControl. + * This function only sets the extra fields in disp_control. */ /* Clear bit 29:27 of display control register */ - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK; + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK; /* Set bit 29:27 of display control register for the right clock */ /* Note that SM750LE only need to supported 7 resolutions. */ if (x == 800 && y == 600) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL41; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL41; else if (x == 1024 && y == 768) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL65; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL65; else if (x == 1152 && y == 864) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80; else if (x == 1280 && y == 768) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80; else if (x == 1280 && y == 720) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL74; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL74; else if (x == 1280 && y == 960) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108; else if (x == 1280 && y == 1024) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108; else /* default to VGA clock */ - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL25; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL25; /* Set bit 25:24 of display controller */ - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT); + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT); /* Set bit 14 of display controller */ - dispControl |= DISPLAY_CTRL_CLOCK_PHASE; + disp_control |= DISPLAY_CTRL_CLOCK_PHASE; - poke32(CRT_DISPLAY_CTRL, dispControl); + poke32(CRT_DISPLAY_CTRL, disp_control); - return dispControl; + return disp_control; } /* only timing related registers will be programed */ @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - displayControlAdjust_SM750LE(pModeParam, tmp); + display_control_adjust_sm750le(pModeParam, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | From patchwork Wed Apr 7 06:36:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB9CC433B4 for ; Wed, 7 Apr 2021 06:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278AE6124C for ; Wed, 7 Apr 2021 06:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348889AbhDGGgb (ORCPT ); Wed, 7 Apr 2021 02:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348885AbhDGGg0 (ORCPT ); Wed, 7 Apr 2021 02:36:26 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73E6C06175F; Tue, 6 Apr 2021 23:36:17 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id a12so12180796pfc.7; Tue, 06 Apr 2021 23:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xEkX5xSjIsagQqqLDFxiiQocHiJ/DDzwHuOshMgpbFw=; b=thYSJ9fjJlSSwyX6GUt3rRzrmDkI7jRCiejyv36KZESRkC1Buo07GU2mBUv5Sl96xn mCaCArjZVQ4GZ4+K6PecXJ/uVQHJkTb2G/fKBtE7crWceT5U8qUteyMnO35xry4KXKoB Q8mLA10zpeGlXLG3PNNCoYQzzZrpse6K3tRnC/LeXgM3ttPNtjBfXvu8uNCLtcRcvXvX f3HBa39r6Y1kLQe6pHXhhnoiHcEf9eKbln7t1onx6DoXSQ/91S1utXQOqf60Jmv80MaK lSJKfx14qYkjsLDhlmuECsLwDmRMWZm/odkBTvW2GQLqoCXPiPw2bO0kkryf9xmVc/kv MQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xEkX5xSjIsagQqqLDFxiiQocHiJ/DDzwHuOshMgpbFw=; b=ZxdrRqaA98MtMUeHeoxucihb9YUrr0C6KxvjY9nAeo15gwRMuKQguzNSFWs0vwZosv WUK32xOdkcX+Lguz98h/EIMq12jXYvihxrtSdbjgiEc5HAws7YkhsmKIx173Atj+g1hZ WM5UxCf0i9j37w5Pr3NAto/d5OppSpHA6xYdd3rUh4wDNy2E8z2Va9vz2E0UN5aDBMZ4 Z8dnj0zgEjTAbzwFOfaj0cR8bSCyeHIRWIRcgkspN4BelK1v8yFe0gwDel4FJRjfCnko AAzhcxYQEaHS8XHW9CiACBAb+6fbKXMbXD75e1eeNEv8ufQLcN5L7jcoZsL4juUHpR2x nAsA== X-Gm-Message-State: AOAM532TkW7l4zwDbKnRKT9nNn9jv5/27/eTCjiXxXAKS8jBAtals078 tN7yWHW+Jv902QBtzjvjrm8= X-Google-Smtp-Source: ABdhPJzJX/CCjqvdgLevX1W2VlwM9ac6ztUBQ5HQwtFm9/0EtFQRMYZ5VJhD3cQGXHJpAPn/79vU9g== X-Received: by 2002:a05:6a00:2288:b029:202:2103:3f21 with SMTP id f8-20020a056a002288b029020221033f21mr1482523pfe.39.1617777377290; Tue, 06 Apr 2021 23:36:17 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w18sm4063739pjh.19.2021.04.06.23.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:16 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:14 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/49] staging: sm750fb: Update programModeRegisters to snake case Message-ID: <6d74a0eb5c1b1dd21ece0520e2c96f1b83df15c8.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function programModeRegisters, including its name, parameters, and body. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 48 +++++++++++++-------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 2fae81b47f46..5c685b4e2fd6 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -75,7 +75,7 @@ display_control_adjust_sm750le(struct mode_parameter *mode_param, } /* only timing related registers will be programed */ -static int programModeRegisters(struct mode_parameter *pModeParam, +static int program_mode_registers(struct mode_parameter *mode_param, struct pll_value *pll) { int ret = 0; @@ -86,46 +86,46 @@ static int programModeRegisters(struct mode_parameter *pModeParam, /* programe secondary pixel clock */ poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll)); - tmp = ((pModeParam->horizontal_total - 1) << + tmp = ((mode_param->horizontal_total - 1) << CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & CRT_HORIZONTAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->horizontal_display_end - 1) & + tmp |= (mode_param->horizontal_display_end - 1) & CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_HORIZONTAL_TOTAL, tmp); - tmp = (pModeParam->horizontal_sync_width << + tmp = (mode_param->horizontal_sync_width << CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & CRT_HORIZONTAL_SYNC_WIDTH_MASK; - tmp |= (pModeParam->horizontal_sync_start - 1) & + tmp |= (mode_param->horizontal_sync_start - 1) & CRT_HORIZONTAL_SYNC_START_MASK; poke32(CRT_HORIZONTAL_SYNC, tmp); - tmp = ((pModeParam->vertical_total - 1) << + tmp = ((mode_param->vertical_total - 1) << CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & CRT_VERTICAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->vertical_display_end - 1) & + tmp |= (mode_param->vertical_display_end - 1) & CRT_VERTICAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_VERTICAL_TOTAL, tmp); - tmp = ((pModeParam->vertical_sync_height << + tmp = ((mode_param->vertical_sync_height << CRT_VERTICAL_SYNC_HEIGHT_SHIFT)) & CRT_VERTICAL_SYNC_HEIGHT_MASK; - tmp |= (pModeParam->vertical_sync_start - 1) & + tmp |= (mode_param->vertical_sync_start - 1) & CRT_VERTICAL_SYNC_START_MASK; poke32(CRT_VERTICAL_SYNC, tmp); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - display_control_adjust_sm750le(pModeParam, tmp); + display_control_adjust_sm750le(mode_param, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | @@ -140,40 +140,40 @@ static int programModeRegisters(struct mode_parameter *pModeParam, poke32(PANEL_PLL_CTRL, sm750_format_pll_reg(pll)); - reg = ((pModeParam->horizontal_total - 1) << + reg = ((mode_param->horizontal_total - 1) << PANEL_HORIZONTAL_TOTAL_TOTAL_SHIFT) & PANEL_HORIZONTAL_TOTAL_TOTAL_MASK; - reg |= ((pModeParam->horizontal_display_end - 1) & + reg |= ((mode_param->horizontal_display_end - 1) & PANEL_HORIZONTAL_TOTAL_DISPLAY_END_MASK); poke32(PANEL_HORIZONTAL_TOTAL, reg); poke32(PANEL_HORIZONTAL_SYNC, - ((pModeParam->horizontal_sync_width << + ((mode_param->horizontal_sync_width << PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT) & PANEL_HORIZONTAL_SYNC_WIDTH_MASK) | - ((pModeParam->horizontal_sync_start - 1) & + ((mode_param->horizontal_sync_start - 1) & PANEL_HORIZONTAL_SYNC_START_MASK)); poke32(PANEL_VERTICAL_TOTAL, - (((pModeParam->vertical_total - 1) << + (((mode_param->vertical_total - 1) << PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) & PANEL_VERTICAL_TOTAL_TOTAL_MASK) | - ((pModeParam->vertical_display_end - 1) & + ((mode_param->vertical_display_end - 1) & PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK)); poke32(PANEL_VERTICAL_SYNC, - ((pModeParam->vertical_sync_height << + ((mode_param->vertical_sync_height << PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) & PANEL_VERTICAL_SYNC_HEIGHT_MASK) | - ((pModeParam->vertical_sync_start - 1) & + ((mode_param->vertical_sync_start - 1) & PANEL_VERTICAL_SYNC_START_MASK)); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; - if (pModeParam->clock_phase_polarity) + if (mode_param->clock_phase_polarity) tmp |= DISPLAY_CTRL_CLOCK_PHASE; reserved = PANEL_DISPLAY_CTRL_RESERVED_MASK | @@ -220,6 +220,6 @@ int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) outb_p(0x88, 0x3d4); outb_p(0x06, 0x3d5); } - programModeRegisters(parm, &pll); + program_mode_registers(parm, &pll); return 0; } From patchwork Wed Apr 7 06:36:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E243EC433ED for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B40BE613C0 for ; Wed, 7 Apr 2021 06:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348897AbhDGGgf (ORCPT ); Wed, 7 Apr 2021 02:36:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348879AbhDGGg2 (ORCPT ); Wed, 7 Apr 2021 02:36:28 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42CBC06174A; Tue, 6 Apr 2021 23:36:19 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id b17so8613099pgh.7; Tue, 06 Apr 2021 23:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JLhOPBDJGtizHkxpYodDCmquLiJc74NkWzdot10Uqo4=; b=E4gmRbZZB3nrPfH6rYurKTZ1NVPwu4BxR2b3mFcY7emW9XBR/0Vbkjv45xhT9mrl8T zYg4wPEw9rY2U1GXlL+4hgbLWG3p8o4XyvxD4IRyzljbRzvwWiRsD8w/HhjrFzcooPBO fWbbqnMdzR0r1trJROWweJ01y+8wsvtTnpIoqzFLoW6GJFL5GNtFdCvStx6/6kfN1Kzy 7jg1EKGuX01KvY05QJw39yvzZqKU0uD3IpTRvbQJJWcPf81aSFPEMSjNj/SoP5ZtXatS nQFE3APRS7YENjU+7rrMObQ8I68YILgELibvRiW5iKo0l194K2EzEbyNqx5IsjJO+09g 3WXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JLhOPBDJGtizHkxpYodDCmquLiJc74NkWzdot10Uqo4=; b=GOZG6ez9DEjeQ5kD/p+ZqCGTh3dkqMP+mEfEzpNSNaY3YteRAwb3W2OEDRNOI9QKM1 ZYZNkWkxgkYUKY9AoA6dRoGUiBWU4BlZwe6KrWk9nG+WNrW73BjHqUbdCXpWwettAlPs HSu8XckLfOY3y5oJAy1Gl+RX+sUQiwGXeXnFkx4yYWpuHJUIXMDTzgLdil7GQLYUxg6m Al4BQGhBCaC4H3w77wLSU7Ay4vsGHhJeNeGoyfLUflN7W6MAEDmHyd3NvAqbJjIn/+Sa C8Xjs3N6CqrU3K0D3isg0lWxMWF+f/mVD1RQ8UUQVPKNw0AWHh3LK1B86oPZX4XOocEW th0w== X-Gm-Message-State: AOAM531cE3+0lQbFtCoqe1HGltyQ9C37ZfRGqXQzJ11pkwHGez8yowV2 Onkc/4D+FucuDuo1Gq1Y+s4wW6QstlwaAQ== X-Google-Smtp-Source: ABdhPJxEYTKG+PCtN+CeP3xplySvBw9rwgnoRIal/cf2VznSrk1EHQGqNHaq0RI9n/aVrC5Yf78uig== X-Received: by 2002:a63:4f59:: with SMTP id p25mr1868291pgl.21.1617777379324; Tue, 06 Apr 2021 23:36:19 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id p10sm20128790pfn.55.2021.04.06.23.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:18 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:16 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/49] staging: sm750fb: Update enum values in dpms to snake case Message-ID: <16693e7cc62f84ea1ec34b7d5cbd77c4cd1965e8.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for values in enum dpms. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_power.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index 7002567a47d2..4756db1ccb9c 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -3,10 +3,10 @@ #define DDK750_POWER_H__ enum dpms { - crtDPMS_ON = 0x0, - crtDPMS_STANDBY = 0x1, - crtDPMS_SUSPEND = 0x2, - crtDPMS_OFF = 0x3, + CRT_DPMS_ON = 0x0, + CRT_DPMS_STANDBY = 0x1, + CRT_DPMS_SUSPEND = 0x2, + CRT_DPMS_OFF = 0x3, }; #define set_DAC(off) { \ From patchwork Wed Apr 7 06:36:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804B0C433B4 for ; Wed, 7 Apr 2021 06:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F6D9613B3 for ; Wed, 7 Apr 2021 06:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348887AbhDGGgg (ORCPT ); Wed, 7 Apr 2021 02:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348892AbhDGGge (ORCPT ); Wed, 7 Apr 2021 02:36:34 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ECC9C06175F; Tue, 6 Apr 2021 23:36:24 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id mj7-20020a17090b3687b029014d162a65b6so728503pjb.2; Tue, 06 Apr 2021 23:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NKhEC0n0+HHz2/kqzUxi1bjRR45zn9PJxgcyMxxcHD0=; b=lygCHTNwZJDmCnOGSnyS9lEPmMhRONQKdZ1ZE0u7OaH+tfgDKVRJ40Zdz01VUkHOQJ EUDhqvAMjHJv+mgimYY3R6/YM6MHssvn7nn0jTy9eDw7v1JY2gs4x5kUNUALDq7DXwe1 wFOB7B9RbtnSO7hl0rcRS2mSEp0R+2CpDGNJvNJTUYfbR5jGdrrcOGNGFq50OBsLUG1f rJeQhKQnSXwJSAsYQNzZFChA3nWWCWecTHkZL2tjsYF50Uv2bCc4teVKfwi58AlTjkhO MYkqtRpKBXSMrsGuuLOYIRKiLLb6rAXkGZVAfgSXsxBWDkRI2DlDFl/DEDbhTxDJPEu0 v9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NKhEC0n0+HHz2/kqzUxi1bjRR45zn9PJxgcyMxxcHD0=; b=K05IKKU9TYjNh65qYE0TR5d2r2Rk+8FEf2M3NHrwfTRVtRjhO+uzP8q1Tnl4EKtKUM slrMpsgWfCSGtYWHqMFTH4rOu1J6aGLupsJlS5k2CjaBCPi3UxzkkRDnMgj3zlUywZ9h 5HtCxHcFQ1vMi5ufK9PBb08AfjwNEeWP2fNWDXYTIBHkYPNCgOctJ5VTYg7Aljlwbasb pQJSG0OO9BEHgSfCWrNGhmSwzQt8xUHmlPFCSRs2h1puNpwg3klfQzZaTkmmDjmjdGa6 vN5XbaRS2FWcpv39ga0TVk36qYm8KxkLYQ2CUutFKI0Q/anX/od0xkXG7FHf/8Krsxen 6Tkw== X-Gm-Message-State: AOAM532eMd3/yYQujzAJencEiSN4QUM1hc8lWdbkt0UyuqwPy0SP9+sd uARhY1n1mCKRCzavqQZdJmg= X-Google-Smtp-Source: ABdhPJzjCrD9VkJdexxuIEAc44r4zfApwixmcFjRguF7fpRsP+5+wqpx2AuN60U/CklvcU2Q4Hcbvg== X-Received: by 2002:a17:90a:7f95:: with SMTP id m21mr584566pjl.174.1617777383574; Tue, 06 Apr 2021 23:36:23 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id f135sm20247563pfa.102.2021.04.06.23.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:23 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:21 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/49] staging: sm750fb: Rename sm750_set_power_mode function parameter Message-ID: <39375dd8cf48aabdc30c6bca67adc38887fd03cf.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function parameter powerMode of function sm750_set_power_mode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_power.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h index 4756db1ccb9c..d43942d6a5aa 100644 --- a/drivers/staging/sm750fb/ddk750_power.h +++ b/drivers/staging/sm750fb/ddk750_power.h @@ -15,7 +15,7 @@ enum dpms { } void ddk750_set_dpms(enum dpms state); -void sm750_set_power_mode(unsigned int powerMode); +void sm750_set_power_mode(unsigned int power_mode); void sm750_set_current_gate(unsigned int gate); /* From patchwork Wed Apr 7 06:36:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B87C433ED for ; Wed, 7 Apr 2021 06:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A65546124C for ; Wed, 7 Apr 2021 06:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348894AbhDGGgh (ORCPT ); Wed, 7 Apr 2021 02:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348883AbhDGGgf (ORCPT ); Wed, 7 Apr 2021 02:36:35 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F1FEC06174A; Tue, 6 Apr 2021 23:36:26 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id t24so5174124pjw.4; Tue, 06 Apr 2021 23:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ruk0ECVgk5cWHRPO3cAAhvgkfpUeZxerRvgvguMhn0o=; b=cCxkJ6PcgHqucOCgBqwJzcXMho+kt6wxoC9luQC65j75k28zZis00M0SDW3j2Y4AVa 5VsMoxxNOrJjg5dj/E7aa/dO1MxwWX2K5GDUm1NErwkCGTRleULp/7KSpky/XhXZeVJw Wcyj9etukxGB50xyMBmT2ccHj5lTgRhuZKk5NeoTPbXC0InqfWPEFQci63q6cZeEDdg+ 4vZUuTfdeBc48mAbTscdQIbfIOHuUlBw1tORYtZaM3iUXEuj+ZVxsb41PbzbGmxgR4Fr +pm/4yD7Ka8bwklFfKxAzHbO1TjDxsYMpikH1lRAHJHK8t+HWZEgUNYiXS84Xr8TLvlM EAmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ruk0ECVgk5cWHRPO3cAAhvgkfpUeZxerRvgvguMhn0o=; b=okGw7LAHLRVNAA1xkLHiiomnjyoAvtqsISpUEfVoW9bs1cShv/O2FaNvP5o3bADkL8 oWYFQ4WckwlV79BVEt5isPtM0z9kiRLv++mADBWol0EHFlzrSmvOxkIKp4VR7LeHl892 7Uo+gkiaiTMWWOP5tipJLAVQyoT6QKHruJD1Sn8SzuZA/Ass0qR3OJQILh61CfvhNKxf wwgCCxLOrYCGWD2P0TwrxMhppZ7hHchIQBKSn7jWu8ZTFsStHSYqyBva5eaPmXL6WsNf kzk66RtXzh2stebswen48B/loSj+Jlf/erfyCluOlehHmj0tzQ+nLC9Y5MlQZmDHkb5T L1aA== X-Gm-Message-State: AOAM531FFgP1I6a3V3NZwvromNGFxudedi0RAG1VhL/XUKngdMHGTLdn 2kKPDrscYG+yQG38UIHwcGWtRu7oo3I3TQ== X-Google-Smtp-Source: ABdhPJyN79crnDz/EANR+ilOos5UHzuBrR29ClVpgHmPReRVWTDoisYajjjTpvhOzOjwA4j+Xc4I3A== X-Received: by 2002:a17:90a:3ee3:: with SMTP id k90mr417024pjc.147.1617777385644; Tue, 06 Apr 2021 23:36:25 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w16sm784249pfn.200.2021.04.06.23.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:36:25 -0700 (PDT) Date: Tue, 6 Apr 2021 23:36:23 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/49] staging: sm750fb: Rename ddk750_setModeTiming to ddk750_set_mode_timing Message-ID: <2b1d5ae43f2f5556dfc787d15b27d0db99354c85.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function ddk750_setModeTiming. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 5c685b4e2fd6..2548695829ec 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -207,7 +207,7 @@ static int program_mode_registers(struct mode_parameter *mode_param, return ret; } -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock) { struct pll_value pll; diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 2df78a0937b2..1b70885f85e5 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -33,5 +33,5 @@ struct mode_parameter { enum spolarity clock_phase_polarity; }; -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock); +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock); #endif diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 7136d751cff5..e31f4c6bc69e 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -305,7 +305,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, clock = SECONDARY_PLL; pr_debug("Request pixel clock = %lu\n", modparm.pixel_clock); - ret = ddk750_setModeTiming(&modparm, clock); + ret = ddk750_set_mode_timing(&modparm, clock); if (ret) { pr_err("Set mode timing failed\n"); goto exit; From patchwork Wed Apr 7 06:37:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB79C433ED for ; Wed, 7 Apr 2021 06:37:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 776126052B for ; Wed, 7 Apr 2021 06:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348919AbhDGGhR (ORCPT ); Wed, 7 Apr 2021 02:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348892AbhDGGhP (ORCPT ); Wed, 7 Apr 2021 02:37:15 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C67B2C06174A; Tue, 6 Apr 2021 23:37:06 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id y32so9079984pga.11; Tue, 06 Apr 2021 23:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vULtDa5keVBuOsfipQdVKGYBxEy7Ud81/4o2D3FTHWs=; b=XoKonTp1E4C28zmw43dvziWmtoduTK7P/adrpQQDP9obdlimDZDDGVMWdM0xEo8m/g xMV7eII7LP5cIGjZYynGHEQtEPE0VDh8mdgDhnd6PiL8xsHhelI0IcKG+dQ7dHTwvMO4 XFgxOFeRJg2+XPLMXZ9MvY0ZHBBvqfWIOkA2wXYQ4+r0A9QcOmgScKibFIxv8ptfdm2U VcNAEovNhRnBT5ll5YVt7PLge0gX+L79GcznHdqLeBWmWNk3lYKeCAdxRHZ4f+o8Bc/6 MjMC4rz698wUHSclZyr8hqUcG6xzT2ReVUTGZaaQ2Mm16ABeCCc7ZQtSwNJMknppV4Mv r7uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vULtDa5keVBuOsfipQdVKGYBxEy7Ud81/4o2D3FTHWs=; b=gENmue8+jUe1gqhsD9QPAHqsINjNEjj71wM7sKHy1w30x2Djc4clBHXxd+trPTXd+x f/lIx0WDQCrUP+mzP5MftMPhy2F+Gruc26fGxPB+j6+o+cWONPG6fTpsl+99G7pc6cot xOwERODb8WMZX7vvq6cqwLKDpsf6Q1Vj+jhKqRj8TbsPk+726WvaHaPehmsib/IHZEOn gEtuRjNeSrP0o7GLjbc2/8YdMRNoQd2AIvHcMfz0TuKhhYmfWY6vxelIOA8UOWPrJxEx mYp+gnFZNRZ+f493IiubpgKdHT5FJX6a9fObk+KPJ3+0uZdhPqCIj249y0sqErFM9B21 f4lQ== X-Gm-Message-State: AOAM531XswNqHgp0BVqaYCMOJ3sdzChRBMS75Xhr7a5TwpAFWNkz+94D WxyQTrYv//bYVXIUhZ774oA= X-Google-Smtp-Source: ABdhPJwS8g6q8EWYDwh7VZlr2HoIpM+960xrKG0v9PqsNci9JamJ6RO4Wp9euXTYeUjfHuJK1eFkHw== X-Received: by 2002:a63:342:: with SMTP id 63mr1831044pgd.151.1617777426141; Tue, 06 Apr 2021 23:37:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w26sm20734055pfj.58.2021.04.06.23.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:05 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:03 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/49] staging: sm750fb: Rename i2cWriteReg and i2cReadReg to snake case Message-ID: <8a68f0a377016bd8026359e7ca10c658087ffac6.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for i2cWriteReg and i2cReadReg in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 46 ++++++++++++------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 6c343e2e0433..af14273b99eb 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -12,11 +12,11 @@ #define USE_HW_I2C #ifdef USE_HW_I2C - #define i2cWriteReg sm750_hw_i2c_write_reg - #define i2cReadReg sm750_hw_i2c_read_reg + #define i2c_write_reg sm750_hw_i2c_write_reg + #define i2c_read_reg sm750_hw_i2c_read_reg #else - #define i2cWriteReg sm750_sw_i2c_write_reg - #define i2cReadReg sm750_sw_i2c_read_reg + #define i2c_write_reg sm750_sw_i2c_write_reg + #define i2c_read_reg sm750_sw_i2c_read_reg #endif /* SII164 Vendor and Device ID */ @@ -39,9 +39,9 @@ unsigned short sii164_get_vendor_id(void) { unsigned short vendorID; - vendorID = ((unsigned short)i2cReadReg(SII164_I2C_ADDRESS, + vendorID = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | - (unsigned short)i2cReadReg(SII164_I2C_ADDRESS, + (unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_LOW); return vendorID; @@ -58,9 +58,9 @@ unsigned short sii164_get_device_id(void) { unsigned short deviceID; - deviceID = ((unsigned short)i2cReadReg(SII164_I2C_ADDRESS, + deviceID = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_HIGH) << 8) | - (unsigned short)i2cReadReg(SII164_I2C_ADDRESS, + (unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_LOW); return deviceID; @@ -176,7 +176,7 @@ long sii164_init_chip(unsigned char edge_select, else config |= SII164_CONFIGURATION_VSYNC_AS_IS; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); /* * De-skew enabled with default 111b value. @@ -214,7 +214,7 @@ long sii164_init_chip(unsigned char edge_select, config |= SII164_DESKEW_8_STEP; break; } - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DESKEW, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_DESKEW, config); /* Enable/Disable Continuous Sync. */ if (continuous_sync_enable == 0) @@ -231,12 +231,12 @@ long sii164_init_chip(unsigned char edge_select, /* Set the PLL Filter value */ config |= ((pll_filter_value & 0x07) << 1); - i2cWriteReg(SII164_I2C_ADDRESS, SII164_PLL, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_PLL, config); /* Recover from Power Down and enable output. */ - config = i2cReadReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); + config = i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); config |= SII164_CONFIGURATION_POWER_NORMAL; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); return 0; } @@ -283,17 +283,17 @@ void sii164_set_power(unsigned char powerUp) { unsigned char config; - config = i2cReadReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); + config = i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); if (powerUp == 1) { /* Power up the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_NORMAL; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); } else { /* Power down the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_DOWN; - i2cWriteReg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION, config); } } @@ -306,7 +306,7 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; switch (hotPlugMode) { case SII164_HOTPLUG_DISABLE: @@ -325,7 +325,7 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) break; } - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg); } /* @@ -338,7 +338,7 @@ void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); + detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); /* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. @@ -361,7 +361,7 @@ unsigned char sii164_is_connected(void) { unsigned char hotPlugValue; - hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + hotPlugValue = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) return 1; @@ -381,7 +381,7 @@ unsigned char sii164_check_interrupt(void) { unsigned char detectReg; - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & + detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; if (detectReg == SII164_DETECT_MONITOR_STATE_CHANGE) return 1; @@ -398,8 +398,8 @@ void sii164_clear_interrupt(void) unsigned char detectReg; /* Clear the MDI interrupt */ - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, + detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); } From patchwork Wed Apr 7 06:37:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20384C43461 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC4AD613CD for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348892AbhDGGhX (ORCPT ); Wed, 7 Apr 2021 02:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348928AbhDGGhR (ORCPT ); Wed, 7 Apr 2021 02:37:17 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD2C2C06174A; Tue, 6 Apr 2021 23:37:07 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id x26so5447482pfn.0; Tue, 06 Apr 2021 23:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5wteGrNjTPUFB2ScDRoKVavC5gzuo9SnMMiAPfPlNCw=; b=IEn9J76Lrugc/nUlPH9NZtZ75aywRi+kX3Z/6TeK3ZWmibspXs2M1eoU+9sqvzHuNk qWN1keMnWiY2Fm47qlCozmZvdxu+uDJ2bAm2JiiWl6JAiOi4Qi7QzeiHrqucDiWKr9N8 CXhtRgNZXTv+RzqAV4mrzFi1qf0xLZF08e9l+v2X3zW/ZGQyMeHyx6jxxDEssosnMGdh HB8EGRQf2sYxPlgTTR85hYX1K/U/OjMyWWk76OF/C5uGrV/OWE9pvEJIMHqyO30Dq0Y6 S16zyrPXvCmrp002Co2RleisWdkIdkq3wmq5nR4kLsKIeTMeLWtGMSdu1oDgXDMj4Ong RwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5wteGrNjTPUFB2ScDRoKVavC5gzuo9SnMMiAPfPlNCw=; b=WDaqTElxJOqubkZ8piYt4JS/q0dKvB7QiXlCvHQojbZKvI7MsFhucmnP1ms3X6QTmW dTEdNZ9Ywch9owa8/Eiwx88jUdWFCUtnf/onmlBNRAe599y55vyXZp5vzUE/tQitvzk+ 4eR5EYnwq4mhDgb7B97b6JiV0Ww94+aPV78+iUAh3i1Gi+8eLvALvXBXOkQ7ZsnIQw2W jUB94vDXNRf/6PtLfEPP3pEb0KbWIIG2Q0xklNc9rDVj2nzp+BZDbQ5Ac3tgwI+bdwBo ZlzBhM8NmlBvSx8YGvIbCVPKRqrwyj/CjMwdPlh3Mzp/O8ALNEGK5bK/fkPTcX2kh1FF nsvQ== X-Gm-Message-State: AOAM533/RtBNvHt1jJIYtr7FBgEDL0JowBQRu9CN8HinjSVH9Ll1RGcN tm8R84CVXBWPKN+Z+IFsV5w= X-Google-Smtp-Source: ABdhPJxnL2AlOFOVq2buT/wYmiXorBFb4z+UVn2KSZphdDcp2PVtoou+pHQjsExZXemZ91dpLqPvYw== X-Received: by 2002:a62:1c93:0:b029:1fd:2216:fb45 with SMTP id c141-20020a621c930000b02901fd2216fb45mr1476120pfc.13.1617777427417; Tue, 06 Apr 2021 23:37:07 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id b84sm20998653pfb.162.2021.04.06.23.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:07 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:05 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/49] staging: sm750fb: Rename vendorID local variable to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the local variable vendorID in the function sii164_get_vendor_id. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index af14273b99eb..14d7083775b4 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -37,14 +37,14 @@ static char *gDviCtrlChipName = "Silicon Image SiI 164"; */ unsigned short sii164_get_vendor_id(void) { - unsigned short vendorID; + unsigned short vendor_id; - vendorID = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, + vendor_id = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | (unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_LOW); - return vendorID; + return vendor_id; } /* From patchwork Wed Apr 7 06:37:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F7DC43460 for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAA39613B3 for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348945AbhDGGhX (ORCPT ); Wed, 7 Apr 2021 02:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348922AbhDGGhR (ORCPT ); Wed, 7 Apr 2021 02:37:17 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E698AC061756; Tue, 6 Apr 2021 23:37:08 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id c17so12170442pfn.6; Tue, 06 Apr 2021 23:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZGMaTnhAGkt8KYVxrVKbfZTGzttqgPwSz58aY8xeIts=; b=DPhGn5VNya3y33vxf5Ki/zWMTNOzOY4P+JPBBl00ReAABTtKxV40hi/pVgmAetvOTt hkMy4xCmn89/m2by9NNV7BDHFZJGsoHsc47SLRkxyfDZQyUxoxhUeS45T6LgezSQIOCB 0uhJKnbfwioBIBj7eJoROWEMljCJkj7xuiZ20Ve154ll4LTOe8m0TfPGm14GUti21cLu tQpgu0o7x9q28SB7JSGiRZpJbfyq4T6ox6GS7ivjcHipOhJzXubTqcttnD7fcLpsAC55 P0JUPSzVlPnLmKgJUfixs/FL4PxNyASxhamX2KZfMCPOr1HBy5ZM8NEb4evCkaV68rfO gNFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZGMaTnhAGkt8KYVxrVKbfZTGzttqgPwSz58aY8xeIts=; b=UIwYfJ8docdQ/OROW5blDBx6dUQxgckV3NgI1DlHcP6j2DYOb/i6oBI7dDnAvY+Mkd 3iVVPrNdVozXkieOr0j5f9JtCFRskZAueiRH4r/YIsgyGp7e7mLrab1KmNPHdYs0hwW7 Rebzj6ParlzOTGk/f+7VC93G7mk79f6fSXuH/eYWfiK6miWmUJuRPQCw2e3XTibo4UZe 69RTWVX7iwPkXXXgLj91MQfAebVWh3D6dyETLr6KK8hViUbeH4WlRbsMGyH5Q3FWiNUc T3RFNmZwblcNEWENMdYSc3u7IPUAMPcfM93eyb4eNYb7eTRybOzLilHndXConp4isuF3 EqAA== X-Gm-Message-State: AOAM5317GJ6hJsXAEvyjf6aVqI9Mit2oNUemoHAVKN1/rpCZcyWrRAWD D+OvE38k27R3jp99AWEmqaw= X-Google-Smtp-Source: ABdhPJyT0UMLGJ9rpAI763JX6R6qPy2596YeMN0kG9OZZlfz5zu/2aTtVSennR8N+N796+LoKrcVwg== X-Received: by 2002:a62:8485:0:b029:1fc:823d:2a70 with SMTP id k127-20020a6284850000b02901fc823d2a70mr1606951pfd.18.1617777428422; Tue, 06 Apr 2021 23:37:08 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id s76sm20722388pfc.110.2021.04.06.23.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:08 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:06 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 13/49] staging: sm750fb: Rename deviceID local variable to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the local variable deviceID in the function sii164_get_device_id. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 14d7083775b4..ceeb914f8441 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -56,14 +56,14 @@ unsigned short sii164_get_vendor_id(void) */ unsigned short sii164_get_device_id(void) { - unsigned short deviceID; + unsigned short device_id; - deviceID = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, + device_id = ((unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_HIGH) << 8) | (unsigned short)i2c_read_reg(SII164_I2C_ADDRESS, SII164_DEVICE_ID_LOW); - return deviceID; + return device_id; } /* From patchwork Wed Apr 7 06:37:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B50C43462 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02EF9613C0 for ; Wed, 7 Apr 2021 06:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348940AbhDGGhY (ORCPT ); Wed, 7 Apr 2021 02:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348935AbhDGGhU (ORCPT ); Wed, 7 Apr 2021 02:37:20 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EA4CC06175F; Tue, 6 Apr 2021 23:37:11 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id p10so3695846pld.0; Tue, 06 Apr 2021 23:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BtyBOMvsqSJAayOGR2ps6Fm5o+TmuUaUOXkQzK0Am80=; b=FYxkr4zNiq+MJV0WrNM/yKUHigyUboVN9BVJ/JJ5qxDsVp7R+hZCNWzmv3aSNvZcvD 2uIguRDT37Etg0K2v4exBizNKH2BtXOMR+bpoXs08TP7sZ4mJFZlAa4zDfYQhXujiuaU IUzokmik9TLiLYU8vVaKyySF3kAUQZhKE6FOUim5T8qas27ror5wckKPsJod7tThnTul XKkx8vQpAVWpwmPGqdvBOkEGjSUo0xIchc0wdYe6x3R58WuQFNXiAptRPCeLCl1Ymls9 u1v0nUo3g0tNdqVReKWPhw8Tc3aNhzLHS7oZYIg92ZHE8509ju4NxoIlTJmC6eiqpnpr 2slw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BtyBOMvsqSJAayOGR2ps6Fm5o+TmuUaUOXkQzK0Am80=; b=gd2khaQ3l5raVNlhWGLk24c6XO7j4DDbuyFtDCguznJL6ruIAdEVybLsek/F8frrb2 6sEifWcITuGS1i98ASImnPBGQXL5ly6707UG6Tr0n4rh9iopu5Yj+56G3hM6u//6RJvT U/xgWMlzSWMyQEn9DnHorqxS5pJXso3z6VOQA9+fDuKx7okJ+C0ER7h8GlTvSEGOHT3X UeAGVmVPxB6BODydzH4fZum+C54mQNKQx2/7M9wVPpqy4TXhdb5/uXKfCpK5w0s3YkZ4 d7Yp5htq/iI9q+hZeI8ZtY4USKX12Tsyr06tOYbD+USeLbXbNkp2+QUhoe/9PIgq7gM+ KrqA== X-Gm-Message-State: AOAM5337vw5QkfPsaOniq0xllnUDmLH15gO3zNfjItmkrVYrUhTd+sde WIMjYROrRoQXz32wJ+82UFg= X-Google-Smtp-Source: ABdhPJx62uNLl6w6YDWL21XyY3o6O682yByIaQI1OCkg2oivnbKc6M+sEPhfMEzwkSr20Tun3HEiDQ== X-Received: by 2002:a17:902:f686:b029:e5:de44:af60 with SMTP id l6-20020a170902f686b02900e5de44af60mr1772297plg.64.1617777430958; Tue, 06 Apr 2021 23:37:10 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w203sm19836430pfc.188.2021.04.06.23.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:10 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:08 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 14/49] staging: sm750fb: Rename sii164SelectHotPlugDetectionMode to snake case Message-ID: <39d33b45117c205208b6fa9c21ac9d32eaa9c5b1.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function sii164SelectHotPlugDetectionMode in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index ceeb914f8441..7e0a481970f5 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -298,11 +298,11 @@ void sii164_set_power(unsigned char powerUp) } /* - * sii164SelectHotPlugDetectionMode + * sii164_select_hot_plug_detection_mode * This function selects the mode of the hot plug detection. */ static -void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode) +void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode) { unsigned char detectReg; @@ -344,9 +344,9 @@ void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) * on each individual chip design. */ if (enableHotPlug != 0) - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_USE_MDI); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_USE_MDI); else - sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_DISABLE); + sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_DISABLE); } /* From patchwork Wed Apr 7 06:37:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAEBC43470 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E496613C0 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348950AbhDGGhY (ORCPT ); Wed, 7 Apr 2021 02:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348913AbhDGGhW (ORCPT ); Wed, 7 Apr 2021 02:37:22 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13893C061761; Tue, 6 Apr 2021 23:37:13 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id t23so6012268pjy.3; Tue, 06 Apr 2021 23:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OdUv2xn5NTVX4upCxFLBlB0yHvpqXhX8iMiPwr0mJUo=; b=feh8cmuNFbOe6K8YLbss+gUYGOmZxEtOYqMSn8UeBRI1QIjyXO6O3TDrS9hhqii26O B+Ffbqg/Kw+8upWR7MiKn556v6yqiO5C/cyeacNP1qOsvuAOPncgQ2tMr6jf4LK/W4kV LyMUulkNgoKbHkLLjaGwWA6s+GF1H7vJwImQWmTT9PilbDm9oLf7JBEi9+lDxg12GqGY peKuuH9WfNA+hfeLlRcvRd5tTZ0WDgmd2gnVLwAFzpq5ndAFHkE/lbGAlA95hqncYlyp LbckmrM5O/iJeG0CCVQrnkfifwMLWMImQ5MPCprnuk6DyFTvulKC4vVzE6D8uK4xxpbe q+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OdUv2xn5NTVX4upCxFLBlB0yHvpqXhX8iMiPwr0mJUo=; b=U22d4Fk5FwV5KXotyJa0jOSlQSoC6ARbG1WN0BZ70DB+siV17896mgOFVlBQ0LmWoz /dj9JhjFim6+DavFLVYcEOr28HOTb5tfhpHKxEqVSTpafAFU+ORmmZXQErDLeM26z3zU Hy4i7i2XztpC8vSh7pMFEDD08MgrIqJqFgtlTi7pKQsqG2lJUVvSf0xjyvU5+MlW/RcR VwW6YGreeENwcGEkjQ5GTzEoZ5oWj/ZCb1fwTIFINGuEqDhTTgSCTUzZvixlxuAjIJFJ xm135llTuTOoFFZZBjVdld0LMAHOtVe9rtUPWpyD+EC2dxZxCxnjKVeKtzJ953YwTwnd A8Fg== X-Gm-Message-State: AOAM531tRcWw+M1fT1C/U43WBnDh0kMgXQYnwwLkOtWuBVthBzKJ3aXp TAyRtNlyJI2wBzpZJP6l0ho= X-Google-Smtp-Source: ABdhPJx+jOoVjmVg8eboQUVBADDx/rVM3HKCdPwk2DHla3qTcWnsseF+WE+NAdOnRG5f/Cya6++6jg== X-Received: by 2002:a17:902:9f94:b029:e9:68a3:8551 with SMTP id g20-20020a1709029f94b02900e968a38551mr835471plq.35.1617777432651; Tue, 06 Apr 2021 23:37:12 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w21sm4180614pjy.52.2021.04.06.23.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:12 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:10 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 15/49] staging: sm750fb: Rename gDviCtrlChipName to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the global variable gDviCtrlChipName. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 7e0a481970f5..a7e0f001d96f 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -25,7 +25,7 @@ #ifdef SII164_FULL_FUNCTIONS /* Name of the DVI Controller chip */ -static char *gDviCtrlChipName = "Silicon Image SiI 164"; +static char *dvi_ctrl_chip_name = "Silicon Image SiI 164"; #endif /* @@ -269,7 +269,7 @@ void sii164_reset_chip(void) */ char *sii164_get_chip_string(void) { - return gDviCtrlChipName; + return dvi_ctrl_chip_name; } /* From patchwork Wed Apr 7 06:37:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B7CC43603 for ; Wed, 7 Apr 2021 06:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC681613C0 for ; Wed, 7 Apr 2021 06:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348956AbhDGGhZ (ORCPT ); Wed, 7 Apr 2021 02:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348944AbhDGGhX (ORCPT ); Wed, 7 Apr 2021 02:37:23 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 694C5C06174A; Tue, 6 Apr 2021 23:37:14 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id p10so3695905pld.0; Tue, 06 Apr 2021 23:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dQrlDf0eDikumeOMgJ6ztK4P1o0ZR5DUf/qDrdQaE4g=; b=tVYXTWuH1N0C4RnwthpEI3savbkYox+RhtgZ2mFjU8Q7w6GEMIFs94zjEVTulflvkC Ouzrln1JTlBxQ2EJs77a04jkH/i/DeOq4236o8hwIO+uznKVPK8M8AarByMRIIZvIzoC tQe13+tZyS5cgQYS1ZWGltd1tcXmkr8OReKNt7ZXdypm/pcPhssPfPCfALQaF5LPL7Dy WleV/RfwrM5YKlIceCYNGfGLlHIOpOpPhu4sE/HUutrCFG8kow9svNXrhfNig5eyOd6Q aIPLNzsmQGReAWKrAkOsxCMF1ScpsoLWZ/0FSpma5VZe0zvSaosLD9VFcLiVywTnlk9f Azaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dQrlDf0eDikumeOMgJ6ztK4P1o0ZR5DUf/qDrdQaE4g=; b=DZ/svSS1tPH7Kn9UheGQJfSa03SGo2KA1ZZAAk2nSJm0doklVNWhxb/9l4eqjJgCDq ax9psFibQTR9jS4tmCO07XuQV7lmOPCylb0oWxG1uSS1FTdpYpSLxa9k1z5DmVOwvrpM YIdrVINxMaePI2h0RgudM/r12c2U0/CPzpPCUokHBk97IwnBGt4fcOp1E95xYZ8BCs76 5Tl0suR4GGo3PIbBMuUXev8+Ljp6D+zJ0YAY+c+QfQBCSzY/qnuhC9c2365wTlZemUQq iBOXkf47eTeGm66FCnFbhAwv0rZVmf7wMlG6Hz1je0qGKhJ4cpCZgni2iw13qrMeYfBd V5vQ== X-Gm-Message-State: AOAM5326lgWxzHkRkqKVhz2PUS0XnhM5el/1vSeM0cud643X6szOEatB DhOzSiessd4oqEJ1c/lNafU= X-Google-Smtp-Source: ABdhPJwC2wF7XTq33ajE5NYMbxgVzCijJmae94EWZ6VhqV/eqM/QG7L8Et10IrnpxCRWw5hT/mrC2Q== X-Received: by 2002:a17:902:d4c7:b029:e9:543c:58bc with SMTP id o7-20020a170902d4c7b02900e9543c58bcmr1757708plg.20.1617777433926; Tue, 06 Apr 2021 23:37:13 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id j21sm18707903pfc.114.2021.04.06.23.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:13 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:11 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/49] staging: sm750fb: Update function parameter names in ddk750_sii164.c Message-ID: <53df8b6501a7849644fba613e194bfc297abb7c7.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in ddk750_sii164.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index a7e0f001d96f..869d74f53a6a 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -277,14 +277,14 @@ char *sii164_get_chip_string(void) * This function sets the power configuration of the DVI Controller Chip. * * Input: - * powerUp - Flag to set the power down or up + * power_up - Flag to set the power down or up */ -void sii164_set_power(unsigned char powerUp) +void sii164_set_power(unsigned char power_up) { unsigned char config; config = i2c_read_reg(SII164_I2C_ADDRESS, SII164_CONFIGURATION); - if (powerUp == 1) { + if (power_up == 1) { /* Power up the chip */ config &= ~SII164_CONFIGURATION_POWER_MASK; config |= SII164_CONFIGURATION_POWER_NORMAL; @@ -302,13 +302,13 @@ void sii164_set_power(unsigned char powerUp) * This function selects the mode of the hot plug detection. */ static -void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode) +void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hot_plug_mode) { unsigned char detectReg; detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; - switch (hotPlugMode) { + switch (hot_plug_mode) { case SII164_HOTPLUG_DISABLE: detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HIGH; break; @@ -332,9 +332,9 @@ void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hotPlugMode * sii164_enable_hot_plug_detection * This function enables the Hot Plug detection. * - * enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection + * enable_hot_plug - Enable (=1) / disable (=0) Hot Plug detection */ -void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) +void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) { unsigned char detectReg; @@ -343,7 +343,7 @@ void sii164_enable_hot_plug_detection(unsigned char enableHotPlug) /* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. */ - if (enableHotPlug != 0) + if (enable_hot_plug != 0) sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_USE_MDI); else sii164_select_hot_plug_detection_mode(SII164_HOTPLUG_DISABLE); From patchwork Wed Apr 7 06:37:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF18C433ED for ; Wed, 7 Apr 2021 06:37:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B36966052B for ; Wed, 7 Apr 2021 06:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348967AbhDGGh2 (ORCPT ); Wed, 7 Apr 2021 02:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348954AbhDGGhZ (ORCPT ); Wed, 7 Apr 2021 02:37:25 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DA77C06174A; Tue, 6 Apr 2021 23:37:16 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id n38so2504470pfv.2; Tue, 06 Apr 2021 23:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DYURKtLO6AtN4f6e54JwN9XZV55wF5BkCRQvFn99ABM=; b=ZxX/pDJ/ycCJIAr9JnYgENG2GHwcQVqthIG3lI/ZjHzcciTdYG0WM9Qn5EHVr4dSTR d07E5zpEoFac3yoE1GL+shm57oJYCLnrECJ/FrRKR4+0ncnfbb+uSyHKTX1zEo3dtSlE rwXz0xlHGvHAPTy1ter8A06UZKn16leAqQaNiZgb/4+KLyiv40okJ/7YVCLixloQrLsT SxPsyiQMq0bGeaCpX9XETtV7IANTvFcVBD1U5WY/+d6gnbCW3EsRXB4D1hoARcaZiSQH wuHXFV845voBWjKhQdcnKVtbYu+tekOE6gTMik2S5XCme1CUtyXqN93X2sG0w9TsQcnZ 3m6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DYURKtLO6AtN4f6e54JwN9XZV55wF5BkCRQvFn99ABM=; b=OzSixYlAq2gy7yRKW2Gk1h6RyxNzrP81rYOFDY3zXyAmiDXgjm1oA2MLGUzLx+YS52 goLeDJjYU63zIg1EDDqn7HakdR0vXGe3aRrxGPTHmdZueSXg3r+1C+AIYGjygPZNlv4d P27TUymTexrB4z64OO/mbaLfOGRuPnxlkOxAXP/4WIvWfuR/vcH8QK3NicvN5o/Rx1aY 5trHwLsTxlqiNFrvW/puyR+iCXSFg3pDSdfyuftypGv6+B9gNYcV1lKfktDDUf3s8MZ7 6raLoUdC3irbpDjX+uYf1We86Wlo8M4CuviXfISwfBn0YatspVuVVf78ZhZknbNle8Qz DFAw== X-Gm-Message-State: AOAM531DNNqv0vGcN4TU/Zpfai/GGd/xbyk8RHSNBEAYSCVi+ojHhmbP vF+lVLyvGFyTBIFXicKmlmk= X-Google-Smtp-Source: ABdhPJz2yOyJ5mHpagT/V01zGJIu58qjTR0EquQjsb+wWJOg/2MywFInIX9gMohojTtConxGWnLuZQ== X-Received: by 2002:a63:cc05:: with SMTP id x5mr1867032pgf.254.1617777435642; Tue, 06 Apr 2021 23:37:15 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id kk6sm4290581pjb.51.2021.04.06.23.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:37:15 -0700 (PDT) Date: Tue, 6 Apr 2021 23:37:13 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 17/49] staging: sm750fb: Rename local variables to snake case Message-ID: <031bfc81af290969ddfd06d211de6fc85db283ac.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for local variables in SII164_FULL_FUNCTIONS block. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.c | 40 ++++++++++++------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index 869d74f53a6a..758a118e4421 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -304,28 +304,28 @@ void sii164_set_power(unsigned char power_up) static void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hot_plug_mode) { - unsigned char detectReg; + unsigned char detect_reg; - detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & + detect_reg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & ~SII164_DETECT_MONITOR_SENSE_OUTPUT_FLAG; switch (hot_plug_mode) { case SII164_HOTPLUG_DISABLE: - detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HIGH; + detect_reg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HIGH; break; case SII164_HOTPLUG_USE_MDI: - detectReg &= ~SII164_DETECT_INTERRUPT_MASK; - detectReg |= SII164_DETECT_INTERRUPT_BY_HTPLG_PIN; - detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_MDI; + detect_reg &= ~SII164_DETECT_INTERRUPT_MASK; + detect_reg |= SII164_DETECT_INTERRUPT_BY_HTPLG_PIN; + detect_reg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_MDI; break; case SII164_HOTPLUG_USE_RSEN: - detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_RSEN; + detect_reg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_RSEN; break; case SII164_HOTPLUG_USE_HTPLG: - detectReg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HTPLG; + detect_reg |= SII164_DETECT_MONITOR_SENSE_OUTPUT_HTPLG; break; } - i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg); + i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, detect_reg); } /* @@ -336,9 +336,9 @@ void sii164_select_hot_plug_detection_mode(enum sii164_hot_plug_mode hot_plug_mo */ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) { - unsigned char detectReg; + unsigned char detect_reg; - detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); + detect_reg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); /* Depending on each DVI controller, need to enable the hot plug based * on each individual chip design. @@ -359,11 +359,11 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug) */ unsigned char sii164_is_connected(void) { - unsigned char hotPlugValue; + unsigned char hot_plug_value; - hotPlugValue = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & + hot_plug_value = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; - if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) + if (hot_plug_value == SII164_DETECT_HOT_PLUG_STATUS_ON) return 1; else return 0; @@ -379,11 +379,11 @@ unsigned char sii164_is_connected(void) */ unsigned char sii164_check_interrupt(void) { - unsigned char detectReg; + unsigned char detect_reg; - detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & + detect_reg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; - if (detectReg == SII164_DETECT_MONITOR_STATE_CHANGE) + if (detect_reg == SII164_DETECT_MONITOR_STATE_CHANGE) return 1; else return 0; @@ -395,12 +395,12 @@ unsigned char sii164_check_interrupt(void) */ void sii164_clear_interrupt(void) { - unsigned char detectReg; + unsigned char detect_reg; /* Clear the MDI interrupt */ - detectReg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); + detect_reg = i2c_read_reg(SII164_I2C_ADDRESS, SII164_DETECT); i2c_write_reg(SII164_I2C_ADDRESS, SII164_DETECT, - detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); + detect_reg | SII164_DETECT_MONITOR_STATE_CLEAR); } #endif From patchwork Wed Apr 7 06:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3DCC433B4 for ; Wed, 7 Apr 2021 06:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 000F2610C8 for ; Wed, 7 Apr 2021 06:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349002AbhDGGn3 (ORCPT ); Wed, 7 Apr 2021 02:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGn3 (ORCPT ); Wed, 7 Apr 2021 02:43:29 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33BAC06174A; Tue, 6 Apr 2021 23:43:18 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so775858pjv.1; Tue, 06 Apr 2021 23:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZAuGglzaZUilwxmfKh+vB3j+5qRuKYKMV1iFQ03oySg=; b=g6gIelmtiXWSl9iuGdO97naDvYmDnPLLIeCo+nOz0LwZQrG3lVCa7DRF+/9bVjM2wr iDgR3R00ajkdSNzDQdJpXxcq/WnHvAHMspdV7Cu6w6Z6ysrJSpOjG8zF9gapZh+7/1bg S7N7c136/ZrRf4Xtgbi+nPXD+6YJr2CZ+Cce1/TAyzMc60R9mB3Nv59+gz7AXVk94ZWt 53/IYMrtJ5hJ8MfKPZ7z/ZhoaIwrCnKS3lWkvUz8WFpvuufWEILVtctw70t/eoxLFzol hG3hwEpk3M6SIFgDJ87GJrCkB2ZVg8KuwCWNP+y718zerzJDUP1P91PaQbzP96ebVzoY PTzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZAuGglzaZUilwxmfKh+vB3j+5qRuKYKMV1iFQ03oySg=; b=ZXc8T63bDni4f6c+/qnm+s8vKh6ThIgOeHMfpACc/xuGrmQ8MO3Sw/ZVYsru1Pm4YR jA4IEyn8y2btR5E2yRWaJjz5BEUShb5VwGboImcrlFYQdQuAhDPVH9bplY+yGStSzD6S iIBlDHERbyuEzpLyvfFO1H9ktlxIAkwXnq9cekk1GxbBFJtufidOPyQlKfnS74hD8rBz CpfALcmV8Hh6p28pFbKIc8OJl3IOLjlbqi/5pjHiElSltI2O1cY7vJV6tO4xkZvAMPGD 8ugbGUE96z7QY9HM8XUPusdZYxLvzwXgwTJIGpm/iUmhPOdyP/V6Rt/JtG/N6XPUC1XS UY7g== X-Gm-Message-State: AOAM532FelZAJbonuQjpBzqcpUoLbjYKsTAlsTsCAJnXKQfuA7MjFCLF +mbyxcDHcLiehGysdVmJtWkyWcFgoYooLQ== X-Google-Smtp-Source: ABdhPJxWSmAXAukOFlyPPiMrn1UKacPWX0YrpPIz/Oc7rAqf79rADJkQBtWoKzOPV9hdfH5AU+ht7A== X-Received: by 2002:a17:902:ea0e:b029:e4:81d4:ddae with SMTP id s14-20020a170902ea0eb02900e481d4ddaemr1859233plg.12.1617777798266; Tue, 06 Apr 2021 23:43:18 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id c11sm20233683pgk.83.2021.04.06.23.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:17 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:15 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 18/49] staging: sm750fb: Rename function params of sii164_init_chip Message-ID: <902ae58f025b3cce6004b83d8ee8fbc3f6ecee7a.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameter names of the function sii164_init_chip. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h index cf17b9029496..ceafac60340f 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.h +++ b/drivers/staging/sm750fb/ddk750_sii164.h @@ -16,16 +16,16 @@ enum sii164_hot_plug_mode { }; /* Silicon Image SiI164 chip prototype */ -long sii164_init_chip(unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue); +long sii164_init_chip(unsigned char edge_select, + unsigned char bus_select, + unsigned char dual_edge_clk_select, + unsigned char hsync_enable, + unsigned char vsync_enable, + unsigned char deskew_enable, + unsigned char deskew_setting, + unsigned char continuous_sync_enable, + unsigned char pll_filter_enable, + unsigned char pll_filter_value); unsigned short sii164_get_vendor_id(void); unsigned short sii164_get_device_id(void); From patchwork Wed Apr 7 06:43:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E529C433B4 for ; Wed, 7 Apr 2021 06:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62EC061222 for ; Wed, 7 Apr 2021 06:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349015AbhDGGnn (ORCPT ); Wed, 7 Apr 2021 02:43:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGnn (ORCPT ); Wed, 7 Apr 2021 02:43:43 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55FDEC06174A; Tue, 6 Apr 2021 23:43:34 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id k23-20020a17090a5917b02901043e35ad4aso728939pji.3; Tue, 06 Apr 2021 23:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bvyOIchcblyTZxnk7QAJ5m+10+TOrC3FpEbk+84z4mA=; b=L2LHFPXPOiW6v3ukim6PWI9ekG/YDRwkjW5YT01lM9eZ9nS/i+qJnVnT8ZVAyRalD5 dKnt45ZAZR5MioQkIpRouxs1KonXRR1Z+hfsguv3UJONa5oBBBqL+gVj0jZw4w/8DyNJ 25IBbZqpKGYMHJc4OZTv8QwTsli8d1gFdQ9oItH5/ejvzsH8B1kWbzecw/VCVD15flQS 0ltX1D46/DWkQFSv9HiC2ZU0gTss1F/Sik51jCaN4gwoqAC01DYFwSLCbLewi12/gQU5 8T7dSIFDckdzWIshwiNcZrQ6gPymfFiEHfnI7k2PeQuvNGF2trbL0tfKnE4Pb9e1atoV oWjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bvyOIchcblyTZxnk7QAJ5m+10+TOrC3FpEbk+84z4mA=; b=FW/oOBYAwLpVr1oOHEC03DlGjIVuaryhXcs1frOaGU6ETMPlIglH5K4RLjJhSx1rat tRgnQEbUrlCUaiz03poBK7bxnp3CBPRiKTM4sGDJCihQpiBF6SIhLECYc7BGUYAigufS KIalVOD9FNSSVWjDpLslKGFICRLdP7pN4u7/KIzZHZDyIbtB6QGRwp4fld+N2CsCOaW2 i9aiIcjCx8wRN1ukbHWsMx5vxRshscFZyzBokyYmLmBnyEedSmlnub/ptvNECPYlsgxY oMGtuN3ghiJ0SgZ2lvevDEaLeUkntlQljTRO/IfweHR6cWPVom98A/aSY4bTNMGF+7uz jQtg== X-Gm-Message-State: AOAM533OKGelxqjPqKBS6PHo4X5Asv9SLM1Sg30X4eNngEfplkgSzFXS NGajPiGkDUwTH8jeJATDaaw= X-Google-Smtp-Source: ABdhPJy4Ln4m3cV2fjHszjqG0UJvfKjad9FvZloqq8wON2TZdz9ZWHsKfeBcQ/qPq0j5Rz86wUFH1w== X-Received: by 2002:a17:902:ee93:b029:e9:6b29:3219 with SMTP id a19-20020a170902ee93b02900e96b293219mr695699pld.16.1617777813875; Tue, 06 Apr 2021 23:43:33 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id e190sm20147991pfe.3.2021.04.06.23.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:33 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:31 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 19/49] staging: sm750fb: Rename function parameter of sii164_enable_hot_plug_detection Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function parameter enable_hot_plug in the prototype of the function sii164_enable_hot_plug_detection. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h index ceafac60340f..ac1431dcb419 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.h +++ b/drivers/staging/sm750fb/ddk750_sii164.h @@ -34,7 +34,7 @@ unsigned short sii164_get_device_id(void); void sii164_reset_chip(void); char *sii164_get_chip_string(void); void sii164_set_power(unsigned char powerUp); -void sii164_enable_hot_plug_detection(unsigned char enableHotPlug); +void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug); unsigned char sii164_is_connected(void); unsigned char sii164_check_interrupt(void); void sii164_clear_interrupt(void); From patchwork Wed Apr 7 06:43:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043E3C433B4 for ; Wed, 7 Apr 2021 06:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D409F61222 for ; Wed, 7 Apr 2021 06:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349032AbhDGGns (ORCPT ); Wed, 7 Apr 2021 02:43:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349025AbhDGGnr (ORCPT ); Wed, 7 Apr 2021 02:43:47 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41B54C061756; Tue, 6 Apr 2021 23:43:37 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id e10so4469756pls.6; Tue, 06 Apr 2021 23:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LtPY28YFe+3bqh2kGpqagJA+l0TwkVBMvsxawK4Hef0=; b=CYnRpPpGvYCCmiTofhHDTtc96f7jsJ2CxAMhz8TFl3QqnZjSOzhUZC0k3LQO8ht9r4 luCn6B+r6yV7wwp0bNBKeC4nb8Igj/eg8PoOWCPMXw4Ah6WUaOKNShg6JIW6ToaIQK/y qJSS0BMNv9FqDxNOvej/O2tBF5QRXk/OnV6xlO+tIY0WxBgJaslIW1t209bLdQyZY4ch Ck0kk2fF+8+tfYdTl2GkQLSmNQAgFUe0v1t4kOZ/vTI6hebiS0baQm5wmCV5yM2akAg5 DOkZ8WOpOKiC2XrByDRA2DnTJZvtXbZpdze1XpkeAJn+bId+YRIFY3uCdfhzlABraAAA 03OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LtPY28YFe+3bqh2kGpqagJA+l0TwkVBMvsxawK4Hef0=; b=bYutUC0rrynx9famI9eTtzCTbUMsk9gXw38ezhkP3PJ5+/0EiKGyNrnN5udRr80OSX UkEYw6v4+uh9fWl/IZv9J88/z+E97ij2GauHUA+vy0K0lG2pEb1JbQa2+igqUNUfd16L zFzs4Kse5PqXWLYcHlIy0f7UMR7mtY7Sr4BdTFcfpiionXxtXXCD7IsRWuBP2eEqHCOP q19GXsuJpDxXGroIVxa+m9mjb7qynN71nD7Ei+Gb6ArGgy3C/DHlot36XfRI9ds+sMaA ilP2vwiR/dEZ+Hjn2TftgejJu3gcBSiR9N4rXL7TFrZdHIMNvaJcDE9iLhuhEIFrmKKp ADmA== X-Gm-Message-State: AOAM533Xh91JFSB9Er1BiSfHzTkHdQpb6g8uPHylYZzY+KW1I3h68bAA 2qM4pWWkkyW1e3WDcsdU5+Y= X-Google-Smtp-Source: ABdhPJyJst779Wu8OU+DmxWuTuWR0FKUG1klbj6rtJXqj3A6FP+2PcRa/8zFJZ7CZbAcefqVItM0gQ== X-Received: by 2002:a17:90a:6c45:: with SMTP id x63mr1834472pjj.138.1617777816772; Tue, 06 Apr 2021 23:43:36 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id f16sm18655210pfj.220.2021.04.06.23.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:36 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:34 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 20/49] staging: sm750fb: Update function parameter names to snake case Message-ID: <80a0c8c1d020da11e458d197d155a6296c090ad5.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameter names in sm750_accel.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 92 +++++++++++++-------------- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 8faa601c700b..4327bda871e1 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -18,9 +18,9 @@ #include "sm750.h" #include "sm750_accel.h" -static inline void write_dpr(struct lynx_accel *accel, int offset, u32 regValue) +static inline void write_dpr(struct lynx_accel *accel, int offset, u32 reg_value) { - writel(regValue, accel->dprBase + offset); + writel(reg_value, accel->dprBase + offset); } static inline u32 read_dpr(struct lynx_accel *accel, int offset) @@ -86,7 +86,7 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt) } int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bpp, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { @@ -103,14 +103,14 @@ int sm750_hw_fillrect(struct lynx_accel *accel, write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ write_dpr(accel, DE_PITCH, - ((pitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((pitch / bpp << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (pitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (pitch / bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ write_dpr(accel, DE_WINDOW_WIDTH, - ((pitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((pitch / bpp << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ + (pitch / bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr44 */ write_dpr(accel, DE_FOREGROUND, color); /* DPR14 */ @@ -132,13 +132,13 @@ int sm750_hw_fillrect(struct lynx_accel *accel, /** * sm750_hm_copyarea - * @sBase: Address of source: offset in frame buffer - * @sPitch: Pitch value of source surface in BYTE + * @s_base: Address of source: offset in frame buffer + * @s_pitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -146,10 +146,10 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @rop2: ROP value */ int sm750_hw_copyarea(struct lynx_accel *accel, - unsigned int sBase, unsigned int sPitch, + unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, - unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int d_base, unsigned int d_pitch, + unsigned int bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2) { @@ -160,7 +160,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, de_ctrl = 0; /* If source and destination are the same surface, need to check for overlay cases */ - if (sBase == dBase && sPitch == dPitch) { + if (s_base == d_base && s_pitch == d_pitch) { /* Determine direction of operation */ if (sy < dy) { /* +----------+ @@ -234,14 +234,14 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * It is an address offset (128 bit aligned) * from the beginning of frame buffer. */ - write_dpr(accel, DE_WINDOW_SOURCE_BASE, sBase); /* dpr40 */ + write_dpr(accel, DE_WINDOW_SOURCE_BASE, s_base); /* dpr40 */ /* * 2D Destination Base. * It is an address offset (128 bit aligned) * from the beginning of frame buffer. */ - write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); /* dpr44 */ + write_dpr(accel, DE_WINDOW_DESTINATION_BASE, d_base); /* dpr44 */ /* * Program pitch (distance between the 1st points of two adjacent lines). @@ -249,9 +249,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) & + ((d_pitch / bpp << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (s_pitch / bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -259,9 +259,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) & + ((d_pitch / bpp << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ + (s_pitch / bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ if (accel->de_wait() != 0) return -1; @@ -298,26 +298,26 @@ static unsigned int deGetTransparency(struct lynx_accel *accel) /** * sm750_hw_imageblit - * @pSrcbuf: pointer to start of source buffer in system memory - * @srcDelta: Pitch value (in bytes) of the source buffer, +ive means top down + * @src_buf: pointer to start of source buffer in system memory + * @src_delta: Pitch value (in bytes) of the source buffer, +ive means top down * and -ive mean button up - * @startBit: Mono data can start at any bit in a byte, this value should be + * @start_bit: Mono data can start at any bit in a byte, this value should be * 0 to 7 - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @bytePerPixel: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @byte_per_pixel: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value * @height: height of rectangle in pixel value * @fColor: Foreground color (corresponding to a 1 in the monochrome data - * @bColor: Background color (corresponding to a 0 in the monochrome data + * @b_olor: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ -int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, - u32 srcDelta, u32 startBit, u32 dBase, u32 dPitch, - u32 bytePerPixel, u32 dx, u32 dy, u32 width, - u32 height, u32 fColor, u32 bColor, u32 rop2) +int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, + u32 src_delta, u32 start_bit, u32 d_base, u32 d_pitch, + u32 byte_per_pixel, u32 dx, u32 dy, u32 width, + u32 height, u32 fColor, u32 b_olor, u32 rop2) { unsigned int ulBytesPerScan; unsigned int ul4BytesPerScan; @@ -326,8 +326,8 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, unsigned char ajRemain[4]; int i, j; - startBit &= 7; /* Just make sure the start bit is within legal range */ - ulBytesPerScan = (width + startBit + 7) / 8; + start_bit &= 7; /* Just make sure the start bit is within legal range */ + ulBytesPerScan = (width + start_bit + 7) / 8; ul4BytesPerScan = ulBytesPerScan & ~3; ulBytesRemain = ulBytesPerScan & 3; @@ -344,7 +344,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, * It is an address offset (128 bit aligned) * from the beginning of frame buffer. */ - write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); + write_dpr(accel, DE_WINDOW_DESTINATION_BASE, d_base); /* * Program pitch (distance between the 1st points of two adjacent @@ -352,9 +352,9 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, * register uses pixel values. Need Byte to pixel conversion. */ write_dpr(accel, DE_PITCH, - ((dPitch / bytePerPixel << DE_PITCH_DESTINATION_SHIFT) & + ((d_pitch / byte_per_pixel << DE_PITCH_DESTINATION_SHIFT) & DE_PITCH_DESTINATION_MASK) | - (dPitch / bytePerPixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ + (d_pitch / byte_per_pixel & DE_PITCH_SOURCE_MASK)); /* dpr10 */ /* * Screen Window width in Pixels. @@ -362,17 +362,17 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, * in frame buffer for a given point. */ write_dpr(accel, DE_WINDOW_WIDTH, - ((dPitch / bytePerPixel << DE_WINDOW_WIDTH_DST_SHIFT) & + ((d_pitch / byte_per_pixel << DE_WINDOW_WIDTH_DST_SHIFT) & DE_WINDOW_WIDTH_DST_MASK) | - (dPitch / bytePerPixel & DE_WINDOW_WIDTH_SRC_MASK)); + (d_pitch / byte_per_pixel & DE_WINDOW_WIDTH_SRC_MASK)); /* * Note: For 2D Source in Host Write, only X_K1_MONO field is needed, * and Y_K2 field is not used. - * For mono bitmap, use startBit for X_K1. + * For mono bitmap, use start_bit for X_K1. */ write_dpr(accel, DE_SOURCE, - (startBit << DE_SOURCE_X_K1_SHIFT) & + (start_bit << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MONO_MASK); /* dpr00 */ write_dpr(accel, DE_DESTINATION, @@ -384,7 +384,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ write_dpr(accel, DE_FOREGROUND, fColor); - write_dpr(accel, DE_BACKGROUND, bColor); + write_dpr(accel, DE_BACKGROUND, b_olor); de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE | @@ -396,15 +396,15 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, for (i = 0; i < height; i++) { /* For each line, send the data in chunks of 4 bytes */ for (j = 0; j < (ul4BytesPerScan / 4); j++) - write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4))); + write_dpPort(accel, *(unsigned int *)(src_buf + (j * 4))); if (ulBytesRemain) { - memcpy(ajRemain, pSrcbuf + ul4BytesPerScan, + memcpy(ajRemain, src_buf + ul4BytesPerScan, ulBytesRemain); write_dpPort(accel, *(unsigned int *)ajRemain); } - pSrcbuf += srcDelta; + src_buf += src_delta; } return 0; From patchwork Wed Apr 7 06:43:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45243C433ED for ; Wed, 7 Apr 2021 06:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DF14613C0 for ; Wed, 7 Apr 2021 06:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349026AbhDGGnr (ORCPT ); Wed, 7 Apr 2021 02:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGnr (ORCPT ); Wed, 7 Apr 2021 02:43:47 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43429C06174A; Tue, 6 Apr 2021 23:43:38 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id s11so12191336pfm.1; Tue, 06 Apr 2021 23:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qFLPg7mZDXW2+QgSTwSk0nVCNAL/L9QDEUI+JqqFX3k=; b=mT/mUn7WmUIME4GnBmCZDyfX4zs6Bm6ohDT27mTk5sndsJ7EnOZQ7klKCB/g909puv uyusQntZbxLgSrr/+dFpa8tAX6RBUqMCciTeiWL9Qw165iKf5o31jJTdvwfiAlcRVWQ3 OHEchdISJQ52hUxRg4KgfaFBe0K3MoLdd4EkkNHZVnEYYVab6kQ5EeGxc1iRt+UScqNF tSubDVgI7VeWKzKXFEQO+HOLhsWo01lrNoal28Cd/ayNyNq6RMIxb6+jJmJ24XFwmCBa zbp3avkBtTjbigntRHWsp/RjggErHM4bg83IMROKbnlrqJbgVPn4m0O/U9UQbI4ydauH 0mEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qFLPg7mZDXW2+QgSTwSk0nVCNAL/L9QDEUI+JqqFX3k=; b=iODILrgpp/QGc+n28w7my7qN6fwDOddnQZZ5zCk0PPPHakq0ypy8DNtrxBJc5LGbDP ABFPzxJRQyV+2ttWd3Sv6yUqCT0hHgZdL63xn3F7pLu1p8uShEtgh0Atn3wDMGGX6NIc GhhJ0rdnPoDWRX09rhms3K8M5h/FZS5LmacSM8yCuAy57VhbdlUDnxOLKpKMfzy2ze/5 5L4KoeAa8ia4YCVLyj1stn1GeLkXChKOxuwPUZ9Rh4VCabcdQeWPC8JGLFPbN2cXRIeZ sjbBp2GJ26S169JhOZk/4qPsFuzjMjcIX2L5hDBtvPWenQaZwzOnnz3c3WyYHW3wwrpZ i5yQ== X-Gm-Message-State: AOAM530CnO5vnL/JQQDnPviph/dOvq5O4fcfgC6opSy6nT1ST6suVanH FIukL0dqPTDsXekn7D/K83s= X-Google-Smtp-Source: ABdhPJwOqNX467U2gyXYnZ7HmnsGJu0HLQzRCxRCYJua+3faT0g0IMb6lROPCAKfblaoO8iLfgb1Rw== X-Received: by 2002:a63:dc57:: with SMTP id f23mr774017pgj.294.1617777817858; Tue, 06 Apr 2021 23:43:37 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id gk20sm3035930pjb.17.2021.04.06.23.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:37 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:35 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 21/49] staging: sm750fb: Rename function write_dpPort to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for the function write_dpPort. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4327bda871e1..4ad2814b5b54 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -28,7 +28,7 @@ static inline u32 read_dpr(struct lynx_accel *accel, int offset) return readl(accel->dprBase + offset); } -static inline void write_dpPort(struct lynx_accel *accel, u32 data) +static inline void write_dp_port(struct lynx_accel *accel, u32 data) { writel(data, accel->dpPortBase); } @@ -396,12 +396,12 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, for (i = 0; i < height; i++) { /* For each line, send the data in chunks of 4 bytes */ for (j = 0; j < (ul4BytesPerScan / 4); j++) - write_dpPort(accel, *(unsigned int *)(src_buf + (j * 4))); + write_dp_port(accel, *(unsigned int *)(src_buf + (j * 4))); if (ulBytesRemain) { memcpy(ajRemain, src_buf + ul4BytesPerScan, ulBytesRemain); - write_dpPort(accel, *(unsigned int *)ajRemain); + write_dp_port(accel, *(unsigned int *)ajRemain); } src_buf += src_delta; From patchwork Wed Apr 7 06:43:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41052C43460 for ; Wed, 7 Apr 2021 06:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FEBF61222 for ; Wed, 7 Apr 2021 06:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349035AbhDGGnt (ORCPT ); Wed, 7 Apr 2021 02:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349029AbhDGGns (ORCPT ); Wed, 7 Apr 2021 02:43:48 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65EC3C06174A; Tue, 6 Apr 2021 23:43:39 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id ay2so8840603plb.3; Tue, 06 Apr 2021 23:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=juPdFsys4r3Aaic/tVEakxA+SlqXVvRJQMcNPtT88ko=; b=V3Jd8on2MAtBF/RvEHZ1tA0fxsIBKGL9HyHv8m7MS02I+BhhMaFAxvfwKrxBtdmgIa ZsvnIg9VaPf5aQw5/FhyhPtpNNezI9I3/ThfdWf1zEZR9/dAyrl9yIgtsRPYFey6OqMi qNdSDWkx/74o0qT5iirVrEh4HwyXNShC+jPlWitcli4StnQCtIHI2ysMQCAQs7K6k1er D6dccbtfNj0/+sPSFech95aVrHX7qDadNgR8dQiQo2vYZ7woqy6ZIt+nPa1TyfbMYxv7 WEMxEyhCUQAo5KbGGsbd7pMB4OC5ZNijgLZQz1Jz1eEupTBufLJkXPS9BjKuav0Vxt03 ts+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=juPdFsys4r3Aaic/tVEakxA+SlqXVvRJQMcNPtT88ko=; b=cotmmx2ZlRPvo9QIlDxFiDrWdvB3UTyPrm5bhp9Z/qda6Hj4lhs8v9IoGed/Bwv6OJ WeHKMjNr1LCao/gtH92XbZjSfuCxK2Halwb6jKDPlH5K4hMVNM6Punn1qk+5yaQ9gJX/ T0u8X++emVHvig8AX0utE3O/a4KsoSVeQIxVH+wVem7VQt8PfaUurkUB1IV26eDk1w+Z T5yNvczGFnN5SClRM6o4F09MV1TAXTWnJXw5z7O2ooiM+6oXpZvKbDLCbgd66OoyJG8l w2wwuP+t35kzlPg+vV6ZhlTLootAughYex2ZXGDn2JNo554YmC1XnnlKiMIvFvSaf3Ed WsdQ== X-Gm-Message-State: AOAM533dPiKprT46VOnJHLWNbIoIeSQ32WE+RppXwd8SahPJr/l6SKXd mEbxf7jgC1/qX7kn2YuXOhQ= X-Google-Smtp-Source: ABdhPJzooZZLcFRKF8gWsCfqXUMmjqpDRxFfh8K5S0UQaX5Xv3UXDYqGmunEpRFbquOtNCtZ80nsCA== X-Received: by 2002:a17:902:122:b029:e8:bde2:7f6c with SMTP id 31-20020a1709020122b02900e8bde27f6cmr1686322plb.29.1617777818946; Tue, 06 Apr 2021 23:43:38 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id 14sm19981411pfl.1.2021.04.06.23.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:38 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:36 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 22/49] staging: sm750fb: Update local variable in sm750_hw_copyarea to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the local variable nDirection in the function sm750_hw_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4ad2814b5b54..760dd036d71a 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int nDirection, de_ctrl; + unsigned int n_direction, de_ctrl; - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ de_ctrl = 0; @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = BOTTOM_TO_TOP; + n_direction = BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = TOP_TO_BOTTOM; + n_direction = TOP_TO_BOTTOM; } else { /* sy == dy */ @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = RIGHT_TO_LEFT; + n_direction = RIGHT_TO_LEFT; } else { /* sx > dx */ @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; } } } - if ((nDirection == BOTTOM_TO_TOP) || (nDirection == RIGHT_TO_LEFT)) { + if ((n_direction == BOTTOM_TO_TOP) || (n_direction == RIGHT_TO_LEFT)) { sx += width - 1; sy += height - 1; dx += width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((n_direction == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */ From patchwork Wed Apr 7 06:43:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A801C43470 for ; Wed, 7 Apr 2021 06:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32CCC613C0 for ; Wed, 7 Apr 2021 06:43:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349047AbhDGGnv (ORCPT ); Wed, 7 Apr 2021 02:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349042AbhDGGnu (ORCPT ); Wed, 7 Apr 2021 02:43:50 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB61C06174A; Tue, 6 Apr 2021 23:43:40 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id x21-20020a17090a5315b029012c4a622e4aso773413pjh.2; Tue, 06 Apr 2021 23:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sykweF1xow+67RG88cYdeLCD9JLGGBr6+VUxqXfVo3c=; b=tMCGc6exiWT5/SzYX95SEtNEdMhsPtWabVZ7qpaIQtCMQr0dLxD+cl0mp09sOgtIiI Ce+Hbm33MTfaJAWNV3q8V2n2GjOjww0lkrj5EeXUwHimuzbFmhiMaTXwQh9RFZYt0X2m +BVu2C+sqHI/QygpybP359dH28as4BQ4P3zvHxwldYit7tZKFBk4UEH++ClZzfbJZZFl 7UzdMUioFXLYDD/O+qSVnY1OW93UCI8nFo79d43UpH1X4AkKp4K0qznpe18ugdDKGUfc FPHIGN0+UI8fyu3r8gI5wtRhZ6TEqUj6Zb2A2CDUSOm+1BG4IEKz/s09ZiQQitcfZ1av 7Y8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sykweF1xow+67RG88cYdeLCD9JLGGBr6+VUxqXfVo3c=; b=BQoc8po91WE8sjfygXlac07JBNNr4VdCp8Jikv0FRheLsUBLCycZdxKY/N9HEvcYs0 qS2Eix/XT09JJJSm277lz2CqQUtav4dQh3Pr6ggPDPMqwKCb1wtU4mJcjkEtqDsbMFty zK+osOaf6s7T0m3A8FLxQtlLoSMaxwTfkrNgTuqsEMFj6mrofUD3wnvEWiqPRja424xJ ULlAmquhfCZwKZ4j7thfVJxhUAd8T/WHO+v1vw1q31YbHlrHCxvCtU/MuAATSMFg4VCF PuTHH4/ZE5DB+yt8mlZnBojanJa8tp1SVJtr1v7ehvz+4GmXZ+ofkNZWh3rlP1kRi+iy EsPA== X-Gm-Message-State: AOAM5309T8t7bzuKomqZrTCvIOPamWDbH44mzxPPGc5gTLlZPUkzk/Av WaBOPW0EamsFeZjRPP0/qViYlOwHCQFkTA== X-Google-Smtp-Source: ABdhPJxBKfSQkEa2QkysRsUeMg9hiBbRFrLc9DHXYZggn8Gl9H0/Yjp+K7ab73tqIK60RcdNyb71mg== X-Received: by 2002:a17:90b:f93:: with SMTP id ft19mr1811479pjb.135.1617777820160; Tue, 06 Apr 2021 23:43:40 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id e6sm13641235pgm.92.2021.04.06.23.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:39 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:37 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 23/49] staging: sm750fb: Update local variables in sm750_hw_imageblit to snake case Message-ID: <8785050f4c2d4b9568689fec897aec03ca01da35.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the local variables in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 760dd036d71a..c840873e9622 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -319,17 +319,17 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, u32 byte_per_pixel, u32 dx, u32 dy, u32 width, u32 height, u32 fColor, u32 b_olor, u32 rop2) { - unsigned int ulBytesPerScan; - unsigned int ul4BytesPerScan; - unsigned int ulBytesRemain; + unsigned int ul_bytes_per_scan; + unsigned int ul4_bytes_per_scan; + unsigned int ul_bytes_remain; unsigned int de_ctrl = 0; - unsigned char ajRemain[4]; + unsigned char aj_remain[4]; int i, j; start_bit &= 7; /* Just make sure the start bit is within legal range */ - ulBytesPerScan = (width + start_bit + 7) / 8; - ul4BytesPerScan = ulBytesPerScan & ~3; - ulBytesRemain = ulBytesPerScan & 3; + ul_bytes_per_scan = (width + start_bit + 7) / 8; + ul4_bytes_per_scan = ul_bytes_per_scan & ~3; + ul_bytes_remain = ul_bytes_per_scan & 3; if (accel->de_wait() != 0) return -1; @@ -395,13 +395,13 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, /* Write MONO data (line by line) to 2D Engine data port */ for (i = 0; i < height; i++) { /* For each line, send the data in chunks of 4 bytes */ - for (j = 0; j < (ul4BytesPerScan / 4); j++) + for (j = 0; j < (ul4_bytes_per_scan / 4); j++) write_dp_port(accel, *(unsigned int *)(src_buf + (j * 4))); - if (ulBytesRemain) { - memcpy(ajRemain, src_buf + ul4BytesPerScan, - ulBytesRemain); - write_dp_port(accel, *(unsigned int *)ajRemain); + if (ul_bytes_remain) { + memcpy(aj_remain, src_buf + ul4_bytes_per_scan, + ul_bytes_remain); + write_dp_port(accel, *(unsigned int *)aj_remain); } src_buf += src_delta; From patchwork Wed Apr 7 06:43:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5650C433ED for ; Wed, 7 Apr 2021 06:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82AF7613CD for ; Wed, 7 Apr 2021 06:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349039AbhDGGnu (ORCPT ); Wed, 7 Apr 2021 02:43:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhDGGnu (ORCPT ); Wed, 7 Apr 2021 02:43:50 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28011C061756; Tue, 6 Apr 2021 23:43:41 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id m11so9552116pfc.11; Tue, 06 Apr 2021 23:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7SRBX2zWlmG+Wnp7OjpNFHLRL6YKU9gaSLUgjStjeSA=; b=AMYUtoZ2wZYY0gE9hzXqShCPRugVZ8z0VUJuJH69xXJaXI/FZ+5yIsOAHHhp/Xa8EG nG060gKFAckyldI9nEBSQFRlUT5CBU5SN/CdLeGI3klVLm++zuw+TWeFGFhcsC4+J2Tr YT6c2ZKmlY8a3+ecoahFAL7uMsLzRMzRR01xwgPZhBbBmxe56yV8/VeRhVyaLqGT7lDN 7dVox0XD/bmyyw1HFVvKsHHtMj11E4isqMso+4SBhUk2EItcxuSE0vnAEObsO8BNXkEO wnG4SUBiLS1blPlV21YE0eSx40atF61ipiDIbZ5sqVgOW+UnA6x9Z1T2uG8dTOAw+OFR yCug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7SRBX2zWlmG+Wnp7OjpNFHLRL6YKU9gaSLUgjStjeSA=; b=DtA2BNvFgYPbhwI96NDCa6Ixai64+iVKfMzLRzGZQVduGDDGdKfW5naiSoTLzyaQip DHUn1L6aX+hRnFChzHSnuDYGOyA1QnbGHjuf9HNco9LgVnmS0M+hLeYsOzjiNmry18Xu qYsRsPXG5Xy9EXecqbZkD4XD8pnAoyzKdZINAI/JCnsFtRF5eJ+nSwXvy0huBQTsJpMr T2xjG2Gsacx3M7LcXF0UKPzBp2wPahdhh3bXA0EtGU4T7nPMSV4UgKmtBfLRkRGpFqOg 83gbYLc/6lPmuI3GFAdNHoSP8yPJwSAM0UufYiB+54wSXXIvuNs6gF4RZpKUCmr18/a0 g/WA== X-Gm-Message-State: AOAM532IxVx0Z4fSDDJZ8uGU76MnOv8QgYb6T/rhzDCpBFO5gCxhrc04 1UNsHjBSmIGq9z1HYRBaKRU= X-Google-Smtp-Source: ABdhPJwqQmSR9ejO+2SH7wVFCu55gOSjGn+5iNaoES3fzICyJ7d5/kNX9xjU90SUtbPAmh/KqTV17g== X-Received: by 2002:a63:dd14:: with SMTP id t20mr1912847pgg.258.1617777820715; Tue, 06 Apr 2021 23:43:40 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id x2sm20604956pgb.89.2021.04.06.23.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:40 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:38 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 24/49] staging: sm750fb: Update local variable in sm750_hw_fillrect to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the local variable deCtrl in the function sm750_hw_fillrect. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index c840873e9622..1eeedacfc4a8 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -90,7 +90,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop) { - u32 deCtrl; + u32 de_ctrl; if (accel->de_wait() != 0) { /* @@ -122,11 +122,11 @@ int sm750_hw_fillrect(struct lynx_accel *accel, ((width << DE_DIMENSION_X_SHIFT) & DE_DIMENSION_X_MASK) | (height & DE_DIMENSION_Y_ET_MASK)); /* dpr8 */ - deCtrl = DE_CONTROL_STATUS | DE_CONTROL_LAST_PIXEL | + de_ctrl = DE_CONTROL_STATUS | DE_CONTROL_LAST_PIXEL | DE_CONTROL_COMMAND_RECTANGLE_FILL | DE_CONTROL_ROP_SELECT | (rop & DE_CONTROL_ROP_MASK); /* dpr0xc */ - write_dpr(accel, DE_CONTROL, deCtrl); + write_dpr(accel, DE_CONTROL, de_ctrl); return 0; } From patchwork Wed Apr 7 06:43:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A08CC433ED for ; Wed, 7 Apr 2021 06:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0236613B3 for ; Wed, 7 Apr 2021 06:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349059AbhDGGnx (ORCPT ); Wed, 7 Apr 2021 02:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349049AbhDGGnv (ORCPT ); Wed, 7 Apr 2021 02:43:51 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72FBCC061756; Tue, 6 Apr 2021 23:43:42 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so756899pjb.0; Tue, 06 Apr 2021 23:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iNQgMFGdHCJQybttnc8ZktUg+AuixFV373VKxt8OipQ=; b=bL4tLK6rPdC9+pMpm+HgZ5dgrI/LpotabRYSpDBBWA/GPfObATMmj0oDciLDLRPShY sXA5qGSY6JqDDlUxFrNOS5K6DaOhD9FNkeKi1J0yNR0qgBn+MEQaHHyUVXB1iUSuRRSX hLE9ZBm3U95hSbeespJke+/a1o7eI0a4QBzAZxjEerBV8nRf0XLzTI2RRWQMKKw4tTFo 3L0fO/i9Q/XwMLOVNY7XZkEzBF9+fiP0M0nZE0wjpRz/N+p2CpVmROeA2QMHqWcVK5Zu ZmkodlE1i0ppSsaj6gZiuVrTH1z74+GTKxLid36gFbjvz/4cZubHTHBH/bxkSkOQkTr6 QoCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iNQgMFGdHCJQybttnc8ZktUg+AuixFV373VKxt8OipQ=; b=UbXELtrmcTpDraBDuV2Iz/1/WtRX0cze6YktqAi9t+UitRE3gRkDG3tr9uegCUlRYx BPcIbe1awY5pqUpzAKq5SdFq5wYPbRTxviVir3htKCskRP9s1hpIE/4ILI39H3PhEp2Y rgFmdf1DsjTwZR4SP8yAgeYI3ONwchQulu/dzCCB+vFg/RMhXGDgJ2p31oZbbGrAMIHr mAVVdbhhmtr++TZgm6l+B+mpTQugps5Cz/o0y0p+HHRavIHl5uNyiBzhKp6kjkusoK8K q2q9Cul3ag/tAsDJ9DpHZ23/qAReV1PIvhPl80zRUuU3LnX1gtV5jLCsvq9duagYDaw0 rRiA== X-Gm-Message-State: AOAM531ppqzkOOa8Tht4Mhsr4q0XjHSWxCxqvsW/ix0B1MaKJIkCEMGA Lr5rneoqLqpTZ2YMzuYfHlc= X-Google-Smtp-Source: ABdhPJxBAsCxXKZcvwuM32JlND25qmOd8VBz/H1GWFe+6qjtmSIae702aXP3xKjzS3nHNJ6Koe5VCw== X-Received: by 2002:a17:90a:9281:: with SMTP id n1mr1867246pjo.146.1617777822010; Tue, 06 Apr 2021 23:43:42 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id j205sm3817856pfd.214.2021.04.06.23.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:41 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:39 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 25/49] staging: sm750fb: Rename deGetTransparency to snake case Message-ID: <1cdaddb4b127cf70c3ccac2496a29da1b761cfbf.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function deGetTransparency in sm750_accel.c. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 1eeedacfc4a8..8ab7d827a99e 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, return 0; } -static unsigned int deGetTransparency(struct lynx_accel *accel) +static unsigned int de_get_transparency(struct lynx_accel *accel) { unsigned int de_ctrl; @@ -390,7 +390,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE | DE_CONTROL_HOST | DE_CONTROL_STATUS; - write_dpr(accel, DE_CONTROL, de_ctrl | deGetTransparency(accel)); + write_dpr(accel, DE_CONTROL, de_ctrl | de_get_transparency(accel)); /* Write MONO data (line by line) to 2D Engine data port */ for (i = 0; i < height; i++) { From patchwork Wed Apr 7 06:43:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC751C43461 for ; Wed, 7 Apr 2021 06:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 975E661222 for ; Wed, 7 Apr 2021 06:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349061AbhDGGny (ORCPT ); Wed, 7 Apr 2021 02:43:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349054AbhDGGnw (ORCPT ); Wed, 7 Apr 2021 02:43:52 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64751C061761; Tue, 6 Apr 2021 23:43:43 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id z12so4769223plb.9; Tue, 06 Apr 2021 23:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KdD/0jSjXQu+pj5Tw8B9xW+iyGYs472db51etZPlQWM=; b=Cuij2ZAyqmlX8ep4uD8ie3JDJu9JmDDWeyfVqGuFYbxLxExVx13/kAMuXmArzRqbIq 1yNubc40iVWWJhhYDZd0R+4LTJyzP1DuAxZFjSts0glTiC/vEjQUk4Bj2VDxrg6K+xko rG+DwQVB9qYCLpJMvKgl360B9lxBTjX6hak4jFtOCGfet/wBVZg4vapOG01LVkv1uupB FKUOMHDjRNx5WRR9PShTZgfps5+xEYZfiyYpwNT6Qh08SYmjXGhZxQAnrgWtfmgut9bS b89YtfpOz5duji1P/HNN2zJ8xdNhQgx06f3TEClh492et9Yl3nf8lE4HFtatBkrT34Wd B75g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KdD/0jSjXQu+pj5Tw8B9xW+iyGYs472db51etZPlQWM=; b=izHmcrEy5EObfzfgF5cfxpAaaX2s9kbOVGsXg/5EsNMPUROHMxYBLEuE7Xa7iOykhX Hd5lJAC4Av1sbdozLBIERM31CsVgnhSu/vnqkIo6k1unn+bbPq3q52RvUoWEf1ZrmBz+ ekJXHZGvZ98xHMfR14bOcwTx4ULfgGQVKX+ld6nTS0DbCPAR0iAPTctuwBPaPhHEmRqD NDFadcqoTvN1rflamEXBbjYkrP5fkb1W1wBOAlty5iSniMtBxFM48vjP87uxI2JGpFmB C27y2PSH8DjSK+5Rocg4rvGBKpBcXKjJ8kmEZusUOIBeM2lowoqGxBdgB0yQkjfiRRzC l2gQ== X-Gm-Message-State: AOAM533D8rKp7kuvqxh+uGWxfJjWEjasl4qbFI6eG1c2s5gAE0/rEDVy tchmT4h8kkqKoyMPDRQ0A/rKEqJEdNZ6+A== X-Google-Smtp-Source: ABdhPJwFg0ykpCJkqAF7uxTunboyHBPPTna7uYRLdOsIFwRktA/JTtm8BuYFwjjpCHU1BZjwRltxAw== X-Received: by 2002:a17:90a:7b85:: with SMTP id z5mr1870880pjc.39.1617777823012; Tue, 06 Apr 2021 23:43:43 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id f2sm19378511pfe.177.2021.04.06.23.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:42 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:40 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 26/49] staging: sm750fb: Update function parameter of sm750_hw_imageblit to snake case Message-ID: <080958faf487654e336a2e8ce152bfd756128617.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpoint.pl checks for the function parameter fColor in the function sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 8ab7d827a99e..d0b64962b10e 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -310,14 +310,14 @@ static unsigned int de_get_transparency(struct lynx_accel *accel) * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value * @height: height of rectangle in pixel value - * @fColor: Foreground color (corresponding to a 1 in the monochrome data + * @f_color: Foreground color (corresponding to a 1 in the monochrome data * @b_olor: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, u32 src_delta, u32 start_bit, u32 d_base, u32 d_pitch, u32 byte_per_pixel, u32 dx, u32 dy, u32 width, - u32 height, u32 fColor, u32 b_olor, u32 rop2) + u32 height, u32 f_color, u32 b_olor, u32 rop2) { unsigned int ul_bytes_per_scan; unsigned int ul4_bytes_per_scan; @@ -383,7 +383,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, ((width << DE_DIMENSION_X_SHIFT) & DE_DIMENSION_X_MASK) | (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ - write_dpr(accel, DE_FOREGROUND, fColor); + write_dpr(accel, DE_FOREGROUND, f_color); write_dpr(accel, DE_BACKGROUND, b_olor); de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | From patchwork Wed Apr 7 06:43:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C28AC433ED for ; Wed, 7 Apr 2021 06:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 428FD613E3 for ; Wed, 7 Apr 2021 06:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349102AbhDGGoG (ORCPT ); Wed, 7 Apr 2021 02:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349052AbhDGGnz (ORCPT ); Wed, 7 Apr 2021 02:43:55 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4365CC061760; Tue, 6 Apr 2021 23:43:45 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id kk2-20020a17090b4a02b02900c777aa746fso773093pjb.3; Tue, 06 Apr 2021 23:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dcsh/9mtL1pzvY0j0UgWraj+0Jc1yK6/3oHw6URUNrU=; b=QBn6DuPcKpAFSiiPz8CHPbeQFR3uxDi67HLT6IP0ZaA4rRw70m9ZPedbLDDFsIIuJ/ XiBoVwZ1QnE9iLuCtyrqF26ViSuGt9klvyHhyTycWCGv37D7S9uhBRBnCNCEzAZdtwaI 0EIErsmQgoHHQmJ7d3n0VmRqLBqfZdnX1Qrv7TVN8YrdXo6UY3hzGdNA+2iVaKHSXz1b xio2CDrw9fjyQd2GOlO+9vsRGtkHhqJeA6GE4EtqWdWRvIZpzF9a+bcETyPN4UbguFwJ UaciV/dtjMNWSEc5L3MXvRp9gYen8ezLQxsPW0GnO3zzqUn0MVRKPB9NYg/8t5VAhdG4 iCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dcsh/9mtL1pzvY0j0UgWraj+0Jc1yK6/3oHw6URUNrU=; b=ZdHA/+9uwZ46aqAO3tA9GLRrZr9waGsH6bZpXgBpDTFpYa7bL5yvK/oKeU3KSYCXmv 2ynZIohQrFN0fAPpgC7KsTzFm4vIUOv34ppjBMOJ3PeDHN41SBqtONjnS+v8OYiu/b+s BTumaH7jH6BaOyL0xXVHuCKN+FWM3dC0Dg+HI9OU/C463g4aDoiN3Zv00CqwlmAtG9Re o4BaIy7Ekce6taO0L5b+vmkrymia3pfbZsD/63TEMViG8cn4lPTqjENuX8Ajg+OxS/1J 9Uj2i/vT/IeF7MH2fM38Ry1dfYkDeGE5fTCCu0r/SYsXwfilwI6GOMvNpc8MRHv3PxcY +7kw== X-Gm-Message-State: AOAM531P+W+Ziu/xyfM3GMbMfaBf1r2bcF740XOCqt/ToJHbw3onEwFJ ptdgSHd/1VQq5bPbjEr8CrI= X-Google-Smtp-Source: ABdhPJz4kTyvwNyBJpVANobnxmZ7JplrEIqkyXbpSP1VqONXNpWK96Lr+/aYnoaHKh4cQBHK1hcQUQ== X-Received: by 2002:a17:90a:3be4:: with SMTP id e91mr1808156pjc.113.1617777824783; Tue, 06 Apr 2021 23:43:44 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id z23sm20509608pgn.88.2021.04.06.23.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:44 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:42 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 27/49] staging: sm750fb: Rename function params to snake case in sm750_accel.h Message-ID: <5460f1029f91f3a7f0ca98fa787eb9caa57eb83b.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for function parameters in sm750_accel.h, in particular for functions sm750_hw_fillrect, sm750_hw_copyarea and sm750_hw_imageblit. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_accel.h | 42 +++++++++++++-------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h index 2c79cb730a0a..8a5d1fe5075a 100644 --- a/drivers/staging/sm750fb/sm750_accel.h +++ b/drivers/staging/sm750fb/sm750_accel.h @@ -190,19 +190,19 @@ void sm750_hw_set2dformat(struct lynx_accel *accel, int fmt); void sm750_hw_de_init(struct lynx_accel *accel); int sm750_hw_fillrect(struct lynx_accel *accel, - u32 base, u32 pitch, u32 Bpp, + u32 base, u32 pitch, u32 bpp, u32 x, u32 y, u32 width, u32 height, u32 color, u32 rop); /** * sm750_hm_copyarea - * @sBase: Address of source: offset in frame buffer - * @sPitch: Pitch value of source surface in BYTE + * @s_base: Address of source: offset in frame buffer + * @s_pitch: Pitch value of source surface in BYTE * @sx: Starting x coordinate of source surface * @sy: Starting y coordinate of source surface - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @Bpp: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @bpp: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value @@ -210,34 +210,34 @@ int sm750_hw_fillrect(struct lynx_accel *accel, * @rop2: ROP value */ int sm750_hw_copyarea(struct lynx_accel *accel, - unsigned int sBase, unsigned int sPitch, + unsigned int s_base, unsigned int s_pitch, unsigned int sx, unsigned int sy, - unsigned int dBase, unsigned int dPitch, - unsigned int Bpp, unsigned int dx, unsigned int dy, + unsigned int d_base, unsigned int d_pitch, + unsigned int bpp, unsigned int dx, unsigned int dy, unsigned int width, unsigned int height, unsigned int rop2); /** * sm750_hw_imageblit - * @pSrcbuf: pointer to start of source buffer in system memory - * @srcDelta: Pitch value (in bytes) of the source buffer, +ive means top down + * @src_buf: pointer to start of source buffer in system memory + * @src_delta: Pitch value (in bytes) of the source buffer, +ive means top down *>----- and -ive mean button up - * @startBit: Mono data can start at any bit in a byte, this value should be + * @start_bit: Mono data can start at any bit in a byte, this value should be *>----- 0 to 7 - * @dBase: Address of destination: offset in frame buffer - * @dPitch: Pitch value of destination surface in BYTE - * @bytePerPixel: Color depth of destination surface + * @d_base: Address of destination: offset in frame buffer + * @d_pitch: Pitch value of destination surface in BYTE + * @byte_per_pixel: Color depth of destination surface * @dx: Starting x coordinate of destination surface * @dy: Starting y coordinate of destination surface * @width: width of rectangle in pixel value * @height: height of rectangle in pixel value - * @fColor: Foreground color (corresponding to a 1 in the monochrome data - * @bColor: Background color (corresponding to a 0 in the monochrome data + * @f_color: Foreground color (corresponding to a 1 in the monochrome data + * @b_color: Background color (corresponding to a 0 in the monochrome data * @rop2: ROP value */ -int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf, - u32 srcDelta, u32 startBit, u32 dBase, u32 dPitch, - u32 bytePerPixel, u32 dx, u32 dy, u32 width, - u32 height, u32 fColor, u32 bColor, u32 rop2); +int sm750_hw_imageblit(struct lynx_accel *accel, const char *src_buf, + u32 src_delta, u32 start_bit, u32 d_base, u32 d_pitch, + u32 byte_per_pixel, u32 dx, u32 dy, u32 width, + u32 height, u32 f_color, u32 b_color, u32 rop2); #endif From patchwork Wed Apr 7 06:43:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5164C433ED for ; Wed, 7 Apr 2021 06:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6C566139C for ; Wed, 7 Apr 2021 06:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349066AbhDGGoC (ORCPT ); Wed, 7 Apr 2021 02:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349068AbhDGGnz (ORCPT ); Wed, 7 Apr 2021 02:43:55 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 598C7C061761; Tue, 6 Apr 2021 23:43:46 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id f29so9815911pgm.8; Tue, 06 Apr 2021 23:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ud5Lzp79k1SGUuv+EiKNbNuFA/5+lE3CGchvKku3uIE=; b=iJkwBi7KVbyZYS9GfX0BYQ91VreWjBOm8zpdIIlzLlF3Ry9LHDAcwS6uCbzrtlwzVO O6P//6QInNKwmD/t9RPVEZx9rR02xxPqpSGP5ruuQddvo5izBtQLh2FfbtHhMTXOtg4M 92K4fjg30GwsFx+D1FiAVCCnwwfoFF+YIWFfcqjsX9/YJxuqEagqqpju5wV5CBeCtwbJ VyoXFnEZW5qKcrMsQkrwxYrwemMg0WPhUsef2ZCfKOhEAGaOyxWZIqBN4OTGPgNIznHi P0FZ+scia1jCQl9rd5JRaNv0//YaDXThk4BQuyvGMQyomtzFL1jUy62VLsTMV8qng45F 66OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ud5Lzp79k1SGUuv+EiKNbNuFA/5+lE3CGchvKku3uIE=; b=LKAHiGzX91HQW4VC4zdMPxP9rOT8hcX0ByjHUzumU9c+Fv9JIjwJGIiwdzK6iLg4k5 OpUBTbX/pD6HlKUOPOe4x66B7aYWdbM0u8iMgXqkQHg7a5iPKAXdkmg5Zt94fxm3SNLh k6vtsjhrMJfVoDZ4C8VlpClwRnQTaSOQykoisAsgO4hh5aV5EokJtdgfsvj0dtPERPBc hgOrzot9NGN4TFubtwyRtdXNlGrBRP+7qKbkhLxfI/qPV1Wrnw+Z7hIFKb2yGhZzgsBz yDoUrB5NpOhoMEXCLUbNHqutmP5G/BGCnPZWCSqVNreEnBIpXXy90BA4FS95ky6SuC14 anmg== X-Gm-Message-State: AOAM530Xit17lgf5Sqvd/WRefeVGTsd8EhHVhUDyUzkrWgLOa9WuCu6G tTzUslDuurr9W/bsYOa/mao= X-Google-Smtp-Source: ABdhPJwiGXyAMRtVFst8y5vF7NeRJzg5ktr1IulCzxwSMwUNmxjCn4VFmNbLLH9kTYxuRPqh0iZbjg== X-Received: by 2002:a63:390:: with SMTP id 138mr1978644pgd.8.1617777825923; Tue, 06 Apr 2021 23:43:45 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id p17sm19778622pfn.62.2021.04.06.23.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:43:45 -0700 (PDT) Date: Tue, 6 Apr 2021 23:43:43 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 28/49] staging: sm750fb: Update members of lynx_cursor to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of lynx_cursor structure, in particular maxW and maxH. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 8 ++++---- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_cursor.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c237a8f8eb59..4f5f68e6aa60 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -112,8 +112,8 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) crtc = &par->crtc; cursor = &crtc->cursor; - if (fbcursor->image.width > cursor->maxW || - fbcursor->image.height > cursor->maxH || + if (fbcursor->image.width > cursor->max_w || + fbcursor->image.height > cursor->max_h || fbcursor->image.depth > 1) { return -ENXIO; } @@ -723,8 +723,8 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) 0x800f0 + (int)crtc->channel * 0x140; pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio); - crtc->cursor.maxH = crtc->cursor.maxW = 64; - crtc->cursor.size = crtc->cursor.maxH * crtc->cursor.maxW * 2 / 8; + crtc->cursor.max_h = crtc->cursor.max_w = 64; + crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8; crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset; memset_io(crtc->cursor.vstart, 0, crtc->cursor.size); diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 23eefd019ec9..8271cf7c89f3 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -122,8 +122,8 @@ struct lynx_cursor { int h; int size; /* hardware limitation */ - int maxW; - int maxH; + int max_w; + int max_h; /* base virtual address and offset of cursor image */ char __iomem *vstart; int offset; diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index bbbef27cb329..43e6f52c2551 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -97,7 +97,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, count = pitch * cursor->h; /* in byte */ - offset = cursor->maxW * 2 / 8; + offset = cursor->max_w * 2 / 8; data = 0; pstart = cursor->vstart; @@ -147,7 +147,7 @@ void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, count = pitch * cursor->h; /* in byte */ - offset = cursor->maxW * 2 / 8; + offset = cursor->max_w * 2 / 8; data = 0; pstart = cursor->vstart; From patchwork Wed Apr 7 06:44:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187129 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E08DC43462 for ; Wed, 7 Apr 2021 06:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CF816139C for ; Wed, 7 Apr 2021 06:44:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349054AbhDGGot (ORCPT ); Wed, 7 Apr 2021 02:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349149AbhDGGoP (ORCPT ); Wed, 7 Apr 2021 02:44:15 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA73EC06174A; Tue, 6 Apr 2021 23:44:05 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id c204so8437642pfc.4; Tue, 06 Apr 2021 23:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pz+9qnXlLq6MG0RWGwUAYrEGLB2Ibvwg3U+XKwAVHAY=; b=hPz0Vr/0FNjH/shaPI4Kf6Q+NrMh3PzQxZZ4llx2LvOsULhzpXrut83oD4Dq/M+lPx v3/fO8S4rXvbjfzn1kq+8AACkWIncAe1YGk2p0TrB7AxSA9ejUfK1ULtU/UX8AaC4tgN Gpd/j5teDfVYuR8AnMBTtjGlndYTVAlVWmSBXI1E/gRQdtr1nBGx2KDn4Izgf8TrvoRi lIdjCEJfPSwGt0S3PZxQ0w9tGNqrnbnrVQKn7SPKPph0Q0x8FS+IeRPF4OZJJm1R/a6f t1ZPZeMEQg2soVzCgab/IIz8TjsLKIhFOGwJ4E5g74H2oRS9bKEsdCLJZTgzCYq9aBPu b4dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pz+9qnXlLq6MG0RWGwUAYrEGLB2Ibvwg3U+XKwAVHAY=; b=tY/RDW/WnjeEggALJbVqTjkOAjOjWX6IT8rAGy51CODQwg5A26EbRAii5UHhG1uUQX FlVrDL4oWVUQ/Ut3UmXIDAB2pJlZ2ZGEvES7XSUZRrovwoPxqQIoiJuTp9phd03C6lZR xm0MS8wpEOucDZMtvx5gvHRtt2tAFGsZ81JXbrOthrd/kJGMz6eYVZpcacq7uQzPRNCQ gUyimHsNbc+NFoZA5DWagnrU1kiPrL3Dl9PUTytEhoz05vpm0Ge7b6OHJtzJ6rGJqjY/ cpi2wLEiuTGxYSwQG65ZVEXpPWMFV2tKCN3G9hqMAVyVv38/kwhwEjS9WZUFoK/tnjrm VdOg== X-Gm-Message-State: AOAM530RJ4KgSEe6rv+VH5ZyuZQTq8GVwM36fKDZQLSqC1osZjowWTrt ZbWWSHZa4QTmVCcDjVrCbo8= X-Google-Smtp-Source: ABdhPJyvKlMC+j+4Xu3mfNkUoacARCr1TNNehDyvHlblMJewcOT5lLqeYU7xYDIEb/n9xvEg5gx+pQ== X-Received: by 2002:aa7:858e:0:b029:1f1:5df2:1f70 with SMTP id w14-20020aa7858e0000b02901f15df21f70mr1607759pfn.46.1617777845296; Tue, 06 Apr 2021 23:44:05 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id s76sm20749146pfc.110.2021.04.06.23.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:04 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:03 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 29/49] staging: sm750fb: Rename function sm750_hw_cursor_setSize to snake case Message-ID: <976e2df443f81ca1433b742621651425aac43e2e.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setSize. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 4f5f68e6aa60..eeba12f4b267 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -120,7 +120,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) sm750_hw_cursor_disable(cursor); if (fbcursor->set & FB_CUR_SETSIZE) - sm750_hw_cursor_setSize(cursor, + sm750_hw_cursor_set_size(cursor, fbcursor->image.width, fbcursor->image.height); diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 43e6f52c2551..d5ef40b8bc8e 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -58,7 +58,7 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor) poke32(HWC_ADDRESS, 0); } -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h) +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h) { cursor->w = w; cursor->h = h; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index b59643dd61ed..edeed2ea4b04 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -5,7 +5,7 @@ /* hw_cursor_xxx works for voyager,718 and 750 */ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); -void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h); +void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, From patchwork Wed Apr 7 06:44:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187131 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3577AC43460 for ; Wed, 7 Apr 2021 06:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 098F86139C for ; Wed, 7 Apr 2021 06:44:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349057AbhDGGot (ORCPT ); Wed, 7 Apr 2021 02:44:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349162AbhDGGoR (ORCPT ); Wed, 7 Apr 2021 02:44:17 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BD83C06174A; Tue, 6 Apr 2021 23:44:07 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id i190so3923767pfc.12; Tue, 06 Apr 2021 23:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JESl8F7HZRw0LoSc8TBdM56g5Q/RrwjjChVRu++BC7M=; b=pIeW7733ZNniiFIlG+mz0goVz0YILC2Er9C5Kut4+DkulhA/X+gIrSoG3evHTxVokF pcUIKMTiw0pXAkteWkRJ7yeZ0Nwsb4ZNCGUVj94/+ohk6f2TP35et6CAw6vp4Z9UfCCE 97nGNlFpim7JyIHyz3r2ERQVLFLLvudS/AGNEe9YY3mVHRSQ6y28z+9v1Jz+bM6LNRgU nHd36/plfVjrJHzzeYHerr2UrNmq8/cO22oSJOkxy7rvHvRX7x/89skw+L7hDvkFctxq MYYfL2dLtEAjcNijKHLxcLBraaTyiVhCTladZ2CfxDO8cso7Q4/c3xXBX7f+GyZm2U1a vWKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JESl8F7HZRw0LoSc8TBdM56g5Q/RrwjjChVRu++BC7M=; b=XImO3A9DzPiys0oUeFkkTEWTNL4D/bqVew+vjms3C48bH3rwcYahIsvkkq3Hcw6nwQ appGGwDqxiRVfEigsIpJ3wq9MZX2NEL3FBiAzGgvhc8OHOBBs5L8+n4+bZ3nlATgAGAE eomcYNWOE3IBMJjy+OGBJ8qR/jCFeqmYeCzjKV6Pmz64cjJi2TaYTkQPlaYFEtwNZWYi RyL3EAa7T83HMjAPfbL5/Az10fPIvuxLT9JlaRqE7NC3wa1aN5hEugTCvS/LtvZ2c0B2 CcVAq3S2vRTbrbbJoKOS815jlcVbFDpIYix2EgJy9wKAQ0MU8IChJIDC7Gm+hUG4m7UY BMVg== X-Gm-Message-State: AOAM531LEU5C+xSrxEvgQ+B8x4gICol45L+9imjUOLgQaaxwhpFYOXbr HsMTFhCBjUaSiT3OoRr7kY27wvmn1qaQzg== X-Google-Smtp-Source: ABdhPJyOtpgRhE/HbBiaHc+S7qKnzFbedlYfn3+0kIirv2faj+coYPXBXXmjEEtZxcdNqmo5b2P4PA== X-Received: by 2002:a63:5466:: with SMTP id e38mr1939318pgm.172.1617777846646; Tue, 06 Apr 2021 23:44:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id y2sm20296657pgp.2.2021.04.06.23.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:06 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:04 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 30/49] staging: sm750fb: Rename function sm750_hw_cursor_setPos to snake case Message-ID: <64e2d34d1aada4b5ea77afa11019422f3fcb7229.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_set_pos. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index eeba12f4b267..b76d3d40969a 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -125,7 +125,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) fbcursor->image.height); if (fbcursor->set & FB_CUR_SETPOS) - sm750_hw_cursor_setPos(cursor, + sm750_hw_cursor_set_pos(cursor, fbcursor->image.dx - info->var.xoffset, fbcursor->image.dy - info->var.yoffset); diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index d5ef40b8bc8e..0ba80e086415 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -64,7 +64,7 @@ void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h) cursor->h = h; } -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y) +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y) { u32 reg; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index edeed2ea4b04..d0ade8e366f4 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -6,7 +6,7 @@ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); -void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y); +void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); From patchwork Wed Apr 7 06:44:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD44C433ED for ; Wed, 7 Apr 2021 06:44:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4906761222 for ; Wed, 7 Apr 2021 06:44:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349070AbhDGGou (ORCPT ); Wed, 7 Apr 2021 02:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349237AbhDGGoa (ORCPT ); Wed, 7 Apr 2021 02:44:30 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E7EC06174A; Tue, 6 Apr 2021 23:44:21 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id ep1-20020a17090ae641b029014d48811e37so769336pjb.4; Tue, 06 Apr 2021 23:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ghbx7FFI/xOaeHs+49tMcMS7V7bwU5Z4Exh4f7xVL44=; b=ZHdV5aLw9zBBixfk7lns3j+uLp+fE+jfpBzCQ7bZd5CYr2EuneKFIuLHqTifVnaucL zGdPcDW+nNelVgeqB7W8oUdMFsYRpxCrBkIOM8VgAaFX5CXzWK68BSVrTEKrts7X1Yd/ EamanSujTxwKs4BQr5XQv69wV+v6gstaNlTCKO4E0G/a86co5dtRz0ZCS+1J0V/v6VDi YqQwY0uVAAbtBURfKhkp0yl0fE/7M8It5+XQi0t1fWA6q50lvULYRLfdzxIbEU/bX12V QyZMUMJNXFT8i5Dztf04m48S8EeXSE9mQCvAp2KUuNguhx5kjLdP0ltHdpMdn7QZSLGZ RqzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ghbx7FFI/xOaeHs+49tMcMS7V7bwU5Z4Exh4f7xVL44=; b=EyOVJPJ9S6Zmpv9hLM5/3mwqgE6Tis8JatVUc85PsWlMr6XqqOmf0zuj/4slv3I7Tj 4kK0ZYWzuszW02DvLGx5QF7hW7+jS6SivoQYIwT+ZqGrezDPtJNGt4WwKjLRnEtppVsV QJI2oB0gzYpWsOJdgcjLa0mCyu5Pan1YEMl5wwC9ttE6l4KIgIBjJSbcfWOkeU11nqHL X0NOCDQR7lB1+PJI0suXF1JhRUe0esaExNDj7tesp9AGticqevMCWx62D7/Jw9m/19ud LVLEEJRx1xCq/6rJzdMpcukD5pUyEhBY2ZovBBu4jZZqpHymax3ozu1oDsDa1ATUATzr e7Pw== X-Gm-Message-State: AOAM533eIEFo/gBrI8nX9YZGUJjiN6ZRlWUqAHYyKLuE0to5bvn9X5MG PuVZ5gNGu09aU+/e2TVleRU= X-Google-Smtp-Source: ABdhPJwMUnBvkzFOlvRo36+9JXfDTHckBHyQhlezB7Mo3oGKjr3aI+4SImJApI+xreybVO67UNt6lA== X-Received: by 2002:a17:90a:94cc:: with SMTP id j12mr1936031pjw.159.1617777861339; Tue, 06 Apr 2021 23:44:21 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id x18sm3809410pfi.105.2021.04.06.23.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:20 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:18 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 31/49] staging: sm750fb: Rename function sm750_hw_cursor_setColor to snake case Message-ID: <453d3058e041eb99492ea0bc85956ecf8cc47129.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_set_color. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index b76d3d40969a..d93884f9da7f 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -141,7 +141,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) ((info->cmap.green[fbcursor->image.bg_color] & 0xfc00) >> 5) | ((info->cmap.blue[fbcursor->image.bg_color] & 0xf800) >> 11); - sm750_hw_cursor_setColor(cursor, fg, bg); + sm750_hw_cursor_set_color(cursor, fg, bg); } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 0ba80e086415..ac83ead1c5bc 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -73,7 +73,7 @@ void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y) poke32(HWC_LOCATION, reg); } -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg) { u32 reg = (fg << HWC_COLOR_12_2_RGB565_SHIFT) & HWC_COLOR_12_2_RGB565_MASK; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index d0ade8e366f4..edfa6a8202cd 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -7,7 +7,7 @@ void sm750_hw_cursor_enable(struct lynx_cursor *cursor); void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); -void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg); +void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, From patchwork Wed Apr 7 06:44:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187135 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2B7C433B4 for ; Wed, 7 Apr 2021 06:44:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E04761222 for ; Wed, 7 Apr 2021 06:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349071AbhDGGou (ORCPT ); Wed, 7 Apr 2021 02:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349258AbhDGGop (ORCPT ); Wed, 7 Apr 2021 02:44:45 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC98C06174A; Tue, 6 Apr 2021 23:44:32 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id l76so12263828pga.6; Tue, 06 Apr 2021 23:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6p8ZANqd/RqsWjSImmd+1sF92/GqWhRbXBxvKnMm8Pg=; b=jV4m0l4ZmxdtJzwPsVyZjRIfDdmI8j5RZhoa/zDJAGovAhwpeq7vTBXKWw2R8FGgT7 4h5V3TxuCQ/tx9xQCE3LwD/S0QZhKI2zMN1S87dpLCVZH4kKT9RfIP4FGrxGI6+/PrHt Wel2RMXwRjGPuWIEmWnFJ14EABXdt8Qp4mynEr8aGhGBfy8j0kPW6Gth6J0qTXcsV9Ti 8y5xl9yMQoIRlZ0PxtJ/7UUTUsMwQM6cVEOYasdCuGJ5NvJrxbI/4l8ukwIcHz8gze2e RmcQWwc+aott8c3KLTYJocgDasuP1bUab2AsUq6t7f1Sxm+U++S5cHAwB4sCdJuQ/SdK J4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6p8ZANqd/RqsWjSImmd+1sF92/GqWhRbXBxvKnMm8Pg=; b=c9fSsSQLshCpfe2FjU2cAGgv0L2Zg5tSkyfAWC6tOo4CJacmiqu+a8B5xSy6o7JZiE lN1W67i9DnByOE026Vt96Q1n7Ae8Ic0zQbeIEZT/aJi4uXpRuIexUYeyw2waogwplFav tR5VnnxApWYbJ6UWXxgOZnwr+XAnNQ7AHz4yV80puBcTpuU6p7MEhXe3jq1Jf67HJLou Ow2SgeNi+dYuiX0PnNCz3TSVQ88nulFFwzkUlq8bRLIEC2NkiFUkzmWpa7p7QvQbkExl cdVZxOJ4lEvnwh8+a59TJbWAhNZ40ZIFN1n/oHS95DoJ8/rtftU4Y+348EgGtK1m2zA/ LLXw== X-Gm-Message-State: AOAM531YafQYK0vEkUFI8wBKzECZsmCGaqieM5mjqegKyMHqWThKpgmq VeuKh5NPBy0ZK1IY7/z4DPg= X-Google-Smtp-Source: ABdhPJyFmpsftdsYmNluBQreMHb0XqH5cpB/EVFcvW9RKRwrT0uyXBG66Mq1jUNM4Of1+X3Z6Wmm2Q== X-Received: by 2002:a63:c847:: with SMTP id l7mr1919574pgi.445.1617777872126; Tue, 06 Apr 2021 23:44:32 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id l191sm4313761pfd.36.2021.04.06.23.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:31 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:29 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 32/49] staging: sm750fb: Rename function sm750_hw_cursor_setData to snake case Message-ID: <3df59f311d53a8d0dba7cc8a9704b036d34c5a7d.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index d93884f9da7f..9263d4bdd222 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -145,7 +145,7 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) } if (fbcursor->set & (FB_CUR_SETSHAPE | FB_CUR_SETIMAGE)) { - sm750_hw_cursor_setData(cursor, + sm750_hw_cursor_set_data(cursor, fbcursor->rop, fbcursor->image.data, fbcursor->mask); diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index ac83ead1c5bc..98d294ac223c 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -82,7 +82,7 @@ void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg) poke32(HWC_COLOR_3, 0xffe0); } -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index edfa6a8202cd..af0211242ae8 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -8,7 +8,7 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor); void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h); void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); -void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); From patchwork Wed Apr 7 06:44:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16604C43460 for ; Wed, 7 Apr 2021 06:44:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D983D61222 for ; Wed, 7 Apr 2021 06:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349092AbhDGGoz (ORCPT ); Wed, 7 Apr 2021 02:44:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349108AbhDGGow (ORCPT ); Wed, 7 Apr 2021 02:44:52 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83FDCC061762; Tue, 6 Apr 2021 23:44:43 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id a6so5505174pls.1; Tue, 06 Apr 2021 23:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v5F66A4CVLf0PCVKwwhgQWPfplNHHogpzp6J0Rowd60=; b=J+83Zbiiag6BpOcxsapxpcpjCFeBM7GFFXJ7MMoFNkOQCMOCajfwQGgfim/yMz0Xjt r/trgUh9QydkyOeFJcI/BZc2virqSs1viHTFxvfI7NZe0cYbSDqrBPHHzmDx6n3xqpoM 7iduvXOrbE7tVdAq9UGLBTTwSCxIaBRnbc62ws0d/RTJoPt5joGBvs9xIguZqxyZ3lsw 6bCdTnUTj/tFQvvJqsFWlLqV8neyHLzoOM/njFTZn/3e7JPeTm4TN2RyaBVTWuw9A7+9 sZdvSHAdOCShuJvMkLf676LEssxQxskJJTIAg/HOK6GJbp863xGhS6Amb7LR/6A3bBZu qHpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v5F66A4CVLf0PCVKwwhgQWPfplNHHogpzp6J0Rowd60=; b=JAJ7Tz/1yUIvlfeyFk2BH/EPMdWACfGSjLmtJWFIb/VilMH+S9lg/K7Smg0x1QvABU 3bBFOkzxfjeqm8MaI5dyg6I9uPHfyJQ73MY4TxQqZaK205KaKouOr0T5oW836LzeILl5 QLVC7/NmgXkmfZqgTqrf9Uaghv2K5W2P3krcWXcvWnWLCGfTVWmu5wYiW4hGWY0DU+gy v447IpmMVQelB64E5nWOL/jsL7Iv93ZW7p5IQxUy5SrcqV6Ltq6/c4k86fbVdfJUCNJt SqJX2Y6Y6rcvX6FA6o54q7stsCF2FSmHILdFZA1VDfDghClDR/Yx5hFM5r32wJJEunEw FVGg== X-Gm-Message-State: AOAM5309sbukK/Rabuj+1J2tyZg6MO81E4+5+dIIGullosIEEwcPmwfP ez/2BGA7P46a35CEn/ZNv+OKUZZ44ID4uQ== X-Google-Smtp-Source: ABdhPJz+XXWB75AReec2tP6DygxwX83W/w/NAB6x50T3Tg926mjmOGn4LbRYExRzqS4N1RCtTls18A== X-Received: by 2002:a17:90b:1993:: with SMTP id mv19mr1869403pjb.193.1617777883018; Tue, 06 Apr 2021 23:44:43 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id s9sm3816977pfc.192.2021.04.06.23.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:44:42 -0700 (PDT) Date: Tue, 6 Apr 2021 23:44:40 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 33/49] staging: sm750fb: Rename function hw_sm750_crtc_setMode to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_crtc_setMode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 9263d4bdd222..2343cd897989 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -393,7 +393,7 @@ static int lynxfb_ops_set_par(struct fb_info *info) pr_err("bpp %d not supported\n", var->bits_per_pixel); return ret; } - ret = hw_sm750_crtc_setMode(crtc, var, fix); + ret = hw_sm750_crtc_set_mode(crtc, var, fix); if (!ret) ret = hw_sm750_output_setMode(output, var, fix); return ret; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 8271cf7c89f3..6e0805a99180 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -204,7 +204,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output, int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var); -int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index e31f4c6bc69e..efe379ef3438 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -247,7 +247,7 @@ int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, } /* set the controller's mode for @crtc charged with @var and @fix parameters */ -int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix) { From patchwork Wed Apr 7 06:45:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1DE7C433B4 for ; Wed, 7 Apr 2021 06:45:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F162613B3 for ; Wed, 7 Apr 2021 06:45:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349145AbhDGGpS (ORCPT ); Wed, 7 Apr 2021 02:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbhDGGpN (ORCPT ); Wed, 7 Apr 2021 02:45:13 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F79C061756; Tue, 6 Apr 2021 23:45:04 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id w10so6787614pgh.5; Tue, 06 Apr 2021 23:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r+/ubJpz4/HTXv8eOVXNq9iq2TyIv3qtyAaCadZayLU=; b=ex0ZuJ6BYTkipi3BrHw6UPzSmwY0XAYK47g+AbilJ2uy/hMZGCWjFREyZ1hts2EyqE eyAOUCrvvaBbvobBqbFqK4dEV3z7sTRioHX7gOFuSuFsyhNSXINBYcgurEPzQQfC2y5W 9GhE5edIkrS7YjZ7myHVxwdQuRIyOjem+BYYx1HqWql1FKVVcf0flS1zj8jN61Q85hlw Re355WTiOnpHAHo77p6FiCipjfPZj1Xh5vk3Ql+uOtDS+wMRzpctc9VPanhPz03q5yrw Ae2CT/rHkTLWRj5esNmEUp1RVKgHlOpHqQCdG9Qr1XvF1V9zX1nXkOMWhesPiKoFT7A/ iuNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r+/ubJpz4/HTXv8eOVXNq9iq2TyIv3qtyAaCadZayLU=; b=jnlRlD9NSuIqdgomDz8t2KT/lxqmV0IP9GlexwS+Nk7uY5vrCeCIZwq4OGqWkbCUbt e7DhVrLuW5QeV00AGQDhYZxg7ADnTZMRHIIll0xJCpFdPg9l4bQbB0CVy2/ZTatfqc/U fT58XlJP7PEfy7xFnXUd6Bh7UV2gM6gdX/LPqxMWjQBOeNrr3xLJV+0on/JvTCJGYV49 koQr5o1ZIh8YYQ3Uf+kUOOjA5yg1U++MD7+kMbXyEgxQKQmiDqkjP4Sq0nalUa48l6sS 04tsLQhAq/zjaW2aQwrRe1qQiKQKW8K11lqEGdwlKvFvO7Xh8kotYW084t4IWITjhrWA ujoQ== X-Gm-Message-State: AOAM530vhyFUhNkebTxSQUou3eNXEl/wACWKujsAyAhy6E2iVI3aXUW2 BpU4MtBkVurt5PZQ3aldFL0= X-Google-Smtp-Source: ABdhPJwFZt1Y2aKbKiI5jvIRs8N3P6dCnsP3uA3w0axYqaNVGu5TafhGHB08xBH43ZJF4/zpL0wDoA== X-Received: by 2002:aa7:96aa:0:b029:222:4029:7408 with SMTP id g10-20020aa796aa0000b029022240297408mr1532087pfk.74.1617777904495; Tue, 06 Apr 2021 23:45:04 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id s29sm3431080pfd.7.2021.04.06.23.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:04 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:02 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 34/49] staging: sm750fb: Update members of init_status struct to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct init_status, in particular powerMode, setAllEngOff, and resetMemory. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 6 +++--- drivers/staging/sm750fb/sm750.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 2343cd897989..58de4b9575d9 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -873,9 +873,9 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) sm750_dev->initParm.chip_clk = 0; sm750_dev->initParm.mem_clk = 0; sm750_dev->initParm.master_clk = 0; - sm750_dev->initParm.powerMode = 0; - sm750_dev->initParm.setAllEngOff = 0; - sm750_dev->initParm.resetMemory = 1; + sm750_dev->initParm.power_mode = 0; + sm750_dev->initParm.set_all_eng_off = 0; + sm750_dev->initParm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */ g_hwcursor = 3; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 6e0805a99180..f946d35d30d0 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -39,13 +39,13 @@ enum sm750_path { }; struct init_status { - ushort powerMode; + ushort power_mode; /* below three clocks are in unit of MHZ*/ ushort chip_clk; ushort mem_clk; ushort master_clk; - ushort setAllEngOff; - ushort resetMemory; + ushort set_all_eng_off; + ushort reset_memory; }; struct lynx_accel { From patchwork Wed Apr 7 06:45:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6152FC433ED for ; Wed, 7 Apr 2021 06:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DA8C61222 for ; Wed, 7 Apr 2021 06:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243243AbhDGGpb (ORCPT ); Wed, 7 Apr 2021 02:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbhDGGp1 (ORCPT ); Wed, 7 Apr 2021 02:45:27 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04E8C06174A; Tue, 6 Apr 2021 23:45:18 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so758952pjb.0; Tue, 06 Apr 2021 23:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WxWGo8ILtmVAdW7DYZqUtw98RFWj2ze6hbKX+KcSEqI=; b=MF2sB6L4LiOtKsVFzSV9iCM5li/W9l6IytIBgpMZmNQDUYUI+qHjjZsjOS8T8o/Xly Lg/gMMbN/v2uoWV9lxC0Xl/dSc9n4ZaAkItZt+0aOjZv7CtUyUqd0RAVzhWv+n7+c8FT QKUFg9h89HuHub9a/go9nbPJfZ/rVPC8w6DwJBJ0xnsoZu4QHoloGsO2T1DZOiEpMp+B HUv8h7ji8AYYCzZ6/wcHUme3La7bvf1odNBmp6Sdu0ecntWk5lW0HjA0LzQEzSqQaq1F c8yJNCuPDOI4q7AacmJvMnd9dZJpiN+SZNwRyR2GIQ+VOZvHKyQl14zx8fGheiwIilFt /NfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WxWGo8ILtmVAdW7DYZqUtw98RFWj2ze6hbKX+KcSEqI=; b=gKnFwHIRhdst3Gv9eiDWUB5d0jRfxO/zrXyaX8XbnjLrGJp/p8W3SO6ytSOEpshH0a yw1wRrDZX9CssuXTm83TcpPCYG48TxCxy0z/h83+Z96o8wrVEvgrcmp73YfVqqhbeb4A OKNbodc2x4AbwiSfpHPb0L+eyPjr8iG9xoz/7xdAVO2+K6AG1fziM3LDtQ/hVwTCJpR9 dDOVimTsr6Ejxrm90Tsx3dkEUAEsQa1G3kG2eLmEYjs51/qvLxvrUCxctkttbJS1Y+fF QhUk3ThpUf8L5MTTGB2HitRICdveeewsJftPT++D5X0P3x5bQ0sk85r8RSguZ7dVq2On aKPA== X-Gm-Message-State: AOAM531wPWgg7X/0UH+b/QQ108fOehR9fstmJNCGRskJH5IiWJuIRxQh 6jfj9jpgeEOptGuwo2Ef0rU= X-Google-Smtp-Source: ABdhPJwBgQPbWKpEIXmeAH2VyBDeKJvWfUDqQScruju9ROclIK6s70UEE31A1gkggUugQQ/uY+fsqQ== X-Received: by 2002:a17:902:ea93:b029:e9:4b38:deef with SMTP id x19-20020a170902ea93b02900e94b38deefmr1760652plb.22.1617777918397; Tue, 06 Apr 2021 23:45:18 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id g15sm3877642pjd.2.2021.04.06.23.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:18 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:16 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 35/49] staging: sm750fb: Update members of sm750_dev struct to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of sm750_dev structure, in particular initParam, pvReg, pvMem, and hwCursor. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 36 +++++++++++++++--------------- drivers/staging/sm750fb/sm750.h | 8 +++---- drivers/staging/sm750fb/sm750_hw.c | 22 +++++++++--------- 3 files changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 58de4b9575d9..22881d35c9ad 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -598,7 +598,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) crtc->vidmem_size >>= 1; /* setup crtc and output member */ - sm750_dev->hwCursor = g_hwcursor; + sm750_dev->hw_cursor = g_hwcursor; crtc->line_pad = 16; crtc->xpanstep = 8; @@ -615,27 +615,27 @@ static int sm750fb_set_drv(struct lynxfb_par *par) output->paths = sm750_pnc; crtc->channel = sm750_primary; crtc->oScreen = 0; - crtc->vScreen = sm750_dev->pvMem; + crtc->vScreen = sm750_dev->mem; pr_info("use simul primary mode\n"); break; case sm750_simul_sec: output->paths = sm750_pnc; crtc->channel = sm750_secondary; crtc->oScreen = 0; - crtc->vScreen = sm750_dev->pvMem; + crtc->vScreen = sm750_dev->mem; break; case sm750_dual_normal: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_primary; crtc->oScreen = 0; - crtc->vScreen = sm750_dev->pvMem; + crtc->vScreen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_secondary; /* not consider of padding stuffs for oScreen,need fix */ crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->pvMem + crtc->oScreen; + crtc->vScreen = sm750_dev->mem + crtc->oScreen; } break; case sm750_dual_swap: @@ -643,7 +643,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) output->paths = sm750_panel; crtc->channel = sm750_secondary; crtc->oScreen = 0; - crtc->vScreen = sm750_dev->pvMem; + crtc->vScreen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_primary; @@ -651,7 +651,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) * need fix */ crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->pvMem + crtc->oScreen; + crtc->vScreen = sm750_dev->mem + crtc->oScreen; } break; default: @@ -719,13 +719,13 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * must be set after crtc member initialized */ crtc->cursor.offset = crtc->oScreen + crtc->vidmem_size - 1024; - crtc->cursor.mmio = sm750_dev->pvReg + + crtc->cursor.mmio = sm750_dev->reg + 0x800f0 + (int)crtc->channel * 0x140; pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio); crtc->cursor.max_h = crtc->cursor.max_w = 64; crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8; - crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset; + crtc->cursor.vstart = sm750_dev->mem + crtc->cursor.offset; memset_io(crtc->cursor.vstart, 0, crtc->cursor.size); if (!g_hwcursor) { @@ -870,12 +870,12 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) swap = 0; - sm750_dev->initParm.chip_clk = 0; - sm750_dev->initParm.mem_clk = 0; - sm750_dev->initParm.master_clk = 0; - sm750_dev->initParm.power_mode = 0; - sm750_dev->initParm.set_all_eng_off = 0; - sm750_dev->initParm.reset_memory = 1; + sm750_dev->init_parm.chip_clk = 0; + sm750_dev->init_parm.mem_clk = 0; + sm750_dev->init_parm.master_clk = 0; + sm750_dev->init_parm.power_mode = 0; + sm750_dev->init_parm.set_all_eng_off = 0; + sm750_dev->init_parm.reset_memory = 1; /* defaultly turn g_hwcursor on for both view */ g_hwcursor = 3; @@ -1061,7 +1061,7 @@ static int lynxfb_pci_probe(struct pci_dev *pdev, sm750_dev->mtrr.vram = arch_phys_wc_add(sm750_dev->vidmem_start, sm750_dev->vidmem_size); - memset_io(sm750_dev->pvMem, 0, sm750_dev->vidmem_size); + memset_io(sm750_dev->mem, 0, sm750_dev->vidmem_size); pci_set_drvdata(pdev, sm750_dev); @@ -1092,8 +1092,8 @@ static void lynxfb_pci_remove(struct pci_dev *pdev) sm750fb_framebuffer_release(sm750_dev); arch_phys_wc_del(sm750_dev->mtrr.vram); - iounmap(sm750_dev->pvReg); - iounmap(sm750_dev->pvMem); + iounmap(sm750_dev->reg); + iounmap(sm750_dev->mem); kfree(g_settings); } diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index f946d35d30d0..6f3af779f3b0 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -97,12 +97,12 @@ struct sm750_dev { unsigned long vidreg_start; __u32 vidmem_size; __u32 vidreg_size; - void __iomem *pvReg; - unsigned char __iomem *pvMem; + void __iomem *reg; + unsigned char __iomem *mem; /* locks*/ spinlock_t slock; - struct init_status initParm; + struct init_status init_parm; enum sm750_pnltype pnltype; enum sm750_dataflow dataflow; int nocrt; @@ -113,7 +113,7 @@ struct sm750_dev { * 2: secondary crtc hw cursor enabled * 3: both ctrc hw cursor enabled */ - int hwCursor; + int hw_cursor; }; struct lynx_cursor { diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index efe379ef3438..add9daa585fd 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -50,20 +50,20 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) } /* now map mmio and vidmem */ - sm750_dev->pvReg = ioremap(sm750_dev->vidreg_start, + sm750_dev->reg = ioremap(sm750_dev->vidreg_start, sm750_dev->vidreg_size); - if (!sm750_dev->pvReg) { + if (!sm750_dev->reg) { pr_err("mmio failed\n"); ret = -EFAULT; goto exit; } else { - pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg); + pr_info("mmio virtual addr = %p\n", sm750_dev->reg); } - sm750_dev->accel.dprBase = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dprBase = sm750_dev->reg + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dpPortBase = sm750_dev->reg + DE_PORT_ADDR_TYPE1; - mmio750 = sm750_dev->pvReg; + mmio750 = sm750_dev->reg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); sm750_dev->vidmem_start = pci_resource_start(pdev, 0); @@ -78,14 +78,14 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) sm750_dev->vidmem_start, sm750_dev->vidmem_size); /* reserve the vidmem space of smi adaptor */ - sm750_dev->pvMem = ioremap_wc(sm750_dev->vidmem_start, + sm750_dev->mem = ioremap_wc(sm750_dev->vidmem_start, sm750_dev->vidmem_size); - if (!sm750_dev->pvMem) { + if (!sm750_dev->mem) { pr_err("Map video memory failed\n"); ret = -EFAULT; goto exit; } else { - pr_info("video memory vaddr = %p\n", sm750_dev->pvMem); + pr_info("video memory vaddr = %p\n", sm750_dev->mem); } exit: return ret; @@ -95,7 +95,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) { struct init_status *parm; - parm = &sm750_dev->initParm; + parm = &sm750_dev->init_parm; if (parm->chip_clk == 0) parm->chip_clk = (sm750_get_chip_type() == SM750LE) ? DEFAULT_SM750LE_CHIP_CLOCK : @@ -106,7 +106,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) if (parm->master_clk == 0) parm->master_clk = parm->chip_clk / 3; - ddk750_init_hw((struct initchip_param *)&sm750_dev->initParm); + ddk750_init_hw((struct initchip_param *)&sm750_dev->init_parm); /* for sm718, open pci burst */ if (sm750_dev->devid == 0x718) { poke32(SYSTEM_CTRL, From patchwork Wed Apr 7 06:45:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02132C433ED for ; Wed, 7 Apr 2021 06:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1AFF6139C for ; Wed, 7 Apr 2021 06:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345458AbhDGGqQ (ORCPT ); Wed, 7 Apr 2021 02:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345361AbhDGGpl (ORCPT ); Wed, 7 Apr 2021 02:45:41 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D96C06174A; Tue, 6 Apr 2021 23:45:30 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so778565pjv.1; Tue, 06 Apr 2021 23:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Cq0F0lLxX9YZN85mY7IttM5IDARZ7TDuacaMTtEqzBU=; b=ZqHBDt9zMmhQ2BUnkUxKq1bpZgEJsxiJL7gxitapvMauN/ZBXTgjwXa+l4BO3cOS9g B/o67xoi9AjNDWI/+TMzzBl1BH8N0sqrPoF97WThEaoghxSbClpNbjpBLA8L2mhFAeq7 pLByWMgtKasK7qVRhZ4m5pO6jq1P0vqo9cVq8Ib8A32r3P/wG0tB/4M+ngjMLsI4HVXh sHklVjfdagHfp0a5IbtGba42yV8Hy9uf1jtki9/ybyV/AHxFYSwHUzP1Nw3gLujAtoYX sZ0mvpZHQRSJRJtOTPpxlfMJcBSjfBWCgGaFrzdzPrd1Hwkyct5eQa0tv3POs4DOK9x1 LGmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Cq0F0lLxX9YZN85mY7IttM5IDARZ7TDuacaMTtEqzBU=; b=SfQGnmS199REnQy9F1FsrMSnaEvIHFsvgU9N2a5GtH4ET9/edgSXGC4WcO3Po0rNjq 5I8U0nLJSySmUJTTeUB/Krl2bsj+9oZklyLRihEVAiQh8TmgyBsEukQIc5F475EVV1TL 6nODE3NKJpm8O4ly8o8Vg0GYtzzE0CMm7AUskbqNqCvN+ho6mCb59/VUjusxwfEyiET6 IG3Q6TGu5ywmR9uk0+nv+hJqg/yia0cacQI/X+HR7IHTWbQ5D4n2eWJg4xnuyAP4257G hgt0Q8lVaULA029yrQfKcMc9kULIMZ2id1Rqsy2a0OIgQqGCMwuLgIOjuJSKDqhdF4YH ju2A== X-Gm-Message-State: AOAM533aZVSsktit9B+WnkWsePDTl1yvP5MZ60QiBQL36SNyrslBDSH7 f8e34PpEd/N3GAKpd099BLM= X-Google-Smtp-Source: ABdhPJweO/S/JOZZdVNrMt+N1UpFQgRrQ4bndSmGPIZkV6qvSMhqoaRRJlBgmXbWfaspqIgGX9FW+w== X-Received: by 2002:a17:90a:1509:: with SMTP id l9mr1904415pja.163.1617777930303; Tue, 06 Apr 2021 23:45:30 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id w203sm19864646pfc.188.2021.04.06.23.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:29 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:27 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 36/49] staging: sm750fb: Update members of lynxfb_crtc struct to snake case Message-ID: <8c28f719ba6be13c9d5cf6a72080c449ce4897ce.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of the struct lynxfb_crtc, in particular vCursor, vScreen, oCursor, and oScreen. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 44 +++++++++++++++--------------- drivers/staging/sm750fb/sm750.h | 8 +++--- drivers/staging/sm750fb/sm750_hw.c | 6 ++-- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 22881d35c9ad..2c944539eaf0 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -175,7 +175,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -213,7 +213,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -247,7 +247,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, * each time 2d function begin to work,below three variable always need * be set, seems we can put them together in some place */ - base = par->crtc.oScreen; + base = par->crtc.o_screen; pitch = info->fix.line_length; Bpp = info->var.bits_per_pixel >> 3; @@ -451,7 +451,7 @@ static int __maybe_unused lynxfb_resume(struct device *dev) crtc = &par->crtc; cursor = &crtc->cursor; memset_io(cursor->vstart, 0x0, cursor->size); - memset_io(crtc->vScreen, 0x0, crtc->vidmem_size); + memset_io(crtc->v_screen, 0x0, crtc->vidmem_size); lynxfb_ops_set_par(info); fb_set_suspend(info, 0); } @@ -463,7 +463,7 @@ static int __maybe_unused lynxfb_resume(struct device *dev) crtc = &par->crtc; cursor = &crtc->cursor; memset_io(cursor->vstart, 0x0, cursor->size); - memset_io(crtc->vScreen, 0x0, crtc->vidmem_size); + memset_io(crtc->v_screen, 0x0, crtc->vidmem_size); lynxfb_ops_set_par(info); fb_set_suspend(info, 0); } @@ -614,44 +614,44 @@ static int sm750fb_set_drv(struct lynxfb_par *par) case sm750_simul_pri: output->paths = sm750_pnc; crtc->channel = sm750_primary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; pr_info("use simul primary mode\n"); break; case sm750_simul_sec: output->paths = sm750_pnc; crtc->channel = sm750_secondary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; break; case sm750_dual_normal: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_primary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_secondary; - /* not consider of padding stuffs for oScreen,need fix */ - crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->mem + crtc->oScreen; + /* not consider of padding stuffs for o_screen,need fix */ + crtc->o_screen = sm750_dev->vidmem_size >> 1; + crtc->v_screen = sm750_dev->mem + crtc->o_screen; } break; case sm750_dual_swap: if (par->index == 0) { output->paths = sm750_panel; crtc->channel = sm750_secondary; - crtc->oScreen = 0; - crtc->vScreen = sm750_dev->mem; + crtc->o_screen = 0; + crtc->v_screen = sm750_dev->mem; } else { output->paths = sm750_crt; crtc->channel = sm750_primary; - /* not consider of padding stuffs for oScreen, + /* not consider of padding stuffs for o_screen, * need fix */ - crtc->oScreen = sm750_dev->vidmem_size >> 1; - crtc->vScreen = sm750_dev->mem + crtc->oScreen; + crtc->o_screen = sm750_dev->vidmem_size >> 1; + crtc->v_screen = sm750_dev->mem + crtc->o_screen; } break; default: @@ -718,7 +718,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) * set current cursor variable and proc pointer, * must be set after crtc member initialized */ - crtc->cursor.offset = crtc->oScreen + crtc->vidmem_size - 1024; + crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024; crtc->cursor.mmio = sm750_dev->reg + 0x800f0 + (int)crtc->channel * 0x140; @@ -801,7 +801,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) crtc->line_pad); info->pseudo_palette = &par->pseudo_palette[0]; - info->screen_base = crtc->vScreen; + info->screen_base = crtc->v_screen; pr_debug("screen_base vaddr = %p\n", info->screen_base); info->screen_size = line_length * var->yres_virtual; info->flags = FBINFO_FLAG_DEFAULT | 0; @@ -816,7 +816,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) strscpy(fix->id, fixId[index], sizeof(fix->id)); - fix->smem_start = crtc->oScreen + sm750_dev->vidmem_start; + fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start; pr_info("fix->smem_start = %lx\n", fix->smem_start); /* * according to mmap experiment from user space application, diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 6f3af779f3b0..368e5cc19147 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -132,10 +132,10 @@ struct lynx_cursor { }; struct lynxfb_crtc { - unsigned char __iomem *vCursor; /* virtual address of cursor */ - unsigned char __iomem *vScreen; /* virtual address of on_screen */ - int oCursor; /* cursor address offset in vidmem */ - int oScreen; /* onscreen address offset in vidmem */ + unsigned char __iomem *v_cursor; /* virtual address of cursor */ + unsigned char __iomem *v_screen; /* virtual address of on_screen */ + int o_cursor; /* cursor address offset in vidmem */ + int o_screen; /* onscreen address offset in vidmem */ int channel;/* which channel this crtc stands for*/ resource_size_t vidmem_size;/* this view's video memory max size */ diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index add9daa585fd..7c852c6a153b 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -314,7 +314,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, if (crtc->channel != sm750_secondary) { /* set pitch, offset, width, start address, etc... */ poke32(PANEL_FB_ADDRESS, - crtc->oScreen & PANEL_FB_ADDRESS_ADDRESS_MASK); + crtc->o_screen & PANEL_FB_ADDRESS_ADDRESS_MASK); reg = var->xres * (var->bits_per_pixel >> 3); /* @@ -350,7 +350,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, poke32(PANEL_DISPLAY_CTRL, reg | (var->bits_per_pixel >> 4)); } else { /* not implemented now */ - poke32(CRT_FB_ADDRESS, crtc->oScreen); + poke32(CRT_FB_ADDRESS, crtc->o_screen); reg = var->xres * (var->bits_per_pixel >> 3); /* * crtc->channel is not equal to par->index on numeric, @@ -554,7 +554,7 @@ int hw_sm750_pan_display(struct lynxfb_crtc *crtc, total = var->yoffset * info->fix.line_length + ((var->xoffset * var->bits_per_pixel) >> 3); - total += crtc->oScreen; + total += crtc->o_screen; if (crtc->channel == sm750_primary) { poke32(PANEL_FB_ADDRESS, peek32(PANEL_FB_ADDRESS) | From patchwork Wed Apr 7 06:45:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C6EC433B4 for ; Wed, 7 Apr 2021 06:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A30661222 for ; Wed, 7 Apr 2021 06:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239509AbhDGGqS (ORCPT ); Wed, 7 Apr 2021 02:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349160AbhDGGpv (ORCPT ); Wed, 7 Apr 2021 02:45:51 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32E70C061756; Tue, 6 Apr 2021 23:45:42 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id b17so8629030pgh.7; Tue, 06 Apr 2021 23:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2cYF68oFcyjU4Kfw0xfEVQzUH83t8nX8JKIHWjr/Ga4=; b=MEokI6t3x8iAwgGFuejhxCZfmi/8MZr1VfKdpod4k0sm+6g0CTIMZud2LT2aIEjPmM SGKqVjzmxeHkaq0RbhWqK0TBvdEod2XCaDHzh/O+S05TvY7T4fiacuLDQYI0hK5UsLrx V11h9pGD6iJZxUEwJAszphcVnKmeM/Ocutf6obIGu5JpbkxIbabAI7FQNc0salQf6OM7 c/7tfo6Dv6UW+r1B8uAkp5FRh0kDMHvq+hWQcI4vn1ZZr4ApZ6xoBHx0W4cLNPgXbCqF XxEMZZLA2z0RavXGOmdGyc+9iPDhPjiQPQltvlyDzrowszOJj14dxsOjLdROM37Nf0zw GhFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2cYF68oFcyjU4Kfw0xfEVQzUH83t8nX8JKIHWjr/Ga4=; b=qUSiDfJ48CQoTi3FMYePhb7EdPXmv8gCZBtnz+Rg5ct8aCMe76/Wvc2xq/KkfYhT6d D4bedTOH/lUwgJC2N2S6I3wIYqCo92htDfA9Bgw3b1xF1wqM3MXwzoSuekgH1/UU7Q/t ELCzKKWxcGOp5qq0SbzI/46v9yUrLMapU+CtBFfU1ZGacYHUOhitobPtl6+w7IHKQ3ZP N/KRnC5HDU5qqjw+ftnhabE2bsqpLV0xoqvUVt2sKkqdrHSsOkfchI1k0VztQmfKchQ2 VoNb14GCtbx5XL+Otbs6Su8CIvb9eNljaYmSwW9gkugxJ5tRQ2lbh7MySpAl9ZTL3Mhk eMbg== X-Gm-Message-State: AOAM532yVPhJDyOTSxqvol4v8OplSOzQ+YIf6wWq10lpFLiIZFItNr6N IQwdGuNUwZ9lVRpZfoLLcg4vn3a5M/2/yg== X-Google-Smtp-Source: ABdhPJxk+9euoAl2I+ED+syNGgwrNK2Klr1blr3hUcYgQ/TU2vQI/PVdYVYP0vPQ22ggVoTxZGYaBg== X-Received: by 2002:a63:1b5f:: with SMTP id b31mr1968300pgm.194.1617777941781; Tue, 06 Apr 2021 23:45:41 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id l25sm21847554pgu.72.2021.04.06.23.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:45:41 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:39 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 37/49] staging: sm750fb: Rename function hw_sm750_output_setMode to snake case Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_output_set_mod. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 2c944539eaf0..8e803b580a71 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -395,7 +395,7 @@ static int lynxfb_ops_set_par(struct fb_info *info) } ret = hw_sm750_crtc_set_mode(crtc, var, fix); if (!ret) - ret = hw_sm750_output_setMode(output, var, fix); + ret = hw_sm750_output_set_mode(output, var, fix); return ret; } diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 368e5cc19147..b46d13134f76 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -197,7 +197,7 @@ void hw_sm750_initAccel(struct sm750_dev *sm750_dev); int hw_sm750_deWait(void); int hw_sm750le_deWait(void); -int hw_sm750_output_setMode(struct lynxfb_output *output, +int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 7c852c6a153b..410f726b03e9 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -180,7 +180,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) return 0; } -int hw_sm750_output_setMode(struct lynxfb_output *output, +int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix) { From patchwork Wed Apr 7 06:45:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB6DC43462 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B73F613CF for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345649AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345694AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58B0AC06175F; Tue, 6 Apr 2021 23:46:01 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id j7so4152880plx.2; Tue, 06 Apr 2021 23:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RBA5zwvxY/1ia+fk/xzK8YHrNKoUOfjiRKh/7CEC92U=; b=mrhaeb+T/SIIYoEllcrxGKc1jjqGpydgzecq43Imy5Oy7UD1xJ5ZjVKZeucTjR1y9R Ch4axRbbD7Vw6VxFryHw1vLmpG5gx1N5yBeJGUV98gU5IGUDPbwFdPu1iE+8h9R3vAef BT1kHDDwzSzRYah8JADtv2j29ecgHdIciHmBH0n1eiAmnNuPuhPsDkHNTa7dHVYPllW2 uAmNlzbfP+Svr0nJNes8kHeIHn2oIDiiX1atR9JX44iDjZbycsleENnVTAOdWp0t0Lwp LVNgNHk9w4DOZAHO7yp2/vNwk/CZjd2XKtszXWCJM2yQIs0orE4yCEE3Nvrc80H6orEE s9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RBA5zwvxY/1ia+fk/xzK8YHrNKoUOfjiRKh/7CEC92U=; b=mqlFS9PgNdKn+DQr1w6vklUsfY6B115kyY1tlWB48uhOAzDWvo5fs3+97zISoLKCeb ay2e2Y1DiMO+r8RxeH0VG+uuHT6etmhYAhu0GixpPBa+PzbEM1fR3VwB611XvL6Vdlvl ezFJVbrsJVIrqGfXAvSWrMImbN1kgIXLz0vhKD6M5gMO+kxdsjveEPCntZUz1Mn9W9T+ 6Cp7ST2Bs7WFG5cDcpsmhWbwm/eRsZVeuprciHFNf+xJZnEFrlvRUPcsiQZJUGuDGpMQ mgznWKhbW+Bw9LptC/+xgD6A5Kf2L1r1f3JNbasNyeOoChs2D83Q90MB9ttt9VVrccdD xA8g== X-Gm-Message-State: AOAM533tzh/Jk5ywHq4WiC5C7A/T8GILO27chGEO0afalnJ6M4LVtcNW JDfjvqXvEmXwcelG2uSRTBc= X-Google-Smtp-Source: ABdhPJyv4gfR0TnKChyY15jeg2ZsvS91QJc36GgO+qjGtG7OfaTaQ0WlLPQ5uAOEYQEjtLrODErihw== X-Received: by 2002:a17:90a:bf91:: with SMTP id d17mr1854424pjs.138.1617777960944; Tue, 06 Apr 2021 23:46:00 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id k4sm2732908pgm.73.2021.04.06.23.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:00 -0700 (PDT) Date: Tue, 6 Apr 2021 23:45:58 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 38/49] staging: sm750fb: Rename function hw_sm750_setColReg to snake case Message-ID: <4ecf65873d119290ba1173e2a1665b91fdaae9d6.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_setColReg. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 8e803b580a71..62c9a8c5de8f 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -545,7 +545,7 @@ static int lynxfb_ops_setcolreg(unsigned int regno, red >>= 8; green >>= 8; blue >>= 8; - ret = hw_sm750_setColReg(crtc, regno, red, green, blue); + ret = hw_sm750_set_col_reg(crtc, regno, red, green, blue); goto exit; } diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index b46d13134f76..71b4ce05f4fe 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -208,7 +208,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); -int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index, +int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red, ushort green, ushort blue); int hw_sm750_setBLANK(struct lynxfb_output *output, int blank); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 410f726b03e9..7eae56b74a2b 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -372,7 +372,7 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, return ret; } -int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index, +int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red, ushort green, ushort blue) { static unsigned int add[] = {PANEL_PALETTE_RAM, CRT_PALETTE_RAM}; From patchwork Wed Apr 7 06:46:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E85C43461 for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3899A61222 for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345378AbhDGGqU (ORCPT ); Wed, 7 Apr 2021 02:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345398AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E59F7C061760; Tue, 6 Apr 2021 23:46:02 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id z12so4771793plb.9; Tue, 06 Apr 2021 23:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RuREhl/6r10Ul/aj5kYlhGySoHbzCHI5JHMjmbOPC1k=; b=mnBY/ZNujoLmuROjHLZ9tSCR/DZDxFQquNW1LET3jthFDTWzg6gex9lffVXFltJP4s ZPZ0tMCROCdMEa/R6DKY3Nbe0A/jt8Q0in3XjQZoa1dh3rOXEEm9F8iLDGVvbhACNG28 k8w2DesvE1+yCySAKzpG+GnsNEi4tDEKz85T2hPOR3GDIMhcTqzZHnztI/O1Ht+WLkBb c6n9xTC/rXdFuJL1Yw02EB8ldI1VkrFvk+1FediLwkCPq3K24sijsGp3IAgNHMCjThKm 2TCqhNV8mCYTOFQu31LpS3Xo3+ozV9m10to76RrBLH2t19Qb4JgzGwtZ8SsRyv644hrY jzfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RuREhl/6r10Ul/aj5kYlhGySoHbzCHI5JHMjmbOPC1k=; b=C0ddMot9G8yzhGV0eKfskTc6KFgEk6rVJM7Lfp/TJ1wusoskiB+93BJvpMaYfsw+y9 Ldr2O4uE3oeOkHKAwdjAb+vzEx/h8AL7NVsOoSk47nVBl7IPcfXrdqDnjy2K6YLYPWZr tcE9Oxv4eITXjTkXubRWwOiv/NkqLk5AGA3SqwZ9qX3iQfo1eHmSZulujs/SwvG2Su73 T1rnSUaUrGndU6qat+Jd9DpwYwL7dtRXAjpq2AAoncZred6UXLRkrblzefbYtA6ZFoob +c2CeI9frSZaEx6Rwokj2PKL8MdARuGDcWPEdVanhWCUJR+nVaD84vViVBaifqZj9AMH yT/w== X-Gm-Message-State: AOAM532qjUmq5s80bv36VSLrg9g2nm8zostr3Sn1VDIZLyldIMXJREsR b6gD77Dk34nxuG+0vO+Quww= X-Google-Smtp-Source: ABdhPJwValtxEqyXA2Z/HAUme9fwOnwBPtVfz9kJYomrVchhuDMQuF2DvVqf1hNjmn4KLPUBIuuGGg== X-Received: by 2002:a17:903:189:b029:e5:d7c3:a264 with SMTP id z9-20020a1709030189b02900e5d7c3a264mr1815902plg.6.1617777962492; Tue, 06 Apr 2021 23:46:02 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id 12sm19779641pgw.18.2021.04.06.23.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:02 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:00 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 39/49] staging: sm750fb: Rename functions *_setBLANK to snake case Message-ID: <1022013daf6d3985becbdab8b59ed17790fec431.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the functions hw_sm750_setBLANK and hw_sm750le_setBLANK. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 62c9a8c5de8f..05f3a1d454db 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -606,7 +606,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) crtc->ywrapstep = 0; output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ? - hw_sm750le_setBLANK : hw_sm750_setBLANK; + hw_sm750le_set_blank : hw_sm750_set_blank; /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? hw_sm750le_deWait : hw_sm750_deWait; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 71b4ce05f4fe..7347be7dcded 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -211,8 +211,8 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red, ushort green, ushort blue); -int hw_sm750_setBLANK(struct lynxfb_output *output, int blank); -int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank); +int hw_sm750_set_blank(struct lynxfb_output *output, int blank); +int hw_sm750le_set_blank(struct lynxfb_output *output, int blank); int hw_sm750_pan_display(struct lynxfb_crtc *crtc, const struct fb_var_screeninfo *var, const struct fb_info *info); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 7eae56b74a2b..87d2b82f0880 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -382,7 +382,7 @@ int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, return 0; } -int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank) +int hw_sm750le_set_blank(struct lynxfb_output *output, int blank) { int dpms, crtdb; @@ -423,7 +423,7 @@ int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank) return 0; } -int hw_sm750_setBLANK(struct lynxfb_output *output, int blank) +int hw_sm750_set_blank(struct lynxfb_output *output, int blank) { unsigned int dpms, pps, crtdb; From patchwork Wed Apr 7 06:46:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFACC43460 for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09C566139C for ; Wed, 7 Apr 2021 06:46:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240581AbhDGGqU (ORCPT ); Wed, 7 Apr 2021 02:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240543AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E767C061761; Tue, 6 Apr 2021 23:46:04 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id i190so3926782pfc.12; Tue, 06 Apr 2021 23:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bzo2CT+YJY2F1z9OlT8tzpIHNon2mF4OUcXaigWQziI=; b=OEtvKnq84mcXwBBifO9jX76kOSHpziONcL5SKzP8vMLgmp7JMbP18Sms565rdCRbAg F74VNu3LB4OKj92SaXLahFRQPMsdBnVKp+pnWI56WwTHALeqkjyxqlHGOLDBvCVt6Ea4 fPLdcaGvQHhrKQYPMu51quOb/Dka/kK7PksE5lPe2GQJbSLXgmKjQenbhCXDwvNH222W owOpH6N9/wPlMh6fp0isjuJx421rgai089408WskSCSJ9fs38RyhQSatoRVoB6/BadRU ZRY24NKce1Nb5TaeeCLY9dmCuvNIZE0h38G6ElF25/kOldIoCSx8i320p0Q8RqgGKmH7 GC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bzo2CT+YJY2F1z9OlT8tzpIHNon2mF4OUcXaigWQziI=; b=FBVt/pkZuXMP16iOc6EnNpIKxjoP0kfXivhlTxPdGHGLSZ5ZSgLvGdyZVysU8K9DJS mZ20yc1bLOCUqjmOjzfvPAmgP3XxikPV4BDQP8BO4JeasGeLBW/Z11LyEZ3w909B51wY DEXJwUaYcp15tAswKBORJlONG7fKp1EBcOB3FvNMdSCv3Z6cHyhMBDO/orhDQhlv7Xvk qVF/SdneflD2Ed5EHZd25BMl6H5d3K07am9kbxB1U/iQmRAeZy7dmjFUWXDtszPoFVY9 0vu0s1O67OVRh8/gy3QO9P+B7WV2kIgkKmklldfBcZbzSnyQBt4xCXY16D45JD+pugvF luoA== X-Gm-Message-State: AOAM533Wb78lN33pcOxxBeKeOJpKm1DFjUnQF4ePucCt3OQ66f2a6BX5 6+1Nkpjn9+BLuihdoJ+vxW0= X-Google-Smtp-Source: ABdhPJz16x0AB9cEwqIJ3PiCLPa295Lf4wEyzta3KqGXJS2K67APQvuWlM4EKvxaAD65pfkEihHHOw== X-Received: by 2002:a63:544e:: with SMTP id e14mr1978911pgm.288.1617777963878; Tue, 06 Apr 2021 23:46:03 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id g10sm19697726pfh.212.2021.04.06.23.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:03 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:01 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 40/49] staging: sm750fb: Rename function sm750_hw_cursor_setData2 to snake case Message-ID: <89daa11a59211c35ddef3a88bf2937a0a3d6946e.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function sm750_hw_cursor_setData2. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750_cursor.c | 2 +- drivers/staging/sm750fb/sm750_cursor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c index 98d294ac223c..3ee3bf78f7a5 100644 --- a/drivers/staging/sm750fb/sm750_cursor.c +++ b/drivers/staging/sm750fb/sm750_cursor.c @@ -132,7 +132,7 @@ void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, const u8 *pcol, const u8 *pmsk) { int i, j, count, pitch, offset; diff --git a/drivers/staging/sm750fb/sm750_cursor.h b/drivers/staging/sm750fb/sm750_cursor.h index af0211242ae8..8a1e81b8248d 100644 --- a/drivers/staging/sm750fb/sm750_cursor.h +++ b/drivers/staging/sm750fb/sm750_cursor.h @@ -10,6 +10,6 @@ void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y); void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg); void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop, +void sm750_hw_cursor_set_data2(struct lynx_cursor *cursor, u16 rop, const u8 *data, const u8 *mask); #endif From patchwork Wed Apr 7 06:46:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E840C433B4 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1DC61222 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345513AbhDGGqU (ORCPT ); Wed, 7 Apr 2021 02:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244668AbhDGGqP (ORCPT ); Wed, 7 Apr 2021 02:46:15 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A17DEC061762; Tue, 6 Apr 2021 23:46:05 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so730111pjb.4; Tue, 06 Apr 2021 23:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sTRc6HlswoGyydauZH0DMBR4btgAttix5SNGQxPT1ew=; b=hCN6Jvlvr0Cy5U3GdI9ixf0wbksuD/gbjt6erm+iwubSjo5xs3jat03k3XWryyQMTV 9VqUvLyXv+jS0m2JBVL+kS7hnZia78fvMhYaTH8W993GJYDBPO3W/QJ5L4KRBqFlNtZC fC4NhlyjlUO5UVQEGKrRDxXXJ1IGvimS0oYBFJmkRetQSqlDslXTmkDRJYSiwKol5srt DQjhhMBCwTDkm6knV2BjYnLfc7Hfz6yQf6zpiT4O7iSHs6En9fI2i0pNT2c+0crjiDt+ ph65aqOR3rNhda+ypS3vforsRLs6NitKKkr+3htyEtW1kEtp3JY+HCa6uImXlPhqnrKd fLQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sTRc6HlswoGyydauZH0DMBR4btgAttix5SNGQxPT1ew=; b=e5TnjgBHgcoALWApkrEDrtv+1o1U2dWzkAenhKFf+5+0mzDMvwqgg+aPYLoRaLd2+s 5hUkeu/x7cOmeECaa9xevbLsXIZaTHj8OVcr7HwmdM116+gK5GHrAVi6fxcKFuYriWE8 p9YpnrYRgsk1P6Apj6QzSFDdb+1+d+LrHT63ylgJiGIYMwQ3mkO7umybiOllOgMvROqL k1PiPrO2Cd4lrEyEZ/9TDU6mVoYvzM3D9ytgAdA5AwnwyoqmtyJ777jExLCIH8q4NaSa ZTFoo4nBKC5VPAY/h4zEw7AoM+c/EEbRC0QUxRW3NHdzDy3D9vZR67PNRzgfOGTSz5TG GYVA== X-Gm-Message-State: AOAM531dmvhN9hIOZMXNxCuP+ZSxxQlsK1/WmzL9Psaey3aA5JHP/wtt ir5HXi970zsVA6wDv4cgSGg= X-Google-Smtp-Source: ABdhPJxyljQWFRlxJtZqw/hZYn1qo52UgdL8HH3oq2aLpC1posUFye0QYm18DMhz0P08sTYZxQPNFw== X-Received: by 2002:a17:902:bc89:b029:e9:2cd7:382e with SMTP id bb9-20020a170902bc89b02900e92cd7382emr1768815plb.68.1617777965188; Tue, 06 Apr 2021 23:46:05 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id 77sm16401786pgf.55.2021.04.06.23.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:04 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:02 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 41/49] staging: sm750fb: Rename function hw_sm750_initAccel to snake case Message-ID: <9eb8aec92dcef358e174d2e2ab90c91373baeefa.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_init_accel. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 7347be7dcded..4f9fe3e9ef81 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -193,7 +193,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); -void hw_sm750_initAccel(struct sm750_dev *sm750_dev); +void hw_sm750_init_accel(struct sm750_dev *sm750_dev); int hw_sm750_deWait(void); int hw_sm750le_deWait(void); diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 87d2b82f0880..db2c87fe7006 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -175,7 +175,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) /* init 2d engine */ if (!sm750_dev->accel_off) - hw_sm750_initAccel(sm750_dev); + hw_sm750_init_accel(sm750_dev); return 0; } @@ -476,7 +476,7 @@ int hw_sm750_set_blank(struct lynxfb_output *output, int blank) return 0; } -void hw_sm750_initAccel(struct sm750_dev *sm750_dev) +void hw_sm750_init_accel(struct sm750_dev *sm750_dev) { u32 reg; From patchwork Wed Apr 7 06:46:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97114C43603 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B69E613E7 for ; Wed, 7 Apr 2021 06:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349159AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243516AbhDGGqQ (ORCPT ); Wed, 7 Apr 2021 02:46:16 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D046DC06174A; Tue, 6 Apr 2021 23:46:06 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id ay2so8843436plb.3; Tue, 06 Apr 2021 23:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=X/1WQUx4h3Us2MWsdbVA8OpNDkB4BtTTjDqsMm8O3ls=; b=LLoGUZhIk6YW+UKKNqOen1oLr0HJDun+yEuhnwfn880onAoEnJfLYW9fYa278+NI6g 7bg2Md5XZwV8f5JJwJkK7jhfXEgDHTYgW03cCEJLD51fISxqaBoXn0aRL4eo7GPGbo9v fko9MRjaIYHZKn8ACTy15FeH8U7DDxTJNbL88RcZKGaBT0qmOG0rDLR3jIoqdCLl9iqa rV50+u4tlHgrZGw4djiaCDiyqRTFtefE52ALQ7MtTPT4vF6ji2i00uYhIiYnryMuBMFD 5XovHaAHJN4GtcEHSK3LaGtp5F65nV6DjVrymT/L0DUYFT7dVjubtHfiFmigfJotZ23S Ii1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X/1WQUx4h3Us2MWsdbVA8OpNDkB4BtTTjDqsMm8O3ls=; b=rwuJBOjEKaHjcBfO+gpI9aKD5H58afy5m48iE6CGtLgvGAfdEFQg2hdHhNZRQrGK5E TTZ9e4gvVlRgkBTL/5cRq+J7AdhDdGEIdxNDoKBK/I66fo6QNMFN6qTWHqzx7IAQdVPm LzqcAXYSQX7A7nK2u4PLP3OxemRT7F3YWv1xix4zVxPqLc6y/X6S0fZ80ZNXy7CzfifU a77H4WNOfkQUTUEIY4xNngxqa0gcr20LYlNs6/46KQXLfp30tCqCqS9LFpuBx5jJQuWH 4MUPYg6sK5pe8sNZDwZcb9cVuWdpHSDfy/f8yvp9/bCIrjOo4RnTc8JWQ8LlzhpeMC+Q 04Aw== X-Gm-Message-State: AOAM5311SaDN21kLnPcX+Tbj6nvK26gUhKobF0Tk7gDzDBq3W1jDyI/a braFbIPlqRsEdgHcxBYd3Z61tnwXAOWW8Q== X-Google-Smtp-Source: ABdhPJwuxcPKuFNIh/WSZFXCdlX40o5XBWVpLkiVk2vc9UmT6PHe1RjKBk1djEeo4HxzN2TX1hQcYw== X-Received: by 2002:a17:90a:e50d:: with SMTP id t13mr312566pjy.160.1617777966454; Tue, 06 Apr 2021 23:46:06 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id k20sm917135pfa.34.2021.04.06.23.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:06 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:04 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 42/49] staging: sm750fb: Rename functions *_deWait to snake case Message-ID: <0362262fbce2e49082f213a9bba06b1ac64a5bb5.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the functions hw_sm750le_deWait and hw_sm750_deWait. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 05f3a1d454db..bb25ab4ba0de 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -609,7 +609,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) hw_sm750le_set_blank : hw_sm750_set_blank; /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? - hw_sm750le_deWait : hw_sm750_deWait; + hw_sm750le_de_wait : hw_sm750_de_wait; switch (sm750_dev->dataflow) { case sm750_simul_pri: output->paths = sm750_pnc; diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 4f9fe3e9ef81..da37fc81370b 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -194,8 +194,8 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); void hw_sm750_init_accel(struct sm750_dev *sm750_dev); -int hw_sm750_deWait(void); -int hw_sm750le_deWait(void); +int hw_sm750_de_wait(void); +int hw_sm750le_de_wait(void); int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index db2c87fe7006..789199e628cd 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -506,7 +506,7 @@ void hw_sm750_init_accel(struct sm750_dev *sm750_dev) sm750_dev->accel.de_init(&sm750_dev->accel); } -int hw_sm750le_deWait(void) +int hw_sm750le_de_wait(void) { int i = 0x10000000; unsigned int mask = DE_STATE2_DE_STATUS_BUSY | DE_STATE2_DE_FIFO_EMPTY | @@ -523,7 +523,7 @@ int hw_sm750le_deWait(void) return -1; } -int hw_sm750_deWait(void) +int hw_sm750_de_wait(void) { int i = 0x10000000; unsigned int mask = SYSTEM_CTRL_DE_STATUS_BUSY | From patchwork Wed Apr 7 06:46:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0F6C4360C for ; Wed, 7 Apr 2021 06:46:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 491B161222 for ; Wed, 7 Apr 2021 06:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349167AbhDGGqW (ORCPT ); Wed, 7 Apr 2021 02:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349157AbhDGGqR (ORCPT ); Wed, 7 Apr 2021 02:46:17 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68716C061763; Tue, 6 Apr 2021 23:46:08 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id c204so8440898pfc.4; Tue, 06 Apr 2021 23:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0In7Usm62iDzXGlWXf0B0UqSRUyq5ZkXwX+9zfXFdWA=; b=f0eEAxBwZAwKyCusdi6rWc6PV83Li0QqWeBqCWFbovV7R7X36fkRlKIauusERa3X6N ZIlMJxAP3oOTwPthCBTn7eMhHQULRSsgnIC6JN7HtzpEZCDbyebtYZORaTM4WvB/QzSZ EQuIVuW9oNztqrYY6IbvGSmHbXjS4bN8n2mBX26eCum5hiO5yZ9Ix89W4tI68Edk2xDW 3WZrjSp6RvrJmMpIS7J+lv5ybyyIuY87EUS/4Av5mCEs9YC8qcVCW2KEfYjM9O7cY9nP 6e9mREzHX0X5788GK+K67oIiS/3yE0XcYEbkVzylDV+gIUjMnngaVRf/wPWNPubphbSD boHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0In7Usm62iDzXGlWXf0B0UqSRUyq5ZkXwX+9zfXFdWA=; b=hruIJUyf8fb2V6weLBBAq87XfRJ1l+99FGo/g5b/geMIEop4RJngihQz47OatxK1o9 tteCvQrGM6rgn7cf+JKnq98QcF6mVzer/k1wY23BXmJV8CCPjisQG3aqndTYR/Rk01aD g6WhrmSNipKQeVsDwc8/akFr948OWyc4o4w3oqvaS9vslsXxhzKQap5etbemxD5D1v7s kk6yKL32ck2iUB2xexbkclO37usSAiHxYaJ0G6f0A0GXUzSkaLdkDY1uoMSGAXkfaY0C m4+d9pJ3CToCDzY7XjunX89S8s9ZutnQgChR3ZljIdnRnZim3qdhCJdr/O1TCc9vIaao zAqw== X-Gm-Message-State: AOAM533RQ8VBbi4XnpjQZsLIv9ITQvQw3F1lu6uO3kciJLJjRDapsE++ VcLPEF6A1diqfJXoGxPkv5gZWxU2wodJmQ== X-Google-Smtp-Source: ABdhPJxysv27ETveWY9+1QtkAc3R4IcuOpZgVZZChEL6e09gINMJcJ08dM2ot+ikFn9ueIvYMXGFvA== X-Received: by 2002:a63:1a47:: with SMTP id a7mr1863095pgm.437.1617777967933; Tue, 06 Apr 2021 23:46:07 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id v14sm4035981pju.19.2021.04.06.23.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:07 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:05 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 43/49] staging: sm750fb: Update members of lynx_accel struct to snake case Message-ID: <52fcfc4480d5ee19f8751dae2d2369a5958fa1fc.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of lynx_accel structure, in particular dprBase and dpPortBase. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.h | 4 ++-- drivers/staging/sm750fb/sm750_accel.c | 6 +++--- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index da37fc81370b..a27aaac5d67a 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -50,9 +50,9 @@ struct init_status { struct lynx_accel { /* base virtual address of DPR registers */ - volatile unsigned char __iomem *dprBase; + volatile unsigned char __iomem *dpr_base; /* base virtual address of de data port */ - volatile unsigned char __iomem *dpPortBase; + volatile unsigned char __iomem *dp_port_base; /* function pointers */ void (*de_init)(struct lynx_accel *accel); diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index d0b64962b10e..6ca2e5265836 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -20,17 +20,17 @@ #include "sm750_accel.h" static inline void write_dpr(struct lynx_accel *accel, int offset, u32 reg_value) { - writel(reg_value, accel->dprBase + offset); + writel(reg_value, accel->dpr_base + offset); } static inline u32 read_dpr(struct lynx_accel *accel, int offset) { - return readl(accel->dprBase + offset); + return readl(accel->dpr_base + offset); } static inline void write_dp_port(struct lynx_accel *accel, u32 data) { - writel(data, accel->dpPortBase); + writel(data, accel->dp_port_base); } void sm750_hw_de_init(struct lynx_accel *accel) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 789199e628cd..97b842148bcb 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -60,8 +60,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) pr_info("mmio virtual addr = %p\n", sm750_dev->reg); } - sm750_dev->accel.dprBase = sm750_dev->reg + DE_BASE_ADDR_TYPE1; - sm750_dev->accel.dpPortBase = sm750_dev->reg + DE_PORT_ADDR_TYPE1; + sm750_dev->accel.dpr_base = sm750_dev->reg + DE_BASE_ADDR_TYPE1; + sm750_dev->accel.dp_port_base = sm750_dev->reg + DE_PORT_ADDR_TYPE1; mmio750 = sm750_dev->reg; sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid); From patchwork Wed Apr 7 06:46:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187159 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4E6C43460 for ; Wed, 7 Apr 2021 06:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48F236139C for ; Wed, 7 Apr 2021 06:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232556AbhDGGqX (ORCPT ); Wed, 7 Apr 2021 02:46:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242289AbhDGGqT (ORCPT ); Wed, 7 Apr 2021 02:46:19 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D7CC061756; Tue, 6 Apr 2021 23:46:10 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id y16so109108pfc.5; Tue, 06 Apr 2021 23:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r/oBzQNuh63hJGsl/KIQufF0AGvx1q5/RmwFtkCNL+o=; b=pJzk1fBbV1MbhZoF8+rV3MlCvT3v6WtiJR+TdKNaJZaKA7lGQQ2pYyfguhIFru8t0s RtXPorljbp3FPDO3/EkZsl5J21bsBxWst7PRsYgfKh3qwdKsIGRaEHHo377LloRocV8h cZ10BLYrQYC+87Clii+JCtBUKYYJ8UEaynXdOsI9Q/kRYI6hc6wYB9YHkw6ER6v68T3z ayFl6/30OWMMnzI+93MXEyRkrEf633fozyr/wJYKVlYlJ7inDn1gDWrgPndH8PbEMTKm vGRd1kHUwLewJB+82qUxBymc8k2uJi7UW9XNRolh0iWRiOzFDlbMuqb9srltUOPLikga Zv3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r/oBzQNuh63hJGsl/KIQufF0AGvx1q5/RmwFtkCNL+o=; b=Y3Qaqq+taNA2xan6QhqgnGyH/cWWS2Y1C+49RmbhrT5YBUq65d4vc3qoxWxXgoimpB flioEW0FzjABSWlojFvVcMs11cvEK6rw2wxcJzi/wfWntpJ+1LqYt8bd3mQEp0fSY1sm T40//yW3etbdBMSkgFlemHTfPywydf+Cm+kLDCdv8N0/kpdQdXzg4MSu3z/w2HXpRImq dW5wmVlAMuvkGR1zZFypOerMILBP6vF0LLToVM8PBPYwBkIaoTg9iRPkSC9DBT8cyqGo 2Xv3xWywBohGp6IhX4sBnYInozBM57TRXHIU+ACXNxBMtGuJdZvjTaA3ld1mXga0QmSZ w3jg== X-Gm-Message-State: AOAM53352ya6zLTb7LxoElmlmDB+oU3pmU9dmbSj2svKKE1RVyKdgDOj wYenStESxbyimItL+4nTjOQ= X-Google-Smtp-Source: ABdhPJw5XIdGszUVi3JOaGNBZJdtQEMf4VsvOZbSVWrStK1FUM+pJHy4cbOkBHrsJRtrgR2Z1mXpuQ== X-Received: by 2002:a62:1a08:0:b029:220:da90:9173 with SMTP id a8-20020a621a080000b0290220da909173mr1682186pfa.65.1617777969605; Tue, 06 Apr 2021 23:46:09 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id u1sm20031904pgg.11.2021.04.06.23.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:09 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:07 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 44/49] staging: sm750fb: Rename function hw_sm750_crtc_checkMode to snake case Message-ID: <34c28569d6d690d72913dfc0347d05f8536c3a9b.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function hw_sm750_crtc_checkMode. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 2 +- drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index bb25ab4ba0de..162eaf08db4c 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -512,7 +512,7 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var, return -ENOMEM; } - return hw_sm750_crtc_checkMode(crtc, var); + return hw_sm750_crtc_check_mode(crtc, var); } static int lynxfb_ops_setcolreg(unsigned int regno, diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index a27aaac5d67a..2e6481809d43 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -201,7 +201,7 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output, struct fb_var_screeninfo *var, struct fb_fix_screeninfo *fix); -int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var); int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc, diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 97b842148bcb..b445f075d0a9 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -221,7 +221,7 @@ int hw_sm750_output_set_mode(struct lynxfb_output *output, return ret; } -int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, +int hw_sm750_crtc_check_mode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *var) { struct sm750_dev *sm750_dev; From patchwork Wed Apr 7 06:46:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7106C43460 for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9E1C613CD for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349163AbhDGGqZ (ORCPT ); Wed, 7 Apr 2021 02:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349160AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BBA2C06174A; Tue, 6 Apr 2021 23:46:11 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so779374pjv.1; Tue, 06 Apr 2021 23:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=87FzL2bfn+zBBigzd2S34Gvtwu79/Sjcc2/CQOxweQU=; b=MubQ22CpAN1kkt6OD34w02Kt6gDd/Mo619issLItehETO7lPL1JJF/cs4ANeT1NBoU f1VNBSl8/PphpLTFZ17sDZz6U5SaCnO3p5ERo4r/NdxT73FI+G8SVh+1ZgqynUpvKMiM omnN9swULQHZ3Gxgvj4Hr0ti3PDqiGeRWtooNlVkVAgiZq5QxjWt2oRSQWGTngviELye lZrMNG0yhvO9oJlsxa5i9Lta35mTEgR8EY72CODyNfXnnw82wE3tQvdtwjEtRCKz0NRJ jAjT+H2Z0dDq/XbQH8EYEiG5MhO6qchB7G5aB0QD/aQ5t1FmAokqRVjPBYClqfgSETyQ HRqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=87FzL2bfn+zBBigzd2S34Gvtwu79/Sjcc2/CQOxweQU=; b=fb/g2iI8Vs46PpIeaDBSqPVvmgyDtXjv7yCFUzc+ZidS5K0JgHxl1qj+TkEnOPpmFX P71korxiybzNSPD62zm+I6DjxWz40B/rF+D5RFVfa8z7OnsbpakJYwFF70rRLwVm3ujy NAn3uP7q7Eixx3EuWwUtHKJVLI+bQHnIvwGCW6nEdybdA8OBm74wSGbPc0hN5SDo19M9 F6ioYLppyJ2Dx02w3Vppn7JR7mqSPywJQVfjDDSH8fBGM61fAJg+GAqloQlT12lizRmw IsnhHAmm0FHEEcwFIqnGk4w1rN+T46gQx0y62hekCE/bEXyQMFeWyH2DAPvovkP+RRLI OxHA== X-Gm-Message-State: AOAM532SZssuKrxDa4DpW4xWfXaU2TnHxW3nOXC6t/jN7Nu2GS36SHiS dRM2J3Pgm4DVYxaBc0+O63s= X-Google-Smtp-Source: ABdhPJxJMLnMvlrNyuI8azlZ4zPLdcHtePAjBxO51e+ihrQaykciRMTvUL0wA7/2BJib4J2hEv5gzg== X-Received: by 2002:a17:90b:300a:: with SMTP id hg10mr1863313pjb.58.1617777970829; Tue, 06 Apr 2021 23:46:10 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id l1sm10927658pgt.29.2021.04.06.23.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:10 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:08 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 45/49] staging: sm750fb: Rename sii164_set_power function parameter Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the function parameter powerUp. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/ddk750_sii164.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h index ac1431dcb419..a414afbb719a 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.h +++ b/drivers/staging/sm750fb/ddk750_sii164.h @@ -33,7 +33,7 @@ unsigned short sii164_get_device_id(void); #ifdef SII164_FULL_FUNCTIONS void sii164_reset_chip(void); char *sii164_get_chip_string(void); -void sii164_set_power(unsigned char powerUp); +void sii164_set_power(unsigned char power_up); void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug); unsigned char sii164_is_connected(void); unsigned char sii164_check_interrupt(void); From patchwork Wed Apr 7 06:46:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC9D7C433B4 for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 842C6613B3 for ; Wed, 7 Apr 2021 06:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349184AbhDGGqZ (ORCPT ); Wed, 7 Apr 2021 02:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349151AbhDGGqV (ORCPT ); Wed, 7 Apr 2021 02:46:21 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 839AFC061761; Tue, 6 Apr 2021 23:46:12 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id mj7-20020a17090b3687b029014d162a65b6so740714pjb.2; Tue, 06 Apr 2021 23:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P81LnC6bDd+byVZVERPQ7nQWM5zWnQv6C3u8NNQHox4=; b=E/aKNJo54FqShHJx/iEwNgesBoUWtnV4rV5+/FCKpMJ7OJWRkUUQztYa+6lP0vM4HS zKerDwilw9VUXXz8iDH3TUbVw8wMRR/GK5x7FPh7LdAqqIxgtUc/KHQ/rPO9vss/t4df NTv70Vvw4mGdRITOu486Th0VF+NeP6o9CvTqogQDw3b6OeckKrXVSWEjX3v6JH1RBifG 3HeXRR07Yge8lEERcWmOnxvt4+LlGoTUz+lph1VmE/s1kaTAvsAXymvk+w5s9xAJsuO8 ZH4rZyezP+3idDHV+KfN70q3ETKGWj0X1xwAknq2tTQ38zPeeN/OzSP1oNaI3EvIwq9t aAPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P81LnC6bDd+byVZVERPQ7nQWM5zWnQv6C3u8NNQHox4=; b=gHZj0rJI0izXw7UsJtTp2r4vMpldiV5MvWyVxRc1QYgbIAgPUIuYzwiIdnX1aXNQdl lB3d/e4UNNZSOkj7UaeLmUo3yATKgNUqcb7SEZ494rz12y7H92imI+eTnsEM1zSuliRR co+//SuiQILMwHGSRp8rOZ/07FYsB6482zprbe7+vinypUlg16Nz7tXQHGIu2Di0hsOo 59KP5Ng7/SioSf2WJu2/sRCkYsaVnxPnhYweoKdhDjgRVaPJi4hqdL6YulxmAqFici6y 2wlMFsz7h6QF9joqkcM3S/14JfZiDuuN/n44knXpj4nRYjqv/r8HeSbjVdmvs//bk9UM TJ6Q== X-Gm-Message-State: AOAM533LDEHvL4zsYkLU2sPuZR4IOZ9c3j5M6zDCKUCCImOSpfAXzFEn qYCsh7th60Ay1bAYZcw6IRs= X-Google-Smtp-Source: ABdhPJw0j67aR86TwFg3HC6ld3mo9/Va/7UbZQl1JhC/sMn28GhNSjjCm7Jp7wz3P5JK3mLKugWfHQ== X-Received: by 2002:a17:902:7c88:b029:e6:f006:f8e5 with SMTP id y8-20020a1709027c88b02900e6f006f8e5mr1839101pll.1.1617777972094; Tue, 06 Apr 2021 23:46:12 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id t19sm21243026pfg.38.2021.04.06.23.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:11 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:09 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 46/49] staging: sm750fb: Rename local variable Bpp to bpp in sm750.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the local variable Bpp in functions lynxfb_ops_fillrect and lynxfb_ops_copyarea. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 162eaf08db4c..937a44530fbf 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -162,7 +162,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, { struct lynxfb_par *par; struct sm750_dev *sm750_dev; - unsigned int base, pitch, Bpp, rop; + unsigned int base, pitch, bpp, rop; u32 color; if (info->state != FBINFO_STATE_RUNNING) @@ -177,9 +177,9 @@ static void lynxfb_ops_fillrect(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; - color = (Bpp == 1) ? region->color : + color = (bpp == 1) ? region->color : ((u32 *)info->pseudo_palette)[region->color]; rop = (region->rop != ROP_COPY) ? HW_ROP2_XOR : HW_ROP2_COPY; @@ -192,7 +192,7 @@ static void lynxfb_ops_fillrect(struct fb_info *info, spin_lock(&sm750_dev->slock); sm750_dev->accel.de_fillrect(&sm750_dev->accel, - base, pitch, Bpp, + base, pitch, bpp, region->dx, region->dy, region->width, region->height, color, rop); @@ -204,7 +204,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, { struct lynxfb_par *par; struct sm750_dev *sm750_dev; - unsigned int base, pitch, Bpp; + unsigned int base, pitch, bpp; par = info->par; sm750_dev = par->dev; @@ -215,7 +215,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; /* * If not use spin_lock, system will die if user load driver @@ -227,7 +227,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, sm750_dev->accel.de_copyarea(&sm750_dev->accel, base, pitch, region->sx, region->sy, - base, pitch, Bpp, region->dx, region->dy, + base, pitch, bpp, region->dx, region->dy, region->width, region->height, HW_ROP2_COPY); spin_unlock(&sm750_dev->slock); @@ -236,7 +236,7 @@ static void lynxfb_ops_copyarea(struct fb_info *info, static void lynxfb_ops_imageblit(struct fb_info *info, const struct fb_image *image) { - unsigned int base, pitch, Bpp; + unsigned int base, pitch, bpp; unsigned int fgcol, bgcol; struct lynxfb_par *par; struct sm750_dev *sm750_dev; @@ -249,7 +249,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, */ base = par->crtc.o_screen; pitch = info->fix.line_length; - Bpp = info->var.bits_per_pixel >> 3; + bpp = info->var.bits_per_pixel >> 3; /* TODO: Implement hardware acceleration for image->depth > 1 */ if (image->depth != 1) { @@ -276,7 +276,7 @@ static void lynxfb_ops_imageblit(struct fb_info *info, sm750_dev->accel.de_imageblit(&sm750_dev->accel, image->data, image->width >> 3, 0, - base, pitch, Bpp, + base, pitch, bpp, image->dx, image->dy, image->width, image->height, fgcol, bgcol, HW_ROP2_COPY); From patchwork Wed Apr 7 06:46:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187165 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BB0C433B4 for ; Wed, 7 Apr 2021 06:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50685613ED for ; Wed, 7 Apr 2021 06:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349168AbhDGGq2 (ORCPT ); Wed, 7 Apr 2021 02:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349172AbhDGGqW (ORCPT ); Wed, 7 Apr 2021 02:46:22 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9210C061762; Tue, 6 Apr 2021 23:46:13 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id q10so12287287pgj.2; Tue, 06 Apr 2021 23:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m074W+fFkEnWYNx+xHLavlSpN4uemXZiY3b+q0HiAUU=; b=FHU0blh6RjBM8BtMRLL9ChwDZ32YGDEWkaMi3L7+Pgl7h99c9/lsrEmPf0k6rnXSxT emdtWz7SMBTt6gegFBrrR8hsNfyrDFLYueDsRVGLqelYXV36q6nC83vgmJspou5sK60D GuJUkhvnKn8HFlLofTUSE3kv6chHp7nuYNKfnmeBpLBz7F1Ji9hXEL7osG1ONDjTImP0 2qj7JnoQ6X5AyxbFR2xtI85PDtsrQVVcXtfWdJin6NmCjYPeZ/WajH820G32HtQV+1RX sdIMI3GQ2/6Q/9N7vORHMsqTkVu1AOipzLoJMIn/5zsjeFgG4xTyuXj5CIG+YyMq/nm8 95WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m074W+fFkEnWYNx+xHLavlSpN4uemXZiY3b+q0HiAUU=; b=gD8SFixC0km3KDP7yu+oMq3sYHJeOgezrips8b7+go0Rg6C9n/rIelL+73LKxkNPTQ zxqk0J32MG6Yrw1c0ww1k/arPgmKmGkkZ/rpCJb6N24dL/lKjZg0m/yswGGxvseRnbIN yIiZodP9ofLZbQ0g2/KU/ZuNLEkJn2lNAn1BpV3R/WvUM7gzgciiMQ2lWps09/ZPF7PE bnUTc26cJp3+Hy38x3OJrdpmWR+1mLVWiZ3wIJt4ayIz/q1eosaoRSsOukygX/8Z3zJ0 R7AyYKDbTmPPinBtUjnLk2Gc0WDmCY9CFBA1hRfRUMZD/7k3i4w4fdB9ZiBvnKP3Y6JX 0n1Q== X-Gm-Message-State: AOAM5327UYhICZWoWnmx3fbtGSlMUWL6RnAF/4t2qpm2b5wkx5JB3CDR vQon3/ym8Ki3oYdr8kIamt8= X-Google-Smtp-Source: ABdhPJx6IPOkk0HkagSvLJIsZglNVauGdjjn7nSK6ZyfeI0lP0SWEnafiKYcC/WDk3q1snSmaBT4TQ== X-Received: by 2002:aa7:9394:0:b029:1f4:2b30:4cdb with SMTP id t20-20020aa793940000b02901f42b304cdbmr1563635pfe.50.1617777973359; Tue, 06 Apr 2021 23:46:13 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id e3sm20476007pfm.43.2021.04.06.23.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:12 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:10 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 47/49] staging: sm750fb: Rename proc_setBLANK member of lynxfb_output struct Message-ID: <4ac1f3b8295e4f6e2c82a2508a0742bf0b490ef4.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl check for proc_setBLANK member of lynxfb_output structure. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 4 ++-- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 937a44530fbf..0c6bfbedde50 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info) pr_debug("blank = %d.\n", blank); par = info->par; output = &par->output; - return output->proc_setBLANK(output, blank); + return output->proc_set_blank(output, blank); } static int sm750fb_set_drv(struct lynxfb_par *par) @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) crtc->ypanstep = 1; crtc->ywrapstep = 0; - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ? + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ? hw_sm750le_set_blank : hw_sm750_set_blank; /* chip specific phase */ sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ? diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 2e6481809d43..06cf136fa28c 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -170,7 +170,7 @@ struct lynxfb_output { */ void *priv; - int (*proc_setBLANK)(struct lynxfb_output *output, int blank); + int (*proc_set_blank)(struct lynxfb_output *output, int blank); }; struct lynxfb_par { From patchwork Wed Apr 7 06:46:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187167 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C0CC433ED for ; Wed, 7 Apr 2021 06:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2A161222 for ; Wed, 7 Apr 2021 06:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349164AbhDGGqd (ORCPT ); Wed, 7 Apr 2021 02:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349194AbhDGGq0 (ORCPT ); Wed, 7 Apr 2021 02:46:26 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06064C0613D9; Tue, 6 Apr 2021 23:46:18 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id i4so317978pjk.1; Tue, 06 Apr 2021 23:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aNs0AO776EogKhlzulOQJvra1//Jd3QrXTsT/Rf44n8=; b=TBa55wJSKfXc31phpjDZmPxaPtI1b8z5bBwBHwO+0yj4x5TkFIxvunTcNiA6hYkcqQ JUAaONr16oyjxRFQ3D9ksDLDrbWKC8d+d9YxugrgnRGLhLftQFIqU+XTQc70HU1a8+jm H0vHIL2+LMdhSX0D9py+KinOQMp6Hqw42sA5uozZExhhk8DqaKZRiYj/BUsLXMpn0Qrf PXh4nVbHRDEpBUlT/sQisCn/FjzIA+BiTNk1B6C5ka5LAMx6czIl4oi+ESKlWrkLVXjp ALdsvgfzXqZF5pZxAmjr3TSSDiWerSSgMiOHRTj3iZrinTp8Nu8QalifcCqZNFJNt+a6 j9Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aNs0AO776EogKhlzulOQJvra1//Jd3QrXTsT/Rf44n8=; b=Kr/yjUpunWVoXhpSysQ3HLkzVH1yH6aEb0pauhfRWP1WhWH2Xkvrrg2ITH1Gri6qyU l8x2nFafPp4wJ9UJ6twD4NZadjzDmwvSH1NEvHTSNFqb4fjNIE3KKRoMrHBlEQSB2vzE v6nOBKuRJH41AvCKDiwx6FfDHHCpHaH3PX+VIGhIwTmjNiQPp+ATFwUjqLS6rwQKMl5s O8XrAYGGhy543vS22VTrPQ/wz54LPJMG9fTUwFgioNfEQGJDq40MqltQh5YSqt4EWujS 6j4U1hOUkN53AuFI136HLsxa2Ae1JbRRimVprJSBqeq9k3/MJDhuK+Y/enDpdlAHq5L3 sVVA== X-Gm-Message-State: AOAM532LNTFbJ9Ph7KX5LDQ3fiBBau/Wm2WMgxszNAsIDXhzIyp/vPr5 +zXW2SC5Qd1xusunm0UQfdl53W/47qf+hA== X-Google-Smtp-Source: ABdhPJxjo7d1CMoBW6P1IsapB0U61Q0/p/IAFor+//t3W48jP0o0jKvZJzh9bR4yn5nq7+JJyZTqAg== X-Received: by 2002:a17:902:c192:b029:e9:4afd:1f37 with SMTP id d18-20020a170902c192b02900e94afd1f37mr1789594pld.37.1617777977596; Tue, 06 Apr 2021 23:46:17 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id o9sm3999643pjr.43.2021.04.06.23.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:17 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:15 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 48/49] staging: sm750fb: Rename fixId to fix_id Message-ID: <65640b7983efc71cd60dbec7a2dd1d6d8c6f4344.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the local variable fixId in lynxfb_set_fbinfo function. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 0c6bfbedde50..946143de11fc 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -694,7 +694,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) "kernel HELPERS prepared vesa_modes", }; - static const char *fixId[2] = { + static const char *fix_id[2] = { "sm750_fb1", "sm750_fb2", }; @@ -814,7 +814,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) fix->ywrapstep = crtc->ywrapstep; fix->accel = FB_ACCEL_SMI; - strscpy(fix->id, fixId[index], sizeof(fix->id)); + strscpy(fix->id, fix_id[index], sizeof(fix->id)); fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start; pr_info("fix->smem_start = %lx\n", fix->smem_start); From patchwork Wed Apr 7 06:46:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavle Rohalj X-Patchwork-Id: 12187169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23028C433B4 for ; Wed, 7 Apr 2021 06:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB8E5613C0 for ; Wed, 7 Apr 2021 06:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243817AbhDGGqz (ORCPT ); Wed, 7 Apr 2021 02:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349224AbhDGGqe (ORCPT ); Wed, 7 Apr 2021 02:46:34 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8733C06175F; Tue, 6 Apr 2021 23:46:25 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id b8-20020a17090a5508b029014d0fbe9b64so727643pji.5; Tue, 06 Apr 2021 23:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8KMjQscDTu2f3qX/EIrSUJ8LapWFh940dfHfctQfV8U=; b=nmYWcmTrl1AUYU22euLKozyZVDSQkPaf4gh4z/xzAbjRtmXsQxuKhSN5PMcavyiv2h T9y28cNGSmLtswteu2JAPwKXUwpReeUKLzIodYygr7FfXtfyhNTnx2/rV+TWer9o0y2J o9gLSnZp7N/gLCxrvDb4ziBC17Z4LQ3dhfxWhjCKEhodfqTOBlYmmpjzPXVzDexQmos4 m1+RIaEd3lvve7s3FmFEP0g7B4+6hrhBbFo+DMHQG9Hnw9lNRKPw4+Yc+S5orEvJrnQH ZrBrNGuW3xUOrvupsTstOdaS+iQ6OqNva9WopXbYVqXmHxf8M02sdxk9BSPqwWIViQlN ytnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8KMjQscDTu2f3qX/EIrSUJ8LapWFh940dfHfctQfV8U=; b=p8HNNx8PEUTsnaYBOdaPeF4FtqaDfNwLatd4JCh+wiHylsBFST2JOJSHZNBQ7uwnEv fMZH56VvlY6InA5eayqgLSWeMMqHDGlNVah9TMApkxt+VRC7kCIb3vhGCRFhAES0nWFF tNxvzhyq/udI4UuHVJNIU8Th5II3xuoTQqKcLYZZUhQ5fTGdoHbWXgg9gFyTMRKc+LWD h3Gi53kBHazjc5003pqJkcJHFxg4OTbioCouB80AOQLhH+367nizciP5oyoFWUOZzzbM qe1trRLGTtqBN+IZzO92UqjfTojJybvKzwBwSxNjWxvXq5gmQtjgiaksF3Yit/uSIKHF YVNQ== X-Gm-Message-State: AOAM533LQdzfQGU2g0YEmgF0qUDRVXNDgXeQuna/JfqrqpkuxseS7e2/ 0tONNRwGXQFXz8b5D5sgQmM= X-Google-Smtp-Source: ABdhPJz1w6XNaPtFfWFzMBtK3MAqep3koqt9yCzs6xcZ4oja/eBFaNTuGevI7KU8w/uF3GmX8g5mtw== X-Received: by 2002:a17:90a:77c5:: with SMTP id e5mr1800883pjs.189.1617777985391; Tue, 06 Apr 2021 23:46:25 -0700 (PDT) Received: from localhost.localdomain ([134.173.248.5]) by smtp.gmail.com with ESMTPSA id t16sm871809pfc.94.2021.04.06.23.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Apr 2021 23:46:25 -0700 (PDT) Date: Tue, 6 Apr 2021 23:46:22 -0700 From: Pavle Rohalj To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 49/49] staging: sm750fb: Update members of sm750_pnltype struct to snake case Message-ID: <5d8d02f140f9ed246cd5a660a06a3f15daa48297.1617776878.git.pavle.rohalj@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix "Avoid CamelCase" checkpatch.pl checks for the members of sm750_pnltype structure, in particular sm750_24TFT, sm750_dualTFT, and sm750_doubleTFT. Signed-off-by: Pavle Rohalj --- drivers/staging/sm750fb/sm750.c | 6 +++--- drivers/staging/sm750fb/sm750.h | 6 +++--- drivers/staging/sm750fb/sm750_hw.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 946143de11fc..c9b17d6ac9fb 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -894,11 +894,11 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) { sm750_dev->nocrt = 1; } else if (!strncmp(opt, "36bit", strlen("36bit"))) { - sm750_dev->pnltype = sm750_doubleTFT; + sm750_dev->pnltype = sm750_double_tft; } else if (!strncmp(opt, "18bit", strlen("18bit"))) { - sm750_dev->pnltype = sm750_dualTFT; + sm750_dev->pnltype = sm750_dual_tft; } else if (!strncmp(opt, "24bit", strlen("24bit"))) { - sm750_dev->pnltype = sm750_24TFT; + sm750_dev->pnltype = sm750_24_tft; } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) { g_hwcursor &= ~0x1; } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) { diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h index 06cf136fa28c..ce02671a1419 100644 --- a/drivers/staging/sm750fb/sm750.h +++ b/drivers/staging/sm750fb/sm750.h @@ -13,9 +13,9 @@ #endif enum sm750_pnltype { - sm750_24TFT = 0, /* 24bit tft */ - sm750_dualTFT = 2, /* dual 18 bit tft */ - sm750_doubleTFT = 1, /* 36 bit double pixel tft */ + sm750_24_tft = 0, /* 24bit tft */ + sm750_dual_tft = 2, /* dual 18 bit tft */ + sm750_double_tft = 1, /* 36 bit double pixel tft */ }; /* vga channel is not concerned */ diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index b445f075d0a9..ad81fd5c33ad 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -136,12 +136,12 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ~(PANEL_DISPLAY_CTRL_DUAL_DISPLAY | PANEL_DISPLAY_CTRL_DOUBLE_PIXEL); switch (sm750_dev->pnltype) { - case sm750_24TFT: + case sm750_24_tft: break; - case sm750_doubleTFT: + case sm750_double_tft: val |= PANEL_DISPLAY_CTRL_DOUBLE_PIXEL; break; - case sm750_dualTFT: + case sm750_dual_tft: val |= PANEL_DISPLAY_CTRL_DUAL_DISPLAY; break; }