From patchwork Wed Apr 7 15:44:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12188713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C7CC433ED for ; Wed, 7 Apr 2021 15:47:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C2F16113E for ; Wed, 7 Apr 2021 15:47:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C2F16113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Ezh8OkDc2xKIVLWlcWYWcziimMN18xPmb77US0VPlZ4=; b=NaF+2YXvCV2U7u g50p+W+2lk6cVGD9EsUOMl5nwGTnM/u3VLyYvqREO5k4YRhyYB4q3ImVVUIlZsHUCesIg0R8udTcc WUfJqB1ffjjTJdDxWssmI60pEFPks2qsMK+HavuiarEv5d2OCsYGt3yHc2LbcarQtTtldh0sXhQyq 02CB0nGHD1bqNTWTUe/NcT/VHLLIOjC71xcTt1+JIRCRwDLQ2QKtavGp67WwUjTkvJbbcYRkVL5pZ P+WSai4phxbfUHhuUJh/Hqo8UgJ10IrpxggtTOgoDvxkN+eF+S9MoOIWTSYm/H5/OLBtenW/KhQlK Vq/tDn+bgTGrGCUgZBGQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUAMU-005JGK-II; Wed, 07 Apr 2021 15:44:58 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUAMN-005JFd-KU for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 15:44:53 +0000 Received: from mail-wr1-f69.google.com ([209.85.221.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lUAMM-0008Jk-VM for linux-arm-kernel@lists.infradead.org; Wed, 07 Apr 2021 15:44:51 +0000 Received: by mail-wr1-f69.google.com with SMTP id e9so11989021wrg.6 for ; Wed, 07 Apr 2021 08:44:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=9EX0oJuIPTlyrUHwCW2RoQVN/W0NPpMkkUa4pAX++3M=; b=Xa5vHGw6XSttKaw01n954B92rtrPuOm0PLQasRqJRDf5mnCtskliqZGoSfmmA1O+g0 iS2w28mXI/BHVrCj6mz6d34FPM0vEp+qUwWDKpiX0a3lDNihpmal5jJg4AGIChwaUzrK MdyX5kbwcDZ1CYsH9IkzotDjoJZulgzEp9Ldq68gq8WWo0VmRebBmqrTJ11Oe75NNo1y 7AXmMB2gyeSNVLBUNuHNerpssttSCB2CAeGWwVUVtRffFNKBNuWIgesHX2/mYR6yLXjY b9U5aJXwbd1yC34pw3KEdYOmrYPH+7qf6AhF9rgGt7jKF8sg46HYeDf0fjLdDmdloQoi UdAw== X-Gm-Message-State: AOAM532srxRIh7ON1FRs1jX4BvySHYi6pYbOIMqHqRehdT9uVK1bpUZb czHdsX4U1q2315KsUDffXlEjoeCPCA2XmDm7RI5VfzB3fM6MJZgHn8Fb9tVbTly1y731a7ma+Yo 3w/e++rsRLybDHRJwuHbfNMxIB9lTW1cs8/2w412x/l8bl9IDkdun X-Received: by 2002:a05:600c:2204:: with SMTP id z4mr3823531wml.31.1617810290750; Wed, 07 Apr 2021 08:44:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7xb9h76f7b9Tp3JA2d38ti9Ye5g/SZvmbRjglwnvmdKmGySLplxEx4QXb1fRjd7imYs7p+g== X-Received: by 2002:a05:600c:2204:: with SMTP id z4mr3823522wml.31.1617810290655; Wed, 07 Apr 2021 08:44:50 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-192-147.adslplus.ch. [188.155.192.147]) by smtp.gmail.com with ESMTPSA id w3sm8644492wmi.9.2021.04.07.08.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 08:44:50 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value Date: Wed, 7 Apr 2021 17:44:47 +0200 Message-Id: <20210407154447.70540-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_164452_056503_088545D6 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If the driver is probed, the of_device_get_match_data() should not return NULL, however for sanity check its return value. Addresses-Coverity: Dereference null return value Signed-off-by: Krzysztof Kozlowski --- drivers/memory/atmel-sdramc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c index 9c49d00c2a96..e09b2617f63d 100644 --- a/drivers/memory/atmel-sdramc.c +++ b/drivers/memory/atmel-sdramc.c @@ -45,6 +45,8 @@ static int atmel_ramc_probe(struct platform_device *pdev) struct clk *clk; caps = of_device_get_match_data(&pdev->dev); + if (!caps) + return -EINVAL; if (caps->has_ddrck) { clk = devm_clk_get(&pdev->dev, "ddrck");