From patchwork Wed Apr 7 17:35:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 12189071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B66FC43460 for ; Wed, 7 Apr 2021 17:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CA8761363 for ; Wed, 7 Apr 2021 17:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354910AbhDGRgK (ORCPT ); Wed, 7 Apr 2021 13:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354914AbhDGRgE (ORCPT ); Wed, 7 Apr 2021 13:36:04 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79666C061761 for ; Wed, 7 Apr 2021 10:35:53 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id i6so24698790ybk.2 for ; Wed, 07 Apr 2021 10:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=BkV3TKwWehfjnaclwW9FgblItKHUQzlZYJ9avEONYz4=; b=T1lZ4yFsqWYvoS1DiCRlCTHKUax+T8YUew0zGHGEepVrf48kgR1ww02JGu4Wz7xGbg KebB325BaJrEXYKMRPblZbXmYieYpbZ9NyspDV9Z7eCu4PcCaux9rKHXFVrkkNkAZcAh o1nxbNyJbYygsw+3C9+6y/LG6S5BFwBz5bV/vtAjwD1olEfHadnfdX5uTCBPRfoQW/pE z39vhTaUASvFpIZZ6/Q9i6OvVQ1pH7lfDpBo9ZtVyKqjL+V3KoiLAqziE98a4a0oXweA 7Tn7Yl+CoR4FedqNprYiztoRanU3dCRerXKdpUVfYOG45l0pArst0TKyu+InPaAp8pKq YpLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=BkV3TKwWehfjnaclwW9FgblItKHUQzlZYJ9avEONYz4=; b=YGfIdkcrRplCLY83k+Bwv+PRaQGTl+h35rCQJkoKqQUoB6YmTkisWp4ctYPYyAGyUk 7W5S7NKZ2of56yEEeDGoHm2ixJpGoOy192K3c7Bxmbdt2lxMboCfOBtvwdR2RQbyRjKC smiTALROxrj2ctW5B14ENwM7WEM58K9X588V3tFcTJf4QaY5c6XZtk7Io1bjISbqprYw LyNRZ/q4RwxPCiArQaGcJznpI5W8uAnay0xPrgjQouup8YOIQfsVUovzulMnVYj6t0op AItQzCjjFOVYarCUG+S5jquriYQHqTFKF44cgpkSC2iHrvXlLGtsPe4DZwnQXZPfam9k 2FJw== X-Gm-Message-State: AOAM532FtBQRA8V8M8zHR68ARUqlyRb5Fojoswv3wh/xjscVxic1Qobv dAnvVXCCfetEGpKEZgJykiCo+WT4IpDr7CEoZ3s= X-Google-Smtp-Source: ABdhPJy42rUOaM03Eh8vBFdcu8xaIMvohagdZNG+SvsZDA51FS/NywIwIVtK3bBARUCNSzyiJA8MLmGmNoXbrOcvVOs= X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:c454:8587:ce1c:e900]) (user=ndesaulniers job=sendgmr) by 2002:a25:f504:: with SMTP id a4mr5740161ybe.364.1617816952516; Wed, 07 Apr 2021 10:35:52 -0700 (PDT) Date: Wed, 7 Apr 2021 10:35:43 -0700 Message-Id: <20210407173543.3598006-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog Subject: [PATCH] MIPS: select ARCH_KEEP_MEMBLOCK unconditionally From: Nick Desaulniers To: Thomas Bogendoerfer Cc: Linux Kbuild mailing list , Nick Desaulniers , Masahiro Yamada , Guenter Roeck , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org While removing allnoconfig_y from Kconfig, ARCH=mips allnoconfig builds started failing with the error: WARNING: modpost: vmlinux.o(.text+0x9c70): Section mismatch in reference from the function reserve_exception_space() to the function .meminit.text:memblock_reserve() The function reserve_exception_space() references the function __meminit memblock_reserve(). This is often because reserve_exception_space lacks a __meminit annotation or the annotation of memblock_reserve is wrong. ERROR: modpost: Section mismatches detected. Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. allnoconfig disables DEBUG_KERNEL and thus ARCH_KEEP_MEMBLOCK, which changes __init_memblock to be equivalent to __meminit triggering the above error. Link: https://lore.kernel.org/linux-kbuild/20210313194836.372585-11-masahiroy@kernel.org/ Fixes: commit a8c0f1c634507 ("MIPS: Select ARCH_KEEP_MEMBLOCK if DEBUG_KERNEL to enable sysfs memblock debug") Cc: Masahiro Yamada Reported-by: Guenter Roeck Signed-off-by: Nick Desaulniers Reviewed-by: Masahiro Yamada --- arch/mips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index e9893cd34992..702648f60e41 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -12,7 +12,7 @@ config MIPS select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_HAS_UBSAN_SANITIZE_ALL select ARCH_HAS_GCOV_PROFILE_ALL - select ARCH_KEEP_MEMBLOCK if DEBUG_KERNEL + select ARCH_KEEP_MEMBLOCK select ARCH_SUPPORTS_UPROBES select ARCH_USE_BUILTIN_BSWAP select ARCH_USE_CMPXCHG_LOCKREF if 64BIT