From patchwork Thu Apr 8 11:02:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 12190635 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFC4C433ED for ; Thu, 8 Apr 2021 11:04:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F3CE610A8 for ; Thu, 8 Apr 2021 11:04:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F3CE610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=nfhK3cUt2C4jHq6y0Btz1P2/Ox65ajKo8mMGekBRsrY=; b=dZQ02AlUonNeVfwkJcSPiab4RC HIoIc2UzkTTSDS/uUU7fRfYPa1FCh0NmE9GfiAwHEvO66x0hDO7TFYaL4bWL1ieHzznBnUFAmGkmn aLqSb07d2jWzhS8ewuvmePmjxWNl/EjwdNfuXabzJLIS48JZ8vaDsep7iTWzsj4yVxJU5M9LfsVxV NLywuLsgaiVwsHBLejFmc7I//IXuKCf++0o+UV+/cujFtkOGFZMahgR3L9BMmXB1KhoYNG6X0o/2N PI3l3lIsKkp1IBk7uFls1nfPwOuAGnxBuah7rqn0MqdjPjOaj0ITD0Y4Xm/7UITNgMvKaxrjjOLuU W8lcqnHw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUSR4-007jjL-4c; Thu, 08 Apr 2021 11:02:55 +0000 Received: from ssl.serverraum.org ([176.9.125.105]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUSQf-007jeG-Ha for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 11:02:33 +0000 Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 3C95B22234; Thu, 8 Apr 2021 13:02:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1617879746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=SUxDw+DpTluQprPfBQeKr9XZNXZmnB1MAnzFLLh1p50=; b=bAwQLlvy9SWSTPcEJEN/ST4cpl7Rw8AO/jllyrRNyojdNgjnrs4maxj92n8Aui4az5Bkef gWw6kif0w+Nt/pvh0Bn8Hixe8uHoo+GX003CWEyqcW+f6S1XrfFGH6VJLBih58kTTV/sa/ ll72odXz9HMYnKfMSYzKF6Jal/FdTi4= From: Michael Walle To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: Shawn Guo , Li Yang , Rob Herring , Catalin Marinas , Will Deacon , Michael Walle Subject: [PATCH 1/2] arm64: dts: ls1028a: fix memory node Date: Thu, 8 Apr 2021 13:02:18 +0200 Message-Id: <20210408110219.20149-1-michael@walle.cc> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Spam: Yes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_120229_759677_3C398C57 X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While enabling EDAC support for the LS1028A it was discovered that the memory node has a wrong endianness setting as well as a wrong interrupt assignment. Fix both. This was tested on a sl28 board. To force ECC errors, you can use the error injection supported by the controller in hardware (with CONFIG_EDAC_DEBUG enabled): # enable error injection $ echo 0x100 > /sys/devices/system/edac/mc/mc0/inject_ctrl # flip lowest bit of the data $ echo 0x1 > /sys/devices/system/edac/mc/mc0/inject_data_lo Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC") Signed-off-by: Michael Walle --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 9506f0669ead..040a3e529bf1 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -197,8 +197,8 @@ ddr: memory-controller@1080000 { compatible = "fsl,qoriq-memory-controller"; reg = <0x0 0x1080000 0x0 0x1000>; - interrupts = ; - big-endian; + interrupts = ; + little-endian; }; dcfg: syscon@1e00000 { From patchwork Thu Apr 8 11:02:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Walle X-Patchwork-Id: 12190633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF347C433ED for ; Thu, 8 Apr 2021 11:04:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F81961106 for ; Thu, 8 Apr 2021 11:04:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F81961106 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=33KPCRijgcoBIuP+KyXT6uMqE15m83Ki26Tn2GNBT3E=; b=EV6VTD8ce7bpllBrPUZFBqhhv NCaj963HoShzZghPQ77CIVn+Y3hJRh+/rh4pf2PZBaGtY6Md865gPADM5n/5GTeHNmTloDgjGV4zT WPZ0pv+IWbQ5ezk7TYGllyLkYSWV17cJClNO3t8SpO7Kox1sYkL3Yb52E4J5NPAqxyNkwWKTIbYCg 8Go55vZxRVXfGjC2OQWeqV+9EQAqvYqYd8b5hIPPI5r4YvlyAuClwNhARDgmNZ0w53pSrPRMXM+66 Dvl1E4+AYk61NC7RfAQGIvw1V+FfboR1R4SOMoTI2bePycvU2CnJ1hXeX4OA9qDmnvKhvY1W/cuSZ DIE2qfgSA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUSQm-007jgJ-CH; Thu, 08 Apr 2021 11:02:36 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUSQe-007jdU-8U for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 11:02:32 +0000 Received: from mwalle01.fritz.box (unknown [IPv6:2a02:810c:c200:2e91:fa59:71ff:fe9b:b851]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id F1D222224D; Thu, 8 Apr 2021 13:02:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1617879747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=biHq6sbjGE96pYmKiKZd5FxjT6rERDkBpqsoByUxslM=; b=iwL4uFOz+WUXFohE8mGGMgOQa9z6uLkiJBSNQDPDDPHX7wAW3DfsnrojsHuOjxNgmCTsKX HRfhaV3mgu6raQoZs0aEJQsuLsEF92HwmGGpiZiLItg627OShaTvinCjb1wQRYVHfBnbYt D2XcMWm11gZHiaRy5JL0rJ12YZjDwlY= From: Michael Walle To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: Shawn Guo , Li Yang , Rob Herring , Catalin Marinas , Will Deacon , Michael Walle Subject: [PATCH 2/2] arm64: defconfig: enable Layerscape EDAC driver Date: Thu, 8 Apr 2021 13:02:19 +0200 Message-Id: <20210408110219.20149-2-michael@walle.cc> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210408110219.20149-1-michael@walle.cc> References: <20210408110219.20149-1-michael@walle.cc> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_120228_871250_B98BB70B X-CRM114-Status: UNSURE ( 8.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Most Layerscape SoCs support ECC error reporting for the memory controller. Enable the corresponding module. In particular, this will enable EDAC support on the Kontron sl28 board which comes with ECC memory. Signed-off-by: Michael Walle --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 99e8a8fb5b4e..c7a62bc6df7c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -883,6 +883,7 @@ CONFIG_LEDS_TRIGGER_DEFAULT_ON=y CONFIG_LEDS_TRIGGER_PANIC=y CONFIG_EDAC=y CONFIG_EDAC_GHES=y +CONFIG_EDAC_LAYERSCAPE=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_DS1307=m CONFIG_RTC_DRV_HYM8563=m