From patchwork Thu Apr 8 17:54:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 12192063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44616C433ED for ; Thu, 8 Apr 2021 17:57:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD97D6112F for ; Thu, 8 Apr 2021 17:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD97D6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bwyamiACSCoeGrWkOevfDg+twLcNsM+8h2T+XS0GQeE=; b=ZewyCdh3LHi/AsqGrJHYFCfSo KMMA7vMom6XZxrfV/iRrLcaUFAQ72keyv8stWZGf+M2otTgl87oTr64/J09bV5RNcrWBVT1EgFHUC ZcUM1aQzvPCm+vc7albwkeEcF4z3tw3C1HuoCiNzZkLQbgdnrSLswX/aUm4socM8dDTbSZpUdnx8A AD3vi941DUe2ubP4QE2bBhRwEuM5bLnB3GOynzkuQNMstrqXAM9P23lwEEHCDt7QQwBbkUFSvxQ5L DIYAn0iKeHmzs+Yp+Z6ITHLp1icb6oXTh1ksV3LPDZ6jv479vQaP9kcH/ympWLRF9floKPPqF2W78 ZMG33kCvw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUYru-008qCy-Hd; Thu, 08 Apr 2021 17:55:02 +0000 Received: from mail-dm6nam11on2042.outbound.protection.outlook.com ([40.107.223.42] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUYrp-008qBh-BT for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 17:54:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JVZF/Y2rIV7ps0Wvf+2YQOfmEW8sAVvERP+Ffpy5F9EALX+C7QiQR6MlVJeduDq5FgUeWF3HyepPasZ7VV7DiuGuBhxapt0riWwOdjJo+uwLGdeE9QERTlf3ySTlsTaHHXQK6AK0vM265M+52tke5etzqu+RYEPr7dFG341el/aX7Qul+KXzmmMw0PzqXNx+MEi39RS7oNjYv7qKcd1Izf4+b5SzSe4Q/f084IRtYPKgZBYg/PBZTLi/xC3i75nUWRsgMuEXHj+ZosyKc/SHyBBHRCJoh7c5f0aEPsqWjrpoWYW56hlT7SYsbMrpoKR1ApfKYvhW6oor7h5lawlcqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtJgc4drPnHtAFZUQWQvtsu8PBmkm4Yj3FUOwq+uw24=; b=ftelx9XY7IRsP4azUtKSg9SpjDm0BRu2Etnr/62DHmzKVclXemiU/YrWBi6TGBybkK4aGlgBHrBCogBaZLeunYfDpMrrHSkc70iJ+OTRVFaxCQfMC2TawoVUUI3SfkPizN66DPIzrtQKiadnuiQa3ZK2jyiXAETgYEYdDdXiDYFXnHWYkaTrgnhzDTDQKGqiYug1aS8pyHa20S+BNHuR60llnlgUYNklC0pYYjGJJnzVP8OFUUC+YZiqFjfegHGRvhjTFOfqN6pQMK3anr7VL0hbfWb64naE2Uhmm2SN2wH64lLTzOu/IZUZcRI2ycqiJGm0U8kxs2t6HmPlHA9R7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PtJgc4drPnHtAFZUQWQvtsu8PBmkm4Yj3FUOwq+uw24=; b=nPwG8FY9da9xpAZgs3uX0QiaasTHBvX/VcuMiVuGaYvUsZ79RFApmhKWqsKtrLSSWYHlFbCYLxCMbk+tUmozYKGgrK1T96U0XqJ3znYq3HrWWEhxO4rSJjtwb6jXJTNmLrcbw87pDZi8af51z/1GD7g0uA4p0nQ2sfD5ys8QPDM= Received: from BL0PR01CA0023.prod.exchangelabs.com (2603:10b6:208:71::36) by CH2PR02MB6168.namprd02.prod.outlook.com (2603:10b6:610:a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 17:54:53 +0000 Received: from BL2NAM02FT019.eop-nam02.prod.protection.outlook.com (2603:10b6:208:71:cafe::53) by BL0PR01CA0023.outlook.office365.com (2603:10b6:208:71::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Thu, 8 Apr 2021 17:54:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BL2NAM02FT019.mail.protection.outlook.com (10.152.77.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 17:54:53 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 10:54:34 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2106.2 via Frontend Transport; Thu, 8 Apr 2021 10:54:34 -0700 Received: from [172.23.64.106] (port=38715 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lUYrR-0002iP-35; Thu, 08 Apr 2021 10:54:33 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id D7BE212123D; Thu, 8 Apr 2021 23:24:22 +0530 (IST) From: Manish Narani To: , , CC: , , , , Manish Narani Subject: [PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver Date: Thu, 8 Apr 2021 23:24:07 +0530 Message-ID: <1617904448-74611-2-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1617904448-74611-1-git-send-email-manish.narani@xilinx.com> References: <1617904448-74611-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 837e1236-a659-494e-a9d0-08d8fab769c1 X-MS-TrafficTypeDiagnostic: CH2PR02MB6168: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GRBdkHdUUgqNrcBqq7t2rW6/pbEGV1/coNdqxzuBT8JCbR5c8RwPpSrz+s9KZ+sbhdxRVXoR5ZPvtM6gEm/b7Qn8BVmpjdJAMZkAMVxAEZlyc+fRR/BrvJgap/13WZ4YJxjaf8DZ+wEvCIGtVSyUBuIs5yo/Lf7rJEAB364Ucaw7aWEDQ6FLotWkJulUraMu1PcvnuTxEH666b8GY85j9cjvBi4GR7v16wNID7I4eHv38jk+tPfKa5RiRkvM91E2h5mptwe0sP1s8h2DMhovU8NiwYSWyQxU7wOqhPPJngayTl8feMa6bRzim+837lYmw4afZt+C5m+wssZmg7WKauR7uG3veVW/XwMQMRIitoOdMPq4er0SWe9JiaiwgPR3NF2i3KPvX+X42gwvgi6mbAX+JF/Ox42pe2N022+y8w0bCqr+3N6G8pscxIoz7AU0Aa6P/UhUBknRPGbuHr0WbohiZVH/RsDgp3Ed9rjLzKd6uOmWu40KALZ/gx+3y0RAK4roHydrM1+7afQJh5hBkqD5zwOV8vsL+FYxwqckPFhJSU/iujKvSBkJWEt8rUbGYM5+tAU/LasnDPA0QRbjppEU1WbxI6GdKDaFTj7ZxOsSrVzDoq1x4yH58Xwfd51Jwwjj2xPhCd7eS/lJ6SnwLcyo2kSIqRtNqLbKcR9ikUTOj0kDC3n4GMQ9ZoUkAGMD X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966006)(36840700001)(83380400001)(107886003)(8676002)(478600001)(8936002)(82740400003)(36860700001)(2906002)(2616005)(336012)(426003)(4326008)(44832011)(6266002)(82310400003)(70586007)(36756003)(186003)(26005)(356005)(7636003)(6666004)(5660300002)(70206006)(4744005)(42186006)(110136005)(36906005)(316002)(47076005)(54906003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 17:54:53.1786 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 837e1236-a659-494e-a9d0-08d8fab769c1 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BL2NAM02FT019.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6168 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_185457_653355_137AC8CC X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The kernel-doc run gave a warning for Xilinx DWC3 driver: drivers/usb/dwc3/dwc3-xilinx.c:27: warning: expecting prototype for dwc3(). Prototype was for XLNX_USB_PHY_RST_EN() instead Basically it was due to an extra '*' in line:2. This patch fixes the same. Signed-off-by: Manish Narani Reported-by: kernel test robot --- drivers/usb/dwc3/dwc3-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index a59e149..f42f4cb 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 -/** +/* * dwc3-xilinx.c - Xilinx DWC3 controller specific glue driver * * Authors: Manish Narani From patchwork Thu Apr 8 17:54:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Narani X-Patchwork-Id: 12192065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4CCC43460 for ; Thu, 8 Apr 2021 17:57:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D35361105 for ; Thu, 8 Apr 2021 17:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D35361105 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cZ99aCIghZhQ8TgvkjM3Y9QOUk2FppibhZTDBTTZq10=; b=MJ0o8VxBjfaUFtEUQ3P1VIJd7 qABiEEV3ruFiJr0Lg3pkkUinule3TpYCWsBxNfzZ/C3sHVxfRhyZD4xhr40zPus9laLfLq4FB9IKp OVCJL300OZF63GQ4syqhOuElueuzfmgAfOvuLtrMujcGI0TkGk90byvyLaNcibn8SmHDGwdIWqPlW t17TYjNiwaPV351YNLUxwPmSZh3qUsXDluI1Lm7WNurBIiEzIQx8ANsVgp901baGHBT3AxtG3/AxG dwz8N0FczyzyOtsVgbIL4v6cSquv18zHvmKWbVchK6mL4hs5Bp5YUnv8aiEkEQ87+mTOXNrTwZdPq /gJcKPH2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUYs9-008qFo-4x; Thu, 08 Apr 2021 17:55:18 +0000 Received: from mail-dm6nam08on2084.outbound.protection.outlook.com ([40.107.102.84] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUYs4-008qEE-Cd for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 17:55:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTL1eZ/PAA0zI7hF5NDjkUElSCQMtmxo0JcHCVUy6fygDgZigOU/XZrdQA0i8MLyIgZBvNk+/sgpKAR6DUKrm2aOKyBwkw7y+Uj85xw0Rx0zZS1ebpsKwAhr8CVVW0HXkCzri+YNnmjj9UvhhanbYywZXUMTnVwFeZK1O21WLjyVAqYg7QEdKCzgE2+X7RLsorWvC3pyoRIGCh8Y9Wo47GDUZSn32fbngNzKlHZT/5qhyGhfbfP9TBR8Xo/p2ylYOFnB9u10Iu9y3EMdCjpECh8IN7PAdUxYNgJeXD8tLM3T2Wg/p3R/YMdhUBCW5OJf9g30MhLSS8OgUjEz0ZzAgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m5BQWPUZ7GBSzUV1wg/QTKwT4E5dhO4twiw5+yNB2RA=; b=MnQ8ks8iE1FE0iSfbSOxbJe8zRA8snl7gNcUFirYBgzdJF2XWsFKrgfo7tOnuyrUo4IxF2AqNcKVWuBeHAHrqRTOWtAqftSBQakfhXyxpzXDshOLKK+K3Rl9VqN7zTrmBl/e1+RGF3vueHTsVQLyVNj00ey9yKyXk8IxospDvahoFmAtkqrecwUXeWPHfTy6rGPaeK+eJ7CAqIp2R9NSLDd89xdnA3rnL2nDiD2zrvAQT4tq2EiSF/1HTJ7kQuayn2lWbCPm0ObzpZEO8/dldP7mACC1jLjoe54NSgXny2/HcGgAu28bf5W7SX0RFjLkfi1Z0beLTSG2w6QRWVCwFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m5BQWPUZ7GBSzUV1wg/QTKwT4E5dhO4twiw5+yNB2RA=; b=jOxpl9Eos0J1eeFre9fa7f75fHSki360sW6Q7CGApXOYzbTEfDj8peXbKq201+paNR20IwnEelNdqxq4qfIJr2rFOHPfawRav8Krf1/LIWzR6lkHxCAsJ0FfVZJsN82JKmKcEIqXNAv3kOT0pWMVW6koZRLdRb6O0gr3igrEdZo= Received: from SN2PR01CA0033.prod.exchangelabs.com (2603:10b6:804:2::43) by CH2PR02MB6837.namprd02.prod.outlook.com (2603:10b6:610:ae::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 17:55:09 +0000 Received: from SN1NAM02FT050.eop-nam02.prod.protection.outlook.com (2603:10b6:804:2:cafe::17) by SN2PR01CA0033.outlook.office365.com (2603:10b6:804:2::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Thu, 8 Apr 2021 17:55:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT050.mail.protection.outlook.com (10.152.72.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 17:55:09 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 10:54:47 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2106.2 via Frontend Transport; Thu, 8 Apr 2021 10:54:47 -0700 Received: from [172.23.64.106] (port=38719 helo=xhdvnc125.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lUYre-0002jP-65; Thu, 08 Apr 2021 10:54:46 -0700 Received: by xhdvnc125.xilinx.com (Postfix, from userid 16987) id 5426912155A; Thu, 8 Apr 2021 23:24:23 +0530 (IST) From: Manish Narani To: , , CC: , , , , Manish Narani Subject: [PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks Date: Thu, 8 Apr 2021 23:24:08 +0530 Message-ID: <1617904448-74611-3-git-send-email-manish.narani@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1617904448-74611-1-git-send-email-manish.narani@xilinx.com> References: <1617904448-74611-1-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 844a859d-9b1e-418f-def8-08d8fab7736d X-MS-TrafficTypeDiagnostic: CH2PR02MB6837: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: irTnSky9qVGQ1ioXYLkKr39KCpdMXYBf/sye9aH/+V2V53FvC6fkHFlI1T0jEfJFo8xvZN82WzROQIo6qGccAQF3rwYfsxxF5VAlQGiyTiAemVqotzXlGgk/POCqFVMpYxNKEJrzldCc8zoGwXDX8OkNc8EdyTOrbftqQrp/qN9xldcbK24OdiussUaBeReuQGebbqgVi3AsJouNGWw/8bDyULorjBfzxZRtVeSU/mhQLPlP6SxVMgTxcd6KGKd3iqWcPYDkYQtmaRa5qdLvQEYOW9rtjGa+GC7InxyGJxtZtwrgfCWEWmHuUAkdZEB7YdMhguMrCWHACD0WcFTmViro4wT1+Mt58pzpuSQ3ZrJvmfRYX7NImcWeCVS5peqWauG4dEKkaTdOxhfnnfLojvFSr3rQxz2TMGbphs1/KmMds1jdhNWEx4d8S8iMH9KyVwMz3e8IrERbchSXMc4CJQwUGxk3B5vw7EoxxXvrI2h3iISEsWBPPy2ozlseOFZdqNLOH0JIqrlh4RNhyC5zG5d22g18DJWI9/16v0slfxvS71vD28BnSIK2wOdPjIyxsykUpogTKXPas/fjFfHjbqkiISNrEAFuF9Aht8x8dgrS+f/rJlflL8cX34D55IOK+X+Qgtgy45Pnb1WGlaWN/ff0ylktym+h7fgNJuUL4BLXFJxcJnWzZuuQorvro9a7 X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(136003)(396003)(36840700001)(46966006)(8676002)(36860700001)(83380400001)(70206006)(70586007)(2906002)(6666004)(107886003)(6266002)(36906005)(47076005)(26005)(54906003)(2616005)(426003)(4326008)(82310400003)(316002)(44832011)(36756003)(42186006)(356005)(110136005)(8936002)(478600001)(82740400003)(7636003)(5660300002)(336012)(186003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 17:55:09.4665 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 844a859d-9b1e-418f-def8-08d8fab7736d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT050.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6837 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_185512_757365_602D2B06 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The clocks are configured by devm_clk_bulk_get_all() in this driver. In case of any error the clocks freeing will be handled automatically. There is no need to explicitly free the clocks. Fix the same. Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms") Signed-off-by: Manish Narani --- drivers/usb/dwc3/dwc3-xilinx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index f42f4cb..9cc3ad7 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev) err_clk_put: clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks); - clk_bulk_put_all(priv_data->num_clocks, priv_data->clks); return ret; } @@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev) of_platform_depopulate(dev); clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks); - clk_bulk_put_all(priv_data->num_clocks, priv_data->clks); priv_data->num_clocks = 0; pm_runtime_disable(dev);