From patchwork Mon Apr 12 12:32:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 12197917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C45C433ED for ; Mon, 12 Apr 2021 12:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D16161288 for ; Mon, 12 Apr 2021 12:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240959AbhDLMc5 (ORCPT ); Mon, 12 Apr 2021 08:32:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239061AbhDLMc5 (ORCPT ); Mon, 12 Apr 2021 08:32:57 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BE9BC061574; Mon, 12 Apr 2021 05:32:39 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id b139so7620089qkc.10; Mon, 12 Apr 2021 05:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mA58phHCIh0Fa6R2ws4D2uh9fwyQMsDVNdVth2KiCIY=; b=c6kaqcuTHS1/9SLVDIAXUxG5NHciZc0wUgbJYgFrvtbINty94AlexqXnaYC5HqISDi FUmVUobfAZcbeK8aV7iXtiPjwyT/f6Ac4UiEQYUP+u/KJOiKFW+h2WPp6LoMTIuCkym8 cSZIdGTJ0AhJ8M/5O4N39UdJ81NJAVhhveA2Aje21J2hYMWT484rrFu6dJAPaRMXUgcK vid/w7HKTpyj7HNgPWhXAx8f+jAYel1OzvsP4nO9Tc9FAnq5Se8dv1zeLzPbLy3MmYTz My5REGKsMYp5PIHYnMuALKgN59ytobrrteqh29FWtgdhbm7QVr1ZG7NL9GxthIAwoesg bF6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mA58phHCIh0Fa6R2ws4D2uh9fwyQMsDVNdVth2KiCIY=; b=iEibrzYBHXuMNU5Px5U5N7+poKmVAGTkDXagG2P/lLIXaK+DWgjzKxxjOvASk71u+f 05xRnc4EpfompIMARucdVfY9pUdehshJUxcq37iMCHsdB6a5NIg7v+NQwtPpWOLTT8GF DlMGxuONbVDHvjMOYxrQ+GezAytKPeHt+qZl/CVLnoioUiJLZAF+btFgxAqprBGYpp01 lE9OjLbIpHs4xJPrwRNSB4YA5ii/MzeyQ72iSaCm78MxE/A1uhgXdWpx+X3w8sIh6Guw PgsmUFgx96mF3h3oGyReHyA6HyZvBNX2ly7nM1gn9i6MsXuQ4uWKokA9ZIaO0mrTjLsY 3/nQ== X-Gm-Message-State: AOAM533c7AFAV7JEYSHrC7ew7ge9NCke4pHtocuOu+TMJPtggy+D56YK 4DQvXNTryslxMZnwdTXO7GY= X-Google-Smtp-Source: ABdhPJxQEao5wGjpEmTQoa9QbrprmuIkT6cZTAAZsPz6CEg0q/anF4HvSiA0699g0JB7y9kbvm9njQ== X-Received: by 2002:a37:a485:: with SMTP id n127mr1124762qke.454.1618230757975; Mon, 12 Apr 2021 05:32:37 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id m14sm7101397qke.107.2021.04.12.05.32.36 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:32:37 -0700 (PDT) Date: Mon, 12 Apr 2021 09:32:34 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 1/4] Replace macro function by static inline function in file iss.c Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro Reported-by: kernel test robot --- drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index c89f268a..3bbc39e 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -27,22 +27,24 @@ #include "iss.h" #include "iss_regs.h" -#define ISS_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)) +static inline iss_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name)); +} static void iss_print_status(struct iss_device *iss) { dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n"); - ISS_PRINT_REGISTER(iss, HL_REVISION); - ISS_PRINT_REGISTER(iss, HL_SYSCONFIG); - ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5)); - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5)); - ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5)); - ISS_PRINT_REGISTER(iss, CTRL); - ISS_PRINT_REGISTER(iss, CLKCTRL); - ISS_PRINT_REGISTER(iss, CLKSTAT); + iss_print_register(iss, HL_REVISION); + iss_print_register(iss, HL_SYSCONFIG); + iss_print_register(iss, HL_IRQSTATUS(5)); + iss_print_register(iss, HL_IRQENABLE_SET(5)); + iss_print_register(iss, HL_IRQENABLE_CLR(5)); + iss_print_register(iss, CTRL); + iss_print_register(iss, CLKCTRL); + iss_print_register(iss, CLKSTAT); dev_dbg(iss->dev, "-----------------------------------------------\n"); } From patchwork Mon Apr 12 12:32:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 12197919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91122C433ED for ; Mon, 12 Apr 2021 12:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 639A361352 for ; Mon, 12 Apr 2021 12:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240981AbhDLMdB (ORCPT ); Mon, 12 Apr 2021 08:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239061AbhDLMdA (ORCPT ); Mon, 12 Apr 2021 08:33:00 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F624C061574; Mon, 12 Apr 2021 05:32:43 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id d15so45599qkc.9; Mon, 12 Apr 2021 05:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=alZ/njDA6kDUiXsUqrZlj3PHW2OGA8s+7K/9VZo9fWw=; b=IrB5OOVtvD+sK7NlIiEoVjBIDu7KE6eRZbHqC99ISyF78e8bvtg7Wew06Cd70O12dw 7inwuWxyECY6katLBk3CE7xbmI9Z+Z5RoM3v+CLXB1Qh+KWQEUeZC1TzQm4opMCg9z2l zDq37qo2QVPPZov/OYT83cej5jSStyjWXwyKBB1l0/0QBheLuveOdcTvgIZdN1BP7UE6 he09QLNRLTqYXbdUl4fsxCZVesJCHlDQBOCSUpQyzSmrLE0rtxHkVY8tRzk3n8bz2DJ/ zvmuLrWWiCTCfeGXWhwEKQ7yiJFcjuZnH7TZe27wtZVr4kMd8UjVHNIdrKW9noxS//Cz EHzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=alZ/njDA6kDUiXsUqrZlj3PHW2OGA8s+7K/9VZo9fWw=; b=J6n861+dM6Pw8uuXRnu5SbgK4ikpBtu3sXPIrozYFjEGRgKhH3AGsaab62tQWX0hYS kkaTd7fyO5OjTfen4C0Uxo1axbl0yOi+q0SE8M1X59UBq9FyziMz+h3zUUjBS6xy+/rb shZ9etAK6M+U+iRiNEjVdY9iuV2gorqONi3+ttBJ46s0gu8Xzm4ku+WfuaTuxBEVeTYg gygxbpPpdI4W6X4kr4MTlMoQxfCQ1sS9vN+krQyjSwPFcdpPZHONBMx0EULRN811vk9O fJSrakHBpxa47Iz1td1K+2DjdqsO8gdJhRQLFThqFIpCqAj6CHYNu7gIHiyO1mOFvbhq fOHw== X-Gm-Message-State: AOAM533LgrM3oT4g+T2hjm34JVrzBn0/GRXFr5CJDU6pZ6z8IykXHavW UrNcjIpq8FdwOkQyoZICSqs= X-Google-Smtp-Source: ABdhPJz4C60O6AngmQ7b0XRWnnOu3FX9tZWFaN2kh5E01pnaNT245XTfipRbalOoeKn1vnPH5mlflw== X-Received: by 2002:a37:9c85:: with SMTP id f127mr7659821qke.283.1618230762320; Mon, 12 Apr 2021 05:32:42 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id v11sm7495148qtx.79.2021.04.12.05.32.41 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:32:42 -0700 (PDT) Date: Mon, 12 Apr 2021 09:32:39 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 2/4] Replace macro function by static inline function in file iss_ipipe.c Message-ID: <3d3facd1c3eef996d7e824917c19282bd1e1f041.1618230425.git.alinesantanacordeiro@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro Reported-by: kernel test robot --- drivers/staging/media/omap4iss/iss_ipipe.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_ipipe.c b/drivers/staging/media/omap4iss/iss_ipipe.c index 26be078..09c941c 100644 --- a/drivers/staging/media/omap4iss/iss_ipipe.c +++ b/drivers/staging/media/omap4iss/iss_ipipe.c @@ -38,9 +38,11 @@ static const unsigned int ipipe_fmts[] = { * * Also prints other debug information stored in the IPIPE module. */ -#define IPIPE_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)) +static inline ipipe_print_register(iss, name) +{ + dev_dbg(iss->dev, "###IPIPE " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPE, IPIPE_##name)); +} static void ipipe_print_status(struct iss_ipipe_device *ipipe) { @@ -48,16 +50,16 @@ static void ipipe_print_status(struct iss_ipipe_device *ipipe) dev_dbg(iss->dev, "-------------IPIPE Register dump-------------\n"); - IPIPE_PRINT_REGISTER(iss, SRC_EN); - IPIPE_PRINT_REGISTER(iss, SRC_MODE); - IPIPE_PRINT_REGISTER(iss, SRC_FMT); - IPIPE_PRINT_REGISTER(iss, SRC_COL); - IPIPE_PRINT_REGISTER(iss, SRC_VPS); - IPIPE_PRINT_REGISTER(iss, SRC_VSZ); - IPIPE_PRINT_REGISTER(iss, SRC_HPS); - IPIPE_PRINT_REGISTER(iss, SRC_HSZ); - IPIPE_PRINT_REGISTER(iss, GCK_MMR); - IPIPE_PRINT_REGISTER(iss, YUV_PHS); + ipipe_print_register(iss, SRC_EN); + ipipe_print_register(iss, SRC_MODE); + ipipe_print_register(iss, SRC_FMT); + ipipe_print_register(iss, SRC_COL); + ipipe_print_register(iss, SRC_VPS); + ipipe_print_register(iss, SRC_VSZ); + ipipe_print_register(iss, SRC_HPS); + ipipe_print_register(iss, SRC_HSZ); + ipipe_print_register(iss, GCK_MMR); + ipipe_print_register(iss, YUV_PHS); dev_dbg(iss->dev, "-----------------------------------------------\n"); } From patchwork Mon Apr 12 12:32:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 12197921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC15C433ED for ; Mon, 12 Apr 2021 12:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 383BD61288 for ; Mon, 12 Apr 2021 12:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241000AbhDLMdG (ORCPT ); Mon, 12 Apr 2021 08:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240999AbhDLMdF (ORCPT ); Mon, 12 Apr 2021 08:33:05 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38370C06174A; Mon, 12 Apr 2021 05:32:47 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id s5so4281886qkj.5; Mon, 12 Apr 2021 05:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ufJcji2+m5srymBQPjBrGfe67cUzEZqDOtn26wg7648=; b=qmZowgBMDh564wGGBAK1Y1joojizHF7rqrmZftAPLZxtvx27k/0X6Pgut82fixi5cf bA9LTq2CbQyy7wM83UFfKezSsxfv+WnJe/VKlPDE19Yes60j8YKthliqDOnVEjMk4bA2 heb1VIYTXB10TlggpqLE0O6Guif5cScxju6/dRAbnNVIVjggyRh9mMP/7hnBjnEvhc2T GASDkr+istx/XQJSrD/Y9BzVq4CUfwoyXq5Wv7l0q66Wk4pb1Qj/M4y0ieDcaxpVtM9Z LwgV+O8dqBJkR9OLyxWDW/zZ5A4k6IGVF+j99oWD4KrYc5PAMGLp3LrQDawSSlAlKxdZ /GVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ufJcji2+m5srymBQPjBrGfe67cUzEZqDOtn26wg7648=; b=sDgG+h9LhM3KfSMHUwI2NIiEAjtiNrZJ06C55sIoNkUyP9ALdKdXIFmnOKLAqwrumb AolB/c6AL4EeiWB17bQTnwyA0Q+BbM26Z0b+LweurKGhYdgHA8K78JiBrbqVWsruJKC6 cwESCcGM6zha1TqVm2UfQRxQfx5tYNn2VSMpDD815ioJSbm7YX1Voy5mCl/Vys55zrY6 dH2aKk7Ur3yuOo94YMrsT9OKJS+nG3uVWHN3qq7orXA3DVJWuQf+Aj+7yjr2SvNpR93L 4wFMuG12GjgHOITszR06q+uqmClbzydi3VunejCf5c9A3h4AygF2gY03irwJwvym9EmN kKKQ== X-Gm-Message-State: AOAM5317pQwLcyEUZSDn1MtEE7sr/xpCr0sGl76LtSG9kawzpljbSBRh 3VvBLPhKpKmfVd8bE0SMyb8= X-Google-Smtp-Source: ABdhPJwmIem/9PltNNtX361r7eJlfDfF/v4WGNSnhLLBJHmAaPropaUMqQ3u/AAtkSQzUNsEa02G7g== X-Received: by 2002:ae9:e015:: with SMTP id m21mr25440661qkk.420.1618230766509; Mon, 12 Apr 2021 05:32:46 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id f25sm6898173qtm.49.2021.04.12.05.32.45 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:32:46 -0700 (PDT) Date: Mon, 12 Apr 2021 09:32:43 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 3/4] Replace macro function by static inline function in file iss_ipipeif.c Message-ID: <808aaecdd2783cd1c216ba5ca3d592242731e73a.1618230425.git.alinesantanacordeiro@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro Reported-by: kernel test robot --- drivers/staging/media/omap4iss/iss_ipipeif.c | 62 +++++++++++++++------------- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_ipipeif.c b/drivers/staging/media/omap4iss/iss_ipipeif.c index c2978d0..3dc98f6 100644 --- a/drivers/staging/media/omap4iss/iss_ipipeif.c +++ b/drivers/staging/media/omap4iss/iss_ipipeif.c @@ -34,17 +34,23 @@ static const unsigned int ipipeif_fmts[] = { * * Also prints other debug information stored in the IPIPEIF module. */ -#define IPIPEIF_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name)) +static inline ipipeif_print_register(iss, name) +{ + dev_dbg(iss->dev, "###IPIPEIF " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_IPIPEIF, IPIPEIF_##name)); +} -#define ISIF_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name)) +static inline isif_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISIF " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_ISIF, ISIF_##name)); +} -#define ISP5_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name)) +static inline isp5_print_register(iss, name) +{ + dev_dbg(iss->dev, "###ISP5 " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_##name)); +} static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif) { @@ -52,25 +58,25 @@ static void ipipeif_print_status(struct iss_ipipeif_device *ipipeif) dev_dbg(iss->dev, "-------------IPIPEIF Register dump-------------\n"); - IPIPEIF_PRINT_REGISTER(iss, CFG1); - IPIPEIF_PRINT_REGISTER(iss, CFG2); - - ISIF_PRINT_REGISTER(iss, SYNCEN); - ISIF_PRINT_REGISTER(iss, CADU); - ISIF_PRINT_REGISTER(iss, CADL); - ISIF_PRINT_REGISTER(iss, MODESET); - ISIF_PRINT_REGISTER(iss, CCOLP); - ISIF_PRINT_REGISTER(iss, SPH); - ISIF_PRINT_REGISTER(iss, LNH); - ISIF_PRINT_REGISTER(iss, LNV); - ISIF_PRINT_REGISTER(iss, VDINT(0)); - ISIF_PRINT_REGISTER(iss, HSIZE); - - ISP5_PRINT_REGISTER(iss, SYSCONFIG); - ISP5_PRINT_REGISTER(iss, CTRL); - ISP5_PRINT_REGISTER(iss, IRQSTATUS(0)); - ISP5_PRINT_REGISTER(iss, IRQENABLE_SET(0)); - ISP5_PRINT_REGISTER(iss, IRQENABLE_CLR(0)); + ipipeif_print_register(iss, CFG1); + ipipeif_print_register(iss, CFG2); + + isif_print_register(iss, SYNCEN); + isif_print_register(iss, CADU); + isif_print_register(iss, CADL); + isif_print_register(iss, MODESET); + isif_print_register(iss, CCOLP); + isif_print_register(iss, SPH); + isif_print_register(iss, LNH); + isif_print_register(iss, LNV); + isif_print_register(iss, VDINT(0)); + isif_print_register(iss, HSIZE); + + isp5_print_register(iss, SYSCONFIG); + isp5_print_register(iss, CTRL); + isp5_print_register(iss, IRQSTATUS(0)); + isp5_print_register(iss, IRQENABLE_SET(0)); + isp5_print_register(iss, IRQENABLE_CLR(0)); dev_dbg(iss->dev, "-----------------------------------------------\n"); } From patchwork Mon Apr 12 12:32:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aline Santana Cordeiro X-Patchwork-Id: 12197923 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CD8C433B4 for ; Mon, 12 Apr 2021 12:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13E486134F for ; Mon, 12 Apr 2021 12:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241024AbhDLMdK (ORCPT ); Mon, 12 Apr 2021 08:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241008AbhDLMdJ (ORCPT ); Mon, 12 Apr 2021 08:33:09 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93953C06174A; Mon, 12 Apr 2021 05:32:51 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id h3so5340279qve.13; Mon, 12 Apr 2021 05:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5phIbF0SJjc1xH9SRYu5fVVE6GnlEyVLJ25MTvQm6gk=; b=RMkvkOHmjhdP17NNF9xXFBDWDRebXixHvYtL/zYG09ZsIpFem1DIF6bKoozhqZdD23 AE9dLc4KDSE8hxQBFDLOHi+Jt1h5Dck2uygvm2Q+uMZonR95B3gKv3WOCNLWDb7+I1IJ GYZ/DDE+wdYpyeC+GvfTfy0vGsHQP2PnYNropr8WYrsJ2n5KAQZy0eSuUwZlbpgKgLYP uz/tcrkrLmr41j3mKvGWx6ccgx5m4acSMhdsfZPWCzSn/MMQAtjMawdCc0Zo+hVCGxga ruPy3vVhLt0+NVbwdZpdqT8c/T6s5R+T0QvClbj0cKgMnGyIH9acQakYln3kqajqrUft 8/Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5phIbF0SJjc1xH9SRYu5fVVE6GnlEyVLJ25MTvQm6gk=; b=EwVV6Jh5GY1+O0dNKWVgYP/5Z3ZJt6tP6MpuTrwkZoSDhCSEhGx/7aF+HCiHSi2oru AgpmfGh3vhHyCsC+BKHATYmQqoBy4LnpSIg4QyudPMWNjdjty81GfKcCJMtAGgVuWElN VXFCyhtcKDt4etviKhzQDxhGBlGTDLUocv5v+G8P/TWfpA3WBGRK+JfcctAN61iQXozV 3kPmjrzjc0Pru63OoaYNdnjOwUY3H8l5Pe1qnSGaU8+jZKt7oF+8NAtjwqnoaQJmc3jz lSsf09o4MNo68qubpIBPpmhAmdvMY3ErsArMtJ7l5P2mpi3p/dylQ36tpj28Iran9uzt A+Qg== X-Gm-Message-State: AOAM5309V7cp5rluv774+ebirKoJ9/Vm45jLesFi/8s65C6x2kzHxz7G EBytfP1o/1NLzuiNRv5SMudG40RCxA4w07Hc X-Google-Smtp-Source: ABdhPJw4HVWeGXlu9QOMOgyquVblt75ZPUF7a8d8Y+kYW7EsfVl16gHHG6EF8ramsvU3XfSE6B3qfw== X-Received: by 2002:a05:6214:1470:: with SMTP id c16mr5841085qvy.60.1618230770882; Mon, 12 Apr 2021 05:32:50 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id i25sm7602148qka.38.2021.04.12.05.32.49 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 05:32:50 -0700 (PDT) Date: Mon, 12 Apr 2021 09:32:47 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [Outreachy kernel][PATCH 4/4] Replace macro function by static inline function in file iss_resizer.c Message-ID: <5bcb30af75bd8639f8771587fdcca8827b0ae013.1618230425.git.alinesantanacordeiro@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/omap4iss/iss_resizer.c | 126 ++++++++++++++------------- 1 file changed, 65 insertions(+), 61 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_resizer.c b/drivers/staging/media/omap4iss/iss_resizer.c index 3b6875c..7d16bde 100644 --- a/drivers/staging/media/omap4iss/iss_resizer.c +++ b/drivers/staging/media/omap4iss/iss_resizer.c @@ -30,13 +30,17 @@ static const unsigned int resizer_fmts[] = { * * Also prints other debug information stored in the RESIZER module. */ -#define RSZ_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name)) +static inline rsz_print_register(iss, name) +{ + dev_dbg(iss->dev, "###RSZ " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RSZ_##name)); +} -#define RZA_PRINT_REGISTER(iss, name)\ - dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", \ - iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name)) +static inline rza_print_register(iss, name) +{ + dev_dbg(iss->dev, "###RZA " #name "=0x%08x\n", + iss_reg_read(iss, OMAP4_ISS_MEM_ISP_RESIZER, RZA_##name)); +} static void resizer_print_status(struct iss_resizer_device *resizer) { @@ -44,61 +48,61 @@ static void resizer_print_status(struct iss_resizer_device *resizer) dev_dbg(iss->dev, "-------------RESIZER Register dump-------------\n"); - RSZ_PRINT_REGISTER(iss, SYSCONFIG); - RSZ_PRINT_REGISTER(iss, IN_FIFO_CTRL); - RSZ_PRINT_REGISTER(iss, FRACDIV); - RSZ_PRINT_REGISTER(iss, SRC_EN); - RSZ_PRINT_REGISTER(iss, SRC_MODE); - RSZ_PRINT_REGISTER(iss, SRC_FMT0); - RSZ_PRINT_REGISTER(iss, SRC_FMT1); - RSZ_PRINT_REGISTER(iss, SRC_VPS); - RSZ_PRINT_REGISTER(iss, SRC_VSZ); - RSZ_PRINT_REGISTER(iss, SRC_HPS); - RSZ_PRINT_REGISTER(iss, SRC_HSZ); - RSZ_PRINT_REGISTER(iss, DMA_RZA); - RSZ_PRINT_REGISTER(iss, DMA_RZB); - RSZ_PRINT_REGISTER(iss, DMA_STA); - RSZ_PRINT_REGISTER(iss, GCK_MMR); - RSZ_PRINT_REGISTER(iss, GCK_SDR); - RSZ_PRINT_REGISTER(iss, IRQ_RZA); - RSZ_PRINT_REGISTER(iss, IRQ_RZB); - RSZ_PRINT_REGISTER(iss, YUV_Y_MIN); - RSZ_PRINT_REGISTER(iss, YUV_Y_MAX); - RSZ_PRINT_REGISTER(iss, YUV_C_MIN); - RSZ_PRINT_REGISTER(iss, YUV_C_MAX); - RSZ_PRINT_REGISTER(iss, SEQ); - - RZA_PRINT_REGISTER(iss, EN); - RZA_PRINT_REGISTER(iss, MODE); - RZA_PRINT_REGISTER(iss, 420); - RZA_PRINT_REGISTER(iss, I_VPS); - RZA_PRINT_REGISTER(iss, I_HPS); - RZA_PRINT_REGISTER(iss, O_VSZ); - RZA_PRINT_REGISTER(iss, O_HSZ); - RZA_PRINT_REGISTER(iss, V_PHS_Y); - RZA_PRINT_REGISTER(iss, V_PHS_C); - RZA_PRINT_REGISTER(iss, V_DIF); - RZA_PRINT_REGISTER(iss, V_TYP); - RZA_PRINT_REGISTER(iss, V_LPF); - RZA_PRINT_REGISTER(iss, H_PHS); - RZA_PRINT_REGISTER(iss, H_DIF); - RZA_PRINT_REGISTER(iss, H_TYP); - RZA_PRINT_REGISTER(iss, H_LPF); - RZA_PRINT_REGISTER(iss, DWN_EN); - RZA_PRINT_REGISTER(iss, SDR_Y_BAD_H); - RZA_PRINT_REGISTER(iss, SDR_Y_BAD_L); - RZA_PRINT_REGISTER(iss, SDR_Y_SAD_H); - RZA_PRINT_REGISTER(iss, SDR_Y_SAD_L); - RZA_PRINT_REGISTER(iss, SDR_Y_OFT); - RZA_PRINT_REGISTER(iss, SDR_Y_PTR_S); - RZA_PRINT_REGISTER(iss, SDR_Y_PTR_E); - RZA_PRINT_REGISTER(iss, SDR_C_BAD_H); - RZA_PRINT_REGISTER(iss, SDR_C_BAD_L); - RZA_PRINT_REGISTER(iss, SDR_C_SAD_H); - RZA_PRINT_REGISTER(iss, SDR_C_SAD_L); - RZA_PRINT_REGISTER(iss, SDR_C_OFT); - RZA_PRINT_REGISTER(iss, SDR_C_PTR_S); - RZA_PRINT_REGISTER(iss, SDR_C_PTR_E); + rsz_print_register(iss, SYSCONFIG); + rsz_print_register(iss, IN_FIFO_CTRL); + rsz_print_register(iss, FRACDIV); + rsz_print_register(iss, SRC_EN); + rsz_print_register(iss, SRC_MODE); + rsz_print_register(iss, SRC_FMT0); + rsz_print_register(iss, SRC_FMT1); + rsz_print_register(iss, SRC_VPS); + rsz_print_register(iss, SRC_VSZ); + rsz_print_register(iss, SRC_HPS); + rsz_print_register(iss, SRC_HSZ); + rsz_print_register(iss, DMA_RZA); + rsz_print_register(iss, DMA_RZB); + rsz_print_register(iss, DMA_STA); + rsz_print_register(iss, GCK_MMR); + rsz_print_register(iss, GCK_SDR); + rsz_print_register(iss, IRQ_RZA); + rsz_print_register(iss, IRQ_RZB); + rsz_print_register(iss, YUV_Y_MIN); + rsz_print_register(iss, YUV_Y_MAX); + rsz_print_register(iss, YUV_C_MIN); + rsz_print_register(iss, YUV_C_MAX); + rsz_print_register(iss, SEQ); + + rza_print_register(iss, EN); + rza_print_register(iss, MODE); + rza_print_register(iss, 420); + rza_print_register(iss, I_VPS); + rza_print_register(iss, I_HPS); + rza_print_register(iss, O_VSZ); + rza_print_register(iss, O_HSZ); + rza_print_register(iss, V_PHS_Y); + rza_print_register(iss, V_PHS_C); + rza_print_register(iss, V_DIF); + rza_print_register(iss, V_TYP); + rza_print_register(iss, V_LPF); + rza_print_register(iss, H_PHS); + rza_print_register(iss, H_DIF); + rza_print_register(iss, H_TYP); + rza_print_register(iss, H_LPF); + rza_print_register(iss, DWN_EN); + rza_print_register(iss, SDR_Y_BAD_H); + rza_print_register(iss, SDR_Y_BAD_L); + rza_print_register(iss, SDR_Y_SAD_H); + rza_print_register(iss, SDR_Y_SAD_L); + rza_print_register(iss, SDR_Y_OFT); + rza_print_register(iss, SDR_Y_PTR_S); + rza_print_register(iss, SDR_Y_PTR_E); + rza_print_register(iss, SDR_C_BAD_H); + rza_print_register(iss, SDR_C_BAD_L); + rza_print_register(iss, SDR_C_SAD_H); + rza_print_register(iss, SDR_C_SAD_L); + rza_print_register(iss, SDR_C_OFT); + rza_print_register(iss, SDR_C_PTR_S); + rza_print_register(iss, SDR_C_PTR_E); dev_dbg(iss->dev, "-----------------------------------------------\n"); }