From patchwork Fri Nov 23 12:00:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauro Carvalho Chehab X-Patchwork-Id: 10695681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1C54415A7 for ; Fri, 23 Nov 2018 12:00:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 08A0E2BA92 for ; Fri, 23 Nov 2018 12:00:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0C9E2C2DA; Fri, 23 Nov 2018 12:00:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A4642BA92 for ; Fri, 23 Nov 2018 12:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503914AbeKWWop (ORCPT ); Fri, 23 Nov 2018 17:44:45 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38116 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503912AbeKWWop (ORCPT ); Fri, 23 Nov 2018 17:44:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cPvonoCPuDIwcOze98co2Me3eD1emMo8op8fhUXLE0I=; b=rpXnfeXKwLMa6sE6tz+qGESUE Gp5XfYOtG5+TfZu028//n+liGnP117PQAkQDfNx1WPV/cqfam3k5EFt9wLDxFeXOz8csrahBBpR+Y BCRL1Wm6f/vjXt3W5aZJQup6+KlRrbgTSQREdSljWRE2ruMG5qLVSc25m6qn7e/4HHcyq91TSC9k2 IBnTFqb3t7vfEw7A6W6ubs6pM8l+FqstTY6RfbeMQd6aJizPANpksN3ffT5GQW5PE1yizUKLPwiok tFwtULJCTm3nBA3nEStzIpj1r2UhBdHjhiAvEIU9liQ6ldHsipsIHt6XuRRcFKQ6vSdoOTfVEiUA6 TPmNvdgGQ==; Received: from 201.47.163.210.dynamic.adsl.gvt.net.br ([201.47.163.210] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gQA8d-00081a-8Q; Fri, 23 Nov 2018 12:00:47 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.91) (envelope-from ) id 1gQA8a-00018f-J7; Fri, 23 Nov 2018 07:00:44 -0500 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab , Ettore Chimenti Subject: [PATCH] media: seco-cec: declare ops as static const Date: Fri, 23 Nov 2018 07:00:43 -0500 Message-Id: X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As warned by smatch: drivers/media/platform/seco-cec/seco-cec.c:338:21: warning: symbol 'secocec_cec_adap_ops' was not declared. Should it be static? This struct should be static. Also, it is const, so declare it as such. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/seco-cec/seco-cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/seco-cec/seco-cec.c b/drivers/media/platform/seco-cec/seco-cec.c index 8308873c53ab..01ada99de723 100644 --- a/drivers/media/platform/seco-cec/seco-cec.c +++ b/drivers/media/platform/seco-cec/seco-cec.c @@ -335,7 +335,7 @@ static void secocec_rx_done(struct cec_adapter *adap, u16 status_val) smb_wr16(SECOCEC_STATUS, status_val); } -struct cec_adap_ops secocec_cec_adap_ops = { +static const struct cec_adap_ops secocec_cec_adap_ops = { /* Low-level callbacks */ .adap_enable = secocec_adap_enable, .adap_log_addr = secocec_adap_log_addr,