From patchwork Mon Apr 19 16:33:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12212281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09037C433B4 for ; Mon, 19 Apr 2021 16:33:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF7C6610A1 for ; Mon, 19 Apr 2021 16:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238910AbhDSQeM (ORCPT ); Mon, 19 Apr 2021 12:34:12 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38522 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhDSQeM (ORCPT ); Mon, 19 Apr 2021 12:34:12 -0400 Received: from mail-ej1-f69.google.com ([209.85.218.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYWqC-00027f-VK for linux-pm@vger.kernel.org; Mon, 19 Apr 2021 16:33:41 +0000 Received: by mail-ej1-f69.google.com with SMTP id w2-20020a1709062f82b0290378745f26d5so3830385eji.6 for ; Mon, 19 Apr 2021 09:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=FQxWDozA0tVYdPvSIjWgb2svpfnzLps1lAqPUiFgCgM=; b=t3+78P80OGkEpYEiMewTsnqgniY4N11Sp8B6v14KWHYnu5Dy9EBTg81vXaJQi6fD8J jjbvYX7DQVn/ySjm6MbZ8/gcbieW99gZg3JqS1MdTatlJ9SO18zOnv8/QaobWdKQ3HN/ 88P4KduKcY+SizFa0x+fRBVonLcRaikoNlp4bPep2dpBHJETvbXoMvSEscZLvNZ15RKL reJtbo1CnHrFA4wBpfnYrqViy+Lq/ALdUFZ7UpoyozSY49TvlnW7a7gbY1CtRJvls6cA tHNPMLk9FVCqPS0J/jqY6lO8l6F2Um8dMxP67g0PLVxt4Bs1v7GwzBBlCnAxAeZSKdA/ BSBQ== X-Gm-Message-State: AOAM531QDKFKCCuWHtg83CKQ2y5d6KhdNlFd7h7yIjXtBSXyaMZ4I7Nf 0i+pJ1w0wfiV3Mh/VDsuE4coGQeocS8Tm7kUA+7Ek6n+kDLmxHMyozYM2FHJ+8PLhjS/eqtiDNd ExepNqu/sxXshbiSkTjl+vtZ/wMX3LWBwEgxV X-Received: by 2002:a17:906:747:: with SMTP id z7mr23437096ejb.192.1618850020677; Mon, 19 Apr 2021 09:33:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS/LNiUGt0EvGgoYA868p7AY80Rrv/sN3QJhQcSvtrE8Pou1sjnlbZEZD3aRmOBpMQwnAgzg== X-Received: by 2002:a17:906:747:: with SMTP id z7mr23437085ejb.192.1618850020537; Mon, 19 Apr 2021 09:33:40 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id d10sm10884257ejw.125.2021.04.19.09.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:33:40 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] power: supply: max14577: remove unneeded variable initialization Date: Mon, 19 Apr 2021 18:33:32 +0200 Message-Id: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The local 'current_bits' variable does not have to be initialized because all cases in following switch() either return or initialize it. Addresses-Coverity: Unused value Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/max14577_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c index dcedae18d7be..f244cd902eb9 100644 --- a/drivers/power/supply/max14577_charger.c +++ b/drivers/power/supply/max14577_charger.c @@ -261,7 +261,7 @@ static int max14577_init_constant_voltage(struct max14577_charger *chg, static int max14577_init_eoc(struct max14577_charger *chg, unsigned int uamp) { - unsigned int current_bits = 0xf; + unsigned int current_bits; u8 reg_data; switch (chg->max14577->dev_type) { From patchwork Mon Apr 19 16:33:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12212283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2F4C43460 for ; Mon, 19 Apr 2021 16:33:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 603CF611F2 for ; Mon, 19 Apr 2021 16:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238981AbhDSQeN (ORCPT ); Mon, 19 Apr 2021 12:34:13 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38529 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238885AbhDSQeM (ORCPT ); Mon, 19 Apr 2021 12:34:12 -0400 Received: from mail-ej1-f70.google.com ([209.85.218.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYWqE-00028D-Al for linux-pm@vger.kernel.org; Mon, 19 Apr 2021 16:33:42 +0000 Received: by mail-ej1-f70.google.com with SMTP id d11-20020a170906370bb029037c87968c04so3865196ejc.17 for ; Mon, 19 Apr 2021 09:33:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dJFDAj6TYp7FZZ9Zf4ZhG/lOPFtwU6nBh8dkTxsEpU8=; b=R77ReJEVxS0Khd9I9dxBMqwKmX54jCy/qscvPLidnazR7gBBJTBGZPZJ9C5lGOLYsi LZeTN0j/gA1mzhPM8EjCBQNKYJ5GDTBGINtyimRMbiNwcjGf31I1XkHKjDC+BoQ0wvQC Y/CXBMDuLmpjj82ttxVwfGe/zsTEn2fwJ5cVHapnHkbRpwHKPtQ83O+xfkk1UOMkHGGR 3m8GmcLDL7GEE9LLvLxB/5fY23LLDuD7dZ3MMOT8FQUdjGc6AiI1cYVjf3Db0mQx755l 3vk6H7Xd+g6D7DVSDC0wrxOotRYijTFWCUS0iOIo6Vqe4tJRfF0C1qUopow+rQJbyYS0 ImBA== X-Gm-Message-State: AOAM530z1TJkTij6h0Ncb0/R9k6TFxKhsXa317tr2+00FHo8vb8OZffL jebnE/DCeLU4/30ofT03Vz9HpOe3hAORZQVAkjzEf3FObWjMsplmLHxZqDUDVVbQDJftgm69f+O 6WkV4oaqPHuhEij5wGjHXa8Gs9f7nJZMae90o X-Received: by 2002:a17:906:85c1:: with SMTP id i1mr23186445ejy.216.1618850021747; Mon, 19 Apr 2021 09:33:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUor1TH50RdkNQ0brGoOfZsltUgbORXKk/u2PaE6e5BIAtrg/yKQPZA5J2g9XQ7h+mSE+6NA== X-Received: by 2002:a17:906:85c1:: with SMTP id i1mr23186432ejy.216.1618850021640; Mon, 19 Apr 2021 09:33:41 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id d10sm10884257ejw.125.2021.04.19.09.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:33:40 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] power: supply: max17040: handle device_property_read_u8_array() failure Date: Mon, 19 Apr 2021 18:33:33 +0200 Message-Id: <20210419163336.64075-2-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> References: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The device_property_read_u8_array() call should not fail because it is preceded with device_property_count_u8() and check for number of readable u8 values. However the code is more obvious and easier to read if the return value of device_property_read_u8_array() is checked. Otherwise reader needs to investigate whether really there is no risk of using random stack values of 'rcomp' variable. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/max17040_battery.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index d956c67d5155..d2053cd0bd13 100644 --- a/drivers/power/supply/max17040_battery.c +++ b/drivers/power/supply/max17040_battery.c @@ -268,11 +268,10 @@ static int max17040_get_of_data(struct max17040_chip *chip) rcomp_len = device_property_count_u8(dev, "maxim,rcomp"); chip->rcomp = MAX17040_RCOMP_DEFAULT; if (rcomp_len == data->rcomp_bytes) { - device_property_read_u8_array(dev, "maxim,rcomp", - rcomp, rcomp_len); - chip->rcomp = rcomp_len == 2 ? - rcomp[0] << 8 | rcomp[1] : - rcomp[0] << 8; + if (!device_property_read_u8_array(dev, "maxim,rcomp", + rcomp, rcomp_len)) + chip->rcomp = rcomp_len == 2 ? rcomp[0] << 8 | rcomp[1] : + rcomp[0] << 8; } else if (rcomp_len > 0) { dev_err(dev, "maxim,rcomp has incorrect length\n"); return -EINVAL; From patchwork Mon Apr 19 16:33:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12212287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3E5C433B4 for ; Mon, 19 Apr 2021 16:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81A51610A1 for ; Mon, 19 Apr 2021 16:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239098AbhDSQeP (ORCPT ); Mon, 19 Apr 2021 12:34:15 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38535 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238974AbhDSQeO (ORCPT ); Mon, 19 Apr 2021 12:34:14 -0400 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYWqF-00028Q-E1 for linux-pm@vger.kernel.org; Mon, 19 Apr 2021 16:33:43 +0000 Received: by mail-ed1-f70.google.com with SMTP id n18-20020a0564020612b02903853320059eso2472296edv.0 for ; Mon, 19 Apr 2021 09:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=snr6bOpKVS1nofF6NBC7+ehvgRwGojW903lwvMJmgjU=; b=rcAM3evE75k+ogzrEUdZZBX5boBlLjgqAI0HQlSsRcPkiWHQdCKE7oPVK722KX0slp IccZSIqVUaaqejB1Sz7oQ9zuU/XZRvuEAszFcMV9N9KvfHYPI8MUzIse5dQ+HQArjCiR q+50oSfkE6nRNEL8sP6evXCUckw5ZEBMj67kqM4fbsdIaz+/MN2sTSozJhWvFlvj3QRl LUd97tJF9/dUFDdFuiMIm/XpIHSJwqnTuxS0o4SvXJX6NC/kDkGr9QMK4gZl5cxtZHqt Pi+iOZtjns8QierX7H22EJPIpsZ5mv329um/a2bVksir4LD9jcQza+jLxX87IY31aPHm 1jHQ== X-Gm-Message-State: AOAM532oLTD292Ul3h5XfMCwuhAwIi61KAuiAesenIZ0iZNbEIWRXapn 8ToUmItRc0eu4xIvY/j2bPjFKO0dMd8O3x7lINXRT49G88qkcf8vOtbCevD8NLrO8idfoM/kf9D KwQBEkehVTl9odxisY7ZdfqYPFuSZvzDL/bKE X-Received: by 2002:aa7:d85a:: with SMTP id f26mr15217586eds.305.1618850023133; Mon, 19 Apr 2021 09:33:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwxaqu8Nz38y932354Y2gcGKu9I2RvQcNCKssKJOBhk4VKgjSNbYz6iXMUKUCz+kiKZ1IHPQ== X-Received: by 2002:aa7:d85a:: with SMTP id f26mr15217572eds.305.1618850023015; Mon, 19 Apr 2021 09:33:43 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id d10sm10884257ejw.125.2021.04.19.09.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:33:41 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] power: supply: max17040: remove unneeded double cast Date: Mon, 19 Apr 2021 18:33:34 +0200 Message-Id: <20210419163336.64075-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> References: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org There is no need for double explicit cast from of_device_get_match_data() (uintptr_t and then to target enum) because implicit conversion from uintptr_t to enum is straightforward (uintptr_t is a integer type). Signed-off-by: Krzysztof Kozlowski --- gcc v9.3.0 W=1 does not complain after removal of cast. --- drivers/power/supply/max17040_battery.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/power/supply/max17040_battery.c b/drivers/power/supply/max17040_battery.c index d2053cd0bd13..1aab868adabf 100644 --- a/drivers/power/supply/max17040_battery.c +++ b/drivers/power/supply/max17040_battery.c @@ -486,8 +486,7 @@ static int max17040_probe(struct i2c_client *client, ret = max17040_get_of_data(chip); if (ret) return ret; - chip_id = (enum chip_id) (uintptr_t) - of_device_get_match_data(&client->dev); + chip_id = (uintptr_t)of_device_get_match_data(&client->dev); } chip->data = max17040_family[chip_id]; From patchwork Mon Apr 19 16:33:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12212285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F20C43462 for ; Mon, 19 Apr 2021 16:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8ECB61026 for ; Mon, 19 Apr 2021 16:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239042AbhDSQeP (ORCPT ); Mon, 19 Apr 2021 12:34:15 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38538 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238955AbhDSQeO (ORCPT ); Mon, 19 Apr 2021 12:34:14 -0400 Received: from mail-ej1-f71.google.com ([209.85.218.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYWqG-00028i-8g for linux-pm@vger.kernel.org; Mon, 19 Apr 2021 16:33:44 +0000 Received: by mail-ej1-f71.google.com with SMTP id o25-20020a1709061d59b029037c94676df5so3865904ejh.7 for ; Mon, 19 Apr 2021 09:33:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZS3kDXJbb+yWpJYeuhePkBZuXsYPhImHPxwdAy9xHJY=; b=W7oYkfjek15TcQMziqo3qJ+5IBPl8jh+WGE5OHEWDHTO2W6CgEliLN9G9GDl44OrN9 MrrCADVAdih/BRtTxH4emZmQQWmmW9/kMYHX6dDcGCr/hJ/xD3kbeBTSIPWJIBGeC/Ha EgdO7DJyQfxZfpKVXUDD0TdnVUVla0jcEsYekvft/rCjnOn8dZYInSzbF7d4pewolpTk 8FTc9Ey0ujlSv3OWUCVOGgknSKPNfzhudkSeNIfyWFpsfRBxPSGYxOaeaBNsrVCWIvKQ 8tVqrrERjoxoT8BNjpN6MqRENDrSHQu0F9VnWkCHib+w6Gnwx63DT/NqxOPy2TG2/QLd 6VbQ== X-Gm-Message-State: AOAM530AiYso4jGf348zNdnUbkIOC7Id8XLHKTK9Oq+LH3P1bOq2o4mC PSzr+G49UwiJT2FKNbB1FuX/x9bkSIAQ7Zz2t4gSgq6gnvDwyiUhTY4af2hECGgUey+0gOmNv2M vPhxqH0claGHFhl/djmBhdjFFeKsQxw+dTOfF X-Received: by 2002:a05:6402:274d:: with SMTP id z13mr27160882edd.344.1618850024045; Mon, 19 Apr 2021 09:33:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0Nlz3x2uIOlIMFvCXOrt3t1Rrh6I6eJcYBGtc1yfXtuXqnznZudlXWhga/rZMGGak1BMwDg== X-Received: by 2002:a05:6402:274d:: with SMTP id z13mr27160869edd.344.1618850023920; Mon, 19 Apr 2021 09:33:43 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id d10sm10884257ejw.125.2021.04.19.09.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:33:43 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] power: supply: act8945a: correct kerneldoc Date: Mon, 19 Apr 2021 18:33:35 +0200 Message-Id: <20210419163336.64075-4-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> References: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Remove incorrect kerneldoc marker to fix W=1 warning: drivers/power/supply/act8945a_charger.c:22: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/act8945a_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/act8945a_charger.c b/drivers/power/supply/act8945a_charger.c index 5f3eb6941d05..e9b5f4283772 100644 --- a/drivers/power/supply/act8945a_charger.c +++ b/drivers/power/supply/act8945a_charger.c @@ -18,7 +18,7 @@ static const char *act8945a_charger_model = "ACT8945A"; static const char *act8945a_charger_manufacturer = "Active-semi"; -/** +/* * ACT8945A Charger Register Map */ From patchwork Mon Apr 19 16:33:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12212289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702FDC433ED for ; Mon, 19 Apr 2021 16:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FD5E6100B for ; Mon, 19 Apr 2021 16:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239229AbhDSQeS (ORCPT ); Mon, 19 Apr 2021 12:34:18 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38547 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239099AbhDSQeQ (ORCPT ); Mon, 19 Apr 2021 12:34:16 -0400 Received: from mail-ej1-f71.google.com ([209.85.218.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYWqH-00029H-GN for linux-pm@vger.kernel.org; Mon, 19 Apr 2021 16:33:45 +0000 Received: by mail-ej1-f71.google.com with SMTP id j25-20020a1709060519b029037cb8ca241aso3847497eja.19 for ; Mon, 19 Apr 2021 09:33:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tffa8FxLRD95q68BP7WAuHuH/QuQK9CLj68muj3l3Us=; b=B4vyaMo/ht8MjBocEBJGIGEoGfRKwN2arJuFuqKezZK8loDauGwbiG3TH5S8aslJTe VZ9dV063mdWPhwhvOLjr5rUcJ3mgEGa/Fh2ot4lnqrTEqrxMgwj1mSzlsPc1BmWTVSwf qzAqJ8bdyIZJ14xotkp+B/az7MG7jqz0OcGdr9fI0qhBce/S9N51eeWa3QqJ6dKTDPM8 3CALqnHGjImOmmYj2pOyTUyahtsJMTGrxeXpl9TR5XKFmvURTET/Nji+ciRmNkvpZ2oa 4RByMUJ0QfjRqIL6CP+ArpgUDUtfz7Lgjp5J9IOk4v9HuYYnVMOotwrwIBqJNGJ4bBtg xwMQ== X-Gm-Message-State: AOAM53012AUErcPVRvLaoupesqDe8tbcVdB0aWCia1R4J+s+ZHgUJjU4 DlOErEeg6BbG0Zt5GzaJ+NauuaRhFFkesiBN/vYibrC57NbBMGg6DC/USzluulkVElHH+xlaBSK xBgsKX9s/El6B/YwKuLAVF8sB2RyeQTDJrcMZ X-Received: by 2002:a17:906:8407:: with SMTP id n7mr22280296ejx.264.1618850025028; Mon, 19 Apr 2021 09:33:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIPWR8ANiEgnuHcBPUQLALdaXMV0Sh7rj34LKbSDdNWxalGwJMT5vUSg1W9Vn8ufz87Al0uQ== X-Received: by 2002:a17:906:8407:: with SMTP id n7mr22280287ejx.264.1618850024906; Mon, 19 Apr 2021 09:33:44 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-180-75.adslplus.ch. [188.155.180.75]) by smtp.gmail.com with ESMTPSA id d10sm10884257ejw.125.2021.04.19.09.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 09:33:44 -0700 (PDT) From: Krzysztof Kozlowski To: Sebastian Reichel , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] power: supply: bq256xx: add kerneldoc for structure members Date: Mon, 19 Apr 2021 18:33:36 +0200 Message-Id: <20210419163336.64075-5-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> References: <20210419163336.64075-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Document members of structure to fix W=1 warnings like: drivers/power/supply/bq256xx_charger.c:240: warning: Function parameter or member 'charger' not described in 'bq256xx_device' Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/bq256xx_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/bq256xx_charger.c b/drivers/power/supply/bq256xx_charger.c index 2ab5ba4af92b..f501ecd49202 100644 --- a/drivers/power/supply/bq256xx_charger.c +++ b/drivers/power/supply/bq256xx_charger.c @@ -202,6 +202,8 @@ enum bq256xx_id { * @client: i2c client structure * @regmap: register map structure * @dev: device structure + * @charger: power supply registered for the charger + * @battery: power supply registered for the battery * @lock: mutex lock structure * * @usb2_phy: usb_phy identifier