From patchwork Tue Apr 20 21:49:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 12215083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1217C433ED for ; Tue, 20 Apr 2021 21:52:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21CE261411 for ; Tue, 20 Apr 2021 21:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21CE261411 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c0IA0NTTdFkuOCc6lnhsE7Z2lWNYeiNwTy8bGRheWX4=; b=LsWLQQO1xKZjtemKxVTUyydoH MnjCrTE9xRqc96BnoY6QD5IAXRqrKbpl4La6ztgZAWje6S3JgpgDCEC4VCE7QEw/D55PkZzEERlmW iBwZj7bPkK6hADh+aEIsiDRNCZHVQXQzZibaOBPcU//c8+WTH4OOPz5tqJ4EXL5VYd/GvlDNHsSWw u3XKswDLlkHqwhvW9Kj+L0ZNRLQ+YxGmEacwJmFU4zfDKk5QEhTP9x2O+JPYYuIPQ9KicNtsRgmd9 MpGU3xEjYjHbLUbF/JAQpViTiYkav10DAtnbj4C6NUNJcLKsMiiHzjE4PnVb4Pgk8KRA0vz3DDrOa An9MfdheQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYyGS-00D7EX-Rx; Tue, 20 Apr 2021 21:50:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYyG7-00D7Ca-OZ for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 21:50:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=1ZsSEfYFS+RwbYwV5tkUpZ4YID r8ayYwnkvu/HH+TgNpVtIiezOpnFhiqgMGaY02P+Gt+K2VQXjqDA+wzJ62bZTr4qdBWf2eEvrdhr5 pqonrGWVMwMIhO6tAZZAIOfVTJD7uj+dNByCGjaySK3L3v99RWrGdhnhtJOmjPD8shfQB5SIz++le OIiM/gZUl7ayF8ZT9QWMGYWN3IHGZ4Icbw+HVzn39XjM1E/HC34gEt2YBSEaoz76X3+z53nWO+o5T 2lrNt7kl3aXC0M25khx6iheJBtttWPFzdLcTu15aWycjYHoEv1G/Fvcu1N6o1wfXYbV7ugPBlfimU rFUqx2Dg==; Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYyG2-00CRPC-Ng for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 21:50:14 +0000 Received: by mail-pl1-x635.google.com with SMTP id e2so16125271plh.8 for ; Tue, 20 Apr 2021 14:50:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=Ec+7pf8QFOQGETswMvOwtCRnFSRRBh6lgonx4jun1dk6+8y4PtaKE2ursXiRrg09fb oaXLDuTuNy5OI63T9ZRfLkbe6d9Jiccq/+/AViB8L7ikRzkcy2FO2GXqXL9w7nesdi/K tvVxkFehtsUBOhsmh2vqumM4MHbE1anmyBtjU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=br6Q9nB7EzUYGhvzSIch8sIAGewUeFhxJoVc038K6FM=; b=BNQPvYdK/NAg0PqjfAVLp++9yOaCs6CQuusoZLkw2ii4V82Sav7EV/DjBQCAbTX8UQ zzQl2dLjVDbYSWdy87/Y3V/QzKE/dochVcJPukHgsbAJx8o33ThbmKR2R/Q4HF9F7vj8 onXi665ydK1WtibQMPhmzPEFGrksam240EGQ2BMGD+ekGOuxb0VI2b7QiI0M0OVV9S/p EgEP2zsr9Qq9Atwdv9RFDJShpK/4fnC4GbMgqFT+9WQHg84ZFaFESgL8Une6hHeSp6/2 sTn2U1Z4OURs0eMXrUqymUxVAUXo++rAmIg9H8AYFOLtaLD1yqy9/hcZcOmSwAt8uTVg faZQ== X-Gm-Message-State: AOAM532pqXiKnA1ha3J8aFKMO1Pck5QVPMWcTcHOUjZuVbNS2MhQgejd M1Se0IXQBxoGEOcottBFkN8bjA== X-Google-Smtp-Source: ABdhPJzuTnBpFyGRqoJZe6cfnkCyoMW/W7XlUttLH2iWotczB0vRzufkAo6PBx/lCSNDhKMfGxFErg== X-Received: by 2002:a17:902:70c5:b029:ec:9a57:9cc8 with SMTP id l5-20020a17090270c5b02900ec9a579cc8mr13011264plt.73.1618955409659; Tue, 20 Apr 2021 14:50:09 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:201:bf8b:4b8b:2315:3719]) by smtp.gmail.com with ESMTPSA id c21sm31481pfo.91.2021.04.20.14.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 14:50:09 -0700 (PDT) From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Petr Mladek , Steven Rostedt , Andy Shevchenko , Matthew Wilcox Subject: [PATCH v5 06/13] arm64: stacktrace: Use %pSb for backtrace printing Date: Tue, 20 Apr 2021 14:49:56 -0700 Message-Id: <20210420215003.3510247-7-swboyd@chromium.org> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210420215003.3510247-1-swboyd@chromium.org> References: <20210420215003.3510247-1-swboyd@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_145010_797388_6AF65F2E X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Let's use the new printk format to print the stacktrace entry when printing a backtrace to the kernel logs. This will include any module's build ID[1] in it so that offline/crash debugging can easily locate the debuginfo for a module via something like debuginfod[2]. Cc: Catalin Marinas Cc: Will Deacon Cc: Cc: Jiri Olsa Cc: Alexei Starovoitov Cc: Jessica Yu Cc: Evan Green Cc: Hsin-Yi Wang Cc: Petr Mladek Cc: Steven Rostedt Cc: Andy Shevchenko Cc: Matthew Wilcox Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1] Link: https://sourceware.org/elfutils/Debuginfod.html [2] Signed-off-by: Stephen Boyd Acked-by: Catalin Marinas --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index ad20981dfda4..9d38da01ff98 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -129,7 +129,7 @@ NOKPROBE_SYMBOL(walk_stackframe); static void dump_backtrace_entry(unsigned long where, const char *loglvl) { - printk("%s %pS\n", loglvl, (void *)where); + printk("%s %pSb\n", loglvl, (void *)where); } void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,